openstackgerrit | Merged openstack/horizon master: add dns_name and dns_domain into admin column https://review.openstack.org/585639 | 00:02 |
---|---|---|
*** gyee has quit IRC | 00:38 | |
amotoki | flwang: as of now, we cannot control whether a panel is displayed based on users's role. | 00:53 |
amotoki | flwang: panels in the project dashboard have no policy_rules now. potentially horizon panels can check policies for read operations (though a discussion is needed on what policies should be referred to) | 00:55 |
openstackgerrit | Merged openstack/horizon master: fix bug of fail to create volume type encryption from dashboard https://review.openstack.org/585629 | 01:16 |
flwang | amotoki: ok, then is it possible to determine if a service panel is displayed or not based on the keystone catalog? | 01:26 |
flwang | e.g. if the service is not in keystone catalog, the panel won't be displayed | 01:26 |
*** btully has joined #openstack-horizon | 01:32 | |
*** btully has quit IRC | 01:36 | |
amotoki | flwang: this is what the current horizon does. | 01:49 |
flwang | amotoki: does pike support that? | 01:50 |
amotoki | flwang: for example, you can find "permissions = ('openstack.services.compute',)" in openstack_dashboard/dashboards/project/instances/panel.py | 01:50 |
flwang | amotoki: cool | 01:51 |
amotoki | flwang: it exists from long ago so I think it works for pike | 01:52 |
flwang | amotoki: does that mean we do need similar 'permissions' attribute for the panel we want to control ? like https://github.com/openstack/magnum-ui/blob/master/magnum_ui/content/clusters/panel.py | 01:52 |
*** dave-mccowan has quit IRC | 02:57 | |
*** dklyle has quit IRC | 02:58 | |
*** zhurong has joined #openstack-horizon | 03:01 | |
adriant | flwang, amotoki: I'm confused, I'm fairly sure that if you edited (or wrote your own) policy files for horizon, and set a policy rule for the panel, you can easily hide/show panels based on role | 03:27 |
adriant | e.g. https://github.com/openstack/adjutant-ui/blob/master/adjutant_ui/content/tasks/panel.py#L23 and the note about editing the keystone policy file here: https://github.com/openstack/adjutant-ui/blob/master/doc/source/installation.rst | 03:29 |
adriant | isn't that hiding a panel based on role? | 03:29 |
flwang | adriant: that's the one i was asking, thanks | 03:48 |
flwang | amotoki: ^ thoughts? | 03:48 |
*** zhurong has quit IRC | 04:20 | |
amotoki | flwang: it depends on your point of view. as developer, you can control a panel based on service and/or policy. | 04:49 |
amotoki | flwang: as operators, you cannot define panel permission as you want. | 04:49 |
flwang | amotoki: thanks, that makes sense | 04:50 |
amotoki | flwang: for example, http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/identity/projects/panel.py | 04:51 |
*** hoonetorg has quit IRC | 05:31 | |
*** e0ne has joined #openstack-horizon | 05:40 | |
*** ChanServ sets mode: +o e0ne | 05:40 | |
e0ne | amotoki: hi Akihiro. are you going to create a patch for https://bugs.launchpad.net/horizon/+bug/1785178 before rc1? | 05:41 |
openstack | Launchpad bug 1785178 in OpenStack Dashboard (Horizon) "default_cgsnapshot_type should not be listed in "Group Type" selection in "Create Group" form" [High,New] | 05:41 |
*** e0ne has quit IRC | 05:52 | |
*** hoonetorg has joined #openstack-horizon | 05:52 | |
*** zhurong has joined #openstack-horizon | 05:57 | |
*** e0ne has joined #openstack-horizon | 06:03 | |
*** ChanServ sets mode: +o e0ne | 06:03 | |
*** hoonetorg has quit IRC | 06:06 | |
*** pcaruana has joined #openstack-horizon | 06:27 | |
*** rdopiera has joined #openstack-horizon | 06:31 | |
*** e0ne has quit IRC | 06:51 | |
*** btully has joined #openstack-horizon | 06:58 | |
*** btully has quit IRC | 07:03 | |
*** jpich has joined #openstack-horizon | 07:09 | |
*** cshen has joined #openstack-horizon | 07:17 | |
*** tosky has joined #openstack-horizon | 07:29 | |
*** rcernin has quit IRC | 07:35 | |
Guest74859 | hi | 07:35 |
Guest74859 | I thought about my question about tests, yesterday, and I don't know if I understand the way it should be | 07:37 |
Guest74859 | Panel tests should be in ``{{ module_name }}/test``, then ? | 07:38 |
Guest74859 | (by panel tests, I mean Django tests) | 07:38 |
Guest74859 | or should it stay in ``{{ modude_name }}/content/{{ panel }}/tests.py`` ? | 07:39 |
Guest74859 | (which was removed from ui-cookiecutter) | 07:40 |
*** zhurong has quit IRC | 08:26 | |
josecastroleon | amotoki: I tried today with "basepython = python2" in the releasenotes tox env in tox.ini and then ran "tox -e releasenotes -r" and it worked | 08:27 |
josecastroleon | amotoki: I had to specify python2 to have the 2.7 version | 08:27 |
josecastroleon | amotoki: but on the sphinx-build command it runs sdist first. If you activate the virtualenv (. .tox/releasenotes/bin/activate) and run python setup.py sdist you'll get the same encoding error as in the sphinx job | 08:29 |
josecastroleon | amotoki: http://logs.openstack.org/10/587010/4/check/build-openstack-sphinx-docs/d54a639/job-output.txt.gz in the task [install-if-python : Make sdist to generate ChangeLog] | 08:31 |
*** btully has joined #openstack-horizon | 08:47 | |
*** btully has quit IRC | 08:51 | |
*** priteau has quit IRC | 09:45 | |
*** priteau has joined #openstack-horizon | 09:45 | |
*** edmondsw has joined #openstack-horizon | 09:45 | |
*** edmondsw has quit IRC | 09:49 | |
openstackgerrit | Boxiang Zhu proposed openstack/horizon master: Add package-lock.json which generate by npm https://review.openstack.org/589424 | 09:57 |
*** cshen has quit IRC | 10:02 | |
*** tonyb has quit IRC | 10:16 | |
*** tonyb has joined #openstack-horizon | 10:23 | |
*** madorn has quit IRC | 10:25 | |
*** madorn has joined #openstack-horizon | 10:27 | |
*** btully has joined #openstack-horizon | 10:36 | |
*** btully has quit IRC | 10:40 | |
*** dave-mccowan has joined #openstack-horizon | 10:59 | |
*** rmart04 has joined #openstack-horizon | 11:02 | |
*** cshen has joined #openstack-horizon | 11:15 | |
Guest74859 | oh, and if I use ``{{ module_name }}/test`` for my tests, do I really need to use the ``manage.py`` file from Django ? | 11:52 |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Hide default_cgsnapshot_type from cinder group types https://review.openstack.org/589864 | 12:11 |
*** btully has joined #openstack-horizon | 12:24 | |
*** btully has quit IRC | 12:29 | |
*** e0ne has joined #openstack-horizon | 12:34 | |
*** ChanServ sets mode: +o e0ne | 12:34 | |
*** jpich has quit IRC | 12:37 | |
*** edmondsw has joined #openstack-horizon | 13:05 | |
*** e0ne has quit IRC | 13:18 | |
*** lblanchard has quit IRC | 13:24 | |
*** e0ne has joined #openstack-horizon | 13:31 | |
*** ChanServ sets mode: +o e0ne | 13:31 | |
*** _ix has joined #openstack-horizon | 13:49 | |
openstackgerrit | David Gutman proposed openstack/horizon master: Change project details view in a tab view. https://review.openstack.org/588591 | 13:53 |
*** _ix has quit IRC | 14:13 | |
*** _ix has joined #openstack-horizon | 14:22 | |
amotoki | e0ne: On bug 1785178, I sent a small patch https://review.openstack.org/589864 | 14:38 |
openstack | bug 1785178 in OpenStack Dashboard (Horizon) "default_cgsnapshot_type should not be listed in "Group Type" selection in "Create Group" form" [High,New] https://launchpad.net/bugs/1785178 | 14:38 |
e0ne | amotoki: great! thank you! I'll review it a bit later today and will propose a release patch tomorrow morning (UTC+3) | 14:40 |
amotoki | josecastroleon: is it still broken in py3 env? I would like to know whether it works in others' env. It works in my side. | 14:42 |
*** trevormc has joined #openstack-horizon | 14:43 | |
amotoki | josecastroleon: I am curios why it is not broken in our gate and broken only your env. I am not against to replace unicode char with ascii, but would like to know what happens. | 14:46 |
*** priteau has quit IRC | 14:53 | |
*** e0ne has quit IRC | 14:58 | |
openstackgerrit | David Gutman proposed openstack/horizon master: Add user tab in project details view. https://review.openstack.org/589932 | 15:00 |
openstackgerrit | David Gutman proposed openstack/horizon master: Change project details view in a tab view. https://review.openstack.org/588591 | 15:03 |
*** priteau has joined #openstack-horizon | 15:04 | |
*** trevormc has quit IRC | 15:07 | |
openstackgerrit | David Gutman proposed openstack/horizon master: Add user tab in project details view. https://review.openstack.org/589932 | 15:09 |
openstackgerrit | David Gutman proposed openstack/horizon master: Display users with role through group in users project details tab. https://review.openstack.org/589938 | 15:12 |
openstackgerrit | David Gutman proposed openstack/horizon master: Display users with role through group in users project details tab. https://review.openstack.org/589938 | 15:15 |
*** Guest74859 has left #openstack-horizon | 15:21 | |
*** Guest74859 has joined #openstack-horizon | 15:21 | |
josecastroleon | amotoki: it works under py3 in my env | 15:23 |
josecastroleon | but every time i retest my code that has a release note the sphinx-job in zuul crashes | 15:23 |
amotoki | josecastroleon: any example? | 15:24 |
josecastroleon | amotoki: http://logs.openstack.org/10/587010/4/check/build-openstack-sphinx-docs/d54a639/job-output.txt.gz | 15:24 |
josecastroleon | it you see in the task [install-if-python : Make sdist to generate ChangeLog] | 15:24 |
amotoki | josecastroleon: surprisingly, build-openstack-sphinx-docs jobs in my patch did not fail even though I can see the same error http://logs.openstack.org/64/589864/1/check/build-openstack-sphinx-docs/b7ef4c6/job-output.txt.gz#_2018-08-08_12_32_10_131592 | 15:28 |
*** cshen has quit IRC | 15:29 | |
amotoki | josecastroleon: it seems the root cause is different. | 15:29 |
amotoki | josecastroleon: I agree it is better to fix it. | 15:29 |
amotoki | josecastroleon: when I ran 'tox -e docs' against your patch, I can find the root cause easily | 15:33 |
amotoki | josecastroleon: it says "/home/ubuntu/tmp/horizon/doc/source/configuration/settings.rst:1528:Error in "versionadded" directive: 1 argument(s) required, 0 supplied. " | 15:33 |
*** pcaruana has quit IRC | 15:34 | |
*** rmart04 has quit IRC | 15:42 | |
*** dklyle has joined #openstack-horizon | 15:55 | |
*** ChanServ sets mode: +o dklyle | 15:55 | |
*** david-lyle has joined #openstack-horizon | 15:59 | |
*** ChanServ sets mode: +o david-lyle | 15:59 | |
*** dklyle has quit IRC | 16:01 | |
*** david-lyle is now known as dklyle | 16:02 | |
*** btully has joined #openstack-horizon | 16:02 | |
*** btully has quit IRC | 16:06 | |
*** dklyle has quit IRC | 16:43 | |
*** marlinc has quit IRC | 16:45 | |
*** ediardo has joined #openstack-horizon | 16:52 | |
*** gyee has joined #openstack-horizon | 16:52 | |
*** marlinc has joined #openstack-horizon | 16:59 | |
*** e0ne has joined #openstack-horizon | 17:11 | |
*** ChanServ sets mode: +o e0ne | 17:11 | |
*** dklyle has joined #openstack-horizon | 17:21 | |
*** ChanServ sets mode: +o dklyle | 17:21 | |
*** btully has joined #openstack-horizon | 17:51 | |
*** btully has quit IRC | 17:55 | |
*** dklyle has quit IRC | 17:57 | |
*** e0ne has quit IRC | 18:03 | |
*** dklyle has joined #openstack-horizon | 18:09 | |
*** ChanServ sets mode: +o dklyle | 18:09 | |
*** e0ne has joined #openstack-horizon | 18:20 | |
*** ChanServ sets mode: +o e0ne | 18:20 | |
*** itlinux has joined #openstack-horizon | 18:25 | |
*** ircuser-1 has quit IRC | 18:30 | |
*** dklyle has quit IRC | 18:31 | |
*** dklyle has joined #openstack-horizon | 18:34 | |
*** ChanServ sets mode: +o dklyle | 18:34 | |
*** dklyle has quit IRC | 18:59 | |
*** ediardo has quit IRC | 19:01 | |
*** ediardo has joined #openstack-horizon | 19:02 | |
*** e0ne has quit IRC | 19:11 | |
*** e0ne has joined #openstack-horizon | 19:19 | |
*** ChanServ sets mode: +o e0ne | 19:19 | |
*** e0ne has quit IRC | 19:23 | |
*** rmart04 has joined #openstack-horizon | 19:45 | |
*** rmart04 has quit IRC | 19:45 | |
*** Guest74859 is now known as Linkid | 20:04 | |
*** ircuser-1 has joined #openstack-horizon | 20:05 | |
*** dklyle has joined #openstack-horizon | 20:05 | |
*** ChanServ sets mode: +o dklyle | 20:05 | |
openstackgerrit | Merged openstack/horizon master: Hide default_cgsnapshot_type from cinder group types https://review.openstack.org/589864 | 20:06 |
*** itlinux has quit IRC | 20:12 | |
*** lblanchard has joined #openstack-horizon | 20:25 | |
ediardo | o/ | 20:56 |
*** dklyle has quit IRC | 20:58 | |
*** dklyle has joined #openstack-horizon | 21:02 | |
*** ChanServ sets mode: +o dklyle | 21:02 | |
*** dklyle has quit IRC | 21:07 | |
*** pcaruana has joined #openstack-horizon | 21:07 | |
*** priteau has quit IRC | 21:20 | |
*** lblanchard has quit IRC | 21:52 | |
*** kei-ichi has joined #openstack-horizon | 21:54 | |
*** kei-ichi has quit IRC | 21:57 | |
*** kei-ichi has joined #openstack-horizon | 22:00 | |
*** pcaruana has quit IRC | 22:02 | |
*** edmondsw has quit IRC | 22:10 | |
*** rcernin has joined #openstack-horizon | 22:19 | |
*** priteau has joined #openstack-horizon | 22:26 | |
*** gary-smith_ has joined #openstack-horizon | 22:53 | |
*** jtomasek_ has joined #openstack-horizon | 22:54 | |
*** zioproto_ has joined #openstack-horizon | 22:55 | |
*** r-daneel has joined #openstack-horizon | 22:59 | |
*** amotoki_ has joined #openstack-horizon | 23:01 | |
*** ChanServ sets mode: +v amotoki_ | 23:01 | |
*** Tahvok has quit IRC | 23:02 | |
*** jtomasek has quit IRC | 23:02 | |
*** gary-smith has quit IRC | 23:02 | |
*** NikitaKonovalov has quit IRC | 23:02 | |
*** honza has quit IRC | 23:02 | |
*** amotoki has quit IRC | 23:02 | |
*** zioproto has quit IRC | 23:02 | |
*** rickflare has quit IRC | 23:02 | |
*** zioproto_ is now known as zioproto | 23:02 | |
*** Tahvok has joined #openstack-horizon | 23:03 | |
*** btully has joined #openstack-horizon | 23:17 | |
*** btully has quit IRC | 23:22 | |
*** tosky has quit IRC | 23:49 | |
*** rmcall has joined #openstack-horizon | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!