*** germs has quit IRC | 00:00 | |
*** yamamoto has joined #openstack-horizon | 00:20 | |
*** yamamoto has quit IRC | 00:24 | |
*** lblanchard has joined #openstack-horizon | 00:38 | |
*** yamamoto has joined #openstack-horizon | 00:41 | |
*** hoangcx has joined #openstack-horizon | 00:46 | |
*** lblanchard has quit IRC | 00:51 | |
*** dave-mccowan has joined #openstack-horizon | 01:00 | |
*** dave-mcc_ has joined #openstack-horizon | 01:03 | |
*** dave-mccowan has quit IRC | 01:05 | |
openstackgerrit | Adrian Turjak proposed openstack/horizon master: Create new wsgi.py file and deprecate old file https://review.openstack.org/561802 | 01:14 |
---|---|---|
*** namnh has joined #openstack-horizon | 01:17 | |
*** sapd has joined #openstack-horizon | 01:43 | |
openstackgerrit | Adrian Turjak proposed openstack/horizon master: Create new wsgi.py file and deprecate old file https://review.openstack.org/561802 | 02:14 |
openstackgerrit | Adrian Turjak proposed openstack/horizon master: Create new wsgi.py file and deprecate old file https://review.openstack.org/561802 | 02:37 |
openstackgerrit | Adrian Turjak proposed openstack/horizon master: Create new wsgi.py file and deprecate old file https://review.openstack.org/561802 | 02:38 |
*** dklyle has joined #openstack-horizon | 02:41 | |
*** ChanServ sets mode: +o dklyle | 02:41 | |
adriant | rdopiera, amotoki: updated the wsgi patch. please review when you can :) | 02:46 |
*** dklyle has quit IRC | 03:00 | |
*** dangtrinhnt has quit IRC | 03:09 | |
*** rcernin has quit IRC | 03:31 | |
*** rcernin has joined #openstack-horizon | 03:35 | |
*** dave-mcc_ has quit IRC | 04:00 | |
*** shu-mutow-AWAY is now known as shu-mutow | 04:22 | |
*** btully has joined #openstack-horizon | 04:33 | |
*** btully has quit IRC | 04:38 | |
*** jtomasek has joined #openstack-horizon | 05:12 | |
*** btully has joined #openstack-horizon | 05:39 | |
*** btully has quit IRC | 05:59 | |
*** e0ne has joined #openstack-horizon | 06:02 | |
*** ChanServ sets mode: +o e0ne | 06:02 | |
*** lajoskatona has joined #openstack-horizon | 06:14 | |
*** cshen has joined #openstack-horizon | 06:27 | |
*** masco has joined #openstack-horizon | 06:32 | |
*** ircuser-1 has joined #openstack-horizon | 06:39 | |
*** e0ne has quit IRC | 06:49 | |
*** tesseract has joined #openstack-horizon | 07:04 | |
*** katyafervent_awa has quit IRC | 07:06 | |
*** katyafervent_awa has joined #openstack-horizon | 07:10 | |
*** sapd has quit IRC | 07:13 | |
*** rcernin has quit IRC | 07:19 | |
*** pcaruana has joined #openstack-horizon | 07:25 | |
*** cshen has quit IRC | 07:26 | |
*** tosky has joined #openstack-horizon | 07:28 | |
*** btully has joined #openstack-horizon | 07:44 | |
*** btully has quit IRC | 07:48 | |
*** nguyenhai has joined #openstack-horizon | 07:54 | |
*** jpich has joined #openstack-horizon | 07:58 | |
*** shu-mutow is now known as shu-mutow-AWAY | 08:04 | |
*** threestrands has quit IRC | 08:17 | |
*** sapd has joined #openstack-horizon | 08:53 | |
*** e0ne has joined #openstack-horizon | 09:03 | |
*** ChanServ sets mode: +o e0ne | 09:03 | |
*** namnh has quit IRC | 09:22 | |
*** namnh has joined #openstack-horizon | 09:23 | |
e0ne | amotoki: thanks a lot for the review my patch with django test runner | 09:25 |
*** hoangcx has quit IRC | 09:26 | |
*** hoangcx has joined #openstack-horizon | 09:26 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose https://review.openstack.org/544296 | 09:51 |
*** rmart04 has joined #openstack-horizon | 09:53 | |
*** e0ne changes topic to "OpenStack Horizon | Rocky PTG: https://etherpad.openstack.org/p/horizon-ptg-rocky | Rocky-2 priorities: https://launchpad.net/horizon/+milestone/rocky-2 | Docs: https://docs.openstack.org/horizon/latest/" | 10:05 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Fix selenuim-headless tests https://review.openstack.org/558467 | 10:08 |
*** hoangcx has quit IRC | 10:09 | |
amotoki | e0ne: https://review.openstack.org/#/c/558048/ | 10:12 |
amotoki | e0ne: if it lands I will send an announcement to the ML following my mail last month on mox removal plan in horizon | 10:13 |
*** namnh has quit IRC | 10:17 | |
e0ne | amotoki: looking on it | 10:21 |
*** pcaruana has quit IRC | 10:26 | |
*** yamamoto has quit IRC | 10:31 | |
*** pcaruana has joined #openstack-horizon | 10:33 | |
*** e0ne has quit IRC | 10:35 | |
*** e0ne_ has joined #openstack-horizon | 10:35 | |
*** ChanServ sets mode: +o e0ne_ | 10:35 | |
openstackgerrit | Merged openstack/horizon master: Disable mox usage by default in test helper https://review.openstack.org/558048 | 10:37 |
amotoki | ^^^ yay | 11:01 |
*** hoonetorg has quit IRC | 11:03 | |
e0ne_ | I tried to remove nose from horizon plugins | 11:05 |
amotoki | e0ne_: which topic are you using? | 11:05 |
e0ne_ | https://review.openstack.org/#/q/topic:bp/improve-horizon-testing+(status:open+OR+status:merged) | 11:05 |
e0ne_ | everything went good, except freezer and murano | 11:06 |
e0ne_ | murano-dashboard tests are broken for py35 | 11:06 |
*** e0ne_ is now known as e0ne | 11:07 | |
amotoki | e0ne: a mail on mox removal update: http://lists.openstack.org/pipermail/openstack-dev/2018-April/129648.html | 11:08 |
amotoki | e0ne: so what is the plan of your patch series? you propose patches so that horizon plugins consumes horizon.test.settings. | 11:14 |
amotoki | after that, does this mean that test runners of all horizon plugins will be changed if we change the test runner in horizon.test.settings? | 11:14 |
e0ne | amotoki: it should be up to plugin maintainers to override test runner. I remove nose because it does a lot of false positive reports | 11:15 |
e0ne | so we can't be sure that something works even if nose reports OK | 11:16 |
*** hoonetorg has joined #openstack-horizon | 11:16 | |
e0ne | that's why I remove nose as a first step to see what is going | 11:16 |
e0ne | I want to have cross-project jobs to test plugins pear each horizon tests | 11:17 |
e0ne | we can use unit-tests as a beginning and selenium tests in the futrure | 11:17 |
e0ne | so plugin maintainers could implement own selenium based tests | 11:18 |
amotoki | e0ne: I am a bit confused. in case of your designate-dashboard patch, https://review.openstack.org/#/c/562525/3/designatedashboard/tests/settings.py | 11:18 |
amotoki | e0ne: L.21 imports all attributes in horizon.test.settings | 11:18 |
amotoki | and horizon.test.settings defines TEST_RUNNER at https://github.com/openstack/horizon/blob/master/horizon/test/settings.py#L108 | 11:18 |
amotoki | so I wonder horizon plugin maintainers can choose test runner without overriding settings related to testing. | 11:19 |
e0ne | sure. they need to override horizon's settings to change test runner or anythin else | 11:20 |
e0ne | s/anythin/anything | 11:20 |
*** hoonetorg has quit IRC | 11:21 | |
*** masco has quit IRC | 11:21 | |
amotoki | e0ne: horizon.test.settings requires django_nose in INSTALLED_APPS, so if other horizon plugins try to use other test runners. does they need to do something like L.47 in https://review.openstack.org/#/c/558197/3/neutron_vpnaas_dashboard/test/settings.py ? | 11:22 |
*** btully has joined #openstack-horizon | 11:22 | |
amotoki | e0ne: I just would like to clarify what is the recommended way during this test runner switch. | 11:23 |
e0ne | amotoki: yes, it works in the same way as local_settings.py | 11:23 |
e0ne | amotoki: I think, we need to add a note to the documentation about test runners | 11:24 |
e0ne | my idea is to get a rid of nose, because it's unsupported and has a lot of bugs | 11:25 |
e0ne | but the plugins teams could user anything they want in the future | 11:25 |
e0ne | horizon should provides good enough default test runner to cover most cases | 11:26 |
*** btully has quit IRC | 11:26 | |
e0ne | does it make sense? | 11:26 |
mugsie | e0ne: amotoki it is worth noting a lot of the plugins cargo cult from one another, and have no idea how any of this works :) - so any extra docs would be ++ | 11:27 |
*** yamamoto has joined #openstack-horizon | 11:31 | |
e0ne | mugsie: good point | 11:32 |
e0ne | mugsie: now I remove nose only because it works not like expected:( | 11:32 |
*** yamamoto has quit IRC | 11:37 | |
*** hoonetorg has joined #openstack-horizon | 11:39 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Drop Flavor Edit completely https://review.openstack.org/563586 | 11:48 |
*** pcaruana has quit IRC | 11:54 | |
*** yamamoto has joined #openstack-horizon | 12:05 | |
*** yamamoto has quit IRC | 12:06 | |
*** pcaruana has joined #openstack-horizon | 12:10 | |
*** doxa has quit IRC | 12:10 | |
*** vladiskuz has joined #openstack-horizon | 12:13 | |
vladiskuz | amotoki: Hi! are you here? | 12:14 |
*** vladiskuz has quit IRC | 12:14 | |
*** vladiskuz has joined #openstack-horizon | 12:15 | |
*** yamamoto has joined #openstack-horizon | 12:37 | |
*** yamamoto has quit IRC | 12:42 | |
*** dave-mccowan has joined #openstack-horizon | 12:49 | |
*** yamamoto has joined #openstack-horizon | 12:51 | |
*** yamamoto has quit IRC | 12:55 | |
*** vladiskuz has quit IRC | 13:14 | |
*** jpich has quit IRC | 13:30 | |
*** lvdombrkr has joined #openstack-horizon | 13:30 | |
*** r-daneel has joined #openstack-horizon | 13:37 | |
*** felipemonteiro_ has joined #openstack-horizon | 13:38 | |
*** jpich has joined #openstack-horizon | 13:38 | |
*** felipemonteiro__ has joined #openstack-horizon | 13:44 | |
*** felipemonteiro_ has quit IRC | 13:47 | |
*** jtriley has joined #openstack-horizon | 13:48 | |
*** r-daneel has quit IRC | 13:51 | |
*** yamamoto has joined #openstack-horizon | 13:51 | |
*** rmart04 has quit IRC | 13:51 | |
*** rmart04 has joined #openstack-horizon | 13:52 | |
*** yamamoto has quit IRC | 13:57 | |
*** rmart04 has quit IRC | 13:57 | |
*** rmart04 has joined #openstack-horizon | 13:57 | |
*** felipemonteiro_ has joined #openstack-horizon | 14:00 | |
*** felipemonteiro__ has quit IRC | 14:00 | |
*** tsmith2 has joined #openstack-horizon | 14:05 | |
amotoki | e0ne: final cleanup of "Edit Flavor" https://review.openstack.org/#/c/563586/ | 14:11 |
amotoki | e0ne: we missed it when your patch dropped the feature. | 14:11 |
*** lblanchard has joined #openstack-horizon | 14:11 | |
e0ne | amotoki: thanks! it's on my TODOs list for tonight | 14:11 |
amotoki | e0ne: no worries. it is not urgent. | 14:12 |
*** lblanchard has quit IRC | 14:12 | |
*** felipemonteiro__ has joined #openstack-horizon | 14:20 | |
*** felipemonteiro_ has quit IRC | 14:24 | |
*** lvdombrkr89 has joined #openstack-horizon | 14:37 | |
*** lvdombrkr has quit IRC | 14:40 | |
*** lblanchard has joined #openstack-horizon | 14:46 | |
*** lvdombrkr89 has quit IRC | 14:47 | |
*** felipemonteiro__ has quit IRC | 14:51 | |
*** felipemonteiro__ has joined #openstack-horizon | 14:51 | |
*** yamamoto has joined #openstack-horizon | 14:53 | |
*** r-daneel has joined #openstack-horizon | 14:53 | |
*** yamamoto has quit IRC | 14:58 | |
*** btully has joined #openstack-horizon | 14:59 | |
*** btully has quit IRC | 15:04 | |
*** rmart04 has quit IRC | 15:06 | |
*** felipemonteiro_ has joined #openstack-horizon | 15:09 | |
*** felipemonteiro__ has quit IRC | 15:13 | |
*** jtriley has quit IRC | 15:16 | |
*** pcaruana has quit IRC | 15:19 | |
amotoki | is the meeting agenda page still honored? | 15:20 |
*** felipemonteiro_ has quit IRC | 15:20 | |
*** felipemonteiro_ has joined #openstack-horizon | 15:20 | |
amotoki | the page is not shared at recent meetings, so I wonder what is the best way to add some to the agenda. | 15:21 |
e0ne | amotoki: I use https://wiki.openstack.org/wiki/Meetings/Horizon for meetings agenda | 15:21 |
amotoki | e0ne: thanks. I will add some topics to the page. | 15:22 |
amotoki | (though I am not 100% sure I can join the meeting this week) | 15:22 |
e0ne | :( | 15:22 |
amotoki | I have a local meetup as usual this week | 15:22 |
amotoki | s/this week/this Wed/ | 15:23 |
amotoki | I have neutron drivers meeting on every Friday night, so I tend to schedule local meetups or parties on Wednesday | 15:24 |
amotoki | that's the reason I asked you whether we change day of week or not when rearranging the meeting time slot. | 15:25 |
e0ne | I understand... | 15:25 |
amotoki | I will try to share the background in advance. | 15:25 |
e0ne | it's really hard to get all of us in one time | 15:26 |
*** lajoskatona has quit IRC | 15:27 | |
*** dklyle has joined #openstack-horizon | 15:32 | |
*** ChanServ sets mode: +o dklyle | 15:32 | |
amotoki | yeah exactly. | 15:33 |
*** jtriley has joined #openstack-horizon | 15:46 | |
tosky | a new contributor posted nice patches to remove mox support from sahara-dashboard, but they are failing in the lower-constraints.txt test, because it forces horizon==13.0.0 | 15:47 |
tosky | and I suspest that the patches relies on some feature from horizon master | 15:47 |
tosky | did anyone already face this issue in out-of-horizon dashboards and know how to fix lower-constraints.txt for this to work? | 15:48 |
tosky | (or I will nag dhellmann...) | 15:48 |
e0ne | tosky: could you please provide a link to the patch? | 15:48 |
*** dklyle has quit IRC | 15:49 | |
e0ne | tosky: need to head off. I can take a look on it in ~3 hours | 15:51 |
tosky | e0ne: https://review.openstack.org/#/c/562892/ | 15:51 |
*** yamamoto has joined #openstack-horizon | 15:54 | |
*** e0ne has quit IRC | 15:54 | |
*** yamamoto has quit IRC | 16:00 | |
*** gyee has joined #openstack-horizon | 16:03 | |
*** pcaruana has joined #openstack-horizon | 16:13 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Drop Flavor Edit completely https://review.openstack.org/563586 | 16:19 |
*** jpich has quit IRC | 16:30 | |
*** btully has joined #openstack-horizon | 16:48 | |
*** btully has quit IRC | 16:53 | |
*** yamamoto has joined #openstack-horizon | 16:56 | |
*** yamamoto has quit IRC | 17:01 | |
amotoki | tosky: required-projects need to be added. https://github.com/openstack/neutron-vpnaas-dashboard/blob/master/.zuul.yaml is for neutron-vpnaas-dashboard | 17:06 |
tosky | amotoki: to which job? | 17:12 |
amotoki | tosky: lower-constraints | 17:12 |
amotoki | tosky: tox-siblings will install horizon master if required-projects is specified to lower-constraints job. | 17:13 |
tosky | amotoki: oh, I see - because that would enable LIBS_FROM_GIT for horizon? But isn't cheating a bit, overriding lower-constraints in fact? | 17:13 |
amotoki | tosky: ?? LIBS_FROM_GIT only works for devstack. lower-constraints is not devstack job but tox job. | 17:14 |
tosky | right | 17:14 |
tosky | but the idea is similar | 17:14 |
amotoki | right | 17:14 |
tosky | so basically it will ignore the value of lower-constraints, so I though it's a bit cheating because then lower-constraints wouldn't reflect the real value | 17:15 |
tosky | and we would need to update the value before the release | 17:15 |
tosky | or we may forget it | 17:15 |
tosky | and everything would continue to work, but lower-constraints.txt for the horizon dependency wouldn't be true anymore | 17:16 |
tosky | the value of horizon in lower-constraints.txt* | 17:16 |
amotoki | horizon==13.0.0 is ignored if required-projcts is specified | 17:16 |
tosky | yes, exactly: but let's assume that I add required-project; everything will work, then horizon 14 is released and I need it | 17:17 |
amotoki | but it is due to the some transient situation I think | 17:17 |
tosky | so I should update lower-constraints.txt, but nothing will remember me to do it | 17:17 |
amotoki | the infra was changed suddenly regardless of the current horizon release model | 17:17 |
tosky | so I may forget it, everything will continue to work, but the contents of lower-constraints.txt won't be correct anymore | 17:17 |
tosky | I guess I will ping dhellmann :D | 17:18 |
amotoki | and it seems they suggest to switch horizon rel models to cycle-with-intermediate | 17:18 |
tosky | oh, that will make sense too | 17:18 |
amotoki | or to split out common parts which plugins depends on into some libraries. | 17:18 |
amotoki | it will take time | 17:18 |
tosky | so you would release an intermediate version, then we can switch to that, everyone is happy | 17:18 |
amotoki | I have no good idea on how to move this forward in short term | 17:19 |
tosky | but we may need to remember to remove required-project, or the change would be hidden | 17:19 |
amotoki | I would like to see more wide consensus on this | 17:19 |
tosky | so do you think it's something I could re-raise again with -infra? Because other projects may be affected | 17:19 |
amotoki | I understand the whole picture on what is happening, but personally I have no time to move this forward. | 17:20 |
tosky | I understand that | 17:20 |
amotoki | tosky: yeah it needs to be discussed with the infra team | 17:20 |
amotoki | versioning change is a bit surprising to consumers. | 17:21 |
amotoki | 13.0.0 is Queens release, but for example 15.6.0 can be Rocky release. | 17:21 |
tosky | but thanks for the explanation and the hints; I can easily add required-project, but I'd like a more robust solution | 17:21 |
*** mvk has quit IRC | 17:22 | |
amotoki | * if we switch a versioning model to the semantic versioning more strictly. | 17:22 |
amotoki | Each backward-incompat change (i.e., dropping some feature) will bump major version. | 17:22 |
*** tesseract has quit IRC | 17:23 | |
*** e0ne has joined #openstack-horizon | 17:26 | |
*** ChanServ sets mode: +o e0ne | 17:26 | |
*** yamamoto has joined #openstack-horizon | 17:58 | |
*** r-daneel has quit IRC | 18:00 | |
*** r-daneel has joined #openstack-horizon | 18:01 | |
*** yamamoto has quit IRC | 18:02 | |
*** felipemonteiro__ has joined #openstack-horizon | 18:08 | |
*** felipemonteiro_ has quit IRC | 18:12 | |
*** darland has quit IRC | 18:35 | |
*** harlowja has joined #openstack-horizon | 18:44 | |
*** yamamoto has joined #openstack-horizon | 18:59 | |
*** yamamoto has quit IRC | 19:03 | |
*** felipemonteiro__ has quit IRC | 19:06 | |
*** felipemonteiro__ has joined #openstack-horizon | 19:07 | |
*** harlowja has quit IRC | 19:07 | |
*** dklyle has joined #openstack-horizon | 19:11 | |
*** ChanServ sets mode: +o dklyle | 19:11 | |
*** imacdonn has quit IRC | 19:13 | |
*** imacdonn has joined #openstack-horizon | 19:14 | |
tosky | amotoki: I may have temporarily solved by pushing the requirement on the 14.0.0.0b1, available on pypi: https://review.openstack.org/#/c/563733/ | 19:47 |
tosky | amotoki: apart from that, you may have read the discussion on -infra | 19:47 |
*** yamamoto has joined #openstack-horizon | 19:59 | |
*** yamamoto has quit IRC | 20:05 | |
*** dave-mccowan has quit IRC | 20:14 | |
*** btully has joined #openstack-horizon | 20:26 | |
*** felipemonteiro__ has quit IRC | 20:29 | |
*** btully has quit IRC | 20:30 | |
*** jtomasek has quit IRC | 20:43 | |
*** mvk has joined #openstack-horizon | 20:45 | |
*** idlemind has quit IRC | 20:59 | |
*** lblanchard has quit IRC | 21:06 | |
*** jtriley has quit IRC | 21:10 | |
*** dklyle has quit IRC | 21:31 | |
*** r-daneel_ has joined #openstack-horizon | 21:35 | |
*** r-daneel has quit IRC | 21:36 | |
*** r-daneel_ is now known as r-daneel | 21:36 | |
*** yamamoto has joined #openstack-horizon | 22:02 | |
*** yamamoto has quit IRC | 22:07 | |
*** jrist has quit IRC | 22:08 | |
*** jrist has joined #openstack-horizon | 22:12 | |
*** jrist has quit IRC | 22:12 | |
*** jrist has joined #openstack-horizon | 22:12 | |
*** e0ne has quit IRC | 22:14 | |
*** lbragstad has quit IRC | 22:18 | |
openstackgerrit | Merged openstack/horizon master: Allow OVA upload for images https://review.openstack.org/554572 | 22:19 |
openstackgerrit | Merged openstack/horizon master: Add identity API version discovery https://review.openstack.org/559429 | 22:20 |
*** dklyle has joined #openstack-horizon | 22:26 | |
*** ChanServ sets mode: +o dklyle | 22:26 | |
*** rcernin has joined #openstack-horizon | 22:31 | |
*** dklyle has quit IRC | 22:39 | |
*** threestrands has joined #openstack-horizon | 22:41 | |
*** threestrands has quit IRC | 22:41 | |
*** threestrands has joined #openstack-horizon | 22:41 | |
*** felipemonteiro__ has joined #openstack-horizon | 22:42 | |
*** lblanchard has joined #openstack-horizon | 23:03 | |
*** yamamoto has joined #openstack-horizon | 23:04 | |
*** felipemonteiro__ has quit IRC | 23:07 | |
*** yamamoto has quit IRC | 23:10 | |
*** r-daneel has quit IRC | 23:21 | |
*** yamamoto has joined #openstack-horizon | 23:26 | |
*** tosky has quit IRC | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!