*** jtriley has joined #openstack-horizon | 00:00 | |
*** germs has joined #openstack-horizon | 00:01 | |
*** germs has quit IRC | 00:01 | |
*** germs has joined #openstack-horizon | 00:01 | |
*** tosky has quit IRC | 00:04 | |
*** germs has quit IRC | 00:05 | |
*** ircuser-1 has joined #openstack-horizon | 00:12 | |
*** itlinux has joined #openstack-horizon | 00:23 | |
*** yamamoto has quit IRC | 00:26 | |
*** yamamoto has joined #openstack-horizon | 00:28 | |
*** yamamoto has quit IRC | 00:28 | |
*** lifeless_ has joined #openstack-horizon | 00:46 | |
*** lifeless has quit IRC | 00:46 | |
openstackgerrit | Merged openstack/horizon master: Fix Angular errors in openstack_auth https://review.openstack.org/552789 | 00:50 |
---|---|---|
*** itlinux has quit IRC | 00:51 | |
*** wolverineav has quit IRC | 00:54 | |
*** wolverineav has joined #openstack-horizon | 00:57 | |
*** wolverineav has quit IRC | 01:03 | |
*** lblanchard has quit IRC | 01:04 | |
*** wolverineav has joined #openstack-horizon | 01:04 | |
*** yamamoto has joined #openstack-horizon | 01:07 | |
*** wolverineav has quit IRC | 01:11 | |
*** jtriley has quit IRC | 01:22 | |
*** felipemonteiro has quit IRC | 01:26 | |
*** felipemonteiro has joined #openstack-horizon | 01:27 | |
*** yamamoto has quit IRC | 01:27 | |
*** jtriley has joined #openstack-horizon | 01:28 | |
*** felipemonteiro has quit IRC | 01:46 | |
*** dayou has quit IRC | 01:56 | |
*** germs has joined #openstack-horizon | 02:02 | |
*** germs has quit IRC | 02:06 | |
*** wolverineav has joined #openstack-horizon | 02:08 | |
*** jtriley has quit IRC | 02:12 | |
*** Nil_ has quit IRC | 02:12 | |
*** jtriley has joined #openstack-horizon | 02:24 | |
*** dave-mccowan has quit IRC | 02:31 | |
*** r-daneel has joined #openstack-horizon | 02:32 | |
*** r-daneel_ has joined #openstack-horizon | 02:34 | |
*** r-daneel has quit IRC | 02:36 | |
*** r-daneel_ is now known as r-daneel | 02:36 | |
openstackgerrit | Xinni Ge proposed openstack/horizon master: Add plugin xstatic modules support https://review.openstack.org/552259 | 02:39 |
*** itlinux has joined #openstack-horizon | 02:42 | |
*** wolverineav has quit IRC | 02:58 | |
*** wolverineav has joined #openstack-horizon | 03:04 | |
*** jtriley has quit IRC | 03:10 | |
*** jtriley has joined #openstack-horizon | 03:13 | |
*** dangtrinhnt_ has joined #openstack-horizon | 03:15 | |
*** wolverineav has quit IRC | 03:18 | |
*** wolverineav has joined #openstack-horizon | 03:22 | |
*** dangtrinhnt_ has quit IRC | 03:25 | |
openstackgerrit | Merged openstack/horizon master: Add angular create server group action https://review.openstack.org/517755 | 03:38 |
*** itlinux has quit IRC | 03:49 | |
*** yamamoto has joined #openstack-horizon | 03:52 | |
*** Coldblackice6NLV has joined #openstack-horizon | 03:55 | |
openstackgerrit | Merged openstack/horizon master: Add angular delete server groups action https://review.openstack.org/517756 | 03:56 |
openstackgerrit | Merged openstack/horizon master: Add angular server group details page https://review.openstack.org/517824 | 03:56 |
openstackgerrit | Merged openstack/horizon master: Make size of Angular modal form specifiable https://review.openstack.org/537336 | 03:56 |
openstackgerrit | Merged openstack/horizon master: Fix layout of dialogs for Angularized users panel https://review.openstack.org/535723 | 03:56 |
openstackgerrit | Merged openstack/horizon master: Tabbify quota default panel https://review.openstack.org/540100 | 03:56 |
openstackgerrit | Merged openstack/horizon master: Update Django versions in horizon requirements https://review.openstack.org/553628 | 03:56 |
openstackgerrit | Merged openstack/horizon master: Update RHEL/CentOS horizon install instruction https://review.openstack.org/553631 | 03:56 |
*** yamamoto has quit IRC | 04:01 | |
openstackgerrit | Vu Cong Tuan proposed openstack/horizon master: Sahara projects have been migrated to Storyboard https://review.openstack.org/554409 | 04:02 |
*** germs has joined #openstack-horizon | 04:03 | |
*** germs has quit IRC | 04:03 | |
*** germs has joined #openstack-horizon | 04:03 | |
*** yamamoto has joined #openstack-horizon | 04:04 | |
*** germs has quit IRC | 04:07 | |
*** yamamoto has quit IRC | 04:08 | |
*** yamamoto has joined #openstack-horizon | 04:09 | |
*** yamamoto has quit IRC | 04:14 | |
*** wolverineav has quit IRC | 04:15 | |
*** yamamoto has joined #openstack-horizon | 04:16 | |
openstackgerrit | Merged openstack/horizon master: Sahara projects have been migrated to Storyboard https://review.openstack.org/554409 | 04:19 |
*** yamamoto has quit IRC | 04:27 | |
*** yamamoto has joined #openstack-horizon | 04:28 | |
*** wolverineav has joined #openstack-horizon | 04:42 | |
*** yamamoto has quit IRC | 04:43 | |
*** yamamoto has joined #openstack-horizon | 04:46 | |
*** wolverineav has quit IRC | 05:00 | |
*** wolverineav has joined #openstack-horizon | 05:01 | |
openstackgerrit | Adrian Turjak proposed openstack/horizon master: Fix wrong setting name for SHOW_KEYSTONE_V2_RC https://review.openstack.org/554413 | 05:03 |
*** wolverineav has quit IRC | 05:05 | |
*** masco has joined #openstack-horizon | 05:26 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Exclude nova-network quotas properly https://review.openstack.org/534386 | 05:27 |
*** btully has joined #openstack-horizon | 05:40 | |
*** btully has quit IRC | 05:44 | |
amotoki | I decided to hold my feature patches until related mock conversion patches land. features will come later after mock migration | 05:53 |
*** germs has joined #openstack-horizon | 06:04 | |
*** germs has quit IRC | 06:08 | |
*** e0ne has joined #openstack-horizon | 06:21 | |
*** ChanServ sets mode: +o e0ne | 06:21 | |
*** Jack_Iv has joined #openstack-horizon | 06:22 | |
*** Jack_Iv has quit IRC | 06:26 | |
*** dayou has joined #openstack-horizon | 06:48 | |
*** rcernin has quit IRC | 07:23 | |
*** rcernin has joined #openstack-horizon | 07:24 | |
*** rcernin has quit IRC | 07:24 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Update the doc links to the newest ones https://review.openstack.org/553825 | 07:25 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/554433 | 07:29 |
*** pcaruana has joined #openstack-horizon | 07:34 | |
*** lajoskatona has joined #openstack-horizon | 07:52 | |
*** tesseract has joined #openstack-horizon | 08:00 | |
*** namnh has joined #openstack-horizon | 08:01 | |
*** germs has joined #openstack-horizon | 08:05 | |
*** germs has quit IRC | 08:05 | |
*** germs has joined #openstack-horizon | 08:05 | |
*** jtomasek has joined #openstack-horizon | 08:05 | |
*** rmart04 has joined #openstack-horizon | 08:07 | |
*** priteau has joined #openstack-horizon | 08:08 | |
*** germs has quit IRC | 08:08 | |
openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/554433 | 08:18 |
*** dangtrinhnt has quit IRC | 08:23 | |
*** redondo-mk has quit IRC | 08:30 | |
*** redondo-mk has joined #openstack-horizon | 08:31 | |
*** fbouliane has quit IRC | 08:31 | |
*** fbouliane has joined #openstack-horizon | 08:33 | |
*** e0ne has quit IRC | 08:33 | |
openstackgerrit | Merged openstack/horizon master: Update the doc links to the newest ones https://review.openstack.org/553825 | 08:59 |
openstackgerrit | Shu Muto proposed openstack/ui-cookiecutter master: Run tox on created plugin https://review.openstack.org/554461 | 09:02 |
*** jpich has joined #openstack-horizon | 09:07 | |
openstackgerrit | Shu Muto proposed openstack/horizon master: Avoid popup blocker after key-pair creation https://review.openstack.org/554471 | 09:16 |
*** tosky has joined #openstack-horizon | 09:21 | |
amotoki | rdopiera: I cannot understand your comment https://review.openstack.org/#/c/534386/4/openstack_dashboard/api/nova.py | 09:26 |
rdopiera | amotoki: did you commit that change by mistake? | 09:26 |
amotoki | rdopiera: the code around your comment exists before my patch. | 09:26 |
rdopiera | amotoki: aah, you rebased? | 09:27 |
rdopiera | sorry, I didn't notice that | 09:27 |
rdopiera | I just looked at differences between this and previous patches | 09:27 |
amotoki | rdopiera: yeah, rebased to address merge conflict :) | 09:27 |
rdopiera | sorry | 09:27 |
amotoki | np | 09:27 |
amotoki | mock conversion gives me a lot of presents of merge conflicts :p | 09:28 |
rdopiera | yeah, that sucks | 09:28 |
rdopiera | but mox sucks even worse | 09:28 |
amotoki | yeah | 09:29 |
*** _glb has quit IRC | 09:30 | |
*** glb has joined #openstack-horizon | 09:31 | |
*** btully has joined #openstack-horizon | 09:33 | |
*** glb has quit IRC | 09:50 | |
*** glb has joined #openstack-horizon | 09:51 | |
*** gleblanc has joined #openstack-horizon | 09:53 | |
gleblanc | hello, here :) | 09:53 |
gleblanc | I encoutered this bug https://bugs.launchpad.net/horizon/+bug/1641383 but I have the patch ... | 09:54 |
openstack | Launchpad bug 1641383 in OpenStack Dashboard (Horizon) "Uploading OVA to Glance via Horizon Fails" [Low,Fix released] - Assigned to Jay Jahns (jjahns) | 09:54 |
*** e0ne has joined #openstack-horizon | 09:55 | |
*** ChanServ sets mode: +o e0ne | 09:55 | |
*** btully has quit IRC | 09:55 | |
gleblanc | And after some digging I found that there is the same code at two location ... I don't really know if it's normal | 09:55 |
gleblanc | maybe someone here can tell me if it is ? | 09:56 |
gleblanc | https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/glance.py#L307 | 09:56 |
gleblanc | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/images/forms.py#L47 | 09:56 |
*** yamamoto has quit IRC | 10:04 | |
*** germs has joined #openstack-horizon | 10:05 | |
*** germs has quit IRC | 10:05 | |
*** germs has joined #openstack-horizon | 10:05 | |
*** jtriley has quit IRC | 10:05 | |
*** yamamoto has joined #openstack-horizon | 10:09 | |
*** germs has quit IRC | 10:10 | |
*** namnh has quit IRC | 10:10 | |
*** yamamoto has quit IRC | 10:14 | |
e0ne | gleblanc: hi. code duplication is always not a good way | 10:20 |
rdopiera | except for tests | 10:21 |
e0ne | rdopiera: we can minimize duplication even in tests too | 10:27 |
gleblanc | yes I agree eOne. as I'm not a django developper I don't know where the use of one or another of this function is defined, do you know ? | 10:30 |
e0ne | gleblanc: what do you mean? | 10:30 |
*** mvk has quit IRC | 10:31 | |
rdopiera | e0ne: that's usually not a good idea | 10:32 |
e0ne | rdopiera: why? could you please provide some example or more details | 10:33 |
rdopiera | gleblanc: those functions are not used in django, they are only used in horizon, and you can simply grep the source code for the function name | 10:33 |
gleblanc | The two function, I mentionned above are not for test, no ? | 10:33 |
rdopiera | e0ne: code for a test should show all the steps that are being performed explicitly, if you start to refactor the common parts, you will end up with undreadable mess and tightly coupled tests, where changing one thing leads to changes everywhere | 10:35 |
rdopiera | e0ne: we have that in a few places, amotoki recently cleaned up a few | 10:36 |
e0ne | rdopiera: I understand your point | 10:36 |
e0ne | rdopiera: I mean that we can use setUp/cleanUp methods for tests | 10:37 |
e0ne | rdopiera: also we can use something like ddt or follow our current approach to create test data and have all checks in one place like https://github.com/openstack/horizon/blob/b8919e19af994f3dcf7f12a94e381534104ca5c7/openstack_dashboard/test/unit/api/test_nova.py#L332 | 10:40 |
rdopiera | e0ne: as long as the groupings make sense | 10:42 |
rdopiera | e0ne: but generally, the actions to be tested you want to keep explicit, even if they repeat | 10:42 |
gleblanc | And just for my information, do you know the difference between the file under horizon/openstack_dashboard/api/* and horizon/openstack_dashboard/dashboards/* ? | 10:43 |
rdopiera | gleblanc: the ones under api are for talking to the services, the ones under dashboards are for displaying the particular views | 10:46 |
*** mvk has joined #openstack-horizon | 10:46 | |
amotoki | gleblanc: regarding to your specific question on create_image_metadata, i think it is just from historical reason | 10:50 |
amotoki | gleblanc: openstack_dashboard/api/*.py are API wrappers for backend services. | 10:50 |
amotoki | gleblanc: openstack_dashboard/api/rest/*.py provides REST API for horizon angular implemenattions. | 10:50 |
amotoki | gleblanc: openstack_dashboard/dashboards/*.py implement particular views using Django | 10:51 |
amotoki | gleblanc: ideally create_image_metadata() in two places should be moved to openstack_dashboard/api/glance.py IMHO | 10:52 |
gleblanc | Ok, so if angular POST the form of an image of type OVA it will go in this file openstack_dashboard/api/rest/glance.py and fail. | 11:01 |
*** rcernin has joined #openstack-horizon | 11:02 | |
openstackgerrit | dongjx proposed openstack/horizon master: Delete choice of image source when file is the only option https://review.openstack.org/554504 | 11:02 |
*** rcernin has quit IRC | 11:06 | |
*** yamamoto has joined #openstack-horizon | 11:10 | |
*** yamamoto has quit IRC | 11:12 | |
*** yamamoto has joined #openstack-horizon | 11:12 | |
openstackgerrit | Adrian Turjak proposed openstack/horizon master: Fix wrong setting name for SHOW_KEYSTONE_V2_RC https://review.openstack.org/554413 | 11:16 |
*** pcaruana has quit IRC | 11:23 | |
*** dayou has quit IRC | 11:25 | |
*** jtriley has joined #openstack-horizon | 11:39 | |
*** yamamoto has quit IRC | 11:40 | |
*** yamamoto has joined #openstack-horizon | 11:41 | |
*** dayou has joined #openstack-horizon | 11:47 | |
amotoki | e0ne: hopefully the team discusses xstatic-core in the team meeting http://lists.openstack.org/pipermail/openstack-dev/2018-March/thread.html#128533 | 11:47 |
e0ne | amotoki: I didn't had a chance to read it yet:( | 11:48 |
amotoki | e0ne: no problem. I post some options in the last mail of the thread. | 11:51 |
*** pcaruana has joined #openstack-horizon | 11:55 | |
*** dangtrinhnt has joined #openstack-horizon | 12:04 | |
*** germs has joined #openstack-horizon | 12:06 | |
*** germs has quit IRC | 12:06 | |
*** germs has joined #openstack-horizon | 12:06 | |
*** germs has quit IRC | 12:10 | |
*** openstackgerrit has quit IRC | 12:33 | |
*** r-daneel has quit IRC | 12:41 | |
*** jtriley has quit IRC | 12:42 | |
*** dangtrinhnt has quit IRC | 13:06 | |
*** lblanchard has joined #openstack-horizon | 13:23 | |
*** btully has joined #openstack-horizon | 13:29 | |
*** r-daneel has joined #openstack-horizon | 13:32 | |
*** btully has quit IRC | 13:33 | |
*** r-daneel has quit IRC | 13:36 | |
*** jtriley has joined #openstack-horizon | 13:41 | |
*** lajoskatona has quit IRC | 13:59 | |
*** lblanchard has quit IRC | 14:01 | |
*** germs has joined #openstack-horizon | 14:07 | |
*** germs has quit IRC | 14:07 | |
*** germs has joined #openstack-horizon | 14:07 | |
*** germs has quit IRC | 14:11 | |
*** yamamoto_ has joined #openstack-horizon | 14:12 | |
*** yamamoto has quit IRC | 14:12 | |
*** pcaruana has quit IRC | 14:21 | |
*** felipemonteiro has joined #openstack-horizon | 14:27 | |
*** pcaruana has joined #openstack-horizon | 14:28 | |
*** felipemonteiro_ has joined #openstack-horizon | 14:29 | |
*** felipemonteiro has quit IRC | 14:32 | |
*** openstackgerrit has joined #openstack-horizon | 14:35 | |
openstackgerrit | Guillaume proposed openstack/horizon master: Allow OVA upload for images https://review.openstack.org/554572 | 14:35 |
*** Nil_ has joined #openstack-horizon | 14:35 | |
gleblanc | https://review.openstack.org/554572, merge the create_image_metadata() and fix the OVA image upload. And thanks amotoki for file hierarchy explanation :) | 14:45 |
*** itlinux has joined #openstack-horizon | 14:50 | |
*** r-daneel has joined #openstack-horizon | 14:55 | |
amotoki | gleblanc: thanks for the patch. I added comments for minor improvements and clean up. | 14:57 |
*** masco has quit IRC | 14:59 | |
gleblanc | amotoki: ok I will do that. | 15:03 |
openstackgerrit | Guillaume proposed openstack/horizon master: Allow OVA upload for images https://review.openstack.org/554572 | 15:16 |
*** yamamoto_ has quit IRC | 15:27 | |
*** dave-mccowan has joined #openstack-horizon | 15:29 | |
*** felipemonteiro_ has quit IRC | 15:48 | |
*** felipemonteiro_ has joined #openstack-horizon | 15:49 | |
*** felipemonteiro_ has quit IRC | 16:06 | |
*** gyee has joined #openstack-horizon | 16:26 | |
*** yamamoto has joined #openstack-horizon | 16:28 | |
*** wolverineav has joined #openstack-horizon | 16:33 | |
openstackgerrit | Guillaume proposed openstack/horizon master: Allow OVA upload for images https://review.openstack.org/554572 | 16:33 |
*** yamamoto has quit IRC | 16:34 | |
*** wolverineav has quit IRC | 16:38 | |
*** wolverineav has joined #openstack-horizon | 16:39 | |
*** rmart04 has quit IRC | 16:42 | |
*** mvk has quit IRC | 16:49 | |
*** felipemonteiro has joined #openstack-horizon | 16:55 | |
openstackgerrit | Guillaume proposed openstack/horizon master: Allow OVA upload for images https://review.openstack.org/554572 | 17:00 |
*** mvk has joined #openstack-horizon | 17:03 | |
*** felipemonteiro_ has joined #openstack-horizon | 17:04 | |
*** felipemonteiro has quit IRC | 17:08 | |
*** felipemonteiro has joined #openstack-horizon | 17:08 | |
*** felipemonteiro_ has quit IRC | 17:11 | |
openstackgerrit | Merged openstack/horizon master: Add plugin xstatic modules support https://review.openstack.org/552259 | 17:25 |
*** priteau has quit IRC | 17:30 | |
*** yamamoto has joined #openstack-horizon | 17:30 | |
*** gleblanc has quit IRC | 17:32 | |
*** e0ne has quit IRC | 17:35 | |
*** yamamoto has quit IRC | 17:36 | |
*** jpich has quit IRC | 17:50 | |
*** wolverineav has quit IRC | 18:03 | |
*** wolverineav has joined #openstack-horizon | 18:03 | |
openstackgerrit | Adrian Turjak proposed openstack/horizon master: Fix wrong setting name for SHOW_KEYSTONE_V2_RC https://review.openstack.org/554413 | 18:22 |
*** harlowja has joined #openstack-horizon | 18:23 | |
*** gyee has quit IRC | 18:30 | |
*** dave-mccowan has quit IRC | 18:32 | |
*** yamamoto has joined #openstack-horizon | 18:32 | |
*** yamamoto has quit IRC | 18:37 | |
*** dave-mccowan has joined #openstack-horizon | 18:45 | |
*** btully has joined #openstack-horizon | 18:55 | |
*** btully has quit IRC | 19:00 | |
*** dave-mccowan has quit IRC | 19:03 | |
*** rmart04 has joined #openstack-horizon | 19:15 | |
*** rmart04 has quit IRC | 19:20 | |
*** yamamoto has joined #openstack-horizon | 19:34 | |
*** dave-mccowan has joined #openstack-horizon | 19:36 | |
*** yamamoto has quit IRC | 19:39 | |
*** e0ne has joined #openstack-horizon | 19:53 | |
*** ChanServ sets mode: +o e0ne | 19:53 | |
*** tesseract has quit IRC | 19:56 | |
*** dave-mccowan has quit IRC | 20:03 | |
*** dave-mccowan has joined #openstack-horizon | 20:04 | |
*** germs has joined #openstack-horizon | 20:10 | |
*** germs has quit IRC | 20:10 | |
*** germs has joined #openstack-horizon | 20:10 | |
*** germs has quit IRC | 20:13 | |
openstackgerrit | Merged openstack/horizon master: Convert project tests into mock: cgroups/cg_snapshots https://review.openstack.org/531729 | 20:24 |
*** priteau has joined #openstack-horizon | 20:29 | |
*** dave-mccowan has quit IRC | 20:31 | |
*** openstackgerrit has quit IRC | 20:33 | |
*** yamamoto has joined #openstack-horizon | 20:35 | |
*** yamamoto has quit IRC | 20:41 | |
*** felipemonteiro_ has joined #openstack-horizon | 20:51 | |
*** felipemonteiro has quit IRC | 20:54 | |
*** dave-mccowan has joined #openstack-horizon | 21:00 | |
*** jtriley has quit IRC | 21:03 | |
*** itlinux has quit IRC | 21:31 | |
*** e0ne has quit IRC | 21:33 | |
*** yamamoto has joined #openstack-horizon | 21:37 | |
*** yamamoto has quit IRC | 21:43 | |
*** openstackgerrit has joined #openstack-horizon | 21:53 | |
openstackgerrit | Merged openstack/horizon master: Update docstring of test.helpers.create_mocks https://review.openstack.org/546648 | 21:53 |
*** germs has joined #openstack-horizon | 22:10 | |
*** germs has quit IRC | 22:10 | |
*** germs has joined #openstack-horizon | 22:10 | |
*** rcernin has joined #openstack-horizon | 22:13 | |
*** germs has quit IRC | 22:14 | |
*** priteau has quit IRC | 22:15 | |
*** priteau has joined #openstack-horizon | 22:15 | |
*** dave-mccowan has quit IRC | 22:17 | |
*** felipemonteiro_ has quit IRC | 22:18 | |
*** priteau has quit IRC | 22:20 | |
*** dave-mccowan has joined #openstack-horizon | 22:28 | |
*** ianychoi__ is now known as ianychoi | 22:32 | |
*** btully has joined #openstack-horizon | 22:33 | |
*** btully has quit IRC | 22:37 | |
*** yamamoto has joined #openstack-horizon | 22:39 | |
*** yamamoto has quit IRC | 22:45 | |
*** harlowja has quit IRC | 22:57 | |
*** Anticime1 is now known as Anticimex | 23:29 | |
*** tosky has quit IRC | 23:34 | |
*** yamamoto has joined #openstack-horizon | 23:41 | |
*** yamamoto has quit IRC | 23:46 | |
*** harlowja has joined #openstack-horizon | 23:49 | |
*** felipemonteiro has joined #openstack-horizon | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!