*** Daisy_ has quit IRC | 00:03 | |
*** itlinux has joined #openstack-horizon | 00:07 | |
*** felipemonteiro_ has joined #openstack-horizon | 00:17 | |
*** dave-mccowan has joined #openstack-horizon | 00:22 | |
*** threestrands has joined #openstack-horizon | 00:27 | |
*** threestrands has quit IRC | 00:27 | |
*** threestrands has joined #openstack-horizon | 00:27 | |
*** itlinux has quit IRC | 00:34 | |
*** zhurong has joined #openstack-horizon | 00:47 | |
*** harlowja has joined #openstack-horizon | 00:57 | |
*** tosky has quit IRC | 01:09 | |
*** zhurong has quit IRC | 01:11 | |
*** zhurong has joined #openstack-horizon | 01:14 | |
*** threestrands has quit IRC | 01:29 | |
*** Jeffrey4l has joined #openstack-horizon | 01:34 | |
*** Daisy_ has joined #openstack-horizon | 01:37 | |
*** Nil_ has quit IRC | 01:38 | |
*** Daisy_ has quit IRC | 01:39 | |
*** Daisy_ has joined #openstack-horizon | 01:39 | |
*** r-daneel has quit IRC | 01:45 | |
*** Jeffrey4l_ has joined #openstack-horizon | 01:46 | |
*** Jeffrey4l has quit IRC | 01:47 | |
*** absubram has quit IRC | 02:10 | |
*** ramineni_ has joined #openstack-horizon | 02:28 | |
*** namnh has joined #openstack-horizon | 02:37 | |
*** Daisy_ has quit IRC | 03:39 | |
*** Daisy_ has joined #openstack-horizon | 03:39 | |
*** Daisy_ has quit IRC | 03:44 | |
*** dave-mccowan has quit IRC | 03:48 | |
*** felipemonteiro__ has joined #openstack-horizon | 04:05 | |
*** felipemonteiro__ has quit IRC | 04:05 | |
*** felipemonteiro__ has joined #openstack-horizon | 04:06 | |
*** felipemonteiro_ has quit IRC | 04:08 | |
*** namnh has quit IRC | 04:13 | |
*** openstackgerrit has joined #openstack-horizon | 04:13 | |
openstackgerrit | baiwenteng proposed openstack/horizon master: Fix typos in horizon https://review.openstack.org/542582 | 04:13 |
---|---|---|
*** absubram has joined #openstack-horizon | 04:15 | |
*** absubram_ has joined #openstack-horizon | 04:17 | |
*** absubram has quit IRC | 04:19 | |
*** absubram_ is now known as absubram | 04:19 | |
*** felipemonteiro__ has quit IRC | 04:33 | |
*** zhurong has quit IRC | 04:35 | |
*** ying_zuo changes topic to "OpenStack Horizon | Rocky PTG: https://etherpad.openstack.org/p/horizon-ptg-rocky | Queens-RC2 priorities: https://launchpad.net/horizon/+milestone/queens-rc2 | Docs: https://docs.openstack.org/horizon/latest/" | 04:44 | |
openstackgerrit | baiwenteng proposed openstack/horizon master: Fix typos in horizon https://review.openstack.org/542582 | 04:56 |
*** Daisy_ has joined #openstack-horizon | 05:02 | |
*** Daisy_ has quit IRC | 05:02 | |
*** Daisy_ has joined #openstack-horizon | 05:02 | |
*** harlowja has quit IRC | 05:10 | |
*** ramineni_ has quit IRC | 05:18 | |
*** harlowja has joined #openstack-horizon | 05:35 | |
*** zhurong has joined #openstack-horizon | 05:35 | |
*** harlowja has quit IRC | 05:39 | |
*** itlinux has joined #openstack-horizon | 05:58 | |
*** e0ne has joined #openstack-horizon | 06:05 | |
*** e0ne has quit IRC | 06:06 | |
*** itlinux has quit IRC | 06:27 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/542627 | 06:38 |
*** vladiskuz_ has joined #openstack-horizon | 06:55 | |
*** namnh has joined #openstack-horizon | 07:03 | |
*** rcernin has quit IRC | 07:17 | |
*** rmart04 has joined #openstack-horizon | 07:17 | |
openstackgerrit | OpenStack Release Bot proposed openstack/horizon master: Update reno for stable/queens https://review.openstack.org/542663 | 07:20 |
*** rmart04 has quit IRC | 07:22 | |
*** lvdombrkr has joined #openstack-horizon | 07:24 | |
*** e0ne has joined #openstack-horizon | 07:27 | |
*** lajoskatona has joined #openstack-horizon | 07:34 | |
*** pcaruana has joined #openstack-horizon | 07:35 | |
*** rubasov has left #openstack-horizon | 08:02 | |
vladiskuz_ | ying_zuo: Could you take a look at this patch please https://review.openstack.org/#/c/541676/ | 08:16 |
*** makowals has quit IRC | 08:23 | |
*** tesseract has joined #openstack-horizon | 08:26 | |
*** namnh has quit IRC | 08:27 | |
*** lvdombrkr has quit IRC | 08:37 | |
*** lvdombrkr has joined #openstack-horizon | 08:39 | |
*** kairat has left #openstack-horizon | 08:45 | |
*** vladiskuz_ has quit IRC | 09:01 | |
*** jpich has joined #openstack-horizon | 09:02 | |
*** zhurong has quit IRC | 09:16 | |
*** Jeffrey4l_ has quit IRC | 09:17 | |
*** Jeffrey4l has joined #openstack-horizon | 09:18 | |
*** Daisy_ has quit IRC | 09:21 | |
*** lvdombrkr has quit IRC | 09:42 | |
*** J2LERVevercle has joined #openstack-horizon | 10:12 | |
J2LERVevercle | (_) | | | 10:12 |
J2LERVevercle | (_) | | | 10:12 |
*** J2LERVevercle has quit IRC | 10:12 | |
*** tosky has joined #openstack-horizon | 10:54 | |
*** absubram has quit IRC | 11:00 | |
*** absubram has joined #openstack-horizon | 11:02 | |
*** awestin1 has quit IRC | 12:32 | |
*** awestin1 has joined #openstack-horizon | 12:33 | |
*** Arsalan has joined #openstack-horizon | 12:42 | |
*** serverascode has quit IRC | 12:48 | |
*** serverascode has joined #openstack-horizon | 12:48 | |
*** ameade has quit IRC | 12:50 | |
*** lvdombrkr has joined #openstack-horizon | 12:50 | |
*** ameade has joined #openstack-horizon | 12:51 | |
*** tesseract has quit IRC | 13:12 | |
*** ameeda has quit IRC | 13:28 | |
*** lvdombrkr has quit IRC | 13:28 | |
*** lvdombrkr has joined #openstack-horizon | 13:31 | |
*** betherly has quit IRC | 13:34 | |
*** betherly has joined #openstack-horizon | 13:35 | |
*** dave-mccowan has joined #openstack-horizon | 13:47 | |
openstackgerrit | Merged openstack/horizon master: Update reno for stable/queens https://review.openstack.org/542663 | 13:49 |
*** dave-mcc_ has joined #openstack-horizon | 13:54 | |
*** dave-mccowan has quit IRC | 13:55 | |
*** yamamoto has quit IRC | 13:56 | |
*** yamamoto has joined #openstack-horizon | 13:56 | |
openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/542627 | 13:57 |
*** yamamoto has quit IRC | 13:57 | |
*** yamamoto has joined #openstack-horizon | 13:57 | |
openstackgerrit | Merged openstack/horizon master: Enable more hacking-extensions https://review.openstack.org/538817 | 14:00 |
e0ne | rdopiera: hi. are you around? | 14:03 |
*** johnsom has quit IRC | 14:03 | |
*** johnsom has joined #openstack-horizon | 14:04 | |
*** Arsalan has quit IRC | 14:11 | |
openstackgerrit | Merged openstack/horizon master: Refactor the create port form to workflow https://review.openstack.org/540462 | 14:11 |
*** ethfci_ has joined #openstack-horizon | 14:15 | |
*** ethfci has quit IRC | 14:15 | |
*** dave-mcc_ has quit IRC | 14:17 | |
*** ethfci_ has quit IRC | 14:21 | |
*** ethfci has joined #openstack-horizon | 14:22 | |
*** tesseract has joined #openstack-horizon | 14:28 | |
*** david-lyle has quit IRC | 14:29 | |
*** dave-mccowan has joined #openstack-horizon | 14:29 | |
*** dave-mccowan has quit IRC | 14:40 | |
*** berendt has quit IRC | 14:46 | |
*** berendt has joined #openstack-horizon | 14:46 | |
openstackgerrit | Merged openstack/horizon master: Support specified security groups when creating a port https://review.openstack.org/540463 | 14:47 |
openstackgerrit | Merged openstack/horizon master: Filtering networks or routers by non-existing tenants return an empty list https://review.openstack.org/536687 | 14:50 |
*** hogepodge has quit IRC | 14:51 | |
*** hogepodge has joined #openstack-horizon | 14:52 | |
*** wolverineav has joined #openstack-horizon | 14:52 | |
openstackgerrit | Merged openstack/horizon master: Fix collectstatic in case of theme customization https://review.openstack.org/535674 | 14:52 |
*** r-daneel has joined #openstack-horizon | 14:57 | |
*** jtriley has joined #openstack-horizon | 14:58 | |
*** dave-mccowan has joined #openstack-horizon | 15:03 | |
*** felipemonteiro__ has joined #openstack-horizon | 15:12 | |
*** lajoskatona has quit IRC | 15:21 | |
*** felipemonteiro_ has joined #openstack-horizon | 15:21 | |
amotoki | rdopiera: ping | 15:23 |
*** felipemonteiro__ has quit IRC | 15:25 | |
*** david-lyle has joined #openstack-horizon | 15:30 | |
*** ChanServ sets mode: +o david-lyle | 15:30 | |
*** lvdombrkr has quit IRC | 15:34 | |
rdopiera | amotoki: pong | 15:36 |
e0ne | rdopiera: did you talk about moving away from nose some time ago? | 15:37 |
rdopiera | e0ne: yes, I did some experiments with pytest, but concluded it was much more work than I anticipated | 15:38 |
e0ne | :( | 15:38 |
rdopiera | e0ne: sorry, I didn't see your hightlight because of the space in front | 15:39 |
e0ne | np | 15:39 |
e0ne | I'm trying to figure out what is going with our selenium-related tests | 15:39 |
rdopiera | e0ne: so, basically, we would need to adapt all parts that use nose-django to use pytest-django | 15:39 |
rdopiera | ah, I had that in my todo too, and even started to work on it, but didn't get them to run | 15:40 |
e0ne | so, there are 3 parts of them: | 15:41 |
e0ne | 1) functional tests which are not maintained for 3+ releases and broken:( | 15:42 |
rdopiera | right, that's what I wanted to bring back | 15:42 |
e0ne | rdopiera: ++++++. I'm going to make it my priority for Rocky | 15:42 |
rdopiera | what are the other 2? | 15:43 |
e0ne | 2) some tests with django live server and selenium - they code are mixed with unit-tests. we run them on CI with 'tox -e selenium' | 15:43 |
e0ne | 3) something I can't launch https://github.com/openstack/horizon/tree/master/openstack_dashboard/test/selenium - we don't run this one and the same for horizon package at all | 15:43 |
rdopiera | I think that one was run as a smoke test at some point | 15:44 |
rdopiera | maybe it was in tripleo, I can't rememebr | 15:45 |
e0ne | so, my current plan is remove #3 and split out selenium tests (#2) from unit tests | 15:45 |
rdopiera | sounds reasonable | 15:45 |
e0ne | after it, we can work on our integration tests | 15:45 |
e0ne | btw, are you going to PTG this time? | 15:46 |
rdopiera | yes | 15:46 |
e0ne | great | 15:46 |
rdopiera | I'm happy for it too | 15:46 |
e0ne | :) | 15:46 |
amotoki | rdopiera: hi | 15:47 |
amotoki | if the current topic discussed isn't over, i will wait for a while | 15:47 |
rdopiera | amotoki: I think we are done, what's on your mind? | 15:47 |
amotoki | rdopiera: thanks for your comment on my pluggable tab patch https://review.openstack.org/#/c/540097/ | 15:48 |
amotoki | rdopiera: do you suggest to add 'tabs' configuration to 'enabled' file(s) which define panel or panel group, even though they are not directly related? | 15:49 |
amotoki | rdopiera: I am okay to expand the current 'enabled' file. | 15:49 |
rdopiera | amotoki: I didn't think about it in depth, but I think it would be good to have a single consistent mechanism for the plugins | 15:50 |
amotoki | rdopiera: yeah, I understand your point on consistency | 15:50 |
*** absubram has quit IRC | 15:50 | |
*** absubram_ has joined #openstack-horizon | 15:50 | |
rdopiera | it's just a gut feeling, though, and I will not insist on it | 15:50 |
*** david-lyle has quit IRC | 15:51 | |
amotoki | rdopiera: oh! I just remember there is one way to define 'enabled' file without a panel or a panel group. | 15:51 |
rdopiera | we do need some way for letting packagers make an opt-in mechanism (even if we ship it as opt-out by default) | 15:51 |
rdopiera | amotoki: well, we can always modify the code that reads the enabled files to not require panels or groups at all | 15:52 |
rdopiera | it's our code, we can do whatever we want with it | 15:52 |
amotoki | rdopiera: like this https://github.com/openstack/neutron-fwaas-dashboard/blob/master/neutron_fwaas_dashboard/enabled/_7010_project_firewalls_common.py#L13-L16 | 15:52 |
amotoki | rdopiera: "FEATURE" is not documented but it actually works :) | 15:53 |
rdopiera | nice! | 15:53 |
amotoki | so my first question is resolved | 15:53 |
amotoki | rdopiera: the second point is I am not sure why you perfer to double opt-in mechanism | 15:54 |
amotoki | rdopiera: i think installing horizon plugin itself is the first level of opt-in | 15:54 |
rdopiera | ok, let me give you our use case | 15:54 |
rdopiera | in RDO we are switching to using Docker by default | 15:54 |
rdopiera | so Horizon will be running in its own Docker container | 15:54 |
*** david-lyle has joined #openstack-horizon | 15:55 | |
*** ChanServ sets mode: +o david-lyle | 15:55 | |
amotoki | yeah, i heard it | 15:55 |
rdopiera | we prepare the images up front, so such a horizon container will have all the supported plugins installed | 15:55 |
rdopiera | now, for a customer who only wants a certain set of plugins enabled, they will need some mechanism for that | 15:55 |
amotoki | so you need a way to enable/disable something | 15:56 |
rdopiera | kolla right now does that by moving the enabled files around | 15:56 |
rdopiera | right | 15:56 |
rdopiera | now, why opt-in | 15:56 |
rdopiera | suppose you have your rdo stack installed and configured | 15:56 |
rdopiera | and you do an upgrade | 15:56 |
rdopiera | and the new version of the horizon container has some additional new plugins supported | 15:57 |
amotoki | can't the default setting opt-out new plugins? | 15:57 |
amotoki | *default setting of the horizon container* | 15:57 |
rdopiera | that would require us to edit the config files that have already been customised by the user | 15:58 |
rdopiera | to add the new plugins to the blacklist | 15:58 |
rdopiera | which I suppose is tricky to do right | 15:58 |
amotoki | it's understandable as distributor perspective | 15:58 |
*** r-daneel has quit IRC | 15:59 | |
rdopiera | I'm thinking, if the plugins install their enabled files by default in horizon (which they do), in the simple case you would have them automatically enabled anyways | 15:59 |
amotoki | as an operator deploying openstack from source, double opt-in is too much. we usually think why horizon plugins are configured by default... | 15:59 |
rdopiera | and for our docker use case we would remove those enabled files | 15:59 |
rdopiera | the problem is that many deployers don't control what is installed in their system | 16:00 |
rdopiera | not directly | 16:00 |
rdopiera | you can't assume they are going to only have installed the packages that they need, and nothing else | 16:01 |
amotoki | I am not sure "many" deployers or "some" though | 16:01 |
*** pcaruana has quit IRC | 16:01 | |
rdopiera | anybody who's not installing from source, practically | 16:01 |
rdopiera | and that's 99% production environments, I guess | 16:02 |
amotoki | but all-in-one is a choice of distributor | 16:02 |
*** witek has quit IRC | 16:02 | |
amotoki | in ubuntu package case, we can install octavia-dashboard for example if we need octavia dashboard | 16:02 |
amotoki | i guess this kind of choice is not so special | 16:03 |
rdopiera | and what if you need some other thing that depends on octavia-dashboard, but you don't want octavia-dashboard? | 16:03 |
rdopiera | or you are running several installations of Horizon on the same host, and one needs the octavia-dashboard, while the other doesn't? | 16:04 |
amotoki | if it is 10% case, it is sufficient if there is a way to opt-out it. | 16:04 |
rdopiera | but opt-out is fragile during updates | 16:04 |
amotoki | why? | 16:05 |
rdopiera | in any case, the ubuntu octavia-dashboard package can contain the "enabled" file for it, so that you don't need to do anything else but installing it | 16:05 |
*** witek has joined #openstack-horizon | 16:05 | |
amotoki | yes, in this case. | 16:06 |
rdopiera | and the red hat package may move that file somewhere else and only put it in enabled directory when explicitly enabled, like kolla does right now | 16:06 |
*** e0ne has quit IRC | 16:06 | |
rdopiera | there is no way to do that with the setuptools endpoint approach, though | 16:06 |
rdopiera | as the endpoints are global in the system | 16:07 |
amotoki | yes, the endpoint approach is global but this is not related to opt-in/opt-out thing. If there is a way to disable (or not to load) it it is now configurable. | 16:08 |
rdopiera | that's the main problem I had with stevedore | 16:08 |
amotoki | perhaps i understand the current problem of entrypoints in my implementation. the current version has no way to enable/disable it. | 16:10 |
*** itlinux has joined #openstack-horizon | 16:10 | |
rdopiera | sysadmins are paranoid creatures, they hate it when something happens "automatically" without their permission | 16:11 |
amotoki | this is different from opt-in/opt-out topic. what sysadmin needs is to control enabling/disabling it. | 16:12 |
rdopiera | yes, but also don't have it getting enabled automatically on update | 16:12 |
rdopiera | I'm much less firm on that point, though | 16:13 |
rdopiera | I know that we need a mechanism for enabling/disabling for sure, because if we don't include it, someone will hack it on top of our code | 16:14 |
rdopiera | but I'm not so sure about the opt-in/opt-out thing -- it's just opt-in would be more convenient to sysadmins | 16:15 |
amotoki | if we use all-in-one as you mention, the second level of opt-in will be a must thing | 16:17 |
rdopiera | it could be optinally enabled by the packagers | 16:18 |
amotoki | if we can install individual packages as sysadmin choice, the second level opt-in will be sometimes annoying and it is convenient if the default suggested settings is enabled by default | 16:18 |
rdopiera | so can we have an option? | 16:18 |
amotoki | all enabled files should be not enabled by default? | 16:19 |
rdopiera | for example, if there is no list of enabled plugins, use all installed plugins, but if there is a list, only use the ones in the list? | 16:19 |
amotoki | just a joke | 16:19 |
amotoki | that might work | 16:20 |
rdopiera | another thing I wanted to talk about, do you think it would make sense to replace the enabled files with stevedore eventually? | 16:21 |
amotoki | rdopiera: I think it depends on types of settings. | 16:21 |
amotoki | at now, there are two types of configurations. stevedore way make more sense for settings everyone must register. | 16:22 |
amotoki | on the other hand, the order of panels or enabling/disabling panels cannot be handled by entrypoints. | 16:23 |
amotoki | registering something and enabling something are different things. | 16:24 |
rdopiera | so, stevedore plus greatly simplifiedd "enabled" files? | 16:25 |
amotoki | yes, I think it is better than now | 16:25 |
amotoki | but I have no plan to move forward entrypoints things. | 16:25 |
rdopiera | as for things like order, that could live in the plugin's class itself | 16:25 |
amotoki | is it possible? | 16:26 |
rdopiera | or even on the Panel class | 16:26 |
rdopiera | the Panel class could have a "priority" attribute by which we could sort | 16:26 |
rdopiera | or something like that | 16:26 |
david-lyle | Panel class requires code change | 16:26 |
rdopiera | sure | 16:27 |
david-lyle | the enabled files were added to remove that need, enabled file excluded of course | 16:27 |
amotoki | if multiple plugins adds their panels to one panel group, I am afraid embedded priority doesn't work | 16:27 |
rdopiera | how is it done now? | 16:27 |
amotoki | it is determined by the number of 'enabled' files | 16:28 |
david-lyle | just alphabetical order of enabled files | 16:28 |
rdopiera | so the priority is in the file's name | 16:28 |
amotoki | yes | 16:28 |
david-lyle | those files can be renamed or overridden in local/enableds | 16:28 |
rdopiera | do we have any actual use cases where you need to move the panels around? | 16:29 |
david-lyle | downstream deployers will reorg the panels in panel groups | 16:30 |
david-lyle | new panel groups | 16:30 |
david-lyle | or insert custom panels into the order | 16:30 |
rdopiera | in my experience, the "enabled" files get installed with the plugin's package | 16:30 |
amotoki | yes | 16:31 |
amotoki | if you would like to disable _1490_project_floating_ips_panel.py (FIP panel) | 16:32 |
amotoki | you can put local/enabled/_1490_project_floating_ips_panel.py (same file name) which contains DISABLED = True | 16:32 |
david-lyle | exactly | 16:32 |
david-lyle | that was the design | 16:32 |
amotoki | (it did not work in the initial implementation though) | 16:33 |
david-lyle | I did say design :) | 16:33 |
amotoki | :) | 16:33 |
david-lyle | first implementation was a good start, but needed work for sure | 16:33 |
*** felipemonteiro_ has quit IRC | 16:34 | |
*** felipemonteiro_ has joined #openstack-horizon | 16:34 | |
amotoki | david-lyle: what is the purpose of REMOVE_PANEL? this is the only I cannot understand why we need it. | 16:34 |
david-lyle | amotoki, let me verify, but I though that was essentially nav=False while leaving the plugin content loaded, but I may have that reversed. | 16:35 |
david-lyle | checking | 16:35 |
david-lyle | I believe what I wrote is correct | 16:37 |
amotoki | what does nav=False mean? | 16:37 |
david-lyle | DISABLED=True will not load the plugin content | 16:37 |
david-lyle | amotoki, that's the old way in the panel file of not including an entry for the panel in the left hand navigation | 16:38 |
david-lyle | content is still accessible | 16:38 |
amotoki | ah, i see. | 16:38 |
david-lyle | so the dependent panel case that rdopiera mentioned earlier can be supported | 16:38 |
david-lyle | around octavia | 16:38 |
rdopiera | so we had some panels that required other panels | 16:39 |
amotoki | note thta actually there is no such plugin which depends on octavia-dashbaord. that's just an exaple. | 16:39 |
rdopiera | so you wanted to have it loaded, but not displayed | 16:39 |
david-lyle | or a plugin may load several panels, but an implementation doesn't want to support one of them | 16:40 |
amotoki | i think we can use "FEATURE" keyword to load plugin contents like INSTALLED_APPS. | 16:40 |
david-lyle | amotoki, I understand | 16:40 |
rdopiera | by the way, do we still have ceilometer panel, or was it completely removed? | 16:40 |
david-lyle | rdopiera, removed IIRC | 16:40 |
amotoki | it does not exist in horizon | 16:40 |
rdopiera | thanks | 16:41 |
*** dveem has joined #openstack-horizon | 16:41 | |
amotoki | AFAIK ceilometer project des not provide any horizon plugin too | 16:41 |
david-lyle | per request of ceilometer project we removed it | 16:41 |
rdopiera | great, thanks, just wanted to make sure | 16:41 |
david-lyle | there was an alarming one in progress, not sure if it finalized ever | 16:41 |
amotoki | gnocchi provides its own gui and we can check some meters using it | 16:42 |
david-lyle | not seeing aodh plugin | 16:43 |
david-lyle | amotoki, do you use gnocchi internally? | 16:44 |
david-lyle | out of curiosity | 16:44 |
amotoki | david-lyle: I myself don't use it, but I heard it from my OPNFV collegue | 16:45 |
david-lyle | ok thanks | 16:45 |
amotoki | I also saw some openstack-dev ML thread on that. | 16:45 |
amotoki | searching | 16:45 |
amotoki | david-lyle: https://github.com/gnocchixyz/grafana-gnocchi-datasource | 16:46 |
david-lyle | amotoki, thanks | 16:47 |
amotoki | rdopiera: anyway I will rewrite my pluggable tab patch to use horizon plugin files. | 16:48 |
rdopiera | amotoki: awesome, sorry for the extra work | 16:49 |
amotoki | rdopiera: no problem. it makes sense and it was what I expected a bit when I use stevedore :p | 16:49 |
rdopiera | it's great that you are pushing new approaches, I really appreciate that | 16:50 |
amotoki | I am thinking to make quotas/service-info tabs pluggable using it too | 16:51 |
amotoki | using tabs in overview panels does not work somehow..... piechart seems to ignore hidden tab.... | 16:52 |
rdopiera | this is a very... fertile piece of horizon, if you know what I mean | 16:53 |
rdopiera | it's been around for long and it grew organically | 16:54 |
david-lyle | amotoki, I had trouble with lazy loading and JS in the network_topology panesl | 16:54 |
amotoki | david-lyle: how did you debug it? | 16:54 |
david-lyle | trying to remember my eventual workaroudn, but I think I had to load all when panel is initialized | 16:55 |
amotoki | i see your comment in horizon.tabs.js on some hack on d3 | 16:55 |
david-lyle | haha, well at least I documented it | 16:55 |
david-lyle | it's been a while, but I think actually the rendering may have happened but out of the viewport | 16:57 |
david-lyle | I remember fighting that for a while | 16:58 |
amotoki | it looks like a complicated thing | 16:58 |
david-lyle | the commit message has more details https://review.openstack.org/#/c/282548/ | 16:59 |
david-lyle | the panel content size was 0x0 | 17:00 |
david-lyle | so I used a resize to retrigger the render | 17:00 |
david-lyle | the other option could be to set all tabs sizes based on the visible panel | 17:01 |
david-lyle | but that might happen too late, and I think d3 and the flow layout might still have problems | 17:01 |
david-lyle | amotoki, are your tabs just missing the pie charts? | 17:02 |
amotoki | david-lyle: no. my situation is completely opposite. piecharts in a hidden tab is also shown... | 17:03 |
david-lyle | ah so the display:none is not being set | 17:04 |
david-lyle | wonder why | 17:04 |
amotoki | I tried to tabbify the overview panel and each tab uses limit_summary.html as a template. | 17:05 |
amotoki | I haven't investigated the detail yet. | 17:05 |
david-lyle | chrome and firefox both include a build in js debugger, I found stardard printf style debugging to most effective | 17:05 |
david-lyle | where printf in this case is logging to the js console | 17:06 |
amotoki | printf is usually? sometimes? a powerful debuger :) | 17:07 |
*** jpich has quit IRC | 17:32 | |
*** yamamoto has quit IRC | 17:35 | |
*** absubram_ has quit IRC | 17:36 | |
*** harlowja has joined #openstack-horizon | 17:37 | |
*** yamamoto has joined #openstack-horizon | 17:37 | |
*** yamamoto has quit IRC | 17:39 | |
*** r-daneel has joined #openstack-horizon | 17:48 | |
*** jtriley has quit IRC | 17:48 | |
*** david-lyle has quit IRC | 17:50 | |
*** dave-mccowan has quit IRC | 17:57 | |
*** dave-mccowan has joined #openstack-horizon | 17:59 | |
*** jtriley has joined #openstack-horizon | 18:14 | |
*** jtriley has quit IRC | 18:19 | |
*** jtriley has joined #openstack-horizon | 18:26 | |
*** tosky has quit IRC | 18:37 | |
*** yamamoto has joined #openstack-horizon | 18:40 | |
*** lvdombrkr has joined #openstack-horizon | 18:40 | |
*** lvdombrkr has quit IRC | 18:44 | |
*** yamamoto has quit IRC | 18:47 | |
*** tosky has joined #openstack-horizon | 19:01 | |
*** david-lyle has joined #openstack-horizon | 19:02 | |
*** ChanServ sets mode: +o david-lyle | 19:02 | |
*** jtriley has quit IRC | 19:06 | |
*** lbragstad has quit IRC | 19:18 | |
*** jtriley has joined #openstack-horizon | 19:28 | |
*** lbragstad has joined #openstack-horizon | 19:37 | |
*** idlemind has quit IRC | 19:37 | |
*** idlemind has joined #openstack-horizon | 19:38 | |
*** tesseract has quit IRC | 20:00 | |
*** e0ne has joined #openstack-horizon | 20:18 | |
*** jtriley has quit IRC | 20:20 | |
*** e0ne has quit IRC | 20:20 | |
*** jtriley has joined #openstack-horizon | 20:37 | |
*** dave-mccowan has quit IRC | 20:39 | |
*** e0ne has joined #openstack-horizon | 20:47 | |
*** e0ne has quit IRC | 21:13 | |
*** DuncanT has quit IRC | 21:49 | |
*** DuncanT has joined #openstack-horizon | 21:49 | |
*** gary-smith has quit IRC | 21:56 | |
*** gary-smith has joined #openstack-horizon | 22:03 | |
*** kong has quit IRC | 22:05 | |
*** kong has joined #openstack-horizon | 22:06 | |
*** r-daneel has quit IRC | 22:09 | |
*** dave-mccowan has joined #openstack-horizon | 22:40 | |
*** cargonza has quit IRC | 22:53 | |
*** cargonza has joined #openstack-horizon | 22:54 | |
*** AndyWojo has quit IRC | 23:04 | |
*** AndyWojo has joined #openstack-horizon | 23:04 | |
*** jtomasek has quit IRC | 23:11 | |
*** jtriley has quit IRC | 23:38 | |
*** lbragstad has quit IRC | 23:49 | |
*** wolverineav has quit IRC | 23:56 | |
*** wolverineav has joined #openstack-horizon | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!