*** dave-mcc_ has joined #openstack-horizon | 00:04 | |
*** dave-mccowan has quit IRC | 00:07 | |
*** flwang1 has quit IRC | 00:23 | |
*** zhurong has joined #openstack-horizon | 00:45 | |
openstackgerrit | yanghuichan proposed openstack/horizon master: Replace dict.iteritems() with dict.items() in horizon https://review.openstack.org/485499 | 00:55 |
---|---|---|
*** deep-book-gk has joined #openstack-horizon | 01:02 | |
*** deep-book-gk has left #openstack-horizon | 01:03 | |
*** ducttape_ has joined #openstack-horizon | 01:04 | |
*** ducttape_ has quit IRC | 01:08 | |
*** ducttape_ has joined #openstack-horizon | 01:51 | |
*** ducttape_ has quit IRC | 01:56 | |
*** shu-mutou-AWAY is now known as shu-mutou | 02:51 | |
openstackgerrit | Shu Muto proposed openstack/horizon master: Commonize load-edit directive https://review.openstack.org/483810 | 03:05 |
openstackgerrit | Shu Muto proposed openstack/horizon master: Use load-edit directive in import key pair https://review.openstack.org/487689 | 03:06 |
openstackgerrit | Ying Zuo proposed openstack/horizon master: Fix style of the submit button on confirmation modal https://review.openstack.org/339278 | 03:39 |
*** udesale has joined #openstack-horizon | 03:47 | |
*** ducttape_ has joined #openstack-horizon | 03:52 | |
*** ducttape_ has quit IRC | 03:56 | |
*** junbo has joined #openstack-horizon | 04:07 | |
*** ircuser-1 has quit IRC | 04:23 | |
*** udesale__ has joined #openstack-horizon | 04:31 | |
*** udesale has quit IRC | 04:33 | |
*** udesale__ has quit IRC | 04:38 | |
openstackgerrit | Shu Muto proposed openstack/horizon master: Fix translation tag for datepicker https://review.openstack.org/489090 | 05:07 |
*** udesale__ has joined #openstack-horizon | 05:07 | |
*** GK1wmSU has joined #openstack-horizon | 05:25 | |
*** GK1wmSU has left #openstack-horizon | 05:27 | |
*** zhurong has quit IRC | 05:29 | |
*** ratailor has joined #openstack-horizon | 05:32 | |
amotoki__ | rdopiera: (late response) I took over https://review.openstack.org/#/c/404178/ but I totally forgot it..... | 05:35 |
*** _GK1wmSU has joined #openstack-horizon | 05:39 | |
*** _GK1wmSU has left #openstack-horizon | 05:42 | |
*** ducttape_ has joined #openstack-horizon | 05:53 | |
*** ducttape_ has quit IRC | 05:58 | |
*** rcernin has joined #openstack-horizon | 06:11 | |
*** pcaruana has joined #openstack-horizon | 06:19 | |
openstackgerrit | Ying Zuo proposed openstack/horizon master: Fix style of the submit button on confirmation modal https://review.openstack.org/339278 | 06:20 |
robcresswell | amotoki__: haha | 06:31 |
robcresswell | Oh well :) | 06:31 |
amotoki__ | robcresswell: yeah... two or three months ago, there are many patches which touched neutron ports and I was tired to rebase. I thought it was better to wait for a while, but .... | 06:33 |
amotoki__ | we are in the feature freeze. I wonder it is better to wait for Queens open or do it now. | 06:33 |
*** amotoki__ is now known as amotoki | 06:33 | |
*** lajoskatona has joined #openstack-horizon | 06:46 | |
*** zhurong has joined #openstack-horizon | 06:47 | |
*** TravT has joined #openstack-horizon | 06:47 | |
*** ChanServ sets mode: +v TravT | 06:47 | |
*** e0ne has joined #openstack-horizon | 07:01 | |
robcresswell | amotoki: I would prefer to avoid anything that modifies the API layer if possible. It tends to cause problems for plugins. | 07:30 |
robcresswell | amotoki: If it just adds new API calls thats fine, but changing existing ones will break things :) | 07:30 |
amotoki | robcresswell: it changes the existing API to add an extra argument like https://review.openstack.org/#/c/404178/25/openstack_dashboard/api/neutron.py | 07:35 |
amotoki | robcresswell: i have no reason to rush it. IIRC, it was a feedback from Barcelona ops session, but we already take time long, so one more 6 months does not matter :p | 07:35 |
robcresswell | amotoki: We solved quite a lot of the feedback from that session. I'm quite pleased overall :) | 07:44 |
robcresswell | We still have more to do for next time | 07:45 |
amotoki | I think so :) | 07:45 |
*** ducttape_ has joined #openstack-horizon | 07:56 | |
*** udesale has joined #openstack-horizon | 07:58 | |
*** udesale__ has quit IRC | 08:00 | |
*** ducttape_ has quit IRC | 08:00 | |
*** yamamoto has quit IRC | 08:02 | |
*** masco_ has joined #openstack-horizon | 08:13 | |
*** shu-mutou is now known as shu-mutou-AWAY | 08:27 | |
*** udesale__ has joined #openstack-horizon | 08:31 | |
*** udesale has quit IRC | 08:34 | |
*** zhurong has quit IRC | 08:41 | |
*** yamamoto has joined #openstack-horizon | 09:02 | |
*** yamamoto has quit IRC | 09:08 | |
*** yamamoto has joined #openstack-horizon | 09:08 | |
*** jtomasek has joined #openstack-horizon | 09:20 | |
*** jtomasek has quit IRC | 09:20 | |
*** jtomasek has joined #openstack-horizon | 09:21 | |
*** tosky has joined #openstack-horizon | 09:21 | |
*** yamamoto has quit IRC | 09:25 | |
*** jtomasek has quit IRC | 09:27 | |
*** yamamoto has joined #openstack-horizon | 09:34 | |
*** zhurong has joined #openstack-horizon | 09:37 | |
*** yamamoto has quit IRC | 09:40 | |
*** TravT has quit IRC | 09:49 | |
*** TravT has joined #openstack-horizon | 09:50 | |
*** ChanServ sets mode: +v TravT | 09:50 | |
*** yamamoto has joined #openstack-horizon | 09:53 | |
*** TravT has quit IRC | 09:53 | |
*** jtomasek has joined #openstack-horizon | 09:56 | |
*** ducttape_ has joined #openstack-horizon | 09:57 | |
*** ducttape_ has quit IRC | 10:01 | |
*** TravT has joined #openstack-horizon | 10:03 | |
*** ChanServ sets mode: +v TravT | 10:03 | |
*** TravT has quit IRC | 10:04 | |
*** TravT has joined #openstack-horizon | 10:05 | |
*** ChanServ sets mode: +v TravT | 10:05 | |
*** masco_ has quit IRC | 10:06 | |
*** TravT has quit IRC | 10:07 | |
*** TravT has joined #openstack-horizon | 10:14 | |
*** ChanServ sets mode: +v TravT | 10:14 | |
amotoki | I put provisional -1 on https://review.openstack.org/#/c/477253/ this allows admin to edit image properties, | 10:15 |
amotoki | but my concern is that it introduces another logic to determine admin-ness by referring to is_superuser. | 10:15 |
amotoki | feedback from more folks would be nice. | 10:15 |
robcresswell | amotoki: +1; I agree with you. We should be using policy, not is_admin. | 10:16 |
*** masco_ has joined #openstack-horizon | 10:19 | |
*** TravT has quit IRC | 10:19 | |
*** TravT has joined #openstack-horizon | 10:25 | |
*** ChanServ sets mode: +v TravT | 10:25 | |
openstackgerrit | Beth Elwell proposed openstack/horizon master: Reduce user confusion in router creation template https://review.openstack.org/489170 | 10:26 |
*** wolverineav has joined #openstack-horizon | 10:32 | |
openstackgerrit | Beth Elwell proposed openstack/horizon master: Incorrect URL for polling heat stack https://review.openstack.org/489172 | 10:35 |
*** TravT_ has joined #openstack-horizon | 10:36 | |
*** ChanServ sets mode: +v TravT_ | 10:36 | |
*** TravT has quit IRC | 10:37 | |
*** zhurong has quit IRC | 10:40 | |
*** TravT_ has quit IRC | 10:41 | |
*** TravT has joined #openstack-horizon | 10:43 | |
*** ChanServ sets mode: +v TravT | 10:43 | |
*** TravT has quit IRC | 10:51 | |
*** zhurong has joined #openstack-horizon | 10:52 | |
*** TravT has joined #openstack-horizon | 10:54 | |
*** ChanServ sets mode: +v TravT | 10:54 | |
*** TravT has quit IRC | 10:59 | |
*** TravT has joined #openstack-horizon | 11:11 | |
*** ChanServ sets mode: +v TravT | 11:11 | |
*** TravT has quit IRC | 11:12 | |
*** TravT_ has joined #openstack-horizon | 11:12 | |
*** ChanServ sets mode: +v TravT_ | 11:12 | |
*** TravT has joined #openstack-horizon | 11:16 | |
*** ChanServ sets mode: +v TravT | 11:16 | |
*** TravT_ has quit IRC | 11:17 | |
*** TravT has quit IRC | 11:21 | |
*** TravT has joined #openstack-horizon | 11:22 | |
*** ChanServ sets mode: +v TravT | 11:22 | |
*** TravT has quit IRC | 11:27 | |
*** TravT has joined #openstack-horizon | 11:28 | |
*** ChanServ sets mode: +v TravT | 11:28 | |
*** yamamoto has quit IRC | 11:31 | |
*** TravT has quit IRC | 11:33 | |
*** TravT has joined #openstack-horizon | 11:37 | |
*** ChanServ sets mode: +v TravT | 11:37 | |
openstackgerrit | Bence Romsics proposed openstack/horizon master: WIP Trunks panel: edit button https://review.openstack.org/485473 | 11:38 |
openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: create button https://review.openstack.org/468396 | 11:38 |
openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: delete unused part of drawer https://review.openstack.org/489184 | 11:38 |
openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: improve details' test coverage https://review.openstack.org/489185 | 11:38 |
openstackgerrit | Bence Romsics proposed openstack/horizon master: WIP Trunks panel: default to enabled https://review.openstack.org/489186 | 11:38 |
*** TravT has quit IRC | 11:41 | |
*** TravT has joined #openstack-horizon | 11:48 | |
*** ChanServ sets mode: +v TravT | 11:48 | |
*** TravT has quit IRC | 11:52 | |
*** TravT has joined #openstack-horizon | 11:53 | |
*** ChanServ sets mode: +v TravT | 11:53 | |
*** TravT has quit IRC | 11:58 | |
*** ducttape_ has joined #openstack-horizon | 11:58 | |
*** TravT has joined #openstack-horizon | 11:59 | |
*** ChanServ sets mode: +v TravT | 11:59 | |
openstackgerrit | Merged openstack/horizon master: Makes the xstatic files lookup dynamic in the tests https://review.openstack.org/487862 | 11:59 |
*** yamamoto has joined #openstack-horizon | 12:01 | |
*** ducttape_ has quit IRC | 12:02 | |
*** ducttape_ has joined #openstack-horizon | 12:02 | |
*** yamamoto has quit IRC | 12:04 | |
*** TravT has quit IRC | 12:09 | |
*** TravT has joined #openstack-horizon | 12:10 | |
*** ChanServ sets mode: +v TravT | 12:10 | |
*** TravT has quit IRC | 12:14 | |
*** ducttape_ has quit IRC | 12:15 | |
*** ducttape_ has joined #openstack-horizon | 12:15 | |
*** udesale__ has quit IRC | 12:19 | |
*** yamamoto has joined #openstack-horizon | 12:20 | |
*** TravT has joined #openstack-horizon | 12:25 | |
*** ChanServ sets mode: +v TravT | 12:25 | |
*** ducttape_ has quit IRC | 12:25 | |
*** catintheroof has joined #openstack-horizon | 12:29 | |
*** TravT has quit IRC | 12:30 | |
*** TravT has joined #openstack-horizon | 12:30 | |
*** ChanServ sets mode: +v TravT | 12:30 | |
*** yamamoto has quit IRC | 12:32 | |
*** yamamoto has joined #openstack-horizon | 12:33 | |
*** yamamoto has quit IRC | 12:33 | |
*** yamamoto has joined #openstack-horizon | 12:33 | |
*** masco_ has quit IRC | 12:35 | |
openstackgerrit | Merged openstack/horizon master: Trunks panel: delete unused part of drawer https://review.openstack.org/489184 | 12:36 |
openstackgerrit | Merged openstack/horizon master: Trunks panel: improve details' test coverage https://review.openstack.org/489185 | 12:36 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/489203 | 12:37 |
*** ratailor has quit IRC | 12:39 | |
*** TravT has quit IRC | 12:39 | |
*** TravT has joined #openstack-horizon | 12:40 | |
*** ChanServ sets mode: +v TravT | 12:40 | |
*** TravT has quit IRC | 12:45 | |
*** TravT has joined #openstack-horizon | 12:45 | |
*** ChanServ sets mode: +v TravT | 12:45 | |
*** masco_ has joined #openstack-horizon | 12:48 | |
*** TravT has quit IRC | 12:48 | |
*** TravT has joined #openstack-horizon | 12:49 | |
tosky | gmbl - this sahara_dashboard failure is complicated | 12:49 |
*** ChanServ sets mode: +v TravT | 12:49 | |
tosky | summary: with Django 1.11 sahara a dashboard test break, and it worked with 1.10; I tried a fix | 12:50 |
*** ducttape_ has joined #openstack-horizon | 12:50 | |
tosky | but it a) leaves an error which I don't understand (it looks like a piece of page is not rendered) and | 12:50 |
tosky | b) there are some strange warnings more related to the horizon code which I can't pinpoint | 12:50 |
tosky | http://logs.openstack.org/25/488425/4/check/gate-sahara-dashboard-python27-ubuntu-xenial/080a503/console.html | 12:50 |
*** ducttape_ has quit IRC | 12:52 | |
*** TravT has quit IRC | 12:55 | |
*** TravT has joined #openstack-horizon | 12:56 | |
*** ChanServ sets mode: +v TravT | 12:56 | |
robcresswell | tosky: One of those failures is here: https://github.com/openstack/sahara-dashboard/blob/master/sahara_dashboard/content/data_processing/clusters/nodegroup_templates/workflows/create.py#L304 | 12:57 |
tosky | uh | 12:57 |
robcresswell | tosky: http://logs.openstack.org/25/488425/4/check/gate-sahara-dashboard-python27-ubuntu-xenial/080a503/console.html#_2017-07-31_10_46_44_471445 | 12:58 |
tosky | oh, thanks, I will fix that | 12:58 |
robcresswell | tosky: Its probably worth looking at the release notes from django 1.8 and 1.9 as that's when a lot of these things were deprecated | 12:58 |
tosky | the most complicated are "TypeError: render() got an unexpected keyword argument 'renderer'" | 12:58 |
tosky | also because I don't seem able to find 'renderer' in sahara_dashboard | 12:59 |
*** zhurong has quit IRC | 13:00 | |
tosky | uh, maybe I'm starting to see the light | 13:02 |
robcresswell | That could also be a migraine from trying to debug Django for too long | 13:02 |
*** lucasxu has joined #openstack-horizon | 13:02 | |
*** TravT has quit IRC | 13:03 | |
*** TravT has joined #openstack-horizon | 13:03 | |
*** ChanServ sets mode: +v TravT | 13:03 | |
tosky | ah, thanks, I don't really know django and was feeling a bit, overwhelmed | 13:03 |
robcresswell | tosky: I'd just recommend picking the easiest part and working backwards. I find a lot of the time in the tests the failures sort of "stack", so a widget error can cause a dozen template rendering errors. | 13:05 |
robcresswell | But the widget error might just be a little one line thing at the bottom. | 13:05 |
tosky | robcresswell: I suspect that the warning that are very visible in the logs are preventing the rendering of some pages, leading to the error later | 13:05 |
tosky | robcresswell: but do you have an idea why I'm not seeing the warnings when I run tox -e py27 on my system/ | 13:06 |
tosky | ? | 13:06 |
tosky | is there some special setting on the gate? | 13:06 |
robcresswell | tosky: Version mismatch, usually | 13:07 |
tosky | I mean, I see the same error in the tests, but not the ton of warnings | 13:07 |
tosky | at least Django is the same | 13:07 |
robcresswell | tosky: Just trying it myself locally | 13:10 |
openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/489203 | 13:10 |
tosky | oh, thanks | 13:10 |
*** ducttape_ has joined #openstack-horizon | 13:16 | |
robcresswell | tosky: I still get lots of warnings with tox -e py27 | 13:17 |
tosky | uhm | 13:17 |
tosky | on ubuntu? | 13:18 |
* tosky tries on an Ubuntu VM | 13:19 | |
robcresswell | tosky: this is on macos | 13:19 |
robcresswell | tosky: Clean close, tox -e py27 | 13:19 |
robcresswell | clean clone* | 13:19 |
*** lajoskatona has left #openstack-horizon | 13:19 | |
*** TravT has quit IRC | 13:20 | |
*** lblanchard has joined #openstack-horizon | 13:20 | |
tosky | on fedora right now, let me check on a clean clone | 13:20 |
*** lblanchard has quit IRC | 13:20 | |
*** lblanchard has joined #openstack-horizon | 13:21 | |
amotoki | I experienced the same thing that some warnings only appear in the gate and I failed to reproduce it locally. in my case it was a warning regarding render(). | 13:23 |
*** jtriley has joined #openstack-horizon | 13:23 | |
amotoki | it is not about sahara-dashboard though | 13:24 |
*** TravT has joined #openstack-horizon | 13:26 | |
*** ChanServ sets mode: +v TravT | 13:26 | |
tosky | amotoki: right, but could it be the reason for the issue in sahara-dashboard? | 13:26 |
tosky | I brutally tried to print out the rendered webpage with django 1.10 (working) and 1.11 (failing) and there are few chunks which are not available in the failing part | 13:27 |
tosky | including a chunk that should contain an error message which is then checked by the test | 13:27 |
tosky | I fear that the error in the rendering leads to an empty rendered template (according the message) | 13:27 |
amotoki | tosky: from what I experienced, their warnings were not directly related to the failures, but it was with DJango 1.10 and their warnings are deprecation on Django 1.10 | 13:27 |
amotoki | so I think they are related. | 13:28 |
*** makowals has quit IRC | 13:28 | |
amotoki | hmm... sahara-dashboard dj110 job is also failing.. | 13:29 |
tosky | but if I run py27 locally forcing django 1.10 in the venv, it works | 13:29 |
*** TravT has quit IRC | 13:30 | |
amotoki | tosky: i noticed sahara-dashboard dj110 job actually uses django 1.11 http://logs.openstack.org/25/488425/4/check/gate-sahara-dashboard-tox-py27dj110-ubuntu-xenial/7e0bb53/console.html#_2017-07-31_10_48_21_743252 | 13:30 |
*** TravT has joined #openstack-horizon | 13:31 | |
*** ChanServ sets mode: +v TravT | 13:31 | |
tosky | amotoki: yes, I think it's a problem with some other dependency (some django-something) which brings 1.11 | 13:31 |
*** makowals has joined #openstack-horizon | 13:32 | |
*** ducttape_ has quit IRC | 13:32 | |
amotoki | the only reason I checked dj110 job is I think we can do some incremental approach to fix problems. | 13:34 |
tosky | oh, sure | 13:35 |
*** Adri2000 has quit IRC | 13:35 | |
amotoki | tosky: py27dj110 has no version cap and it calls "pip install django --pre --upgrade" | 13:35 |
amotoki | so it leads to Django 1.11 | 13:35 |
tosky | I see - but that can be fixed later I guess | 13:35 |
amotoki | tosky: yes, of course. juts for clarify! | 13:36 |
tosky | yep :) | 13:36 |
*** jtriley has quit IRC | 13:39 | |
*** TravT has quit IRC | 13:40 | |
*** TravT has joined #openstack-horizon | 13:41 | |
*** ChanServ sets mode: +v TravT | 13:41 | |
*** Adri2000 has joined #openstack-horizon | 13:44 | |
*** TravT has quit IRC | 13:46 | |
*** TravT has joined #openstack-horizon | 13:50 | |
*** ChanServ sets mode: +v TravT | 13:50 | |
*** TravT has quit IRC | 13:54 | |
*** TravT has joined #openstack-horizon | 13:55 | |
*** ChanServ sets mode: +v TravT | 13:55 | |
*** ducttape_ has joined #openstack-horizon | 13:58 | |
*** TravT has quit IRC | 13:59 | |
*** TravT has joined #openstack-horizon | 14:00 | |
*** ChanServ sets mode: +v TravT | 14:00 | |
*** ducttap__ has joined #openstack-horizon | 14:02 | |
*** TravT has quit IRC | 14:02 | |
*** TravT has joined #openstack-horizon | 14:02 | |
*** ChanServ sets mode: +v TravT | 14:02 | |
*** ratailor has joined #openstack-horizon | 14:02 | |
*** ducttape_ has quit IRC | 14:06 | |
*** TravT has quit IRC | 14:07 | |
*** TravT has joined #openstack-horizon | 14:08 | |
*** ChanServ sets mode: +v TravT | 14:08 | |
*** jamesbenson has joined #openstack-horizon | 14:09 | |
*** jamesbenson has quit IRC | 14:09 | |
tosky | it's a bug in horizon | 14:10 |
robcresswell | tosky: Bug report please :) | 14:11 |
tosky | robcresswell: just to see if it makes sense: DynamicSelectWidget inherits from SelectWidget, and defines a render with *args and kwargs | 14:11 |
tosky | and it calls its parents' render() | 14:12 |
tosky | which does not expose a renderer parameter | 14:12 |
*** TravT has quit IRC | 14:13 | |
*** TravT has joined #openstack-horizon | 14:13 | |
*** ChanServ sets mode: +v TravT | 14:13 | |
*** jamesbenson has joined #openstack-horizon | 14:14 | |
*** TravT has quit IRC | 14:17 | |
*** TravT has joined #openstack-horizon | 14:17 | |
*** ChanServ sets mode: +v TravT | 14:17 | |
*** lcastell has joined #openstack-horizon | 14:19 | |
*** TravT has quit IRC | 14:22 | |
*** TravT has joined #openstack-horizon | 14:23 | |
*** ChanServ sets mode: +v TravT | 14:23 | |
*** TravT has quit IRC | 14:31 | |
*** TravT has joined #openstack-horizon | 14:31 | |
*** ChanServ sets mode: +v TravT | 14:31 | |
*** openstackgerrit has quit IRC | 14:33 | |
*** TravT has quit IRC | 14:36 | |
*** TravT has joined #openstack-horizon | 14:38 | |
*** ChanServ sets mode: +v TravT | 14:38 | |
robcresswell | tosky: Where is renderer even being used though? | 14:40 |
tosky | robcresswell: I think it's the definiton of render() of DynamicSelectWidget | 14:40 |
tosky | which uses def render(self, *args, **kwargs):, which probably receives renderer (since 1.11, it is a new parameter), | 14:41 |
robcresswell | tosky: Ah, we aren't actually using that in the Horizon codebase, thats why we havent seen any issue | 14:41 |
tosky | but then invokes the method of SelectWidget, def render(self, name, value, attrs=None) and boom | 14:41 |
tosky | just adding receiver=None to SelectWidget.render seems to work | 14:41 |
tosky | the comment in SelectWidget itself says that some cleanup is needed | 14:42 |
tosky | aaanyway, I'm really writing down the bug right now | 14:42 |
robcresswell | tosky: Although, we added SelectWidget to our tree so I'm not sure why its not working | 14:42 |
robcresswell | Yeah | 14:42 |
*** TravT has quit IRC | 14:42 | |
robcresswell | It was totally rewritten for Django 1.11 | 14:42 |
robcresswell | So we moved the 1.10 version to our tree, because removing code without deprecation is bad Django devs :( | 14:42 |
*** TravT has joined #openstack-horizon | 14:43 | |
*** ChanServ sets mode: +v TravT | 14:43 | |
*** ducttape_ has joined #openstack-horizon | 14:44 | |
*** yamamoto has quit IRC | 14:45 | |
*** ducttap__ has quit IRC | 14:48 | |
*** jtriley has joined #openstack-horizon | 14:49 | |
*** ducttap__ has joined #openstack-horizon | 14:49 | |
*** openstackgerrit has joined #openstack-horizon | 14:51 | |
openstackgerrit | Luigi Toscano proposed openstack/horizon master: Pass renderer to SelectWidget.render() https://review.openstack.org/489248 | 14:51 |
tosky | that's it ^^ | 14:52 |
tosky | I added a Depends-On on my sahara_dashboard patches which fixes few additional deprecation issues, crossing fingers | 14:52 |
*** ducttape_ has quit IRC | 14:53 | |
*** makowals has quit IRC | 15:00 | |
*** makowals has joined #openstack-horizon | 15:02 | |
*** rcernin has quit IRC | 15:03 | |
*** pcaruana has quit IRC | 15:04 | |
*** TravT has quit IRC | 15:06 | |
*** TravT has joined #openstack-horizon | 15:07 | |
*** ChanServ sets mode: +v TravT | 15:07 | |
robcresswell | tosky: I still don't quite understand how thats breaking from Django 1.11 | 15:08 |
robcresswell | tosky: We aren't using any Django widgets :/ | 15:08 |
* robcresswell doesn't like merging fixes he doesn't understand | 15:09 | |
*** TravT has quit IRC | 15:14 | |
*** TravT_ has joined #openstack-horizon | 15:14 | |
*** ChanServ sets mode: +v TravT_ | 15:14 | |
*** yamamoto has joined #openstack-horizon | 15:16 | |
tosky | robcresswell: we are using that widget in sahara_dashboard | 15:18 |
robcresswell | tosky: Right, but its not coming from Django, its coming from Horizon | 15:18 |
robcresswell | tosky: so I dont understand why the django upgrade broke it | 15:18 |
tosky | robcresswell: if I read the release notes of Django 1.11 correctly, renderer is passed to render() | 15:19 |
tosky | starting from 1.11 | 15:19 |
robcresswell | tosky: Again *how* | 15:19 |
robcresswell | Magic inserted code? | 15:19 |
tosky | robcresswell: SeelctWidget inherits widgets.Widget | 15:19 |
amotoki | robcresswell: doesn't horizon.forms.fields.SelectWidget inherit django.forms.widget.Widget? | 15:19 |
*** masco_ has quit IRC | 15:19 | |
tosky | it does | 15:20 |
* robcresswell checks | 15:20 | |
amotoki | https://github.com/openstack/horizon/blob/master/horizon/forms/fields.py#L167 | 15:20 |
robcresswell | ahh, gotcha | 15:20 |
*** yamamoto has quit IRC | 15:21 | |
* robcresswell wonders why super is being called on render... | 15:23 | |
*** TravT_ has quit IRC | 15:23 | |
amotoki | I think Django calls render() method of DynamicSelectWidget with renderer argument and it hits the bug. | 15:25 |
*** TravT has joined #openstack-horizon | 15:25 | |
*** ChanServ sets mode: +v TravT | 15:25 | |
amotoki | super() is unnecessary? | 15:25 |
robcresswell | Ah, yeah | 15:25 |
robcresswell | That makes sense | 15:25 |
robcresswell | I'd expect just added render=None to that func def would be fine then | 15:26 |
*** lucasxu has quit IRC | 15:26 | |
amotoki | what I am not sure now is how the implementation of render() should be in a child class. the current version is different from what Django 1.11 doc says. renderer is not referred to in our impl. | 15:26 |
robcresswell | amotoki: No, but the upstream defaults to None, so I think it is designed with that in mind | 15:27 |
amotoki | i am looking at https://docs.djangoproject.com/en/1.11/ref/forms/widgets/#django.forms.Widget.render | 15:28 |
tosky | as robcresswell hinted, it looks like it is None to not break tons of old code | 15:29 |
*** TravT has quit IRC | 15:29 | |
amotoki | robcresswell: tosky: I agree with that point. I think renderer=None is safe at now too. | 15:31 |
tosky | especially because we have a release close and a bunch of sahara_dashboard patches blocked on that :D | 15:31 |
robcresswell | yeah, thats what I was trying to say just above :) | 15:31 |
robcresswell | tosky: Have you checked it fixes your tests locally? | 15:32 |
tosky | robcresswell: yep, that was the first test before sending the patch | 15:32 |
tosky | with 1.9, 1.10 and 1.11 | 15:32 |
tosky | and the complementary patch for sahara_dashboard agrees: https://review.openstack.org/488425 | 15:33 |
*** TravT has joined #openstack-horizon | 15:34 | |
*** ChanServ sets mode: +v TravT | 15:34 | |
*** TravT has quit IRC | 15:40 | |
*** TravT has joined #openstack-horizon | 15:42 | |
*** ChanServ sets mode: +v TravT | 15:42 | |
tosky | robcresswell: thanks! | 15:43 |
tosky | thanks amotoki too | 15:43 |
amotoki | tosky: you're welcome | 15:43 |
*** ratailor has quit IRC | 15:44 | |
*** lcastell has quit IRC | 15:45 | |
*** TravT has quit IRC | 15:45 | |
*** TravT has joined #openstack-horizon | 15:46 | |
*** ChanServ sets mode: +v TravT | 15:46 | |
amotoki | looking at Django 1.11 code, it seems no widgets implement render() method and just implements get_context and template_name. this looks like a new way in Django.. | 15:46 |
robcresswell | amotoki: Yeah, it is, its even referenced in the comment in that code | 15:46 |
robcresswell | amotoki: Unfortuantely, Django removed all those widgets without any deprecation | 15:46 |
*** TravT has quit IRC | 15:47 | |
amotoki | yeah, Django tends to change things too aggressively :( | 15:47 |
*** yamamoto has joined #openstack-horizon | 15:48 | |
*** TravT has joined #openstack-horizon | 15:48 | |
*** ChanServ sets mode: +v TravT | 15:48 | |
*** ducttape_ has joined #openstack-horizon | 15:50 | |
*** TravT has quit IRC | 15:50 | |
*** e0ne has quit IRC | 15:51 | |
*** vishwanathj has quit IRC | 15:53 | |
*** vishwanathj has joined #openstack-horizon | 15:53 | |
*** ducttap__ has quit IRC | 15:54 | |
*** gyee has joined #openstack-horizon | 15:54 | |
*** yamamoto has quit IRC | 15:58 | |
openstackgerrit | Merged openstack/horizon master: Pass renderer to SelectWidget.render() https://review.openstack.org/489248 | 16:00 |
*** ducttap__ has joined #openstack-horizon | 16:01 | |
openstackgerrit | Merged openstack/horizon master: Update local conf https://review.openstack.org/487808 | 16:02 |
*** ducttape_ has quit IRC | 16:04 | |
*** TravT has joined #openstack-horizon | 16:05 | |
*** ChanServ sets mode: +v TravT | 16:05 | |
*** lucasxu has joined #openstack-horizon | 16:10 | |
*** jamesbenson_ has joined #openstack-horizon | 16:11 | |
*** jamesbenson has quit IRC | 16:11 | |
*** TravT has quit IRC | 16:12 | |
*** TravT_ has joined #openstack-horizon | 16:12 | |
*** ChanServ sets mode: +v TravT_ | 16:12 | |
*** lcastell has joined #openstack-horizon | 16:16 | |
*** lcastell has joined #openstack-horizon | 16:17 | |
*** gyee has quit IRC | 16:21 | |
*** TravT_ has quit IRC | 16:21 | |
*** gyee_ has joined #openstack-horizon | 16:21 | |
*** ying_zuo has joined #openstack-horizon | 16:23 | |
*** lcastell has quit IRC | 16:29 | |
*** TravT has joined #openstack-horizon | 16:34 | |
*** ChanServ sets mode: +v TravT | 16:34 | |
*** lcastell has joined #openstack-horizon | 16:35 | |
*** TravT has quit IRC | 16:39 | |
*** david-lyle has joined #openstack-horizon | 16:47 | |
*** ChanServ sets mode: +o david-lyle | 16:47 | |
*** itlinux_ has joined #openstack-horizon | 16:52 | |
*** jamesbenson_ has quit IRC | 16:53 | |
*** TravT has joined #openstack-horizon | 16:55 | |
*** ChanServ sets mode: +v TravT | 16:55 | |
*** jamesbenson has joined #openstack-horizon | 16:56 | |
*** esp has joined #openstack-horizon | 16:59 | |
*** ducttap__ has quit IRC | 17:00 | |
*** jamesbenson has quit IRC | 17:01 | |
*** ducttape_ has joined #openstack-horizon | 17:02 | |
*** TravT has quit IRC | 17:06 | |
*** ducttape_ has quit IRC | 17:07 | |
*** david-lyle has quit IRC | 17:11 | |
*** david-lyle has joined #openstack-horizon | 17:13 | |
*** ChanServ sets mode: +o david-lyle | 17:13 | |
*** ducttape_ has joined #openstack-horizon | 17:13 | |
*** jamesbenson has joined #openstack-horizon | 17:19 | |
*** TravT has joined #openstack-horizon | 17:20 | |
*** ChanServ sets mode: +v TravT | 17:20 | |
*** itlinux_ has quit IRC | 17:24 | |
*** TravT has quit IRC | 17:24 | |
*** TravT has joined #openstack-horizon | 17:25 | |
*** ChanServ sets mode: +v TravT | 17:25 | |
*** tosky has quit IRC | 17:32 | |
*** TravT has quit IRC | 17:34 | |
*** TravT has joined #openstack-horizon | 17:35 | |
*** ChanServ sets mode: +v TravT | 17:35 | |
*** TravT has quit IRC | 17:47 | |
*** TravT has joined #openstack-horizon | 17:48 | |
*** ChanServ sets mode: +v TravT | 17:48 | |
*** jamesbenson has quit IRC | 17:54 | |
*** ircuser-1 has joined #openstack-horizon | 17:54 | |
*** TravT has quit IRC | 17:55 | |
*** TravT_ has joined #openstack-horizon | 17:55 | |
*** ChanServ sets mode: +v TravT_ | 17:55 | |
*** tosky has joined #openstack-horizon | 17:56 | |
*** tosky has quit IRC | 17:56 | |
*** jamesbenson has joined #openstack-horizon | 17:56 | |
*** tosky has joined #openstack-horizon | 17:57 | |
*** tosky has quit IRC | 17:58 | |
*** tosky has joined #openstack-horizon | 17:58 | |
*** jamesbenson has quit IRC | 18:00 | |
*** jamesbenson_ has joined #openstack-horizon | 18:04 | |
*** jamesbenson_ has quit IRC | 18:05 | |
*** jamesbenson_ has joined #openstack-horizon | 18:05 | |
*** itlinux has joined #openstack-horizon | 18:06 | |
*** jamesbenson_ has quit IRC | 18:10 | |
*** harlowja has joined #openstack-horizon | 18:11 | |
*** jamesbenson has joined #openstack-horizon | 18:26 | |
*** catintheroof has quit IRC | 18:59 | |
*** catintheroof has joined #openstack-horizon | 19:00 | |
*** catintheroof has quit IRC | 19:00 | |
*** catintheroof has joined #openstack-horizon | 19:01 | |
openstackgerrit | Merged openstack/horizon master: Fix translation tag for datepicker https://review.openstack.org/489090 | 19:02 |
*** elod has quit IRC | 19:10 | |
*** wolverineav has quit IRC | 19:18 | |
lucasxu | https://www.openstack.org/summit/sydney-2017/vote-for-speakers#/19348 | 19:20 |
lucasxu | robcresswell, interesting ;) | 19:20 |
robcresswell | lucasxu: :) | 19:20 |
*** ducttap__ has joined #openstack-horizon | 19:25 | |
*** ducttape_ has quit IRC | 19:28 | |
*** e0ne has joined #openstack-horizon | 19:29 | |
*** e0ne has quit IRC | 19:31 | |
*** ducttape_ has joined #openstack-horizon | 19:57 | |
*** ducttap__ has quit IRC | 20:00 | |
*** e0ne has joined #openstack-horizon | 20:04 | |
*** gyee_ has quit IRC | 20:26 | |
*** gyee has joined #openstack-horizon | 20:29 | |
*** gyee has quit IRC | 20:29 | |
*** gyee has joined #openstack-horizon | 20:30 | |
*** gyee has quit IRC | 20:53 | |
*** wolverineav has joined #openstack-horizon | 21:00 | |
*** jtomasek has quit IRC | 21:00 | |
*** lucasxu has quit IRC | 21:02 | |
*** felipemonteiro has joined #openstack-horizon | 21:02 | |
*** yamamoto_ has joined #openstack-horizon | 21:06 | |
*** lblanchard has quit IRC | 21:08 | |
*** felipemonteiro_ has joined #openstack-horizon | 21:09 | |
*** gyee has joined #openstack-horizon | 21:10 | |
*** jtriley has quit IRC | 21:15 | |
*** yamamoto_ has quit IRC | 21:15 | |
*** catintheroof has quit IRC | 21:17 | |
*** ducttap__ has joined #openstack-horizon | 21:35 | |
*** e0ne has quit IRC | 21:37 | |
*** felipemonteiro_ has quit IRC | 21:38 | |
*** ducttape_ has quit IRC | 21:38 | |
*** wolverineav has quit IRC | 21:58 | |
*** jamesbenson has quit IRC | 21:58 | |
*** wolverineav has joined #openstack-horizon | 21:58 | |
*** ducttape_ has joined #openstack-horizon | 22:00 | |
*** wolverineav has quit IRC | 22:02 | |
*** ducttap__ has quit IRC | 22:03 | |
*** itlinux has quit IRC | 22:05 | |
*** ducttap__ has joined #openstack-horizon | 22:15 | |
*** yamamoto has joined #openstack-horizon | 22:16 | |
*** ducttape_ has quit IRC | 22:18 | |
*** yamamoto has quit IRC | 22:23 | |
*** yamamoto has joined #openstack-horizon | 22:28 | |
*** ducttape_ has joined #openstack-horizon | 22:32 | |
*** ducttap__ has quit IRC | 22:35 | |
*** esp has quit IRC | 23:03 | |
*** esp has joined #openstack-horizon | 23:06 | |
*** gyee has quit IRC | 23:17 | |
*** catintheroof has joined #openstack-horizon | 23:24 | |
*** https_GK1wmSU has joined #openstack-horizon | 23:25 | |
*** https_GK1wmSU has left #openstack-horizon | 23:25 | |
*** esp has quit IRC | 23:27 | |
*** ducttape_ has quit IRC | 23:27 | |
*** ducttape_ has joined #openstack-horizon | 23:32 | |
*** ducttap__ has joined #openstack-horizon | 23:35 | |
*** ducttape_ has quit IRC | 23:37 | |
*** ducttap__ has quit IRC | 23:37 | |
*** catintheroof has quit IRC | 23:43 | |
*** tosky has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!