*** Jeffrey4l has quit IRC | 00:03 | |
*** Jeffrey4l has joined #openstack-horizon | 00:03 | |
*** bpokorny has quit IRC | 00:04 | |
*** bpokorny has joined #openstack-horizon | 00:05 | |
*** bpokorny has quit IRC | 00:07 | |
*** bpokorny has joined #openstack-horizon | 00:07 | |
*** ducttape_ has quit IRC | 00:09 | |
*** ducttape_ has joined #openstack-horizon | 00:10 | |
*** bpokorny has quit IRC | 00:11 | |
*** bpokorny has joined #openstack-horizon | 00:11 | |
*** aortega has joined #openstack-horizon | 00:13 | |
kenji-i | robcresswell, r1chardj0n3s: good morning! I saw rob's mail, I'll modify patches I tag as Identity project. | 00:14 |
---|---|---|
kenji-i | I'm sorry to bother you. | 00:14 |
r1chardj0n3s | kenji-i: hi! thanks :-) | 00:14 |
*** ducttape_ has quit IRC | 00:14 | |
tqtran | lol poor kenji-i | 00:14 |
tqtran | got the receiving end of robs wrath | 00:14 |
*** bpokorny has quit IRC | 00:16 | |
tqtran | btw kenji-i, thanks for doing the identity work, i have been reviewing them privately. | 00:16 |
tqtran | wasnt able to get the setup correctly, so the domain panel didnt show up for me. but i'll figure it out at some point | 00:16 |
kenji-i | tqtran: morning! yes, it's my fault >< | 00:17 |
kenji-i | Oh, thank you for reviewing! | 00:18 |
clu_ | kenji-i: i created some new bps like ng-users, ng-groups a while back | 00:18 |
clu_ | you can assign to those when you update :) | 00:18 |
kenji-i | hmm.. to enbale domain panel, we need some preparation like https://wiki.openstack.org/wiki/Horizon/DomainWorkFlow | 00:20 |
kenji-i | clu_: Okay, thank you! Also i'll create new bp for domain :) | 00:21 |
clu_ | kenji-i: cool :) | 00:21 |
tqtran | yes, i followed the instructions there. i was able to log as well, but the domain panel did not show up. i suspect it has something to do on my end. will look into it more tomorrow. | 00:21 |
kenji-i | clu_:(^0^)/ | 00:25 |
kenji-i | tqtran: Thank you! you cannot also see legacy domain panel? If so, my prepalation I wrote in commit meesage may not enough. | 00:27 |
*** Pavo has quit IRC | 00:29 | |
kenji-i | Oh, mistake, I thought if you can see legacy domain panel, I may have an extra preparation to show angular panel. | 00:30 |
tqtran | kenji-i: not really sure, i have to mess around with the keystone conf and policy file, that might be my problem | 00:32 |
tqtran | but i have to look into it some more, maybe i misconfigurd something | 00:32 |
*** Pavo has joined #openstack-horizon | 00:34 | |
*** shu-mutou-AWAY is now known as shu-mutou | 00:38 | |
kenji-i | tqtran: yes, if you find that you can see only the legacy case, please let me know, I'd like to also look into it. | 00:41 |
tqtran | ok, i'll leave comments when i find something | 00:41 |
tqtran | *leave comments on the patch | 00:41 |
*** ctayal has quit IRC | 00:42 | |
kenji-i | Thanks! :) | 00:44 |
*** jamielennox is now known as jamielennox|away | 00:45 | |
*** tqtran has quit IRC | 00:54 | |
*** itisha has quit IRC | 00:59 | |
*** bpokorny has joined #openstack-horizon | 01:12 | |
*** wolverineav has joined #openstack-horizon | 01:14 | |
*** ctayal has joined #openstack-horizon | 01:15 | |
*** bpokorny has quit IRC | 01:16 | |
*** Jeffrey4l has quit IRC | 01:18 | |
*** wolverineav has quit IRC | 01:19 | |
*** Jeffrey4l has joined #openstack-horizon | 01:19 | |
*** dave-mccowan has joined #openstack-horizon | 01:26 | |
*** zhurong has joined #openstack-horizon | 01:32 | |
*** ducttape_ has joined #openstack-horizon | 01:39 | |
*** mtanino has quit IRC | 01:41 | |
*** jamielennox|away is now known as jamielennox | 01:50 | |
*** wolverineav has joined #openstack-horizon | 01:52 | |
*** wolverineav has quit IRC | 01:56 | |
*** gary-smith_ has joined #openstack-horizon | 02:04 | |
*** bpokorny has joined #openstack-horizon | 02:06 | |
*** ctayal has quit IRC | 02:11 | |
*** ducttape_ has quit IRC | 02:12 | |
*** ducttape_ has joined #openstack-horizon | 02:12 | |
*** Jeffrey4l has quit IRC | 02:26 | |
*** _ducttape_ has joined #openstack-horizon | 02:26 | |
*** Jeffrey4l has joined #openstack-horizon | 02:26 | |
*** Pavo has quit IRC | 02:29 | |
*** ducttape_ has quit IRC | 02:30 | |
*** Jeffrey4l has quit IRC | 02:31 | |
*** Jeffrey4l has joined #openstack-horizon | 02:31 | |
*** revon has quit IRC | 02:32 | |
*** Pavo has joined #openstack-horizon | 02:34 | |
*** mtanino has joined #openstack-horizon | 02:37 | |
*** Zer0Byte__ has quit IRC | 02:39 | |
*** bpokorny_ has joined #openstack-horizon | 02:41 | |
openstackgerrit | Ying Zuo proposed openstack/horizon: Fix alignment issues for nav-tabs and ul on details panels https://review.openstack.org/372774 | 02:43 |
*** bpokorny has quit IRC | 02:44 | |
*** bpokorny_ has quit IRC | 02:45 | |
*** Jeffrey4l has quit IRC | 02:46 | |
*** Jeffrey4l has joined #openstack-horizon | 02:47 | |
*** clu_ has quit IRC | 02:47 | |
*** mtanino has quit IRC | 03:02 | |
*** hughhalf has quit IRC | 03:11 | |
*** hughhalf has joined #openstack-horizon | 03:14 | |
*** _ducttape_ has quit IRC | 03:14 | |
*** gary-smith_ has quit IRC | 03:16 | |
openstackgerrit | Jay Jahns proposed openstack/horizon: Enabling MAC learning needs to also remove security groups and port security https://review.openstack.org/408394 | 03:17 |
*** ctayal has joined #openstack-horizon | 03:19 | |
*** ctayal has quit IRC | 03:27 | |
*** edtubill has joined #openstack-horizon | 03:34 | |
openstackgerrit | chenyingnan proposed openstack/horizon: Add Apache 2.0 license to source file https://review.openstack.org/408398 | 03:37 |
*** Jeffrey4l has quit IRC | 03:38 | |
*** Jeffrey4l has joined #openstack-horizon | 03:38 | |
*** yamamoto_ has joined #openstack-horizon | 03:39 | |
*** masco has joined #openstack-horizon | 03:40 | |
*** Jeffrey4l has quit IRC | 03:42 | |
*** Jeffrey4l has joined #openstack-horizon | 03:43 | |
*** absubram has joined #openstack-horizon | 03:48 | |
*** absubram_ has joined #openstack-horizon | 03:50 | |
*** absubram has quit IRC | 03:52 | |
*** absubram_ is now known as absubram | 03:52 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Expose more of Swift to ResourceType https://review.openstack.org/348741 | 03:54 |
*** Jeffrey4l has quit IRC | 03:56 | |
*** Jeffrey4l has joined #openstack-horizon | 03:56 | |
*** Jeffrey4l has quit IRC | 04:00 | |
*** Jeffrey4l has joined #openstack-horizon | 04:01 | |
*** Jeffrey4l has quit IRC | 04:06 | |
*** Jeffrey4l has joined #openstack-horizon | 04:06 | |
*** Jeffrey4l has quit IRC | 04:09 | |
*** Jeffrey4l has joined #openstack-horizon | 04:09 | |
*** ducttape_ has joined #openstack-horizon | 04:15 | |
*** dave-mccowan has quit IRC | 04:19 | |
*** ducttape_ has quit IRC | 04:20 | |
*** Jeffrey4l has quit IRC | 04:24 | |
*** Jeffrey4l has joined #openstack-horizon | 04:24 | |
*** Jeffrey4l has quit IRC | 04:25 | |
*** Jeffrey4l has joined #openstack-horizon | 04:27 | |
*** Pavo has quit IRC | 04:29 | |
*** Pavo has joined #openstack-horizon | 04:34 | |
*** ratailor has joined #openstack-horizon | 04:37 | |
*** harlowja has joined #openstack-horizon | 04:37 | |
*** adriant has quit IRC | 04:56 | |
*** masco has quit IRC | 05:02 | |
*** alexvictorchan has joined #openstack-horizon | 05:20 | |
*** wolverineav has joined #openstack-horizon | 05:26 | |
*** masco has joined #openstack-horizon | 05:30 | |
*** hurgleburgler has quit IRC | 05:40 | |
*** ducttape_ has joined #openstack-horizon | 05:46 | |
*** harlowja has quit IRC | 05:46 | |
*** hurgleburgler has joined #openstack-horizon | 05:48 | |
*** ChanServ sets mode: +v hurgleburgler | 05:48 | |
*** ducttape_ has quit IRC | 05:50 | |
*** shu-mutou is now known as shu-mutou-AWAY | 05:59 | |
robcresswell | kenji-i: No problem at all, just needs a new blueprint for tracking :) | 06:04 |
*** hurgleburgler has quit IRC | 06:19 | |
*** udesale has joined #openstack-horizon | 06:26 | |
*** ctayal has joined #openstack-horizon | 06:26 | |
*** Pavo has quit IRC | 06:30 | |
*** yamamoto_ has quit IRC | 06:33 | |
*** Pavo has joined #openstack-horizon | 06:34 | |
kenji-i | robcresswell: I created a new blueprint for domains, also will update related patches soon. Thank you :-) | 06:41 |
openstackgerrit | Elvin Tubillara proposed openstack/horizon: WIP Keystone to Keystone Federation Drop Down https://review.openstack.org/408435 | 06:42 |
*** tsufiev_ is now known as tsufiev | 06:45 | |
*** sacharya has quit IRC | 06:51 | |
*** sacharya has joined #openstack-horizon | 06:52 | |
*** jichen has joined #openstack-horizon | 06:55 | |
*** sacharya has quit IRC | 06:57 | |
*** zackf has quit IRC | 06:58 | |
*** tobberydberg has joined #openstack-horizon | 07:00 | |
*** ducttape_ has joined #openstack-horizon | 07:16 | |
*** yamamoto_ has joined #openstack-horizon | 07:17 | |
openstackgerrit | Elvin Tubillara proposed openstack/django_openstack_auth: WIP Add K2K Auth Dropdown https://review.openstack.org/408450 | 07:19 |
*** ducttape_ has quit IRC | 07:21 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Adding identity domains table https://review.openstack.org/387771 | 07:24 |
*** rcernin has joined #openstack-horizon | 07:26 | |
*** edtubill has quit IRC | 07:27 | |
*** betherly_ has joined #openstack-horizon | 07:30 | |
*** wolverineav has quit IRC | 07:31 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Add create domain action in angular domain panel https://review.openstack.org/397080 | 07:32 |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Add delete domain action in angular domain panel https://review.openstack.org/397539 | 07:33 |
openstackgerrit | Kenji Ishii proposed openstack/horizon: [WIP]Add Edit domain action in angular https://review.openstack.org/398780 | 07:34 |
*** wolverineav has joined #openstack-horizon | 07:35 | |
*** wolverineav has quit IRC | 07:39 | |
*** tosky has joined #openstack-horizon | 07:41 | |
*** tobberyd_ has joined #openstack-horizon | 07:44 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: hzResourceProperty can handle 'priority' attribute https://review.openstack.org/397132 | 07:45 |
*** ratailor has quit IRC | 07:45 | |
*** tobberydberg has quit IRC | 07:48 | |
*** wolverineav has joined #openstack-horizon | 07:50 | |
*** sacharya has joined #openstack-horizon | 07:53 | |
*** wolverineav has quit IRC | 07:55 | |
*** ratailor has joined #openstack-horizon | 07:58 | |
*** sacharya has quit IRC | 07:58 | |
*** sacharya has joined #openstack-horizon | 08:00 | |
*** wolverineav has joined #openstack-horizon | 08:00 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: [trivial]Add support keys for OPENSTACK_NEUTRON_NETWORK in doc https://review.openstack.org/408470 | 08:03 |
*** wolverineav has quit IRC | 08:04 | |
*** sacharya has quit IRC | 08:06 | |
*** TravT has quit IRC | 08:16 | |
*** tobberyd_ has quit IRC | 08:16 | |
*** tobberydberg has joined #openstack-horizon | 08:17 | |
*** betherly_ has quit IRC | 08:17 | |
*** betherly_ has joined #openstack-horizon | 08:18 | |
*** jpich has joined #openstack-horizon | 08:21 | |
*** ruoyu has joined #openstack-horizon | 08:28 | |
*** Pavo has quit IRC | 08:29 | |
*** jamielennox is now known as jamielennox|away | 08:33 | |
*** ruoyu has quit IRC | 08:33 | |
*** Pavo has joined #openstack-horizon | 08:34 | |
*** ctayal has quit IRC | 08:39 | |
*** ducttape_ has joined #openstack-horizon | 08:47 | |
*** ducttape_ has quit IRC | 08:51 | |
*** pcaruana has joined #openstack-horizon | 08:58 | |
*** zackf has joined #openstack-horizon | 09:00 | |
*** zackf has quit IRC | 09:04 | |
*** zhurong has quit IRC | 09:06 | |
*** zhurong has joined #openstack-horizon | 09:08 | |
openstackgerrit | Merged openstack/horizon: Remove additional response.render() for tabs https://review.openstack.org/333345 | 09:16 |
*** absubram_ has joined #openstack-horizon | 09:17 | |
*** absubram has quit IRC | 09:19 | |
*** absubram_ is now known as absubram | 09:19 | |
*** wolverineav has joined #openstack-horizon | 09:26 | |
*** wolverineav has quit IRC | 09:31 | |
*** zhurong has quit IRC | 09:33 | |
*** zhurong has joined #openstack-horizon | 09:35 | |
*** wolverineav has joined #openstack-horizon | 09:36 | |
*** mvk has quit IRC | 09:39 | |
*** wolverineav has quit IRC | 09:41 | |
*** hogepodge has quit IRC | 09:45 | |
*** hogepodge has joined #openstack-horizon | 09:46 | |
*** wolverineav has joined #openstack-horizon | 09:46 | |
openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Move all Django configuration into .conf file https://review.openstack.org/404735 | 09:48 |
*** zhurong has quit IRC | 09:50 | |
*** wolverineav has quit IRC | 09:51 | |
*** zhurong has joined #openstack-horizon | 09:55 | |
*** wolverineav has joined #openstack-horizon | 09:57 | |
robcresswell | tsufiev: Anything left on profiler bp? | 10:00 |
*** zhurong has quit IRC | 10:01 | |
robcresswell | tsufiev: I'd like to close it soon :) | 10:01 |
*** wolverineav has quit IRC | 10:01 | |
*** betherly_ has quit IRC | 10:04 | |
*** jpich has quit IRC | 10:05 | |
*** Zer0Byte__ has joined #openstack-horizon | 10:06 | |
*** jtomasek has joined #openstack-horizon | 10:07 | |
*** kzaitsev_mb has joined #openstack-horizon | 10:10 | |
*** yamamoto_ has quit IRC | 10:11 | |
*** mvk has joined #openstack-horizon | 10:11 | |
*** yamamoto_ has joined #openstack-horizon | 10:13 | |
*** betherly_ has joined #openstack-horizon | 10:13 | |
*** jpich has joined #openstack-horizon | 10:14 | |
*** wolverineav has joined #openstack-horizon | 10:16 | |
*** ducttape_ has joined #openstack-horizon | 10:17 | |
*** ducttape_ has quit IRC | 10:19 | |
*** ducttape_ has joined #openstack-horizon | 10:19 | |
*** wolverineav has quit IRC | 10:21 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Enable profiling of angular pages https://review.openstack.org/358574 | 10:25 |
*** wolverineav has joined #openstack-horizon | 10:27 | |
*** Pavo has quit IRC | 10:29 | |
*** gleblanc has joined #openstack-horizon | 10:30 | |
*** ducttape_ has quit IRC | 10:31 | |
*** gleblanc has quit IRC | 10:31 | |
*** wolverineav has quit IRC | 10:31 | |
*** glb has joined #openstack-horizon | 10:31 | |
*** Pavo has joined #openstack-horizon | 10:34 | |
*** wolverineav has joined #openstack-horizon | 10:37 | |
*** wolverineav has quit IRC | 10:41 | |
*** wolverineav has joined #openstack-horizon | 10:47 | |
*** wolverineav has quit IRC | 10:52 | |
*** kzaitsev_mb has quit IRC | 10:57 | |
*** hogepodge has quit IRC | 11:01 | |
*** ducttape_ has joined #openstack-horizon | 11:02 | |
*** udesale has quit IRC | 11:04 | |
*** udesale has joined #openstack-horizon | 11:05 | |
*** kzaitsev_mb has joined #openstack-horizon | 11:11 | |
*** udesale has quit IRC | 11:17 | |
*** wolverineav has joined #openstack-horizon | 11:17 | |
*** ducttape_ has quit IRC | 11:17 | |
*** Zer0Byte__ has quit IRC | 11:20 | |
*** Jeffrey4l has quit IRC | 11:20 | |
*** hogepodge has joined #openstack-horizon | 11:21 | |
*** wolverineav has quit IRC | 11:22 | |
*** alexvictorchan has quit IRC | 11:24 | |
*** hogepodge has quit IRC | 11:26 | |
*** wolverineav has joined #openstack-horizon | 11:27 | |
*** alexvictorchan has joined #openstack-horizon | 11:28 | |
*** ducttape_ has joined #openstack-horizon | 11:28 | |
*** udesale has joined #openstack-horizon | 11:31 | |
*** wolverineav has quit IRC | 11:32 | |
*** edtubill has joined #openstack-horizon | 11:33 | |
*** betherly_ has quit IRC | 11:37 | |
*** hogepodge has joined #openstack-horizon | 11:38 | |
*** Jeffrey4l has joined #openstack-horizon | 11:43 | |
*** ducttape_ has quit IRC | 11:44 | |
*** tobberydberg has quit IRC | 11:45 | |
*** tobberydberg has joined #openstack-horizon | 11:46 | |
*** hogepodge has quit IRC | 11:48 | |
*** zackf has joined #openstack-horizon | 11:49 | |
*** zackf has quit IRC | 11:53 | |
*** hogepodge has joined #openstack-horizon | 12:00 | |
*** yamamoto_ has quit IRC | 12:02 | |
*** dave-mccowan has joined #openstack-horizon | 12:02 | |
*** sacharya has joined #openstack-horizon | 12:02 | |
openstackgerrit | Elvin Tubillara proposed openstack/django_openstack_auth: WIP Add K2K Auth Dropdown https://review.openstack.org/408450 | 12:06 |
*** sacharya has quit IRC | 12:07 | |
openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Move all Django configuration into .conf file https://review.openstack.org/404735 | 12:08 |
edtubill | david-lyle, stevemar: Can you guys checkout the approach I'm taking for these patches for K2K on horizon: https://review.openstack.org/#/c/408450, https://review.openstack.org/#/c/408435. I won't be able to make the meeting today. | 12:08 |
*** wolverineav has joined #openstack-horizon | 12:09 | |
*** edtubill has quit IRC | 12:11 | |
*** wolverineav has quit IRC | 12:14 | |
*** edtubill has joined #openstack-horizon | 12:15 | |
*** erlon-airlong has joined #openstack-horizon | 12:18 | |
*** wolverineav has joined #openstack-horizon | 12:19 | |
*** edtubill has quit IRC | 12:21 | |
openstackgerrit | anusha proposed openstack/horizon: Networks panel can't be actually disabled https://review.openstack.org/408583 | 12:22 |
*** wolverineav has quit IRC | 12:24 | |
*** ratailor has quit IRC | 12:28 | |
openstackgerrit | Merged openstack/horizon: Add Apache 2.0 license to source file https://review.openstack.org/379113 | 12:29 |
*** wolverineav has joined #openstack-horizon | 12:29 | |
*** wolverineav has quit IRC | 12:29 | |
*** Pavo has quit IRC | 12:29 | |
*** Pavo has joined #openstack-horizon | 12:34 | |
*** betherly_ has joined #openstack-horizon | 12:39 | |
*** wolverineav has joined #openstack-horizon | 12:39 | |
*** masco has quit IRC | 12:41 | |
*** wolverineav has quit IRC | 12:44 | |
*** yamamoto has joined #openstack-horizon | 12:45 | |
*** ducttape_ has joined #openstack-horizon | 12:48 | |
*** wolverineav has joined #openstack-horizon | 12:50 | |
*** ducttape_ has quit IRC | 12:53 | |
*** wolverineav has quit IRC | 12:54 | |
*** udesale has quit IRC | 12:58 | |
*** udesale has joined #openstack-horizon | 12:58 | |
*** AndyWojo has quit IRC | 13:09 | |
*** jdwald has joined #openstack-horizon | 13:09 | |
*** AndyWojo has joined #openstack-horizon | 13:10 | |
openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Move all Django configuration into .conf file https://review.openstack.org/404735 | 13:17 |
*** itisha has joined #openstack-horizon | 13:17 | |
*** aortega has quit IRC | 13:28 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Move js files into openstack_dashboard folder. https://review.openstack.org/389530 | 13:33 |
*** udesale has quit IRC | 13:42 | |
*** absubram has quit IRC | 13:51 | |
*** ruoyu has joined #openstack-horizon | 13:55 | |
*** sacharya has joined #openstack-horizon | 14:03 | |
*** sacharya has quit IRC | 14:07 | |
*** eandersson has joined #openstack-horizon | 14:11 | |
*** glb has quit IRC | 14:11 | |
*** lblanchard has joined #openstack-horizon | 14:12 | |
*** yamamoto has quit IRC | 14:14 | |
*** yamamoto has joined #openstack-horizon | 14:16 | |
*** lblanchard1 has joined #openstack-horizon | 14:17 | |
*** ducttape_ has joined #openstack-horizon | 14:17 | |
*** lblanchard has quit IRC | 14:20 | |
*** Pavo has quit IRC | 14:29 | |
*** jichen has quit IRC | 14:31 | |
*** Pavo has joined #openstack-horizon | 14:34 | |
*** aortega has joined #openstack-horizon | 14:36 | |
*** ruoyu has quit IRC | 14:37 | |
*** gary-smith_ has joined #openstack-horizon | 14:38 | |
*** ruoyu has joined #openstack-horizon | 14:40 | |
*** weezS has joined #openstack-horizon | 14:44 | |
*** ruoyu has quit IRC | 14:44 | |
*** ruoyu has joined #openstack-horizon | 14:44 | |
*** ducttape_ has quit IRC | 14:46 | |
*** jdwald has quit IRC | 14:51 | |
*** TravT has joined #openstack-horizon | 15:00 | |
*** ChanServ sets mode: +v TravT | 15:00 | |
*** jtriley has joined #openstack-horizon | 15:02 | |
*** weezS has quit IRC | 15:07 | |
*** hurgleburgler has joined #openstack-horizon | 15:10 | |
*** ChanServ sets mode: +v hurgleburgler | 15:10 | |
*** chlong has joined #openstack-horizon | 15:13 | |
*** jprovazn has joined #openstack-horizon | 15:14 | |
*** ducttape_ has joined #openstack-horizon | 15:16 | |
*** matt-borland has joined #openstack-horizon | 15:21 | |
*** _ducttape_ has joined #openstack-horizon | 15:26 | |
*** alexvictorchan has quit IRC | 15:26 | |
openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Move all Django configuration into .conf file https://review.openstack.org/404735 | 15:26 |
*** ducttape_ has quit IRC | 15:29 | |
*** mtanino has joined #openstack-horizon | 15:49 | |
*** Marcellin__ has joined #openstack-horizon | 15:50 | |
_ducttape_ | abandon of this makes me sad robcresswell https://review.openstack.org/#/c/326513/ :'( | 15:52 |
* _ducttape_ just wants to share his sorrow | 15:52 | |
robcresswell | _ducttape_: Still on my list, just need to find a sane approach | 15:52 |
robcresswell | I was just figuring out what is active or not cause I have like 20 open patches right now | 15:52 |
_ducttape_ | I saw something mentioned in yesterday meeting, might have been from ediardo ? | 15:53 |
_ducttape_ | a patch that reminded me of this | 15:53 |
robcresswell | _ducttape_: Oh? I dont recall it | 15:53 |
robcresswell | If it saves me work, thats great | 15:53 |
_ducttape_ | https://review.openstack.org/#/c/366957/ was it | 15:54 |
_ducttape_ | it's not directly the same, but it seems like it should be related | 15:55 |
_ducttape_ | like the ability to customize what users see and what they can filter, in addition to the default order of things.... these are similar | 15:55 |
robcresswell | Oh, hmm, not really, thats just adding the ability to filter, whereas your ask is.. well, the opposite | 15:56 |
robcresswell | prevent filter and give a fixed order | 15:56 |
robcresswell | iirc | 15:56 |
_ducttape_ | if I could customize a set of filters, then maybe I could also remove the items I don't want presented ? | 15:57 |
_ducttape_ | the main goal is to push users to use certain selections | 15:57 |
rdopiera | robcresswell: found a way to translate strings from configuration, even if they are inside lists and dicts | 15:57 |
_ducttape_ | weather that is filters or sorting, we can be flexible on | 15:57 |
_ducttape_ | whether / weather / wither | 15:58 |
robcresswell | rdopiera: Woohoo! Nice one | 15:59 |
robcresswell | _ducttape_: Okay, cool, I'll keep that in mind | 15:59 |
openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Move all Django configuration into .conf file https://review.openstack.org/404735 | 15:59 |
betherly_ | hi all! so i may be missing something obvious but im trying to view a standard 404 page and i keep getting "You're seeing this error because you have DEBUG = True in your Django settings file. Change that to False, and Django will display a standard 404 page." | 16:02 |
openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Move all Django configuration into .conf file https://review.openstack.org/404735 | 16:02 |
betherly_ | however, my debug is set to false | 16:02 |
betherly_ | any ideas? | 16:02 |
hurgleburgler | betherly_ you can just go directly to it | 16:03 |
robcresswell | betherly_: Not to be rude, but I think it isnt set to False :p | 16:03 |
hurgleburgler | go to /404 | 16:03 |
hurgleburgler | I believe | 16:03 |
robcresswell | that also works ^^ | 16:03 |
hurgleburgler | *checks the urls.py to make sure* | 16:03 |
rdopiera | betherly_: check your openstack_dashboard/local/local_settings.py | 16:03 |
rdopiera | it may be changed there several times... | 16:04 |
robcresswell | hurgleburgler: HI o/ | 16:04 |
*** sacharya has joined #openstack-horizon | 16:04 | |
hurgleburgler | robcresswell Hola! | 16:04 |
_ducttape_ | aloha seems awfully similar to hola. I'm suspicious. | 16:05 |
*** ruoyu has quit IRC | 16:05 | |
hurgleburgler | LOL | 16:06 |
hurgleburgler | I wish it was aloha | 16:06 |
betherly_ | rdopiera: thanks that was it. knew i was being ridiculous | 16:06 |
hurgleburgler | then I might have a beach that is accessible | 16:06 |
betherly_ | just had a week of tripleo bootcamp and my brain is not entirely reliable | 16:06 |
*** weezS has joined #openstack-horizon | 16:07 | |
rdopiera | betherly_: happens all the time | 16:07 |
hurgleburgler | looks like that trick only works for the 500 page | 16:08 |
rdopiera | betherly_: also, editing the wrong settings file | 16:08 |
hurgleburgler | pity | 16:08 |
*** tosky has quit IRC | 16:08 | |
*** sacharya has quit IRC | 16:09 | |
rdopiera | so, guys, this is pretty much the summary of how I want to approach the config files: https://review.openstack.org/404735 | 16:10 |
rdopiera | pretty much all the pieces are there already, though I only moved a bunch of settings | 16:10 |
rdopiera | any feedback would be welcome | 16:10 |
robcresswell | thos shorthands | 16:10 |
robcresswell | *cries* | 16:11 |
rdopiera | (I know it fails the tempest test for now, I'm going to work on it, it shouldn't) | 16:11 |
robcresswell | you are one of those people who replaces all their variables with a single letter :p | 16:11 |
rdopiera | robcresswell: I can expand them all, but then it will be huge | 16:11 |
rdopiera | robcresswell: no, I don't normally do that | 16:11 |
rdopiera | robcresswell: but I think that in this case it's justified | 16:11 |
rdopiera | https://review.openstack.org/#/c/404735/24/openstack_dashboard/utils/config_websso.py | 16:12 |
robcresswell | I personally would choose an extra 50 lines over O(t,ct) etc :) | 16:12 |
rdopiera | this file has the example of a translation inside a list of tuples | 16:12 |
robcresswell | nice | 16:12 |
robcresswell | this is cool | 16:12 |
robcresswell | After this we need to use stevedore for plugins :D | 16:13 |
rdopiera | you pass a "spec", describing the structure | 16:13 |
rdopiera | and that can contain also callables | 16:13 |
robcresswell | ah | 16:13 |
rdopiera | and the callables will be called on the corresponding pieces of the structure | 16:14 |
robcresswell | I like the topic too: 'bp/bp' | 16:14 |
rdopiera | in this case, I'm passing another type, which does the translation | 16:14 |
robcresswell | The one blueprint to rule them all | 16:14 |
rdopiera | that's set automatically :/ | 16:14 |
rdopiera | no idea why | 16:14 |
robcresswell | rdopiera: Did you verify it with the pseudo translation tool? | 16:14 |
rdopiera | robcresswell: it won't collect strings | 16:15 |
rdopiera | if you change settings, you have to add the translations there yourself | 16:15 |
robcresswell | rdopiera: its because it should be "Implements: blueprint ini-based-settings" | 16:15 |
*** alexvictorchan has joined #openstack-horizon | 16:15 | |
robcresswell | without the bp/ | 16:15 |
rdopiera | ah, I see | 16:15 |
robcresswell | rdopiera: hmm, the tool should still recognise the translatable string though, I thiiink. | 16:16 |
rdopiera | let's not go there | 16:16 |
rdopiera | it will collect the strings from the defaults | 16:16 |
*** zackf has joined #openstack-horizon | 16:16 | |
robcresswell | All it does is find translatable strings and wrap them in gobbledegook | 16:16 |
rdopiera | which is all that we can reasonably provide | 16:16 |
robcresswell | Yes, I was just checking that it is indeed marking them as translatable strings, thats all | 16:17 |
robcresswell | so that django is aware and can replace them | 16:17 |
robcresswell | otherwise its borked | 16:17 |
rdopiera | yes for defaults | 16:17 |
rdopiera | no for strings inside the actual .conf files | 16:17 |
*** ruoyu has joined #openstack-horizon | 16:17 | |
rdopiera | and I see to sane way to support that | 16:18 |
*** jpich has quit IRC | 16:18 | |
robcresswell | Whats the point in having translatable strings inside conf files if you cant mark them as translatable? | 16:18 |
rdopiera | they are marked as translatable | 16:18 |
rdopiera | they are just not collected | 16:18 |
rdopiera | you have to add them to your .po files yourself | 16:19 |
robcresswell | ahh | 16:19 |
robcresswell | Understood | 16:19 |
*** pcaruana has quit IRC | 16:19 | |
robcresswell | I didnt realise that the pseudo tool wouldnt get that | 16:19 |
rdopiera | I suppose I could make a django command that just loads the current config, goes though it all and prints all __proxy__ objectes from it | 16:20 |
*** ruoyu has quit IRC | 16:22 | |
*** _ducttape_ has quit IRC | 16:22 | |
robcresswell | rdopiera: Lets not go overboard | 16:22 |
*** jdwald has joined #openstack-horizon | 16:23 | |
robcresswell | rdopiera: I can just test it manually | 16:23 |
*** ducttape_ has joined #openstack-horizon | 16:23 | |
*** ducttape_ has quit IRC | 16:23 | |
*** ducttape_ has joined #openstack-horizon | 16:23 | |
*** ruoyu has joined #openstack-horizon | 16:29 | |
rdopiera | robcresswell: no, I mean for collecting the translation strings | 16:29 |
rdopiera | robcresswell: from the config files | 16:29 |
*** Pavo has quit IRC | 16:29 | |
*** sacharya has joined #openstack-horizon | 16:30 | |
*** mvk has quit IRC | 16:30 | |
*** rcernin has quit IRC | 16:31 | |
robcresswell | rdopiera: You could extend the existing extract_messages command | 16:32 |
rdopiera | right | 16:33 |
rdopiera | but that's something for later | 16:33 |
robcresswell | I'm not worried though, as long as it's not a regression it's fine | 16:33 |
*** ruoyu has quit IRC | 16:33 | |
rdopiera | I'm kinda proud of that "Literal" type for oslo.config | 16:33 |
rdopiera | it also uses python syntax, not json | 16:33 |
rdopiera | so you can use both '' and "" stings, and have commas at the ends, etc. | 16:34 |
robcresswell | Glorious | 16:34 |
robcresswell | I'll take a look tomorrow morning when I have fresh brain and coffee | 16:34 |
*** Pavo has joined #openstack-horizon | 16:34 | |
*** ruoyu has joined #openstack-horizon | 16:40 | |
*** ducttape_ has quit IRC | 16:43 | |
*** ducttape_ has joined #openstack-horizon | 16:43 | |
rdopiera | david-lyle: would you have a moment? | 16:44 |
*** ruoyu has quit IRC | 16:44 | |
rdopiera | david-lyle: do you think you could point me to where the configuration for the tempest-horizon is being generated? | 16:44 |
rdopiera | david-lyle: for the gate, I mean | 16:44 |
david-lyle | rdopiera: sure, let me find it | 16:45 |
rdopiera | I tried to run it locally with tox, but it failed | 16:45 |
david-lyle | rdopiera: run it locally how? | 16:46 |
david-lyle | https://github.com/openstack/tempest-horizon is the repo | 16:46 |
rdopiera | yes, I have the repo | 16:47 |
rdopiera | but it requires additional config | 16:47 |
*** jtomasek has quit IRC | 16:47 | |
david-lyle | tox in tempest ? | 16:47 |
rdopiera | well, I naively just typed 'tox' in that repo you just linked | 16:47 |
rdopiera | and it seemed to do something | 16:48 |
rdopiera | but failed lacking config | 16:48 |
david-lyle | ah, you should be running it from tempest | 16:48 |
rdopiera | I assume the gate has that config from somewhere | 16:48 |
david-lyle | I should update the README | 16:48 |
david-lyle | essentially you need to install that tempest-horizon package somewhere on your system | 16:48 |
david-lyle | it can be in a venv if tempest is using a venv | 16:49 |
rdopiera | I see, trying now | 16:49 |
david-lyle | and then "testr run tempest_horizon.tests.scenario.test_dashboard_basic_ops.TestDashboardBasicOps" will give you the horizon plugin results | 16:49 |
david-lyle | otherwise you will get a lot of other output | 16:50 |
david-lyle | this is more info on tempest plugins in general http://docs.openstack.org/developer/tempest/plugin.html | 16:51 |
*** betherly_ has quit IRC | 16:51 | |
*** tobberydberg has quit IRC | 16:55 | |
ediardo | o/ | 16:56 |
*** ruoyu has joined #openstack-horizon | 16:56 | |
*** gary-smith_ has quit IRC | 16:57 | |
*** ruoyu has quit IRC | 17:00 | |
*** bpokorny has joined #openstack-horizon | 17:01 | |
*** rcernin has joined #openstack-horizon | 17:03 | |
*** yamamoto has quit IRC | 17:03 | |
*** Ephur has joined #openstack-horizon | 17:04 | |
*** ctayal has joined #openstack-horizon | 17:06 | |
*** ruoyu has joined #openstack-horizon | 17:07 | |
*** ruoyu has quit IRC | 17:11 | |
rdopiera | david-lyle: where does it take the login_url, dahsboard_url, etc. from on the gate? | 17:12 |
david-lyle | tempest_conf | 17:15 |
david-lyle | only dashboard_url is being set by tempest currently | 17:16 |
david-lyle | http://logs.openstack.org/47/408247/2/check/gate-horizon-dsvm-tempest-plugin-ubuntu-xenial/87ac623/logs/tempest_conf.txt.gz e.g., | 17:16 |
rdopiera | david-lyle: the problem I have, when I moved the settings to a .conf file, that test fails with a 404 | 17:16 |
rdopiera | david-lyle: so I suspect it gets the wrong address somehow | 17:16 |
*** ruoyu has joined #openstack-horizon | 17:17 | |
rdopiera | david-lyle: how does tempest.conf know what is the address? | 17:17 |
david-lyle | it started horizon | 17:17 |
*** ruoyu has quit IRC | 17:19 | |
rdopiera | KeyError: 'tenant' | 17:19 |
rdopiera | does that look familiar? | 17:19 |
*** weezS has quit IRC | 17:20 | |
david-lyle | according to the README in https://github.com/openstack/tempest "tox -egenconfig" will generate a sample config | 17:20 |
david-lyle | rdopiera: I don't remember seeing that no | 17:20 |
*** ruoyu has joined #openstack-horizon | 17:20 | |
david-lyle | I usually run tempest from a devstack deploy | 17:20 |
rdopiera | hmm, ok | 17:20 |
david-lyle | so there may be some steps happening in the devstack config of tempest | 17:21 |
rdopiera | I will try that tomorrow | 17:21 |
rdopiera | thank you for help! | 17:21 |
robcresswell | keystone v2/v3 change? | 17:21 |
david-lyle | nah, that's the default in devstack now | 17:21 |
robcresswell | Either way, the gate doesnt seem to be failing | 17:21 |
david-lyle | that being v3 | 17:21 |
*** piet has joined #openstack-horizon | 17:21 | |
robcresswell | Yeah, I meant that radomir might have an old endpoint or something... anyway | 17:21 |
rdopiera | robcresswell: that was it | 17:22 |
*** weezS has joined #openstack-horizon | 17:23 | |
*** yamamoto has joined #openstack-horizon | 17:25 | |
robcresswell | yeah! | 17:25 |
*** bpokorny has quit IRC | 17:27 | |
*** bpokorny has joined #openstack-horizon | 17:28 | |
*** ruoyu has quit IRC | 17:28 | |
*** dsneddon_ is now known as dsneddon | 17:32 | |
*** bpokorny has quit IRC | 17:32 | |
*** yamamoto has quit IRC | 17:34 | |
*** ruoyu has joined #openstack-horizon | 17:35 | |
*** jgravel has quit IRC | 17:39 | |
*** ruoyu has quit IRC | 17:39 | |
*** bpokorny has joined #openstack-horizon | 17:40 | |
*** wolverineav has joined #openstack-horizon | 17:40 | |
*** ducttape_ has quit IRC | 17:44 | |
*** wolverineav has quit IRC | 17:45 | |
*** wolverineav has joined #openstack-horizon | 17:45 | |
*** TravT has quit IRC | 17:46 | |
*** ruoyu has joined #openstack-horizon | 17:46 | |
*** ruoyu has quit IRC | 17:50 | |
*** ctayal has quit IRC | 17:51 | |
*** ruoyu has joined #openstack-horizon | 17:57 | |
*** ruoyu has quit IRC | 18:01 | |
*** wolverineav has quit IRC | 18:03 | |
openstackgerrit | Revon Mathews proposed openstack/horizon: Fixes inconsistency in Stacks filter label https://review.openstack.org/408755 | 18:10 |
*** ruoyu has joined #openstack-horizon | 18:10 | |
*** wolverineav has joined #openstack-horizon | 18:12 | |
*** ruoyu has quit IRC | 18:14 | |
*** ducttape_ has joined #openstack-horizon | 18:15 | |
*** jgravel has joined #openstack-horizon | 18:15 | |
*** harlowja has joined #openstack-horizon | 18:17 | |
*** wolverineav has quit IRC | 18:17 | |
*** harlowja_ has joined #openstack-horizon | 18:20 | |
*** harlowja has quit IRC | 18:22 | |
*** weezS_ has joined #openstack-horizon | 18:25 | |
*** tobberydberg has joined #openstack-horizon | 18:25 | |
*** weezS has quit IRC | 18:28 | |
*** weezS_ is now known as weezS | 18:28 | |
*** Pavo has quit IRC | 18:29 | |
*** Pavo has joined #openstack-horizon | 18:30 | |
*** zul_ has joined #openstack-horizon | 18:31 | |
*** wolverineav has joined #openstack-horizon | 18:32 | |
*** tqtran has joined #openstack-horizon | 18:33 | |
*** betherly_ has joined #openstack-horizon | 18:34 | |
*** yamamoto has joined #openstack-horizon | 18:35 | |
*** ruoyu has joined #openstack-horizon | 18:35 | |
*** wolverineav has quit IRC | 18:37 | |
*** tobberydberg has quit IRC | 18:39 | |
*** clu_ has joined #openstack-horizon | 18:39 | |
*** ChanServ sets mode: +v clu_ | 18:39 | |
*** ruoyu has quit IRC | 18:40 | |
*** bpokorny has quit IRC | 18:40 | |
*** bpokorny has joined #openstack-horizon | 18:41 | |
*** ctayal has joined #openstack-horizon | 18:43 | |
*** bpokorny has quit IRC | 18:45 | |
*** zul_ has quit IRC | 18:46 | |
*** ruoyu has joined #openstack-horizon | 18:46 | |
*** zul_ has joined #openstack-horizon | 18:48 | |
*** dave-mccowan has quit IRC | 18:49 | |
*** ruoyu has quit IRC | 18:51 | |
*** yamamoto has quit IRC | 18:52 | |
*** wolverineav has joined #openstack-horizon | 18:52 | |
*** wolverineav has quit IRC | 18:57 | |
*** ctayal has quit IRC | 19:00 | |
*** bpokorny has joined #openstack-horizon | 19:00 | |
*** ctayal has joined #openstack-horizon | 19:02 | |
robcresswell | matt-borland: Any chance of an update on https://review.openstack.org/#/c/362230/ ? | 19:04 |
*** tobberydberg has joined #openstack-horizon | 19:06 | |
*** betherly_ has quit IRC | 19:06 | |
*** tobberydberg has quit IRC | 19:10 | |
*** ruoyu has joined #openstack-horizon | 19:10 | |
*** ruoyu has quit IRC | 19:15 | |
*** jichen has joined #openstack-horizon | 19:15 | |
openstackgerrit | Merged openstack/horizon: Add metadata in snapshot details page https://review.openstack.org/335020 | 19:16 |
*** ruoyu has joined #openstack-horizon | 19:20 | |
*** wolverineav has joined #openstack-horizon | 19:21 | |
*** jgravel has quit IRC | 19:23 | |
*** ruoyu has quit IRC | 19:24 | |
*** wolverineav has quit IRC | 19:26 | |
*** jgravel has joined #openstack-horizon | 19:29 | |
*** bpokorny has quit IRC | 19:30 | |
*** bpokorny has joined #openstack-horizon | 19:31 | |
*** piet has quit IRC | 19:32 | |
*** ruoyu has joined #openstack-horizon | 19:34 | |
*** bpokorny has quit IRC | 19:35 | |
*** ruoyu has quit IRC | 19:36 | |
*** ruoyu_ has joined #openstack-horizon | 19:36 | |
*** bpokorny has joined #openstack-horizon | 19:40 | |
*** ruoyu_ has quit IRC | 19:41 | |
*** wolverineav has joined #openstack-horizon | 19:41 | |
*** jichen_ has joined #openstack-horizon | 19:43 | |
*** rcernin has quit IRC | 19:43 | |
*** jichen has quit IRC | 19:43 | |
*** jichen_ is now known as jichen | 19:44 | |
*** wolverineav has quit IRC | 19:46 | |
*** jichen has quit IRC | 19:50 | |
*** wolverineav has joined #openstack-horizon | 19:51 | |
r1chardj0n3s | Horizon/Keystone cross-project meeting in .. 7 minutes .. in #openstack-meeting-cp | 19:53 |
*** wolverineav has quit IRC | 19:56 | |
ducttape_ | wasn't this display bug recently fixed? http://pasteboard.co/7rHazUOgi.png the scroll and cut off stuff | 19:56 |
*** rcernin has joined #openstack-horizon | 19:57 | |
matt-borland | robcresswell, I'm not going to follow up on changes to that patch. | 19:57 |
*** ruoyu has joined #openstack-horizon | 19:58 | |
*** bpokorny has quit IRC | 19:58 | |
r1chardj0n3s | matt-borland: is that because of time or because it's a bad idea? | 19:58 |
*** bpokorny has joined #openstack-horizon | 19:59 | |
matt-borland | mostly time, I don't think what is being suggested improves the code or result. | 19:59 |
r1chardj0n3s | oh, I see your comment on it now thanks | 19:59 |
robcresswell | ducttape_: No, hurgleburgler blocked the patch for reasons | 20:00 |
robcresswell | Ill take a look tomorrow | 20:00 |
hurgleburgler | O:-O | 20:00 |
hurgleburgler | Oh yeah, that was a very very very bad fix | 20:00 |
hurgleburgler | *hides* | 20:00 |
hurgleburgler | that made the modal the size of the dropdown all the time | 20:01 |
hurgleburgler | no matter what | 20:01 |
hurgleburgler | the hidden dropdown size | 20:01 |
hurgleburgler | so, in that example, it looks alright | 20:01 |
hurgleburgler | but that's only because the dropdown its ridiculously big | 20:01 |
hurgleburgler | so, imagine if its 100s of items | 20:02 |
ducttape_ | whatever it is, it's not terrific right now | 20:02 |
ducttape_ | ;) | 20:02 |
hurgleburgler | the modal is GIANT with tons of white space for no apparent reason and the button is pages and pages of white space down | 20:02 |
hurgleburgler | how it is right now is actually more scalable than how the fix would make it | 20:02 |
*** bpokorny has quit IRC | 20:03 | |
hurgleburgler | the right way would need to bring the dropdown out over the modal | 20:03 |
hurgleburgler | and mess with the z-indexing a bit | 20:04 |
*** tobberydberg has joined #openstack-horizon | 20:07 | |
robcresswell | Okay | 20:07 |
*** ruoyu has quit IRC | 20:08 | |
*** ruoyu has joined #openstack-horizon | 20:09 | |
robcresswell | matt-borland: No problem, I'll update it tomorrow | 20:09 |
*** wolverineav has joined #openstack-horizon | 20:11 | |
*** dsneddon is now known as dsneddon_lunch | 20:11 | |
*** jamielennox|away is now known as jamielennox | 20:13 | |
matt-borland | sounds good robcresswell | 20:13 |
matt-borland | thanks! | 20:13 |
*** wolverineav has quit IRC | 20:16 | |
*** absubram has joined #openstack-horizon | 20:16 | |
*** tobberydberg has quit IRC | 20:19 | |
*** ctayal has quit IRC | 20:22 | |
ducttape_ | hurgleburgler: could the modal body have higher z index ? seems like anything in that main display area should be top priority | 20:25 |
*** ctayal has joined #openstack-horizon | 20:28 | |
ducttape_ | ediardo talking about a patch of yours above ^. want me to take a stab at it ? | 20:29 |
*** Pavo has quit IRC | 20:29 | |
ducttape_ | https://review.openstack.org/#/c/389866 for ref | 20:30 |
ediardo | sure, go ahead | 20:30 |
robcresswell | ducttape_: The dropdown items should have priority I assume, so they overlay like an un-themable select | 20:30 |
*** wolverineav has joined #openstack-horizon | 20:30 | |
ediardo | that bug is very annoying | 20:30 |
ducttape_ | I'd think so too | 20:30 |
robcresswell | ducttape_: I can have a stab at it tomorrow if you like. Hadn't done so far because I thought it was getting fixed elsewhere | 20:32 |
hurgleburgler | One thing | 20:32 |
hurgleburgler | if you mess with the z-indexes | 20:32 |
hurgleburgler | be sure to make everything in relation to the variables that already exist | 20:32 |
ducttape_ | no worries, but I think the overflow y is needed hurgleburgler | 20:32 |
hurgleburgler | and don't change the variables | 20:32 |
robcresswell | hurgleburgler: Yep, got it | 20:33 |
hurgleburgler | they are the most fragile part of Bootstrap itself | 20:33 |
*** zul_ has quit IRC | 20:33 | |
hurgleburgler | even they recommend not touching them directly, you can read their comments | 20:33 |
hurgleburgler | the overflow y will just make the modal grow. | 20:33 |
hurgleburgler | indefinately | 20:34 |
ducttape_ | not on my machine it does not | 20:34 |
hurgleburgler | And that's ANOTHER bug | 20:34 |
hurgleburgler | one that I fixed with this solution | 20:34 |
hurgleburgler | so, if we put that back in, that other bug will just resurface as well | 20:34 |
ducttape_ | do you recall that other bug ? | 20:34 |
*** Pavo has joined #openstack-horizon | 20:34 | |
hurgleburgler | not off the top of my head | 20:34 |
hurgleburgler | the modal rework was done a year ago, I think? | 20:34 |
hurgleburgler | I'd have to take a look at it again | 20:34 |
openstackgerrit | Merged openstack/horizon: Add i18n support to Quota.humanizeNumbers https://review.openstack.org/199997 | 20:35 |
*** wolverineav has quit IRC | 20:35 | |
ducttape_ | y overflow of either initial or visible also fix this, would those be terrible as well hurgleburgler ? | 20:37 |
ediardo | This is the change ID I599ad2ffcf3034a24a19bc87e6ebed3eab079f45 | 20:37 |
*** kzaitsev_mb has quit IRC | 20:37 | |
ediardo | git show 03ede4ce | 20:38 |
hurgleburgler | this is just on this one modal with this one dropdown size | 20:38 |
hurgleburgler | if you add an additional 200 elements to the dropdown | 20:38 |
hurgleburgler | what happens? | 20:38 |
ducttape_ | hold my beer / gimme a second | 20:38 |
ediardo | show a scrollbar inside the dropdown? | 20:38 |
hurgleburgler | you can test this by manually just copying the same dropdown line over and over again directly into the HTML | 20:39 |
hurgleburgler | if you have developer tools plugged in | 20:39 |
hurgleburgler | plugged in == turned on | 20:39 |
*** lblanchard1 has quit IRC | 20:39 | |
ducttape_ | http://pasteboard.co/7suj5isUD.png this is what we want, yes hurgleburgler? | 20:41 |
hurgleburgler | looks like that is working | 20:42 |
ducttape_ | http://pasteboard.co/7svj74qyZ.png this is what we have | 20:42 |
hurgleburgler | does it work in the other browser? | 20:42 |
*** adriant has joined #openstack-horizon | 20:42 | |
ducttape_ | you are looking at what we want the change to be, I tricked you ;) | 20:42 |
hurgleburgler | yeah | 20:42 |
hurgleburgler | the thing with it is ... | 20:42 |
hurgleburgler | the first solution is good for desktop | 20:42 |
hurgleburgler | but NOT for mobile | 20:42 |
hurgleburgler | and the second solution works for both | 20:43 |
hurgleburgler | but is obnoxious on desktop | 20:43 |
robcresswell | Why's it bad for mobile? | 20:43 |
hurgleburgler | I think the modal goes to full screen on smaller sizes | 20:43 |
ducttape_ | I'd trade the bug on mobile for this thing on the desktop | 20:43 |
hurgleburgler | ducttape_ can you scrunch the window down to trigger the smallest size? | 20:43 |
robcresswell | As long as the page gets longer we can just scroll | 20:43 |
robcresswell | Kinda annoying if it breaks on half a laptop screen though | 20:44 |
ducttape_ | this is the mobile version - http://pasteboard.co/7sxTqt2C8.png | 20:44 |
ducttape_ | still seems janky to me | 20:45 |
ducttape_ | it seems like we are settling for two bad things | 20:45 |
hurgleburgler | what about that same page iwith your fix above? | 20:45 |
*** tobberydberg has joined #openstack-horizon | 20:45 | |
*** aortega has quit IRC | 20:46 | |
ducttape_ | http://pasteboard.co/7sA35i46z.png is with y overflow initial | 20:46 |
ducttape_ | which seems less terrible | 20:47 |
ducttape_ | I could redo ediardo's fix too, if that is also needed | 20:47 |
hurgleburgler | wait, but add stuff to that last one? | 20:48 |
hurgleburgler | like a bunch more options | 20:49 |
ducttape_ | k | 20:49 |
*** dave-mccowan has joined #openstack-horizon | 20:49 | |
*** tobberydberg has quit IRC | 20:50 | |
ducttape_ | http://pasteboard.co/7sDVelD6L.png hurgleburgler | 20:50 |
ducttape_ | so I can scroll the entire view down, and see the other options down below | 20:50 |
*** rcernin has quit IRC | 20:51 | |
*** rcernin has joined #openstack-horizon | 20:51 | |
hurgleburgler | But you would have to scroll back up to the buttons, or there would be a considerable JUMP back up to the smaller size of hte window when it rerenders | 20:51 |
hurgleburgler | I would STILL say the later is way more standard of a mobile view ... so if you want the former for a desktop, we could appease both audiences by wrapping your fix in a media query | 20:52 |
hurgleburgler | but, whatever the masses decide is fine | 20:53 |
ducttape_ | if there is a valid reason to do something a certain way, I just don't understand the concern / objection yet | 20:54 |
openstackgerrit | Merged openstack/horizon: Fixes traceback if group name attribute is missing https://review.openstack.org/358048 | 20:55 |
ducttape_ | hurgleburgler: - when I select a given item, then the scroll bars disappear. why would I have to scroll ? | 20:56 |
hurgleburgler | that's the rerender | 20:56 |
hurgleburgler | if you selected an option near the very bottom | 20:56 |
ducttape_ | I did | 20:57 |
ducttape_ | like i get it to be like this - http://pasteboard.co/7sLRG8tMZ.png I select the bottom item, then bamo - its back to the initial pretty view with no scroll bars | 20:58 |
ediardo | ducttape_, open the launch isntance wizard and resize your window, this is what happens with my patch http://pasteboard.co/7sLyLzAvY.png | 20:58 |
*** itisha has quit IRC | 20:59 | |
ducttape_ | ah thats terrible | 20:59 |
ediardo | yep | 20:59 |
ducttape_ | what about other y overflow options ? | 20:59 |
ducttape_ | like initial ? | 20:59 |
*** bpokorny has joined #openstack-horizon | 20:59 | |
ediardo | if you remove the max-height then it looks good again | 21:00 |
*** wolverineav has joined #openstack-horizon | 21:00 | |
*** _ducttape_ has joined #openstack-horizon | 21:00 | |
ediardo | this in .modal-body | 21:00 |
_ducttape_ | sorry I bounced wifi. did you try that other option ediardo ? | 21:01 |
*** matt-borland has quit IRC | 21:02 | |
ediardo | will try | 21:02 |
*** ctayal has quit IRC | 21:02 | |
*** ducttape_ has quit IRC | 21:03 | |
*** bpokorny has quit IRC | 21:04 | |
*** wolverineav has quit IRC | 21:05 | |
*** ctayal has joined #openstack-horizon | 21:06 | |
robcresswell | You guys best not be hacking the hell out of our beautiful CSS | 21:07 |
hurgleburgler | LOL | 21:07 |
* _ducttape_ spit coffee all over his monitor | 21:08 | |
*** rcernin has quit IRC | 21:09 | |
*** Ephur has quit IRC | 21:09 | |
robcresswell | Hahaha | 21:09 |
*** chlong has quit IRC | 21:10 | |
r1chardj0n3s | speaking of css changes, if someone with css clues could check https://review.openstack.org/#/c/406879/ I'd appreciate it | 21:10 |
*** rcernin has joined #openstack-horizon | 21:11 | |
robcresswell | r1chardj0n3s: That bug is a duplicate, as is the patch | 21:13 |
robcresswell | r1chardj0n3s: https://bugs.launchpad.net/horizon/+bug/1625310 | 21:15 |
openstack | Launchpad bug 1625310 in OpenStack Dashboard (Horizon) "UI issues on instance details overview tab" [Low,In progress] - Assigned to Ying Zuo (yingzuo) | 21:15 |
robcresswell | Is the original | 21:15 |
ediardo | _ducttape_: the bug we were talking about also affects tooltips | 21:16 |
ediardo | https://bugs.launchpad.net/horizon/+bug/1626310 | 21:16 |
openstack | Launchpad bug 1603496 in OpenStack Dashboard (Horizon) "duplicate for #1626310 UX: Dropdown with several items does not fit in modal" [Low,In progress] - Assigned to Ernest Millan (millan) | 21:16 |
_ducttape_ | ugg. thanks ediardo | 21:17 |
robcresswell | Ohhh wait it's not a dup | 21:17 |
robcresswell | Similar though | 21:17 |
ediardo | I know, too annoying... I'm at an openstack training right now and the instructor is using horizon... I've seen this dropdowns forcing him to scroll down | 21:18 |
_ducttape_ | yes, it's similar enough that one fix should get em both | 21:18 |
ediardo | lol | 21:18 |
_ducttape_ | I placed a comment on that second bug, not sure if you can link launchpad bugs or what (without duping them) | 21:19 |
openstackgerrit | Cindy Lu proposed openstack/horizon: Add Angular keystone user creation action https://review.openstack.org/341945 | 21:19 |
robcresswell | r1chardj0n3s: commented on it | 21:21 |
r1chardj0n3s | thanks tonyb | 21:22 |
r1chardj0n3s | er | 21:22 |
r1chardj0n3s | robcresswell: | 21:22 |
r1chardj0n3s | wow, so much tonyb | 21:22 |
openstackgerrit | Merged openstack/horizon: DataTable column level policy https://review.openstack.org/164010 | 21:23 |
robcresswell | tqtran: Haha, have you just approved every patch I reviewed today? | 21:26 |
robcresswell | Alllll the merges :D | 21:26 |
*** jprovazn has quit IRC | 21:28 | |
*** wolverineav has joined #openstack-horizon | 21:29 | |
*** mvk has joined #openstack-horizon | 21:33 | |
*** wolverineav has quit IRC | 21:34 | |
*** Jeffrey4l has quit IRC | 21:35 | |
*** _ducttape_ has quit IRC | 21:35 | |
*** ducttape_ has joined #openstack-horizon | 21:36 | |
*** Jeffrey4l has joined #openstack-horizon | 21:36 | |
*** aortega has joined #openstack-horizon | 21:36 | |
*** wolverineav has joined #openstack-horizon | 21:40 | |
*** revon has joined #openstack-horizon | 21:43 | |
*** bpokorny has joined #openstack-horizon | 21:44 | |
*** wolverineav has quit IRC | 21:44 | |
*** tobberydberg has joined #openstack-horizon | 21:46 | |
openstackgerrit | Merged openstack/horizon: Missing info on MELLON_IDP for mod_auth_mellon https://review.openstack.org/404971 | 21:47 |
*** ruoyu has quit IRC | 21:53 | |
*** dsneddon_lunch is now known as dsneddon | 21:57 | |
*** tobberydberg has quit IRC | 21:58 | |
*** wolverineav has joined #openstack-horizon | 21:59 | |
r1chardj0n3s | clu_: horizon.framework.util.i18n.gettext | 22:03 |
r1chardj0n3s | but that service is quite limited, it doesn't provide the other gettext functions (not sure why) | 22:04 |
*** wolverineav has quit IRC | 22:04 | |
clu_ | thx r1chardj0n3s | 22:05 |
tqtran | robcresswell: haha yeah, its call lazy reviewing. | 22:05 |
clu_ | seeing more places where it should be used too, will patch | 22:06 |
*** jtriley has quit IRC | 22:06 | |
*** ducttape_ has quit IRC | 22:09 | |
*** wolverineav has joined #openstack-horizon | 22:09 | |
*** ruoyu has joined #openstack-horizon | 22:09 | |
tqtran | r1chardj0n3s: probably because we havent had a reason to yet. most of our translations occur in html files, not js. | 22:12 |
tqtran | and in the html files, they are using the translate tag, which is tagged for extraction by babel-angular | 22:13 |
r1chardj0n3s | tqtran: yep | 22:13 |
tqtran | so no need to inject gettext service | 22:13 |
*** ducttape_ has joined #openstack-horizon | 22:13 | |
tqtran | basically, bulk of translations happen in html, so the service was able to remain simple | 22:13 |
*** wolverineav has quit IRC | 22:14 | |
tqtran | i actually like that pattern more, instead of stuffing translations in js, leave it in the html | 22:14 |
*** ruoyu has quit IRC | 22:14 | |
r1chardj0n3s | yeah, but sometimes we do need to invoke gettext in js, I'm not sure whether we have any pre-service angularjs code currently using eg. ngettext | 22:15 |
r1chardj0n3s | it's not really that big a deal - we have higher priority things to get moving ;-) | 22:15 |
tqtran | if there is a need for it, then we can add it then, its relatively simple to add a wrapper for it | 22:16 |
r1chardj0n3s | a quick search shows up a ton of ngettext use, for example openstack_dashboard/static/app/core/images/actions/delete-image.service.js | 22:17 |
r1chardj0n3s | actually "a ton" isn't right, my grep was mis-configured ;-) | 22:18 |
r1chardj0n3s | anyway, there's definitely some :-) | 22:18 |
r1chardj0n3s | but, low priority | 22:18 |
*** ruoyu has joined #openstack-horizon | 22:19 | |
*** ducttape_ has quit IRC | 22:21 | |
*** ruoyu has quit IRC | 22:23 | |
*** ruoyu has joined #openstack-horizon | 22:24 | |
*** tobberydberg has joined #openstack-horizon | 22:25 | |
*** kzaitsev_mb has joined #openstack-horizon | 22:29 | |
*** Pavo has quit IRC | 22:29 | |
*** jamielennox is now known as jamielennox|away | 22:29 | |
*** Pavo has joined #openstack-horizon | 22:34 | |
*** jamielennox|away is now known as jamielennox | 22:34 | |
*** tobberydberg has quit IRC | 22:36 | |
*** wolverineav has joined #openstack-horizon | 22:38 | |
*** sacharya has quit IRC | 22:42 | |
*** wolverineav has quit IRC | 22:43 | |
*** ruoyu has quit IRC | 23:01 | |
*** tobberydberg has joined #openstack-horizon | 23:03 | |
*** david-lyle_ has joined #openstack-horizon | 23:05 | |
*** david-lyle has quit IRC | 23:07 | |
openstackgerrit | Merged openstack/horizon: Let Nova to pick availability zone if more than 1 https://review.openstack.org/362230 | 23:08 |
*** wolverineav has joined #openstack-horizon | 23:08 | |
*** bpokorny has quit IRC | 23:10 | |
*** bpokorny has joined #openstack-horizon | 23:11 | |
*** ruoyu has joined #openstack-horizon | 23:11 | |
*** rcernin has quit IRC | 23:11 | |
*** wolverineav has quit IRC | 23:12 | |
*** tobberydberg has quit IRC | 23:13 | |
*** bpokorny_ has joined #openstack-horizon | 23:13 | |
*** bpokorny has quit IRC | 23:15 | |
*** ruoyu has quit IRC | 23:15 | |
*** bpokorny_ has quit IRC | 23:16 | |
*** bpokorny has joined #openstack-horizon | 23:16 | |
*** bpokorny has quit IRC | 23:19 | |
*** bpokorny has joined #openstack-horizon | 23:19 | |
*** absubram has quit IRC | 23:20 | |
*** wolverineav has joined #openstack-horizon | 23:28 | |
*** ruoyu has joined #openstack-horizon | 23:29 | |
*** WillUK2010 has joined #openstack-horizon | 23:32 | |
WillUK2010 | evening, The current Horizon settings indicate no valid image creation methods are available. anyone know how to solve this ? so i can upload images using horizon ? | 23:32 |
*** wolverineav has quit IRC | 23:32 | |
*** rcernin has joined #openstack-horizon | 23:33 | |
*** kzaitsev_mb has quit IRC | 23:34 | |
david-lyle_ | WillUK2010: see http://docs.openstack.org/releasenotes/horizon/newton.html#new-features and search for HORIZON_IMAGES_UPLOAD_MODE | 23:35 |
*** david-lyle_ is now known as david-lyle | 23:35 | |
*** ChanServ sets mode: +o david-lyle | 23:35 | |
WillUK2010 | cheers david-lyle | 23:35 |
r1chardj0n3s | that link should be the channel title :/ | 23:38 |
r1chardj0n3s | so many people getting tripped up on oit | 23:38 |
david-lyle | disabled by default probably wasn't the best choice to ship with :) | 23:38 |
*** wolverineav has joined #openstack-horizon | 23:38 | |
r1chardj0n3s | mmm | 23:38 |
*** erlon-airlong has quit IRC | 23:40 | |
*** tobberydberg has joined #openstack-horizon | 23:40 | |
*** sacharya has joined #openstack-horizon | 23:42 | |
*** wolverineav has quit IRC | 23:43 | |
*** sacharya has quit IRC | 23:47 | |
*** rcernin has quit IRC | 23:49 | |
*** ruoyu has quit IRC | 23:49 | |
*** jamielennox is now known as jamielennox|away | 23:49 | |
*** tobberydberg has quit IRC | 23:53 | |
*** ruoyu has joined #openstack-horizon | 23:53 | |
*** dsneddon is now known as dsneddon_ | 23:53 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: hzResourceProperty can handle 'priority' attribute https://review.openstack.org/397132 | 23:54 |
*** ruoyu_ has joined #openstack-horizon | 23:56 | |
*** wolverineav has joined #openstack-horizon | 23:57 | |
*** ruoyu_ has quit IRC | 23:57 | |
*** ruoyu__ has joined #openstack-horizon | 23:57 | |
*** ruoyu has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!