| *** lhcheng has quit IRC | 00:03 | |
| *** btully has quit IRC | 00:13 | |
| *** btully has joined #openstack-horizon | 00:14 | |
| *** wolverineav has joined #openstack-horizon | 00:19 | |
| *** tqtran has quit IRC | 00:21 | |
| *** jtriley has quit IRC | 00:21 | |
| *** wolverineav has quit IRC | 00:23 | |
| *** Mounica has quit IRC | 00:47 | |
| *** vinaypotluri has quit IRC | 00:50 | |
| *** yingjun has joined #openstack-horizon | 00:51 | |
| *** clu_ has quit IRC | 00:57 | |
| *** amotoki has quit IRC | 01:08 | |
| *** zhurong has joined #openstack-horizon | 01:10 | |
| *** wolverineav has joined #openstack-horizon | 01:10 | |
| *** zackf has joined #openstack-horizon | 01:11 | |
| *** zackf has quit IRC | 01:11 | |
| *** zackf has joined #openstack-horizon | 01:12 | |
| *** bpokorny_ has joined #openstack-horizon | 01:13 | |
| *** bpokorny has quit IRC | 01:16 | |
| *** zackf has quit IRC | 01:17 | |
| *** bpokorny_ has quit IRC | 01:18 | |
| *** ngupta has joined #openstack-horizon | 01:20 | |
| *** ducttape_ has joined #openstack-horizon | 01:21 | |
| *** ngupta has quit IRC | 01:35 | |
| *** Daisy has joined #openstack-horizon | 01:37 | |
| *** sdake has joined #openstack-horizon | 01:39 | |
| *** ducttape_ has quit IRC | 01:42 | |
| *** zackf has joined #openstack-horizon | 01:44 | |
| *** amotoki has joined #openstack-horizon | 01:48 | |
| *** zackf has quit IRC | 01:49 | |
| *** sdake_ has joined #openstack-horizon | 01:52 | |
| *** sdake has quit IRC | 01:53 | |
| *** amotoki has quit IRC | 01:56 | |
| *** amotoki has joined #openstack-horizon | 01:59 | |
| *** julim has joined #openstack-horizon | 02:04 | |
| *** sdake_ has quit IRC | 02:09 | |
| *** amotoki has quit IRC | 02:09 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-ui: Add scaffolding for releasenotes https://review.openstack.org/320716 | 02:10 |
|---|---|---|
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-ui: Add support for releasenotes https://review.openstack.org/320716 | 02:15 |
| *** shu-mutou-AFK is now known as shu-mutou | 02:16 | |
| *** zackf has joined #openstack-horizon | 02:17 | |
| *** amotoki has joined #openstack-horizon | 02:18 | |
| *** kzaitsev_mb has quit IRC | 02:18 | |
| *** zackf has quit IRC | 02:25 | |
| *** gyee has quit IRC | 02:39 | |
| *** bpokorny has joined #openstack-horizon | 02:43 | |
| *** vishwanathj has joined #openstack-horizon | 02:52 | |
| *** vishwanathj has quit IRC | 02:58 | |
| *** TravT has joined #openstack-horizon | 02:59 | |
| *** ChanServ sets mode: +v TravT | 02:59 | |
| *** absubram has joined #openstack-horizon | 03:06 | |
| *** absubram_ has joined #openstack-horizon | 03:10 | |
| *** absubram has quit IRC | 03:11 | |
| *** absubram_ is now known as absubram | 03:11 | |
| *** Mounica has joined #openstack-horizon | 03:12 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:14 | |
| *** sdake has joined #openstack-horizon | 03:15 | |
| *** Daisy_ has joined #openstack-horizon | 03:17 | |
| *** Daisy has quit IRC | 03:20 | |
| *** Daisy_ has quit IRC | 03:20 | |
| *** Daisy has joined #openstack-horizon | 03:21 | |
| *** Daisy_ has joined #openstack-horizon | 03:24 | |
| *** Daisy has quit IRC | 03:25 | |
| *** lhcheng has joined #openstack-horizon | 03:27 | |
| *** ChanServ sets mode: +v lhcheng | 03:27 | |
| *** sdake has quit IRC | 03:27 | |
| *** yamamoto_ has quit IRC | 03:43 | |
| *** Daisy_ has quit IRC | 03:43 | |
| *** Daisy has joined #openstack-horizon | 03:44 | |
| *** sdake has joined #openstack-horizon | 03:44 | |
| *** Daisy_ has joined #openstack-horizon | 03:45 | |
| *** Daisy_ has quit IRC | 03:45 | |
| *** Daisy_ has joined #openstack-horizon | 03:45 | |
| *** Daisy has quit IRC | 03:48 | |
| *** Mounica has quit IRC | 03:49 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Migrate swift ui to use hz-dynamic-table https://review.openstack.org/313243 | 03:53 |
| *** Mounica has joined #openstack-horizon | 03:55 | |
| *** kzaitsev_mb has quit IRC | 04:02 | |
| *** masco has joined #openstack-horizon | 04:03 | |
| *** Daisy_ has quit IRC | 04:07 | |
| *** Daisy has joined #openstack-horizon | 04:08 | |
| *** bpokorny has quit IRC | 04:08 | |
| *** Daisy has quit IRC | 04:12 | |
| *** sguduru has joined #openstack-horizon | 04:17 | |
| *** Mounica has quit IRC | 04:18 | |
| *** Daisy has joined #openstack-horizon | 04:20 | |
| *** Daisy has quit IRC | 04:21 | |
| *** Daisy has joined #openstack-horizon | 04:21 | |
| *** sguduru has quit IRC | 04:28 | |
| *** Daisy has quit IRC | 04:31 | |
| *** Daisy has joined #openstack-horizon | 04:32 | |
| *** zackf has joined #openstack-horizon | 04:32 | |
| *** zackf has quit IRC | 04:33 | |
| *** Mounica has joined #openstack-horizon | 04:34 | |
| *** Daisy has quit IRC | 04:37 | |
| *** javeriak has joined #openstack-horizon | 04:37 | |
| *** Mounica has quit IRC | 04:39 | |
| *** Mounica has joined #openstack-horizon | 04:44 | |
| *** zackf has joined #openstack-horizon | 04:44 | |
| *** Daisy has joined #openstack-horizon | 04:47 | |
| *** Mounica has quit IRC | 04:49 | |
| *** zackf has quit IRC | 04:49 | |
| *** lhcheng_ has joined #openstack-horizon | 04:50 | |
| *** jamielennox is now known as jamielennox|away | 04:50 | |
| *** lhcheng has quit IRC | 04:52 | |
| *** yamamoto has joined #openstack-horizon | 04:56 | |
| *** jamielennox|away is now known as jamielennox | 05:04 | |
| *** javeriak has quit IRC | 05:05 | |
| *** Mounica has joined #openstack-horizon | 05:05 | |
| *** sdake_ has joined #openstack-horizon | 05:11 | |
| *** sdake has quit IRC | 05:13 | |
| *** Mounica has quit IRC | 05:15 | |
| *** sguduru has joined #openstack-horizon | 05:18 | |
| *** kzaitsev_mb has joined #openstack-horizon | 05:20 | |
| *** kzaitsev_mb has quit IRC | 05:25 | |
| *** jamielennox is now known as jamielennox|away | 05:54 | |
| *** ig0r_ has joined #openstack-horizon | 06:01 | |
| *** sguduru has quit IRC | 06:04 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 06:05 |
| *** lhcheng has joined #openstack-horizon | 06:06 | |
| *** ChanServ sets mode: +v lhcheng | 06:06 | |
| *** mpavlase has joined #openstack-horizon | 06:08 | |
| *** lhcheng_ has quit IRC | 06:09 | |
| *** jamielennox|away is now known as jamielennox | 06:10 | |
| *** aortega has quit IRC | 06:11 | |
| *** sguduru has joined #openstack-horizon | 06:16 | |
| *** ig0r_ has quit IRC | 06:17 | |
| *** jamielennox is now known as jamielennox|away | 06:21 | |
| *** kzaitsev_mb has joined #openstack-horizon | 06:21 | |
| *** rcernin has joined #openstack-horizon | 06:21 | |
| *** kzaitsev_mb has quit IRC | 06:27 | |
| *** jamielennox|away is now known as jamielennox | 06:28 | |
| *** belmoreira has joined #openstack-horizon | 06:36 | |
| *** vinaypotluri has joined #openstack-horizon | 06:39 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Update the links of django docs to dev version https://review.openstack.org/320800 | 06:47 |
| *** tesseract has joined #openstack-horizon | 06:47 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/318462 | 06:48 |
| *** jprovazn has joined #openstack-horizon | 06:57 | |
| *** sguduru has quit IRC | 07:07 | |
| *** wangbo has quit IRC | 07:11 | |
| *** mpavlase has quit IRC | 07:14 | |
| *** schipiga has joined #openstack-horizon | 07:20 | |
| *** jtomasek has joined #openstack-horizon | 07:20 | |
| tsufiev | hm, so it seems that some patch broke integration tests completely | 07:21 |
| tsufiev | they are unable to switch current project now | 07:22 |
| *** wangbo has joined #openstack-horizon | 07:33 | |
| robcresswell | tsufiev: Guess I should stop rechecking then :) | 07:35 |
| tsufiev | robcresswell, that's for sure :) | 07:35 |
| tsufiev | installing devstack on my laptop at home to see what happens now with horizon | 07:36 |
| * tsufiev is wondering if people will watch integration job failures videos or just continue rechecking the job? | 07:37 | |
| *** aortega has joined #openstack-horizon | 07:39 | |
| r1chardj0n3s | videos? | 07:43 |
| r1chardj0n3s | I check the logs, usually, to see if the same test is failing | 07:43 |
| *** hoonetorg has quit IRC | 07:43 | |
| robcresswell | I'll check the logs once I start seeing consistent integration failures, but right now its buried amongst npm, py27, grenade failures, so it seems wildly inconsistent. | 07:44 |
| *** mpavlase has joined #openstack-horizon | 07:45 | |
| robcresswell | But integration logs are not nice to parse :p | 07:45 |
| *** chlong has quit IRC | 07:46 | |
| tsufiev | r1chardj0n3s, https://review.openstack.org/#/c/320004/ | 07:46 |
| *** lhcheng has quit IRC | 07:48 | |
| tsufiev | robcresswell, that's unfortunate that so many jobs are failing intermittently :( | 07:49 |
| robcresswell | Indeed. The blocker in Horizon is the gate, not reviews right now. | 07:50 |
| r1chardj0n3s | tsufiev: neat! | 07:52 |
| *** sdake_ has quit IRC | 07:56 | |
| *** hoonetorg has joined #openstack-horizon | 07:56 | |
| *** mpavlase has quit IRC | 08:05 | |
| *** mpavlase has joined #openstack-horizon | 08:07 | |
| *** revon has quit IRC | 08:09 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 08:10 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 08:10 |
| r1chardj0n3s | robcresswell, tsufiev I have to apologise for the lower rate of reviews lately, I've been very distracted with PyCon AU in the last couple of weeks | 08:10 |
| *** ygbo has joined #openstack-horizon | 08:11 | |
| openstackgerrit | Sanjana proposed openstack/horizon: Using generic class NameFilterAction https://review.openstack.org/271185 | 08:12 |
| *** ig0r_ has joined #openstack-horizon | 08:20 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:23 | |
| robcresswell | r1chardj0n3s: I think you're still doing more reviews than most other people in Horizon, hah | 08:24 |
| r1chardj0n3s | but not the big ones :-( | 08:24 |
| tsufiev | r1chardj0n3s, stackalytics doesn't agree that you're doing less job, see http://stackalytics.com/report/contribution/horizon-group/30 :) | 08:25 |
| robcresswell | We're about on track for our N-1 targets I believe. Most of the bps are getting fairly mature now, I've been keeping my eye on them. | 08:25 |
| robcresswell | wow I've not seen that before | 08:25 |
| *** tosky has joined #openstack-horizon | 08:26 | |
| tsufiev | robcresswell, there are 2 links at the bottom of http://stackalytics.com/?module=horizon-group section Contribution Summary | 08:26 |
| r1chardj0n3s | ah well, it's dinner time now, catch y'all tomorrow morning I hope :-) | 08:26 |
| tsufiev | r1chardj0n3s, bon appetite :) | 08:27 |
| robcresswell | Have a good evening r1chardj0n3s | 08:27 |
| robcresswell | tsufiev: Ah so there is! Thanks for pointing that out. Quite neat. | 08:27 |
| tsufiev | should be a good PTL tool, robcresswell ;) | 08:27 |
| *** kzaitsev_mb has quit IRC | 08:28 | |
| *** dmk0202 has joined #openstack-horizon | 08:28 | |
| robcresswell | tsufiev: Data is data I suppose, but its just one tool :) | 08:29 |
| *** Daisy has quit IRC | 08:30 | |
| *** Daisy has joined #openstack-horizon | 08:30 | |
| *** _stowa has quit IRC | 08:32 | |
| *** yamamoto_ has joined #openstack-horizon | 08:35 | |
| *** brad[] has quit IRC | 08:36 | |
| tsufiev | robcresswell, I've updated https://blueprints.launchpad.net/horizon/+spec/horizon-glance-large-image-upload to describe both [Django] and [NG] versions | 08:36 |
| *** brad[] has joined #openstack-horizon | 08:37 | |
| *** yamamoto has quit IRC | 08:38 | |
| *** btully has quit IRC | 08:40 | |
| *** sguduru has joined #openstack-horizon | 08:43 | |
| robcresswell | thanks tsufiev | 08:43 |
| *** sdake has joined #openstack-horizon | 08:43 | |
| tsufiev | robcresswell, here is what I see on freshly installed devstack http://imgur.com/g8p6drr | 08:43 |
| tsufiev | seems that Horizon integration tests were broken by some recent Keystone change | 08:44 |
| tsufiev | although the fact that vertical scrollbar is shown for an empty list surprised me a bit | 08:44 |
| * tsufiev is heading to the office, will continue looking there | 08:45 | |
| robcresswell | Hmm, not sure what was released in the past day or two | 08:46 |
| tsufiev | so I cannot switch projects even manually | 08:46 |
| tsufiev | its definitely some bug, possibly the wrong config value | 08:46 |
| robcresswell | yep, investigating :) | 08:49 |
| *** sdake has quit IRC | 08:49 | |
| robcresswell | Seems like the tests are fine but there's a bug in Horizon itself | 08:50 |
| *** vinaypotluri has quit IRC | 08:50 | |
| *** sdake has joined #openstack-horizon | 08:51 | |
| *** amotoki has quit IRC | 09:00 | |
| *** Daisy_ has joined #openstack-horizon | 09:00 | |
| *** Daisy has quit IRC | 09:03 | |
| *** sdake has quit IRC | 09:05 | |
| *** javeriak has joined #openstack-horizon | 09:06 | |
| *** Daisy_ has quit IRC | 09:14 | |
| *** mvk has quit IRC | 09:22 | |
| *** javeriak has quit IRC | 09:22 | |
| ygbo | mrunge: Just for info : In termes of end-user "usability" feedback, reverting https://review.openstack.org/#/c/263040/ is worse than having it in, and the revert should have been included in https://review.openstack.org/#/c/249662/ instead because the stable/mitaka branch is just totaly unusable for icmp rules. So much that for production we have to revert the revert if we do not want to be bashed by our users (no kidding)... do you have any informati | 09:23 |
| ygbo | on about https://review.openstack.org/#/c/249662/ ? Because there's been no dev activity since Nov 30 11:07 AM what happens if the developer does not respond? yalie made the proposal to continue the job. | 09:23 |
| *** mpavlase has quit IRC | 09:23 | |
| mrunge | ygbo, you're free to continue on the job there | 09:23 |
| mrunge | ygbo, honestly, please go ahead there | 09:24 |
| ygbo | mrunge: well I'll let yalie first since he made the proposal | 09:24 |
| ygbo | mrunge: do you know when he generaly connects here on IRC? | 09:24 |
| ygbo | If he does not take over, than if you agree I will. | 09:25 |
| mrunge | ygbo, nope. I somehow followed horizon from a huge distance now for a longer time | 09:25 |
| ygbo | mrunge: Ok :-) | 09:25 |
| mrunge | ygbo, I might be the wrong person to speak to now | 09:25 |
| robcresswell | Does that patch fix the issue properly, rather than reverting the revert? | 09:26 |
| robcresswell | ygbo: Take over the patch, don't wait for response. They have had ample time. | 09:27 |
| mrunge | robcresswell, it does not | 09:27 |
| *** mpavlase has joined #openstack-horizon | 09:27 | |
| mrunge | so currently, we're in the situation as before the patch, right? | 09:28 |
| robcresswell | Wait so, what is the issue again? Which bug is being fixed? | 09:29 |
| ygbo | well curently we're in the situation where ICMP rules are not feasable via horizon. | 09:29 |
| mrunge | ... as before in several releases, right? | 09:29 |
| robcresswell | Are we looking at multiple bugs or a single bug? | 09:29 |
| robcresswell | I see https://bugs.launchpad.net/horizon/+bug/1511748 was mentioned, I recall this from last week | 09:30 |
| openstack | Launchpad bug 1511748 in OpenStack Dashboard (Horizon) "Adding new security group rule Custom ICMP rule has wrong error messages" [Undecided,In progress] - Assigned to Suraj Deshmukh (surajssd009005) | 09:30 |
| ygbo | mrunge: To my knowledge it was working before | 09:30 |
| *** itisha has joined #openstack-horizon | 09:30 | |
| *** javeriak has joined #openstack-horizon | 09:31 | |
| mrunge | robcresswell, ygbo this is about this one here: https://review.openstack.org/#/c/249662/ | 09:31 |
| ygbo | what I mean by working is that we could add ICMP ping rules at ease (and this is to be honest a very common end-user task) | 09:31 |
| *** btully has joined #openstack-horizon | 09:32 | |
| mrunge | well... | 09:32 |
| robcresswell | I'm happy to approve a fix and backport it. We've had ~20 backports already for Mitaka, so thats been going quite well. | 09:32 |
| robcresswell | But I'm unclear where this fix supposedly is | 09:33 |
| robcresswell | It seems like a revert is not necessarily the way forward, due to another issue? | 09:33 |
| ygbo | since stable/mitaka we can't add any ping rules which makes some end-users not happy about it. what I meant is that the new patch should have had included the revert of the displeasing commit, instead of adding a temporary regression (which got released in mitaka) | 09:35 |
| mrunge | leaving all reverts out here, as code was reverted | 09:35 |
| mrunge | imho it boils down to get https://review.openstack.org/#/c/249662/ in, right ygbo ? | 09:35 |
| ygbo | mrunge: exactly :-) | 09:35 |
| mrunge | that patch has issues. if you want it in, please fix those issues | 09:35 |
| mrunge | afterwards, we can talk about getting this backported to mitaka | 09:36 |
| robcresswell | So that patch *does* fix the issues you're having? | 09:36 |
| robcresswell | Or, *should* | 09:36 |
| robcresswell | ? | 09:36 |
| *** btully has quit IRC | 09:36 | |
| ygbo | mrunge: sure, but I wanted approval before taking over someone elses patch :-) | 09:36 |
| robcresswell | Ah | 09:36 |
| robcresswell | Yeah, go ahead :D | 09:36 |
| ygbo | robcresswell: "should", I haven't tested it yet sinc it conflicts | 09:36 |
| mrunge | ygbo, as far as I can see, it changes strings | 09:36 |
| mrunge | which makes it not appropriate for backport | 09:37 |
| robcresswell | mrunge: I'm unclear on the rule for strings now, since we have stable/mitaka translations still. | 09:37 |
| mrunge | ok, then ygbo , hurry up | 09:37 |
| robcresswell | Either way, we may be able to fix without string alterations. | 09:37 |
| mrunge | yupp | 09:38 |
| robcresswell | ygbo: I've removed the bug assignee and prioritised it. Please assign yourself :) | 09:38 |
| robcresswell | https://bugs.launchpad.net/horizon/+bug/1511748 | 09:38 |
| openstack | Launchpad bug 1511748 in OpenStack Dashboard (Horizon) "Adding new security group rule Custom ICMP rule has wrong error messages" [High,In progress] | 09:38 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-ui: Add support for releasenotes https://review.openstack.org/320716 | 09:38 |
| ygbo | robcresswell: done :-) | 09:39 |
| robcresswell | ygbo: Great! Ping when you get a fix and we'll look to review and backport. | 09:40 |
| ygbo | robcresswell: ok, thanks | 09:41 |
| *** zhurong has quit IRC | 09:41 | |
| *** zhurong has joined #openstack-horizon | 09:42 | |
| *** amotoki has joined #openstack-horizon | 09:47 | |
| tsufiev | robcresswell, is missing projects issue a horizon bug or keystone bug? | 09:52 |
| robcresswell | tsufiev: It worked for me, new stack with RECLONE=yes | 09:53 |
| robcresswell | not a fresh env though | 09:53 |
| tsufiev | hm... | 09:53 |
| tsufiev | pkarikh, ^^^ | 09:54 |
| *** mvk has joined #openstack-horizon | 09:55 | |
| ygbo | robcresswell, mrunge: I propose validating the form for codes which validate depending on a type: https://en.wikipedia.org/wiki/Internet_Control_Message_Protocol (this means that I allow e.g. code 15 only for type 3, etc... ) or should I allow a wider range? | 10:00 |
| ygbo | Before I start coding the validator :-) | 10:01 |
| *** kzaitsev_mb has joined #openstack-horizon | 10:02 | |
| *** yingjun has quit IRC | 10:05 | |
| *** zhurong has quit IRC | 10:05 | |
| *** al_indigo has quit IRC | 10:06 | |
| robcresswell | ygbo: You mean, only allowing 15 for type 3? That would miss a lot of possibilities. Or did you mean using range? | 10:06 |
| *** kzaitsev_mb has quit IRC | 10:07 | |
| mrunge | ygbo, there should be a validator in neutron | 10:17 |
| mrunge | otherwise you might create something, which still will fail in neutron | 10:17 |
| mrunge | ... just to have a single source of truth, not two | 10:17 |
| mrunge | we had that with quota in horizon already | 10:18 |
| robcresswell | heh | 10:18 |
| pkarikh | robcresswell, tsufiev do we already have a filed bug about missing projects in dropdown? | 10:19 |
| mrunge | pkarikh, I guess: yes | 10:20 |
| mrunge | pkarikh, at least such thing is known (to me) | 10:20 |
| robcresswell | I wasnt able to recreate it | 10:21 |
| mrunge | uhm, use pki tokens | 10:21 |
| robcresswell | Ah | 10:21 |
| mrunge | or use hierarchical projects | 10:21 |
| mrunge | swich to keystone v3 | 10:22 |
| mrunge | misconfigure your session store | 10:22 |
| mrunge | ... | 10:22 |
| mrunge | it all boils down to doa | 10:22 |
| mrunge | https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/utils.py#L313 | 10:23 |
| mrunge | ^^ pkarikh | 10:23 |
| *** wolverineav has quit IRC | 10:26 | |
| pkarikh | mrunge, thanks. Reinstalling devstack now. What throws Horizon into logs? Some 401 errors? | 10:26 |
| mrunge | pkarikh, I forgot | 10:26 |
| mrunge | I believe, you'll get unauthorized errors | 10:27 |
| *** yamamoto_ has quit IRC | 10:28 | |
| *** lcastell has quit IRC | 10:34 | |
| *** javeriak has quit IRC | 10:43 | |
| *** shu-mutou is now known as shu-mutou-AFK | 10:53 | |
| *** javeriak has joined #openstack-horizon | 10:54 | |
| *** lcastell has joined #openstack-horizon | 11:00 | |
| *** kzaitsev_mb has joined #openstack-horizon | 11:04 | |
| *** yamamoto has joined #openstack-horizon | 11:11 | |
| *** yamamoto has quit IRC | 11:14 | |
| *** amotoki has quit IRC | 11:17 | |
| *** openstackgerrit has quit IRC | 11:18 | |
| *** openstackgerrit has joined #openstack-horizon | 11:19 | |
| *** btully has joined #openstack-horizon | 11:20 | |
| *** btully has quit IRC | 11:24 | |
| *** belmoreira has quit IRC | 11:31 | |
| *** amotoki has joined #openstack-horizon | 11:34 | |
| *** yingjun has joined #openstack-horizon | 11:44 | |
| pkarikh | Folks, could anyone please checkout to stable/liberty and check if Horizon header is ok? Or it looks like this: http://i.imgur.com/QIzWrRY.png | 11:46 |
| robcresswell | pkarikh: can confirm | 11:54 |
| *** amotoki has quit IRC | 11:54 | |
| *** yingjun has quit IRC | 11:54 | |
| *** jamielennox is now known as jamielennox|away | 11:58 | |
| pkarikh | robcresswell, can't find out why it even was broken. Looks like there is no layout-related commits were backported there: https://github.com/openstack/horizon/commits/stable/liberty | 11:58 |
| robcresswell | pkarikh: Bootstrap was updated | 11:58 |
| robcresswell | pkarikh: probably just old code | 11:59 |
| *** itisha has quit IRC | 11:59 | |
| *** yingjun has joined #openstack-horizon | 12:01 | |
| ygbo | robcresswell: no, I mean the opposit, allowing 0 to 15 for typ 3 but 15 is only for type 3 (I don't see other types using code 15). | 12:03 |
| robcresswell | ygbo: Ah, yep makes sense. mrunge had a good comment about that though, would be good to avoid duplicating logic if possible. | 12:03 |
| pkarikh | robcresswell, oh | 12:04 |
| mrunge | is anyone using additional theme logic in local_settings.d ? | 12:04 |
| ygbo | robcresswell: Ok, so I can still validate code 15 for other types and let neutron complain if it's not valid? you agree with this? | 12:05 |
| robcresswell | ygbo: Just may be difficult to control, and result in similar issues as we have now, thats all. But yes, validation sounds sensible. | 12:06 |
| pkarikh | robcresswell, yes, you're right. Downgraded XStatic-Bootstrap-SCSS==3.2 and it works. Thank you! :) | 12:07 |
| *** jamielennox|away is now known as jamielennox | 12:07 | |
| *** yingjun_ has joined #openstack-horizon | 12:11 | |
| *** yamamoto has joined #openstack-horizon | 12:13 | |
| *** javeriak has quit IRC | 12:13 | |
| *** yingjun has quit IRC | 12:14 | |
| openstackgerrit | Merged openstack/django-openstack-auth-kerberos: remove python 2.6 trove classifier https://review.openstack.org/260775 | 12:17 |
| openstackgerrit | Merged openstack/django-openstack-auth-kerberos: Remove Py33 support https://review.openstack.org/266128 | 12:17 |
| *** sguduru has quit IRC | 12:21 | |
| *** ccesario has quit IRC | 12:33 | |
| *** suji-noi has joined #openstack-horizon | 12:34 | |
| *** Murad has joined #openstack-horizon | 12:37 | |
| Murad | hi, can we make ".deb" file for a horizon plugin? | 12:37 |
| *** suji-noi has quit IRC | 12:39 | |
| *** zhurong has joined #openstack-horizon | 12:41 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-ui: Add support for releasenotes https://review.openstack.org/320716 | 12:44 |
| *** absubram has quit IRC | 12:47 | |
| *** ccesario has joined #openstack-horizon | 12:49 | |
| *** absubram has joined #openstack-horizon | 12:50 | |
| *** matt-borland has joined #openstack-horizon | 12:54 | |
| *** mpavlase has quit IRC | 12:55 | |
| *** mpavlase has joined #openstack-horizon | 12:55 | |
| *** javeriak has joined #openstack-horizon | 12:57 | |
| *** pauloewerton has joined #openstack-horizon | 12:58 | |
| *** ducttape_ has joined #openstack-horizon | 12:58 | |
| *** javeriak has quit IRC | 12:59 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Support multiple files direct (with CORS) upload in Swift UI https://review.openstack.org/316143 | 13:01 |
| *** belmoreira has joined #openstack-horizon | 13:01 | |
| tsufiev | r1chardj0n3s, the patch ^^^ lacks some unit tests (new & updates of existing ones), but besides that should be fully functional | 13:02 |
| tsufiev | I remember that it's already an evening for you :), jfyi | 13:03 |
| *** yingjun_ has quit IRC | 13:03 | |
| *** yingjun has joined #openstack-horizon | 13:03 | |
| *** javeriak has joined #openstack-horizon | 13:05 | |
| *** ig0r__ has joined #openstack-horizon | 13:06 | |
| *** ig0r_ has quit IRC | 13:08 | |
| *** ducttape_ has quit IRC | 13:09 | |
| matt-borland | tsufiev, we should probably ensure that a well-documented release note goes out with that patch | 13:10 |
| matt-borland | unless that is covered somewhere else :) | 13:11 |
| tsufiev | matt-borland, it certainly will, that's not a final version yet | 13:12 |
| matt-borland | np, just a todo, thanks for all that work! | 13:12 |
| *** zqfan has quit IRC | 13:13 | |
| tsufiev | btw, for Swift it's even simpler than for Glance - no initial service config is required | 13:13 |
| tsufiev | you just update the container with a specific header, very convenient! | 13:13 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Support multiple files direct (with CORS) upload in Swift UI https://review.openstack.org/316143 | 13:14 |
| tsufiev | added TODO to commit message, thanks to matt-borland :) | 13:14 |
| *** yingjun_ has joined #openstack-horizon | 13:14 | |
| *** zqfan has joined #openstack-horizon | 13:15 | |
| *** yingjun has quit IRC | 13:15 | |
| *** dratushnyy has joined #openstack-horizon | 13:16 | |
| * tsufiev sighs as the fun part of his job for today is over | 13:16 | |
| tsufiev | now it's time to find out what's wrong with projects list in fresh devstack | 13:16 |
| matt-borland | robcresswell, since the gate has been grumpy, and I noticed I'm missing one line from https://review.openstack.org/#/c/309482/ , should I fix that now and resubmit, or file a bug/patch later? | 13:17 |
| dratushnyy | Hi guys, I am getting strange error on the upstream devstack and horizon - "Error: Unable to retrieve project list." while I can get them with CLI | 13:17 |
| tsufiev | matt-borland, dratushnyy: guys, I was typing about this right now ) | 13:18 |
| dratushnyy | oh ok ) | 13:18 |
| matt-borland | :) | 13:18 |
| tsufiev | seems that some Keystone update broke Horizon projects list | 13:18 |
| tsufiev | so integration tests cannot set the project and fail | 13:18 |
| dratushnyy | yep, however that is strange. Isn't horizon use the same API calls as "openstack" CLI client? | 13:19 |
| * tsufiev is rolling up his sleeves | 13:19 | |
| tsufiev | dratushnyy, it uses django_openstack_auth library | 13:20 |
| *** peristeri has joined #openstack-horizon | 13:20 | |
| dratushnyy | oh, so there another layer | 13:21 |
| *** javeriak has quit IRC | 13:22 | |
| *** javeriak has joined #openstack-horizon | 13:22 | |
| tsufiev | dratushnyy, yeah, and it may be behind actual python-keystoneclient | 13:24 |
| tsufiev | just my guess as of now | 13:24 |
| *** mpavlase has quit IRC | 13:26 | |
| *** lblanchard has joined #openstack-horizon | 13:26 | |
| dratushnyy | As I get this "django_openstack_auth" is needed only to map keystone user to django_auth system and may have some assunptions about some urls? | 13:27 |
| tsufiev | no, it's more complicated than that | 13:27 |
| tsufiev | there are different kinds of keystone tokens - unscoped tokens, project-scoped and domain-scoped tokens | 13:28 |
| tsufiev | django_openstack_auth hides all these complexities from the rest of horizon | 13:28 |
| dratushnyy | got it | 13:28 |
| *** mpavlase has joined #openstack-horizon | 13:29 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 13:29 |
| *** javeriak has quit IRC | 13:37 | |
| *** yamamoto has quit IRC | 13:43 | |
| openstackgerrit | Merged openstack/manila-ui: Imported Translations from Zanata https://review.openstack.org/319760 | 13:45 |
| *** yingjun_ has quit IRC | 13:46 | |
| *** yingjun has joined #openstack-horizon | 13:46 | |
| openstackgerrit | Merged openstack/manila-ui: Cleanup of CreateShareType form https://review.openstack.org/319641 | 13:47 |
| *** ngupta has joined #openstack-horizon | 13:48 | |
| *** yingjun has quit IRC | 13:50 | |
| *** ametts has joined #openstack-horizon | 13:51 | |
| *** yingjun has joined #openstack-horizon | 13:59 | |
| *** jtriley has joined #openstack-horizon | 14:02 | |
| *** wolverineav has joined #openstack-horizon | 14:03 | |
| *** yamamoto has joined #openstack-horizon | 14:04 | |
| *** ducttape_ has joined #openstack-horizon | 14:04 | |
| *** ducttape_ has quit IRC | 14:09 | |
| *** ducttape_ has joined #openstack-horizon | 14:09 | |
| *** zackf has joined #openstack-horizon | 14:09 | |
| robcresswell | matt-borland: fix it, I'll just approve it again | 14:10 |
| matt-borland | sounds good, will do :) | 14:10 |
| matt-borland | thanks | 14:10 |
| robcresswell | tsufiev: I still can't get this keystone error. Not sure why. | 14:11 |
| robcresswell | I am cursed with a functioning devstack | 14:11 |
| tsufiev | robcresswell, just deployed a fresh devstack, still reproduces for me | 14:16 |
| tsufiev | seems like some recent devstack/keystone changes are involved | 14:16 |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Implement video capture for failed tests https://review.openstack.org/320004 | 14:17 |
| *** yamamoto has quit IRC | 14:19 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Implement video capture for failed tests https://review.openstack.org/320004 | 14:19 |
| robcresswell | tsufiev: Not sure if my last message went through, but yes I hadnt updated devstack, and it was patched in lib/keystone 18 hours ago | 14:19 |
| mrunge | robcresswell, you might be interested in current openstack-dev mail by Markus Zoeller (expire old bug reports) | 14:21 |
| mrunge | that woild help cleaning up a lot in horizon | 14:22 |
| robcresswell | mrunge: Yeah, I've read it. I would prefer we just triage bugs properly, than batch delete them. I've done many hundreds just by myself. | 14:23 |
| mrunge | yeah, if you have the cycles, your approach is better | 14:23 |
| robcresswell | The issue is not actually the number, but the reluctance to help out | 14:23 |
| mrunge | ack | 14:24 |
| robcresswell | So if you delete 200, all that happens is it slowly creeps back up. No problem has been solved in that regard. Its a culture issue more than anything, IMO :) | 14:24 |
| mrunge | cutting down bug numbers doesn't give you any stackalytics credits | 14:24 |
| tsufiev | robcresswell, I think I saw it, but still I'm getting this error :/ | 14:24 |
| robcresswell | This is why I like to review High bugs and do bug days etc. Think its better to try and persuade people to get involved | 14:25 |
| * tsufiev speaking with keystone folks right now | 14:25 | |
| *** ngupta has quit IRC | 14:25 | |
| *** pushkaru has joined #openstack-horizon | 14:26 | |
| *** javeriak has joined #openstack-horizon | 14:27 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding generic table extensibility https://review.openstack.org/309482 | 14:29 |
| *** yamamoto has joined #openstack-horizon | 14:29 | |
| matt-borland | robcresswell, see ^^; added one missing line. | 14:30 |
| matt-borland | thanks! | 14:30 |
| *** Murad has quit IRC | 14:30 | |
| *** brad[] has quit IRC | 14:30 | |
| matt-borland | TravT, since the gate was broken, I modified that patch you'd approved: https://review.openstack.org/#/c/309482/ | 14:30 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding generic table features https://review.openstack.org/318125 | 14:31 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Instances: Add angular instances panel https://review.openstack.org/261376 | 14:31 |
| *** yamamoto has quit IRC | 14:32 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding actions and views to Instance https://review.openstack.org/316244 | 14:32 |
| *** yamamoto has joined #openstack-horizon | 14:32 | |
| robcresswell | HORIZON_CONFIG["bug_url"] = "https://bugs.launchpad.net/horizon/+filebug" | 14:32 |
| robcresswell | Life changing config line. | 14:32 |
| *** masco has quit IRC | 14:32 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Using registration for auto-generation of Image feature https://review.openstack.org/309561 | 14:37 |
| *** zhurong has quit IRC | 14:40 | |
| *** yamamoto has quit IRC | 14:41 | |
| *** kzaitsev_mb has quit IRC | 14:41 | |
| *** yamamoto has joined #openstack-horizon | 14:42 | |
| *** kzaitsev_mb has joined #openstack-horizon | 14:47 | |
| *** yamamoto has quit IRC | 14:49 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding actions and views to Instance https://review.openstack.org/316244 | 14:50 |
| *** Mounica has joined #openstack-horizon | 14:53 | |
| *** jtriley has quit IRC | 14:54 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Implement video capture for failed tests https://review.openstack.org/320004 | 14:54 |
| *** btully has joined #openstack-horizon | 14:56 | |
| *** Mounica has quit IRC | 14:58 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding generic table features https://review.openstack.org/318125 | 15:01 |
| *** btully has quit IRC | 15:01 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Developer Registry Resource Browser https://review.openstack.org/313790 | 15:02 |
| *** amotoki has joined #openstack-horizon | 15:03 | |
| *** btully has joined #openstack-horizon | 15:05 | |
| *** Mounica has joined #openstack-horizon | 15:09 | |
| *** sdake has joined #openstack-horizon | 15:09 | |
| *** yingjun has quit IRC | 15:10 | |
| *** yingjun has joined #openstack-horizon | 15:10 | |
| *** tyr_ has joined #openstack-horizon | 15:12 | |
| *** bpokorny has joined #openstack-horizon | 15:12 | |
| *** aortega has quit IRC | 15:12 | |
| *** sdake_ has joined #openstack-horizon | 15:13 | |
| *** sdake has quit IRC | 15:13 | |
| *** adelia has joined #openstack-horizon | 15:14 | |
| *** belmoreira has quit IRC | 15:14 | |
| *** yingjun has quit IRC | 15:15 | |
| *** hurgleburgler has joined #openstack-horizon | 15:17 | |
| *** ChanServ sets mode: +v hurgleburgler | 15:17 | |
| *** ngupta has joined #openstack-horizon | 15:17 | |
| *** DevBox has joined #openstack-horizon | 15:18 | |
| *** amotoki_ has joined #openstack-horizon | 15:21 | |
| *** wolverineav has quit IRC | 15:23 | |
| *** amotoki has quit IRC | 15:24 | |
| *** pushkaru has quit IRC | 15:24 | |
| *** roxanaghe has joined #openstack-horizon | 15:27 | |
| *** jtriley has joined #openstack-horizon | 15:28 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding actions and views to Instance https://review.openstack.org/316244 | 15:28 |
| *** aortega has joined #openstack-horizon | 15:31 | |
| *** roxanaghe has quit IRC | 15:31 | |
| *** ngupta has quit IRC | 15:32 | |
| *** amotoki_ has quit IRC | 15:34 | |
| *** sdake_ has quit IRC | 15:34 | |
| *** bpokorny has quit IRC | 15:35 | |
| *** javeriak has quit IRC | 15:35 | |
| *** weezS has joined #openstack-horizon | 15:35 | |
| ducttape_ | I've been asked to add some release notes to a change - does this mean I just add a section in https://github.com/openstack/horizon/blob/master/releasenotes/source/unreleased.rst ? | 15:42 |
| hurgleburgler | reno I think | 15:43 |
| hurgleburgler | 'reno new some-name-here' | 15:43 |
| *** masco has joined #openstack-horizon | 15:44 | |
| ducttape_ | what happens in reno stays in reno | 15:44 |
| hurgleburgler | lol | 15:45 |
| ducttape_ | except things from reno 911 | 15:45 |
| david-lyle | robcresswell: what was: HORIZON_CONFIG["bug_url"] = "https://bugs.launchpad.net/horizon/+filebug" referencing? | 15:48 |
| *** yamamoto has joined #openstack-horizon | 15:48 | |
| *** bpokorny has joined #openstack-horizon | 15:49 | |
| *** dmk0202 has quit IRC | 15:49 | |
| *** javeriak has joined #openstack-horizon | 15:52 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Relax hz-table parent requirement https://review.openstack.org/321089 | 15:53 |
| *** yamamoto has quit IRC | 15:53 | |
| *** rcernin has quit IRC | 16:04 | |
| openstackgerrit | Sergey Gotliv proposed openstack/manila-ui: Create private share types https://review.openstack.org/319637 | 16:05 |
| *** jtriley has quit IRC | 16:08 | |
| *** jtriley has joined #openstack-horizon | 16:09 | |
| *** tesseract has quit IRC | 16:13 | |
| *** ygbo has quit IRC | 16:13 | |
| *** roxanaghe has joined #openstack-horizon | 16:15 | |
| *** roxanaghe has quit IRC | 16:18 | |
| *** lhcheng has joined #openstack-horizon | 16:19 | |
| *** ChanServ sets mode: +v lhcheng | 16:19 | |
| *** jtriley has quit IRC | 16:21 | |
| *** roxanaghe has joined #openstack-horizon | 16:22 | |
| *** gyee has joined #openstack-horizon | 16:23 | |
| *** jtriley has joined #openstack-horizon | 16:25 | |
| *** schipiga has quit IRC | 16:25 | |
| *** roxanaghe has quit IRC | 16:27 | |
| *** sdake has joined #openstack-horizon | 16:29 | |
| *** sayalilunkad has quit IRC | 16:32 | |
| *** masco has quit IRC | 16:33 | |
| *** jtriley has quit IRC | 16:36 | |
| *** ngupta has joined #openstack-horizon | 16:38 | |
| *** jtriley has joined #openstack-horizon | 16:41 | |
| *** roxanaghe has joined #openstack-horizon | 16:55 | |
| *** Daisy has joined #openstack-horizon | 16:55 | |
| *** weezS has quit IRC | 16:56 | |
| *** Daisy has quit IRC | 17:00 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add support for volume consistency group snapshots https://review.openstack.org/268368 | 17:01 |
| *** dratushnyy has quit IRC | 17:03 | |
| *** ducttape_ has quit IRC | 17:08 | |
| *** ducttape_ has joined #openstack-horizon | 17:08 | |
| *** ducttape_ has quit IRC | 17:10 | |
| *** ducttape_ has joined #openstack-horizon | 17:10 | |
| *** brad[] has joined #openstack-horizon | 17:18 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Allow magic search to be initialized by an event https://review.openstack.org/321132 | 17:18 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-ui: Add support for releasenotes https://review.openstack.org/320716 | 17:19 |
| tsufiev | lhcheng, hello! could you please help with a Horizon/Keystone issue? | 17:27 |
| tsufiev | See https://bugs.launchpad.net/keystone/+bug/1585682 | 17:27 |
| openstack | Launchpad bug 1585682 in OpenStack Identity (keystone) "Horizon gating on dsvm-integration job is broken due to recent changes in devstack/keystone" [Undecided,Incomplete] | 17:27 |
| tsufiev | Unfortunately, logstash wasn't able to dig something using the signature string and 2 days interval, so I cannot get morgan what he asks for :/ | 17:28 |
| tsufiev | perhaps we need to take some other root to RCA (instead of just reverting the devstack change under suspicion) | 17:29 |
| *** sean-k-mooney has joined #openstack-horizon | 17:31 | |
| sean-k-mooney | o/ | 17:31 |
| sean-k-mooney | am has the ablity to boot a vm from image without a volumn been removed from horizon? | 17:32 |
| *** sdake_ has joined #openstack-horizon | 17:33 | |
| *** ngupta has quit IRC | 17:33 | |
| *** sdake has quit IRC | 17:35 | |
| *** piet has joined #openstack-horizon | 17:37 | |
| *** TravT has quit IRC | 17:43 | |
| *** ngupta has joined #openstack-horizon | 17:43 | |
| *** TravT has joined #openstack-horizon | 17:49 | |
| *** ChanServ sets mode: +v TravT | 17:49 | |
| *** ig0r__ has quit IRC | 17:51 | |
| *** TravT has quit IRC | 17:53 | |
| *** mpavlase has quit IRC | 17:53 | |
| lhcheng | tsufiev: the endpoint in the service catalog probably didn't have the version number on it. | 17:54 |
| tsufiev | lhcheng, hm... does it mean we have to somehow adjust django_openstack_auth to that new rules or just fix devstack? | 17:54 |
| lhcheng | mfisch: I believe you hit this issue before? the keystone endpoint in service catalog doesn't have /v3 | 17:55 |
| *** javeriak has quit IRC | 17:55 | |
| *** Mounica has quit IRC | 17:55 | |
| lhcheng | tsufiev: I thought there was a patch to address that issue.. | 17:55 |
| *** Mounica has joined #openstack-horizon | 17:56 | |
| *** Mounica has quit IRC | 17:56 | |
| tsufiev | maybe I missed it... anyways, if it has been merged already, then its effects still haven't propagated | 17:57 |
| *** Mounica has joined #openstack-horizon | 17:59 | |
| lhcheng | this should have fix it: https://github.com/openstack/django_openstack_auth/commit/e008112d0f964b00bd5cb633262365ebc7f9395b | 18:00 |
| lhcheng | I think.. | 18:00 |
| lhcheng | maybe it is another bug.. | 18:00 |
| david-lyle | may not be released | 18:01 |
| david-lyle | oh, nevermind, in 2.2.0 and 2.2.1 | 18:01 |
| lhcheng | same issue as what Matt reported in : http://lists.openstack.org/pipermail/openstack-dev/2016-February/086852.html | 18:02 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Add router L3 agent info to info page https://review.openstack.org/306619 | 18:08 |
| * tsufiev thinks that he will examine this mail thread tomorrow (if nobody gets ahead of him) | 18:09 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Add router L3 agent info to info page https://review.openstack.org/306619 | 18:09 |
| lhcheng | david-lyle: does dsvm-integration pickup DOA from master or from latest release version? | 18:10 |
| tsufiev | lhcheng, it's latest release | 18:10 |
| david-lyle | lhcheng: should be latest release | 18:10 |
| lhcheng | tsufiev: summary: horizon should support versionless keystone endpoint :) | 18:10 |
| tsufiev | lol ) | 18:10 |
| *** _ducttape_ has joined #openstack-horizon | 18:11 | |
| *** roxanaghe has quit IRC | 18:11 | |
| *** roxanaghe has joined #openstack-horizon | 18:12 | |
| *** ducttape_ has quit IRC | 18:15 | |
| tsufiev | lhcheng, we don't have this feature yet in master branch or even in gerrit, do we? | 18:16 |
| lhcheng | tsufiev: you asking about the DOA feature? | 18:19 |
| *** vishwanathj has joined #openstack-horizon | 18:19 | |
| tsufiev | yes | 18:19 |
| lhcheng | https://github.com/openstack/django_openstack_auth/commit/e008112d0f964b00bd5cb633262365ebc7f9395b it was merged in Feb | 18:20 |
| *** mvk has quit IRC | 18:20 | |
| lhcheng | from looking at the test, it should append the /v3 or /v2.0 if the endpoint is versionless | 18:20 |
| *** sdake_ is now known as sdake | 18:23 | |
| tsufiev | lhcheng, I cannot reproduce the situation in debugger right now, but AFAIR, there was something like http://<hostip>/identity as auth_url which explains why it didn't work | 18:24 |
| lhcheng | tsufiev: interesting, wonder where "/identity" comes from | 18:25 |
| lhcheng | might be somewhere in devstack script | 18:25 |
| tsufiev | https://github.com/openstack-dev/devstack/commit/f5998b0253be5a73a068169591d9f773662d39aa is the primary suspect | 18:26 |
| lhcheng | ah | 18:27 |
| lhcheng | the web context was added | 18:27 |
| lhcheng | hmm I am afraid that maybe our code is not handling it correctly :( | 18:28 |
| matt-borland | tsufiev, robcresswell, perhaps you have more perspective, but with those bogus npm-run-test failures, they seem suspiciously like problems I had using a real browser for (as opposed to phantomjs) for automated test, in another context | 18:31 |
| matt-borland | The browser process never quite ends properly, so the machine happily waits until the 40-minute mark is reached, and figures everything failed. | 18:32 |
| lhcheng | the fix needed is somewhere here: https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/utils.py#L257 | 18:32 |
| tsufiev | matt-borland, interesting, I've been thinking that happens intermittently and only at gate | 18:33 |
| matt-borland | do we video these tests? | 18:33 |
| tsufiev | npm-run-test? no | 18:33 |
| matt-borland | good :) | 18:33 |
| tsufiev | should we :)? | 18:33 |
| matt-borland | probably not | 18:33 |
| matt-borland | unless we run out of ideas. We should figure out when this first started happening | 18:33 |
| matt-borland | this seems relatively new | 18:34 |
| matt-borland | I suspect Chrome and some sort of file weirdness causing it never to close | 18:34 |
| matt-borland | but I haven't looked at the script | 18:34 |
| sean-k-mooney | hi o/ | 18:34 |
| matt-borland | o/ | 18:34 |
| *** sdake_ has joined #openstack-horizon | 18:35 | |
| sean-k-mooney | i have a quick question re booting a vm with horizon without cinder | 18:35 |
| *** roxanagh_ has joined #openstack-horizon | 18:35 | |
| sean-k-mooney | http://picpaste.com/horizon-IsnSMR2S.PNG this is the view that i am given when i try to boot without cinder deployed | 18:35 |
| sean-k-mooney | there seams to be know way to not select a volumn | 18:35 |
| sean-k-mooney | this cause the boot to fail with aborted Block Device Mapping is invalid | 18:36 |
| matt-borland | I'm not familiar with nova's requirements...someone else? | 18:36 |
| sean-k-mooney | is there a config option to contol this or is horizon nolonger able to boot a vm without cinder? | 18:36 |
| *** bpokorny has quit IRC | 18:36 | |
| *** sdake has quit IRC | 18:37 | |
| sean-k-mooney | nova dose not need cinder as i can boot vms on the same system with the openstack client | 18:37 |
| *** roxanaghe has quit IRC | 18:38 | |
| * matt-borland looking at the code | 18:38 | |
| *** piet has quit IRC | 18:39 | |
| matt-borland | sean-k-mooney, what do you want to boot with, a Glance image? | 18:40 |
| sean-k-mooney | matt-borland: yes | 18:40 |
| sean-k-mooney | i was just booting a cirros image | 18:40 |
| matt-borland | yep. I suspect the code is causing trouble when it's looking to populate the Cinder information that it assumes is there... :P | 18:41 |
| matt-borland | Have you filed a LaunchPad bug ticket? | 18:42 |
| sean-k-mooney | ya i was guessing it was something like that. the option that was displayed should be there if i do boot form image (create new volume) | 18:42 |
| sean-k-mooney | no not yet | 18:42 |
| sean-k-mooney | i was trying to figure out if it was a horizon issue or kolla | 18:42 |
| matt-borland | What I'd suggest is that you take a look at the Javascript/developer panel | 18:43 |
| matt-borland | if you open that up when you go to launch an instance, my guess is you'll see some errors | 18:43 |
| matt-borland | if you could capture that as part of your report, that would really help | 18:43 |
| sean-k-mooney | ah ok ill try that now | 18:43 |
| matt-borland | as most people don't develop without Cinder :P | 18:43 |
| matt-borland | thanks sean-k-mooney | 18:43 |
| matt-borland | ping me when you've filed that bug, and Tag it with 'angularjs' (a LaunchPad option once you've filed the ticket) | 18:44 |
| *** jtriley has quit IRC | 18:44 | |
| sean-k-mooney | ya i normally use cinder too i just killed it to get a basic multi node stack working and was going to add it later | 18:45 |
| matt-borland | thanks for checking out that config | 18:45 |
| *** bpokorny has joined #openstack-horizon | 18:47 | |
| *** wolverineav has joined #openstack-horizon | 18:48 | |
| *** sdake_ is now known as sdake | 18:48 | |
| *** piet_ has joined #openstack-horizon | 18:51 | |
| *** wolverineav has quit IRC | 18:52 | |
| *** mpavlase has joined #openstack-horizon | 18:54 | |
| matt-borland | When the gate is broken, it reminds me of the Simpsons where Itch & Scratchy is horrible and the kids decide to all go outside and play. | 18:58 |
| hurgleburgler | there's a bobcat outside, I'd rather stay inside for now | 18:59 |
| *** javeriak has joined #openstack-horizon | 18:59 | |
| matt-borland | o.O | 18:59 |
| *** Mounica has quit IRC | 18:59 | |
| *** kzaitsev_mb has quit IRC | 19:00 | |
| *** mvk has joined #openstack-horizon | 19:05 | |
| *** adelia has left #openstack-horizon | 19:05 | |
| *** jtriley has joined #openstack-horizon | 19:09 | |
| *** javeriak_ has joined #openstack-horizon | 19:09 | |
| *** javeriak has quit IRC | 19:10 | |
| sean-k-mooney | matt-borland: https://bugs.launchpad.net/horizon/+bug/1585761 . the only error i could see in the javascript console was JQMIGRATE: jQuery.fn.attr('selected') may use property instead of attribute | 19:13 |
| openstack | Launchpad bug 1585761 in OpenStack Dashboard (Horizon) "failded to boot instance from image without cinder volume" [Undecided,New] | 19:13 |
| matt-borland | thanks sean-k-mooney for taking the time to do that, I'll look it over | 19:14 |
| sean-k-mooney | matt-borland: no worries im going to quickly see i i can find a commit that looks like the issue and deploy and older version of horizon and see if the issue is gone | 19:16 |
| matt-borland | sean-k-mooney, the old version of the launch instance wizard is also available by setting | 19:17 |
| *** _ducttape_ has quit IRC | 19:17 | |
| matt-borland | sean-k-mooney, if you go to your local_settings.py, you can change LAUNCH_INSTANCE_LEGACY_ENABLED to True and it will show up side-by-side with the button in your Instances panel | 19:17 |
| matt-borland | If you could test from that legacy Launch Instance, that would help clarify the bug and ensure if/where it's a regression | 19:18 |
| sean-k-mooney | oh ok that is easy to test ill give it a try | 19:18 |
| matt-borland | thanks | 19:18 |
| sean-k-mooney | am where is that file usually stored out of interest? | 19:19 |
| hurgleburgler | sean-k-mooney: I think you can also just go to /project/instances/launch | 19:19 |
| hurgleburgler | directly | 19:19 |
| hurgleburgler | without needing to enable it if you want to test something on the old launch instance | 19:20 |
| sean-k-mooney | hurgleburgler: ya that worked | 19:22 |
| hurgleburgler | \o/ | 19:22 |
| sean-k-mooney | matt-borland: i was able to launch an instance that way | 19:22 |
| matt-borland | ok, good, then we can have a good basis for the regression | 19:22 |
| matt-borland | it's a completely different architecture, so there's not a single patch that will explain the regression | 19:22 |
| matt-borland | it was instead a lost use case that wasn't implemented. | 19:23 |
| matt-borland | either way, thanks for the report! | 19:23 |
| *** bpokorny has quit IRC | 19:23 | |
| sean-k-mooney | matt-borland: am this was working i think 2-3 weeks ago in the new ui | 19:24 |
| *** dave-mccowan has joined #openstack-horizon | 19:24 | |
| matt-borland | really? Interesting. | 19:24 |
| sean-k-mooney | it was definetly posible post the mitaka release | 19:24 |
| matt-borland | ok then...I'll look at the recent changes. Mostly to a page layout | 19:24 |
| sean-k-mooney | there used to be a checkbox i think to select if you wanted a volume either that or it was an option in the drop down cant remember | 19:24 |
| matt-borland | It's an option in the drop down | 19:26 |
| matt-borland | lemme try master out with just the basics of an Image | 19:27 |
| *** ducttape_ has joined #openstack-horizon | 19:28 | |
| sean-k-mooney | this might be related https://github.com/openstack/horizon/commit/3e65e337ee5c707a6f27a7f406d76dab751cb8b2 | 19:28 |
| matt-borland | oh, wow, interesting | 19:30 |
| mrunge | heh, robcresswell has broken LI? | 19:31 |
| sean-k-mooney | not sure but it did change teh default value of volume create form false to true | 19:32 |
| matt-borland | that does seem like a possible problem | 19:32 |
| *** Mounica has joined #openstack-horizon | 19:32 | |
| mrunge | https://git.openstack.org/cgit/openstack/horizon/commit/?id=3e65e337ee5c707a6f27a7f406d76dab751cb8b2 | 19:32 |
| sean-k-mooney | i have never looked at the horizon codbase before so i have no ide if it correct | 19:32 |
| matt-borland | sean-k-mooney, it seems suspicious considering the situation | 19:32 |
| mrunge | that commit should fix this bug here: https://bugs.launchpad.net/horizon/+bug/1568866 | 19:33 |
| openstack | Launchpad bug 1568866 in OpenStack Dashboard (Horizon) "Launch Instance source doesn't detect the min volume size" [Low,Fix released] - Assigned to Rob Cresswell (robcresswell) | 19:33 |
| *** bpokorny has joined #openstack-horizon | 19:33 | |
| sean-k-mooney | should i add it to the bug i opened as a possible cause? | 19:34 |
| mrunge | yes please | 19:34 |
| matt-borland | sean-k-mooney, I put a note in] | 19:34 |
| matt-borland | feel free to expand on that | 19:35 |
| sean-k-mooney | ah ok you bet me too it i had not refreshed | 19:36 |
| matt-borland | heh heh, fingers of fire | 19:36 |
| sean-k-mooney | ill rebuild the horizon contianer with the commit before that was merged and see if the behavior is the same. | 19:37 |
| matt-borland | awesome, thanks for taking the time to do that | 19:37 |
| sean-k-mooney | well im usually a lazy person and prefer using horizon to boot vms then the commandline | 19:38 |
| sean-k-mooney | this is technically more work then jsut using the openstack client but i also like to figure out why things are broken when the effect me | 19:38 |
| robcresswell | david-lyle: Oh, just me mucking around in my dev env and linking to horizons filebug link. | 19:43 |
| david-lyle | got worries | 19:46 |
| david-lyle | *worried | 19:46 |
| tsufiev | robcresswell: david-lyle: could we use channel topic for the notifications when it makes no sense to recheck? | 19:47 |
| *** ngupta has quit IRC | 19:48 | |
| robcresswell | I've broken nothing | 19:48 |
| tsufiev | Another option is to send mail, but I'm not sure it's bett | 19:48 |
| sean-k-mooney | tsufiev: i have seen kolla do that in the past | 19:48 |
| robcresswell | Just reading scrollback :) | 19:48 |
| tsufiev | robcresswell: it's still devstack/django_openstack_auth issue | 19:48 |
| sean-k-mooney | robcresswell: :) well hopefully i can test the commit before that change and see if it works | 19:49 |
| tsufiev | sean-k-mooney: yaeh, I think that could work for horizon | 19:49 |
| dave-mccowan | i have a question about the login_region cookie. can someone help me out? | 19:49 |
| sean-k-mooney | robcresswell: it was a pure guess on my part but it was the first commit i came accross that sounded like it could be the issue | 19:50 |
| sean-k-mooney | tsufiev: its good to send a mail too but if people are on irc it works well | 19:50 |
| robcresswell | sean-k-mooney: Ha, yeah I'm kidding, I may well have broken something. It happens | 19:51 |
| openstackgerrit | Merged openstack/manila-ui: Add support for releasenotes https://review.openstack.org/320716 | 19:52 |
| dave-mccowan | i have a single region deployment, with an external API network (publicURL) and an internal management network (internalURL). in local_settings, I have OPENSTACK_KEYSTONE_URL set to the internalURL for keystone. when logging into horizon, the login_region cookie contains the internal IP address. i don't want internal IP addresses to leak externally. is there a way around this? | 19:53 |
| *** javeriak_ has quit IRC | 19:54 | |
| *** piet_ has quit IRC | 19:56 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: getIdsOfType now returns all ids if type undefined https://review.openstack.org/321207 | 19:57 |
| robcresswell | Ah, in that patch I changed the min vol size from undefined to 0. Not sure if that alters behaviour on the api side. | 19:58 |
| *** lblanchard has quit IRC | 19:58 | |
| r1chardj0n3s | morning | 19:58 |
| lhcheng | dave-mccowan: try un-commenting this setting - https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L361 | 19:59 |
| lhcheng | the code default to use the internalURL | 19:59 |
| *** kzaitsev_mb has joined #openstack-horizon | 20:00 | |
| lhcheng | tsufiev: thanks for sending out the email | 20:01 |
| dave-mccowan | lhcheng i have that set to internalURL, which I need. (the default is publicURL). everything is working. my concern is the value set for the login_region cookie contains an internal IP address, yet is being sent externally. | 20:01 |
| tsufiev | lhcheng, that will ease Jenkins stress a bit :) | 20:02 |
| sean-k-mooney | matt-borland: 8bf69bb0f96079302962ba42e1901fb3eb0f58d9 one commit before https://github.com/openstack/horizon/commit/3e65e337ee5c707a6f27a7f406d76dab751cb8b2 works | 20:02 |
| sean-k-mooney | broken http://picpaste.com/horizon-IsnSMR2S.PNG working http://picpaste.com/horizon-working-ElB9HfZN.PNG | 20:02 |
| *** wangbo has quit IRC | 20:03 | |
| *** zqfan has quit IRC | 20:03 | |
| *** wangbo has joined #openstack-horizon | 20:03 | |
| matt-borland | sean-k-mooney, just note that in the ticket and ping robcresswell :) | 20:03 |
| lhcheng | dave-mccowan: hmm can you change the OPENSTACK_KEYSTONE_URL value to use to publicURL instead? | 20:03 |
| lhcheng | the publicURL should work for authenticating users | 20:04 |
| *** jprovazn has quit IRC | 20:05 | |
| dave-mccowan | lhcheng i have TLS on my publicURL, and no certificates installed on my controller. so i need to use the internalURL for internal requests. | 20:05 |
| sean-k-mooney | matt-borland: would you like me to submit a patch that just reverts changing the defaults or will i leave it with your and robcresswell to resolve? | 20:06 |
| sean-k-mooney | i added a note to the bug too | 20:06 |
| matt-borland | sure, just uses Closes-Bug: bugnumber in the commit message | 20:06 |
| matt-borland | and reference the original bug/patch | 20:06 |
| sean-k-mooney | ok cool will do. ill add you and robcresswell to the reviewers list also incase there was a reason he changed them | 20:07 |
| matt-borland | thanks | 20:08 |
| *** tqtran has joined #openstack-horizon | 20:10 | |
| sjmc7 | dave-mccowan, lhcheng: that sounds like a bug; we wouldn’t want to expose IP addresses either | 20:11 |
| dave-mccowan | sjmc7 +1 | 20:12 |
| sjmc7 | just checking when the switch for the default from public -> internal was; i think it was within the last release or two | 20:12 |
| sjmc7 | ah, it’s still publicURL | 20:13 |
| dave-mccowan | sjmc7 i think the cookie value is coming from the OPENSTACK_KEYSTONE_URL, which should be unnecessary if the catalog value is used. | 20:13 |
| sjmc7 | yeah.. i can’t remember top of my head what that cookie’s used for | 20:13 |
| *** roxanagh_ has quit IRC | 20:14 | |
| lhcheng | dave-mccowan: I think that was for remembering the last endpoint the user logged in | 20:14 |
| lhcheng | sjmc7: ^ | 20:14 |
| sjmc7 | any reason not to record the region id instead? | 20:14 |
| lhcheng | and use that as default | 20:14 |
| dave-mccowan | i can't find the login_region cookie being set or read in horizon code. is there a companion library that does this? | 20:14 |
| lhcheng | sjmc7: can't think of any reason atm | 20:14 |
| sjmc7 | django_openstack_auth, dave-mccowan | 20:14 |
| *** roxanaghe has joined #openstack-horizon | 20:14 | |
| sjmc7 | david-lyle: i wish to tap the well of your great wisdom | 20:15 |
| dave-mccowan | i was thinking about trying to use the AVAILABLE_REGIONS setting. but, i only have one region, and the docs say not to set it if i have only one region. any guidance on that. | 20:15 |
| sjmc7 | available_regions is different | 20:15 |
| sjmc7 | it’s more akin to having multiple clouds | 20:16 |
| tsufiev | that's the problem :) | 20:16 |
| tsufiev | https://review.openstack.org/#/c/224756/ | 20:16 |
| robcresswell | Interesting post about the summit split btw http://www.openstack.org/blog/2016/05/faq-evolving-the-openstack-design-summit/ | 20:16 |
| tsufiev | it's a naming issue | 20:16 |
| tsufiev | dave-mccowan, sjmc7: I have 2 patches that should reduce confusion between regions and keystone endpoints | 20:16 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: getIdsOfType now returns all ids if type undefined https://review.openstack.org/321207 | 20:16 |
| sjmc7 | tsufiev: that’s good. dave-mccowan - this does sound like a legit bug, so i’d suggest filing it | 20:17 |
| tsufiev | (which nobody wants to merge :-/) | 20:17 |
| sjmc7 | robcresswell: they’re definitely going ahead with it then | 20:17 |
| dave-mccowan | sjmc7 bug in horizon or django_openstack_auth? | 20:17 |
| david-lyle | sjmc7: what's up? | 20:17 |
| *** tsufiev has left #openstack-horizon | 20:18 | |
| sjmc7 | under horizon, dave-mccowan | 20:18 |
| *** tsufiev has joined #openstack-horizon | 20:18 | |
| *** ChanServ sets mode: +v tsufiev | 20:18 | |
| sjmc7 | see above.. but the login_region value - can you remember why it’s a URL and not just a region id? | 20:18 |
| dave-mccowan | in my case, i don't have a region id, since i only have one region. | 20:19 |
| sjmc7 | when endpoint_type isn’t publicurl, it ends up exposing ip addresses in cookies | 20:19 |
| sjmc7 | dave-mccowan: there’ll be a default region id | 20:19 |
| tsufiev | robcresswell, seems only you and david-lyle can change the topic channel | 20:20 |
| sjmc7 | thinking about it… presumably the reason for the URL is that you may not have logged in, so no catalog yet | 20:20 |
| tsufiev | I would go with 'Rechecks are futile for dsvm-integration job until LP-1585682 is fixed' | 20:21 |
| *** roxanaghe has quit IRC | 20:22 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Example for video capturing of failed tests https://review.openstack.org/320009 | 20:22 |
| david-lyle | sjmc7: read back | 20:25 |
| david-lyle | and I'm trying to remember | 20:25 |
| sjmc7 | presumably a region ID on its own wouldn’t be much use without the catalog | 20:25 |
| david-lyle | sjmc7: that is correct | 20:25 |
| david-lyle | but we shouldn't be making the region choice until we have a scoped token | 20:26 |
| sjmc7 | it doesn’t determine where to go to keystone? | 20:26 |
| david-lyle | we don't create the user until we have a scoped token | 20:27 |
| *** jtriley has quit IRC | 20:27 | |
| david-lyle | wait, which region value specifically? | 20:27 |
| dave-mccowan | sjmc7, david-lyle hopefully the URL passed in the cookie isn't really used to perform the authentication. | 20:27 |
| sjmc7 | the one in the login_region cookie | 20:27 |
| sjmc7 | yeah, i could see how that might be a problem :) | 20:28 |
| david-lyle | oh yeah, that's for the region drop down on login | 20:29 |
| *** robcresswell changes topic to "Rechecks are futile for dsvm-integration job" | 20:29 | |
| *** zul has quit IRC | 20:29 | |
| r1chardj0n3s | matt-borland: let's argue about https://review.openstack.org/#/c/313243/ ? | 20:29 |
| robcresswell | Argh, damn return . | 20:29 |
| sjmc7 | i like that version robcresswell :) | 20:30 |
| sjmc7 | remove the last three words | 20:30 |
| r1chardj0n3s | heh | 20:30 |
| openstackgerrit | sean mooney proposed openstack/horizon: revert vol_create default value https://review.openstack.org/321223 | 20:30 |
| *** robcresswell changes topic to "Don't recheck for dsvm-integration job until bug 1585682 is fixed" | 20:30 | |
| robcresswell | Better. | 20:30 |
| robcresswell | "recheck is futile" seemed a little pessimistic. | 20:31 |
| r1chardj0n3s | "recheck is required" is more appropriate for a general topic | 20:32 |
| david-lyle | sjmc7: I can't really say why, you could just do a look up to settings based on the region name | 20:32 |
| matt-borland | r1chardj0n3s, what's the argument? | 20:32 |
| sjmc7 | settings doesn’t have the regions though, does it? | 20:32 |
| sjmc7 | wait, this is for AVAILABLE_REGIONS? or actual regions? | 20:32 |
| r1chardj0n3s | DOM structure, where hz-table goes, etc | 20:32 |
| david-lyle | that one is AVAILABLE_REGIONS | 20:32 |
| sjmc7 | now i’m confused :D | 20:32 |
| sjmc7 | hahaha | 20:32 |
| sjmc7 | DAMN YOU, AVAILABLE_REGIONS! | 20:33 |
| david-lyle | login_region is AVAILABLE_REGIONS | 20:33 |
| sjmc7 | ok. so in that case there’s no reason to be a URL | 20:33 |
| david-lyle | services_regions are catalog stuff | 20:33 |
| david-lyle | sjmc7: no, I wouldn't think so | 20:33 |
| sjmc7 | yeah, i was confused. so dave-mccowan - can you file a bug for this? | 20:33 |
| dave-mccowan | sjmc7 sure, i can file a bug. | 20:34 |
| dave-mccowan | sjmc7 do you think setting AVAILABLE_REGIONS could be a workaround? | 20:35 |
| sjmc7 | i think you’ll get a drop down that you maybe don’t want | 20:35 |
| * tsufiev again promotes renaming of AVAILABLE_REGIONS | 20:35 | |
| robcresswell | tsufiev: Is that new? I dont know that you've mentioned it before | 20:36 |
| dave-mccowan | sjmc7 i saw some code that checks len()>1, so maybe not? | 20:36 |
| sjmc7 | i guess give it a go | 20:36 |
| tsufiev | robcresswell, that's a long story, see https://openstack.nimeyo.com/51543/openstack-horizon-keystone-region-entity-finding-better-names | 20:37 |
| robcresswell | tsufiev: I was joking, IRC killed my sarcasm. I'm aware of the effort :) | 20:38 |
| robcresswell | sean-k-mooney: All that does is change the default value | 20:39 |
| sjmc7 | we british are cursed by our dry sense of humour | 20:39 |
| robcresswell | sean-k-mooney: Which is configurable in the workflow anyway... so its not really a bug, IMO. | 20:39 |
| david-lyle | dave-mccowan: one AVAILABLE_REGION will not cause it to appear on the login form | 20:39 |
| tsufiev | robcresswell, the sarcasm was too subtle for me :P | 20:39 |
| robcresswell | sjmc7: Its true. I used to respond to "how's your day" with "terrible, my job is too easy and the weather is perfect" | 20:40 |
| robcresswell | sjmc7: And the Californians would genuinely ask why it was bad :) | 20:40 |
| david-lyle | without setting an AVAILABLE_REGION, how are you connecting to the keystone endpoint? | 20:40 |
| david-lyle | that's like the one mandatory setting | 20:40 |
| *** ngupta has joined #openstack-horizon | 20:40 | |
| david-lyle | otherwise login has no idp to contact | 20:40 |
| david-lyle | it's just a form to nowhere | 20:41 |
| dave-mccowan | david-lyle i only have one region. | 20:41 |
| robcresswell | Deep. | 20:41 |
| david-lyle | dave-mccowan: you're in devstack? | 20:41 |
| dave-mccowan | david-lyle custom install, multi-node with HA. | 20:41 |
| sean-k-mooney | robcresswell: if i dont have cinder installed though i really should not be promted to select a volumn size and if i selct boot from image not boot from image (create new volumn) it should also not display the volumn info | 20:41 |
| dave-mccowan | david-lyle everything is working. just a security audit found internal IPs being leaked via cookies. | 20:42 |
| david-lyle | oh and specify only the OPENSTACK_KEYSTONE_ENDPOINT? | 20:42 |
| david-lyle | s/ENDPOINT/URL/ | 20:42 |
| robcresswell | sean-k-mooney: Thats true, but we should have some handling around the service being available or not | 20:42 |
| dave-mccowan | david-lyle yes. that's what the docs say to do. | 20:43 |
| robcresswell | sean-k-mooney: It seems more a case of "this could be improved" than "this is broken" ? | 20:43 |
| david-lyle | dave-mccowan: here's why we have the URL | 20:43 |
| david-lyle | ok, remembering | 20:43 |
| sean-k-mooney | robcresswell: with the current default if you dont have cinder installed there is nothing you can do from the horizon ui to boot an instance | 20:43 |
| david-lyle | that is the URL in the cookie | 20:43 |
| sean-k-mooney | robcresswell: is there a config option to change this behavior? | 20:44 |
| sean-k-mooney | robcresswell: well except use the old ui | 20:44 |
| david-lyle | if we switch to names, we'll need to change the way settings is handled | 20:45 |
| david-lyle | hmm, maybe | 20:45 |
| david-lyle | or have some logic to handle a default case | 20:45 |
| david-lyle | in d-o-a | 20:46 |
| dave-mccowan | david-lyle since a user can change the value of a cookie, hopefully horizon is not using the URL passed in the cookie. | 20:46 |
| *** sdake_ has joined #openstack-horizon | 20:46 | |
| david-lyle | dave-mccowan: why does it matter if the user changes the value? if they munge it, they can't login, no worries | 20:47 |
| david-lyle | dave-mccowan: the logic around the cookie use seems naive in the code though | 20:47 |
| david-lyle | no error handling | 20:47 |
| david-lyle | or validation | 20:48 |
| dave-mccowan | david-lyle change it to http://returns.50G.slowly.com:5000 | 20:48 |
| *** sdake has quit IRC | 20:48 | |
| robcresswell | sean-k-mooney: Ah, I see. Hmm | 20:48 |
| david-lyle | dave-mccowan: the user just blocked their own login, that's not destructive to anyone but them | 20:48 |
| david-lyle | and clearing the cookie resolves their error | 20:49 |
| david-lyle | validation would certainly be helpful | 20:49 |
| dave-mccowan | david-lyle it seems like an attack vector if a black hat can make horizon read from any URL. | 20:52 |
| sean-k-mooney | robcresswell: i am just testing my change to confim it works now but i know enough to revert to the pervious value, not enough to check if cinder is there. | 20:52 |
| david-lyle | if you're editing cookies on my system, I'm already compromised | 20:52 |
| robcresswell | sean-k-mooney: One moment. Just stacking so I can check. | 20:55 |
| *** julim has quit IRC | 20:56 | |
| robcresswell | tyr_: Thanks for https://review.openstack.org/#/c/321089/ ! I'll look into it | 20:57 |
| tyr_ | sure thing. Nothing earth shattering but an easy middle ground | 20:57 |
| robcresswell | Yeah just makes sense to do it in horizon than a plugin | 21:00 |
| robcresswell | So I appreciate the move. | 21:00 |
| *** roxanaghe has joined #openstack-horizon | 21:04 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Spinner/Loader should inherit from theme https://review.openstack.org/313685 | 21:06 |
| robcresswell | sean-k-mooney: You should be able to use 'serviceCatalog.ifTypeEnabled('volume')' in that launch-instance-model.service.js file to handle it better | 21:06 |
| robcresswell | sean-k-mooney: If you don't have the time to look into it, I can take over. I broke it so I own it, in that regard :) | 21:07 |
| *** roxanaghe has quit IRC | 21:07 | |
| *** gyee has quit IRC | 21:07 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Spinner/Loader should inherit from theme https://review.openstack.org/313685 | 21:08 |
| *** zzelle_ has joined #openstack-horizon | 21:08 | |
| *** Daisy has joined #openstack-horizon | 21:15 | |
| *** xenogear has joined #openstack-horizon | 21:16 | |
| *** pauloewerton has quit IRC | 21:17 | |
| sean-k-mooney | robcresswell: am sure if you could take over that would be great. i normally work on neutron/nova so horizon is not normally something i contribute too. | 21:18 |
| robcresswell | sean-k-mooney: Cool. I've assigned myself to the bug. Leave the patch up, I'll push something that handles both cases in the next couple of days. | 21:19 |
| *** Daisy has quit IRC | 21:19 | |
| sean-k-mooney | cool thanks | 21:19 |
| robcresswell | np | 21:20 |
| *** roxanaghe has joined #openstack-horizon | 21:22 | |
| *** peristeri has quit IRC | 21:26 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Improve system info page https://review.openstack.org/225334 | 21:26 |
| *** ametts has quit IRC | 21:28 | |
| *** matt-borland has quit IRC | 21:30 | |
| *** dratushnyy has joined #openstack-horizon | 21:32 | |
| *** ducttape_ has quit IRC | 21:37 | |
| *** sdake_ has quit IRC | 21:45 | |
| *** sdake has joined #openstack-horizon | 21:51 | |
| *** piet has joined #openstack-horizon | 21:58 | |
| *** lhcheng has quit IRC | 21:59 | |
| *** sdake has quit IRC | 22:25 | |
| *** weezS has joined #openstack-horizon | 22:42 | |
| *** weezS has quit IRC | 22:44 | |
| *** tyr_ has quit IRC | 22:45 | |
| *** ducttape_ has joined #openstack-horizon | 22:46 | |
| *** lhcheng has joined #openstack-horizon | 22:50 | |
| *** ChanServ sets mode: +v lhcheng | 22:50 | |
| *** gyee has joined #openstack-horizon | 22:55 | |
| *** mpavlase has quit IRC | 22:56 | |
| *** ngupta has quit IRC | 22:57 | |
| *** chlong has joined #openstack-horizon | 23:05 | |
| *** Mounica has quit IRC | 23:08 | |
| *** harlowja has quit IRC | 23:12 | |
| *** Mounica has joined #openstack-horizon | 23:16 | |
| *** vishwana_ has joined #openstack-horizon | 23:21 | |
| *** vishwanathj has quit IRC | 23:23 | |
| *** ducttape_ has quit IRC | 23:25 | |
| *** sdake has joined #openstack-horizon | 23:28 | |
| *** ducttape_ has joined #openstack-horizon | 23:28 | |
| *** kenji-i has quit IRC | 23:32 | |
| *** piet has quit IRC | 23:32 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
