| *** k-ishii has joined #openstack-horizon | 00:00 | |
| *** _ducttape_ has quit IRC | 00:03 | |
| *** piet has quit IRC | 00:05 | |
| *** dan_nguyen has joined #openstack-horizon | 00:06 | |
| *** jtriley has quit IRC | 00:32 | |
| *** ppiela_ has quit IRC | 00:35 | |
| *** ducttape_ has joined #openstack-horizon | 00:40 | |
| *** ducttape_ has quit IRC | 00:45 | |
| *** yamamoto has joined #openstack-horizon | 00:56 | |
| *** ZZelle_ has quit IRC | 01:01 | |
| *** yamamoto has quit IRC | 01:03 | |
| *** Drago has quit IRC | 01:05 | |
| *** mtanino has quit IRC | 01:06 | |
| *** Mounica has quit IRC | 01:07 | |
| *** alexvictorchan has quit IRC | 01:16 | |
| *** david-lyle has joined #openstack-horizon | 01:23 | |
| *** ChanServ sets mode: +o david-lyle | 01:23 | |
| *** neelashah has joined #openstack-horizon | 01:24 | |
| openstackgerrit | Reedip proposed openstack/xstatic-jasmine: Remove tox.ini as it is currently not used https://review.openstack.org/264591 | 01:28 |
|---|---|---|
| openstackgerrit | Li Yingjun proposed openstack/horizon: Pagination for flavor - more link https://review.openstack.org/234638 | 01:28 |
| *** ducttape_ has joined #openstack-horizon | 01:29 | |
| *** kzaitsev_mb has quit IRC | 01:29 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Support editing volume type access https://review.openstack.org/221616 | 01:35 |
| *** alexvictorchan has joined #openstack-horizon | 01:43 | |
| *** dan_nguyen has quit IRC | 01:43 | |
| *** ducttape_ has quit IRC | 01:44 | |
| *** ducttape_ has joined #openstack-horizon | 01:47 | |
| *** yamamoto has joined #openstack-horizon | 01:48 | |
| *** bpokorny has joined #openstack-horizon | 01:49 | |
| andrewbogott | I find myself needing to add an additional field to Horizon’s login screen (for a second auth factor). Is that something that’s already implemented in a post-kilo version? Or is the login panel somehow pluggable? | 01:56 |
| *** tqtran-afk has quit IRC | 01:57 | |
| *** yamamoto has quit IRC | 02:00 | |
| *** zhurong has joined #openstack-horizon | 02:01 | |
| openstackgerrit | fengzhr proposed openstack/horizon: The update image should be changed to edit image https://review.openstack.org/275029 | 02:05 |
| openstackgerrit | fengzhr proposed openstack/horizon: swift_create_subfolder function removed but its still called in the code https://review.openstack.org/273857 | 02:06 |
| openstackgerrit | Alan Fung proposed openstack/horizon: Fix issue with some modals are missing backdrop https://review.openstack.org/280470 | 02:06 |
| openstackgerrit | Alan Fung proposed openstack/horizon: Fix issue with some modals are missing backdrop https://review.openstack.org/280470 | 02:08 |
| openstackgerrit | Alan Fung proposed openstack/horizon: Fix issue with some modals are missing backdrop https://review.openstack.org/280472 | 02:11 |
| *** neelashah has quit IRC | 02:14 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add feature to log an operation of users to Horizon https://review.openstack.org/272935 | 02:18 |
| *** zhurong has quit IRC | 02:22 | |
| *** zhurong has joined #openstack-horizon | 02:22 | |
| *** ducttape_ has quit IRC | 02:30 | |
| *** itisha has quit IRC | 02:37 | |
| *** dan_nguyen has joined #openstack-horizon | 02:44 | |
| *** 18VAAAIFD has joined #openstack-horizon | 02:47 | |
| *** fedexo has joined #openstack-horizon | 03:08 | |
| *** ducttape_ has joined #openstack-horizon | 03:09 | |
| *** ducttape_ has quit IRC | 03:23 | |
| *** ducttape_ has joined #openstack-horizon | 03:28 | |
| *** ccard__ has joined #openstack-horizon | 03:31 | |
| *** ccard_ has quit IRC | 03:34 | |
| *** ccard_ has joined #openstack-horizon | 03:35 | |
| *** ccard__ has quit IRC | 03:36 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix issue when using glance v2 api https://review.openstack.org/249531 | 03:47 |
| *** piet has joined #openstack-horizon | 03:47 | |
| *** dmz has quit IRC | 03:47 | |
| *** piet has quit IRC | 03:53 | |
| *** flwang1 has quit IRC | 03:56 | |
| *** amotoki has joined #openstack-horizon | 03:56 | |
| *** amotoki has quit IRC | 03:56 | |
| *** ducttape_ has quit IRC | 03:57 | |
| *** david-lyle has quit IRC | 04:03 | |
| *** gberginc has joined #openstack-horizon | 04:13 | |
| *** dan_nguyen has quit IRC | 04:22 | |
| *** dan_nguyen has joined #openstack-horizon | 04:26 | |
| *** dan_nguyen has quit IRC | 04:41 | |
| *** sanjana has joined #openstack-horizon | 04:45 | |
| *** deray has joined #openstack-horizon | 04:46 | |
| *** david-lyle has joined #openstack-horizon | 04:55 | |
| *** ChanServ sets mode: +o david-lyle | 04:55 | |
| *** masco has joined #openstack-horizon | 05:03 | |
| *** fedexo has quit IRC | 05:18 | |
| wolverineav | in case there's someone online - i'm stuck at this strange error. i've added a neutron plugin with its corresponding python-neutronclient extension. | 05:19 |
| r1chardj0n3s | hi wolverineav | 05:20 |
| wolverineav | i'm able to query it via regular python script. but when calling it from horizon, i end up with a long error trace with "'NoneType' object is not iterable " being the main error | 05:20 |
| wolverineav | r1chardj0n3s: hi! | 05:21 |
| r1chardj0n3s | can you put the full exception display somewere? | 05:21 |
| wolverineav | yep, let me get a pastebin link | 05:21 |
| david-lyle | wolverineav: what plugin? | 05:22 |
| r1chardj0n3s | david-lyle: y u awake? | 05:22 |
| david-lyle | traveling ;) | 05:22 |
| r1chardj0n3s | ah! | 05:22 |
| r1chardj0n3s | whereabouts, or is is secret? | 05:22 |
| david-lyle | pretrip trip to Portland | 05:22 |
| wolverineav | david-lyle: its a service plugin i'm writing for talking to a SDN controller | 05:23 |
| r1chardj0n3s | ahh | 05:23 |
| david-lyle | wolverineav: so you've modified api/neutron.py in horizon? | 05:24 |
| david-lyle | to make the desired request | 05:24 |
| david-lyle | wolverineav: I think the paste will be the most informative | 05:25 |
| wolverineav | yep, so the neutron.py for my horizon plugin looks like this: http://pastebin.com/UD4tWTG1 | 05:25 |
| david-lyle | where are you instantiating neutronclient? | 05:26 |
| wolverineav | and the error log (which doesn't help me much): http://pastebin.com/KvG5Vfbw | 05:26 |
| wolverineav | so i assume the devstack horizon has instantiated neutronclient | 05:28 |
| wolverineav | i just import it from openstack_dashboard.api, just like fwaas does | 05:28 |
| wolverineav | notice, that my neutron.py doesn't even query neutron for now. i'm just creating a static object and returning. and its still failing with that error log | 05:30 |
| david-lyle | wolverineav: you never make a call to neutronclient | 05:30 |
| wolverineav | david-lyle: yes, correct. i was trying to figure out if the neutronclient was the problem. | 05:31 |
| *** zzxwill has joined #openstack-horizon | 05:32 | |
| wolverineav | i returned the static object list from tabs.py and it works. so next, i moved it from tabs.py to neutron.py and i see that error trace. | 05:33 |
| zzxwill | Can I add another .po file under /horizon/locale/zh_CN/LC_MESSAGES? I did, but it won't work after I generated the .mo file based on the .po file. | 05:34 |
| wolverineav | my plugin is exactly like the tutorial one: http://docs.openstack.org/developer/horizon/tutorials/dashboard.html instead of Instances, i return ReachabilityTests | 05:34 |
| david-lyle | wolverineav: so your tabs.py is calling reachabilitytest_list ? | 05:37 |
| wolverineav | yes | 05:37 |
| wolverineav | david-lyle: yes | 05:37 |
| david-lyle | zzxwill: for a local only .po file, or to be delivered with horizon in general? | 05:38 |
| david-lyle | wolverineav: and the result, even though hardcoded is an empty list? | 05:38 |
| *** bpokorny has quit IRC | 05:40 | |
| wolverineav | david-lyle: it doesn't print the LOG or print statements in the neutron.py's method. so i'm not sure if it even gets an empty list. it complains about 'NoneType' | 05:41 |
| zzxwill | david-lyle, to be delivered with Horizion in general. It will work if I put the the translated strings in django.po or djangojs.po. But it won't I put them in a separate .po file. | 05:42 |
| david-lyle | wolverineav: I have a feeling the Wrapper is encountering an error? | 05:43 |
| david-lyle | zzxwill: the translation for horizon and openstack projects are handled in a tool called Zanata | 05:44 |
| david-lyle | they are not manually added to the horizon repo, but instead added to zanata and then uploaded automatically to horizon | 05:44 |
| david-lyle | the .mo files are then generated at run time | 05:44 |
| * david-lyle looks for zanata link | 05:45 | |
| david-lyle | zzxwill: try this https://wiki.openstack.org/wiki/Translations | 05:45 |
| zzxwill | It's a local Horizon project. I run it in my local environment. | 05:45 |
| david-lyle | zzxwill: ok | 05:46 |
| david-lyle | have you tried removing the .mo file and recompiling them? | 05:47 |
| zzxwill | Yes, I tried. | 05:47 |
| zzxwill | I wonder whether Horizon localization can only support django.po and djangojs.po. | 05:47 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix issue when using glance v2 api https://review.openstack.org/249531 | 05:48 |
| zzxwill | instead of another .po file. | 05:48 |
| wolverineav | david-lyle: hmm..wrapper doesn't seem to be the problem, since moving it to tabs.py like this works: http://pastebin.com/5sF066Ty | 05:48 |
| wolverineav | pretty sure its some silly minor thing i'm missing. just can't figure out what! | 05:50 |
| david-lyle | wolverineav: what's your tabs.py look like? | 05:51 |
| david-lyle | hopefully contains a return statement | 05:51 |
| david-lyle | zzxwill: I believe the two files are hardcoded | 05:52 |
| david-lyle | there is work to make the list dynamic | 05:52 |
| wolverineav | david-lyle: this is what it looks like: http://pastebin.com/wiBXps2E | 05:52 |
| david-lyle | but that's plugin driven | 05:52 |
| zzxwill | I am afraid it's ture. | 05:52 |
| david-lyle | wolverineav: ok, you're not paginating your api yet | 05:53 |
| *** Ephur has joined #openstack-horizon | 05:53 | |
| wolverineav | david-lyle: haha, yes, there is a return statement. it craps out before reaching the return statement. | 05:53 |
| david-lyle | so returning one value to something expecting 2 might be causing the problem | 05:53 |
| david-lyle | If you know the method it's bombing in (and it's not related to the mismatched return/expectation) try/except and narrow you window | 05:54 |
| wolverineav | david-lyle: so, in the neutron backend, i have only one value right now. i had the paginate stuff, but i thought it might be causing the issue, so i simplified it to just the request and the return | 05:55 |
| david-lyle | wolverineav: I mean in the horizon side code | 05:55 |
| david-lyle | http://pastebin.com/UD4tWTG1 returns the list | 05:55 |
| david-lyle | http://pastebin.com/wiBXps2E expects the list and a has_more | 05:56 |
| zzxwill | david-lyle: Sorry, By the link, what would you like to tell me? | 05:57 |
| david-lyle | you either need to return list, false from the first or change the expectation on the second | 05:57 |
| david-lyle | zzxwill: that was if you were trying to upstream your translations | 05:57 |
| david-lyle | which I thought you indicated | 05:58 |
| wolverineav | david-lyle: ah, right. let me try that. thanks for the pointer! | 05:58 |
| david-lyle | wolverineav: np | 05:58 |
| david-lyle | hopefully it helps | 05:58 |
| david-lyle | zzxwill: for you, I just have to remember where those files are hardcoded | 05:59 |
| zzxwill | Okay, I will put those strings in one of the two files. Thanks. David. | 06:00 |
| zzxwill | david-lyle: Can a .po file include another .po file? | 06:02 |
| david-lyle | zzxwill: I think they can be concatenated, not sure about inclusion | 06:02 |
| zzxwill | Got it, thanks:) | 06:05 |
| *** piet has joined #openstack-horizon | 06:06 | |
| *** patk has quit IRC | 06:08 | |
| *** Sudheer has joined #openstack-horizon | 06:10 | |
| Sudheer | Hello can we setup horizon with multifactor authentication | 06:10 |
| Sudheer | ?? | 06:10 |
| david-lyle | Sudheer: not without altering django_openstack_auth | 06:11 |
| david-lyle | https://github.com/openstack/django_openstack_auth | 06:11 |
| *** piet has quit IRC | 06:11 | |
| Sudheer | And do we need to change any thing from keystone side | 06:12 |
| Sudheer | say my openstack setup is based on liberty should i need to change anything from keystone side?? | 06:13 |
| wolverineav | david-lyle: updating both tabs.py and neutron.py to handle list, _has_more didn't help :| | 06:16 |
| david-lyle | Sudheer: yes re: Keystone, but I can't provide much more detail on that | 06:18 |
| david-lyle | wolverineav: hmm | 06:18 |
| stevemar | david-lyle: we don't have MFA support in keystone yet :| | 06:19 |
| david-lyle | since there are only about 10 lines of code, I would walk through each line and see which one fails | 06:19 |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Added test for check instances pagination functionality https://review.openstack.org/269488 | 06:19 |
| david-lyle | stevemar: I didn't think so, I'm just pointing out that me telling people how would be bad for all involved :P | 06:20 |
| *** vgridnev has joined #openstack-horizon | 06:20 | |
| stevemar | david-lyle: gotcha, just didn't want you spreading lies :P | 06:21 |
| david-lyle | stevemar: you can't stop me | 06:21 |
| david-lyle | the lies have to get out | 06:21 |
| *** vgridnev has quit IRC | 06:21 | |
| * stevemar regrets everything | 06:21 | |
| *** vgridnev has joined #openstack-horizon | 06:22 | |
| *** vgridnev_ has joined #openstack-horizon | 06:22 | |
| wolverineav | hmm..let me try again.. | 06:24 |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Tests for instance filtering are added https://review.openstack.org/271204 | 06:26 |
| *** vgridnev has quit IRC | 06:26 | |
| k-ishii | @Akihiro, Cindy, David, Lin: Thank you for review! I addressed your comments and would you mind reviewing https://review.openstack.org/#/c/252190/ ? | 06:32 |
| *** aortega has quit IRC | 06:36 | |
| Sudheer | Hello stevemar so changing openstack_auth does not solve the issue right | 06:38 |
| *** gberginc has quit IRC | 06:38 | |
| stevemar | Sudheer: correct, keystone doesn't support MFA at this point | 06:39 |
| *** david-lyle has quit IRC | 06:39 | |
| *** david-lyle has joined #openstack-horizon | 06:40 | |
| *** ChanServ sets mode: +o david-lyle | 06:40 | |
| Sudheer | so is there any way that i can achieve that support i have gone through the web and saw this link | 06:41 |
| Sudheer | https://ask.openstack.org/en/question/53047/how-to-implement-2-factor-authentication-in-horizon/ | 06:41 |
| *** gberginc has joined #openstack-horizon | 06:57 | |
| stevemar | Sudheer: looks like a minimal proof of concept, we have someone adding MFA support to keystone now (https://review.openstack.org/#/c/274901/) you are welcome to review the code and give feedback | 06:59 |
| *** e0ne has joined #openstack-horizon | 07:02 | |
| *** Liuqing has joined #openstack-horizon | 07:05 | |
| *** wolverineav has quit IRC | 07:08 | |
| *** wolverineav has joined #openstack-horizon | 07:21 | |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Added tests for check instance row actions functionality https://review.openstack.org/273971 | 07:32 |
| *** rcernin has joined #openstack-horizon | 07:38 | |
| *** gberginc has quit IRC | 07:39 | |
| *** lhcheng has joined #openstack-horizon | 07:41 | |
| openstackgerrit | fengzhr proposed openstack/horizon: The update image should be changed to edit image https://review.openstack.org/275029 | 07:41 |
| *** gberginc has joined #openstack-horizon | 07:42 | |
| *** Anticimex has quit IRC | 07:45 | |
| *** gbraad_ has quit IRC | 07:45 | |
| *** Anticimex has joined #openstack-horizon | 07:46 | |
| *** gbraad has joined #openstack-horizon | 07:46 | |
| *** piet has joined #openstack-horizon | 07:49 | |
| *** piet has quit IRC | 07:54 | |
| *** mpavlase has joined #openstack-horizon | 07:59 | |
| *** mpavlase has quit IRC | 07:59 | |
| *** piet has joined #openstack-horizon | 07:59 | |
| *** mpavlase has joined #openstack-horizon | 08:00 | |
| openstackgerrit | Masco proposed openstack/horizon: WIP-Added action for attach QoS policy to network https://review.openstack.org/280541 | 08:12 |
| *** e0ne has quit IRC | 08:13 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP - Not stable yet] Tests for images filtering are added https://review.openstack.org/270773 | 08:22 |
| *** rdopiera has joined #openstack-horizon | 08:25 | |
| *** vgridnev has joined #openstack-horizon | 08:26 | |
| *** vgridnev has quit IRC | 08:27 | |
| *** vgridnev has joined #openstack-horizon | 08:29 | |
| *** vgridnev has quit IRC | 08:31 | |
| *** vgridnev_ has quit IRC | 08:33 | |
| *** vgridnev has joined #openstack-horizon | 08:34 | |
| *** vgridnev has quit IRC | 08:38 | |
| *** vgridnev_ has joined #openstack-horizon | 08:39 | |
| *** vgridnev_ has quit IRC | 08:42 | |
| *** vgridnev has joined #openstack-horizon | 08:43 | |
| *** xinwu has quit IRC | 08:43 | |
| *** vgridnev has quit IRC | 08:44 | |
| *** aortega has joined #openstack-horizon | 08:46 | |
| *** piet has quit IRC | 08:47 | |
| *** wolverineav has quit IRC | 08:49 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Add identity v3 API filtering to users and projects tables https://review.openstack.org/252488 | 08:49 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Add truncated flag support https://review.openstack.org/250869 | 08:50 |
| *** xinwu has joined #openstack-horizon | 08:51 | |
| *** xinwu has quit IRC | 08:56 | |
| *** wolverineav has joined #openstack-horizon | 09:01 | |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Added test_view_credentials https://review.openstack.org/277315 | 09:02 |
| *** gberginc has quit IRC | 09:03 | |
| *** wolverineav has quit IRC | 09:04 | |
| *** gberginc has joined #openstack-horizon | 09:15 | |
| *** e0ne has joined #openstack-horizon | 09:16 | |
| openstackgerrit | Masco proposed openstack/horizon: WIP-Added action for attach QoS policy to network https://review.openstack.org/280541 | 09:19 |
| *** zzxwill has quit IRC | 09:23 | |
| *** lhcheng has quit IRC | 09:26 | |
| *** mvk has quit IRC | 09:27 | |
| *** al_indig_ has joined #openstack-horizon | 09:27 | |
| *** ygbo has joined #openstack-horizon | 09:28 | |
| *** zhurong has quit IRC | 09:28 | |
| *** al_indigo has quit IRC | 09:29 | |
| tsufiev | robcresswell, mrunge: morning, gentlemen! As usual, another piece of i9n tests goodness here: https://review.openstack.org/#/c/278365/4 :) | 09:33 |
| tsufiev | I'm telling about it explicitly only because other i9n patches rely on this patch (or waiting for it to merge) | 09:33 |
| tsufiev | most importantly, it encourages DRY in i9n tests | 09:34 |
| mrunge | tsufiev, good morning | 09:34 |
| mrunge | hope to get there at some point | 09:34 |
| tsufiev | sure, no pressure | 09:35 |
| *** aortega has quit IRC | 09:39 | |
| *** Liuqing has quit IRC | 09:41 | |
| *** xinwu has joined #openstack-horizon | 09:44 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Tests for images filtering are added https://review.openstack.org/270773 | 09:47 |
| openstackgerrit | Merged openstack/horizon: Protect cinder list against permission issues https://review.openstack.org/277304 | 09:48 |
| *** mvk has joined #openstack-horizon | 09:54 | |
| *** itxaka has joined #openstack-horizon | 10:00 | |
| *** wolverineav has joined #openstack-horizon | 10:04 | |
| *** piet has joined #openstack-horizon | 10:06 | |
| *** Liuqing has joined #openstack-horizon | 10:06 | |
| *** wolverineav has quit IRC | 10:09 | |
| *** xinwu has quit IRC | 10:10 | |
| *** vgridnev has joined #openstack-horizon | 10:14 | |
| *** vgridnev has quit IRC | 10:14 | |
| *** vgridnev has joined #openstack-horizon | 10:15 | |
| mrunge | tsufiev, may I ask you to look at https://review.openstack.org/#/c/275817/ ? That is a dependency for disabling metering dashboard. | 10:20 |
| tsufiev | mrunge, looking | 10:20 |
| *** vgridnev has quit IRC | 10:26 | |
| *** vgridnev has joined #openstack-horizon | 10:34 | |
| *** aortega has joined #openstack-horizon | 10:39 | |
| *** erlon has joined #openstack-horizon | 10:48 | |
| *** pece has joined #openstack-horizon | 10:50 | |
| tsufiev | mrunge, the patch will need additional iteration or a couple of them, right now DISABLED = True panels are not considered there | 10:56 |
| mrunge | tsufiev, yes, that's right. | 10:57 |
| tsufiev | mrunge, robcresswell: thanks for reviewing i9n patch :) | 10:57 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 10:57 |
| * tsufiev have refreshed his knowledge of plugin system | 10:57 | |
| tsufiev | I have to admit that some places are rather tricky there | 10:58 |
| mrunge | tsufiev, if you have a panel DISABLED = True, it won't get picked up at all | 10:58 |
| mrunge | resulting in orgies of try except | 10:58 |
| tsufiev | yes | 10:58 |
| mrunge | it's not optimal, yes | 10:58 |
| tsufiev | panel not picked, but tests are | 10:58 |
| mrunge | see? | 10:58 |
| *** piet has quit IRC | 10:59 | |
| mrunge | tsufiev, I mean, you can not even check for disabled status then | 10:59 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [WIP] Fix remaining Django 1.9 test failures https://review.openstack.org/280222 | 10:59 |
| tsufiev | mrunge, I guess we need to analyze configs textually, not in memory objects | 10:59 |
| mrunge | ouch | 10:59 |
| tsufiev | or provide some 'shadow' copy of configs - so the disabled configs will be present in memory | 11:00 |
| tsufiev | second approach could be less painful | 11:00 |
| mrunge | on the other side, why should we keep disabled things in memory? | 11:00 |
| tsufiev | hm... yes, that looks a bit awkward. Perhaps we should just consider the panel disabled if it's not present in registry | 11:01 |
| robcresswell | One day, django1.9 will work. | 11:02 |
| robcresswell | one day... | 11:02 |
| tsufiev | I think it's going to be sooner than Horizon switches to Angular 2 :) | 11:03 |
| robcresswell | haha | 11:03 |
| robcresswell | I think we're more likely to use react than angular 2 :p | 11:03 |
| mrunge | or how the next cool javascript framework is being named | 11:03 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 11:06 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: [WIP] Fix remaining Django 1.9 test failures https://review.openstack.org/280222 | 11:08 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [WIP] Fix remaining Django 1.9 test failures https://review.openstack.org/280222 | 11:11 |
| itxaka | tsufiev, do you have any pointers on how to use the panel classes registry? | 11:12 |
| *** deray has quit IRC | 11:12 | |
| itxaka | that was my first approach to the problem but could not get anything decent out of it | 11:12 |
| itxaka | didnt really look like what you expect from a registry tbh | 11:13 |
| *** piet has joined #openstack-horizon | 11:13 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for changing password for newly created user https://review.openstack.org/274659 | 11:15 |
| *** vgridnev_ has joined #openstack-horizon | 11:16 | |
| *** vgridnev_ has quit IRC | 11:16 | |
| *** vgridnev has quit IRC | 11:19 | |
| *** vgridnev has joined #openstack-horizon | 11:19 | |
| toabctl | mrunge: time for another review of https://review.openstack.org/#/c/243974/ ? | 11:20 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for changing password for newly created user https://review.openstack.org/274659 | 11:21 |
| mrunge | toabctl, I'm more or less involved in that patch set, it wouldn't be really right to vote on it | 11:22 |
| toabctl | mrunge: ah.ok. just asked because you added your +2 in the past. then I'll wait for other reviews | 11:23 |
| mrunge | toabctl, I'm still all in for this patch, yes! | 11:23 |
| *** vgridnev has quit IRC | 11:25 | |
| openstackgerrit | Thomas Bechtold proposed openstack/horizon: Add local_settings.d/ dir for settings snippets https://review.openstack.org/243974 | 11:27 |
| *** vgridnev has joined #openstack-horizon | 11:27 | |
| *** mpavlase has quit IRC | 11:29 | |
| *** piet has quit IRC | 11:31 | |
| openstackgerrit | Merged openstack/horizon: Change TestImageAdmin to test proper pages https://review.openstack.org/278365 | 11:31 |
| *** mpavlase has joined #openstack-horizon | 11:32 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test check Instance Overview page https://review.openstack.org/280134 | 11:36 |
| tsufiev | itxaka: sorry, no idea yet | 11:36 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test check Instance Overview page https://review.openstack.org/280134 | 11:37 |
| tsufiev | Perhaps panels registry should be improved | 11:37 |
| robcresswell | yes | 11:37 |
| *** rodrigods has quit IRC | 11:38 | |
| robcresswell | tsufiev: https://pypi.python.org/pypi/stevedore for enabling plugins and better logic to process it | 11:38 |
| *** rodrigods has joined #openstack-horizon | 11:38 | |
| mrunge | should that be the same or a different patch? | 11:38 |
| mrunge | robcresswell, uhm, why don't we use oslo.config then? | 11:38 |
| robcresswell | mrunge: Mainly because our settings processing actually works fine with django | 11:38 |
| robcresswell | using oslo conf would interfere with django conf, would it not? | 11:39 |
| mrunge | but before we'd switch to stevedore, we should switch to oslo.config, no? | 11:39 |
| mrunge | it would not necessarily interfere | 11:39 |
| robcresswell | I don't believe so, but I've not looked into it a great deal. I want to find a better situation than enabled/ though. | 11:40 |
| mrunge | well, config is config, there should be only one. if you're adding another mechanism, then you'll interfere | 11:40 |
| *** 18VAAAIFD has quit IRC | 11:40 | |
| robcresswell | thats the point though | 11:40 |
| robcresswell | we already have config via enabled and config via settings | 11:41 |
| robcresswell | if I want to alter HORIZON_CONFIG, I can use enabled/ or local_settings | 11:41 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 11:41 |
| robcresswell | plus we have panel logic tied in to our settings.py | 11:41 |
| robcresswell | its really not nice. | 11:41 |
| mrunge | robcresswell, yes. /me would propose to remove/deprecate local_settings | 11:42 |
| robcresswell | mrunge: https://blueprints.launchpad.net/horizon/+spec/settings-overhaul | 11:42 |
| robcresswell | That was my very early idea, I just put it down on a bp while it was in my mind. | 11:43 |
| mrunge | a single file might be nice for devstack, but it's a mess for distributors and folks doing configuration | 11:43 |
| *** sambetts has quit IRC | 11:43 | |
| robcresswell | I agree. But I don't agree with keeping any values in local_settings | 11:44 |
| robcresswell | IMO *all* default values should be in settings.py | 11:44 |
| robcresswell | local_settings should be an empty dir. | 11:44 |
| *** ccesario has quit IRC | 11:44 | |
| robcresswell | perhaps with a .py.example | 11:44 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 11:44 |
| *** sambetts has joined #openstack-horizon | 11:44 | |
| mrunge | robcresswell, so you would still keep python files for configs? | 11:45 |
| robcresswell | mrunge: Have a glance through that bp, its easier than me explaining again :) | 11:45 |
| mrunge | I did | 11:45 |
| robcresswell | Ah okay | 11:45 |
| mrunge | I'm commenting there | 11:46 |
| robcresswell | So yes, currently my thinking is to keep python files for config. Too much existing config out in the wild is in python. We could deprecate over time, but initial design would incorporate python config and ini for distros. | 11:47 |
| mrunge | aha, ok | 11:47 |
| *** rodrigods has quit IRC | 11:47 | |
| mrunge | but how much of horizon do you really need to configure? | 11:48 |
| *** rodrigods has joined #openstack-horizon | 11:48 | |
| mrunge | I mean, this will hurt everyone | 11:48 |
| mrunge | while already at causing pain, we can propose a proper solution, no? People will complain anyways | 11:49 |
| robcresswell | Its more that if we rewrite settings and tell everyone they have to port to .ini, we'll break everything | 11:49 |
| robcresswell | Whereas, we could allow .ini settings and advise people to use the new format. | 11:49 |
| *** mpavlase has quit IRC | 11:50 | |
| robcresswell | Its just early thoughts anyway, I'd like to discuss at the summit. I don't know enough about who would break | 11:50 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 11:50 |
| *** mpavlase has joined #openstack-horizon | 11:51 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 11:51 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 11:52 |
| mrunge | robcresswell, there is already another bp: https://blueprints.launchpad.net/horizon/+spec/ini-based-configuration | 11:52 |
| robcresswell | ah interesting | 11:53 |
| mrunge | that predates oslo.config iirc | 11:53 |
| mrunge | ah, nope. radomir changed that | 11:53 |
| *** Daisy has joined #openstack-horizon | 11:54 | |
| *** Daisy has quit IRC | 12:01 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Test for images (create volume/launch instance from image) https://review.openstack.org/273467 | 12:02 |
| *** Daisy has joined #openstack-horizon | 12:02 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:05 | |
| *** mvk has quit IRC | 12:13 | |
| *** ericksonsantos has joined #openstack-horizon | 12:13 | |
| *** mvk has joined #openstack-horizon | 12:15 | |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Added test for check instances pagination functionality https://review.openstack.org/269488 | 12:17 |
| *** lblanchard has joined #openstack-horizon | 12:17 | |
| *** pcaruana has joined #openstack-horizon | 12:18 | |
| Anticimex | in liberty's angularjs instance launch, there is confusion about image sizes units | 12:19 |
| Anticimex | "Allocated" and "Available" lists using GiB, MiB, i.e. 2-base, but Boot Source volume size uses 10-base | 12:20 |
| Anticimex | perhaps fixed in master *shrug* | 12:20 |
| Anticimex | though the min-size warning in Boot Source's Size (GB) field is using the same unit as the size picker | 12:21 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 12:21 |
| *** Daisy has quit IRC | 12:22 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for changing password for newly created user https://review.openstack.org/274659 | 12:22 |
| *** Daisy has joined #openstack-horizon | 12:23 | |
| robcresswell | Anticimex: This was an issue across all of Horizon IIRC | 12:24 |
| robcresswell | I don't know if its still present in master, its not something I've been tracking | 12:24 |
| Anticimex | ack | 12:24 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check availability resources for projects https://review.openstack.org/269703 | 12:25 |
| *** Daisy has quit IRC | 12:27 | |
| *** yamamoto has joined #openstack-horizon | 12:30 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check availability resources for projects https://review.openstack.org/269703 | 12:30 |
| *** ccesario has joined #openstack-horizon | 12:31 | |
| mrunge | Anticimex, iirc, that has been unified | 12:34 |
| *** ccesario has quit IRC | 12:36 | |
| Anticimex | cool | 12:38 |
| *** Daisy has joined #openstack-horizon | 12:39 | |
| *** leitan_ has joined #openstack-horizon | 12:39 | |
| *** archers has joined #openstack-horizon | 12:41 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to verify disabling and then enabling user https://review.openstack.org/275206 | 12:42 |
| *** Daisy has quit IRC | 12:43 | |
| *** archers has quit IRC | 12:43 | |
| *** jprovazn has joined #openstack-horizon | 12:54 | |
| *** mvk has quit IRC | 13:02 | |
| *** davechen has joined #openstack-horizon | 13:03 | |
| *** julim has joined #openstack-horizon | 13:05 | |
| *** vgridnev has quit IRC | 13:05 | |
| *** mvk has joined #openstack-horizon | 13:05 | |
| *** zhurong has joined #openstack-horizon | 13:05 | |
| *** vgridnev has joined #openstack-horizon | 13:10 | |
| *** ducttape_ has joined #openstack-horizon | 13:12 | |
| *** mflobo has left #openstack-horizon | 13:14 | |
| *** doug-fish has joined #openstack-horizon | 13:14 | |
| *** neelashah has joined #openstack-horizon | 13:18 | |
| *** neelashah has quit IRC | 13:24 | |
| *** ducttape_ has quit IRC | 13:25 | |
| *** davechen1 has joined #openstack-horizon | 13:28 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to verify disabling and then enabling user https://review.openstack.org/275206 | 13:30 |
| *** vgridnev has quit IRC | 13:30 | |
| *** davechen has quit IRC | 13:31 | |
| *** vgridnev has joined #openstack-horizon | 13:31 | |
| *** doug-fish has quit IRC | 13:34 | |
| *** davechen has joined #openstack-horizon | 13:37 | |
| *** piet has joined #openstack-horizon | 13:39 | |
| *** davechen1 has quit IRC | 13:40 | |
| *** leitan_ has quit IRC | 13:43 | |
| *** davechen has left #openstack-horizon | 13:50 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check availability resources for projects https://review.openstack.org/269703 | 13:51 |
| *** matt-borland has joined #openstack-horizon | 13:51 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 13:51 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check new project creation during new user creation. https://review.openstack.org/276640 | 13:51 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 14:01 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check availability resources for projects https://review.openstack.org/269703 | 14:02 |
| *** doug-fish has joined #openstack-horizon | 14:02 | |
| *** piet has quit IRC | 14:02 | |
| *** zhurong has quit IRC | 14:02 | |
| *** eroussel has joined #openstack-horizon | 14:03 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that user should not have ability to disable himself. https://review.openstack.org/275623 | 14:05 |
| *** neelashah has joined #openstack-horizon | 14:05 | |
| *** zhurong has joined #openstack-horizon | 14:08 | |
| *** ccesario has joined #openstack-horizon | 14:08 | |
| *** mvk has quit IRC | 14:09 | |
| *** Guest76507 is now known as med_ | 14:12 | |
| *** med_ has quit IRC | 14:12 | |
| *** med_ has joined #openstack-horizon | 14:12 | |
| *** zhurong has quit IRC | 14:14 | |
| *** petertr7_away is now known as petertr7 | 14:18 | |
| *** jpomeroy has joined #openstack-horizon | 14:18 | |
| *** neelashah has quit IRC | 14:21 | |
| *** mvk has joined #openstack-horizon | 14:21 | |
| *** itisha has joined #openstack-horizon | 14:25 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Searchlight resource-type integration https://review.openstack.org/280285 | 14:26 |
| *** peristeri has joined #openstack-horizon | 14:26 | |
| matt-borland | mrunge, thanks for the review! :) | 14:27 |
| matt-borland | TravT, I cleaned up https://review.openstack.org/#/c/280285/ and added Global Actions to the registry. | 14:27 |
| matt-borland | It's got a few little bumps but it generally works. | 14:28 |
| *** aortega has quit IRC | 14:28 | |
| *** lapalm has joined #openstack-horizon | 14:29 | |
| *** rdopiera is now known as rdopiera_adk | 14:30 | |
| *** rdopiera_adk is now known as rdopiera_afk | 14:30 | |
| *** masco has quit IRC | 14:32 | |
| *** mflobo has joined #openstack-horizon | 14:36 | |
| *** jtriley has joined #openstack-horizon | 14:37 | |
| *** vgridnev has quit IRC | 14:37 | |
| *** vgridnev has joined #openstack-horizon | 14:38 | |
| *** neelashah has joined #openstack-horizon | 14:43 | |
| *** vgridnev has quit IRC | 14:47 | |
| *** ygbo has quit IRC | 14:48 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 14:49 |
| *** vgridnev has joined #openstack-horizon | 14:49 | |
| *** piet has joined #openstack-horizon | 14:50 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 14:52 |
| *** ygbo has joined #openstack-horizon | 14:52 | |
| *** vgridnev has quit IRC | 14:52 | |
| *** jtriley has quit IRC | 14:52 | |
| *** vgridnev has joined #openstack-horizon | 14:54 | |
| *** ducttape_ has joined #openstack-horizon | 14:57 | |
| *** ducttape_ has quit IRC | 14:57 | |
| *** ducttape_ has joined #openstack-horizon | 14:57 | |
| *** mtanino has joined #openstack-horizon | 14:57 | |
| *** akulshin has joined #openstack-horizon | 14:58 | |
| *** Drago has joined #openstack-horizon | 14:59 | |
| *** Drago has quit IRC | 14:59 | |
| *** Drago has joined #openstack-horizon | 15:00 | |
| Anticimex | another oddity in liberty's angularjs launch instance panel: when creating volume from image and having flavors with root disk size = 0 GB, the panel won't let me continue. i have set volume size > image's size, which resolves a warning there | 15:00 |
| *** jtriley has joined #openstack-horizon | 15:01 | |
| *** piet has quit IRC | 15:01 | |
| *** ppiela has joined #openstack-horizon | 15:02 | |
| *** akulshin has quit IRC | 15:03 | |
| tsufiev | itxaka, now I'm confused :/ | 15:07 |
| tsufiev | do we use build libraries (as DOA) from sources in stable branches or pull them using versions? | 15:07 |
| itxaka | good point :D | 15:08 |
| itxaka | I think its versions | 15:08 |
| itxaka | so in any case doa needs to release a minor version I guess? | 15:08 |
| tsufiev | then I don't understand how direct backport is going to work | 15:08 |
| tsufiev | yes, it seems to me so | 15:08 |
| itxaka | not really sure how that works or if its possible | 15:08 |
| tsufiev | we had recently the same issue in our downstream distro | 15:09 |
| itxaka | but I think david-lyle is both on the stable team and doa team so maybe he can shed some ligth on it | 15:09 |
| tsufiev | horizon code got updated, but doa package remained the same, so a regression happened | 15:09 |
| tsufiev | ok, I'll remove my -1 and ask him there | 15:10 |
| *** wolverineav has joined #openstack-horizon | 15:10 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check availability resources for projects https://review.openstack.org/269703 | 15:10 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 15:10 |
| *** sjmc7 has joined #openstack-horizon | 15:11 | |
| *** xinwu has joined #openstack-horizon | 15:12 | |
| *** aortega has joined #openstack-horizon | 15:12 | |
| *** wolverineav has quit IRC | 15:15 | |
| Anticimex | ok my issue is around https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/flavor/flavor.controller.js#L308 | 15:15 |
| Anticimex | this seems illogical in my use case. now that i have a pointer to the code perhaps i can see if there's a launchpad bug around it already | 15:16 |
| itxaka | tsufiev, Im gonna mark it as wip until we get some more info just in case | 15:17 |
| *** vgridnev_ has joined #openstack-horizon | 15:17 | |
| itxaka | ugh, I can because its a cherry-pick ¯\_(ツ)_/¯ | 15:18 |
| itxaka | s/can/cant/g | 15:18 |
| robcresswell | tsufiev, itxaka ? | 15:19 |
| robcresswell | Reading the chat but feel like I missed something; is there a d_o_a issue? | 15:19 |
| itxaka | robcresswell, not reallky | 15:21 |
| itxaka | but I did a backport that required 2 patches into doa and one into horizon | 15:21 |
| *** vgridnev has quit IRC | 15:21 | |
| robcresswell | ah | 15:21 |
| itxaka | both doa patches got in, horizon waiting | 15:21 |
| *** Liuqing has quit IRC | 15:21 | |
| itxaka | but we dont know how that really works | 15:21 |
| itxaka | does the stable team release minor patches every X time, and so on | 15:21 |
| robcresswell | Horizon uses whatever pypi version was last released | 15:22 |
| *** piet has joined #openstack-horizon | 15:22 | |
| robcresswell | I assume | 15:22 |
| robcresswell | that stable is uncapped too, as usual | 15:22 |
| *** Liuqing has joined #openstack-horizon | 15:22 | |
| *** Liuqing has quit IRC | 15:22 | |
| itxaka | so yeah, wondering if stable needs to release a minor version of kilo doa for the horizon patch to go in, or what is the usual workflow in this case | 15:23 |
| *** hurgleburgler has joined #openstack-horizon | 15:25 | |
| robcresswell | Yeah, I believe thats how it would work | 15:25 |
| *** piet has quit IRC | 15:25 | |
| tsufiev | itxaka, aha, so horizon patch needs to be held off until an appropriate stable version of doa is released | 15:27 |
| itxaka | tsufiev, Ummm I dont know. There is not hurt into having those patches in both of the repos, unless your doa and horizon releases are not in sync | 15:28 |
| robcresswell | Well, there is, because Horizon wont pull it in by default | 15:29 |
| itxaka | if updates for doa are released first but not horizon that would probably make it fail as well, I guess :/ | 15:29 |
| robcresswell | and it might break? I havent seen the patches though | 15:29 |
| *** Mounica has joined #openstack-horizon | 15:29 | |
| itxaka | no, I dont think it will brask as there was a patch for backwards compatibility | 15:29 |
| *** bpokorny has joined #openstack-horizon | 15:29 | |
| openstackgerrit | Merged openstack/horizon: User isCurrentProject in metadata action https://review.openstack.org/279786 | 15:29 |
| itxaka | so it should be safe | 15:30 |
| robcresswell | ah okay | 15:30 |
| itxaka | I hope | 15:30 |
| * itxaka hides | 15:30 | |
| *** bpokorny has quit IRC | 15:30 | |
| robcresswell | mrunge will tell you off if you break stable :) | 15:31 |
| * Anticimex wrote up the bug (in my opinion) at https://bugs.launchpad.net/horizon/+bug/1546149 | 15:31 | |
| openstack | Launchpad bug 1546149 in OpenStack Dashboard (Horizon) "Launch from new volume fails with flavor.disksize = 0" [Undecided,New] | 15:31 |
| *** vgridnev_ has quit IRC | 15:32 | |
| *** vgridnev has joined #openstack-horizon | 15:32 | |
| tsufiev | itxaka, robcresswell: here is the problem: if the horizon patch lands, but doa patch not pulled by horizon, project list won't be updated and user will need to relogin to be able to switch to newly created project | 15:33 |
| mflobo | hi, question about plugin panels in Horizon. I have a new panel in compute group in project dashboard, but is in the last menu item position | 15:38 |
| mflobo | How could move it to the first menu postion? | 15:39 |
| mflobo | position?* | 15:39 |
| itxaka | tsufiev, only if a new kilo horizon version is launched before a new kilo doa version or if you are using horizon from source right? | 15:39 |
| robcresswell | mflobo: Just change the leading number | 15:39 |
| tsufiev | itxaka, not exactly. That boils down to the different approaches to distribution of horizon vs doa | 15:40 |
| mflobo | robcresswell, I put local/enable/_0001_my_panel.py | 15:40 |
| mflobo | is it not enough to move it firstr position apparently | 15:40 |
| tsufiev | hm... | 15:40 |
| mflobo | :) | 15:40 |
| itxaka | but indeed, doa should go always first on releasing the patched version | 15:41 |
| tsufiev | yes | 15:41 |
| * tsufiev just realized that he doesn't know how horizon in downstream repo is distributed | 15:41 | |
| mflobo | robcresswell, I'm setting bad name? | 15:42 |
| robcresswell | mflobo: local/enabled is read after /enabled | 15:43 |
| robcresswell | justu se enabled if you need to be in front | 15:43 |
| tsufiev | itxaka, how ready in your opinion is https://review.openstack.org/#/c/259013 ? | 15:44 |
| tsufiev | just checked recent integration tests pass over it, looks good to me | 15:45 |
| EmilienM | hello horizon experts, can we have an eye on https://bugs.launchpad.net/puppet-horizon/+bug/1546154 please ? And please bring thoughts | 15:45 |
| openstack | Launchpad bug 1546154 in puppet-horizon "manage.py compress --force must be called after changing theme" [Undecided,New] | 15:45 |
| tsufiev | EmilienM, hurgleburgler is our local expert on that matter ^^^ | 15:46 |
| itxaka | tsufiev, I need to give it another look to be sure that all the tests are passing correctly, number of tests are the same and so on | 15:46 |
| tsufiev | ok | 15:46 |
| itxaka | last time I checked it was ok, but I rather have another look after the rebase | 15:46 |
| itxaka | will try to do that today | 15:46 |
| mflobo | robcresswell, aha!, It worked!, thanks! :) | 15:47 |
| *** SimonChung has quit IRC | 15:48 | |
| hurgleburgler | Hmmm | 15:49 |
| *** flwang1 has joined #openstack-horizon | 15:49 | |
| hurgleburgler | EmilienM if you want to not have to run compress, then you have to turn off offline compression | 15:49 |
| EmilienM | hurgleburgler: can you reply in the LP please? so our group can see your thoughts | 15:50 |
| EmilienM | thanks a lot | 15:50 |
| *** pushkaru has joined #openstack-horizon | 15:51 | |
| hurgleburgler | Sure | 15:51 |
| hurgleburgler | EmilienM … when you said it was discussed … are you referring to Dynamic Themes? | 15:56 |
| tsufiev | hurgleburgler, 'it was discussed' is actually zigo 's words | 15:57 |
| EmilienM | hurgleburgler: I'm not refering to anything -- we just got this request in puppet-horizon and asking for your thoughts. I'm not horizon expert like you guys | 15:57 |
| hurgleburgler | EmilienM tsufiev Got it … I'll add some notes | 15:58 |
| hurgleburgler | erm, comments :) | 15:59 |
| zigo | During a Horizon meeting, I raised the point that running manage.py compress --force just to change a theme was really annoying, and I was replied to "yeah, we know, it's going to be fixed". | 15:59 |
| *** kzaitsev_mb has quit IRC | 15:59 | |
| zigo | Now, we need to know if it was done or not. | 15:59 |
| zigo | itxaka: or hurgleburgler: Please write in this launchpad bug when you know. | 16:01 |
| robcresswell | zigo: The themes patch is up now. | 16:01 |
| zigo | Ah, cool! :) | 16:01 |
| zigo | robcresswell: About Django 1.9, do we have any progress, or is it stalled? | 16:01 |
| *** vijendar has joined #openstack-horizon | 16:01 | |
| robcresswell | zigo: Final patch is nearly complete: https://review.openstack.org/#/c/280222/ | 16:02 |
| zigo | Super nice! | 16:02 |
| zigo | I'll try then. | 16:02 |
| robcresswell | Something like 3 errors left under 1.9. Just a couple more tweaks. | 16:02 |
| itxaka | "nearly" | 16:02 |
| *** mflobo has quit IRC | 16:02 | |
| itxaka | :D | 16:02 |
| robcresswell | haha | 16:02 |
| itxaka | I like your positivity :P | 16:02 |
| robcresswell | I'm sure last time I ran it, had something like 5 errors | 16:03 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: [WIP] Fix remaining Django 1.9 test failures https://review.openstack.org/280222 | 16:03 |
| robcresswell | Considering it started as 1400, I'm feeling good. | 16:03 |
| *** rdopiera_afk is now known as rdopiera | 16:04 | |
| *** vijendar1 has joined #openstack-horizon | 16:04 | |
| *** vijendar has quit IRC | 16:07 | |
| zigo | robcresswell: Do you believe that plugins will need fixes too? There's quite a bunch of them these days ... | 16:08 |
| robcresswell | I imagine so | 16:09 |
| robcresswell | zigo: Though our link to plugins is fairly poor right now, in the sense that we don't really guarantee any level of functionality or quality. | 16:10 |
| zigo | robcresswell: Which is why I do not like having plugins. | 16:10 |
| zigo | robcresswell: The same way getting stuff out of Neutron tree, quality will be a lot lower for sure. | 16:11 |
| robcresswell | No way around it with big tent | 16:11 |
| zigo | Yeah, sure, I understand... | 16:12 |
| zigo | Though I probably would have prefer a smaller tent if we were sure to keep it water tight this way. | 16:12 |
| robcresswell | You're not alone in that thinking ;) | 16:13 |
| zigo | robcresswell: BTW, I do regret I couldn't spend more time on Django 1.9 patching, though I've been given 20 days to work on Fuel master node porting to Debian before the Mitaka b3 release, so I got busy doing that. | 16:14 |
| robcresswell | zigo: No problem, 'twas my responsibility. I'll need to address faster next time. I've already got 3 patches for 1.10. No N-3 release this time. | 16:15 |
| *** pcaruana has quit IRC | 16:18 | |
| *** eroussel has quit IRC | 16:21 | |
| *** mvk has quit IRC | 16:21 | |
| *** Drago has quit IRC | 16:24 | |
| *** alexvictorchan has quit IRC | 16:26 | |
| *** SimonChung has joined #openstack-horizon | 16:26 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: [WIP] Fix remaining Django 1.9 test failures https://review.openstack.org/280222 | 16:27 |
| *** agireud has quit IRC | 16:31 | |
| *** agireud has joined #openstack-horizon | 16:32 | |
| *** rcernin has quit IRC | 16:37 | |
| *** donu7 has joined #openstack-horizon | 16:47 | |
| *** vgridnev has quit IRC | 16:49 | |
| sjmc7 | Trav | 16:56 |
| sjmc7 | oops, sorry, wrong room | 16:56 |
| *** Drago has joined #openstack-horizon | 16:57 | |
| *** vishwanathj has joined #openstack-horizon | 16:57 | |
| *** kzaitsev_mb has joined #openstack-horizon | 16:58 | |
| *** Drago has quit IRC | 17:03 | |
| *** lapalm_ has joined #openstack-horizon | 17:03 | |
| *** Drago has joined #openstack-horizon | 17:03 | |
| *** e0ne has quit IRC | 17:04 | |
| matt-borland | robcresswell, if you're interested, I put up a patch to clear up the 'row-action' 'batch-action' services and just expose actions via a registry: https://review.openstack.org/#/c/278447/ | 17:04 |
| matt-borland | I'm looking to TravT, r1chardj0n3s and jpomeroy for input. It seems pretty useful. | 17:05 |
| *** gyee has joined #openstack-horizon | 17:05 | |
| *** lapalm has quit IRC | 17:06 | |
| *** dan_nguyen has joined #openstack-horizon | 17:07 | |
| *** mpavlase has quit IRC | 17:08 | |
| *** jprovazn has quit IRC | 17:08 | |
| *** rcernin has joined #openstack-horizon | 17:09 | |
| *** alexvictorchan has joined #openstack-horizon | 17:11 | |
| *** wolverineav has joined #openstack-horizon | 17:12 | |
| *** sjmc7 has quit IRC | 17:13 | |
| *** sjmc7 has joined #openstack-horizon | 17:14 | |
| *** eroussel has joined #openstack-horizon | 17:14 | |
| *** roxanaghe has joined #openstack-horizon | 17:15 | |
| *** wolverineav has quit IRC | 17:16 | |
| *** ygbo has quit IRC | 17:21 | |
| *** lhcheng has joined #openstack-horizon | 17:21 | |
| *** garthb has joined #openstack-horizon | 17:22 | |
| *** jbell8 has joined #openstack-horizon | 17:24 | |
| *** lapalm_ has quit IRC | 17:25 | |
| *** flwang1 has quit IRC | 17:25 | |
| *** ybathia has joined #openstack-horizon | 17:26 | |
| *** lapalm has joined #openstack-horizon | 17:26 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Ignore local folder https://review.openstack.org/280840 | 17:28 |
| *** tqtran has joined #openstack-horizon | 17:30 | |
| *** petertr7 is now known as petertr7_away | 17:34 | |
| *** wolverineav has joined #openstack-horizon | 17:36 | |
| *** jtriley has quit IRC | 17:36 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Running eslint in quiet mode https://review.openstack.org/280842 | 17:39 |
| *** jtriley has joined #openstack-horizon | 17:41 | |
| *** roxanaghe has quit IRC | 17:42 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Updating password in local_conf https://review.openstack.org/275395 | 17:44 |
| *** Mounica has quit IRC | 17:47 | |
| *** e0ne has joined #openstack-horizon | 17:47 | |
| *** Mounica has joined #openstack-horizon | 17:48 | |
| matt-borland | TravT, FYI I verified why you don't get the Type facet again after a Type search, it's exactly what I thought. | 17:49 |
| TravT | oh yeah, easy fix? | 17:49 |
| matt-borland | Well, it's "not a bug" in so far as it's doing what it 'should do' in most cases. | 17:50 |
| matt-borland | the question is more, how do we inform it not to clean up the facet choices? | 17:50 |
| matt-borland | most of the time we do want to auto-remove options that have been selected. | 17:50 |
| matt-borland | doesn't matter to me how it operates, I just need something that indicates that either: | 17:51 |
| TravT | i'd vote for a property | 17:51 |
| matt-borland | a) the field should be specifically allowed | 17:51 |
| matt-borland | b) that all facets returned in this case are allowed | 17:51 |
| matt-borland | I like properties. :) | 17:51 |
| matt-borland | how about I propose something in a that patch? :) | 17:51 |
| TravT | makes sense to me | 17:51 |
| matt-borland | cool, also if you didn't see, I got the Global Actions (mostly) working | 17:52 |
| matt-borland | there's a slight bug with LI that causes it to spew a message the first time you load it | 17:52 |
| matt-borland | but it looks good and mostly works | 17:53 |
| TravT | cool, definitely trying to get to it this morning. | 17:53 |
| *** petertr7_away is now known as petertr7 | 17:54 | |
| matt-borland | TravT, FYI I'll just comment out the clearing code from the MS patch so it works well, and we can figure out details about how to switch it later. | 17:56 |
| matt-borland | it won' | 17:56 |
| matt-borland | it won't hurt much to do that. | 17:56 |
| TravT | ok | 17:57 |
| *** vijendar1 has quit IRC | 18:01 | |
| *** jtriley has quit IRC | 18:01 | |
| *** vijendar has joined #openstack-horizon | 18:02 | |
| *** mayurig has joined #openstack-horizon | 18:03 | |
| *** vgridnev has joined #openstack-horizon | 18:03 | |
| *** SimonChung has quit IRC | 18:04 | |
| *** SimonChung1 has joined #openstack-horizon | 18:04 | |
| *** yamamoto has quit IRC | 18:05 | |
| *** yamamoto has joined #openstack-horizon | 18:10 | |
| *** bpokorny has joined #openstack-horizon | 18:11 | |
| *** wolverineav has quit IRC | 18:19 | |
| *** bpokorny has quit IRC | 18:19 | |
| *** bpokorny has joined #openstack-horizon | 18:20 | |
| *** kzaitsev_mb has quit IRC | 18:23 | |
| *** jtriley has joined #openstack-horizon | 18:25 | |
| *** david-lyle has quit IRC | 18:27 | |
| matt-borland | TravT, hrm, on further investigation it does seem it respects the singleton property | 18:29 |
| matt-borland | so you want to send the singleton as 'False' for Trye. | 18:29 |
| matt-borland | 'Type" | 18:29 |
| matt-borland | TravT, what is generating that value for Type? | 18:30 |
| TravT | i think facet utlis | 18:32 |
| TravT | let me see | 18:32 |
| TravT | https://review.openstack.org/#/c/227036/33/openstack_dashboard/dashboards/project/static/dashboard/project/search/util/searchlight-facet-utils.service.js | 18:32 |
| TravT | line 334 | 18:32 |
| *** sjmc7 has quit IRC | 18:33 | |
| *** e0ne has quit IRC | 18:33 | |
| matt-borland | yeah, just change that to False. | 18:33 |
| matt-borland | it works. | 18:34 |
| matt-borland | just like it was meant to ! :) | 18:34 |
| matt-borland | sorry about the confusion there. | 18:34 |
| *** neelashah has quit IRC | 18:34 | |
| matt-borland | I guess I prefer an easy solution TravT :) | 18:34 |
| *** mpavlase has joined #openstack-horizon | 18:34 | |
| *** jtriley has quit IRC | 18:35 | |
| *** david-lyle has joined #openstack-horizon | 18:35 | |
| *** ChanServ sets mode: +o david-lyle | 18:35 | |
| matt-borland | I think there was a bug in the GitHub code that didn't respect the singleton value and just kept the facet. | 18:36 |
| matt-borland | I fixed that, and in doing so exposed the fact that the setting was wrong in the implementing code | 18:36 |
| *** kzaitsev_mb has joined #openstack-horizon | 18:36 | |
| TravT | so, my original thoughts on the purpose of singleton were correct? | 18:37 |
| matt-borland | yep :) | 18:37 |
| matt-borland | I had got confused. | 18:37 |
| matt-borland | We were *both* right! | 18:37 |
| matt-borland | jk | 18:37 |
| TravT | yeah and I think that i have a bug above | 18:37 |
| TravT | because it is defaulting to true right now | 18:37 |
| matt-borland | so yeah, singleton means "you can only select one option for this facet" | 18:37 |
| TravT | that's what i thought... | 18:38 |
| matt-borland | which is horrible terminology, but so be it :) | 18:38 |
| matt-borland | so I think that means that the MS patch is hunky dory. | 18:38 |
| matt-borland | robcresswell, do you use that term? ^^ | 18:38 |
| TravT | very easy to get a little confused. | 18:38 |
| *** jtriley has joined #openstack-horizon | 18:39 | |
| itxaka | robcresswell, good news, django 1.9 tests now pass! bad news, I broke the other django 1.8, python27 and python34 tests! :D | 18:40 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: [WIP] Fix remaining Django 1.9 test failures https://review.openstack.org/280222 | 18:41 |
| *** wolverineav has joined #openstack-horizon | 18:41 | |
| *** vijendar has quit IRC | 18:42 | |
| *** wolverineav has quit IRC | 18:42 | |
| *** wolverineav has joined #openstack-horizon | 18:42 | |
| openstackgerrit | Elena S proposed openstack/horizon: Added router set/clear gateway test. https://review.openstack.org/266776 | 18:43 |
| *** mayurig has quit IRC | 18:44 | |
| *** petertr7 is now known as petertr7_away | 18:44 | |
| robcresswell | itxaka: Wrap everything in if django.VERSION >= (1, 9) and call it a day? XD | 18:45 |
| itxaka | yeah that would be nice :D | 18:46 |
| itxaka | will keep working a bit on it, see if I can fix it so works both ways | 18:47 |
| *** roxanaghe has joined #openstack-horizon | 18:48 | |
| *** yamamoto has quit IRC | 18:49 | |
| *** roxanaghe has quit IRC | 18:51 | |
| *** garthb_ has joined #openstack-horizon | 18:55 | |
| *** garthb has quit IRC | 18:57 | |
| *** SimonChung has joined #openstack-horizon | 18:59 | |
| *** SimonChung1 has quit IRC | 18:59 | |
| *** jbell8 has quit IRC | 19:00 | |
| *** neelashah has joined #openstack-horizon | 19:00 | |
| matt-borland | krotscheck, | 19:01 |
| matt-borland | are you a stackalytics core? | 19:01 |
| krotscheck | Yeeees? | 19:01 |
| krotscheck | No. | 19:01 |
| krotscheck | Why? | 19:01 |
| * krotscheck avoids being a core like the plague. | 19:01 | |
| matt-borland | eh, just wanted to push my stackalytics personal entry thru | 19:01 |
| matt-borland | had no response on the IRC | 19:01 |
| matt-borland | thanks! :) | 19:02 |
| krotscheck | matt-borland: Wish I could help :/ | 19:02 |
| matt-borland | np | 19:02 |
| *** SimonChung1 has joined #openstack-horizon | 19:02 | |
| *** SimonChung has quit IRC | 19:02 | |
| *** kzaitsev_mb has quit IRC | 19:04 | |
| *** sjmc7 has joined #openstack-horizon | 19:06 | |
| *** vijendar has joined #openstack-horizon | 19:09 | |
| *** vijendar1 has joined #openstack-horizon | 19:10 | |
| *** jtriley has quit IRC | 19:11 | |
| *** SimonChung1 has quit IRC | 19:11 | |
| *** patk has joined #openstack-horizon | 19:12 | |
| tqtran | matt-borland: you need a battering ram in order to push it through | 19:12 |
| itxaka | robcresswell, last commit fixed all the issues in the other tests so everything should be passing now \o/ | 19:13 |
| matt-borland | tqtran, good to know! :) | 19:13 |
| *** rdopiera has quit IRC | 19:13 | |
| *** ybathia has quit IRC | 19:13 | |
| *** vijendar has quit IRC | 19:14 | |
| *** vgridnev has quit IRC | 19:14 | |
| robcresswell | itxaka: That's awesome. | 19:16 |
| robcresswell | itxaka: Really appreciate it | 19:16 |
| matt-borland | woot woot! | 19:16 |
| itxaka | robcresswell, now we need to find the real issue behind the double calls..only... :D | 19:17 |
| robcresswell | itxaka: I was just reading your comment about the heat issue. Nice find. I was stuck on that for a good while. | 19:18 |
| tqtran | david-lyle: ping pong | 19:18 |
| *** jtriley has joined #openstack-horizon | 19:19 | |
| robcresswell | itxaka: Just need a requirements bump and d_o_a release now. | 19:20 |
| *** jtomasek_ has joined #openstack-horizon | 19:28 | |
| *** vijendar1 has quit IRC | 19:29 | |
| *** roxanaghe has joined #openstack-horizon | 19:34 | |
| *** jtriley has quit IRC | 19:35 | |
| *** roxanaghe has quit IRC | 19:36 | |
| *** itxaka has quit IRC | 19:37 | |
| *** vijendar has joined #openstack-horizon | 19:37 | |
| *** petertr7_away is now known as petertr7 | 19:41 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Update URLs to Django 1.8+ style https://review.openstack.org/280901 | 19:41 |
| openstackgerrit | Rob Cresswell proposed openstack/django_openstack_auth: Update URLs to Django 1.8+ style https://review.openstack.org/280902 | 19:42 |
| *** roxanaghe has joined #openstack-horizon | 19:42 | |
| *** SimonChung has joined #openstack-horizon | 19:45 | |
| *** vijendar has quit IRC | 19:46 | |
| *** yamamoto has joined #openstack-horizon | 19:50 | |
| *** petertr7 is now known as petertr7_away | 19:51 | |
| *** vgridnev has joined #openstack-horizon | 19:54 | |
| *** yamamoto has quit IRC | 19:56 | |
| *** gariveradlt has joined #openstack-horizon | 20:00 | |
| *** vgridnev has quit IRC | 20:01 | |
| *** e0ne has joined #openstack-horizon | 20:02 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API for getting and updating quotas https://review.openstack.org/207126 | 20:03 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel subflows for admin https://review.openstack.org/234986 | 20:03 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel for admin https://review.openstack.org/205296 | 20:03 |
| *** neelashah has quit IRC | 20:03 | |
| *** petertr7_away is now known as petertr7 | 20:04 | |
| *** e0ne has quit IRC | 20:05 | |
| *** neelashah has joined #openstack-horizon | 20:05 | |
| *** sambetts is now known as sambetts|afk | 20:12 | |
| r1chardj0n3s | morning | 20:13 |
| r1chardj0n3s | matt-borland / TravT: I need to pick brains about the action list widget when I've woken up a bit more, please. The implementation is ... opaque, and I cannot seem to implement my own button HTML :/ | 20:14 |
| matt-borland | r1chardj0n3s, exactly, I agree the actions services are unnecesary and problematic | 20:15 |
| matt-borland | (hence the registry patch) | 20:16 |
| r1chardj0n3s | um | 20:16 |
| TravT | r1chardj0n3s: are you talking the Actions directive? | 20:16 |
| r1chardj0n3s | matt-borland, TravT: yes, I'm speaking of the actions directive; I have some actions services implemented but I'm trying to implement a custom button HTML for an action and setting the url to my custom template isn't working and I have no idea why | 20:17 |
| r1chardj0n3s | afaict the registry won't change this in the slightest | 20:17 |
| *** wolverin_ has joined #openstack-horizon | 20:17 | |
| r1chardj0n3s | though maybe it'll have clearer docs? | 20:17 |
| matt-borland | r1chardj0n3s, sorry, is there a patch I can take a look at? | 20:17 |
| r1chardj0n3s | I tried to get rajat to write clear docs, and they *seemed* clear at the time ;-) | 20:18 |
| matt-borland | heh heh | 20:18 |
| *** garthb_ has quit IRC | 20:18 | |
| *** garthb__ has joined #openstack-horizon | 20:18 | |
| matt-borland | yeah, whatever I can help with in regard to actions...I want those cleaned up/documented accordingly | 20:18 |
| *** david-lyle has quit IRC | 20:18 | |
| *** vijendar has joined #openstack-horizon | 20:19 | |
| r1chardj0n3s | matt-borland: I'm just pushing up the latest swift ui, which includes my attempt at custom action HTML | 20:19 |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP: Add ngSwift object actions https://review.openstack.org/270553 | 20:19 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift containers and objects display https://review.openstack.org/259231 | 20:19 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift Django Interface https://review.openstack.org/258769 | 20:19 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift container actions https://review.openstack.org/259236 | 20:19 |
| matt-borland | cool...look at that chain! | 20:19 |
| r1chardj0n3s | please grab the WIP patch | 20:19 |
| matt-borland | yep. In meetings a bit today, will take a look when I can | 20:19 |
| r1chardj0n3s | and you'll need to enable _1921_project_ng_containers_panel.py | 20:20 |
| *** wolverineav has quit IRC | 20:20 | |
| *** wolverin_ has quit IRC | 20:21 | |
| r1chardj0n3s | the key bit is https://review.openstack.org/#/c/270553/17/openstack_dashboard/dashboards/project/static/dashboard/project/containers/objects-row-actions.service.js which points at a dummy (for now) html template which not only doesn't appear, but the presence of that action causes the rest of the actions to no longer render too :/ | 20:21 |
| r1chardj0n3s | and there's no exception (thanks Javascript) | 20:21 |
| r1chardj0n3s | implicit undefined is the worst thing ever (hated it in Perl, hate it in Javascript) | 20:22 |
| *** SimonChung has quit IRC | 20:22 | |
| *** SimonChung1 has joined #openstack-horizon | 20:22 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 20:24 |
| TravT | r1chardj0n3s: that almost sounds like some promise is never resolving | 20:25 |
| TravT | total guess without looking | 20:25 |
| r1chardj0n3s | seems a reasonable guess | 20:25 |
| *** mayurig has joined #openstack-horizon | 20:25 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check availability resources for projects https://review.openstack.org/269703 | 20:26 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 20:27 |
| *** wolverineav has joined #openstack-horizon | 20:39 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:40 | |
| *** Mounica has quit IRC | 20:42 | |
| *** flwang1 has joined #openstack-horizon | 20:43 | |
| *** wolverineav has quit IRC | 20:43 | |
| *** wolverineav has joined #openstack-horizon | 20:43 | |
| *** ArcTanSusan has joined #openstack-horizon | 20:47 | |
| ArcTanSusan | Hii!!! | 20:47 |
| *** SimonChung has joined #openstack-horizon | 20:48 | |
| *** SimonChung1 has quit IRC | 20:48 | |
| *** garthb__ has quit IRC | 20:51 | |
| *** gyee has quit IRC | 20:54 | |
| openstackgerrit | Roxana Gherle proposed openstack/horizon: Add a configurable websso keystone url https://review.openstack.org/279355 | 20:59 |
| *** ArcTanSusan has quit IRC | 21:00 | |
| *** ArcTanSusan has joined #openstack-horizon | 21:03 | |
| *** jbell8 has joined #openstack-horizon | 21:05 | |
| *** wolverineav has quit IRC | 21:11 | |
| stevemar | ArcTanSusan: o/ | 21:12 |
| *** jtriley has joined #openstack-horizon | 21:13 | |
| *** bpokorny has quit IRC | 21:14 | |
| matt-borland | robcresswell, are you planning on having https://review.openstack.org/#/c/246625/ ready by the midcycle? | 21:19 |
| matt-borland | I'd love to give it a nice walkthru once you feel it's ready | 21:20 |
| *** neelashah has quit IRC | 21:20 | |
| *** roxanaghe has quit IRC | 21:23 | |
| *** garthb has joined #openstack-horizon | 21:24 | |
| *** Mounica has joined #openstack-horizon | 21:27 | |
| *** SimonChung has quit IRC | 21:27 | |
| *** Mounica has quit IRC | 21:27 | |
| *** SimonChung1 has joined #openstack-horizon | 21:27 | |
| r1chardj0n3s | looks like a good one to push through, yeah | 21:30 |
| *** bpokorny has joined #openstack-horizon | 21:34 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Updates horizon's copy of the cinder policy file https://review.openstack.org/249379 | 21:36 |
| *** vijendar has quit IRC | 21:37 | |
| *** jtomasek_ has quit IRC | 21:39 | |
| *** Mounica has joined #openstack-horizon | 21:45 | |
| *** jtriley has quit IRC | 21:46 | |
| *** wolverineav has joined #openstack-horizon | 21:46 | |
| *** wolverineav has quit IRC | 21:46 | |
| *** wolverineav has joined #openstack-horizon | 21:46 | |
| *** vijendar has joined #openstack-horizon | 21:48 | |
| *** gyee has joined #openstack-horizon | 21:50 | |
| *** neelashah has joined #openstack-horizon | 21:52 | |
| *** jtriley has joined #openstack-horizon | 21:53 | |
| *** roxanaghe has joined #openstack-horizon | 21:55 | |
| *** roxanaghe has quit IRC | 21:56 | |
| *** roxanaghe has joined #openstack-horizon | 21:57 | |
| *** jtomasek has quit IRC | 21:58 | |
| *** david-lyle has joined #openstack-horizon | 22:05 | |
| *** ZZelle_ has joined #openstack-horizon | 22:06 | |
| *** eroussel has quit IRC | 22:07 | |
| *** vishwanathj has quit IRC | 22:08 | |
| r1chardj0n3s | hmm, the pep8 test on https://review.openstack.org/#/c/259236/ consistently fails with a bizarro UnicodeDecodeError in PO file handling http://logs.openstack.org/36/259236/31/check/gate-horizon-pep8/cc74655/console.html#_2016-02-16_21_36_42_940 | 22:08 |
| r1chardj0n3s | any help deciphering / fixing that would be appreciated | 22:09 |
| r1chardj0n3s | I can't reproduce the failure locally | 22:09 |
| *** eroussel has joined #openstack-horizon | 22:10 | |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Add REST API for working with floating IPs https://review.openstack.org/280955 | 22:11 |
| *** david-lyle_ has joined #openstack-horizon | 22:16 | |
| *** petertr7 is now known as petertr7_away | 22:17 | |
| *** david-lyle has quit IRC | 22:20 | |
| *** onovy has quit IRC | 22:24 | |
| *** onovy has joined #openstack-horizon | 22:28 | |
| *** jtriley has quit IRC | 22:28 | |
| *** eroussel has quit IRC | 22:31 | |
| *** lapalm has quit IRC | 22:32 | |
| *** garthb has quit IRC | 22:33 | |
| *** lblanchard has quit IRC | 22:35 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: WIP Searchlight Search Panel https://review.openstack.org/227036 | 22:36 |
| *** Mounica has quit IRC | 22:46 | |
| *** Mounica has joined #openstack-horizon | 22:52 | |
| *** peristeri has quit IRC | 22:53 | |
| *** pece has quit IRC | 22:57 | |
| *** wolverin_ has joined #openstack-horizon | 23:02 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Updates horizon's copy of the cinder policy file https://review.openstack.org/249379 | 23:03 |
| *** wolverin_ has quit IRC | 23:03 | |
| *** wolverineav has quit IRC | 23:04 | |
| *** david-lyle_ has quit IRC | 23:05 | |
| *** david-lyle_ has joined #openstack-horizon | 23:05 | |
| r1chardj0n3s | matt-borland: please to not disappear before helping me with actions :-) | 23:08 |
| *** wolverineav has joined #openstack-horizon | 23:11 | |
| *** david-lyle_ has quit IRC | 23:12 | |
| *** wolverineav has quit IRC | 23:14 | |
| matt-borland | hey r1chardj0n3s ! | 23:17 |
| r1chardj0n3s | matt-borland: hey! | 23:17 |
| matt-borland | OK, let me take a look at that patch. | 23:17 |
| r1chardj0n3s | got the links, or should I re-post? | 23:17 |
| *** rcernin has quit IRC | 23:18 | |
| *** sjmc7 has quit IRC | 23:18 | |
| matt-borland | I just need the panel activation I think... | 23:19 |
| r1chardj0n3s | _1921_project_ng_containers_panel.py | 23:19 |
| *** Mounica has quit IRC | 23:19 | |
| matt-borland | thx | 23:19 |
| r1chardj0n3s | I learned yesterday that you can copy that file to openstack_dashboard/local/enabled and enable it there | 23:19 |
| *** flwang has quit IRC | 23:19 | |
| *** pushkaru has quit IRC | 23:20 | |
| r1chardj0n3s | I added a .gitignore for openstack_dashboard/local/enabled/*panel.py to my patch chain too | 23:20 |
| matt-borland | eesh, I wonder if I have switft... | 23:20 |
| r1chardj0n3s | you're not running OSA? for shame :-) | 23:20 |
| *** pushkaru has joined #openstack-horizon | 23:20 | |
| matt-borland | I'll just have to run the code in my head. :) Taking a look. | 23:20 |
| r1chardj0n3s | argh, somehow in my fiddling I've broken upload in that patch :/ | 23:21 |
| * matt-borland reading back... | 23:22 | |
| r1chardj0n3s | so I can see the page loading the fragments for the actions: | 23:22 |
| r1chardj0n3s | [16/Feb/2016 23:21:54] "GET /static/dashboard/project/containers/download-action.html HTTP/1.1" 200 6 | 23:22 |
| r1chardj0n3s | [16/Feb/2016 23:21:54] "GET /static/framework/widgets/action-list/menu-item.html HTTP/1.1" 200 238 | 23:22 |
| r1chardj0n3s | [16/Feb/2016 23:21:54] "GET /static/framework/widgets/action-list/menu.html HTTP/1.1" 200 64 | 23:22 |
| *** wolverineav has joined #openstack-horizon | 23:22 | |
| r1chardj0n3s | download-action is the custom HTML I'm trying to use | 23:22 |
| r1chardj0n3s | but the result is that the action list button just doesn't render at all | 23:23 |
| matt-borland | specifically, the download service, right? | 23:24 |
| r1chardj0n3s | I can see the <actions> tag in the DOM, but it's not being rendered, and the custom HTML action isn't in the DOM at all | 23:24 |
| r1chardj0n3s | yep | 23:24 |
| matt-borland | k | 23:24 |
| matt-borland | ah | 23:27 |
| r1chardj0n3s | ah! | 23:27 |
| *** garthb has joined #openstack-horizon | 23:27 | |
| *** jbell8_ has joined #openstack-horizon | 23:28 | |
| matt-borland | Hm. I wonder if you add an initScope if that helps...I recall something horrendous where if something was missing (scope? initScope?) in some contexts it just silently passed thru and did nothing. | 23:29 |
| *** jtriley has joined #openstack-horizon | 23:29 | |
| *** jbell8_ has quit IRC | 23:29 | |
| matt-borland | although that seems different from what we have here. | 23:29 |
| matt-borland | doesn't make sense... | 23:29 |
| matt-borland | there were some things in the actions handlers where if something expected wasn't present, it just wandered off and did nothing. | 23:30 |
| matt-borland | because of course we don't log things. | 23:30 |
| *** gyee_ has joined #openstack-horizon | 23:30 | |
| *** andrewbogott_ has joined #openstack-horizon | 23:30 | |
| r1chardj0n3s | hmm, ok, will have a look | 23:30 |
| *** DuncanT_ has joined #openstack-horizon | 23:30 | |
| *** ducttape_ has quit IRC | 23:31 | |
| matt-borland | oh, wait | 23:31 |
| r1chardj0n3s | I also find it confusing to work through because we effectively have two separate "action list" implementations sharing the same directory/namespace | 23:31 |
| matt-borland | nm, sorry, real-time code-reading without running | 23:31 |
| *** Mounica has joined #openstack-horizon | 23:31 | |
| r1chardj0n3s | np :-) | 23:31 |
| *** Mounica has quit IRC | 23:31 | |
| matt-borland | as a side note, | 23:32 |
| r1chardj0n3s | I think I'm gonna add some logging to actions | 23:32 |
| *** jpomeroy has quit IRC | 23:32 | |
| *** flwang has joined #openstack-horizon | 23:33 | |
| *** jtriley has quit IRC | 23:34 | |
| *** m3m0 has joined #openstack-horizon | 23:34 | |
| *** EmilienM_ has joined #openstack-horizon | 23:35 | |
| *** wasmum- has joined #openstack-horizon | 23:35 | |
| *** clayton_ has joined #openstack-horizon | 23:36 | |
| matt-borland | so, barring other things, I'm assuming file.is_object is in fact a boolean in all cases? | 23:36 |
| r1chardj0n3s | yes | 23:36 |
| r1chardj0n3s | hmm | 23:36 |
| r1chardj0n3s | lemme double check, might be undefined | 23:37 |
| *** gyee has quit IRC | 23:37 | |
| *** jbell8 has quit IRC | 23:37 | |
| *** gariveradlt has quit IRC | 23:37 | |
| *** ccesario has quit IRC | 23:37 | |
| *** wasmum has quit IRC | 23:37 | |
| *** clayton has quit IRC | 23:37 | |
| *** andrewbogott has quit IRC | 23:37 | |
| *** EmilienM has quit IRC | 23:37 | |
| *** jrist has quit IRC | 23:37 | |
| *** m3m0_ has quit IRC | 23:37 | |
| *** mdavidson has quit IRC | 23:37 | |
| *** DuncanT has quit IRC | 23:37 | |
| *** ameade has quit IRC | 23:37 | |
| *** clayton_ is now known as clayton | 23:37 | |
| *** EmilienM_ is now known as EmilienM | 23:37 | |
| r1chardj0n3s | (rather than false) | 23:37 |
| matt-borland | I mean, should be handled either way, but may pose complexities | 23:37 |
| *** EmilienM is now known as Guest28836 | 23:37 | |
| *** roxanaghe has quit IRC | 23:38 | |
| matt-borland | also, | 23:38 |
| matt-borland | if I set perform: angular.noop for any action | 23:39 |
| *** wolverineav has quit IRC | 23:39 | |
| matt-borland | it seems to fail. | 23:39 |
| *** wolverineav has joined #openstack-horizon | 23:39 | |
| matt-borland | e.g. Cannot read property 'then' of undefined | 23:39 |
| r1chardj0n3s | hmm, right. so actions *have* to have a perform, even if there's no perform. | 23:39 |
| r1chardj0n3s | hmm | 23:39 |
| r1chardj0n3s | (download rendering is intended to create a direct <a> link for the download) | 23:40 |
| *** andrewbogott_ is now known as andrewbogott | 23:40 | |
| r1chardj0n3s | is_object is always a boolean, fyi | 23:40 |
| *** Guest28836 has quit IRC | 23:41 | |
| *** Guest28836 has joined #openstack-horizon | 23:41 | |
| *** neelashah has quit IRC | 23:41 | |
| *** david-lyle_ has joined #openstack-horizon | 23:41 | |
| *** roxanaghe has joined #openstack-horizon | 23:41 | |
| matt-borland | hrm, experimenting... | 23:41 |
| *** Drago has quit IRC | 23:42 | |
| *** Guest28836 is now known as EmilienM | 23:42 | |
| matt-borland | erm, i was wrong about perform/noop. | 23:42 |
| matt-borland | getting confused late in the day apparently | 23:42 |
| *** vijendar has quit IRC | 23:42 | |
| r1chardj0n3s | :-) | 23:43 |
| *** ameade has joined #openstack-horizon | 23:43 | |
| *** mdavidson has joined #openstack-horizon | 23:43 | |
| *** DuncanT_ is now known as DuncanT | 23:43 | |
| *** ccesario has joined #openstack-horizon | 23:43 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add support for identity provider protocol CRUD https://review.openstack.org/248865 | 23:44 |
| *** pushkaru has quit IRC | 23:44 | |
| matt-borland | is it at all possible your downloadService refs are getting confused? | 23:44 |
| *** jrist has joined #openstack-horizon | 23:44 | |
| *** andrewbogott has quit IRC | 23:45 | |
| *** andrewbogott has joined #openstack-horizon | 23:45 | |
| *** Mounica has joined #openstack-horizon | 23:45 | |
| r1chardj0n3s | you mean that I have more than one with the same name? | 23:45 |
| *** david-lyle_ has quit IRC | 23:45 | |
| *** david-lyle_ has joined #openstack-horizon | 23:46 | |
| r1chardj0n3s | afaict I'm only creating one, called 'horizon.dashboard.project.containers.objects-actions.download' | 23:46 |
| matt-borland | well, | 23:46 |
| matt-borland | you've got the function downloadService. | 23:46 |
| matt-borland | you've also got the param downloadService. | 23:46 |
| matt-borland | I think the scoping's right | 23:46 |
| r1chardj0n3s | oic | 23:46 |
| r1chardj0n3s | yeah, separate scoping | 23:47 |
| matt-borland | I'm just going to airlift this action into something else for a minute | 23:48 |
| matt-borland | Hm, I airlift that action in place of another action (image/Launch Instance) and it 'works' fine. | 23:51 |
| matt-borland | something is going wrong in the context here. | 23:51 |
| r1chardj0n3s | yep, I'm still instrumenting some logging into actions.service.js to try to understand what it's doing and where it's all going wrong :-) | 23:51 |
| matt-borland | so, if you take that action out, other actions work? | 23:52 |
| matt-borland | or no actions work? | 23:52 |
| r1chardj0n3s | yep, they work without the download action in | 23:52 |
| matt-borland | you have found the achilles heel | 23:53 |
| r1chardj0n3s | oh, I definitely know it's the download action that's causing the problem, I just don't know why :-) | 23:53 |
| matt-borland | must be something with the template structure, not the service itself... | 23:53 |
| matt-borland | digging | 23:53 |
| r1chardj0n3s | hmm | 23:54 |
| matt-borland | where do you see examples of the url: in the template? | 23:54 |
| matt-borland | and no text? | 23:55 |
| r1chardj0n3s | I don't see them anywhere - AFAICT there are no examples of url usage at all | 23:55 |
| r1chardj0n3s | ok, so the trigger is that my download-action.html doesn't have an <action> tag in it | 23:56 |
| r1chardj0n3s | changing it to <action>HELLO</action> causes the drop-down to render correctly | 23:56 |
| matt-borland | morbidly fascinating | 23:56 |
| r1chardj0n3s | hmm. so I guess now I have to figure how to make that work for me | 23:57 |
| matt-borland | sorry about that | 23:57 |
| r1chardj0n3s | since I *do not want* a <button> | 23:57 |
| r1chardj0n3s | so, now to figure out how to make <action> generate an <a> instead, I guess | 23:57 |
| matt-borland | <action style="display: none;"> lol | 23:57 |
| r1chardj0n3s | lol | 23:58 |
| r1chardj0n3s | hmm, adding a button type might work | 23:59 |
| matt-borland | seems like it should for any action | 23:59 |
| matt-borland | I was gonna ask why it had to be a link... :) | 23:59 |
| r1chardj0n3s | it's a download link | 23:59 |
| r1chardj0n3s | so it has to be a link | 23:59 |
| matt-borland | yeah. | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!