| *** tqtran_ is now known as tqtran | 00:01 | |
| *** jtriley has quit IRC | 00:03 | |
| *** ducttape_ has joined #openstack-horizon | 00:09 | |
| *** lblanchard has joined #openstack-horizon | 00:11 | |
| *** lblanchard has quit IRC | 00:12 | |
| *** Daisy has joined #openstack-horizon | 00:14 | |
| *** sid14726 has quit IRC | 00:18 | |
| *** Daisy has quit IRC | 00:18 | |
| *** sjmc7 has quit IRC | 00:21 | |
| *** jtriley has joined #openstack-horizon | 00:26 | |
| *** lblanchard has joined #openstack-horizon | 00:30 | |
| *** ybathia has quit IRC | 00:30 | |
| *** Drago has quit IRC | 00:43 | |
| *** gariveradlt has quit IRC | 00:46 | |
| *** tyr_ has joined #openstack-horizon | 00:51 | |
| openstackgerrit | Merged openstack/horizon: Fix bug at update quota of project's network item https://review.openstack.org/240493 | 00:51 |
|---|---|---|
| *** tyr_ has quit IRC | 00:55 | |
| *** ducttape_ has quit IRC | 00:55 | |
| *** jtriley has quit IRC | 01:09 | |
| *** garthb has quit IRC | 01:12 | |
| *** btully has quit IRC | 01:14 | |
| *** jbell8 has quit IRC | 01:15 | |
| *** SimonChung has quit IRC | 01:18 | |
| *** harlowja has quit IRC | 01:18 | |
| *** chlong has joined #openstack-horizon | 01:18 | |
| *** tyr_ has joined #openstack-horizon | 01:21 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Checkboxes are now themeable. https://review.openstack.org/252161 | 01:23 |
| *** hurgleburgler has quit IRC | 01:25 | |
| *** tyr_ has quit IRC | 01:26 | |
| *** jtriley has joined #openstack-horizon | 01:32 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP: Add ngSwift object actions https://review.openstack.org/270553 | 01:32 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift containers and objects display https://review.openstack.org/259231 | 01:32 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift Django Interface https://review.openstack.org/258769 | 01:32 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add Swift REST API https://review.openstack.org/256140 | 01:32 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift container actions https://review.openstack.org/259236 | 01:32 |
| *** Mounica has quit IRC | 01:33 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/278234 | 01:34 |
| *** jasondotstar has quit IRC | 01:35 | |
| openstackgerrit | Merged openstack/horizon: Logo on non-standard themes should be centered https://review.openstack.org/271859 | 01:35 |
| *** raginbajin has quit IRC | 01:35 | |
| openstackgerrit | Merged openstack/horizon: Add Metadata Tree widget to NG image table drawer https://review.openstack.org/277645 | 01:36 |
| *** joker_ has quit IRC | 01:36 | |
| *** sid14726 has joined #openstack-horizon | 01:36 | |
| *** joker_ has joined #openstack-horizon | 01:36 | |
| *** jasondotstar has joined #openstack-horizon | 01:37 | |
| *** raginbajin has joined #openstack-horizon | 01:37 | |
| *** lhcheng has quit IRC | 01:44 | |
| *** gyee has quit IRC | 01:48 | |
| *** ducttape_ has joined #openstack-horizon | 01:59 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add function to recreate ec2 credential https://review.openstack.org/252190 | 02:00 |
| *** Daisy has joined #openstack-horizon | 02:00 | |
| *** lhcheng has joined #openstack-horizon | 02:03 | |
| *** Daisy has quit IRC | 02:03 | |
| *** lhcheng has quit IRC | 02:03 | |
| *** asahlin has joined #openstack-horizon | 02:04 | |
| *** rbertram has joined #openstack-horizon | 02:04 | |
| *** mtanino has quit IRC | 02:04 | |
| *** lblanchard1 has joined #openstack-horizon | 02:07 | |
| *** lblanchard has quit IRC | 02:15 | |
| *** bpokorny has quit IRC | 02:15 | |
| *** openstackgerrit has quit IRC | 02:15 | |
| *** chlong has quit IRC | 02:15 | |
| *** hurgleburgler has joined #openstack-horizon | 02:23 | |
| *** openstackgerrit has joined #openstack-horizon | 02:24 | |
| *** ducttape_ has quit IRC | 02:26 | |
| *** ducttape_ has joined #openstack-horizon | 02:27 | |
| *** chlong has joined #openstack-horizon | 02:29 | |
| *** btully has joined #openstack-horizon | 02:30 | |
| *** jbell8 has joined #openstack-horizon | 02:32 | |
| *** btully has quit IRC | 02:34 | |
| *** ducttape_ has quit IRC | 02:35 | |
| *** jbell8 has quit IRC | 02:39 | |
| *** lhcheng has joined #openstack-horizon | 02:45 | |
| *** sid14726 has quit IRC | 02:47 | |
| *** lhcheng_ has joined #openstack-horizon | 02:53 | |
| *** lhcheng has quit IRC | 02:56 | |
| *** lhcheng has joined #openstack-horizon | 02:58 | |
| *** lhcheng_ has quit IRC | 03:01 | |
| *** sid14726 has joined #openstack-horizon | 03:15 | |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Allow setting default value for config_drive https://review.openstack.org/271464 | 03:24 |
| *** neelashah has joined #openstack-horizon | 03:28 | |
| *** lhcheng has quit IRC | 03:42 | |
| *** rbertram has quit IRC | 03:43 | |
| *** asahlin has quit IRC | 03:43 | |
| *** rbertram has joined #openstack-horizon | 03:44 | |
| *** asahlin has joined #openstack-horizon | 03:44 | |
| *** amotoki has joined #openstack-horizon | 03:50 | |
| *** piet has joined #openstack-horizon | 03:51 | |
| *** flwang1 has quit IRC | 03:53 | |
| *** amotoki has quit IRC | 03:57 | |
| *** ducttape_ has joined #openstack-horizon | 03:58 | |
| *** wolverin_ has joined #openstack-horizon | 04:05 | |
| *** lhcheng has joined #openstack-horizon | 04:07 | |
| *** wolverineav has quit IRC | 04:09 | |
| *** wolverin_ has quit IRC | 04:10 | |
| *** tyr_ has joined #openstack-horizon | 04:15 | |
| *** itisha has quit IRC | 04:16 | |
| *** Daisy has joined #openstack-horizon | 04:18 | |
| *** tyr_ has quit IRC | 04:20 | |
| *** jtriley has quit IRC | 04:21 | |
| *** Daisy has quit IRC | 04:23 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Checkboxes are now themeable. https://review.openstack.org/252161 | 04:23 |
| *** wolverineav has joined #openstack-horizon | 04:24 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Webroot Theme is no longer needed https://review.openstack.org/213411 | 04:24 |
| *** sid14726 has quit IRC | 04:27 | |
| *** wolverineav has quit IRC | 04:28 | |
| *** ducttape_ has quit IRC | 04:29 | |
| *** amotoki has joined #openstack-horizon | 04:29 | |
| *** wolverineav has joined #openstack-horizon | 04:35 | |
| *** amotoki has quit IRC | 04:42 | |
| *** piet has quit IRC | 04:42 | |
| *** xinwu has quit IRC | 04:44 | |
| *** btully has joined #openstack-horizon | 04:45 | |
| *** lblanchard1 has quit IRC | 04:52 | |
| *** julim has joined #openstack-horizon | 05:00 | |
| *** sid14726 has joined #openstack-horizon | 05:04 | |
| *** piet has joined #openstack-horizon | 05:05 | |
| *** jamielennox is now known as jamielennox|away | 05:06 | |
| *** wolverineav has quit IRC | 05:06 | |
| *** wolverineav has joined #openstack-horizon | 05:07 | |
| *** xinwu has joined #openstack-horizon | 05:12 | |
| *** hurgleburgler has quit IRC | 05:13 | |
| *** neelashah has quit IRC | 05:14 | |
| openstackgerrit | Merged openstack/horizon: Re-enable keypairs integration test https://review.openstack.org/276820 | 05:18 |
| *** piet has quit IRC | 05:18 | |
| *** bpokorny has joined #openstack-horizon | 05:22 | |
| openstackgerrit | Merged openstack/horizon: Adding multiple row actions for the Image table https://review.openstack.org/217964 | 05:28 |
| *** garthb has joined #openstack-horizon | 05:28 | |
| *** jamielennox|away is now known as jamielennox | 05:31 | |
| *** piet has joined #openstack-horizon | 05:36 | |
| *** sid14726 has quit IRC | 05:39 | |
| *** qwebirc92085 has joined #openstack-horizon | 05:45 | |
| *** sid14726 has joined #openstack-horizon | 05:49 | |
| *** fedexo has joined #openstack-horizon | 05:52 | |
| *** fedexo_ has joined #openstack-horizon | 05:53 | |
| *** piet has quit IRC | 05:54 | |
| *** vgridnev has joined #openstack-horizon | 05:58 | |
| *** wasmum has quit IRC | 06:05 | |
| *** tqtran has quit IRC | 06:10 | |
| *** dan_nguyen has quit IRC | 06:18 | |
| *** sid14726 has quit IRC | 06:21 | |
| *** bpokorny has quit IRC | 06:22 | |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Added test for create/delete router actions from network topology page https://review.openstack.org/278327 | 06:27 |
| *** sid14726 has joined #openstack-horizon | 06:30 | |
| *** aortega has quit IRC | 06:31 | |
| *** masco has joined #openstack-horizon | 06:36 | |
| openstackgerrit | Merged openstack/horizon: Ensure that integration tests are being run in proper project https://review.openstack.org/276678 | 06:37 |
| openstackgerrit | Merged openstack/horizon: Launch Instance - UI for Download Key Pair https://review.openstack.org/259593 | 06:38 |
| *** lhcheng has quit IRC | 06:42 | |
| *** vgridnev has quit IRC | 06:43 | |
| *** vgridnev has joined #openstack-horizon | 06:55 | |
| *** tyr has joined #openstack-horizon | 06:58 | |
| *** tyr has quit IRC | 06:58 | |
| *** vishwanathj has quit IRC | 07:00 | |
| *** Mzoorikh has joined #openstack-horizon | 07:03 | |
| *** sid14726 has quit IRC | 07:05 | |
| Mzoorikh | tsufiev: Hi Timur. | 07:06 |
| *** vgridnev has quit IRC | 07:10 | |
| *** fedexo has quit IRC | 07:14 | |
| *** rdopiera has joined #openstack-horizon | 07:14 | |
| *** sid14726 has joined #openstack-horizon | 07:15 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP: Add ngSwift object actions https://review.openstack.org/270553 | 07:16 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift containers and objects display https://review.openstack.org/259231 | 07:16 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift Django Interface https://review.openstack.org/258769 | 07:16 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add Swift REST API https://review.openstack.org/256140 | 07:16 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift container actions https://review.openstack.org/259236 | 07:16 |
| *** vgridnev has joined #openstack-horizon | 07:18 | |
| openstackgerrit | Masco proposed openstack/horizon: Router namespace not created in controller https://review.openstack.org/269605 | 07:19 |
| *** rdopiera has quit IRC | 07:24 | |
| *** rdopiera has joined #openstack-horizon | 07:25 | |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Added test for check instances pagination functionality https://review.openstack.org/269488 | 07:26 |
| *** jsheeren has joined #openstack-horizon | 07:27 | |
| jsheeren | hey all, i have a question concerning authentication in horizon | 07:27 |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Tests for instance filtering are added https://review.openstack.org/271204 | 07:27 |
| jsheeren | the normal keystone credentials work without a problem | 07:28 |
| jsheeren | and we have configured an openid identity server through which we can authenticate | 07:28 |
| jsheeren | but my question is: can i use httpd basic auth to authenticate? | 07:29 |
| mrunge | jsheeren, you require a keystone token to work with horizon | 07:29 |
| mrunge | if you manage to get that token: you're fine | 07:30 |
| jsheeren | mrunge, thanks, to do that, do i need to create a custom authentication module? | 07:30 |
| mrunge | jsheeren, probably yes. same as for openid | 07:30 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/278890 | 07:31 |
| jsheeren | mrunge, same as for openid? so i need to create the necessary identity provider in keystone, with the associated mapping, as with the openid? | 07:32 |
| *** rudolfvriend has joined #openstack-horizon | 07:32 | |
| mrunge | jsheeren, currently, it's a bit cloudy for me, how you enabled openid | 07:33 |
| mrunge | jsheeren, basic auth will just let you in, but you don't have a user from this, no? | 07:33 |
| mrunge | esp. keystone has no clue, who was logged in | 07:33 |
| mrunge | it's not clear to me, why you'll need basic auth, where a user could easily reside in keystone | 07:34 |
| mrunge | more: you could configure a second keystone... | 07:35 |
| openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Added tests for check instance row actions functionality https://review.openstack.org/273971 | 07:35 |
| *** jtomasek has joined #openstack-horizon | 07:36 | |
| *** sid14726 has quit IRC | 07:36 | |
| *** amotoki has joined #openstack-horizon | 07:38 | |
| *** btully has quit IRC | 07:39 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/275486 | 07:39 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 07:41 |
| *** Mzoorikh has quit IRC | 07:42 | |
| *** Mzoorikh has joined #openstack-horizon | 07:42 | |
| *** sid14726 has joined #openstack-horizon | 07:45 | |
| tsufiev | Mzoorikh: hi! | 07:50 |
| Mzoorikh | tsufiev: hi :) | 07:58 |
| Mzoorikh | tsufiev: For my latest patch (https://review.openstack.org/#/c/242691/), you wanted me to change the UX of image membership management in openstack dashboard. | 07:58 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add tests for modification of Resource Types for NameSpaces. https://review.openstack.org/272948 | 08:02 |
| *** mpavlase has joined #openstack-horizon | 08:02 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add tests for modification of Resource Types for NameSpaces. https://review.openstack.org/272948 | 08:03 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add tests for modification of Resource Types for NameSpaces. https://review.openstack.org/272948 | 08:05 |
| *** vgridnev has quit IRC | 08:06 | |
| jsheeren | mrunge, can't i map the REMOTE_USER to a user in keystone? we setup keystone and openid where the identity server is the IDP and keystone/openstack is the SP | 08:08 |
| *** Mzoorikh has quit IRC | 08:09 | |
| jsheeren | i was looking into the external authentication mechanism, and possibly to extent that for our use-case | 08:09 |
| *** tyr has joined #openstack-horizon | 08:09 | |
| jsheeren | http://docs.openstack.org/developer/keystone/external-auth.html | 08:09 |
| *** sinese_ has joined #openstack-horizon | 08:10 | |
| mrunge | jsheeren, sure you can do that | 08:11 |
| mrunge | I must admit, I don't really see a benefit of that. but it has been your question.... | 08:12 |
| *** sid14726 has quit IRC | 08:13 | |
| *** tyr has quit IRC | 08:14 | |
| *** garthb has quit IRC | 08:15 | |
| *** btully has joined #openstack-horizon | 08:16 | |
| *** btully has quit IRC | 08:20 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Add test for network topology page https://review.openstack.org/276845 | 08:21 |
| *** sanjana has joined #openstack-horizon | 08:22 | |
| *** sid14726 has joined #openstack-horizon | 08:28 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check volume types management functionality https://review.openstack.org/267403 | 08:31 |
| *** xinwu has quit IRC | 08:31 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added tests for check change volume functionality https://review.openstack.org/267630 | 08:31 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check launch volume as instance functionality https://review.openstack.org/276654 | 08:31 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Add test for check router create, edit, delete from Admin page https://review.openstack.org/275170 | 08:32 |
| *** sinese_ has quit IRC | 08:34 | |
| *** rcernin has joined #openstack-horizon | 08:35 | |
| *** aortega has joined #openstack-horizon | 08:40 | |
| openstackgerrit | Masco proposed openstack/horizon: Adding angular QoS panel in Horizon https://review.openstack.org/247997 | 08:41 |
| *** e0ne has joined #openstack-horizon | 08:42 | |
| *** amotoki has quit IRC | 08:45 | |
| *** openstackgerrit has quit IRC | 08:47 | |
| *** openstackgerrit_ has joined #openstack-horizon | 08:47 | |
| *** openstackgerrit_ is now known as openstackgerrit | 08:48 | |
| openstackgerrit | Masco proposed openstack/horizon: added edit policy option https://review.openstack.org/259022 | 08:49 |
| openstackgerrit | Masco proposed openstack/horizon: Added a create action for qos policy https://review.openstack.org/272928 | 08:51 |
| openstackgerrit | Masco proposed openstack/horizon: added bandwidth limit rule workflow https://review.openstack.org/277743 | 08:51 |
| *** jtomasek has quit IRC | 08:52 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add tests for verification of NameSpace visibility for associated resource https://review.openstack.org/273563 | 08:53 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add tests for verification of NameSpace visibility for associated resource https://review.openstack.org/273563 | 08:54 |
| *** slunkad has quit IRC | 08:56 | |
| *** tqtran has joined #openstack-horizon | 08:57 | |
| *** jtomasek has joined #openstack-horizon | 08:57 | |
| *** tqtran has quit IRC | 08:58 | |
| *** itxaka has joined #openstack-horizon | 08:59 | |
| *** Mzoorikh has joined #openstack-horizon | 09:00 | |
| *** tqtran has joined #openstack-horizon | 09:02 | |
| *** sid14726 has quit IRC | 09:04 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add tests for modification of Resource Types for NameSpaces. https://review.openstack.org/272948 | 09:05 |
| *** ygbo has joined #openstack-horizon | 09:05 | |
| *** slunkad has joined #openstack-horizon | 09:08 | |
| *** wolverineav has quit IRC | 09:16 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Fix misc small issues with docs https://review.openstack.org/278941 | 09:17 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add tests for verification of NameSpace visibility for associated resource https://review.openstack.org/273563 | 09:18 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Angular: Configuration of boot sources for launch instance https://review.openstack.org/270182 | 09:24 |
| *** sid14726 has joined #openstack-horizon | 09:24 | |
| *** vgridnev has joined #openstack-horizon | 09:25 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Add Network Port selection to new instance launch https://review.openstack.org/253573 | 09:25 |
| *** mvk has joined #openstack-horizon | 09:27 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that user should not have ability to disable himself. https://review.openstack.org/275623 | 09:31 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to verify disabling and then enabling user https://review.openstack.org/275206 | 09:31 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that it is not be possible to disable current project. https://review.openstack.org/278289 | 09:31 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for disabling, enabling project (Identity->Projects). https://review.openstack.org/277409 | 09:31 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for changing password for newly created user https://review.openstack.org/274659 | 09:31 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check new project creation during new user creation. https://review.openstack.org/276640 | 09:31 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check new project creation during new user creation. https://review.openstack.org/276640 | 09:41 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for disabling, enabling project (Identity->Projects). https://review.openstack.org/277409 | 09:43 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that it is not be possible to disable current project. https://review.openstack.org/278289 | 09:44 |
| tsufiev | robcresswell, morning! | 09:48 |
| tsufiev | are there any plans to merge your tables appearance unification in M? | 09:49 |
| *** ccesario has quit IRC | 09:50 | |
| robcresswell | tsufiev: o/ | 09:52 |
| robcresswell | tsufiev: Err, would like to, yes | 09:53 |
| robcresswell | Working on modals too, though not sure if that will make it. | 09:53 |
| tsufiev | robcresswell, okay, going to review it today then | 09:53 |
| robcresswell | tsufiev: Oh awesome, thanks. A lot of the patch noise is due to merge conflicts. | 09:53 |
| tsufiev | yeah, I saw notifications | 09:54 |
| *** ccesario has joined #openstack-horizon | 10:01 | |
| *** vgridnev has quit IRC | 10:03 | |
| *** vgridnev has joined #openstack-horizon | 10:08 | |
| *** vgridnev has quit IRC | 10:09 | |
| *** yamamoto has quit IRC | 10:10 | |
| *** yamamoto has joined #openstack-horizon | 10:10 | |
| *** vgridnev has joined #openstack-horizon | 10:10 | |
| *** vgridnev has quit IRC | 10:12 | |
| *** vgridnev has joined #openstack-horizon | 10:12 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Protect cinder list against permission issues https://review.openstack.org/277304 | 10:12 |
| *** vgridnev has quit IRC | 10:13 | |
| *** sid14726 has quit IRC | 10:13 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add test_router integration test https://review.openstack.org/260360 | 10:14 |
| *** kzaitsev_mb has joined #openstack-horizon | 10:14 | |
| *** vgridnev has joined #openstack-horizon | 10:15 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add test_router integration test https://review.openstack.org/260360 | 10:15 |
| *** sid14726 has joined #openstack-horizon | 10:24 | |
| *** fedexo_ has quit IRC | 10:24 | |
| *** Daisy has joined #openstack-horizon | 10:26 | |
| *** Daisy has quit IRC | 10:31 | |
| *** vgridnev has quit IRC | 10:34 | |
| tsufiev | robcresswell, found one issue, otherwise looks very good to me | 10:35 |
| tsufiev | robcresswell, would you mind reviewing Richard's patch at https://review.openstack.org/#/c/274996/ :)? It will ease the life of i9n tests writers | 10:36 |
| *** yamamoto has quit IRC | 10:38 | |
| robcresswell | tsufiev: Ooo interesting. re: Actions, its just something the angular tables do. I think I'll revert that and make the angular tables show the word actions. | 10:39 |
| robcresswell | It was a minor thing I didnt really think much on. | 10:39 |
| onovy | hi guys. Can you look to this review pls? http://paste.openstack.org/show/486633/ it's same reviews in all xstatic projects. Same patch already merged in majority of OS projects. Thanks | 10:39 |
| tsufiev | onovy, omg, that's quite a big pile of reviews | 10:40 |
| onovy | tsufiev: i sent review to all OS projects, so big pile of reviews was my outgoing queue :) | 10:40 |
| *** itxaka_ has joined #openstack-horizon | 10:41 | |
| *** itxaka_ has quit IRC | 10:41 | |
| *** itxaka has quit IRC | 10:41 | |
| onovy | https://review.openstack.org/#/q/%22Deprecated+tox+-downloadcache+option+removed%22 | 10:41 |
| *** itxaka has joined #openstack-horizon | 10:41 | |
| *** vgridnev has joined #openstack-horizon | 10:42 | |
| tsufiev | onovy, r1chardj0n3s is currently the most involved person in xstatic stuff among active cores | 10:43 |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Add test for network topology page https://review.openstack.org/276845 | 10:44 |
| *** haypo has quit IRC | 10:44 | |
| *** haypo has joined #openstack-horizon | 10:44 | |
| onovy | thanks Radomir for +2 | 10:44 |
| tsufiev | robcresswell, thanks! | 10:45 |
| rdopiera | onovy: np | 10:45 |
| *** vgridnev has quit IRC | 10:45 | |
| *** vgridnev has joined #openstack-horizon | 10:45 | |
| *** tosky has joined #openstack-horizon | 10:46 | |
| robcresswell | tsufiev: np | 10:46 |
| *** jbell8 has joined #openstack-horizon | 10:48 | |
| *** yamamoto has joined #openstack-horizon | 10:49 | |
| *** yamamoto has quit IRC | 10:49 | |
| *** mvk has quit IRC | 10:54 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: [wip] select options support https://review.openstack.org/261576 | 10:55 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: [wip] select options support https://review.openstack.org/261576 | 10:56 |
| *** sid14726 has quit IRC | 10:57 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Adding hz-if-neutron-extensions directive https://review.openstack.org/252597 | 11:08 |
| *** sid14726 has joined #openstack-horizon | 11:08 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [WIP] Add Create Network workflow https://review.openstack.org/264299 | 11:13 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [WIP] Add Create Network workflow https://review.openstack.org/264299 | 11:14 |
| *** wolverineav has joined #openstack-horizon | 11:16 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/278890 | 11:20 |
| *** wolverineav has quit IRC | 11:21 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: disable metering with ceilometer https://review.openstack.org/272644 | 11:22 |
| openstackgerrit | Merged openstack/horizon: Port last unit tests to Python 3 https://review.openstack.org/278505 | 11:23 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that user should not have ability to disable himself. https://review.openstack.org/275623 | 11:25 |
| *** mvk has joined #openstack-horizon | 11:26 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Force line break for detail table cells https://review.openstack.org/276171 | 11:27 |
| *** jbell8 has quit IRC | 11:28 | |
| *** jbell8 has joined #openstack-horizon | 11:29 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Provide i9n test for managing a project's members https://review.openstack.org/168935 | 11:29 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to verify disabling and then enabling user https://review.openstack.org/275206 | 11:32 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for changing password for newly created user https://review.openstack.org/274659 | 11:33 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to verify disabling and then enabling user https://review.openstack.org/275206 | 11:33 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that user should not have ability to disable himself. https://review.openstack.org/275623 | 11:33 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check new project creation during new user creation. https://review.openstack.org/276640 | 11:33 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for disabling, enabling project (Identity->Projects). https://review.openstack.org/277409 | 11:34 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that it is not be possible to disable current project. https://review.openstack.org/278289 | 11:34 |
| itxaka | question for folks with knowledge on jasmine testing, Im trying to inject the toast service for testing | 11:36 |
| itxaka | byt doing "toast = $injector.get('horizon.framework.widgets.toast.service');" | 11:36 |
| itxaka | as to test if its called and to check the proper params | 11:37 |
| itxaka | but I get a failure all the time | 11:37 |
| itxaka | Unknown provider: horizon.framework.widgets.toast.serviceProvider <- horizon.framework.widgets.toast.service <- launchInstanceModel | 11:37 |
| itxaka | went to check other patches that inject the toast and found this one:https://review.openstack.org/#/c/234875/30/openstack_dashboard/dashboards/admin/static/dashboard/admin/flavors/actions/create-action.service.spec.js | 11:38 |
| itxaka | and in that one it seems to work perfectly | 11:38 |
| itxaka | so I know Im missing something very simple there but I dont know what | 11:38 |
| itxaka | any help would be appreciated, thanks | 11:38 |
| *** amotoki has joined #openstack-horizon | 11:41 | |
| *** sid14726 has quit IRC | 11:41 | |
| tsufiev | itxaka, are you pulling the same modules in beforeEach() before $injector.get() ? | 11:42 |
| *** Mzoorikh_ has joined #openstack-horizon | 11:42 | |
| itxaka | tsufiev, the same modules as in the example patch? Nope, this is for the launch-instance specs | 11:43 |
| tsufiev | itxaka, no other ideas than this one about what might you have missed | 11:43 |
| itxaka | arrrghh all this javascript injectors and providers and mocks is very confusing brrrr | 11:45 |
| *** sid14726 has joined #openstack-horizon | 11:45 | |
| itxaka | thanks tsufiev Ill keep banging my head against the keyboard :/ | 11:45 |
| *** Mzoorikh has quit IRC | 11:46 | |
| robcresswell | Yeah I think matt-borland is gonna take over the create network stuff, I'm just slowing the process down :/ | 11:48 |
| *** yamamoto has joined #openstack-horizon | 11:50 | |
| *** btully has joined #openstack-horizon | 11:52 | |
| *** vgridnev has quit IRC | 11:56 | |
| *** vgridnev has joined #openstack-horizon | 11:56 | |
| *** btully has quit IRC | 11:57 | |
| *** yamamoto has quit IRC | 11:58 | |
| *** amotoki has quit IRC | 12:00 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Add test for network topology page https://review.openstack.org/276845 | 12:03 |
| *** amotoki has joined #openstack-horizon | 12:03 | |
| openstackgerrit | Merged openstack/horizon: Add configuration mechanism to turn off browser maximisation https://review.openstack.org/274996 | 12:05 |
| *** kzaitsev_mb has quit IRC | 12:06 | |
| haypo | itxaka, robcresswell : hi. i'm working on horizon integration tests, i'm trying to port them to py3. but it doesn't work. how can I run manually horizon HTTP server? | 12:08 |
| haypo | "manage.py testserver --settings=openstack_dashboard.test.settings" complains that it has no DB configured | 12:08 |
| haypo | it looks like tests use file:memorydb_default?mode=memory&cache=shared | 12:08 |
| *** Mzoorikh_ has quit IRC | 12:09 | |
| haypo | ah wait, "manage.py runserver" if i put DEBUG=True in settigs.py. my django skills are rusty :) | 12:10 |
| *** ig0r_ has joined #openstack-horizon | 12:12 | |
| *** sid14726 has quit IRC | 12:21 | |
| *** masco has quit IRC | 12:24 | |
| *** jbell8 has quit IRC | 12:24 | |
| robcresswell | itxaka: I think we just got rubber ducked | 12:24 |
| robcresswell | haypo: Glad it got sorted :p | 12:25 |
| itxaka | rubber ducking is awesome, its a total win-win situation | 12:25 |
| itxaka | the questioner resolves it by itself so its happy, the asked person says "I helped! Im useful!" | 12:25 |
| itxaka | :P | 12:25 |
| *** doug-fish has joined #openstack-horizon | 12:29 | |
| toabctl | doug-fish: hey. friendly reminder about commenting https://review.openstack.org/#/c/243974/ | 12:32 |
| *** ppiela has quit IRC | 12:39 | |
| *** amotoki has quit IRC | 12:41 | |
| *** ppiela has joined #openstack-horizon | 12:45 | |
| *** sid14726 has joined #openstack-horizon | 12:45 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:49 | |
| *** jprovazn has joined #openstack-horizon | 12:53 | |
| *** jtriley has joined #openstack-horizon | 12:54 | |
| *** jtriley has quit IRC | 13:00 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 13:08 |
| *** pauloewerton has joined #openstack-horizon | 13:08 | |
| *** sjmc7 has joined #openstack-horizon | 13:08 | |
| *** amotoki has joined #openstack-horizon | 13:09 | |
| *** ducttape_ has joined #openstack-horizon | 13:11 | |
| *** esp has joined #openstack-horizon | 13:17 | |
| *** wolverineav has joined #openstack-horizon | 13:18 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: disable metering with ceilometer https://review.openstack.org/272644 | 13:19 |
| doug-fish | toabctl: yes, thanks for the reminder | 13:19 |
| *** jtomasek_ has joined #openstack-horizon | 13:21 | |
| *** sid14726 has quit IRC | 13:21 | |
| *** esp has quit IRC | 13:23 | |
| *** sjmc7 has quit IRC | 13:23 | |
| *** wolverineav has quit IRC | 13:23 | |
| *** kzaitsev_mb has quit IRC | 13:24 | |
| *** Daisy has joined #openstack-horizon | 13:24 | |
| doug-fish | toabctl: I've noted my concern in the review - not sure if we should discuss here or keep using the review for discussion | 13:25 |
| toabctl | doug-fish: we can discuss it here. I'm all for getting progress into that one :) | 13:26 |
| doug-fish | understood | 13:26 |
| toabctl | doug-fish: at least it's not the usual rebase hell when a patch needs time for review :) | 13:26 |
| *** gberginc has joined #openstack-horizon | 13:26 | |
| doug-fish | yes - hooray for new function! :-) | 13:26 |
| doug-fish | toabctl: and just to be clear - I understand and like the idea, but that one detail, the order of precedence is really concerning me | 13:27 |
| *** ducttape_ has quit IRC | 13:27 | |
| doug-fish | is the order of evaluation alphabetical by filename? | 13:27 |
| * toabctl needs to look again | 13:28 | |
| *** rbertram has quit IRC | 13:29 | |
| *** asahlin has quit IRC | 13:29 | |
| doug-fish | Sure - and I'm concerned about the deployer needing to be settings in some convoluted file name local_settings.d/ZZ_my_settings.py or similar. | 13:29 |
| *** rbertram has joined #openstack-horizon | 13:30 | |
| *** asahlin has joined #openstack-horizon | 13:30 | |
| toabctl | doug-fish: about the order: should be alphabetical. but I think I need to fix that and add a sorted() call to the filesnames list | 13:30 |
| toabctl | because os.walk uses os.listdir() which has arbitrary order | 13:31 |
| toabctl | doug-fish: but beside that, I think it's common practice to use a ZZ_myfile nameing schema where ZZ is a number | 13:32 |
| doug-fish | yeah, I can see that | 13:32 |
| doug-fish | it's a lot like our enabled files that way | 13:33 |
| *** mpavlase has quit IRC | 13:33 | |
| toabctl | doug-fish: about adding local_settings.py at the last evaluated file - then I can not overwrite stuff that is in there. | 13:33 |
| *** mpavlase has joined #openstack-horizon | 13:33 | |
| toabctl | doug-fish: I think when having local_settings.d/ we should remove everything from local_settings.py and move it to i.e. local_settings.d/_50_local_settings.py | 13:34 |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Add test for network topology page https://review.openstack.org/276845 | 13:34 |
| doug-fish | toabctl: do you envision 50_local_settings.py being the highest or lowest precedence file? | 13:35 |
| toabctl | doug-fish: nothing from both. | 13:35 |
| toabctl | you can add files with higher and lower numbers | 13:35 |
| doug-fish | oh I see | 13:35 |
| doug-fish | hmm | 13:35 |
| toabctl | doug-fish: I think when people using a distro (i.e. debian or suse or redhat r whatever) they usually know how things work. and it's easy to find out what's before and/or after the default settings | 13:36 |
| toabctl | and I guess for the devstack case there is nothing that changes. | 13:36 |
| *** jtomasek_ has quit IRC | 13:37 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Add Network Port selection to new instance launch https://review.openstack.org/253573 | 13:37 |
| doug-fish | toabctl: yes, I think I see your vision. I'm thinking through now how much of this belongs in OpenStack developer doc and how much just remains distro choices | 13:37 |
| toabctl | doug-fish: imo it's fine to document that there is a mechanism to override settings. how that is done by downstream is something downstream should document | 13:39 |
| doug-fish | toabctl: agreed. I think this only fact that's missing is the order of evaluation for the fragments. That's should be in the community doc. (and should be coded too!) | 13:40 |
| toabctl | yes. I'll do that today and update the patchset. thanks doug-fish! | 13:40 |
| doug-fish | toabctl: certainly - thanks for your work on this! and feel free to call out another friendly reminder as needed. :-) | 13:41 |
| toabctl | doug-fish: ok :-) | 13:42 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 13:43 |
| *** sid14726 has joined #openstack-horizon | 13:44 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check availability resources for projects https://review.openstack.org/269703 | 13:44 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 13:51 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test case create/delete subnet from Network Overview page https://review.openstack.org/273116 | 13:52 |
| *** cbader has quit IRC | 13:52 | |
| openstackgerrit | Thomas Bechtold proposed openstack/horizon: Add local_settings.d/ dir for settings snippets https://review.openstack.org/243974 | 13:53 |
| toabctl | doug-fish: I updated the changeset and (hopefully) clarified the order in the documentation. | 13:54 |
| doug-fish | toabctl: cool - I'll take a look right now | 13:54 |
| *** matt-borland has joined #openstack-horizon | 13:54 | |
| *** jtriley has joined #openstack-horizon | 13:54 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 13:56 |
| *** kzaitsev_mb has joined #openstack-horizon | 13:57 | |
| *** jtriley has quit IRC | 13:59 | |
| doug-fish | toabctl: patch is looking good. I noted one specific concern with the doc. | 14:00 |
| doug-fish | (complete with a suggestion for improvement!) | 14:00 |
| doug-fish | toabctl: oh - that patch probably needs a release note too. I'll note that inline as well | 14:04 |
| toabctl | doug-fish: hm. are the release notes also in git? and should that be included in this commit? | 14:04 |
| *** julim has quit IRC | 14:05 | |
| doug-fish | toabctl: I think we are using reno - the commits include fragments to be added to the release notes ... | 14:05 |
| doug-fish | I'm just not sure I've seen that used recently ... maybe we are just doing secret patches. | 14:06 |
| doug-fish | Let me dig up an example of what I think needs to be done | 14:06 |
| robcresswell | doug-fish toabctl: See http://docs.openstack.org/developer/horizon/contributing.html#release-notes | 14:06 |
| robcresswell | toabctl: It's pretty straightforward, shouldnt take more than a minute :) | 14:06 |
| robcresswell | You just generate a release note and edit out the sections you dont need. | 14:07 |
| robcresswell | then write a line or two for the new feature. | 14:07 |
| doug-fish | here's an example of what it should look like at the end: https://review.openstack.org/#/c/255590/ | 14:07 |
| doug-fish | robcresswell: thanks for pointing out the doc! | 14:08 |
| toabctl | robcresswell: great. thanks | 14:08 |
| toabctl | doug-fish: thanks. I'll have a look. | 14:08 |
| robcresswell | doug-fish, toabctl: np | 14:09 |
| *** Daisy has quit IRC | 14:11 | |
| openstackgerrit | Thomas Bechtold proposed openstack/horizon: Add local_settings.d/ dir for settings snippets https://review.openstack.org/243974 | 14:11 |
| mrunge | doug-fish, toabctl robcresswell didn't we talk about deprecating local_settings.py at some point? | 14:12 |
| mrunge | If yes, that should be added to docs | 14:12 |
| *** neelashah has joined #openstack-horizon | 14:13 | |
| doug-fish | mrunge: my recollection is that we talked, but didn't take action | 14:13 |
| *** neelashah has quit IRC | 14:13 | |
| mrunge | like "from N release, local_settings.py" will be deprecated | 14:13 |
| openstackgerrit | Thomas Bechtold proposed openstack/horizon: Add local_settings.d/ dir for settings snippets https://review.openstack.org/243974 | 14:14 |
| mrunge | (or so); at least, it would be a good idea to move local_settings.py to snippets then? | 14:14 |
| * doug-fish thinking | 14:14 | |
| toabctl | doug-fish: added the release note and add the text from your comment. | 14:14 |
| mrunge | I mean, you're currently doc'ing things, how they are supposed to be | 14:14 |
| toabctl | mrunge: I'm fine with deprecating local_settings.py | 14:15 |
| *** krotscheck_dcm is now known as krotscheck | 14:15 | |
| *** jpomeroy has joined #openstack-horizon | 14:15 | |
| mrunge | toabctl, that would be my suggestion. but if we want to deprecate, we need to document | 14:15 |
| mrunge | just to give deployers a real chance | 14:16 |
| mrunge | I mean, that file has been there forever | 14:16 |
| robcresswell | Doesn't have to hold up that patch though. afaik there has been no decision on it | 14:16 |
| *** lblanchard has joined #openstack-horizon | 14:16 | |
| robcresswell | So I don't know that we shouls hold up that work any further since people seem to want it. | 14:16 |
| toabctl | yeah. given that this patch took 3 month to get consensus I would like to move the deprecation to another patch | 14:17 |
| doug-fish | I have unspecified concern with deprecating it. I'm not sure if it's well founded yet. I'm still reflecting. | 14:17 |
| mrunge | heh, fair enough | 14:17 |
| mrunge | (to both objections) | 14:17 |
| robcresswell | I want to talk through plugin and settings architecture at the mid/end-cycle actually | 14:18 |
| matt-borland | robcresswell, let me know what you'll need done with https://review.openstack.org/#/c/264299/ | 14:18 |
| matt-borland | "mend-cycle," when we fix everything before the release | 14:18 |
| doug-fish | lol | 14:19 |
| robcresswell | matt-borland: The scope issue; I'm still throwing in rootScope and hitting my head against the wall. | 14:19 |
| matt-borland | ok, will do, thx | 14:19 |
| mrunge | good idea robcresswell | 14:19 |
| robcresswell | Er I'll ping you on hangouts rather than spam the channel matt-borland | 14:19 |
| mrunge | make sure it's documented | 14:19 |
| matt-borland | thx robcresswell | 14:19 |
| robcresswell | mrunge: Yep just adding to etherpad | 14:20 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Enhances tox to not rely on run_tests https://review.openstack.org/259013 | 14:20 |
| mrunge | unfortunately, I can't attend. someone will have to talk about my topics, there were a few | 14:20 |
| mrunge | :( | 14:20 |
| robcresswell | ah no :( | 14:21 |
| robcresswell | thats a shame | 14:21 |
| *** gberginc has quit IRC | 14:22 | |
| *** Daisy has joined #openstack-horizon | 14:23 | |
| *** peristeri has joined #openstack-horizon | 14:25 | |
| *** Daisy has quit IRC | 14:26 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding resource type registry service https://review.openstack.org/278447 | 14:28 |
| *** btully has joined #openstack-horizon | 14:33 | |
| *** gariveradlt has joined #openstack-horizon | 14:34 | |
| *** jtriley has joined #openstack-horizon | 14:38 | |
| matt-borland | TravT, let me know when/if you want to chat more about the registry. I think you're mostly right but there are some important gotchas with respect to registration vs. extension. | 14:38 |
| matt-borland | (mostly, that you have to assume registries can happen in any order) | 14:39 |
| *** gariveradlt has quit IRC | 14:39 | |
| *** neelashah has joined #openstack-horizon | 14:40 | |
| *** gariveradlt has joined #openstack-horizon | 14:42 | |
| openstackgerrit | Merged openstack/horizon: Remove extraneous table padding https://review.openstack.org/277439 | 14:43 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Add missing network mock https://review.openstack.org/279103 | 14:43 |
| robcresswell | thanks for that one itxaka! | 14:44 |
| itxaka | pretty bad that the test is not failing :/ | 14:44 |
| robcresswell | itxaka: Its a known issue in the tests, I've not had time to look into it | 14:44 |
| *** Drago has joined #openstack-horizon | 14:45 | |
| *** Drago has quit IRC | 14:46 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/275486 | 14:46 |
| *** Drago has joined #openstack-horizon | 14:46 | |
| *** cbader has joined #openstack-horizon | 14:47 | |
| itxaka | also Im seeeing some errors on the py34 tox env on master. Something is trying to do a call to an endpoint and we are not mocking it, looking into it. | 14:47 |
| itxaka | can anyone confirm by launching tox -e py34? | 14:47 |
| itxaka | Im not sure if its a local issue :/ | 14:47 |
| *** gariveradlt has quit IRC | 14:47 | |
| robcresswell | itxaka: Running now, 1 min | 14:47 |
| itxaka | thanks rob | 14:47 |
| *** gariveradlt has joined #openstack-horizon | 14:48 | |
| mrunge | I know I did it a few hours ago, output was clean :-/ | 14:49 |
| robcresswell | urgh python has updated to 3.5, one minute | 14:49 |
| *** jtriley_ has joined #openstack-horizon | 14:50 | |
| *** sid14726 has quit IRC | 14:50 | |
| itxaka | ugh, I hope my local install didnt break somehow ~_~ | 14:50 |
| robcresswell | right, tests running now :p | 14:51 |
| mrunge | oh, good idea to remove *.py[co] files from time to time... | 14:51 |
| mrunge | I see cinderclient traces, is that new? | 14:52 |
| mrunge | and "Unable to connect to Neutron" | 14:52 |
| mrunge | sigh | 14:52 |
| itxaka | yeah, unable to connect I fixed that one | 14:52 |
| robcresswell | So the Neutron one itxaka has a patch for | 14:52 |
| *** julim has joined #openstack-horizon | 14:52 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test case add subnet to the network https://review.openstack.org/273644 | 14:52 |
| mrunge | link? | 14:52 |
| itxaka | but the cinderclient trying to connect to public.nova.example.com is new | 14:53 |
| robcresswell | and the cinderclient ones, I *had* patch for but I've lost it in the hundreds of branches I have locally | 14:53 |
| itxaka | https://review.openstack.org/279103 | 14:53 |
| *** jtriley has quit IRC | 14:53 | |
| itxaka | mrunge ^^ | 14:53 |
| mrunge | thx itxaka | 14:53 |
| robcresswell | the cinderclient one, is that the absolute_limits issue? | 14:54 |
| robcresswell | or is that a different one | 14:54 |
| mrunge | fetching my son from school now, will be back after | 14:54 |
| mrunge | itxaka, now my py34 tests don't pass locally any more | 14:54 |
| itxaka | nice | 14:54 |
| itxaka | robcresswell, is trying to connect to /v2/snapshots/detail?all_tenants | 14:55 |
| *** erlon has joined #openstack-horizon | 14:55 | |
| robcresswell | Oh yeah, it just popped up for me too | 14:55 |
| robcresswell | I think thats just another missing mock | 14:55 |
| itxaka | its great that it doesnt come up on py27 :D | 14:55 |
| robcresswell | :( | 14:55 |
| itxaka | ok good, Ill have a look at it to see whats going one | 14:55 |
| itxaka | thanks for the help :) | 14:55 |
| robcresswell | There are test failures that only show up in dj19 but definitely exist in dj18 and I can't fathom why | 14:56 |
| robcresswell | One is a missing mock and I have no idea why it passes dj18 | 14:56 |
| *** sjmc7 has joined #openstack-horizon | 14:56 | |
| robcresswell | Yeah I'm seeing a lot of cinderclient issues. but the tests "Pass" | 14:56 |
| robcresswell | haypo: Any thoughts? | 14:56 |
| haypo | robcresswell: which failures? | 14:58 |
| haypo | mrunge: "mrunge> itxaka, now my py34 tests don't pass locally any more" ah? what are your failures? | 14:58 |
| robcresswell | haypo: Just seeing a lot of cinderclient debug statements in py34 tests | 14:58 |
| robcresswell | Wondered if you had encountered them | 14:59 |
| haypo | robcresswell: ah yes, it's common to see more logs on py3 than on py2 | 14:59 |
| robcresswell | huh, why is that? | 14:59 |
| *** ducttape_ has joined #openstack-horizon | 14:59 | |
| haypo | robcresswell: if i recall correctly, py2 has a bug which hides logs | 14:59 |
| robcresswell | Ah excellent. | 14:59 |
| TravT | matt-borland: i have to run searchlight IRC meeting right now. | 15:00 |
| haypo | robcresswell: what i run "tox -e py34" i don't see any log | 15:00 |
| matt-borland | :) np | 15:00 |
| haypo | oops | 15:00 |
| haypo | robcresswell: when i run "tox -e py34" i don't see any log | 15:00 |
| TravT | the append / prepend thing is true for timing. | 15:00 |
| matt-borland | yeah, no problem, I'm implementing it now | 15:00 |
| haypo | robcresswell: but you see them when you run directly a test using manage.py | 15:00 |
| haypo | robcresswell: it shouldn't be hard to hide these logs if you don't want them | 15:00 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test case add subnet to the network https://review.openstack.org/273644 | 15:01 |
| robcresswell | haypo: Well, its more that they're highlight connection errors which should be mocked | 15:01 |
| robcresswell | No need to hide that | 15:01 |
| robcresswell | But I was curious why an issue like that would be more visible in py3 over py2 | 15:02 |
| haypo | robcresswell: it would not be the first time that py3 helps to find bugs in tests ;) | 15:02 |
| haypo | robcresswell: i recall vaguely a change in the warnings module in a minor version of py 3.4 | 15:02 |
| haypo | robcresswell: but i guess that your log doesn't come from the warnings module | 15:03 |
| haypo | i just ran tox -e py34, i saw: | 15:03 |
| haypo | "Failed to create user from domain scoped token." | 15:03 |
| haypo | "Unable to connect to Neutron." | 15:03 |
| *** Mzoorikh has joined #openstack-horizon | 15:04 | |
| *** gariveradlt has quit IRC | 15:05 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test create/edit/delete port on Network Overview page https://review.openstack.org/274119 | 15:05 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check instance creation when several networks are present https://review.openstack.org/276075 | 15:06 |
| *** piet has joined #openstack-horizon | 15:06 | |
| robcresswell | haypo: You don't see the cinderclient DEBUG messages? | 15:07 |
| haypo | robcresswell: http://paste.openstack.org/show/486704/ | 15:08 |
| robcresswell | Huh, interesting. Thanks. | 15:08 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add test_router integration test https://review.openstack.org/260360 | 15:09 |
| *** piet has quit IRC | 15:12 | |
| *** piet has joined #openstack-horizon | 15:12 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check associate/disassociate actions for floating ip https://review.openstack.org/277467 | 15:14 |
| *** Daisy has joined #openstack-horizon | 15:16 | |
| *** Mzoorikh has quit IRC | 15:17 | |
| *** Daisy has quit IRC | 15:17 | |
| *** wolverineav has joined #openstack-horizon | 15:20 | |
| *** ig0r_ has quit IRC | 15:21 | |
| *** pushkaru has joined #openstack-horizon | 15:21 | |
| *** aortega has quit IRC | 15:22 | |
| *** Mounica has joined #openstack-horizon | 15:22 | |
| *** hurgleburgler has joined #openstack-horizon | 15:24 | |
| *** wolverineav has quit IRC | 15:24 | |
| *** jsheeren has quit IRC | 15:25 | |
| *** hurgleburgler has quit IRC | 15:25 | |
| *** vijendar has joined #openstack-horizon | 15:30 | |
| *** garthb has joined #openstack-horizon | 15:31 | |
| *** petertr7 is now known as petertr7_away | 15:31 | |
| *** garthb has quit IRC | 15:35 | |
| *** garthb has joined #openstack-horizon | 15:35 | |
| *** zul_ has joined #openstack-horizon | 15:36 | |
| *** zul has quit IRC | 15:36 | |
| *** Daisy has joined #openstack-horizon | 15:37 | |
| *** piet has quit IRC | 15:37 | |
| *** mtanino has joined #openstack-horizon | 15:40 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Add policy checks of getting images https://review.openstack.org/261967 | 15:40 |
| *** Daisy has quit IRC | 15:41 | |
| *** jtriley_ has quit IRC | 15:48 | |
| *** amotoki has quit IRC | 15:52 | |
| *** EmilienM has quit IRC | 15:53 | |
| *** NightKhaos has quit IRC | 15:54 | |
| *** jtriley has joined #openstack-horizon | 15:54 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding resource type registry service https://review.openstack.org/278447 | 15:54 |
| *** HenryG has quit IRC | 15:55 | |
| *** haypo has quit IRC | 15:55 | |
| matt-borland | TravT, updated that patch to include use of extensibility service ^^ | 15:56 |
| TravT | matt-borland: cool. will look in a second. | 15:56 |
| *** v12aml has quit IRC | 15:56 | |
| TravT | last night i didn't add a bunch of nitpick about code style. | 15:56 |
| TravT | but we'll want to do that too. | 15:56 |
| matt-borland | yeah, indeed, I reconfigured a few things as well | 15:57 |
| matt-borland | I figured we could hash out the general workings first | 15:57 |
| matt-borland | then clean up & do docs | 15:58 |
| TravT | but in general, the more i think about it, the more i think this registry service need to be a critical part of the pattern and should get into mitaka | 15:58 |
| matt-borland | yeah. | 15:58 |
| matt-borland | luckily, it's really simple. | 15:58 |
| TravT | yep! | 15:58 |
| *** vijendar1 has joined #openstack-horizon | 15:58 | |
| matt-borland | I want to go ahead and add the general actions feature in as well | 15:58 |
| *** dan_nguyen has joined #openstack-horizon | 15:58 | |
| matt-borland | I know Tyr was going to work on that but I probably have more focus on it | 15:59 |
| TravT | yeah | 15:59 |
| *** HenryG has joined #openstack-horizon | 16:02 | |
| matt-borland | jpomeroy, if I haven't said it before, that extensibility service is awesome :) | 16:02 |
| *** vijendar has quit IRC | 16:02 | |
| *** NightKhaos has joined #openstack-horizon | 16:02 | |
| *** v12aml has joined #openstack-horizon | 16:02 | |
| jpomeroy | =] | 16:02 |
| *** kzaitsev_mb has quit IRC | 16:05 | |
| jpomeroy | matt-borland, will that action registry break existing angular table actions? | 16:05 |
| jpomeroy | doesn't look like it at quick glance | 16:05 |
| matt-borland | nope! The only change is that actions shouldn't perform API calls, etc in their construction. | 16:06 |
| *** EmilienM has joined #openstack-horizon | 16:06 | |
| matt-borland | because those would be executed at injection, which is a no-no | 16:06 |
| matt-borland | so just offload those to the init method, all is well | 16:06 |
| robcresswell | Hmm. itxaka, iirc a while back you mentioned a non-existent template in the tables? | 16:06 |
| itxaka | yup | 16:06 |
| robcresswell | Did that get fixed? I've just stumbled across it | 16:07 |
| itxaka | robcresswell, let me find the bug | 16:07 |
| jpomeroy | matt-borland, i will have to take a look. i'm sure we'll want to convert the lbaas tables. | 16:07 |
| *** piet has joined #openstack-horizon | 16:07 | |
| itxaka | https://bugs.launchpad.net/horizon/+bug/1523949 | 16:07 |
| openstack | Launchpad bug 1523949 in OpenStack Dashboard (Horizon) "horizon.tables.actions LinkAction referencing a non-existant template" [Low,Confirmed] | 16:07 |
| *** kzaitsev_mb has joined #openstack-horizon | 16:07 | |
| matt-borland | yeah, nothing conflicts with the current approach; all actions would still work fine, but they would not work in an injected situation. | 16:07 |
| robcresswell | itxaka: Ah, nice | 16:08 |
| robcresswell | Yeah thats the one I see too | 16:08 |
| matt-borland | which is where we'd like them to be so they can integrate with searchlight &c | 16:08 |
| itxaka | its a very nice one. Returning something breaks css, a 500 error makes the css work | 16:08 |
| itxaka | :D | 16:08 |
| robcresswell | Hmm, | 16:09 |
| robcresswell | So in my pthon/angular table matching, tsufiev point this out http://imgur.com/AyGiU13 | 16:09 |
| itxaka | I think matt-borland did a wip of it | 16:09 |
| robcresswell | Its really bizarre, because refreshing the table renders properly | 16:09 |
| robcresswell | but when you delete something, it screws up | 16:09 |
| matt-borland | ah, yeah | 16:09 |
| itxaka | ah, so you are trigerring it probably and its messing up the css | 16:09 |
| *** vijendar has joined #openstack-horizon | 16:10 | |
| robcresswell | Yeah I believe so | 16:10 |
| tsufiev | robcresswell, seems that some CSS ninja trick is required | 16:10 |
| matt-borland | I did do a pretty bad wip of it, really not too clear on the *right* way to do it | 16:10 |
| tsufiev | you know whom you need to call ;) | 16:10 |
| robcresswell | dammit diana isnt online | 16:10 |
| matt-borland | lol | 16:10 |
| robcresswell | This is like being in a ghostbusters movie without the ghostbusters | 16:11 |
| *** vijendar1 has quit IRC | 16:11 | |
| robcresswell | It looks like just updating it to data_table_action should be enough | 16:12 |
| *** leitan has joined #openstack-horizon | 16:12 | |
| leitan | Hi guys, im having an issue with manage.py collectstatic, its ignoring some folders that need to be collected / compressed, if i run the collectstatic with verbosity=3 i dont see the folder get processed, how can i debug this ? | 16:13 |
| leitan | or why a folder can be ignored ? if im running the command without ignore expressions | 16:14 |
| *** cbader has quit IRC | 16:14 | |
| *** vgridnev has quit IRC | 16:15 | |
| *** cbader has joined #openstack-horizon | 16:15 | |
| robcresswell | leitan: data data data, I can't make bricks without clay! | 16:15 |
| robcresswell | leitan: Basically: what are you trying to do, what files etc please :) | 16:15 |
| *** tyr has joined #openstack-horizon | 16:17 | |
| *** garthb has quit IRC | 16:20 | |
| *** aortega has joined #openstack-horizon | 16:20 | |
| leitan | robcresswell, we have developed a UI for cloudkitty for showback and chargeback, its a folder that has inside its "static" folder and inside the static, two more more folder named billing and billing_ui inside thems the classic folders js, css and img | 16:20 |
| leitan | robcresswell, for some reason collectstatic (were using compress_offline=True) ignore them | 16:21 |
| leitan | doesnt create the folders inside /static root, and then manage.py compress fails to find static files | 16:21 |
| leitan | so im wondering why collectstatic is ignoring them | 16:21 |
| *** vgridnev has joined #openstack-horizon | 16:21 | |
| leitan | if you need i can provide a tree, to be more clear robcresswell | 16:21 |
| *** vgridnev has quit IRC | 16:22 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Enhances tox to not rely on run_tests https://review.openstack.org/259013 | 16:23 |
| robcresswell | leitan: That would be handy, if you could drop it into paste.openstack.org | 16:23 |
| leitan | robcresswell, http://paste.openstack.org/show/ntqoAE8TVn1hcSTNr0Lh/ | 16:24 |
| TravT | matt-borland: i'm just looking at this review: https://review.openstack.org/#/c/261967/6/openstack_dashboard/static/app/core/images/table/images.controller.js | 16:24 |
| TravT | and it totally occurs to me that we could also register policy on the registry | 16:24 |
| *** mvk has quit IRC | 16:24 | |
| *** Mounica has quit IRC | 16:27 | |
| *** vkmc|midcycle is now known as vkmc | 16:27 | |
| robcresswell | leitan: A couple of things look off to me. It'snot following the usual structure: http://docs.openstack.org/developer/horizon/tutorials/dashboard.html#structure | 16:28 |
| robcresswell | Actually... | 16:28 |
| robcresswell | Hmm | 16:28 |
| *** absubram has joined #openstack-horizon | 16:28 | |
| *** Mounica has joined #openstack-horizon | 16:29 | |
| robcresswell | leitan: Have you got ADD_SCSS_FILES and AUTO_DISCOVER_STATIC_FILES in your enabled files? | 16:29 |
| leitan | let me check robcresswell but should | 16:29 |
| *** flwang1 has joined #openstack-horizon | 16:30 | |
| *** Mounica has quit IRC | 16:30 | |
| *** bpokorny has joined #openstack-horizon | 16:31 | |
| *** bpokorny has quit IRC | 16:31 | |
| *** bpokorny has joined #openstack-horizon | 16:32 | |
| matt-borland | TravT, sorry, was making breakfast | 16:32 |
| matt-borland | REGISTER ALL THE THINGS | 16:32 |
| TravT | i think its perfect. | 16:33 |
| TravT | moves more out of the controller. | 16:33 |
| TravT | anyway, i need to go get a cup of tea... | 16:34 |
| leitan | robcresswell, yes, the autodiscover is set | 16:34 |
| *** bpokorny_ has joined #openstack-horizon | 16:34 | |
| TravT | i somehow got sucked into a some other review. it is like the internet. you sit down to check the weather and end up ordering something on amazon | 16:35 |
| robcresswell | TravT: I'll just review some patches... *ends up reading about polar bears for 2 hours* | 16:36 |
| TravT | more like i sit down to check the weather and end up reviewing patches for 2 hours | 16:36 |
| TravT | ;) | 16:36 |
| robcresswell | haha | 16:36 |
| *** bpokorny has quit IRC | 16:37 | |
| *** Mzoorikh has joined #openstack-horizon | 16:38 | |
| *** zhenguo_ has quit IRC | 16:38 | |
| *** andrewbogott has quit IRC | 16:38 | |
| *** rbertram has quit IRC | 16:39 | |
| *** betherly has quit IRC | 16:39 | |
| *** jmccrory has quit IRC | 16:39 | |
| *** piet has quit IRC | 16:39 | |
| *** asahlin has quit IRC | 16:39 | |
| *** wasmum has joined #openstack-horizon | 16:40 | |
| *** asahlin has joined #openstack-horizon | 16:41 | |
| *** rbertram has joined #openstack-horizon | 16:41 | |
| *** betherly has joined #openstack-horizon | 16:41 | |
| robcresswell | leitan: I don't have much of a suggestion off the top of my head. My first thought would be that the file structure is not what is expect by the autodiscovery | 16:42 |
| robcresswell | But I don't have time to debug it just now | 16:42 |
| robcresswell | Sorry :/ | 16:42 |
| *** piet has joined #openstack-horizon | 16:43 | |
| *** aortega has quit IRC | 16:43 | |
| *** andrewbogott has joined #openstack-horizon | 16:44 | |
| *** jmccrory has joined #openstack-horizon | 16:44 | |
| *** zhenguo_ has joined #openstack-horizon | 16:44 | |
| *** Mzoorikh has quit IRC | 16:46 | |
| leitan | robcresswell, no worries | 16:48 |
| leitan | robcresswell, ill keep looking | 16:48 |
| leitan | robcresswell, thanks dough | 16:48 |
| *** Mzoorikh has joined #openstack-horizon | 16:48 | |
| *** hurgleburgler has joined #openstack-horizon | 16:48 | |
| *** piet has quit IRC | 16:49 | |
| *** amotoki has joined #openstack-horizon | 16:52 | |
| *** gariveradlt has joined #openstack-horizon | 16:53 | |
| *** Mzoorikh has quit IRC | 16:53 | |
| *** kzaitsev_mb has quit IRC | 16:53 | |
| *** kzaitsev_mb has joined #openstack-horizon | 16:53 | |
| *** rcernin has quit IRC | 16:56 | |
| *** vishwanathj has joined #openstack-horizon | 16:57 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 16:58 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Provide an integration test for dynamic themes https://review.openstack.org/279185 | 16:58 |
| *** lapalm has joined #openstack-horizon | 16:58 | |
| *** ygbo has quit IRC | 16:58 | |
| *** amotoki has quit IRC | 16:58 | |
| *** bpokorny_ has quit IRC | 17:01 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding resource type registry service https://review.openstack.org/278447 | 17:02 |
| *** bpokorny has joined #openstack-horizon | 17:02 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: [wip] experimental i9n failure on new tox.ini https://review.openstack.org/279189 | 17:02 |
| *** gyee has joined #openstack-horizon | 17:05 | |
| *** pushkaru has quit IRC | 17:06 | |
| *** vijendar has quit IRC | 17:06 | |
| *** aortega has joined #openstack-horizon | 17:07 | |
| *** petertr7_away is now known as petertr7 | 17:07 | |
| *** rudolfvriend has quit IRC | 17:08 | |
| robcresswell | itxaka: There seems to be more to the story. I fixed the template, but it still breaks | 17:11 |
| robcresswell | Not sure why | 17:11 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 17:11 |
| *** vijendar has joined #openstack-horizon | 17:13 | |
| *** e0ne has quit IRC | 17:14 | |
| *** Mounica has joined #openstack-horizon | 17:14 | |
| *** lhcheng has joined #openstack-horizon | 17:16 | |
| *** mpavlase has quit IRC | 17:19 | |
| matt-borland | TravT, wow, the registry will cut out a lot of very sad tests :) | 17:19 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 17:20 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 17:20 |
| *** wolverineav has joined #openstack-horizon | 17:20 | |
| ducttape_ | mrunge - follow up on https://review.openstack.org/#/c/243974/ , the local_settings.d changes. Do you know the longer plans for what will happen to local_settings.py ? I see this new change as a review, but the roadmap / future plans are still a bit vague to me | 17:22 |
| *** tyr has quit IRC | 17:22 | |
| ducttape_ | perhaps Thomas is in the room ? | 17:22 |
| *** petertr7 is now known as petertr7_away | 17:23 | |
| ducttape_ | or doug-fish could refresh my memory ?^ | 17:24 |
| *** pushkaru has joined #openstack-horizon | 17:24 | |
| doug-fish | ducttape_: we talked about one day deprecating local_settings.py ... but today may not be that day | 17:25 |
| ducttape_ | I'm wondering - why? what is wrong with local_settings.py that this now fixes ? | 17:25 |
| ducttape_ | trying to understand that, vs churn because someone had an alternate idea | 17:26 |
| doug-fish | it fixes the ability for a distro to create a package that doesn't modify local_settings.py but changes settings - key for theme support, offhand | 17:26 |
| *** wolverineav has quit IRC | 17:26 | |
| ducttape_ | is that really that much better? | 17:27 |
| doug-fish | the idea is that local_settings.py will go away and be replaced by local_settings.d/_50_local_settings.py so that prioritized settings fragments can be added by distros, configuration tools, etc | 17:27 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Disable metering with ceilometer https://review.openstack.org/272644 | 17:27 |
| ducttape_ | but they could do that by modifying local_settings.py too | 17:27 |
| ducttape_ | its just one file vs spread out in various files, it seems | 17:28 |
| doug-fish | except that kind of behavior works badly in the context of installing/uninstalling packages | 17:28 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 17:28 |
| ducttape_ | but a customer is still going to modify those local_Settings.d/ files too | 17:28 |
| ducttape_ | and those files would have similar install issue | 17:28 |
| ducttape_ | s | 17:28 |
| doug-fish | I don't think so ... | 17:28 |
| *** sambetts has joined #openstack-horizon | 17:29 | |
| tsufiev | a question to wide auditory: have anyone observed languages randomly changing in Horizon? | 17:29 |
| doug-fish | the priority of files should be clear from the order in local_settings.d | 17:29 |
| sambetts | robcresswell: Hi Rob | 17:29 |
| doug-fish | just like enabled files today | 17:29 |
| robcresswell | sambetts: o/ | 17:29 |
| ducttape_ | the priority is clear when it is in one file too, perhaps more clear | 17:29 |
| tsufiev | one of our customers reported such strange behavior on a 3 controllers HA config (= 3 Apache nodes behind HAProxy), I wonder if it's a common issue | 17:29 |
| ducttape_ | (devils advocate) | 17:29 |
| doug-fish | right - priority is a complete non issue - but again, package based installs are impossible | 17:30 |
| doug-fish | with the update priority should be clear enough and package based configuration is possible | 17:30 |
| ducttape_ | that is a bit strong of a statement, package installs have been around for years | 17:30 |
| doug-fish | how about "reasonable package based configuration is possible"? | 17:30 |
| doug-fish | are there many cases where a package is installed into Horizon that changes the settings? | 17:31 |
| ducttape_ | I'm not disagreeing with you, but trying to not change all the things, if nothing noticeable is changing. just tyring to weight the cost | 17:31 |
| doug-fish | I think that might be new for themes | 17:31 |
| *** SimonChung has joined #openstack-horizon | 17:31 | |
| doug-fish | understood | 17:31 |
| doug-fish | I think we are having a reasonable discussion, not arguing. Well, not yet anyway. | 17:32 |
| ducttape_ | yeah, I can kind of see this now, if you had a standalone theme, you do not want it to muck with an existing file | 17:32 |
| ducttape_ | and install / uninstall cleanly | 17:32 |
| ducttape_ | I get it, thanks for walking me through this | 17:33 |
| doug-fish | no worries | 17:33 |
| ducttape_ | tsufiev - if you had more info to share, we have run with a similar setup as you describe | 17:33 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 17:35 |
| tsufiev | ducttape_, well, according to scarce info I have, 'We are intermittently seeing language change in the horizon UI, which makes it unusable during that time. It usually goes away on its own but would like to find the root cause to stop this from happened. This doesnt affect all users at one time, we will see it sometimes or a user will. The browser doesnt seem to matter either.' | 17:36 |
| tsufiev | And it's an Icehouse | 17:36 |
| david-lyle | Icehouse? | 17:37 |
| david-lyle | that's what you get for living on the bleeding edge | 17:37 |
| tsufiev | :)) | 17:37 |
| ducttape_ | tsufiev - what is the session engine ? | 17:37 |
| david-lyle | yeah, I was thinking cookie overflow | 17:38 |
| tsufiev | cache backed by memcached | 17:38 |
| david-lyle | well, there goes that theory | 17:38 |
| ducttape_ | and those 3 horizon instances are all configured to use the same memcached instances ? | 17:38 |
| tsufiev | david-lyle, that was that I thought initially | 17:38 |
| david-lyle | but the cookies for language would be outside SESSION store | 17:39 |
| *** sid14726 has joined #openstack-horizon | 17:39 | |
| ducttape_ | also, for your horizon lb, what is the policy? source/RR/lconn ? | 17:39 |
| tsufiev | ducttape_, good point, I'll check that | 17:39 |
| *** itxaka has quit IRC | 17:39 | |
| tsufiev | didn't think about that possibility... but if they still use Icehouse, everything is possible | 17:39 |
| ducttape_ | i would bet if you switched to source, this goes away.... but this is still a problem somewhere | 17:40 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 17:40 |
| tsufiev | ducttape_, did lb policy in your experience cause this kind of effects? | 17:40 |
| ducttape_ | it certainly could | 17:41 |
| tsufiev | okay, will check that as well, thank you for clues, ducttape_ | 17:41 |
| ducttape_ | we try to use automation for all our nodes, they tend to be 100% consistent with each other. but I could see some snowflake config and a LB policy exposing this | 17:41 |
| *** garthb has joined #openstack-horizon | 17:42 | |
| *** vijendar1 has joined #openstack-horizon | 17:42 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding resource type registry service https://review.openstack.org/278447 | 17:43 |
| *** garthb has quit IRC | 17:45 | |
| *** rdopiera has quit IRC | 17:45 | |
| *** garthb has joined #openstack-horizon | 17:46 | |
| *** vijendar has quit IRC | 17:46 | |
| *** lhcheng has quit IRC | 17:48 | |
| *** lhcheng has joined #openstack-horizon | 17:49 | |
| *** lhcheng has quit IRC | 17:49 | |
| *** lhcheng has joined #openstack-horizon | 17:49 | |
| *** flwang1 has quit IRC | 17:49 | |
| *** lhcheng has quit IRC | 17:50 | |
| *** Guest15678 is now known as mariusv | 17:51 | |
| *** mariusv has quit IRC | 17:51 | |
| *** mariusv has joined #openstack-horizon | 17:51 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 17:53 |
| *** xinwu has joined #openstack-horizon | 17:56 | |
| *** wolverineav has joined #openstack-horizon | 17:57 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 18:00 |
| *** lhcheng has joined #openstack-horizon | 18:03 | |
| *** kzaitsev_mb has quit IRC | 18:05 | |
| *** sid14726 has quit IRC | 18:07 | |
| *** e0ne has joined #openstack-horizon | 18:15 | |
| *** rcernin has joined #openstack-horizon | 18:17 | |
| *** lhcheng has quit IRC | 18:19 | |
| *** tqtran has joined #openstack-horizon | 18:23 | |
| *** piet has joined #openstack-horizon | 18:24 | |
| *** tqtran has quit IRC | 18:27 | |
| *** tqtran has joined #openstack-horizon | 18:27 | |
| *** petertr7_away is now known as petertr7 | 18:33 | |
| *** zhenguo_ has quit IRC | 18:33 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Checkboxes are now themeable. https://review.openstack.org/252161 | 18:35 |
| *** zhenguo_ has joined #openstack-horizon | 18:36 | |
| *** garthb has quit IRC | 18:37 | |
| *** garthb has joined #openstack-horizon | 18:37 | |
| *** Mounica has quit IRC | 18:37 | |
| *** Mounica has joined #openstack-horizon | 18:38 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Webroot Theme is no longer needed https://review.openstack.org/213411 | 18:39 |
| *** gariveradlt has quit IRC | 18:40 | |
| *** matt-borland_ has joined #openstack-horizon | 18:43 | |
| *** matt-borland has quit IRC | 18:43 | |
| *** piet has quit IRC | 18:43 | |
| *** tosky has quit IRC | 18:46 | |
| *** garthb has quit IRC | 18:48 | |
| *** garthb has joined #openstack-horizon | 18:49 | |
| *** garthb has quit IRC | 18:50 | |
| *** vijendar1 has quit IRC | 18:51 | |
| *** garthb has joined #openstack-horizon | 18:51 | |
| *** gyee has quit IRC | 18:53 | |
| *** wolverineav has quit IRC | 18:53 | |
| *** vijendar has joined #openstack-horizon | 18:54 | |
| *** vijendar1 has joined #openstack-horizon | 18:55 | |
| *** amotoki has joined #openstack-horizon | 18:55 | |
| *** vijendar has quit IRC | 18:58 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Webroot Theme is no longer needed https://review.openstack.org/213411 | 18:58 |
| *** amotoki has quit IRC | 18:59 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:59 | |
| *** vishwana_ has joined #openstack-horizon | 19:00 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 19:02 |
| *** vishwanathj has quit IRC | 19:03 | |
| *** harlowja has joined #openstack-horizon | 19:04 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Radio Buttons are now themeable. https://review.openstack.org/278041 | 19:08 |
| sjmc7 | is anyone here familiar with websso in horizon? | 19:18 |
| *** wolverineav has joined #openstack-horizon | 19:18 | |
| *** wolverineav has quit IRC | 19:18 | |
| *** wolverineav has joined #openstack-horizon | 19:18 | |
| doug-fish | sjmc7: I know something about it | 19:20 |
| sjmc7 | i was just talking to our keystone folks.. they have a problem whereby we configure the KEYSTONE_URL in horizon to be an internal address | 19:21 |
| sjmc7 | i.e. not accessible from where a user’s browser might be | 19:21 |
| sjmc7 | unfortunately the same setting, OPENSTACK_KEYSTONE_URL, is used to construct websso URLs | 19:22 |
| sjmc7 | they just filed a blueprint to address it but it actually seems more like a bug to me | 19:22 |
| * doug-fish thinking | 19:23 | |
| sjmc7 | in general i wouldn’t expect OPENSTACK_KEYSTONE_URL to necessarily be routable to a user of horizon, though in some cases (using publicURLs, for instance), it might be | 19:23 |
| openstackgerrit | rajalokan proposed openstack/horizon: Fixed missing ',' in docs of Column:status_choices https://review.openstack.org/279239 | 19:26 |
| *** mpavlase has joined #openstack-horizon | 19:28 | |
| david-lyle | sjmc7: so, you want a mix of user/pass and websso? | 19:30 |
| david-lyle | where user/pass is internal and websso is external? | 19:31 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: disable metering with ceilometer https://review.openstack.org/272644 | 19:31 |
| *** jbell8 has joined #openstack-horizon | 19:31 | |
| *** vijendar1 has quit IRC | 19:31 | |
| *** wolverineav has quit IRC | 19:32 | |
| *** wolverineav has joined #openstack-horizon | 19:32 | |
| sjmc7 | david-lyle: potentially. we want traffic from horizon to keystone directly to go over one network, but not necessarily the one traffic from a browser goes over to horizon (or keystone for the websso redirect) | 19:32 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: disable metering with ceilometer https://review.openstack.org/272644 | 19:33 |
| sjmc7 | you could, for instance, set devstack up with OPENSTACK_KEYSTONE_URL=localhost:5000 and ENDPOINT_TYPE=publicURL and everything would work, but websso wouldn't | 19:34 |
| david-lyle | sjmc7: why? | 19:35 |
| sjmc7 | https://blueprints.launchpad.net/horizon/+spec/configurable-websso-keystone-url is the BP the keystone folks filed | 19:35 |
| sjmc7 | why would i do that? | 19:35 |
| david-lyle | nevermind localhost | 19:35 |
| *** jbell8 has quit IRC | 19:35 | |
| *** neelashah has quit IRC | 19:36 | |
| sjmc7 | if horizon’s running on a trusted network with other services, one might configure horizon such that traffic from horizon to those services went over that network | 19:36 |
| david-lyle | yeah, I get it | 19:36 |
| david-lyle | I'm fine with a second URL | 19:36 |
| *** jbell8 has joined #openstack-horizon | 19:37 | |
| david-lyle | not really a bp | 19:37 |
| sjmc7 | yeah, i was going to suggest they file it as a bug instead | 19:37 |
| sjmc7 | or just do it | 19:37 |
| david-lyle | but I guess we have one on the wrong project :P | 19:37 |
| *** alexvictorchan has joined #openstack-horizon | 19:37 | |
| david-lyle | d-o-a needs to release soon. just make it happen | 19:37 |
| sjmc7 | yep, will do | 19:37 |
| david-lyle | we'll want lhcheng to review too | 19:38 |
| sjmc7 | sure. i’ll get a patch up today | 19:38 |
| david-lyle | sjmc7: sounds good | 19:38 |
| david-lyle | mrunge: I think part of the concern from the ceilo folks is the display didn't really make sense even if it was fast | 19:42 |
| david-lyle | will comment on review, nvmd | 19:42 |
| *** gberginc has joined #openstack-horizon | 19:45 | |
| *** xinwu has quit IRC | 19:49 | |
| *** jbell8 has quit IRC | 19:51 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 19:52 |
| r1chardj0n3s | morning | 19:54 |
| *** Drago has quit IRC | 19:55 | |
| *** Drago has joined #openstack-horizon | 19:55 | |
| *** amotoki has joined #openstack-horizon | 19:56 | |
| *** neelashah has joined #openstack-horizon | 19:56 | |
| *** neelashah has quit IRC | 20:00 | |
| *** amotoki has quit IRC | 20:00 | |
| *** vijendar has joined #openstack-horizon | 20:02 | |
| *** neelashah has joined #openstack-horizon | 20:02 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add isOwner to userSession service https://review.openstack.org/279245 | 20:04 |
| *** vgridnev has joined #openstack-horizon | 20:07 | |
| matt-borland_ | belated good morning, r1chardj0n3s | 20:07 |
| r1chardj0n3s | matt-borland_: it's ok, I'm still not awake | 20:07 |
| r1chardj0n3s | and trying to digest the LIGO announcement, which is kinda crazy | 20:07 |
| matt-borland_ | missed it | 20:08 |
| matt-borland_ | TravT, I put a patchset up on the blessed Image Details, but it's less useful, except for the addition of the userSession.isOwner, which I decided to put in another patch. | 20:10 |
| r1chardj0n3s | matt-borland_: sorry, LIGO is not Horizon related ;-) | 20:10 |
| matt-borland_ | ah, current events :) | 20:11 |
| *** vijendar has quit IRC | 20:14 | |
| TravT | r1chardj0n3s: i saw that this morning... pretty amazing | 20:17 |
| openstackgerrit | Merged openstack/horizon: Adding hz-if-neutron-extensions directive https://review.openstack.org/252597 | 20:17 |
| openstackgerrit | Romain Hardouin proposed openstack/horizon: DataTable column level policy https://review.openstack.org/164010 | 20:20 |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/275486 | 20:21 |
| *** wolverin_ has joined #openstack-horizon | 20:21 | |
| *** rcernin has quit IRC | 20:24 | |
| *** wolverineav has quit IRC | 20:24 | |
| *** neelashah1 has joined #openstack-horizon | 20:25 | |
| *** neelashah has quit IRC | 20:28 | |
| openstackgerrit | Elena S proposed openstack/horizon: Add test_router integration test https://review.openstack.org/260360 | 20:28 |
| *** rdopiera has joined #openstack-horizon | 20:29 | |
| *** jtomasek has quit IRC | 20:31 | |
| openstackgerrit | Elena S proposed openstack/horizon: Add host aggregate create/delete test https://review.openstack.org/262323 | 20:31 |
| *** kzaitsev_mb has quit IRC | 20:32 | |
| *** flwang1 has joined #openstack-horizon | 20:32 | |
| *** xinwu has joined #openstack-horizon | 20:32 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 20:32 |
| *** neelashah1 has quit IRC | 20:37 | |
| *** julim has quit IRC | 20:40 | |
| *** ybathia has joined #openstack-horizon | 20:46 | |
| mrunge | david-lyle, sort of. ceilo does ad-hoc accumulation, where gnocchi uses pre-processing. the latter should suffice in many, many cases | 20:51 |
| *** Mounica has quit IRC | 20:52 | |
| *** e0ne has quit IRC | 20:53 | |
| mrunge | david-lyle, I wouldn't even blame ceilometer, we're using the wrong tool for the job, or expecting something, which can not be delivered from ceilometer by design. | 20:53 |
| david-lyle | mrunge: no, not blaming ceilo, but what we're trying to represent in that view is different than what the data represents | 20:54 |
| david-lyle | the view is just wrong | 20:55 |
| david-lyle | slow, but wrong | 20:55 |
| *** jprovazn has quit IRC | 20:55 | |
| mrunge | uhm, would you suggest a change in the patch then? | 20:55 |
| mrunge | s/patch/commit message/ ? | 20:55 |
| mrunge | or in release note? | 20:55 |
| david-lyle | that's where I was going with it, because slow suggests we could improve on that part by reducing the time slice | 20:56 |
| mrunge | reducing the time slice does not reduce the collected amount of data | 20:56 |
| *** sid14726 has joined #openstack-horizon | 20:57 | |
| *** lhcheng has joined #openstack-horizon | 21:00 | |
| *** vijendar has joined #openstack-horizon | 21:01 | |
| *** neelashah has joined #openstack-horizon | 21:02 | |
| *** matt-borland_ has quit IRC | 21:09 | |
| *** vishwanathj has joined #openstack-horizon | 21:13 | |
| *** kzaitsev_mb has joined #openstack-horizon | 21:14 | |
| *** vishwana_ has quit IRC | 21:15 | |
| *** neelashah has quit IRC | 21:16 | |
| *** dan_nguyen has quit IRC | 21:18 | |
| onovy | hi, can someone look to https://review.openstack.org/#/c/256771/ pls? | 21:18 |
| *** NightKhaos has quit IRC | 21:19 | |
| *** hurgleburgler has quit IRC | 21:21 | |
| *** NightKhaos has joined #openstack-horizon | 21:21 | |
| onovy | thanks :) | 21:22 |
| *** ybathia has quit IRC | 21:24 | |
| *** pauloewerton has quit IRC | 21:24 | |
| *** pushkaru has quit IRC | 21:27 | |
| *** pushkaru has joined #openstack-horizon | 21:28 | |
| *** hurgleburgler has joined #openstack-horizon | 21:36 | |
| *** Mounica has joined #openstack-horizon | 21:36 | |
| *** wolverin_ has quit IRC | 21:37 | |
| *** wolverineav has joined #openstack-horizon | 21:38 | |
| *** jbell8 has joined #openstack-horizon | 21:38 | |
| *** vijendar has quit IRC | 21:38 | |
| *** sid14726 has quit IRC | 21:42 | |
| *** rdopiera has quit IRC | 21:42 | |
| *** dan_nguyen has joined #openstack-horizon | 21:43 | |
| *** jbell8 has quit IRC | 21:44 | |
| *** jbell8 has joined #openstack-horizon | 21:45 | |
| *** leitan has quit IRC | 21:47 | |
| *** hurgleburgler has quit IRC | 21:48 | |
| *** neelashah has joined #openstack-horizon | 21:49 | |
| *** jbell8 has quit IRC | 21:49 | |
| *** hurgleburgler has joined #openstack-horizon | 21:50 | |
| *** bpokorny has quit IRC | 21:51 | |
| *** amotoki has joined #openstack-horizon | 21:56 | |
| *** garthb has quit IRC | 21:57 | |
| *** garthb has joined #openstack-horizon | 21:58 | |
| *** hurgleburgler has quit IRC | 21:59 | |
| *** hurgleburgler has joined #openstack-horizon | 22:00 | |
| *** _ducttape_ has joined #openstack-horizon | 22:00 | |
| *** amotoki has quit IRC | 22:01 | |
| *** chlong has quit IRC | 22:03 | |
| *** hurgleburgler has quit IRC | 22:03 | |
| *** ducttape_ has quit IRC | 22:03 | |
| *** petertr7 is now known as petertr7_away | 22:18 | |
| *** vgridnev has quit IRC | 22:19 | |
| *** lblanchard has quit IRC | 22:20 | |
| tqtran | TravT, r1chardj0n3s, robcresswell: i recently took a look at how we're handling delete in images, https://review.openstack.org/#/c/217422/ | 22:22 |
| r1chardj0n3s | yeah? | 22:23 |
| tqtran | we have 3 files to handle delete, thats just terrible... | 22:23 |
| TravT | tqtran: were your ears burning? | 22:23 |
| r1chardj0n3s | you mean batch-delete, delete-image and delete.action ... yeah | 22:23 |
| tqtran | delete.action.service.js is almost identical to batch-delete.action.service.js | 22:23 |
| TravT | i quite literally 5 minutes just said "there must be a way to improve that" | 22:23 |
| r1chardj0n3s | hah | 22:24 |
| tqtran | and delete-image.service.js is checking the policy twice, totally uneeeded | 22:24 |
| tqtran | https://review.openstack.org/#/c/202315/19/openstack_dashboard/dashboards/identity/static/dashboard/identity/users/actions/delete.action.service.js | 22:24 |
| tqtran | here is the pattern i had initially | 22:24 |
| tqtran | we should make that a service and reuse elsewhere | 22:24 |
| tqtran | pass in the context for your own custom messaging | 22:25 |
| tqtran | pass in a callback to handle the api deletes | 22:25 |
| tqtran | bam, done | 22:25 |
| TravT | unless i'm wrong your patch doesn't account for the difference in policy for single vs batch delete. | 22:25 |
| *** lapalm has quit IRC | 22:25 | |
| david-lyle | related to nothing: I rewrote my gerrit dashboard http://paste.openstack.org/show/486768/ if people would find it useful I can push to gerrit-dash-creator | 22:25 |
| tqtran | there are different policies for single vs batch delete? | 22:26 |
| david-lyle | policy should be the same for single or batch | 22:26 |
| TravT | let me put it another way | 22:26 |
| tqtran | david-lyle: oh wow, thats super nice | 22:26 |
| tqtran | yes, you should definitely push that | 22:27 |
| TravT | the action is visible on batch even though it may not be visible on row | 22:27 |
| david-lyle | TravT: that can be true yes | 22:27 |
| tqtran | that dhttps://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fhorizon+OR%0Aproject%3Aopenstack%2Fdjango_openstack_auth%29+status%3Aopen+NOT+label%3ACode%2DReview%3C%3D%2D2+branch%3Amaster&title=Horizon+Review+Dashboard&My+Patches=owner%3Aself&Starred+Reviews=is%3Astarred&Needs+final+%2B2=label%3AVerified%3E%3D1%2Cjenkins+NOT+labe | 22:27 |
| tqtran | l%3AWorkflow%3E%3D1+NOT+label%3AWorkflow%3C0+label%3ACode%2DReview%3E%3D2+limit%3A50+NOT+label%3ACode%2DReview%3E%3D2%2Cself+NOT+label%3ACode%2DReview%3C%3D%2D1%2Chorizon%2Dcore&You+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3AWorkflow%3C0+NOT+label%3ACode%2DReview%3C%3D2%2Cself+reviewe | 22:27 |
| tqtran | r%3Aself&Passed+Jenkins%2C+No+Negative+Core+Feedback+%28Small+Fixes%29=label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3AWorkflow%3C0+NOT+label%3ACode%2DReview%3E%3D2+NOT+label%3ACode%2DReview%3C%3D%2D1%2Chorizon%2Dcore+delta%3A%3C%3D10&Passed+Jenkins%2C+No+Negative+Feedback+%28Small+Fixes%29=label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3AWorkflow%3C0+N | 22:27 |
| tqtran | OT+label%3ACode%2DReview%3E%3D2+NOT+label%3ACode%2DReview%3C%3D%2D1%2Chorizon%2Dcore+NOT+label%3ACode%2DReview%3C%3D%2D1+delta%3A%3C%3D10&Passed+Jenkins%2C+No+Negative+Core+Feedback=label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3AWorkflow%3C0+NOT+label%3ACode%2DReview%3E%3D2+NOT+label%3ACode%2DReview%3C%3D%2D1%2Chorizon%2Dcore+NOT+label%3ACode%2DRevi | 22:27 |
| tqtran | ew%3C%3D%2D1+delta%3A%3E10&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3AWorkflow%3C0+NOT+label%3ACode%2DReview%3C%3D2+age%3A5d&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+20+days%29=label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3AWorkflow%3C0+NOT+labe | 22:27 |
| tqtran | l%3ACode%2DReview%3C%3D2+age%3A20d | 22:27 |
| tqtran | why would someone be able to delete a single row but not batch delete? | 22:27 |
| david-lyle | which makes batch actions problematic | 22:27 |
| TravT | holy crap | 22:27 |
| tqtran | or vice versa? that doesnt make any sense at all | 22:28 |
| david-lyle | tqtran: he's saying action is not available on row | 22:28 |
| TravT | it isn't just policy it is allowed or now | 22:28 |
| TravT | or not | 22:28 |
| david-lyle | but if you multiselect, the batch action will try | 22:28 |
| *** tyr has joined #openstack-horizon | 22:28 | |
| david-lyle | not necessarily policy either more the allowed() method | 22:28 |
| tqtran | what im saying is, dont show the deletes at all if the action is not allowed | 22:28 |
| TravT | david-lyle: exactly | 22:28 |
| david-lyle | tqtran: half may allow, half may not | 22:28 |
| TravT | that's why actions have an allowed and perform method | 22:29 |
| tqtran | ok hold on... let me try and understand this better | 22:29 |
| david-lyle | the plus side in a batch (python side) is that the exception is caught and handled | 22:29 |
| david-lyle | although you get an error message | 22:29 |
| tqtran | you guys are saying that it is possible for a user to delete a single row but cannot batch delete? | 22:30 |
| TravT | yes... | 22:30 |
| TravT | think about it | 22:30 |
| tqtran | what about - a user to batch delete but not row delete? | 22:30 |
| TravT | batch is based on selecting items in a row | 22:30 |
| TravT | you may have 5 different types of batch actions | 22:30 |
| david-lyle | the allowed method is not called when executing the batch action | 22:31 |
| TravT | you can't selectively enable disable each select box on a row | 22:31 |
| david-lyle | but it's called when rendering the table to hide the row action | 22:31 |
| TravT | because the checkbox is for any of the possible batch actions | 22:31 |
| tqtran | i see what you're saying... you're talking about in context of the searchlight table | 22:31 |
| tqtran | where you can have multiple deletes from different tables | 22:31 |
| TravT | no | 22:31 |
| TravT | yes | 22:31 |
| TravT | but in context of images table | 22:31 |
| david-lyle | any table | 22:31 |
| TravT | ng-images tqtran, django tables | 22:31 |
| TravT | etc, etc | 22:31 |
| *** sid14726 has joined #openstack-horizon | 22:32 | |
| david-lyle | If I have a VM in run state, batch booting it doesn't make sense | 22:32 |
| * david-lyle knows we don't have a batch start | 22:32 | |
| david-lyle | but the point is the same | 22:32 |
| david-lyle | the row action to start wouldn't be there | 22:32 |
| tqtran | heres the thing that bothers me though.... the single delete and batch delete are both checking the same policy | 22:33 |
| david-lyle | but if you multiselected the row and hit batch button, it would attempt to boot it anyway | 22:33 |
| david-lyle | policy is the wrong word | 22:33 |
| tqtran | https://review.openstack.org/#/c/217422/105/openstack_dashboard/static/app/core/images/actions/batch-delete.action.service.js L74 | 22:33 |
| david-lyle | because it's overloaded | 22:33 |
| david-lyle | there's policy file policy | 22:33 |
| david-lyle | and business rule policy | 22:33 |
| david-lyle | and the two are getting conflated | 22:33 |
| tqtran | https://review.openstack.org/#/c/217422/105/openstack_dashboard/static/app/core/images/actions/delete-image.service.js L57 | 22:34 |
| david-lyle | so not showing an action based on entity state is different then not showing it based on policy file policy, but both can hide the action | 22:34 |
| tqtran | right, if that i the case, then why dont have it for row action as well? | 22:35 |
| *** sshen has joined #openstack-horizon | 22:35 | |
| tqtran | https://review.openstack.org/#/c/217422/105/openstack_dashboard/static/app/core/images/actions/delete.action.service.js i dont see any allowed in here | 22:35 |
| david-lyle | because the action doesn't make sense for the entity and we're trying reinforce that | 22:35 |
| tqtran | and if we add allowed in there with the same policy, we go back to my initial point. they are exactly the same..... | 22:35 |
| TravT | are these reviews up to date? | 22:36 |
| TravT | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/actions/row-delete.service.js#L51 | 22:36 |
| TravT | they both use the same allowed | 22:36 |
| TravT | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/actions/delete-image.service.js#L83 | 22:36 |
| tqtran | yeah it is, omg... so hes linking it from the deleteImageService, that is super confusing | 22:36 |
| tqtran | its not consistent at all | 22:37 |
| tqtran | in one, hes defining it manually, in another he's delegating | 22:37 |
| *** _ducttape_ has quit IRC | 22:37 | |
| TravT | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/actions/batch-delete.service.js#L55 | 22:37 |
| *** ducttape_ has joined #openstack-horizon | 22:38 | |
| tqtran | yes thats the one where hes defining it manually | 22:38 |
| tqtran | and the one before that is delegating it to deleteImageService | 22:38 |
| TravT | actually, that's for view purposes, i think | 22:38 |
| tqtran | ugh, its just a complete mess, hopefully no one has copied the pattern yet | 22:38 |
| *** vijendar has joined #openstack-horizon | 22:38 | |
| tqtran | i'll take a stab at cleaning it up | 22:39 |
| tqtran | unless someone else wants to do it? | 22:39 |
| TravT | well, we also want to remove 4 other uneccessary files | 22:39 |
| *** jtriley has quit IRC | 22:40 | |
| tqtran | what other files? | 22:40 |
| TravT | batch-actions.service.js, batch-actions.service.spec.js, row-actions.service.js, row-actions.service.spec.js | 22:40 |
| TravT | completely repetitive and uneccessary | 22:40 |
| TravT | single registration service can do it and make them more reusable | 22:41 |
| TravT | https://review.openstack.org/#/c/278447/ | 22:42 |
| tqtran | TravT: dont know if you still talk to sqchen, but auto discovery isnt working well for JS plugins | 22:42 |
| tqtran | lbaas and zaqar are both listing JS files manually atm because autodiscovery is causing problems | 22:42 |
| TravT | i'm not sure that's a blocker on this | 22:42 |
| tqtran | its totally unrelated | 22:43 |
| TravT | sadly, i don't know what sqchen is doing now | 22:43 |
| TravT | :( | 22:43 |
| *** Drago has quit IRC | 22:43 | |
| tqtran | ok... looks like i will look into it then :( | 22:43 |
| *** hurgleburgler has joined #openstack-horizon | 22:44 | |
| r1chardj0n3s | TravT: hmm, at first glance, how is that "resource type registry" different from the exisitng angular event system? Do we need a separate registry? | 22:45 |
| TravT | event system? | 22:45 |
| TravT | i'm not quite sure i see how events play in | 22:45 |
| r1chardj0n3s | $scope.$emit and $on | 22:46 |
| *** leitan has joined #openstack-horizon | 22:46 | |
| TravT | if i want to be able to get actions that aren't hard coded to controller, how do i look them up? | 22:46 |
| tqtran | r1chardj0n3s: the event system only works when the controllers are linked | 22:46 |
| r1chardj0n3s | hmm, the registry groups actions by resource type, ok | 22:46 |
| r1chardj0n3s | solid | 22:46 |
| tqtran | if you have things from different tables, they are not linked, so it wont work | 22:46 |
| TravT | yes, so the other thing this does | 22:46 |
| TravT | is you can have a plugin that just adds a new aciton | 22:47 |
| TravT | so even in existing say images table | 22:47 |
| r1chardj0n3s | there still might be a need for separate batch actions vs. individual actions - does that work in the proposed registry model? | 22:47 |
| TravT | i could add a plugin that just registers a new action for it | 22:47 |
| TravT | yes | 22:47 |
| r1chardj0n3s | (swift, for example, has batch action handlers) | 22:47 |
| r1chardj0n3s | ok | 22:47 |
| r1chardj0n3s | matt's WIP -1'ed that patch, but I look forward to reviewing it | 22:47 |
| TravT | this registry also uses the extensible service | 22:48 |
| TravT | so, for batch or row actions you get all the prepend, append, replace capabilities for actions | 22:48 |
| tqtran | thats a big plus | 22:48 |
| r1chardj0n3s | I don't follow that | 22:48 |
| r1chardj0n3s | "the extensible service"? | 22:49 |
| *** matt-borland has joined #openstack-horizon | 22:49 | |
| matt-borland | hey everybody :) | 22:49 |
| TravT | let me point you to a paste | 22:49 |
| tqtran | extensible service allows you to do something like this https://review.openstack.org/#/c/244407/ | 22:49 |
| r1chardj0n3s | ahh, I see the ref now | 22:49 |
| TravT | r1chardj0n3s: see my comment on patch set 4 | 22:49 |
| TravT | of the registry service | 22:49 |
| r1chardj0n3s | aahhhh, this is the thing we talked about last midcycle? | 22:49 |
| TravT | yes | 22:50 |
| TravT | its in for workflows | 22:50 |
| tqtran | r1chardj0n3s: oh right, i could have just said that lol | 22:50 |
| TravT | this essentially makes it work for actions | 22:50 |
| TravT | so, that whiteboarding session we had became real... | 22:50 |
| TravT | imagine that | 22:50 |
| TravT | thanks jpomeroy | 22:50 |
| r1chardj0n3s | :-) | 22:50 |
| r1chardj0n3s | cool | 22:51 |
| TravT | sorry, i mean see my comments on patch set 5 of https://review.openstack.org/#/c/278447/ | 22:51 |
| TravT | tqtran: i started looking at your extensible docs last night | 22:52 |
| TravT | will try to give some feedback shortly | 22:53 |
| tqtran | TravT: thanks, much appreciated | 22:53 |
| * r1chardj0n3s also | 22:54 | |
| r1chardj0n3s | you made me notice it :-) | 22:54 |
| matt-borland | TravT, yeah, I'll clean up the image module code | 22:54 |
| jpomeroy | =] | 22:54 |
| TravT | the extensible service is really nice | 22:55 |
| TravT | jpomeroy, what do you think about my comment here: https://review.openstack.org/#/c/278447/9/openstack_dashboard/static/app/core/images/images.module.js | 22:55 |
| TravT | would be nice to be able to chain or send in multiple items... | 22:56 |
| TravT | again just a "would be nice" | 22:56 |
| jpomeroy | TravT, yep i can see that being handy | 22:56 |
| jpomeroy | i like the idea of returning the container | 22:57 |
| matt-borland | yeah, shouldn't be hard to do | 22:58 |
| TravT | jpomeroy: put a patch up! | 22:58 |
| matt-borland | :) | 22:58 |
| jpomeroy | =] | 22:58 |
| *** bpokorny has joined #openstack-horizon | 22:59 | |
| jpomeroy | yeah would be really simple, maybe later tonight | 22:59 |
| *** wolverin_ has joined #openstack-horizon | 23:02 | |
| *** wolverineav has quit IRC | 23:06 | |
| *** neelashah has quit IRC | 23:07 | |
| *** vishwanathj has quit IRC | 23:08 | |
| tqtran | david-lyle: that link is so cool..... didnt even know you can do that | 23:12 |
| david-lyle | tqtran: I had created an older one, but it had unnecessary stuff | 23:12 |
| tqtran | what is this gerrit-dash-creator you speak of? | 23:13 |
| david-lyle | tqtran: https://github.com/openstack/gerrit-dash-creator | 23:15 |
| tqtran | so if you upload to that the horizon one, thats what we will see from now on? | 23:16 |
| david-lyle | tqtran: you have to run a script and it generates the URL with the query built in | 23:17 |
| tqtran | ok, so its not on by default, you still have to use the url | 23:17 |
| david-lyle | save the link and go there instead of just review.openstack.org | 23:17 |
| david-lyle | yeah | 23:17 |
| tqtran | i see | 23:17 |
| *** sid14726 has quit IRC | 23:18 | |
| david-lyle | but much more useful than the default view | 23:18 |
| tqtran | i like it though, helps | 23:18 |
| *** ybathia has joined #openstack-horizon | 23:18 | |
| tqtran | too bad we dont have one for marking priority | 23:18 |
| tqtran | and ordering them in nice little sections | 23:18 |
| david-lyle | tqtran: not sure that's possible | 23:19 |
| david-lyle | but would be nice | 23:19 |
| *** ybathia_ has joined #openstack-horizon | 23:21 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Angular Table Directive https://review.openstack.org/252014 | 23:21 |
| *** xinwu has quit IRC | 23:22 | |
| *** ybathia has quit IRC | 23:23 | |
| *** jpomeroy has quit IRC | 23:24 | |
| *** ybathia has joined #openstack-horizon | 23:24 | |
| *** ybathia_ has quit IRC | 23:26 | |
| *** matt-borland has quit IRC | 23:26 | |
| *** pushkaru has quit IRC | 23:27 | |
| *** dan_nguyen has quit IRC | 23:28 | |
| *** chlong has joined #openstack-horizon | 23:30 | |
| *** SimonChung has quit IRC | 23:31 | |
| *** SimonChung1 has joined #openstack-horizon | 23:31 | |
| *** mpavlase has quit IRC | 23:32 | |
| *** outofmemory is now known as reedip | 23:36 | |
| *** wolverin_ is now known as wolverineav | 23:43 | |
| openstackgerrit | Merged openstack/horizon: Add breadcrumbs on Network Detail https://review.openstack.org/270012 | 23:44 |
| *** wolverineav has quit IRC | 23:45 | |
| openstackgerrit | Merged openstack/horizon: Try to be more verbose on sec group error https://review.openstack.org/246275 | 23:48 |
| *** xinwu has joined #openstack-horizon | 23:48 | |
| openstackgerrit | Merged openstack/horizon: Allow setting default value for config_drive https://review.openstack.org/271464 | 23:48 |
| *** ducttape_ has quit IRC | 23:55 | |
| *** absubram has quit IRC | 23:57 | |
| *** amotoki has joined #openstack-horizon | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!