*** jtriley has quit IRC | 00:09 | |
*** errolpais has joined #openstack-horizon | 00:11 | |
*** aortega_ has quit IRC | 00:42 | |
*** yamamoto has quit IRC | 00:55 | |
*** yamamoto has joined #openstack-horizon | 01:07 | |
*** fedexo has quit IRC | 01:24 | |
*** julim has quit IRC | 01:27 | |
*** Drago has quit IRC | 01:31 | |
*** Drago has joined #openstack-horizon | 01:31 | |
*** errolpais has quit IRC | 01:32 | |
*** btully has quit IRC | 01:43 | |
*** jtriley has joined #openstack-horizon | 01:43 | |
*** jerrygb has joined #openstack-horizon | 01:44 | |
*** zhenguo has joined #openstack-horizon | 01:48 | |
*** jtriley has quit IRC | 01:50 | |
*** zhurong has joined #openstack-horizon | 01:53 | |
*** jerrygb has quit IRC | 02:05 | |
*** jerrygb has joined #openstack-horizon | 02:05 | |
*** jerrygb has quit IRC | 02:10 | |
*** ducttape_ has joined #openstack-horizon | 02:11 | |
*** nlahouti has joined #openstack-horizon | 02:17 | |
*** nlahouti1 has joined #openstack-horizon | 02:19 | |
*** nlahouti has quit IRC | 02:21 | |
*** nlahouti1 has quit IRC | 02:30 | |
*** ducttape_ has quit IRC | 02:34 | |
*** jtriley has joined #openstack-horizon | 02:45 | |
openstackgerrit | Shan Guo proposed openstack/horizon: VPN forms help text could be improved https://review.openstack.org/248512 | 02:56 |
---|---|---|
*** btully has joined #openstack-horizon | 03:02 | |
*** jerrygb has joined #openstack-horizon | 03:06 | |
*** btully has quit IRC | 03:07 | |
*** jerrygb has quit IRC | 03:11 | |
*** neelashah has joined #openstack-horizon | 03:35 | |
*** neelashah has quit IRC | 03:37 | |
*** KingKhan has joined #openstack-horizon | 03:51 | |
*** SurajD has joined #openstack-horizon | 03:54 | |
*** wuhg has joined #openstack-horizon | 03:55 | |
*** SurajD has quit IRC | 04:00 | |
*** ducttape_ has joined #openstack-horizon | 04:01 | |
*** ducttape_ has quit IRC | 04:04 | |
*** ducttape_ has joined #openstack-horizon | 04:05 | |
*** SurajD has joined #openstack-horizon | 04:06 | |
*** errolpais has joined #openstack-horizon | 04:08 | |
*** jtriley has quit IRC | 04:11 | |
*** agireud has quit IRC | 04:18 | |
*** agireud has joined #openstack-horizon | 04:20 | |
*** Ramanjaneya has joined #openstack-horizon | 04:24 | |
*** agireud has quit IRC | 04:25 | |
*** shunliz has joined #openstack-horizon | 04:38 | |
*** jbell8 has joined #openstack-horizon | 04:39 | |
*** jbell8 has quit IRC | 04:39 | |
*** SurajD has quit IRC | 04:41 | |
*** SurajD has joined #openstack-horizon | 04:42 | |
*** agireud has joined #openstack-horizon | 04:46 | |
*** yamamoto has quit IRC | 04:50 | |
*** Drago has quit IRC | 05:06 | |
*** Drago has joined #openstack-horizon | 05:07 | |
*** jtriley has joined #openstack-horizon | 05:08 | |
*** masco has joined #openstack-horizon | 05:11 | |
*** zhurong has quit IRC | 05:12 | |
*** zhurong has joined #openstack-horizon | 05:12 | |
*** jtriley has quit IRC | 05:14 | |
*** ducttape_ has quit IRC | 05:16 | |
*** nlahouti has joined #openstack-horizon | 05:16 | |
*** btully has joined #openstack-horizon | 05:26 | |
*** yamamoto has joined #openstack-horizon | 05:28 | |
*** Drago has quit IRC | 05:31 | |
*** nlahouti has quit IRC | 05:31 | |
*** ducttape_ has joined #openstack-horizon | 05:31 | |
*** ducttape_ has quit IRC | 05:32 | |
*** ducttape_ has joined #openstack-horizon | 05:33 | |
*** KingKhan has quit IRC | 05:33 | |
*** rcernin has joined #openstack-horizon | 05:36 | |
*** ducttape_ has quit IRC | 05:37 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Handle absence of cinder default volume type https://review.openstack.org/248531 | 05:41 |
*** rcernin has quit IRC | 05:42 | |
*** lhcheng has joined #openstack-horizon | 06:00 | |
*** aortega has joined #openstack-horizon | 06:05 | |
openstackgerrit | Ramanjaneya Reddy Palleti proposed openstack/horizon: Horizon support for Service Function Chaining https://review.openstack.org/231868 | 06:16 |
openstackgerrit | Shan Guo proposed openstack/horizon: VPN forms help text could be improved https://review.openstack.org/248512 | 06:17 |
*** yamamoto has quit IRC | 06:20 | |
*** lhcheng has quit IRC | 06:22 | |
*** mpavlase has joined #openstack-horizon | 06:23 | |
openstackgerrit | Ramanjaneya Reddy Palleti proposed openstack/horizon: Horizon support for Service Function Chaining https://review.openstack.org/231868 | 06:23 |
*** aortega has quit IRC | 06:27 | |
*** errolpais has quit IRC | 06:30 | |
*** jhesketh has quit IRC | 06:31 | |
*** jhesketh has joined #openstack-horizon | 06:34 | |
*** ygl has joined #openstack-horizon | 06:39 | |
*** lhcheng has joined #openstack-horizon | 06:43 | |
*** mohankumar_ has joined #openstack-horizon | 06:43 | |
*** zhurong has quit IRC | 06:47 | |
*** zhurong has joined #openstack-horizon | 06:47 | |
openstackgerrit | Shan Guo proposed openstack/horizon: VPN forms help text could be improved7 8 The help text (both tooltips, and descriptive text on the right hand side) for VPN forms (Create, Ed it etc.) is very sparse, and we should update it with more information from the VPN docs or API docs https://review.openstack.org/248546 | 06:52 |
openstackgerrit | Shan Guo proposed openstack/horizon: VPN forms help text could be improved https://review.openstack.org/248546 | 06:56 |
*** lhcheng_ has joined #openstack-horizon | 06:57 | |
*** nlahouti has joined #openstack-horizon | 06:58 | |
*** lhcheng has quit IRC | 07:00 | |
*** rcernin has joined #openstack-horizon | 07:07 | |
*** jtriley has joined #openstack-horizon | 07:10 | |
*** jtriley has quit IRC | 07:15 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: API to Get a Volume, Volume Types and a Volume Type https://review.openstack.org/241415 | 07:16 |
*** yamamoto has joined #openstack-horizon | 07:17 | |
*** openstack has joined #openstack-horizon | 07:20 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add support for identity provider management https://review.openstack.org/244991 | 07:23 |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add basic CRUD for federation mapping https://review.openstack.org/248551 | 07:23 |
*** jingjing_ren has joined #openstack-horizon | 07:31 | |
*** yamamoto has quit IRC | 07:34 | |
*** jingjing_ren has quit IRC | 07:35 | |
*** yamamoto has joined #openstack-horizon | 07:36 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add support for identity provider management https://review.openstack.org/244991 | 07:38 |
*** mohankumar_ has quit IRC | 07:41 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add basic CRUD for federation mapping https://review.openstack.org/248551 | 07:41 |
*** nlahouti has quit IRC | 07:45 | |
*** nlahouti has joined #openstack-horizon | 07:47 | |
*** jerrygb has joined #openstack-horizon | 07:51 | |
*** jerrygb has quit IRC | 07:57 | |
*** itxaka has joined #openstack-horizon | 07:57 | |
*** rdopiera has joined #openstack-horizon | 08:01 | |
*** Ala has joined #openstack-horizon | 08:04 | |
*** nlahouti has quit IRC | 08:13 | |
openstackgerrit | Di XiaoLi proposed openstack/horizon: Add handle get_file when launch stack from horizon https://review.openstack.org/241700 | 08:22 |
openstackgerrit | Shan Guo proposed openstack/horizon: VPN forms help text could be improved https://review.openstack.org/248546 | 08:22 |
*** ygbo has joined #openstack-horizon | 08:23 | |
*** btully has quit IRC | 08:25 | |
*** josecastroleon has joined #openstack-horizon | 08:29 | |
*** zsli_ has joined #openstack-horizon | 08:30 | |
*** shunliz has quit IRC | 08:33 | |
betherly | Morning! | 08:45 |
*** SurajD has quit IRC | 08:46 | |
*** SurajD has joined #openstack-horizon | 08:49 | |
*** btully has joined #openstack-horizon | 08:51 | |
pkarikh | betherly: morning. :) | 08:53 |
*** aortega has joined #openstack-horizon | 08:54 | |
lhcheng_ | morning! | 08:54 |
*** btully has quit IRC | 08:56 | |
*** yamamoto has quit IRC | 09:00 | |
pkarikh | lhcheng_: is it morning in your timezone now? | 09:03 |
*** zhurong has quit IRC | 09:08 | |
*** SurajD has quit IRC | 09:08 | |
*** SurajD has joined #openstack-horizon | 09:09 | |
openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 09:10 |
mrunge | oh, good night lhcheng_ | 09:11 |
lhcheng_ | pkarikh: yes, 10am. working in euro timezone for the next month :) | 09:11 |
*** jtriley has joined #openstack-horizon | 09:11 | |
mrunge | and good morning all | 09:11 |
mrunge | oh! lhcheng_ then good morning o/ | 09:11 |
pkarikh | lhcheng_: nice! | 09:11 |
lhcheng_ | mrunge: good morning! o/ | 09:11 |
pkarikh | lhcheng_, mrunge: since you are here. What ro you think about this prorosial to add debreach into Horizon? https://review.openstack.org/#/c/247838/2 | 09:12 |
pkarikh | *are you think | 09:12 |
lhcheng_ | not sure about it, the fact that django didn't prioritize this seems odd | 09:13 |
mrunge | yeah, same here | 09:13 |
mrunge | I thought, it's a good idea; on the other side, BREACH was 2013? | 09:14 |
mrunge | so, why is that being added now? | 09:14 |
pkarikh | yep, same thoghts. Looks like django don't care | 09:14 |
*** mohankumar_ has joined #openstack-horizon | 09:14 | |
*** tmazur has joined #openstack-horizon | 09:15 | |
mrunge | pkarikh, with that being said, I'm twofold here | 09:15 |
*** jtriley has quit IRC | 09:16 | |
lhcheng_ | I feel like this is more of a security hardening that's up to deployer to add | 09:20 |
mrunge | I feel, something like this belongs to Django, since it's a general issue | 09:22 |
mrunge | and not to Horizon | 09:22 |
pkarikh | Also looks like deployer can disable django GZIP middleware, if he want. | 09:22 |
mrunge | uhm, httpd deflate that'll be | 09:23 |
mrunge | ah, both | 09:23 |
pkarikh | yep. https://bugs.launchpad.net/ossn/+bug/1209250 . See the section "Recommended Actions" | 09:24 |
openstack | Launchpad bug 1209250 in OpenStack Security Notes "Configure Horizon to mitigate BREACH/CRIME attacks" [Undecided,Fix released] - Assigned to Robert Clark (robert-clark) | 09:24 |
mrunge | pkarikh, https://code.djangoproject.com/ticket/20869 | 09:25 |
openstack | Django bug 20869 in CSRF "Prevent repetitive output to counter BREACH-type attacks" [Normal,Assigned] - Assigned to Unknown | 09:25 |
mrunge | that's the ticket in Django | 09:25 |
*** e0ne has joined #openstack-horizon | 09:28 | |
*** vgridnev has joined #openstack-horizon | 09:29 | |
*** SurajD has quit IRC | 09:34 | |
pkarikh | mrunge: yes, I've seen it. Maybe lhcheng_ is right and it's up to deployer. | 09:38 |
*** bluex has joined #openstack-horizon | 09:39 | |
mrunge | pkarikh, or up to the installer? | 09:39 |
*** bluex has quit IRC | 09:40 | |
mrunge | wouldn't that be an idea for puppet modules to match this? | 09:40 |
*** bluex has joined #openstack-horizon | 09:40 | |
*** aix has joined #openstack-horizon | 09:43 | |
lhcheng_ | I think we should just update this: https://github.com/openstack/horizon/blob/master/doc/source/topics/deployment.rst#secure-site-recommendations | 09:45 |
lhcheng_ | that's all we'll do, don't add BREACH middleware part of horizon. | 09:46 |
*** ygl has left #openstack-horizon | 09:46 | |
pkarikh | lhcheng_: it was my next idea - just to add note about it in docs. | 09:49 |
pkarikh | mrunge: maybe so. But I confused that django team ignoring it for two years anyway. Maybe I'm just too paranoid. | 09:50 |
*** zsli_ has quit IRC | 09:51 | |
*** aix has quit IRC | 09:52 | |
mrunge | pkarikh, they have been sensible in the past with security issues; either there is no solution, or they don't believe, it's up to them? | 09:52 |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Remove data-type from flavor column https://review.openstack.org/248594 | 09:55 |
*** mohankumar_ has quit IRC | 09:55 | |
*** zhenguo has quit IRC | 09:56 | |
*** bluex has quit IRC | 09:59 | |
*** JeanBriceCombebi has joined #openstack-horizon | 10:00 | |
*** yamamoto has joined #openstack-horizon | 10:01 | |
*** mohankumar_ has joined #openstack-horizon | 10:01 | |
*** bluex has joined #openstack-horizon | 10:05 | |
*** josecastroleon has quit IRC | 10:05 | |
*** yamamoto has quit IRC | 10:06 | |
*** jerrygb has joined #openstack-horizon | 10:08 | |
*** haypo has joined #openstack-horizon | 10:11 | |
*** JeanBriceCombebi has quit IRC | 10:12 | |
*** JeanBriceCombebi has joined #openstack-horizon | 10:12 | |
*** jerrygb has quit IRC | 10:13 | |
*** yamamoto has joined #openstack-horizon | 10:13 | |
*** JeanBriceCombebi has quit IRC | 10:18 | |
*** JeanBriceCombebi has joined #openstack-horizon | 10:18 | |
*** aix has joined #openstack-horizon | 10:24 | |
*** tmazur has quit IRC | 10:26 | |
*** tmazur has joined #openstack-horizon | 10:29 | |
*** mflobo has joined #openstack-horizon | 10:36 | |
*** mflobo has left #openstack-horizon | 10:37 | |
*** sambetts-afk is now known as sambetts | 10:45 | |
*** josecastroleon has joined #openstack-horizon | 10:46 | |
*** tsufiev_ is now known as tsufiev | 10:54 | |
*** bluex has quit IRC | 10:58 | |
*** yamamoto has quit IRC | 11:07 | |
*** Ephur has joined #openstack-horizon | 11:09 | |
*** Liuqing has joined #openstack-horizon | 11:10 | |
*** jtriley has joined #openstack-horizon | 11:11 | |
*** yamamoto has joined #openstack-horizon | 11:15 | |
*** jtriley has quit IRC | 11:16 | |
*** Ala has quit IRC | 11:18 | |
*** Ephur has quit IRC | 11:26 | |
*** erlon has joined #openstack-horizon | 11:27 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Add integration tests section to testing docs https://review.openstack.org/238959 | 11:32 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Add integration tests section to testing docs https://review.openstack.org/238959 | 11:32 |
openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/248431 | 11:34 |
*** bluex has joined #openstack-horizon | 11:39 | |
*** ^Gal^ has joined #openstack-horizon | 11:43 | |
*** raorn_ is now known as raorn | 11:44 | |
*** josecastroleon has quit IRC | 11:45 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon: Replace "Terminate Instance" with "Delete Instance" https://review.openstack.org/231428 | 11:48 |
robcresswell | mrunge: Do Debian/ Fedora expect the same /etc/openstack_dashboard dir? Just wondering if there's any oddities like it being openstack-dashboard etc. | 11:49 |
robcresswell | tsufiev is back! | 11:49 |
robcresswell | \o/ | 11:49 |
mrunge | robcresswell, Fedora/CentOS uses /etc/openstack-dashboard | 11:49 |
robcresswell | ah, okay | 11:49 |
mrunge | robcresswell, if that's an issue, why don't making the directory configurable? | 11:50 |
mrunge | that could be done in settings.py | 11:50 |
lhcheng_ | that should be in /usr/share right mrunge? | 11:50 |
*** kzaitsev_mb has joined #openstack-horizon | 11:50 | |
mrunge | lhcheng_, sorry? | 11:50 |
robcresswell | mrunge: Sure, just trying to figure out most sane default | 11:50 |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Translate Floating IPs on overview page https://review.openstack.org/248633 | 11:50 |
lhcheng_ | mrunge: /usr/share/openstack-dashboard? | 11:51 |
robcresswell | I finish modularising settings and .ini overrides works now. Also local_settings.py continues to work as expected. | 11:51 |
robcresswell | So, thats good progress. | 11:51 |
mrunge | lhcheng_, we were talking about local_settings or replacing settings with something more sane | 11:51 |
lhcheng_ | oops, nvm | 11:51 |
mrunge | lhcheng_, upstream horizon corrently doesn't care about settings being placed under /etc.... | 11:52 |
robcresswell | lhcheng_: Whats your tz? I thought you were in the US... | 11:52 |
lhcheng_ | robcresswell: working from Paris atm | 11:52 |
mrunge | linking is an option, but sane approach would be to read directly from /etc/openstack-dashboard | 11:52 |
robcresswell | lhcheng_: Oh awesome! | 11:53 |
robcresswell | mrunge: Yeah, I'll use that as the default for testing things for now. Still needs a lot of work, need docs/testing too, will propose idea in a couple weeks. | 11:53 |
robcresswell | But hopefully this will alleviate a couple of the packaging issues :) | 11:54 |
mrunge | robcresswell, sounds great! | 11:54 |
*** shunliz has joined #openstack-horizon | 12:07 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Eliminate mutable default arguments https://review.openstack.org/225613 | 12:12 |
*** josecastroleon has joined #openstack-horizon | 12:14 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Pay attention to Nova disabled quotas defined in a config file https://review.openstack.org/215277 | 12:15 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor updating neutron quotas during project update https://review.openstack.org/216645 | 12:15 |
tsufiev | robcresswell, yep! And hello :) | 12:19 |
*** KingKhan has joined #openstack-horizon | 12:19 | |
tsufiev | robcresswell, seems that integration tests are still non-voting? | 12:19 |
tsufiev | were there any new failures that prevented making them voting? | 12:20 |
*** zhurong has joined #openstack-horizon | 12:25 | |
*** zhurong has quit IRC | 12:26 | |
*** btully has joined #openstack-horizon | 12:28 | |
*** aortega has quit IRC | 12:31 | |
*** masco has quit IRC | 12:31 | |
*** btully has quit IRC | 12:32 | |
*** pauloewerton has joined #openstack-horizon | 12:34 | |
robcresswell | tsufiev: Not afaik. They should be made voting now. | 12:42 |
robcresswell | tsufiev: https://review.openstack.org/#/c/248673/ ? | 12:47 |
*** aix has quit IRC | 12:47 | |
*** aix has joined #openstack-horizon | 12:48 | |
*** Daisy has joined #openstack-horizon | 12:49 | |
*** ygl has joined #openstack-horizon | 12:54 | |
*** Daisy has quit IRC | 12:55 | |
*** Daisy has joined #openstack-horizon | 12:56 | |
*** jerrygb has joined #openstack-horizon | 12:59 | |
*** jerrygb has quit IRC | 12:59 | |
*** jerrygb has joined #openstack-horizon | 12:59 | |
*** KingKhan has quit IRC | 13:00 | |
*** Daisy has quit IRC | 13:00 | |
*** ygl has left #openstack-horizon | 13:00 | |
*** jerrygb_ has joined #openstack-horizon | 13:00 | |
*** jerrygb has quit IRC | 13:03 | |
*** aortega has joined #openstack-horizon | 13:05 | |
tsufiev | robcresswell, thank you, +1-ed :) | 13:07 |
*** ducttape_ has joined #openstack-horizon | 13:11 | |
*** jtriley has joined #openstack-horizon | 13:12 | |
*** jtriley has quit IRC | 13:17 | |
robcresswell | tsufiev: We have bug day tomorrow btw, if you didnt see the email :D | 13:20 |
*** ducttape_ has quit IRC | 13:22 | |
*** ducttape_ has joined #openstack-horizon | 13:22 | |
*** Ala has joined #openstack-horizon | 13:22 | |
lhcheng_ | robcresswell mrunge: when you get the chance: https://review.openstack.org/#/c/248208/ I moved the release notes in L to the yaml format. | 13:24 |
mrunge | didn't I already +2'ed that? | 13:25 |
*** doug-fish has joined #openstack-horizon | 13:25 | |
mrunge | heh | 13:25 |
lhcheng_ | mrunge: I think that was the backport to add the reno library to stable/liberty | 13:25 |
robcresswell | lhcheng_: Nice, thanks. Starred, will get to it a bit later. | 13:26 |
lhcheng_ | robcresswell: thank you sir | 13:26 |
mrunge | lhcheng_, are you satisfied with the doa patches around domain tokens? | 13:27 |
*** ducttape_ has quit IRC | 13:27 | |
lhcheng_ | the patch will try to scoped to a domain every login, that concerns me since it will generate noise on the keystone log | 13:28 |
openstackgerrit | Merged openstack/horizon: Add Reject option to Firewall Rules https://review.openstack.org/246190 | 13:29 |
*** tmazur has quit IRC | 13:29 | |
lhcheng_ | operators may have setup some sort of security monitoring on the logs, the noise from doa will trigger false alarms | 13:30 |
mrunge | got you | 13:30 |
mrunge | that will trigger false alarms for sure | 13:30 |
*** lapalm has joined #openstack-horizon | 13:30 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add Developer Dashboard + Bootstrap Theme Preview https://review.openstack.org/209631 | 13:30 |
robcresswell | That Firewall rule Reject option has zero tests :( | 13:31 |
lhcheng_ | I don't know if I'm just paranoid, but I feel like that we should not be trying to scope to domain every time | 13:31 |
mrunge | that needs to be documented then, lhcheng_ | 13:33 |
mrunge | robcresswell, yes, right. but what would you test there? | 13:33 |
lhcheng_ | robcresswell: I don't think it would be fair to ask test for that patch, we don't tests each value on a choice dropdown. | 13:33 |
mrunge | just test, that this option is there? | 13:33 |
tsufiev | lhcheng_, btw, is NOT_REGISTERED status for releasenotes job is an expected thing? (I got an impression, that you're driving this change) | 13:33 |
robcresswell | Oh, I just glanced at the merge and saw there were no tests, my bad | 13:34 |
lhcheng_ | mrunge: yeah, I don't know what to test either :P | 13:34 |
mrunge | but tbh, missing tests was my concern, too | 13:35 |
mrunge | there's just no valuable test for that | 13:35 |
robcresswell | It makes me uneasy that we can add new options without any type of alteration to any tests or test data lol. | 13:35 |
*** aortega has quit IRC | 13:35 | |
robcresswell | Like... someone can remove that option, and no test would catch it | 13:35 |
*** aortega has joined #openstack-horizon | 13:35 | |
mrunge | right. worse: those options are passed to underlying services | 13:36 |
*** Ramanjaneya has quit IRC | 13:37 | |
robcresswell | Its a minor thing anyway. Horizon has bigger issues :) | 13:37 |
*** JeanBriceCombebi has quit IRC | 13:37 | |
lhcheng_ | robcresswell: right.. yeah, that would be bad if someone removes it.. no way to catch it. :( | 13:39 |
* robcresswell grumbles out horizon more | 13:40 | |
robcresswell | about* | 13:40 |
mrunge | yeah, scrap that crap, move to console client. it's scriptable ;-) | 13:40 |
mrunge | oh, guys, what do you think about sorting by flavor? | 13:42 |
mrunge | it seems, anyone has an own opinion on that? | 13:42 |
robcresswell | mrunge: Sort by flavor? | 13:43 |
mrunge | this is mostly bug 1518893 | 13:43 |
openstack | bug 1518893 in OpenStack Dashboard (Horizon) "Instance flavor column does not sort the proper way" [Undecided,In progress] https://launchpad.net/bugs/1518893 - Assigned to Itxaka (itxakaserrano) | 13:43 |
mrunge | robcresswell, in instances table | 13:43 |
robcresswell | Got it | 13:43 |
*** JeanBriceCombebi has joined #openstack-horizon | 13:43 | |
robcresswell | Er, thats a weird one. | 13:45 |
robcresswell | I guess there is no obvious "size" of a flavor to sort by. So name seems logical in that case. | 13:46 |
mrunge | I'd vote for removing sort for flavor completely | 13:46 |
*** mohankumar_ has quit IRC | 13:46 | |
lhcheng_ | I don't know if the sorting by size is useful. | 13:46 |
mrunge | robcresswell, one would argue for: flavor name, another for size, another for sorting by price | 13:46 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix for the broken header's dropdowns for both v0.11.2 and v0.13 https://review.openstack.org/218815 | 13:46 |
robcresswell | Hmmm | 13:47 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix for the broken header's dropdowns for both v0.11.2 and v0.13 https://review.openstack.org/218815 | 13:48 |
tsufiev | resolved merge conflict ^^ | 13:49 |
*** ccesario has quit IRC | 13:49 | |
*** Daisy has joined #openstack-horizon | 13:49 | |
robcresswell | mrunge: I think you're right. | 13:50 |
lhcheng_ | mrunge: It would be more intuitive to just sort by the data rendered. But if we remove the sorting, doesn't that mean we're removing a feature in horizon? | 13:52 |
robcresswell | What even is "size" in this context? | 13:52 |
robcresswell | A flavour has many different aspects. | 13:52 |
robcresswell | lhcheng_: Also true. | 13:53 |
* robcresswell does not have very strong opinions on this. | 13:53 | |
mrunge | lhcheng_, but if the feature is broken? | 13:53 |
mrunge | and: what size? cpu? RAM? disk? network quota? what? | 13:53 |
mrunge | I mean, there are so many dimensions to sort on | 13:54 |
robcresswell | Well, allowing a grouping by name has value. So all tiny would be grouped etc. | 13:54 |
mrunge | yepp, that's right | 13:54 |
robcresswell | I'm not actually sure what 'size' is in the context of that table. | 13:54 |
lhcheng_ | mrunge: not 100% broken, for some people maybe they expect the sorting to be by size? | 13:54 |
lhcheng_ | :P | 13:54 |
lhcheng_ | so current behavior is okay. | 13:55 |
mrunge | but robcresswell that grouping works only for instances on that single instances page | 13:55 |
robcresswell | >.< | 13:55 |
lhcheng_ | if we don't care about breaking anyone, I also prefer turning off the sorting | 13:55 |
lhcheng_ | if they to be able to sort on some special value, have the ops customize the table and add a column for that special value | 13:56 |
robcresswell | What is attrs={'data-type': 'size'}) actually doing in this case? It seems sensible to just remove it, as that patch suggests. | 13:56 |
mrunge | if we want that sorting to be functional, should we give operators a logic to sort on? | 13:56 |
*** JeanBriceCombebi has quit IRC | 13:56 | |
robcresswell | But then, with pagination issues that sort has basically zero value. | 13:57 |
mrunge | or some function to to calculate comparable values | 13:57 |
robcresswell | Sorting a subset of your instances by the name of its flavour... | 13:57 |
mrunge | robcresswell, that applies to all sorts then | 13:57 |
mrunge | sigh, have to run, will catch you guys later | 13:58 |
robcresswell | mrunge: Well, its probably true for all sorts too :p | 13:58 |
robcresswell | I do too. Back in about 45 mins. | 13:58 |
itxaka | robcresswell attrs={'data-type': 'size'}) -> is used by sortable jquery to know what parser to use for sorting | 13:58 |
*** julim has joined #openstack-horizon | 13:59 | |
*** Ala has quit IRC | 13:59 | |
itxaka | IMO, sorting by flavor name has better value that no sorting at all | 14:00 |
itxaka | you can group your instances by flavor type easily which is valuable on the ops side to mentally group them somehow | 14:00 |
itxaka | And also, when clicking in the header of a column that has names in it, I expect it to be sorted by name, which was not happening now | 14:01 |
*** mohankumar_ has joined #openstack-horizon | 14:03 | |
*** jtriley has joined #openstack-horizon | 14:03 | |
*** cbader has joined #openstack-horizon | 14:03 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:04 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Try to be more verbose on sec group error https://review.openstack.org/246275 | 14:07 |
*** Ala has joined #openstack-horizon | 14:07 | |
*** jtriley has quit IRC | 14:09 | |
*** amotoki_ has joined #openstack-horizon | 14:09 | |
*** yamamoto has quit IRC | 14:09 | |
*** yamamoto has joined #openstack-horizon | 14:10 | |
tsufiev | any idea what's happening here: https://review.openstack.org/#/c/225613/ ? | 14:11 |
tsufiev | specifically, the line 'gate-horizon-releasenotesNOT_REGISTERED' | 14:11 |
tsufiev | reproduced 2 times in a row | 14:11 |
lhcheng_ | tsufiev: oops sorry missed to respond | 14:12 |
*** amotoki has quit IRC | 14:12 | |
lhcheng_ | I submitted a patch to add the new reno job | 14:12 |
*** amotoki_ is now known as amotoki | 14:12 | |
tsufiev | lhcheng_, np, at least now I know that it isn't intermittent ) | 14:12 |
lhcheng_ | let me check with infra what going on | 14:13 |
tsufiev | ok. It's weird, that only this commit was affected | 14:13 |
tsufiev | just at the same time I uploaded 2 other commits and they have just passed | 14:13 |
lhcheng_ | tsufiev: the reno job was just added this morning | 14:16 |
lhcheng_ | https://review.openstack.org/#/c/248224 | 14:16 |
*** yamamoto has quit IRC | 14:16 | |
lhcheng_ | checking with infra if I missed something in the config | 14:16 |
*** matt-borland has joined #openstack-horizon | 14:16 | |
tsufiev | lhcheng_, perhaps the config wasn't propagated yet to every worker :/? (just a shot in the dark) | 14:17 |
mrunge | itxaka, due to limitations on the nova side, that sorting is being done on client side, i.e. it sorts only the values currently shown | 14:20 |
mrunge | itxaka, the same is true for searching | 14:20 |
*** ccesario has joined #openstack-horizon | 14:20 | |
mrunge | what would be bigger then ? the flavor with 10 gigs of ram and 1 cpu or the one with 5 gigs of ram and 2 cpus? | 14:21 |
lhcheng_ | tsufiev: yeah, sounds like it.. infra is looking at it | 14:21 |
itxaka | mrunge, I dont think we should sort by size as that its impossible | 14:21 |
mrunge | or let's add a bit disk space, how does that come into game then? | 14:21 |
itxaka | hence the simple solution of sorting by whats displayed on the cell, which is the name | 14:22 |
mrunge | itxaka, but that's what people would find to be "natural" sort | 14:22 |
mrunge | others would expect to sort after price | 14:22 |
itxaka | mrunge, I dont know, Im no UX expert but it feels natural to sort by name as the cells content are just names. Sorting by something that is not even displayed at a first glance (You cant see whats on the flavor unless you click on it) seems backwards | 14:23 |
mrunge | itxaka, yes, I agree. in that case, sorting would be by alphabetical? | 14:24 |
itxaka | but ofc it can also be removed altogether if we cannot agree on what it should be the sort type, as the sorting in place now its not useful at all | 14:24 |
itxaka | mrunge, yes, it defaults to alphabetical if no parser is set | 14:25 |
mrunge | I had a bugzilla for this.... | 14:25 |
*** hurgleburgler has joined #openstack-horizon | 14:27 | |
mrunge | ah, yes: https://bugzilla.redhat.com/show_bug.cgi?id=1262107 | 14:27 |
openstack | bugzilla.redhat.com bug 1262107 in python-django-horizon "When sorting by instance size, it's not sorted the right way" [Low,New] - Assigned to mrunge | 14:27 |
*** Daisy has quit IRC | 14:27 | |
mrunge | expected sort: m1.tiny < m1.small < m1.medium | 14:28 |
mrunge | which is not sorting by name... | 14:28 |
mrunge | just illustrating, end users are expecting something different for sorting | 14:28 |
itxaka | Indeed | 14:29 |
itxaka | thats a very good point | 14:29 |
itxaka | but the problem is that you could call a flavor m1.big and it could be "smaller" than m1.tiny :/ | 14:30 |
mrunge | yepp, exactly | 14:30 |
itxaka | or it could be bigger on cpu but smaller on ram, no way of knowing which one is bigger :/ | 14:30 |
mrunge | yes, exactly | 14:30 |
mrunge | I had once the task to sort lectures. the expected sorting key was: lectures held by persons with more doctoral grades should be listed in the front | 14:31 |
itxaka | but is removing the sorting on flavor a regression? Even if its useless right now? | 14:31 |
mrunge | that is not, what I would call *natural* | 14:32 |
mrunge | I would argue: it's not doing anything useful right now, removing that shouldn't be a regression then | 14:32 |
*** ygl has joined #openstack-horizon | 14:33 | |
*** jasondotstar_afk is now known as jasondotstar | 14:33 | |
mrunge | have to run out again... | 14:34 |
*** jtriley has joined #openstack-horizon | 14:34 | |
itxaka | will, redo the patch to remove the sorting and explain the reasoning, thanks mrunge ! | 14:37 |
lhcheng_ | tsufiev: infra confirmed that the reno job problem is indeed Infra CI issue, they're looking at it. | 14:42 |
tsufiev | tsufiev, thank you for an update! will recheck this particular commit in a day or two | 14:43 |
*** ducttape_ has joined #openstack-horizon | 14:44 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Remove data-type and sort from flavor column https://review.openstack.org/248594 | 14:47 |
openstackgerrit | Matt Borland proposed openstack/horizon: Split instance details and source in Launch Instance wizard. https://review.openstack.org/235004 | 14:52 |
*** bluex has quit IRC | 14:53 | |
*** bluex has joined #openstack-horizon | 14:53 | |
*** aix has quit IRC | 14:54 | |
*** petertr7 is now known as petertr7_away | 14:57 | |
*** julim_ has joined #openstack-horizon | 15:00 | |
*** shunliz has quit IRC | 15:01 | |
*** aix has joined #openstack-horizon | 15:01 | |
*** openstackgerrit has quit IRC | 15:02 | |
*** openstackgerrit has joined #openstack-horizon | 15:02 | |
*** julim has quit IRC | 15:02 | |
*** petertr7_away is now known as petertr7 | 15:02 | |
*** btully has joined #openstack-horizon | 15:09 | |
*** JeanBriceCombebi has quit IRC | 15:10 | |
robcresswell | The way to get things done: put up low-hanging-fruits and watch the patches fly in. | 15:10 |
*** JeanBriceCombebi has joined #openstack-horizon | 15:11 | |
robcresswell | Lol 4 -1s on a 6 line patch. | 15:12 |
robcresswell | david-lyle: Hey boss, can you look at https://review.openstack.org/#/c/248673/ ? | 15:13 |
*** pumaranikar has joined #openstack-horizon | 15:17 | |
*** mpavlase has quit IRC | 15:21 | |
*** Daisy has joined #openstack-horizon | 15:22 | |
*** JeanBriceCombebi has quit IRC | 15:24 | |
*** JeanBriceCombebi has joined #openstack-horizon | 15:26 | |
*** mohankumar_ has quit IRC | 15:29 | |
*** willsama has joined #openstack-horizon | 15:31 | |
*** willsama has quit IRC | 15:31 | |
*** neelashah has joined #openstack-horizon | 15:37 | |
*** josecastroleon has quit IRC | 15:39 | |
*** nlahouti has joined #openstack-horizon | 15:41 | |
*** nlahouti1 has joined #openstack-horizon | 15:43 | |
*** bluex has quit IRC | 15:43 | |
*** JeanBriceCombebi has quit IRC | 15:43 | |
*** bluex has joined #openstack-horizon | 15:44 | |
*** bluex has quit IRC | 15:45 | |
*** bluex has joined #openstack-horizon | 15:45 | |
*** nlahouti has quit IRC | 15:46 | |
*** vijendar has joined #openstack-horizon | 15:49 | |
*** jprovazn has joined #openstack-horizon | 15:50 | |
*** Piet has joined #openstack-horizon | 15:52 | |
*** peristeri has joined #openstack-horizon | 15:53 | |
*** gerchardon has joined #openstack-horizon | 15:53 | |
*** gerchardon has left #openstack-horizon | 15:54 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 15:56 |
*** Drago has joined #openstack-horizon | 16:04 | |
*** dsneddon has joined #openstack-horizon | 16:04 | |
*** Drago1 has joined #openstack-horizon | 16:04 | |
*** Drago1 has quit IRC | 16:04 | |
*** Drago1 has joined #openstack-horizon | 16:05 | |
*** petertr7 is now known as petertr7_away | 16:06 | |
*** Drago has quit IRC | 16:08 | |
*** Liuqing has quit IRC | 16:08 | |
*** rcernin has quit IRC | 16:08 | |
*** Daisy_ has joined #openstack-horizon | 16:10 | |
*** ducttape_ has quit IRC | 16:10 | |
*** Daisy has quit IRC | 16:11 | |
*** Pablo|off| has joined #openstack-horizon | 16:14 | |
*** ducttape_ has joined #openstack-horizon | 16:15 | |
*** jtriley has quit IRC | 16:15 | |
*** Pablo|off| is now known as pcaruana | 16:15 | |
*** bluex has quit IRC | 16:19 | |
*** JeanBriceCombebi has joined #openstack-horizon | 16:20 | |
*** petertr7_away is now known as petertr7 | 16:21 | |
*** jtriley has joined #openstack-horizon | 16:23 | |
*** aix has quit IRC | 16:24 | |
*** ygl has quit IRC | 16:25 | |
*** nlahouti1 has quit IRC | 16:25 | |
*** bpokorny has joined #openstack-horizon | 16:26 | |
*** SimonChung1 has quit IRC | 16:27 | |
*** nlahouti has joined #openstack-horizon | 16:27 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Make default date range at Overview panel configurable https://review.openstack.org/238204 | 16:30 |
*** ryanpetrello has quit IRC | 16:30 | |
*** Ala has quit IRC | 16:34 | |
*** petertr7 is now known as petertr7_away | 16:44 | |
*** vishwanathj has joined #openstack-horizon | 16:45 | |
*** lhcheng_ has quit IRC | 16:46 | |
*** lhcheng has joined #openstack-horizon | 16:47 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Barcharts now inherit from a Bootstrap Theme https://review.openstack.org/245342 | 16:47 |
*** petertr7_away is now known as petertr7 | 16:49 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Make default date range at Overview panel configurable https://review.openstack.org/238204 | 16:50 |
*** JeanBriceCombebi has quit IRC | 16:52 | |
*** tqtran has joined #openstack-horizon | 16:52 | |
tsufiev | did anybody notice that now any POST action on Tabbed Tables redirects to the first tab on a success | 16:52 |
tsufiev | e.g., Access&Security->Floating IPs->Allocate IP | 16:52 |
tsufiev | I believe that current tab was stored in cookies before | 16:53 |
tsufiev | looking for a commit that introduced the change | 16:53 |
tqtran | mrunge, david-lyle: you guys around? | 16:53 |
*** Piet has quit IRC | 16:55 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix for the broken header's dropdowns for both v0.11.2 and v0.13 https://review.openstack.org/218815 | 16:56 |
*** JeanBriceCombebi has joined #openstack-horizon | 16:58 | |
*** JeanBriceCombebi has quit IRC | 17:00 | |
*** nlahouti has quit IRC | 17:00 | |
*** nlahouti has joined #openstack-horizon | 17:00 | |
tsufiev | robcresswell, doug-fish: guys, if you notice that test_floatingip integration test fails, that's for a reason ^^^ | 17:01 |
*** alexvictorchan has joined #openstack-horizon | 17:02 | |
krotscheck | tqtran: Answer for you on https://review.openstack.org/#/c/248279/ | 17:02 |
*** ryanpetrello has joined #openstack-horizon | 17:04 | |
tqtran | krotscheck: hm.... couldn't we just disable this linting rules for third-party libraries (we know where they are stored in the file system) | 17:04 |
tqtran | and if user extends js, it will come in as a form of plugin | 17:04 |
tqtran | let me back petal a bit, 'use strict' is check during the linting process? or when the browser runs it? | 17:05 |
*** vgridnev has quit IRC | 17:06 | |
krotscheck | tqtran: It's a browser thing. | 17:08 |
tqtran | so if we enable use strict globally, and there is a third-party library that isn't strict, what will the browser do? | 17:09 |
krotscheck | tqtran: It'll blow up. | 17:09 |
tqtran | it should be able to run both right? | 17:09 |
krotscheck | tqtran: I'm trying to find a good article that describes it. | 17:09 |
tqtran | "Strict mode code and non-strict mode code can coexist, so scripts can opt into strict mode incrementally." MSDN | 17:09 |
krotscheck | Basically, "use strict" is a line in the sand where you say "We're running in strict ECMA 5". | 17:09 |
krotscheck | tqtran: That's true. Strict mode can be enabled on a per file or a per function basis. | 17:10 |
krotscheck | Horizon concatenates all its javascript though, doesn't it? | 17:10 |
krotscheck | So to the browser, there'd be one file. | 17:10 |
krotscheck | And everything in there would be flagged as strict. | 17:11 |
tqtran | yea we compress them into one file | 17:11 |
tqtran | i wonder if you can have different mode in the same file | 17:12 |
tqtran | like blocks | 17:12 |
krotscheck | Well, you can do it via IIFE. | 17:12 |
krotscheck | But, well, I'm not certain what that'd do to horizon if all of its javascript files were wrapped in execution closures. | 17:12 |
krotscheck | The problem is that it's only on "on" switch. There's no off switch. | 17:13 |
krotscheck | The John Resig argument describes some patterns that would work: http://ejohn.org/blog/ecmascript-5-strict-mode-json-and-more/ | 17:13 |
*** ir2ivps10 has joined #openstack-horizon | 17:14 | |
tqtran | reading | 17:16 |
*** ygbo has quit IRC | 17:17 | |
*** rcernin has joined #openstack-horizon | 17:21 | |
*** SimonChung has joined #openstack-horizon | 17:21 | |
tqtran | krotscheck: all of the new angular code uses IIFE, its only the legacy stuff that doesn't (the files you modified). Can we just enclose them in IIFE instead of per function? | 17:24 |
krotscheck | tqtran: I don't know what that'd do to that code... BUT... I can turn the rule off for the legacy folder. | 17:25 |
*** SurajD has joined #openstack-horizon | 17:25 | |
tqtran | perfect, that will work for me | 17:25 |
krotscheck | Sweeet. | 17:25 |
*** jerrygb_ has quit IRC | 17:26 | |
krotscheck | Can I do that with all new linting rules? Is it understood that legacy won't keep up with the new development? | 17:26 |
*** SimonChung has quit IRC | 17:26 | |
tqtran | yeah i think so, we made that decision a while back when we disabled a few other things in legacy | 17:26 |
*** mpavlase has joined #openstack-horizon | 17:27 | |
krotscheck | Alright, I'll propose it. That'll make things easier to manage anyway | 17:27 |
tqtran | cool thanks! | 17:28 |
*** petertr7 is now known as petertr7_away | 17:29 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Try to be more verbose on sec group error https://review.openstack.org/246275 | 17:32 |
*** jerrygb has joined #openstack-horizon | 17:33 | |
*** itxaka has quit IRC | 17:35 | |
*** rebase has joined #openstack-horizon | 17:35 | |
*** jerrygb has quit IRC | 17:36 | |
tsufiev | oh, ignore my question about tabbed tables - it was a false alarm | 17:37 |
tsufiev | I must have read JS console log in integration tests' artifacts :) | 17:37 |
tsufiev | (would save myself one hour of time) | 17:37 |
*** nlahouti has quit IRC | 17:38 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix for the broken header's dropdowns for both v0.11.2 and v0.13 https://review.openstack.org/218815 | 17:39 |
*** e0ne has quit IRC | 17:39 | |
*** jerrygb has joined #openstack-horizon | 17:40 | |
*** petertr7_away is now known as petertr7 | 17:41 | |
openstackgerrit | David Lyle proposed openstack/horizon: Excising Sahara from Horizon https://review.openstack.org/248838 | 17:42 |
*** SimonChung has joined #openstack-horizon | 17:42 | |
*** nlahouti has joined #openstack-horizon | 17:43 | |
*** aix has joined #openstack-horizon | 17:45 | |
*** jerrygb has quit IRC | 17:45 | |
*** mohankumar_ has joined #openstack-horizon | 17:47 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: Launch Instance Wizard - Security Group Available table https://review.openstack.org/248848 | 17:49 |
*** vgridnev has joined #openstack-horizon | 17:51 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 17:52 |
matt-borland | TravT, I added tests to https://review.openstack.org/#/c/236832/ for visibility = shared and private. | 17:53 |
*** zul has quit IRC | 17:53 | |
*** kzaitsev_mb has quit IRC | 17:55 | |
*** kzaitsev_mb has joined #openstack-horizon | 17:55 | |
*** lapalm has quit IRC | 17:58 | |
*** zul has joined #openstack-horizon | 17:58 | |
*** lapalm has joined #openstack-horizon | 17:59 | |
*** nlahouti has quit IRC | 18:02 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: Launch Instance Wizard - Security Group Available table https://review.openstack.org/248848 | 18:02 |
*** lapalm has quit IRC | 18:03 | |
*** kzaitsev_mb has quit IRC | 18:04 | |
openstackgerrit | ayoung proposed openstack/horizon: Federated Identity Mapping https://review.openstack.org/232114 | 18:09 |
*** ygl has joined #openstack-horizon | 18:11 | |
openstackgerrit | ayoung proposed openstack/horizon: Federated Identity Mapping https://review.openstack.org/232114 | 18:11 |
mrunge | tqtran, yes, I am around here | 18:13 |
robcresswell | r1chardj0n3s: Ping - this was the reason for that odd settings change (SECRET_KEY assignment block moved) in the Theme Preview patch: http://logs.openstack.org/31/209631/27/check/gate-horizon-docs/53d954c/console.html | 18:14 |
*** errolpais has joined #openstack-horizon | 18:14 | |
*** aix has quit IRC | 18:18 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Make configurable the default date range used on Overview panel https://review.openstack.org/238204 | 18:20 |
robcresswell | What I dont understand yet is why only this dashboard is causing the error :/ | 18:22 |
*** e0ne has joined #openstack-horizon | 18:22 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add support for identity provider protocol CRUD https://review.openstack.org/248865 | 18:22 |
sjmc7 | robcresweell - because you’re importing settings | 18:24 |
sjmc7 | err, robcreswell ^ | 18:24 |
sjmc7 | damnit! monday morning | 18:24 |
robcresswell | lol | 18:24 |
robcresswell | Can't you just tab autocomplete? | 18:25 |
sjmc7 | apparently i can | 18:25 |
robcresswell | But also, yes, your point makes sense. Cheers. | 18:26 |
robcresswell | Saved me an investigation :p | 18:26 |
*** jerrygb has joined #openstack-horizon | 18:27 | |
sjmc7 | it is a bit of a gotcha importing settings from ‘enabled’ files | 18:27 |
robcresswell | half-baked plugin system ftw | 18:28 |
*** bpokorny_ has joined #openstack-horizon | 18:28 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add Developer Dashboard + Bootstrap Theme Preview https://review.openstack.org/209631 | 18:29 |
*** e0ne has quit IRC | 18:29 | |
tqtran | mrunge: https://review.openstack.org/#/c/246683/1 works well, but makes a few assumptions | 18:29 |
*** e0ne has joined #openstack-horizon | 18:29 | |
mrunge | Thai, I still have that in my review queue | 18:29 |
tqtran | if you remove line 16, it will pick it up from all installed apps, which is fine | 18:29 |
tqtran | but the app compressor has a subdir call test/static | 18:30 |
tqtran | the current implementation also pull static from that app, not sure if that is ok or not | 18:30 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add Developer Dashboard + Bootstrap Theme Preview https://review.openstack.org/209631 | 18:31 |
tqtran | there's not real way to know if a subdir is a panel or not. right now, it just looks into the first-level subdir | 18:31 |
mrunge | tqtran, I don't think we want to pull static files from app compressor | 18:31 |
mrunge | but you're right | 18:31 |
tqtran | the other thing we can do is to have a setting in enabled file | 18:31 |
tqtran | telling the compressor whether to pick up files from the panel or not | 18:31 |
tqtran | it is more intelligent but requires user to manually specify it | 18:32 |
*** bpokorny has quit IRC | 18:32 | |
mrunge | hmmm | 18:32 |
mrunge | since I have seen so many configs made by users, I'm not sure here | 18:33 |
*** bpokorny_ has quit IRC | 18:33 | |
tqtran | right, thats what i wanted to talk to you and david about | 18:33 |
tqtran | not sure if there is a good way to detect panel subdir | 18:34 |
tqtran | the dumb way is to do it for all 1st level subdir for all installed_apps. it works well but will include additional statics that are not use in production | 18:35 |
robcresswell | Couldn't you just crudely check for a panel.py? Sorry, just skimming | 18:37 |
mrunge | probably not | 18:37 |
mrunge | as you can have a disabled panel | 18:37 |
mrunge | where you don't want to pull static files from | 18:37 |
* robcresswell thinks more | 18:38 | |
tqtran | a disabled panel is easy, we have a disabled flag in settings for that | 18:38 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable semi-spacing https://review.openstack.org/244920 | 18:38 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable strict https://review.openstack.org/248279 | 18:38 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable eqeqeq https://review.openstack.org/244925 | 18:38 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable callback-return https://review.openstack.org/248302 | 18:38 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable consistent-return https://review.openstack.org/248303 | 18:38 |
tqtran | so can easily check that | 18:38 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable no-redeclare https://review.openstack.org/244930 | 18:38 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Disable all new linting rules in legacy code https://review.openstack.org/248870 | 18:38 |
krotscheck | tqtran: Disabling those rules for legacy removed 700 violations. | 18:38 |
krotscheck | That's a lot easier to deal with :) | 18:38 |
tqtran | lol oh wow | 18:38 |
*** kyleolivo has joined #openstack-horizon | 18:39 | |
tqtran | mrunge, robcresswell: i suppose checking for panel.py could work for now | 18:39 |
robcresswell | Wait, there's better ways to do this I'm sure | 18:39 |
tqtran | but leaves me concern about js plugin that may not require it, like workflow or action extension | 18:39 |
robcresswell | Horizon gathers a registry in its base.py anyway | 18:40 |
openstackgerrit | Merged openstack/horizon: Fixed Update Metadata modal description's typos https://review.openstack.org/247670 | 18:40 |
tqtran | registry of panels? or of dashboards? | 18:40 |
robcresswell | both | 18:41 |
*** petertr7 is now known as petertr7_away | 18:41 | |
*** wuhg has quit IRC | 18:41 | |
robcresswell | I don't know if that helps with gathering static files though. I should probably read more into what we're trying to achieve before I start trying to help >.< | 18:42 |
*** jerrygb has quit IRC | 18:42 | |
mrunge | hahaha | 18:43 |
*** jingjing_ren has joined #openstack-horizon | 18:44 | |
mrunge | tqtran, I was thinking of implementing a special finder just to walk through dasboard dirs | 18:44 |
mrunge | I mean openstack-dashboard/dashboards + subdirs in one level | 18:45 |
mrunge | to add the static directory, if there is one | 18:45 |
tqtran | right, so what i have right now does that | 18:45 |
tqtran | the issue is that it wont work for plugins | 18:45 |
tqtran | plugins are installed as applications | 18:46 |
mrunge | but for plugins, we have the traditional static finder | 18:46 |
*** jerrygb has joined #openstack-horizon | 18:46 | |
openstackgerrit | Merged openstack/horizon: Translate Floating IPs on overview page https://review.openstack.org/248633 | 18:46 |
tqtran | mrunge: yes, but the traditional static finder only works at the dashboard level | 18:46 |
robcresswell | Hang on, we don't want to maintain two finders because one just "doesnt work for plugins" | 18:46 |
tqtran | it still doesnt go into the panel level | 18:46 |
robcresswell | That would be silly :) | 18:46 |
mrunge | plugins are python packages, no? | 18:47 |
robcresswell | indeed | 18:47 |
tqtran | robcresswell: we are using 2 atm, one for apps and one for filesystem (aka the stuff in static_dirs) | 18:47 |
mrunge | there is a static finder for python packages | 18:47 |
mrunge | let me look up the name | 18:47 |
mrunge | huh, I thought there was a third finder | 18:49 |
mrunge | tqtran, the traditiona appdirectories finder should do that for us | 18:50 |
mrunge | +l | 18:50 |
robcresswell | tqtran: Interesting | 18:51 |
tqtran | mrunge: it wont :P | 18:51 |
mrunge | how did that work before then? | 18:51 |
*** jerrygb has quit IRC | 18:51 | |
tqtran | the traditional appdir finder operates only at the dashboard level | 18:51 |
tqtran | let me look into it, i know what you're talking about | 18:51 |
*** rdopiera has quit IRC | 18:52 | |
tqtran | robcresswell: basically, the filesystem one is the one we use for importing 3rd party xstatic libs, and the appsdir one is what we use for dashboards and panels in plugins | 18:53 |
tqtran | what i have done is extend the appsdir to also look into dashboard's subdir for panels as well | 18:53 |
robcresswell | Isee | 18:53 |
*** SurajD has quit IRC | 18:53 | |
mrunge | I must admit, I'll have to play with that again | 18:53 |
tqtran | right now, you can only have a static folder under each application (aka dashboard). you can't have static under panel (which is a subdir of dashboard) | 18:54 |
mrunge | I know, I looked into finders about 2 years ago | 18:54 |
tqtran | right, that was to explain to rob the situation in case he knows of a different method | 18:54 |
hurgleburgler | we also use the filesystem finder to load static from themes | 18:54 |
tqtran | but i will look into how we are doing it for panel level plugins | 18:54 |
robcresswell | Yeah, it just looks for static within the installed_apps, which is only the dashboards, I see. | 18:54 |
mrunge | it would be just beautiful to be able to move static files to panels | 18:55 |
mrunge | this is, what Thai is currently trying to achieve | 18:55 |
robcresswell | mrunge: Agreeeed, makes so much more sense for code layout | 18:55 |
mrunge | unfortunately, that is not as simple as assumed at the summit | 18:56 |
*** bpokorny has joined #openstack-horizon | 18:56 | |
*** SurajD has joined #openstack-horizon | 18:57 | |
robcresswell | How does this tie in with the auto file discovery thing that came about last cycle? | 18:58 |
tqtran | it doesnt | 18:59 |
tqtran | ok, let me backpedal a bit | 18:59 |
tqtran | the static finder picks up all of the static files | 19:00 |
mrunge | I have to step out again, but will be back in 1hr | 19:00 |
robcresswell | mrunge: o/ | 19:00 |
tqtran | the auto-discovery stuff puts those static files into the page so they can be use | 19:00 |
tqtran | saves you from having to manually list them out in the enabled file | 19:00 |
openstackgerrit | Kyle Olivo proposed openstack/horizon: Adding Create Image Action to angular images panel https://review.openstack.org/236042 | 19:02 |
robcresswell | tqtran: Right | 19:02 |
*** jerrygb has joined #openstack-horizon | 19:03 | |
robcresswell | :/ | 19:03 |
*** mohankumar_ has quit IRC | 19:04 | |
robcresswell | tqtran: When are the finders executed during setup? After the enabled files have been searched? | 19:05 |
tqtran | when you run collectstatic | 19:05 |
hurgleburgler | The auto discovery stuff is why the importing of the scss is currently hosed as well | 19:06 |
hurgleburgler | you don't have to run collectstatic for the static finders to find your files | 19:06 |
robcresswell | If you just run the dev server, it'll populate your static_dir | 19:07 |
robcresswell | but, I can't recall when in the process that occurs. | 19:07 |
*** mpavlase has quit IRC | 19:10 | |
*** flwang has quit IRC | 19:13 | |
*** jbell8 has joined #openstack-horizon | 19:15 | |
*** lapalm has joined #openstack-horizon | 19:16 | |
*** SurajD has quit IRC | 19:16 | |
*** lapalm_ has joined #openstack-horizon | 19:17 | |
*** josecastroleon has joined #openstack-horizon | 19:19 | |
*** lapalm has quit IRC | 19:20 | |
*** lapalm has joined #openstack-horizon | 19:21 | |
*** lapalm_ has quit IRC | 19:22 | |
matt-borland | TravT, tqtran you both approved https://review.openstack.org/#/c/235004/ but it failed in the gate due to new eslint rules...I think it's ready for re-review. | 19:25 |
matt-borland | ^^ This is the Launch Instance source/detail split | 19:25 |
matt-borland | I feel like we should limit elsint rules to certain phases of the moon | 19:26 |
matt-borland | (changes to) | 19:26 |
TravT | matt-borland: yep, saw that earlier. will look at it again in a bit. | 19:26 |
matt-borland | thanks!!! | 19:26 |
*** flwang has joined #openstack-horizon | 19:27 | |
TravT | your eslint comment makes some sense. | 19:28 |
tqtran | great, compared it to the previous patchset, seems fine to me | 19:28 |
*** ygl has quit IRC | 19:28 | |
*** lapalm has quit IRC | 19:30 | |
*** lapalm has joined #openstack-horizon | 19:31 | |
*** lapalm_ has joined #openstack-horizon | 19:32 | |
*** lapalm has quit IRC | 19:35 | |
*** jwy has joined #openstack-horizon | 19:36 | |
*** lapalm_ has quit IRC | 19:38 | |
*** ducttape_ has quit IRC | 19:39 | |
*** bpokorny has quit IRC | 19:41 | |
*** Daisy_ has quit IRC | 19:41 | |
*** bpokorny has joined #openstack-horizon | 19:42 | |
*** Daisy has joined #openstack-horizon | 19:42 | |
*** lapalm has joined #openstack-horizon | 19:44 | |
*** petertr7_away is now known as petertr7 | 19:45 | |
*** vkmc is now known as vkmc-afk | 19:47 | |
*** josecastroleon has quit IRC | 19:49 | |
neillc_ | morning | 19:54 |
*** e0ne has quit IRC | 19:55 | |
matt-borland | morning neillc_ :) | 19:56 |
*** neillc_ is now known as neillc | 19:56 | |
robcresswell | morning neillc | 19:57 |
neillc | today is fun with devstack day | 19:57 |
robcresswell | Oh? | 19:57 |
neillc | testing my new angularised swift panel - network latency is killing me so setting up a local devstack | 19:58 |
neillc | hilarity ensues... | 19:58 |
neillc | if only Australia had real internets I wouldn't be doing this | 19:59 |
robcresswell | Heh. I have real internets in the UK, but my server is sat behind Cisco's firewall in San Jose. Sooo... latency. | 20:00 |
*** Daisy has quit IRC | 20:01 | |
*** kyleolivo has quit IRC | 20:01 | |
*** ZZelle_ has joined #openstack-horizon | 20:04 | |
mrunge | isn't that more a real test for end users using angularized panels? | 20:08 |
*** neelashah has quit IRC | 20:08 | |
*** neelashah has joined #openstack-horizon | 20:09 | |
neillc | mrunge: yes, but I'm still in heavy development | 20:09 |
robcresswell | mrunge: Yes, but not useful in dev | 20:09 |
neillc | testing to come soon... | 20:09 |
mrunge | i.e. a push for us to reduce number of ping-pongs between end user and proxy? | 20:09 |
mrunge | but I agree neillc, robcresswell | 20:09 |
robcresswell | tqtran: I had a play around, but couldn't find a nicer solution to the finder just yet. Will keep looking later in the week and ping any suggestions I find :) | 20:10 |
neillc | yeah, but at the moment I end up doing a lot of full page refreshes as I change js / templates etc | 20:10 |
*** clu_ has joined #openstack-horizon | 20:10 | |
tqtran | robcresswell: great! i'll continue to investigate | 20:11 |
*** neelashah1 has joined #openstack-horizon | 20:12 | |
*** neelashah has quit IRC | 20:13 | |
*** neelashah has joined #openstack-horizon | 20:16 | |
*** neelashah1 has quit IRC | 20:16 | |
*** pat has quit IRC | 20:18 | |
*** pat has joined #openstack-horizon | 20:24 | |
*** kyleolivo has joined #openstack-horizon | 20:25 | |
*** kyleolivo has quit IRC | 20:26 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: Launch Instance Wizard - Security Group Available table https://review.openstack.org/248848 | 20:34 |
r1chardj0n3s | morning | 20:34 |
r1chardj0n3s | Bug Day! \o/ | 20:35 |
neillc | morning r1chardj0n3s | 20:35 |
*** e0ne has joined #openstack-horizon | 20:42 | |
*** petertr7 is now known as petertr7_away | 20:43 | |
*** petertr7_away is now known as petertr7 | 20:46 | |
r1chardj0n3s | robcresswell: re that SECRET_KEY move ... well, there you go | 20:47 |
doug-fish | r1chardj0n3s: not to distract you from bug day, but I was just looking at https://review.openstack.org/#/c/246549/ | 20:51 |
r1chardj0n3s | doug-fish: hiya | 20:51 |
doug-fish | I think you are saying some of the tests are too broad - but I wasn't quite able to sort out which one | 20:51 |
r1chardj0n3s | doug-fish: eg https://review.openstack.org/#/c/246549/4/openstack_dashboard/dashboards/project/volumes/volumes/tests.py,cm | 20:52 |
doug-fish | ah ok - thx! | 20:52 |
*** yamamoto has joined #openstack-horizon | 20:58 | |
*** jprovazn has quit IRC | 20:59 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Quota pages now inherit from Bootstrap Theme https://review.openstack.org/245398 | 21:05 |
*** kyleolivo has joined #openstack-horizon | 21:05 | |
*** kyleolivo has quit IRC | 21:06 | |
*** jbell8 has quit IRC | 21:08 | |
*** e0ne has quit IRC | 21:08 | |
*** krotscheck has quit IRC | 21:10 | |
*** anteaya has quit IRC | 21:11 | |
*** jasondotstar has quit IRC | 21:12 | |
*** kyleolivo has joined #openstack-horizon | 21:16 | |
*** krotscheck has joined #openstack-horizon | 21:17 | |
*** kyleolivo has quit IRC | 21:17 | |
*** e0ne has joined #openstack-horizon | 21:17 | |
*** jasondotstar has joined #openstack-horizon | 21:18 | |
*** kzaitsev_mb has joined #openstack-horizon | 21:19 | |
*** pauloewerton has quit IRC | 21:21 | |
*** kyleolivo has joined #openstack-horizon | 21:22 | |
*** jerrygb has quit IRC | 21:22 | |
*** jerrygb has joined #openstack-horizon | 21:26 | |
*** ducttape_ has joined #openstack-horizon | 21:26 | |
*** anteaya has joined #openstack-horizon | 21:27 | |
*** vgridnev has quit IRC | 21:27 | |
*** bradjones has quit IRC | 21:27 | |
*** vkmc-afk is now known as vkmc | 21:27 | |
*** vgridnev has joined #openstack-horizon | 21:28 | |
*** bradjones has joined #openstack-horizon | 21:29 | |
*** bradjones has quit IRC | 21:29 | |
*** bradjones has joined #openstack-horizon | 21:29 | |
*** haypo has left #openstack-horizon | 21:30 | |
*** jerrygb has quit IRC | 21:31 | |
*** david-lyle has quit IRC | 21:31 | |
*** vgridnev has quit IRC | 21:32 | |
*** errolpais has quit IRC | 21:32 | |
*** david-lyle has joined #openstack-horizon | 21:34 | |
*** ChanServ sets mode: +o david-lyle | 21:34 | |
*** lapalm has quit IRC | 21:40 | |
*** e0ne has quit IRC | 21:43 | |
*** Piet has joined #openstack-horizon | 21:45 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP Adding Magic Search codebase to Horizon https://review.openstack.org/245288 | 21:47 |
*** crobertsrh is now known as _crobertsrh | 21:52 | |
*** jhesketh has quit IRC | 21:55 | |
*** david-lyle has quit IRC | 21:55 | |
Piet | I wanted to let you know that I’ve accepted a position with Intel's Open Source Technology Center. My last day with HPE will be December 11th and my first day with Intel will begin on December 14th. | 21:55 |
*** jhesketh has joined #openstack-horizon | 21:55 | |
jamielennox | Piet: congratulations, that should be a great group | 21:57 |
Piet | Thanks! My personal email is pkruithofjr at gmail.com if you need to reach me in the interim. | 21:58 |
*** harlowja_ has joined #openstack-horizon | 21:59 | |
*** harlowja has quit IRC | 21:59 | |
*** david-lyle has joined #openstack-horizon | 22:03 | |
*** ChanServ sets mode: +o david-lyle | 22:03 | |
*** neelashah1 has joined #openstack-horizon | 22:03 | |
*** david-lyle has quit IRC | 22:04 | |
*** neelashah has quit IRC | 22:06 | |
*** neelashah has joined #openstack-horizon | 22:06 | |
*** petertr7 is now known as petertr7_away | 22:06 | |
*** SimonChung1 has joined #openstack-horizon | 22:07 | |
*** SimonChung has quit IRC | 22:07 | |
openstackgerrit | ayoung proposed openstack/horizon: Federated Identity Mapping https://review.openstack.org/232114 | 22:08 |
*** SimonChung1 has quit IRC | 22:08 | |
*** SimonChung has joined #openstack-horizon | 22:08 | |
*** neelashah1 has quit IRC | 22:08 | |
*** neelashah1 has joined #openstack-horizon | 22:09 | |
*** julim_ has quit IRC | 22:09 | |
*** vijendar has quit IRC | 22:10 | |
*** neelashah has quit IRC | 22:11 | |
*** jerrygb has joined #openstack-horizon | 22:11 | |
openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 22:13 |
openstackgerrit | Merged openstack/django_openstack_auth: Add domain scoped token to session in multidomain https://review.openstack.org/141153 | 22:13 |
*** jtriley has quit IRC | 22:14 | |
*** matt-borland has quit IRC | 22:15 | |
*** yamamoto has quit IRC | 22:18 | |
openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 22:18 |
sjmc7 | ^ almost that patch’s one year anniversary! | 22:18 |
openstackgerrit | Cindy Lu proposed openstack/horizon: Launch Instance Wizard - Security Group Available table https://review.openstack.org/248848 | 22:20 |
*** rcernin has quit IRC | 22:20 | |
*** david-lyle has joined #openstack-horizon | 22:21 | |
*** ChanServ sets mode: +o david-lyle | 22:21 | |
*** david-lyle has quit IRC | 22:25 | |
*** tqtran has quit IRC | 22:37 | |
*** SimonChung has quit IRC | 22:39 | |
*** SimonChung1 has joined #openstack-horizon | 22:39 | |
*** SimonChung1 has quit IRC | 22:40 | |
*** SimonChung has joined #openstack-horizon | 22:40 | |
*** SimonChung1 has joined #openstack-horizon | 22:40 | |
*** SimonChung has quit IRC | 22:40 | |
*** jwy has quit IRC | 22:42 | |
*** sambetts is now known as sambetts-afk | 22:45 | |
*** josecastroleon has joined #openstack-horizon | 22:49 | |
*** josecastroleon has quit IRC | 22:54 | |
*** amotoki has quit IRC | 22:58 | |
*** kyleolivo has quit IRC | 22:58 | |
*** david-lyle has joined #openstack-horizon | 23:03 | |
*** ChanServ sets mode: +o david-lyle | 23:03 | |
*** david-lyle has quit IRC | 23:05 | |
*** ducttape_ has quit IRC | 23:09 | |
*** kyleolivo has joined #openstack-horizon | 23:10 | |
*** peristeri has quit IRC | 23:14 | |
*** doug-fish has quit IRC | 23:17 | |
*** david-lyle has joined #openstack-horizon | 23:23 | |
*** ChanServ sets mode: +o david-lyle | 23:23 | |
*** david-lyle has quit IRC | 23:25 | |
*** Daisy has joined #openstack-horizon | 23:26 | |
*** Daisy has quit IRC | 23:30 | |
*** jhesketh has quit IRC | 23:31 | |
*** josh6627 has joined #openstack-horizon | 23:31 | |
*** Daisy has joined #openstack-horizon | 23:31 | |
*** david-lyle has joined #openstack-horizon | 23:35 | |
*** ChanServ sets mode: +o david-lyle | 23:35 | |
*** josh6627 has quit IRC | 23:35 | |
*** Daisy has quit IRC | 23:36 | |
*** Daisy has joined #openstack-horizon | 23:36 | |
*** Daisy has quit IRC | 23:37 | |
*** Daisy has joined #openstack-horizon | 23:38 | |
*** ZZelle_ has quit IRC | 23:38 | |
*** david-lyle has quit IRC | 23:41 | |
*** david-ly_ has joined #openstack-horizon | 23:41 | |
*** Daisy has quit IRC | 23:42 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add support for identity provider management https://review.openstack.org/244991 | 23:50 |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add basic CRUD for federation mapping https://review.openstack.org/248551 | 23:50 |
*** neillc is now known as neillc_away | 23:51 | |
*** jtriley has joined #openstack-horizon | 23:53 | |
*** pumaranikar has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!