*** davidmichaelkarr has joined #openstack-horizon | 00:04 | |
*** lhcheng has quit IRC | 00:06 | |
*** lhcheng has joined #openstack-horizon | 00:07 | |
*** lhcheng has quit IRC | 00:11 | |
*** lhcheng has joined #openstack-horizon | 00:11 | |
*** lhcheng has quit IRC | 00:33 | |
*** lhcheng has joined #openstack-horizon | 00:35 | |
*** saksham has quit IRC | 00:42 | |
*** Piet has joined #openstack-horizon | 00:47 | |
*** akanksha_ has quit IRC | 00:58 | |
*** yamamoto has joined #openstack-horizon | 01:03 | |
*** lhcheng_ has joined #openstack-horizon | 01:08 | |
*** lhcheng has quit IRC | 01:08 | |
*** zhenguo has joined #openstack-horizon | 01:15 | |
*** nlahouti has joined #openstack-horizon | 01:15 | |
*** August1914 has joined #openstack-horizon | 01:20 | |
*** makkie- has quit IRC | 01:22 | |
*** lhcheng_ has quit IRC | 01:24 | |
*** lhcheng has joined #openstack-horizon | 01:26 | |
*** alexvictorchan has joined #openstack-horizon | 01:36 | |
*** btully has quit IRC | 01:37 | |
*** amotoki has joined #openstack-horizon | 01:37 | |
*** patk has quit IRC | 01:47 | |
*** linkedinyou has joined #openstack-horizon | 01:48 | |
*** zhurong has joined #openstack-horizon | 01:50 | |
*** ducttape_ has joined #openstack-horizon | 01:55 | |
*** lhcheng has quit IRC | 01:55 | |
*** mitz has left #openstack-horizon | 01:56 | |
*** lhcheng_ has joined #openstack-horizon | 01:56 | |
*** patk has joined #openstack-horizon | 01:59 | |
*** nlahouti has quit IRC | 02:00 | |
*** zhurong has quit IRC | 02:00 | |
*** nlahouti has joined #openstack-horizon | 02:00 | |
*** zhurong has joined #openstack-horizon | 02:01 | |
*** ducttape_ has quit IRC | 02:07 | |
*** ducttape_ has joined #openstack-horizon | 02:17 | |
*** lhcheng_ has quit IRC | 02:17 | |
*** lhcheng has joined #openstack-horizon | 02:17 | |
*** ducttape_ has quit IRC | 02:21 | |
*** ducttape_ has joined #openstack-horizon | 02:24 | |
*** lhcheng has quit IRC | 02:24 | |
*** lhcheng has joined #openstack-horizon | 02:25 | |
*** Liuqing has joined #openstack-horizon | 02:27 | |
*** tjones has joined #openstack-horizon | 02:44 | |
*** ducttape_ has quit IRC | 02:51 | |
*** btully has joined #openstack-horizon | 02:55 | |
*** ducttape_ has joined #openstack-horizon | 02:57 | |
*** btully has quit IRC | 03:00 | |
*** julim_ has quit IRC | 03:00 | |
*** zhurong has quit IRC | 03:00 | |
*** zhurong has joined #openstack-horizon | 03:01 | |
*** ducttape_ has quit IRC | 03:01 | |
*** cloudtrainme has joined #openstack-horizon | 03:03 | |
*** fedexo has joined #openstack-horizon | 03:04 | |
*** akanksha_ has joined #openstack-horizon | 03:04 | |
*** amotoki has quit IRC | 03:09 | |
*** hurgleburgler has quit IRC | 03:13 | |
*** ducttape_ has joined #openstack-horizon | 03:17 | |
*** linkedinyou has quit IRC | 03:18 | |
*** saksham has joined #openstack-horizon | 03:21 | |
*** itisha has quit IRC | 03:21 | |
*** zhurong has quit IRC | 03:21 | |
*** cloudtrainme has quit IRC | 03:22 | |
*** zhurong has joined #openstack-horizon | 03:22 | |
*** tjones has quit IRC | 03:22 | |
*** lhcheng has quit IRC | 03:26 | |
*** lhcheng_ has joined #openstack-horizon | 03:26 | |
*** ducttape_ has quit IRC | 03:27 | |
*** ducttape_ has joined #openstack-horizon | 03:28 | |
*** saksham has quit IRC | 03:28 | |
*** lhcheng_ has quit IRC | 03:28 | |
openstackgerrit | Merged openstack/horizon: Separate Ports tests from Networks tests https://review.openstack.org/242867 | 03:34 |
---|---|---|
*** ducttape_ has quit IRC | 03:55 | |
*** ducttape_ has joined #openstack-horizon | 04:05 | |
*** ducttape_ has quit IRC | 04:05 | |
*** ducttape_ has joined #openstack-horizon | 04:12 | |
*** KingKhan has joined #openstack-horizon | 04:18 | |
*** ducttape_ has quit IRC | 04:19 | |
*** lhcheng has joined #openstack-horizon | 04:21 | |
*** nlahouti has quit IRC | 04:34 | |
*** nlahouti has joined #openstack-horizon | 04:37 | |
*** lhcheng_ has joined #openstack-horizon | 04:47 | |
*** masco__ has joined #openstack-horizon | 04:49 | |
*** lhcheng has quit IRC | 04:50 | |
*** jamielennox is now known as jamielennox|away | 04:57 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Enable PhantomJS for running Selenium tests https://review.openstack.org/242926 | 04:57 |
openstackgerrit | Richard Jones proposed openstack/horizon: Enable PhantomJS for running Selenium tests https://review.openstack.org/242926 | 04:58 |
*** amotoki has joined #openstack-horizon | 05:08 | |
*** Piet has quit IRC | 05:15 | |
*** jamielennox|away is now known as jamielennox | 05:24 | |
*** hurgleburgler has joined #openstack-horizon | 05:45 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 06:12 | |
*** sayan has joined #openstack-horizon | 06:13 | |
*** lhcheng has joined #openstack-horizon | 06:19 | |
*** lhcheng_ has quit IRC | 06:19 | |
*** nlahouti has quit IRC | 06:22 | |
*** fedexo has quit IRC | 06:22 | |
*** akanksha_ has quit IRC | 06:28 | |
*** btully has joined #openstack-horizon | 06:31 | |
*** btully has quit IRC | 06:36 | |
*** sayan has quit IRC | 06:43 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Drop Django 1.7 support https://review.openstack.org/223106 | 06:47 |
*** amotoki_ has joined #openstack-horizon | 06:53 | |
*** amotoki has quit IRC | 06:54 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Navigation + cleanup for details pages https://review.openstack.org/212152 | 07:01 |
*** alexvictorchan has quit IRC | 07:01 | |
*** lsmola has joined #openstack-horizon | 07:09 | |
*** kzaitsev_mb has joined #openstack-horizon | 07:09 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add firewall detail actions and breadcrumb nav https://review.openstack.org/234315 | 07:11 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add breadcrumb to more details pages https://review.openstack.org/234173 | 07:11 |
robcresswell | Gooood morning | 07:13 |
*** katyafervent_awa is now known as katyafervent | 07:28 | |
*** wolverineav has quit IRC | 07:30 | |
*** romainh has joined #openstack-horizon | 07:36 | |
*** rdopiera has joined #openstack-horizon | 07:40 | |
*** mpavlase has joined #openstack-horizon | 07:41 | |
*** lsmola has quit IRC | 07:50 | |
*** Ala has joined #openstack-horizon | 07:56 | |
*** kzaitsev_mb has quit IRC | 07:56 | |
*** amotoki_ has quit IRC | 07:59 | |
*** hurgleburgler has quit IRC | 08:02 | |
*** AJaeger has joined #openstack-horizon | 08:02 | |
AJaeger | hi horizon cores, could you import the django_openstack_auth translations for liberty, please? See https://review.openstack.org/#/c/238353/ The change removes some obsolete URLs and should be in... | 08:03 |
mrunge | AJaeger, clicking | 08:04 |
AJaeger | thanks, mrunge - and good morning! | 08:04 |
*** lsmola has joined #openstack-horizon | 08:04 | |
mrunge | good morning to you AJaeger , and thanks for the heads up! | 08:05 |
*** JeanBriceCombebi has joined #openstack-horizon | 08:05 | |
mrunge | it's a backport, this is handled by the stable team, which is significantly smaller | 08:05 |
mrunge | AJaeger, aren't you a stable maint yourself? | 08:05 |
AJaeger | mrunge: no, I'm not - busy enough with my limited powers ;) | 08:06 |
mrunge | I can imagine... | 08:06 |
mrunge | lhcheng, are you able to look at https://review.openstack.org/#/c/238353/1 ? | 08:06 |
mrunge | (i18n backport for liberty) | 08:07 |
*** sayan has joined #openstack-horizon | 08:11 | |
lhcheng | mrunge: sure | 08:11 |
mrunge | awesome, thank you Lin | 08:11 |
*** amotoki has joined #openstack-horizon | 08:11 | |
AJaeger | thanks, lhcheng and mrunge! | 08:11 |
*** amotoki has quit IRC | 08:12 | |
robcresswell | Nice work :D | 08:12 |
*** amotoki has joined #openstack-horizon | 08:12 | |
mrunge | Good morning robcresswell , you're quite early around here :D | 08:13 |
mrunge | jetlagged? | 08:13 |
robcresswell | mrunge: Been up for hours, jetlag indeed | 08:13 |
mrunge | oh boy... | 08:13 |
lhcheng | AJaeger: anytime, thanks for the help on this | 08:15 |
*** JeanBriceCombebi has quit IRC | 08:15 | |
*** zigo has quit IRC | 08:16 | |
robcresswell | mrunge: Trying to debug tox issues on a non-voting dj19 test I'm adding | 08:17 |
*** sayan has quit IRC | 08:17 | |
robcresswell | >.< | 08:17 |
mrunge | ouch | 08:17 |
mrunge | I don't remember, did you already propose a patch for deprecation messages? | 08:18 |
*** zigo has joined #openstack-horizon | 08:19 | |
robcresswell | mrunge: https://review.openstack.org/#/c/223106/ | 08:20 |
mrunge | robcresswell, I would expect this should be merged first, right? | 08:21 |
mrunge | ah, just saw your comment on that patch, robcresswell | 08:21 |
robcresswell | mrunge: Yup. This patch is fairly trivial; just removing simple code and the dj17 tests | 08:21 |
robcresswell | mrunge: Follow on patches will add dj19 and a non-voting job. Then once it is released properly, we can enable dj19, and have lots of cycle left to fix breakages. | 08:22 |
mrunge | yeah, good idea | 08:23 |
mrunge | robcresswell, I would like to see django-1.8 enabled on the gate as long as it's supported upstream | 08:23 |
mrunge | but that shouldn't be an issue right now :D | 08:24 |
robcresswell | mrunge: Yeah, there are no plans to remove that job | 08:24 |
robcresswell | just an additional 1.9 job I expect. One for LTS and one for current seems sensible. | 08:24 |
mrunge | robcresswell, what's the story with permanent = True in https://review.openstack.org/#/c/223106/7/openstack_dashboard/contrib/sahara/content/data_processing/wizard/views.py,cm ? | 08:24 |
robcresswell | mrunge: Redirect views don't have a default iirc | 08:25 |
robcresswell | Let me find the doc | 08:25 |
mrunge | ah yes, I remember | 08:25 |
mrunge | thanks! | 08:25 |
robcresswell | Deprecated since version 1.8: | 08:26 |
robcresswell | The default value of the permanent attribute will change from True to False in Django 1.9. | 08:26 |
robcresswell | So explicit listing is required :) | 08:26 |
mrunge | yes, makes sense to have it, even now | 08:26 |
robcresswell | mrunge: Woop, thanks for +2 | 08:28 |
mrunge | you're welcome | 08:28 |
mrunge | pretty straightforward patch. thanks for doing this! | 08:29 |
*** wolverineav has joined #openstack-horizon | 08:30 | |
robcresswell | mrunge: Yeah, thats the easy one. No problem! | 08:31 |
*** zhurong_ has joined #openstack-horizon | 08:32 | |
*** Liuqing_ has joined #openstack-horizon | 08:32 | |
robcresswell | mrunge: If you're in a reviewing zone, take a look at https://review.openstack.org/#/c/212152/ :D | 08:32 |
*** sayan has joined #openstack-horizon | 08:33 | |
openstackgerrit | Thomas Goirand proposed openstack/horizon: adding general packaging information https://review.openstack.org/228423 | 08:33 |
mrunge | robcresswell, oho, same goes for you: https://review.openstack.org/#/c/242454/ | 08:33 |
mrunge | :D | 08:33 |
robcresswell | looking | 08:33 |
*** KingKhan has quit IRC | 08:34 | |
*** Liuqing has quit IRC | 08:35 | |
*** zhurong has quit IRC | 08:35 | |
*** wolverineav has quit IRC | 08:37 | |
*** ZZelle has quit IRC | 08:38 | |
*** ZZelle has joined #openstack-horizon | 08:39 | |
*** jamielennox is now known as jamielennox|away | 08:42 | |
*** KingKhan has joined #openstack-horizon | 08:43 | |
*** e0ne has joined #openstack-horizon | 08:46 | |
*** sayan has quit IRC | 08:46 | |
robcresswell | mrunge: Works for me. +2. | 08:52 |
mrunge | awesome, thank you robcresswell | 08:54 |
*** AJaeger has left #openstack-horizon | 08:54 | |
*** e0ne has quit IRC | 08:55 | |
*** e0ne has joined #openstack-horizon | 08:57 | |
*** ygbo has joined #openstack-horizon | 09:11 | |
*** zhurong_ has quit IRC | 09:13 | |
*** openstack has joined #openstack-horizon | 09:19 | |
*** haypo has joined #openstack-horizon | 09:21 | |
*** josecastroleon has joined #openstack-horizon | 09:26 | |
*** JeanBriceCombebi has joined #openstack-horizon | 09:27 | |
*** lhcheng has quit IRC | 09:29 | |
*** JeanBriceCombebi has quit IRC | 09:32 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: tox: add /bin/bash to whitelist_externals https://review.openstack.org/243010 | 09:40 |
*** Liuqing_ has quit IRC | 09:40 | |
*** jprovazn has joined #openstack-horizon | 09:49 | |
*** aix has joined #openstack-horizon | 09:50 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: Fix Python 3 issues in dashboard image tests https://review.openstack.org/234868 | 09:51 |
openstackgerrit | Victor Stinner proposed openstack/horizon: Port network topology tests to Python 3 https://review.openstack.org/234867 | 09:51 |
openstackgerrit | Victor Stinner proposed openstack/horizon: Port dashboard stack tests to Python 3 https://review.openstack.org/234866 | 09:51 |
openstackgerrit | Victor Stinner proposed openstack/horizon: Port dashboard router tests on Python 3 https://review.openstack.org/234865 | 09:51 |
openstackgerrit | Victor Stinner proposed openstack/horizon: Port project instance tests to Python 3 https://review.openstack.org/234864 | 09:51 |
openstackgerrit | Andreas Jaeger proposed openstack/horizon: adding general packaging information https://review.openstack.org/228423 | 09:55 |
*** Ala has quit IRC | 10:00 | |
*** zhenguo has quit IRC | 10:02 | |
*** Ala has joined #openstack-horizon | 10:03 | |
*** can8dnSix has joined #openstack-horizon | 10:07 | |
*** Liuqing has joined #openstack-horizon | 10:10 | |
*** ttrifonov has quit IRC | 10:11 | |
robcresswell | mrunge: Thanks for the +2 on the details patch!! It's been sitting for sooo long. | 10:13 |
mrunge | robcresswell, you're welcome. It's such a pain with patches involving many files | 10:14 |
robcresswell | mrunge: Indeed. It's blocking up several other networking patches I have too, so keen to get it moving. | 10:23 |
*** tosky has joined #openstack-horizon | 10:34 | |
*** bradjones has joined #openstack-horizon | 10:37 | |
*** bradjones has quit IRC | 10:37 | |
*** bradjones has joined #openstack-horizon | 10:37 | |
*** belmoreira has joined #openstack-horizon | 10:37 | |
robcresswell | Need more non-US cores for me to pester. | 10:45 |
openstackgerrit | Merged openstack/horizon: Adds config to disable the password in stack https://review.openstack.org/148997 | 10:45 |
*** masco__ has quit IRC | 10:47 | |
*** tosky has quit IRC | 10:51 | |
mrunge | robcresswell, there are: just a few, but mostly you and me active. the other 4-5 are deeply buried in their daily work, I assume. | 10:51 |
mrunge | s/:// | 10:51 |
*** tosky has joined #openstack-horizon | 10:53 | |
*** sayan has joined #openstack-horizon | 10:55 | |
*** akrivoka has joined #openstack-horizon | 11:09 | |
*** amotoki has quit IRC | 11:12 | |
*** romainh has quit IRC | 11:19 | |
*** e0ne has quit IRC | 11:21 | |
*** josecastroleon has quit IRC | 11:24 | |
*** e0ne has joined #openstack-horizon | 11:30 | |
*** ^Gal^ has quit IRC | 11:34 | |
openstackgerrit | Merged openstack/horizon: py3: Fix unicode versus bytes issues https://review.openstack.org/231523 | 11:39 |
*** weihan has joined #openstack-horizon | 11:43 | |
robcresswell | pkarikh: Thanks for the review! | 11:49 |
pkarikh | robcresswell: no problem.:) I'm looking at your another commit (https://review.openstack.org/#/c/234315/7), but I'm still in progress. :) | 11:50 |
robcresswell | pkarikh: Oh excellent, much appreciated. | 11:51 |
robcresswell | tsufiev_: Do you happen to have that list of integration tests that needs adding? I recall you spent some time putting together a rather lengthy doc... | 11:51 |
pkarikh | robcresswell: I understood that last few months I spend too less time for upstream. Look like it's time to spend more time to it :) | 11:52 |
robcresswell | pkarikh: Ha, I just commented to tsufiev_ that you were super active then suddenly disappeared | 11:57 |
*** josecastroleon has joined #openstack-horizon | 12:00 | |
pkarikh | robcresswell: yep, angular patches in upstream suddenly became unclear (and popular) for and I had not enough time to fill that spaces. Angular learning curve make me sad sometimes. :) | 12:04 |
*** wolverineav has joined #openstack-horizon | 12:07 | |
*** wolverineav has quit IRC | 12:11 | |
*** KingKhan has quit IRC | 12:12 | |
*** KingKhan has joined #openstack-horizon | 12:14 | |
*** ig0r__ has joined #openstack-horizon | 12:17 | |
*** can8dnSix has quit IRC | 12:20 | |
*** yamamoto has quit IRC | 12:26 | |
*** vgridnev has joined #openstack-horizon | 12:29 | |
*** tosky_ has joined #openstack-horizon | 12:30 | |
*** jsheeren has joined #openstack-horizon | 12:31 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: [WIP] Inline editing for LBaaS tables https://review.openstack.org/242100 | 12:31 |
*** tosky has quit IRC | 12:33 | |
*** amotoki has joined #openstack-horizon | 12:34 | |
*** jsheeren has quit IRC | 12:34 | |
*** romainh has joined #openstack-horizon | 12:34 | |
*** kzaitsev_mb has quit IRC | 12:37 | |
*** cloudtrainme has joined #openstack-horizon | 12:39 | |
*** cloudtrainme has quit IRC | 12:49 | |
*** KingKhan has quit IRC | 12:51 | |
mrunge | toabctl, thank you for your feedback on the packaging docs review | 12:53 |
toabctl | mrunge: hey. you're welcome | 12:54 |
mrunge | toabctl, just for me to confirm: zypper se -s foo will search for a package named foo? | 12:54 |
mrunge | (to add this at the right location) | 12:54 |
toabctl | mrunge: yes. and returns a list of all available versions | 12:54 |
mrunge | toabctl, awesome, thank you | 12:54 |
mrunge | toabctl, it's clear to me, we can not meet all distributions here. In fact, *I* tried to keep it as distribution agnostic as I could | 12:55 |
*** zhurong has joined #openstack-horizon | 12:55 | |
mrunge | there are still a lot distributions out there, we did not reflect there at all. It was more intended to give an overview. Next section to add would be: how to package a plugin for horizon | 12:56 |
toabctl | mrunge: sure. I like the document and I think it's very useful! | 12:56 |
*** aix has quit IRC | 12:56 | |
*** weihan has quit IRC | 12:57 | |
mrunge | I wonder if we should merge the packaging docs at some point and get smaller patches on top then | 12:57 |
mrunge | as rebasing becomes painful | 12:58 |
toabctl | mrunge: sounds good to me | 12:58 |
*** Alon has joined #openstack-horizon | 12:58 | |
openstackgerrit | Matthias Runge proposed openstack/horizon: adding general packaging information https://review.openstack.org/228423 | 13:02 |
*** pauloewerton has joined #openstack-horizon | 13:03 | |
*** aortega has joined #openstack-horizon | 13:05 | |
*** jerrygb has quit IRC | 13:07 | |
*** cloudtrainme has joined #openstack-horizon | 13:07 | |
*** yamamoto has joined #openstack-horizon | 13:08 | |
*** yamamoto has quit IRC | 13:09 | |
*** yamamoto has joined #openstack-horizon | 13:09 | |
*** yamamoto_ has joined #openstack-horizon | 13:10 | |
*** yamamoto has quit IRC | 13:13 | |
*** aix has joined #openstack-horizon | 13:14 | |
*** cloudtrainme has quit IRC | 13:20 | |
*** amotoki has quit IRC | 13:22 | |
*** e0ne has quit IRC | 13:23 | |
*** amotoki has joined #openstack-horizon | 13:27 | |
robcresswell | mrunge, zigo: Thanks for the docs work | 13:29 |
*** cloudtrainme has joined #openstack-horizon | 13:29 | |
robcresswell | Great first step for understanding issues :D | 13:30 |
zigo | Thanks. | 13:32 |
zigo | mrunge: Do you run compress at build time btw? | 13:32 |
zigo | I'm running it in postinst ... | 13:32 |
zigo | mrunge: We should add http://packages.debian.org/foo to search for package foo (or apt-cache search foo in Sid...) | 13:33 |
*** kzaitsev_mb has joined #openstack-horizon | 13:33 | |
zigo | mrunge: wrt distribution specific, I have a different view. I think it's best to give as many examples as possible for all distros. | 13:34 |
mrunge | zigo, I am running at build time, as install in docker does not support httpd systemd hooks | 13:34 |
zigo | Why would you need it as an httpd systemd hook? | 13:34 |
zigo | Can't you just run it in postinst? | 13:34 |
mrunge | zigo, tbh, I would like to remove such specific searches from the packaging docs | 13:34 |
mrunge | it doesn't really adds a value for a horizon developer | 13:34 |
zigo | I'm fine with removing it. | 13:35 |
mrunge | and we left so many distros out of the document | 13:35 |
zigo | Well, RDO / RedHat / SuSE + Debian is fine, no? | 13:35 |
mrunge | zigo, postinst is a single job | 13:35 |
mrunge | but when updating a dependency, you'll have to re-run again | 13:36 |
mrunge | that's why I added it as a httpd hook | 13:36 |
*** Alon has quit IRC | 13:36 | |
zigo | mrunge: Yeah, I use triggers in Debian for that (so that if a libjs-* package is updated, compress is ran...). | 13:36 |
zigo | Though compress is also needed when changing the default theme. | 13:36 |
zigo | Which is why I believe running it at build time is currently not very useful. | 13:36 |
mrunge | zigo, there is at least one gentoo developer, I have seen a few *bsd folks here and there | 13:37 |
mrunge | they didn't add comments yet. | 13:37 |
zigo | Its fine if they contribute, no? | 13:37 |
*** e0ne has joined #openstack-horizon | 13:37 | |
zigo | I also didn't know that Horizon could run on *BSD... | 13:37 |
mrunge | but as I said, most horizon folks are not familiar with packaging at all. adding different syntaxes for different distributions doesn't really help in getting more basic things | 13:38 |
mrunge | as long as django runs on the system, you should be fine. it should even run on windows, which we completely ignored in the guide | 13:39 |
*** cloudtrainme has quit IRC | 13:39 | |
mrunge | and django works, once you have python 2.7 or 3.x | 13:39 |
*** _crobertsrh is now known as crobertsrh | 13:42 | |
*** davidmichaelkarr has quit IRC | 13:45 | |
*** davidmichaelkarr has joined #openstack-horizon | 13:47 | |
*** amotoki has quit IRC | 13:47 | |
*** freyes has quit IRC | 13:52 | |
*** wolverineav has joined #openstack-horizon | 13:55 | |
robcresswell | doug-fish: Could I ask you to look over https://review.openstack.org/#/c/212152 ? It's the first patch for the breadcrumb patch I showed at the summit, starting to hold up a few of my Networks patches because I don't want to get mired in rebases. | 13:59 |
*** jpomeroy has joined #openstack-horizon | 13:59 | |
*** wolverineav has quit IRC | 14:00 | |
*** amotoki has joined #openstack-horizon | 14:00 | |
*** petertr7_away is now known as petertr7 | 14:03 | |
*** sayan has quit IRC | 14:06 | |
*** doug-fish has joined #openstack-horizon | 14:06 | |
*** freyes has joined #openstack-horizon | 14:10 | |
*** neelashah has joined #openstack-horizon | 14:11 | |
*** mwhagedorn has joined #openstack-horizon | 14:13 | |
*** sayan has joined #openstack-horizon | 14:13 | |
*** jerrygb has joined #openstack-horizon | 14:13 | |
*** petertr7 is now known as petertr7_away | 14:16 | |
*** julim has joined #openstack-horizon | 14:17 | |
*** Ala has quit IRC | 14:18 | |
*** absubram has quit IRC | 14:20 | |
*** lblanchard has joined #openstack-horizon | 14:25 | |
*** doug-fish has quit IRC | 14:25 | |
*** lapalm has joined #openstack-horizon | 14:25 | |
*** doug-fish has joined #openstack-horizon | 14:34 | |
*** mounica has joined #openstack-horizon | 14:50 | |
*** petertr7_away is now known as petertr7 | 14:52 | |
*** ctina has joined #openstack-horizon | 14:53 | |
*** ctina_ has joined #openstack-horizon | 14:54 | |
*** ctina_ has quit IRC | 14:54 | |
*** ctina has quit IRC | 14:54 | |
*** hurgleburgler has joined #openstack-horizon | 14:55 | |
*** willsama has joined #openstack-horizon | 14:56 | |
*** ducttape_ has joined #openstack-horizon | 14:57 | |
*** ducttape_ has quit IRC | 15:00 | |
*** ducttape_ has joined #openstack-horizon | 15:00 | |
*** zhurong has quit IRC | 15:04 | |
*** amotoki has quit IRC | 15:06 | |
*** jpomeroy has quit IRC | 15:07 | |
*** yamamoto_ has quit IRC | 15:07 | |
haypo | hi. i got a -1 on https://review.openstack.org/#/c/243010/ "tox: add /bin/bash to whitelist_externals" do i really need to open a bug for such trivial change? | 15:08 |
*** amotoki has joined #openstack-horizon | 15:08 | |
haypo | my change fixes a minor tox warning | 15:08 |
*** _ducttape_ has joined #openstack-horizon | 15:09 | |
*** vgridnev has quit IRC | 15:11 | |
*** ducttape_ has quit IRC | 15:11 | |
*** kzaitsev_mb has quit IRC | 15:12 | |
*** stevemar_ has joined #openstack-horizon | 15:13 | |
robcresswell | haypo: Ugh, it's a petty -1, but honestly in the time it takes to argue you may as well just open a one line bug. | 15:15 |
robcresswell | lapalm: ^^ It's not really necessary to open LP bugs for minor one-line fixes. | 15:16 |
*** Drago has joined #openstack-horizon | 15:17 | |
*** Drago has quit IRC | 15:17 | |
*** openstackgerrit has quit IRC | 15:17 | |
*** Drago has joined #openstack-horizon | 15:17 | |
haypo | robcresswell: i would prefer to spend 1h to discuss that than pollute the bug tracker with such minor issues | 15:17 |
*** pumaranikar has joined #openstack-horizon | 15:17 | |
*** openstackgerrit has joined #openstack-horizon | 15:17 | |
*** petertr7 is now known as petertr7_away | 15:17 | |
robcresswell | lapalm: Mainly just use it where the item is reasonably significant (i.e. blueprints for feature changes, bugs that cause noticeable functionality changes) | 15:17 |
robcresswell | haypo: Up to you :) Not that I would worry to much about polluting a bug list that is 800+ in length. | 15:18 |
lapalm | robcresswell: Okay gotcha, Thanks Rob | 15:18 |
robcresswell | lapalm: Np | 15:18 |
robcresswell | haypo: situation resolved, it seems ^^ | 15:18 |
*** absubram has joined #openstack-horizon | 15:19 | |
*** kevinbenton_ has quit IRC | 15:20 | |
haypo | lapalm: would you mind changing your vote on https://review.openstack.org/#/c/243010/ ? | 15:20 |
*** kevinbenton has joined #openstack-horizon | 15:20 | |
lapalm | haypo: yes, I am working on it now ;) | 15:20 |
robcresswell | mrunge: # TODO(gabriel): This bugfix is cribbed from Django's code. When 1.4.1 | 15:21 |
robcresswell | # is available we can remove this code. | 15:21 |
robcresswell | This makes me sad :( | 15:21 |
*** vishwanathj has joined #openstack-horizon | 15:22 | |
lapalm | haypo: Done. | 15:22 |
haypo | lapalm: thank you | 15:22 |
robcresswell | haypo, lapalm: Community in action. Thanks for addressing that :D | 15:23 |
lapalm | haypo: np | 15:23 |
*** vgridnev has joined #openstack-horizon | 15:23 | |
lapalm | robcresswell: np! Learning as I go here... ;) | 15:24 |
haypo | robcresswell, lapalm : yeah, i like when it's quickly fixed thanks to IRC. community powa! | 15:24 |
haypo | lapalm: the rule really depends on projects. some projects require a bug, some others don't | 15:25 |
lapalm | haypo: Sure, that makes sense. | 15:25 |
*** peristeri has joined #openstack-horizon | 15:25 | |
*** wlehman__ has joined #openstack-horizon | 15:26 | |
*** wlehman__ has quit IRC | 15:26 | |
robcresswell | lapalm: Mainly, just don't be too draconian about it. The tracking tools are obviously there for a reason, but we needn't hold up every tiny addition or refactor over it. | 15:27 |
*** aorourke has quit IRC | 15:28 | |
*** amotoki has quit IRC | 15:28 | |
*** wlehman__ has joined #openstack-horizon | 15:29 | |
*** petertr7_away is now known as petertr7 | 15:29 | |
*** willsama has quit IRC | 15:29 | |
*** cbader has quit IRC | 15:29 | |
lapalm | robcresswell: I understand now. I was under the impression that, like you said, launchpad was there to track any and all changes/bugs/bp's. | 15:30 |
*** aorourke has joined #openstack-horizon | 15:30 | |
lapalm | robcresswell: I see now that that there are exceptions :) | 15:30 |
lapalm | robcresswell: I personally did think it was/is silly to require bugs for such small changes, but I was just enforcing the standard. | 15:31 |
robcresswell | lapalm: Yeah, we don't need to go crazy with it. I often don't ask for bugs for refactors, for example, as its just moving code around. But I will ask for them if behaviour or functionality changes, etc. | 15:31 |
*** ducttape_ has joined #openstack-horizon | 15:32 | |
*** vgridnev has quit IRC | 15:33 | |
*** _ducttape_ has quit IRC | 15:35 | |
*** Ala has joined #openstack-horizon | 15:36 | |
*** sjmc7 has joined #openstack-horizon | 15:41 | |
*** wolverineav has joined #openstack-horizon | 15:43 | |
*** wlehman__ has quit IRC | 15:44 | |
*** mtanino has joined #openstack-horizon | 15:45 | |
*** Drago has quit IRC | 15:47 | |
*** wolverineav has quit IRC | 15:48 | |
*** Liuqing has quit IRC | 15:48 | |
*** cbader has joined #openstack-horizon | 15:49 | |
*** vijendar has joined #openstack-horizon | 15:51 | |
*** willsama has joined #openstack-horizon | 15:53 | |
*** Drago has joined #openstack-horizon | 15:53 | |
*** Drago has quit IRC | 15:53 | |
*** jpomeroy has joined #openstack-horizon | 15:58 | |
*** sjmc7 has quit IRC | 16:03 | |
*** Ala has quit IRC | 16:04 | |
*** Ephur has joined #openstack-horizon | 16:05 | |
*** sjmc7 has joined #openstack-horizon | 16:06 | |
*** krotscheck has joined #openstack-horizon | 16:07 | |
*** yamamoto has joined #openstack-horizon | 16:08 | |
*** sjmc7_ has joined #openstack-horizon | 16:09 | |
*** sjmc7_ has quit IRC | 16:09 | |
*** eroussel has joined #openstack-horizon | 16:09 | |
*** Ephur has quit IRC | 16:10 | |
*** SimonChung1 has quit IRC | 16:11 | |
*** yamamoto has quit IRC | 16:12 | |
*** kzaitsev_mb has joined #openstack-horizon | 16:15 | |
*** Drago has joined #openstack-horizon | 16:16 | |
cbader | hemna, so looks like file server came back up. but would like to know if you know of a contact if it goes down again? | 16:23 |
*** jpomeroy has quit IRC | 16:24 | |
*** e0ne has quit IRC | 16:26 | |
*** mpavlase has quit IRC | 16:27 | |
*** petertr7 is now known as petertr7_away | 16:29 | |
*** petertr7_away is now known as petertr7 | 16:31 | |
*** jpomeroy has joined #openstack-horizon | 16:33 | |
*** Piet has joined #openstack-horizon | 16:34 | |
*** e0ne has joined #openstack-horizon | 16:34 | |
*** Drago has quit IRC | 16:35 | |
*** Drago has joined #openstack-horizon | 16:36 | |
*** peristeri has quit IRC | 16:38 | |
*** lsmola has quit IRC | 16:39 | |
*** jbell8 has joined #openstack-horizon | 16:42 | |
*** aix has quit IRC | 16:45 | |
robcresswell | doug-fis_: Thanks Doug! | 16:46 |
robcresswell | for the review | 16:47 |
*** gyee has joined #openstack-horizon | 16:48 | |
*** peristeri has joined #openstack-horizon | 16:52 | |
doug-fish | robcresswell: hey no worries - I appreciate the code! | 16:53 |
*** akanksha_ has joined #openstack-horizon | 16:56 | |
*** cody-somerville has quit IRC | 16:57 | |
doug-fish | robcresswell: it seems that Network details has been omitted from your patches for breadcrumbs. Am I missing a patch? | 16:57 |
*** bpokorny has joined #openstack-horizon | 16:58 | |
*** lhcheng has joined #openstack-horizon | 16:58 | |
haypo | hey, someone available to review my latest python3 patch serie? https://review.openstack.org/#/q/status:open+project:openstack/horizon+branch:master+topic:bp/porting-python3,n,z : 2/5 are already approved | 16:58 |
*** liangbo has joined #openstack-horizon | 16:59 | |
doug-fish | robcresswell: router details too. Maybe my real question is how to manage changing all of the panels. | 17:00 |
*** aix has joined #openstack-horizon | 17:01 | |
*** ygbo has quit IRC | 17:01 | |
*** petertr7 is now known as petertr7_away | 17:05 | |
robcresswell | doug-fish: There are 2 dependants | 17:05 |
robcresswell | doug-fish: Ah, you've found them :p | 17:06 |
doug-fish | well sort of | 17:06 |
robcresswell | doug-fish: Network Details is being fixed by another | 17:06 |
doug-fish | link? | 17:06 |
doug-fish | I see routers is updated | 17:06 |
doug-fish | that was my mistake | 17:06 |
robcresswell | doug-fish: I haven't pushed Network Details yet, its the patch I showed you at the summit that makes it tabbed. | 17:07 |
doug-fish | yeah, that's a nice improvement too. | 17:07 |
robcresswell | doug-fish: There's a bug for it though: https://bugs.launchpad.net/horizon/+bug/1416838 | 17:07 |
openstack | Launchpad bug 1416838 in OpenStack Dashboard (Horizon) "Network Details should be a tabbed page" [Wishlist,New] - Assigned to Rob Cresswell (robcresswell) | 17:07 |
*** alexvictorchan has joined #openstack-horizon | 17:07 | |
doug-fish | robcresswell: how about hypervisor details? | 17:08 |
robcresswell | doug-fish: I've got quite a few cleanups for the Networks panels, just needed some to get moving before I push more of them | 17:08 |
doug-fish | sure understood | 17:08 |
robcresswell | doug-fish: Not all done yet, I have't addressed Identity at all iirc | 17:08 |
doug-fish | I'm just trying to figure out how to know when the navigation updates are "done" and how to coordinate efforts | 17:08 |
robcresswell | doug-fish: Ah, I see. I have a list I'm just working through, but the main blocker was that parent patch. Most of the others are quite trivial. | 17:09 |
*** e0ne has quit IRC | 17:09 | |
robcresswell | doug-fish: Makes for a nice refactor too! Several hundred lines removed. | 17:09 |
*** wolverineav has joined #openstack-horizon | 17:10 | |
doug-fish | yes! I have a vague recollection we considered a refactor like this in the past, but there wasn't really a good justification for it. The breadcrumbs are a good reason to clean up the code. | 17:11 |
*** wolverineav has quit IRC | 17:11 | |
*** wolverineav has joined #openstack-horizon | 17:11 | |
robcresswell | Yeah, I tried it about 9 months ago, but it got no traction. So I rolled in the navigation fix, and it seemed a bit more desirable. | 17:11 |
doug-fish | robcresswell: I had incorrectly read https://review.openstack.org/#/c/234315/ as closing 1413823 -- that's what started my questions about completeness | 17:11 |
*** krotscheck has quit IRC | 17:12 | |
robcresswell | Ah, understood | 17:12 |
robcresswell | That was just another issue I uncovered while looking around | 17:12 |
*** SimonChung has joined #openstack-horizon | 17:16 | |
*** btully has joined #openstack-horizon | 17:19 | |
openstackgerrit | Kirill Zaitsev proposed openstack/django_openstack_auth: Use set comprehension instead of converting lists to sets https://review.openstack.org/216441 | 17:22 |
*** btully has quit IRC | 17:24 | |
*** neelashah1 has joined #openstack-horizon | 17:24 | |
*** eroussel has quit IRC | 17:27 | |
*** krotscheck has joined #openstack-horizon | 17:29 | |
openstackgerrit | Steve McLellan proposed openstack/horizon: Set autodismissAlert on each alert https://review.openstack.org/242700 | 17:34 |
openstackgerrit | Steve McLellan proposed openstack/horizon: Set autodismissAlert on each alert https://review.openstack.org/242700 | 17:38 |
*** neelashah1 has quit IRC | 17:40 | |
*** tqtran has joined #openstack-horizon | 17:41 | |
*** neelashah1 has joined #openstack-horizon | 17:42 | |
*** mwhagedorn has quit IRC | 17:42 | |
*** mpavlase has joined #openstack-horizon | 17:44 | |
*** mwhagedorn has joined #openstack-horizon | 17:45 | |
openstackgerrit | Di XiaoLi proposed openstack/horizon: Add handle get_file when launch stack from horion https://review.openstack.org/241700 | 17:45 |
*** wolverineav has quit IRC | 17:46 | |
*** wolverineav has joined #openstack-horizon | 17:47 | |
*** wolverineav has joined #openstack-horizon | 17:47 | |
*** stevemar_ has quit IRC | 17:48 | |
*** bpokorny has quit IRC | 17:56 | |
*** lapalm has quit IRC | 17:58 | |
*** kzaitsev_mb has quit IRC | 17:58 | |
*** lapalm has joined #openstack-horizon | 17:58 | |
*** TravT has joined #openstack-horizon | 17:59 | |
*** aix has quit IRC | 18:00 | |
*** wolverineav has quit IRC | 18:02 | |
*** lapalm has quit IRC | 18:02 | |
*** kzaitsev_mb has joined #openstack-horizon | 18:04 | |
*** neelashah1 has quit IRC | 18:07 | |
*** belmoreira has quit IRC | 18:08 | |
*** ZZelle_ has joined #openstack-horizon | 18:15 | |
*** john5223 is now known as zz_john5223 | 18:17 | |
*** eroussel has joined #openstack-horizon | 18:18 | |
*** zz_john5223 is now known as john5223 | 18:19 | |
hurgleburgler | Can anyone tell me why 310: horizon/test/tests/workflows.py converts to bytes before checking a reg ex match? | 18:21 |
*** neelashah has quit IRC | 18:21 | |
*** tosky_ has quit IRC | 18:22 | |
*** kzaitsev_mb has quit IRC | 18:22 | |
robcresswell | haypo: ^^ | 18:23 |
*** lblanchard has quit IRC | 18:25 | |
*** lblanchard has joined #openstack-horizon | 18:25 | |
*** kzaitsev_mb has joined #openstack-horizon | 18:25 | |
*** romainh has quit IRC | 18:29 | |
*** petertr7_away is now known as petertr7 | 18:33 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Plugin Docs https://review.openstack.org/233709 | 18:35 |
*** wolverineav has joined #openstack-horizon | 18:37 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Plugin Docs https://review.openstack.org/233709 | 18:37 |
*** wolverineav has quit IRC | 18:39 | |
*** wolverineav has joined #openstack-horizon | 18:39 | |
*** neelashah has joined #openstack-horizon | 18:41 | |
*** neelashah1 has joined #openstack-horizon | 18:43 | |
*** kzaitsev_mb has quit IRC | 18:46 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Plugin Docs https://review.openstack.org/233709 | 18:47 |
*** neelashah has quit IRC | 18:47 | |
tqtran | TravT: can I bug you to take a look at https://review.openstack.org/#/c/214815/ ? been sitting there for a while now | 18:48 |
*** neelashah1 has quit IRC | 18:49 | |
TravT | tqtran: sure... i'll look at it in a bit | 18:49 |
*** neelashah has joined #openstack-horizon | 18:52 | |
*** akrivoka has quit IRC | 18:53 | |
*** pumaranikar has quit IRC | 18:53 | |
*** itisha has joined #openstack-horizon | 18:57 | |
*** e0ne has joined #openstack-horizon | 19:00 | |
*** jpomeroy has quit IRC | 19:00 | |
*** petertr7 is now known as petertr7_away | 19:01 | |
*** kzaitsev_mb has joined #openstack-horizon | 19:03 | |
*** ducttape_ has quit IRC | 19:04 | |
*** errolpais has joined #openstack-horizon | 19:04 | |
*** lapalm has joined #openstack-horizon | 19:05 | |
*** stevemar_ has joined #openstack-horizon | 19:05 | |
*** jpomeroy has joined #openstack-horizon | 19:06 | |
*** btully has joined #openstack-horizon | 19:08 | |
*** jprovazn has quit IRC | 19:08 | |
*** petertr7_away is now known as petertr7 | 19:08 | |
*** e0ne has quit IRC | 19:10 | |
*** yunpengli has joined #openstack-horizon | 19:10 | |
*** e0ne has joined #openstack-horizon | 19:10 | |
*** btully has quit IRC | 19:12 | |
*** kzaitsev_mb has quit IRC | 19:16 | |
*** pumaranikar has joined #openstack-horizon | 19:19 | |
*** mwhagedorn has quit IRC | 19:19 | |
*** garthb has joined #openstack-horizon | 19:22 | |
*** willsama has quit IRC | 19:23 | |
openstackgerrit | Errol Pais proposed openstack/horizon: Add angular flavors panel Edit Subflow https://review.openstack.org/234874 | 19:24 |
*** ducttape_ has joined #openstack-horizon | 19:26 | |
*** e0ne has quit IRC | 19:27 | |
*** jwy has joined #openstack-horizon | 19:27 | |
openstackgerrit | Tony Dunbar proposed openstack/horizon: Add STATUS_DISPLAY_CHOICE which matches Nova vm state https://review.openstack.org/238258 | 19:31 |
*** bpokorny has joined #openstack-horizon | 19:35 | |
*** August1914 has quit IRC | 19:36 | |
*** willsama has joined #openstack-horizon | 19:36 | |
*** kzaitsev_mb has joined #openstack-horizon | 19:36 | |
*** willsama has quit IRC | 19:36 | |
*** willsama has joined #openstack-horizon | 19:37 | |
*** packet has joined #openstack-horizon | 19:37 | |
*** packet has quit IRC | 19:37 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 19:39 | |
r1chardj0n3s | morning | 19:39 |
*** Piet has quit IRC | 19:40 | |
*** kzaitsev_mb has quit IRC | 19:42 | |
*** yunpengli has quit IRC | 19:43 | |
*** mwhagedorn has joined #openstack-horizon | 19:43 | |
*** crobertsrh has quit IRC | 19:45 | |
*** mwhagedorn has quit IRC | 19:46 | |
*** kzaitsev_mb has joined #openstack-horizon | 19:47 | |
*** mwhagedorn has joined #openstack-horizon | 19:47 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding CREATE action to identity users panel https://review.openstack.org/222297 | 19:48 |
robcresswell | tqtran: I'll review that again in the morning, the Create action | 19:51 |
tqtran | and the plugin docs is already ready robcresswell | 19:51 |
tqtran | *also ready, god i am still on japan time | 19:51 |
*** crobertsrh has joined #openstack-horizon | 19:52 | |
robcresswell | tqtran: Nice! Ha, yeah I'm so jetlagged, | 19:52 |
tqtran | when did you get home? | 19:52 |
robcresswell | tqtran: Did you see my comment about the docimpact flag btw? | 19:52 |
robcresswell | tqtran: Sunday mid-afternoon UK time | 19:52 |
robcresswell | Woke up at 4.30am | 19:52 |
robcresswell | Brain doesn't know what's going on anymore | 19:53 |
robcresswell | Is https://review.openstack.org/#/c/214815/ required for the create work? | 19:53 |
tqtran | i didnt.... what docimpact flag? | 19:53 |
tqtran | the if directive is not, but would be nice if it merged before the create work | 19:53 |
*** kzaitsev_mb has quit IRC | 19:53 | |
robcresswell | https://wiki.openstack.org/wiki/Documentation/DocImpact | 19:54 |
*** mwhagedorn has quit IRC | 19:55 | |
tqtran | so can we use the docimpact for this? https://review.openstack.org/#/c/214306/ | 19:55 |
*** mwhagedorn has joined #openstack-horizon | 19:55 | |
*** kzaitsev_mb has joined #openstack-horizon | 19:56 | |
robcresswell | tqtran: Add it to the commit msg for https://review.openstack.org/#/c/233709/ | 19:56 |
robcresswell | Like this: https://review.openstack.org/#/c/238043/ | 19:56 |
tqtran | from my understanding of the flag, isnt it for a patch that would impact documentation? | 19:58 |
*** garthb_ has joined #openstack-horizon | 19:58 | |
tqtran | my patch merely provides what is already undocumented, so do i still need it? | 19:58 |
robcresswell | Oh, maybe I've misunderstood it | 19:58 |
tqtran | your patch made sense because it introduced the change along with the doc | 19:58 |
*** garthb has quit IRC | 19:59 | |
tqtran | there is no code change in mine, so the docimpact flag might not be required to track. but i could be wrong, anyone else wants to weigh in? | 19:59 |
robcresswell | My understanding had been that it creates a bug for the docs folk, so it just provides visibility for their input | 19:59 |
tqtran | for justin's patch, this would make sense | 20:00 |
*** mwhagedorn has quit IRC | 20:00 | |
tqtran | we can bring it up at the meeting, i have no idea, maybe david knows | 20:01 |
robcresswell | I think you are correct | 20:01 |
*** mwhagedorn has joined #openstack-horizon | 20:01 | |
robcresswell | My interpretation of its use case was wrong. I'll ask tomorrow | 20:02 |
*** mwhagedorn has joined #openstack-horizon | 20:02 | |
*** mwhagedorn has quit IRC | 20:02 | |
*** mwhagedorn has joined #openstack-horizon | 20:05 | |
*** kzaitsev_mb has quit IRC | 20:05 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:05 | |
r1chardj0n3s | robcresswell, tqtran: I'll ask the docs PTL today and let you know :) | 20:09 |
tqtran | ok :) that will be good to know | 20:09 |
r1chardj0n3s | has there been any muttering about a midcycle btw? | 20:10 |
robcresswell | r1chardj0n3s: Ah, thanks. I tired asking in the IRC, but no response so far. | 20:10 |
robcresswell | tried* | 20:10 |
r1chardj0n3s | robcresswell: lana's only just going to be getting started for the day soon | 20:11 |
robcresswell | r1chardj0n3s: None that I've heard | 20:11 |
robcresswell | r1chardj0n3s: Heh. One-person docs team :p | 20:11 |
robcresswell | Anyone else read about reno? http://lists.openstack.org/pipermail/openstack-dev/2015-November/078301.html | 20:12 |
robcresswell | I'm trying to understand how this makes things easier :/ | 20:13 |
*** crobertsrh has quit IRC | 20:13 | |
*** mwhagedorn has quit IRC | 20:14 | |
*** crobertsrh has joined #openstack-horizon | 20:14 | |
*** mwhagedorn has joined #openstack-horizon | 20:15 | |
*** mwhagedorn has quit IRC | 20:15 | |
tqtran | easier for who is the questionlol | 20:17 |
*** akanksha_ has quit IRC | 20:18 | |
haypo | hurgleburgler: "Can anyone tell me why 310: horizon/test/tests/workflows.py converts to bytes before checking a reg ex match?" i can tell you :) | 20:20 |
haypo | hurgleburgler: output is not a string, it's an object, whereas self.assertRegexpMatches() expects a string | 20:20 |
haypo | hurgleburgler: does it reply to your question? | 20:20 |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/django_openstack_auth: Refactor d-o-a to use keystoneauth library https://review.openstack.org/205251 | 20:23 |
*** kzaitsev_mb has quit IRC | 20:26 | |
hurgleburgler | haypo yup, thanks! | 20:26 |
*** kzaitsev_mb has joined #openstack-horizon | 20:27 | |
haypo | hurgleburgler: my change was just to replace str() with bytes() which is a noop on python 2 ;) | 20:28 |
haypo | (but it matters on py3) | 20:28 |
openstackgerrit | Merged openstack/horizon: Navigation + cleanup for details pages https://review.openstack.org/212152 | 20:28 |
*** crobertsrh has quit IRC | 20:31 | |
*** ducttape_ has quit IRC | 20:32 | |
*** crobertsrh has joined #openstack-horizon | 20:33 | |
openstackgerrit | Steve Martinelli proposed openstack/django_openstack_auth: Updating default keystone API verson to 3 https://review.openstack.org/158384 | 20:39 |
*** rdopiera has quit IRC | 20:40 | |
*** ducttape_ has joined #openstack-horizon | 20:43 | |
*** vgridnev has joined #openstack-horizon | 20:44 | |
stevemar_ | yo horizon peeps | 20:45 |
stevemar_ | https://review.openstack.org/#/c/158384/ | 20:45 |
stevemar_ | i can't log in with multi domains :O | 20:45 |
stevemar_ | i think it's cause of ^ | 20:45 |
ducttape_ | why don't you just configure v3? | 20:46 |
ducttape_ | not sure why that change is needed, vs just doing a config setup of v3 | 20:46 |
ducttape_ | ala https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L49-L53 | 20:47 |
*** haypo has left #openstack-horizon | 20:47 | |
*** cody-somerville has joined #openstack-horizon | 20:51 | |
*** kzaitsev_mb has quit IRC | 20:52 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:53 | |
*** yamamoto has joined #openstack-horizon | 20:54 | |
openstackgerrit | Merged openstack/horizon: doc: subsections for neutron releated settings https://review.openstack.org/242874 | 20:55 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add breadcrumb to more details pages https://review.openstack.org/234173 | 20:56 |
openstackgerrit | Eric Peterson proposed openstack/horizon: Add support for default dns for subnet https://review.openstack.org/233290 | 20:57 |
openstackgerrit | Eric Peterson proposed openstack/horizon: Improve system info page https://review.openstack.org/225334 | 20:57 |
*** mounica has quit IRC | 21:00 | |
*** Piet has joined #openstack-horizon | 21:08 | |
*** kzaitsev_mb has quit IRC | 21:08 | |
*** ducttape_ has quit IRC | 21:10 | |
*** cody-somerville has quit IRC | 21:11 | |
*** crobertsrh has quit IRC | 21:11 | |
*** crobertsrh has joined #openstack-horizon | 21:12 | |
*** sayan has quit IRC | 21:14 | |
*** kzaitsev_mb has joined #openstack-horizon | 21:16 | |
kfox1111 | so, I've been pulling out parts of the horizon app catalog ui plugin to share with apps.openstack.org website. I've got it mostly working now. :) | 21:20 |
kfox1111 | there's a few bits of horizon that are depended on though. angular widgets. | 21:20 |
kfox1111 | has anyone considered pulling those out and shiping them seperately so they could be reused? | 21:20 |
r1chardj0n3s | kfox1111: not that I'm aware of, but +1 if those components are stable enough :) | 21:22 |
*** jhesketh has quit IRC | 21:23 | |
*** ducttape_ has joined #openstack-horizon | 21:23 | |
kfox1111 | k. :) | 21:23 |
*** pauloewerton has quit IRC | 21:24 | |
*** jhesketh has joined #openstack-horizon | 21:25 | |
*** crobertsrh has quit IRC | 21:32 | |
*** crobertsrh has joined #openstack-horizon | 21:34 | |
*** eroussel has quit IRC | 21:35 | |
*** vgridnev has quit IRC | 21:38 | |
openstackgerrit | Merged openstack/horizon: Actions directive for dynamic actions https://review.openstack.org/231335 | 21:43 |
openstackgerrit | Merged openstack/horizon: Add a Delete Modal Service for deleting entities https://review.openstack.org/234408 | 21:43 |
*** liangbo has quit IRC | 21:48 | |
*** JeanBriceCombebi has joined #openstack-horizon | 21:50 | |
*** devl_ has joined #openstack-horizon | 21:51 | |
*** crobertsrh has quit IRC | 21:53 | |
*** crobertsrh has joined #openstack-horizon | 21:54 | |
*** kzaitsev_mb has quit IRC | 21:54 | |
*** kzaitsev_mb has joined #openstack-horizon | 21:57 | |
*** crobertsrh is now known as _crobertsrh | 21:58 | |
*** david_cu has joined #openstack-horizon | 22:00 | |
*** lapalm has quit IRC | 22:01 | |
robcresswell | doug-fish: Nice catch on the translation. Just pushing a new patch. | 22:02 |
*** nlahouti has joined #openstack-horizon | 22:02 | |
*** kzaitsev_mb has quit IRC | 22:03 | |
doug-fish | robcresswell: sure - sounds good! | 22:03 |
*** julim has quit IRC | 22:05 | |
openstackgerrit | Steve McLellan proposed openstack/horizon: Set autodismissAlert on each alert https://review.openstack.org/242700 | 22:05 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add firewall detail actions and breadcrumb nav https://review.openstack.org/234315 | 22:08 |
*** petertr7 is now known as petertr7_away | 22:09 | |
robcresswell | doug-fish: Done :) | 22:09 |
robcresswell | Night folks | 22:09 |
doug-fish | robcresswell: night! | 22:09 |
*** yamamoto has quit IRC | 22:11 | |
*** peristeri has quit IRC | 22:12 | |
*** lblanchard has quit IRC | 22:12 | |
*** vgridnev has joined #openstack-horizon | 22:12 | |
*** neelashah has quit IRC | 22:12 | |
*** kzaitsev_mb has joined #openstack-horizon | 22:13 | |
*** tqtran is now known as tqtran-afk | 22:14 | |
openstackgerrit | Errol Pais proposed openstack/horizon: API Services for Flavors Panel https://review.openstack.org/214896 | 22:16 |
openstackgerrit | Errol Pais proposed openstack/horizon: Add Multiple and Single delete actions for the flavors panel https://review.openstack.org/234873 | 22:16 |
rhagarty_ | hello - looking for advice on https://bugs.launchpad.net/horizon/+bug/1511167. Basically, volume size is in GiB, not GB, so we need to change some simple panel strings. My question is about going any further, such as changing quota key names, variable names, etc. Only developers would see this, but having gibibyte values stored in a variable named "size_in_gigabytes" seems wrong. Thoughts? | 22:18 |
openstack | Launchpad bug 1511167 in OpenStack Dashboard (Horizon) "Cinder client incorrectly list the volume size units in GB, the API is actually in GiB" [Undecided,New] - Assigned to Richard Hagarty (richard-hagarty) | 22:18 |
doug-fish | rhagarty_: my thoughts: how is it that I've worked in tech for so many years and never heard of a gibibyte? | 22:21 |
rhagarty_ | doug-fish, yeah, its a storage thing. But to our customers its a big deal | 22:22 |
doug-fish | sure - not trying to make light of the situation | 22:22 |
doug-fish | I'm just trying to think of the various places these values are exposed in the UI | 22:23 |
rhagarty_ | understood... it's pretty insignificant diff, unless you are trying to manage it | 22:23 |
doug-fish | and wondering offhand if it's better to recompute the values rather than change the units | 22:23 |
rhagarty_ | volume panels, instance creation | 22:23 |
rhagarty_ | the values are correct, we are just representing them as GB, not GiB | 22:24 |
rhagarty_ | so whan a Horizon user creates a 1 GB volume (according to our panel), it creates a 1.07GB volume on the backend | 22:25 |
*** devl_ has quit IRC | 22:25 | |
doug-fish | rhagarty_: do you know if the quotas are reported/specified in GiB as well? | 22:25 |
rhagarty_ | that is just a number, but unfortunately the key value name is "gigabytes". | 22:26 |
doug-fish | *sigh* | 22:26 |
doug-fish | the behavior you describe suggests to me that some APIs use GB and some use GiB | 22:27 |
doug-fish | rhagarty_: do you think that's true? | 22:27 |
rhagarty_ | all of the storage API's use GiB | 22:27 |
rhagarty_ | and have since the beginning | 22:27 |
*** vgridnev has quit IRC | 22:28 | |
rhagarty_ | the quota stuff is related to total volume size so it should be the same. | 22:28 |
* doug-fish more thinking | 22:28 | |
rhagarty_ | doug-fish, take your time... appreciate your feedback | 22:31 |
doug-fish | rhagarty_: I assume this is a change you'll need backported? | 22:31 |
kfox1111 | there we go... got the plugin working on apps.openstack.org like system. :) | 22:31 |
doug-fish | that's affecting my thinking: in Horizon we translate these units | 22:31 |
doug-fish | so if we change the labels that's not suitable for backport | 22:32 |
rhagarty_ | doug-fish, where are we doing that? | 22:32 |
doug-fish | Admin->System->Defaults, for example | 22:32 |
doug-fish | Create Volume wizard | 22:33 |
doug-fish | - both the Size (GB) field as well as the description of Limits | 22:33 |
*** August1914 has joined #openstack-horizon | 22:34 | |
rhagarty_ | looking... | 22:34 |
*** jamielennox|away is now known as jamielennox | 22:38 | |
*** Drago has quit IRC | 22:40 | |
*** devl_ has joined #openstack-horizon | 22:42 | |
rhagarty_ | doug-fish, looking at create volume - we are not manipulating the value entered by the user. Are you talking about the comparison to the quotas? | 22:42 |
*** harlowja_ has quit IRC | 22:43 | |
doug-fish | rhagarty_: I'm just saying that the label is GB and it's a translatable element - as in, we allow it to be translated into other human languages | 22:43 |
rhagarty_ | understood, but not seeing an issue with what value is stored. | 22:45 |
*** jbell8 has quit IRC | 22:46 | |
*** stevemar_ has quit IRC | 22:49 | |
doug-fish | rhagarty_: are you considering changing cinder's quota apis to use updated labels? | 22:49 |
rhagarty_ | doug-fish, all cinder changes have already been made | 22:51 |
*** itisha has quit IRC | 22:51 | |
rhagarty_ | actually, let me double check that | 22:51 |
*** jpomeroy has quit IRC | 22:52 | |
*** kzaitsev_mb has quit IRC | 22:53 | |
*** absubram has quit IRC | 22:55 | |
*** kzaitsev_mb has joined #openstack-horizon | 22:55 | |
*** SimonChung has quit IRC | 22:57 | |
*** SimonChung1 has joined #openstack-horizon | 22:57 | |
*** SimonChung has joined #openstack-horizon | 22:57 | |
*** SimonChung1 has quit IRC | 22:58 | |
*** SimonChung1 has joined #openstack-horizon | 22:58 | |
rhagarty_ | doug-fish, let me get all the details on the cinder side and get back to you on that. | 22:58 |
*** SimonChung2 has joined #openstack-horizon | 22:58 | |
*** SimonChung1 has quit IRC | 22:58 | |
*** SimonChung has quit IRC | 22:58 | |
doug-fish | rhagarty_: sure no worries. I'm just thinking through it all ... are you aware of how nova handles units? | 22:59 |
*** SimonChung has joined #openstack-horizon | 22:59 | |
*** SimonChung2 has quit IRC | 22:59 | |
*** jerrygb has quit IRC | 22:59 | |
doug-fish | descriptions of Flavors have all kinds of units on them | 22:59 |
rhagarty_ | not sure... thought this was an easy fix :) | 23:00 |
*** jbell8 has joined #openstack-horizon | 23:01 | |
*** jerrygb has joined #openstack-horizon | 23:02 | |
doug-fish | ha! | 23:03 |
*** ybathia has joined #openstack-horizon | 23:04 | |
*** vijendar has quit IRC | 23:04 | |
*** yamamoto has joined #openstack-horizon | 23:12 | |
*** JeanBriceCombebi has quit IRC | 23:12 | |
rhagarty_ | doug-fish, not to dismiss what nova uses, but this bug is specifically to accurately reflect what the cinder client does. And for "cinder create", the size value is in GiB. So, our Horizon panels that put a UI around this call needs to be consistent. This also applies to "cinder extend". | 23:13 |
*** david_cu has quit IRC | 23:14 | |
doug-fish | rhagarty_: right now I can claim Horizon uses "traditional" decimal units to represent binary measurements. I'm afraid if we use proper terms in some locations (like GiB) and deprecated terms in others (like GB) that's actually going to increase confusion | 23:15 |
rhagarty_ | doug-fish, valid point | 23:16 |
doug-fish | I think I'm going to call it a day. Maybe the answer will be clear and simple upon my arrival tomorrow. | 23:16 |
rhagarty_ | doug-fish, Sounds like a plan. Thanks for your time. | 23:17 |
doug-fish | rhagarty_: sure no worries. TTYL | 23:17 |
*** ZZelle_ has quit IRC | 23:17 | |
*** yamamoto has quit IRC | 23:17 | |
*** kzaitsev_mb has quit IRC | 23:18 | |
*** lblanchard has joined #openstack-horizon | 23:19 | |
*** wolverin_ has joined #openstack-horizon | 23:20 | |
*** wolverin_ has quit IRC | 23:23 | |
*** wolverin_ has joined #openstack-horizon | 23:23 | |
*** wolverineav has quit IRC | 23:23 | |
*** willsama has quit IRC | 23:26 | |
*** ducttape_ has quit IRC | 23:32 | |
*** lblanchard has quit IRC | 23:44 | |
*** pumaranikar has quit IRC | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!