| *** stevemar_ has joined #openstack-horizon | 00:00 | |
| *** stevemar_ has quit IRC | 00:04 | |
| *** ybathia has quit IRC | 00:05 | |
| *** Piet has joined #openstack-horizon | 00:07 | |
| *** krotscheck has quit IRC | 00:11 | |
| *** jpomeroy has quit IRC | 00:11 | |
| *** jpomeroy has joined #openstack-horizon | 00:11 | |
| *** rajatvig has quit IRC | 00:12 | |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 00:17 |
|---|---|---|
| *** dansiwiec has quit IRC | 00:17 | |
| *** nzeplowi has quit IRC | 00:18 | |
| *** SimonChung1 has quit IRC | 00:18 | |
| *** krotscheck has joined #openstack-horizon | 00:19 | |
| *** garthb_ has quit IRC | 00:22 | |
| *** yamamoto has joined #openstack-horizon | 00:23 | |
| *** bpokorny has joined #openstack-horizon | 00:28 | |
| tqtran | sqchen: can you get matt on irc if he is still around? need to ask him a question about his patch | 00:28 |
| *** pumaranikar has joined #openstack-horizon | 00:30 | |
| sqchen | Matt is not online atm. | 00:30 |
| sqchen | tqtran: ^^ | 00:30 |
| *** bpokorny has quit IRC | 00:31 | |
| *** jpomeroy has quit IRC | 00:32 | |
| *** bpokorny has joined #openstack-horizon | 00:32 | |
| tqtran | :( ok | 00:32 |
| *** kzaitsev_mb has quit IRC | 00:33 | |
| *** bpokorny has quit IRC | 00:33 | |
| *** bpokorny has joined #openstack-horizon | 00:34 | |
| sqchen | tqtran: I left a message to him. | 00:34 |
| *** pumaranikar has quit IRC | 00:35 | |
| tqtran | coolios, thanks sean! | 00:36 |
| *** tqtran has quit IRC | 00:36 | |
| *** ybathia_ has joined #openstack-horizon | 00:37 | |
| *** yamamoto has quit IRC | 00:42 | |
| *** lblanchard has joined #openstack-horizon | 00:43 | |
| *** kmartin has joined #openstack-horizon | 00:43 | |
| *** lblanchard has quit IRC | 00:47 | |
| *** kmartin has quit IRC | 00:51 | |
| *** jpomeroy has joined #openstack-horizon | 00:54 | |
| *** pumaranikar has joined #openstack-horizon | 01:04 | |
| *** bpokorny has quit IRC | 01:05 | |
| *** neelashah has joined #openstack-horizon | 01:05 | |
| *** neelashah1 has quit IRC | 01:06 | |
| *** ybathia_ has quit IRC | 01:09 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Adding Identity ng-roles panel https://review.openstack.org/222825 | 01:11 |
| *** gyee has quit IRC | 01:15 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Adding tests for ng identity basePath constant https://review.openstack.org/221804 | 01:15 |
| *** jwy has quit IRC | 01:17 | |
| openstackgerrit | Merged openstack/horizon: Improving JS unit test branch coverage https://review.openstack.org/235984 | 01:18 |
| openstackgerrit | Merged openstack/horizon: Improving JS unit test branch coverage https://review.openstack.org/235984 | 01:18 |
| *** josecastroleon has joined #openstack-horizon | 01:22 | |
| *** zhurong has joined #openstack-horizon | 01:30 | |
| *** kzaitsev_mb has joined #openstack-horizon | 01:30 | |
| *** itisha has quit IRC | 01:31 | |
| *** sqchen has quit IRC | 01:31 | |
| *** sqchen has joined #openstack-horizon | 01:38 | |
| *** yamamoto has joined #openstack-horizon | 01:42 | |
| *** jwy has joined #openstack-horizon | 01:48 | |
| *** yamamoto has quit IRC | 01:48 | |
| *** josecastroleon has quit IRC | 01:52 | |
| *** kzaitsev_mb has quit IRC | 01:54 | |
| *** pumaranikar has quit IRC | 01:55 | |
| *** SimonChung has joined #openstack-horizon | 01:56 | |
| *** lhcheng has quit IRC | 01:59 | |
| *** stevemar_ has joined #openstack-horizon | 02:02 | |
| *** SimonChung1 has joined #openstack-horizon | 02:09 | |
| *** SimonChung has quit IRC | 02:09 | |
| *** sqchen has quit IRC | 02:11 | |
| *** clu_ has quit IRC | 02:12 | |
| *** sqchen has joined #openstack-horizon | 02:14 | |
| *** pumaranikar has joined #openstack-horizon | 02:15 | |
| openstackgerrit | Coleman Beasley proposed openstack/horizon: Add unit tests for load-edit directive https://review.openstack.org/237788 | 02:21 |
| *** mounica has quit IRC | 02:26 | |
| *** jbell8 has joined #openstack-horizon | 02:28 | |
| *** yamamoto has joined #openstack-horizon | 02:30 | |
| *** pumaranikar has quit IRC | 02:50 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:50 | |
| *** saksham has quit IRC | 02:51 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular flavors panel https://review.openstack.org/206203 | 02:53 |
| *** KunalGan_ has joined #openstack-horizon | 02:54 | |
| *** kzaitsev_mb has quit IRC | 02:55 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Magic Search Filtering to NG Flavors https://review.openstack.org/233755 | 02:57 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add a Delete Modal Service for deleting entities https://review.openstack.org/234408 | 02:57 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API Services for Flavors Panel https://review.openstack.org/214896 | 02:57 |
| *** KunalGandhi has quit IRC | 02:58 | |
| *** morgan has quit IRC | 03:00 | |
| *** zhurong has quit IRC | 03:02 | |
| *** zhurong has joined #openstack-horizon | 03:03 | |
| *** rajatvig has joined #openstack-horizon | 03:03 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Multiple and Single delete actions for the flavors panel https://review.openstack.org/234873 | 03:04 |
| *** garthb has joined #openstack-horizon | 03:04 | |
| *** lhcheng has joined #openstack-horizon | 03:19 | |
| *** jwy has quit IRC | 03:32 | |
| *** KunalGan_ has quit IRC | 03:35 | |
| *** pumaranikar has joined #openstack-horizon | 03:36 | |
| *** rajatvig has quit IRC | 03:40 | |
| *** jbell8 has quit IRC | 03:44 | |
| *** jbell8 has joined #openstack-horizon | 03:44 | |
| *** saksham has joined #openstack-horizon | 03:45 | |
| *** SimonChung has joined #openstack-horizon | 03:50 | |
| *** SimonChung1 has quit IRC | 03:54 | |
| *** SimonChung has quit IRC | 03:56 | |
| *** SimonChung has joined #openstack-horizon | 03:57 | |
| *** pumaranikar has quit IRC | 03:57 | |
| *** pumaranikar has joined #openstack-horizon | 03:57 | |
| *** SimonChung1 has joined #openstack-horizon | 04:02 | |
| *** SimonChung has quit IRC | 04:05 | |
| *** saksham_ has joined #openstack-horizon | 04:07 | |
| *** SimonChung has joined #openstack-horizon | 04:08 | |
| *** SimonChung1 has quit IRC | 04:08 | |
| *** bpokorny has joined #openstack-horizon | 04:10 | |
| *** saksham has quit IRC | 04:10 | |
| *** saksham_ is now known as saksham | 04:10 | |
| *** jbell8 has quit IRC | 04:15 | |
| *** jbell8 has joined #openstack-horizon | 04:16 | |
| *** jbell8 has quit IRC | 04:18 | |
| *** jbell8 has joined #openstack-horizon | 04:18 | |
| *** SimonChung1 has joined #openstack-horizon | 04:20 | |
| *** SimonChung has quit IRC | 04:21 | |
| *** masco has joined #openstack-horizon | 04:21 | |
| *** jbell8 has quit IRC | 04:32 | |
| *** lhcheng has quit IRC | 04:39 | |
| *** rajatvig has joined #openstack-horizon | 04:41 | |
| *** mohankumar has joined #openstack-horizon | 04:43 | |
| *** bpokorny has quit IRC | 04:52 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:52 | |
| *** bpokorny has joined #openstack-horizon | 04:53 | |
| *** pumaranikar has quit IRC | 04:54 | |
| *** kzaitsev_mb has quit IRC | 04:57 | |
| *** bpokorny has quit IRC | 04:58 | |
| *** lhcheng has joined #openstack-horizon | 05:04 | |
| *** pumaranikar has joined #openstack-horizon | 05:05 | |
| openstackgerrit | Reedip proposed openstack/horizon: Add support for IP Version in Horizon FW-Rule https://review.openstack.org/232382 | 05:06 |
| *** openstackgerrit has quit IRC | 05:16 | |
| *** openstackgerrit has joined #openstack-horizon | 05:16 | |
| *** morgan has joined #openstack-horizon | 05:16 | |
| *** stevemar_ has quit IRC | 05:19 | |
| *** stevemar_ has joined #openstack-horizon | 05:19 | |
| *** stevemar_ has quit IRC | 05:22 | |
| *** flwang has joined #openstack-horizon | 05:23 | |
| *** flwang has quit IRC | 05:27 | |
| *** saksham has quit IRC | 05:31 | |
| *** lhcheng has quit IRC | 05:44 | |
| *** rajatvig has quit IRC | 05:44 | |
| *** morgan has quit IRC | 05:45 | |
| *** pumaranikar has quit IRC | 05:52 | |
| *** garthb has quit IRC | 05:52 | |
| *** kzaitsev_mb has joined #openstack-horizon | 05:53 | |
| *** aortega has quit IRC | 05:53 | |
| *** flwang has joined #openstack-horizon | 05:57 | |
| *** flwang has quit IRC | 05:58 | |
| *** kzaitsev_mb has quit IRC | 05:58 | |
| *** morgan has joined #openstack-horizon | 06:01 | |
| *** sayan has joined #openstack-horizon | 06:03 | |
| *** josecastroleon has joined #openstack-horizon | 06:06 | |
| *** flwang has joined #openstack-horizon | 06:07 | |
| *** flwang has quit IRC | 06:11 | |
| *** flwang has joined #openstack-horizon | 06:11 | |
| *** rajatvig has joined #openstack-horizon | 06:12 | |
| *** evgenyf has joined #openstack-horizon | 06:13 | |
| openstackgerrit | Reedip proposed openstack/horizon: Add support for IP Version in Horizon FW-Rule https://review.openstack.org/232382 | 06:13 |
| *** rajatvig_ has joined #openstack-horizon | 06:14 | |
| *** rajatvig has quit IRC | 06:17 | |
| *** flwang has quit IRC | 06:21 | |
| *** flwang has joined #openstack-horizon | 06:24 | |
| openstackgerrit | Merged openstack/horizon: Add HTTPS to image location help text https://review.openstack.org/223499 | 06:30 |
| *** pumaranikar has joined #openstack-horizon | 06:31 | |
| *** e0ne has joined #openstack-horizon | 06:32 | |
| *** lsmola_ has quit IRC | 06:33 | |
| *** vgridnev has joined #openstack-horizon | 06:34 | |
| *** pumaranikar has quit IRC | 06:35 | |
| *** jamielennox is now known as jamielennox|away | 06:37 | |
| *** mohankumar has quit IRC | 06:41 | |
| *** mohankumar has joined #openstack-horizon | 06:41 | |
| *** e0ne has quit IRC | 06:42 | |
| *** wolverineav has joined #openstack-horizon | 06:46 | |
| *** josecastroleon has quit IRC | 06:46 | |
| *** lsmola_ has joined #openstack-horizon | 06:46 | |
| *** e0ne has joined #openstack-horizon | 06:47 | |
| *** dansiwiec has joined #openstack-horizon | 06:53 | |
| *** pumaranikar has joined #openstack-horizon | 06:53 | |
| *** rdopiera has joined #openstack-horizon | 06:54 | |
| *** kzaitsev_mb has joined #openstack-horizon | 06:55 | |
| *** wolverineav has quit IRC | 06:58 | |
| *** pumaranikar has quit IRC | 06:58 | |
| *** wolverineav has joined #openstack-horizon | 06:59 | |
| *** josecastroleon has joined #openstack-horizon | 07:00 | |
| *** kzaitsev_mb has quit IRC | 07:01 | |
| *** peristeri has joined #openstack-horizon | 07:02 | |
| *** linkedinyou has quit IRC | 07:06 | |
| *** flwang has quit IRC | 07:06 | |
| *** sqchen has quit IRC | 07:07 | |
| *** bluex has joined #openstack-horizon | 07:07 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: Add API services for system information https://review.openstack.org/205196 | 07:08 |
| *** bluex has quit IRC | 07:08 | |
| *** bluex has joined #openstack-horizon | 07:08 | |
| *** wolverineav has quit IRC | 07:10 | |
| *** rajatvig has joined #openstack-horizon | 07:13 | |
| *** vgridnev has quit IRC | 07:15 | |
| *** wolverineav has joined #openstack-horizon | 07:16 | |
| *** wolverineav has quit IRC | 07:17 | |
| *** wolverineav has joined #openstack-horizon | 07:18 | |
| *** wolverineav has quit IRC | 07:18 | |
| *** rajatvig has quit IRC | 07:19 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:21 | |
| *** bluex has quit IRC | 07:22 | |
| *** sayan has quit IRC | 07:24 | |
| *** vgridnev has joined #openstack-horizon | 07:24 | |
| *** e0ne has quit IRC | 07:27 | |
| *** jongchoi has joined #openstack-horizon | 07:30 | |
| *** wolverineav has joined #openstack-horizon | 07:31 | |
| *** e0ne has joined #openstack-horizon | 07:31 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: Add API services for system information https://review.openstack.org/205196 | 07:36 |
| *** sayan has joined #openstack-horizon | 07:37 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: Add angular system information panel https://review.openstack.org/204731 | 07:38 |
| *** julim has quit IRC | 07:39 | |
| *** wolverineav has quit IRC | 07:39 | |
| *** dansiwiec has quit IRC | 07:41 | |
| *** sayan has quit IRC | 07:43 | |
| *** sayan has joined #openstack-horizon | 07:44 | |
| *** aortega has joined #openstack-horizon | 07:46 | |
| *** julim has joined #openstack-horizon | 07:46 | |
| *** mohankumar has quit IRC | 07:48 | |
| *** sayan has quit IRC | 07:48 | |
| *** sayan has joined #openstack-horizon | 07:49 | |
| *** mpavlase has joined #openstack-horizon | 07:53 | |
| *** jsheeren has joined #openstack-horizon | 07:54 | |
| *** lhcheng has joined #openstack-horizon | 07:55 | |
| openstackgerrit | Reedip proposed openstack/horizon: Add support for IP Version in Horizon FW-Rule https://review.openstack.org/232382 | 07:56 |
| *** lhcheng has quit IRC | 07:59 | |
| *** zhurong has quit IRC | 08:01 | |
| *** kzaitsev_mb has quit IRC | 08:03 | |
| *** bluex has joined #openstack-horizon | 08:07 | |
| *** bluex has quit IRC | 08:07 | |
| *** bluex has joined #openstack-horizon | 08:08 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:09 | |
| *** josecastroleon has quit IRC | 08:11 | |
| *** kzaitsev_mb has quit IRC | 08:13 | |
| *** jsheeren has quit IRC | 08:14 | |
| openstackgerrit | Merged openstack/horizon: Change ports range in validators and test function https://review.openstack.org/116508 | 08:18 |
| robcresswell | Gooood morning everyone | 08:20 |
| *** josecastroleon has joined #openstack-horizon | 08:20 | |
| *** rajatvig_ has quit IRC | 08:23 | |
| *** jgrassler has joined #openstack-horizon | 08:23 | |
| *** vgridnev has quit IRC | 08:26 | |
| *** Ala has joined #openstack-horizon | 08:30 | |
| *** e0ne has quit IRC | 08:37 | |
| jgrassler | Good morning. | 08:47 |
| *** sayan has quit IRC | 08:47 | |
| jgrassler | I've got a bit of a problem with the projects dropdown in Horizon on Kilo: https://gist.github.com/anonymous/ab8a68ca9e62411e38b8 | 08:47 |
| *** tnovacik has joined #openstack-horizon | 08:48 | |
| jgrassler | We traced the root cause back to a bad endpoint URL being used | 08:48 |
| *** jongchoi has quit IRC | 08:48 | |
| jgrassler | Horizon tries to use /tokens when it should use /v2.0/tokens. | 08:48 |
| jgrassler | s/endpoint/identity endpoint/ | 08:48 |
| jgrassler | As you can see from the local_settings.py in the Gist, OPENSTACK_KEYSTONE_URL is configured to be http://10.0.80.11:5000/v2.0 - as far as I understand it Horizon should then use that URL. | 08:50 |
| jgrassler | Instead it uses http://10.0.80.11:5000 (unversioned, as you'd get it from `openstack endpoint list`) | 08:51 |
| *** sayan has joined #openstack-horizon | 08:51 | |
| jgrassler | I verified this is indeed the problem by hacking up backend.py to append the API version if it is missing from the URL (ll. 64, also in the Gist) | 08:52 |
| jgrassler | While this did indeed fix the problem, I'd prefer not to have a wrong endpoint in there in the first place - did I miss the correct way to go about that, or should I file a bug report? | 08:53 |
| *** tnovacik has quit IRC | 08:54 | |
| robcresswell | jgrassler: It sounds like a bug to me. At least file it for now, so those with better keystone knowledge can comment | 08:57 |
| robcresswell | jgrassler: Which version is this one? | 08:57 |
| jgrassler | robcresswell: Package version? | 08:58 |
| tsufiev | jgrassler: is it the same issue as in https://bugs.launchpad.net/horizon/+bug/1413851 ? | 08:58 |
| openstack | Launchpad bug 1413851 in OpenStack Dashboard (Horizon) "Horizon Identity Projects Panel doesn't list projects when configured to Keystone v3 RBAC" [Undecided,In progress] - Assigned to Dan Nguyen (daniel-a-nguyen) | 08:58 |
| robcresswell | jgrassler: Version of Horizon, as in Juno/ Kilo/ Liberty etc. | 08:58 |
| robcresswell | I don't know if packages follow those strictly, which might make that more difficult to answer | 08:59 |
| jgrassler | Ah, Kilo (the Ubuntu packages with one or two backported bugfixes of our own) | 08:59 |
| jgrassler | Definitely not the latest stable/kilo | 08:59 |
| jgrassler | Keystone v3...doesn't sound like it's exactly the same problem (we configured Horizon to use v2) | 09:00 |
| jgrassler | Let me have a quick look... | 09:00 |
| jgrassler | No, that looks like a different problem | 09:01 |
| *** openstackgerrit has quit IRC | 09:01 | |
| jgrassler | That being said, we got the same 404 when switching Horizon to Keystone v3 experimentally | 09:01 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:01 | |
| *** openstackgerrit has joined #openstack-horizon | 09:01 | |
| *** amotoki has joined #openstack-horizon | 09:01 | |
| jgrassler | (obviously, since it was still using the same unversioned Keystone endpoint URL) | 09:02 |
| jgrassler | Anyway, I guess I'll file a bug report then. Thanks! | 09:03 |
| *** akanksha_ has joined #openstack-horizon | 09:07 | |
| tsufiev | jgrassler, thank you for filing the bug :) | 09:14 |
| tsufiev | robcresswell, seems we really need to adopt a bug day practice | 09:15 |
| robcresswell | tsufiev: Yes :( | 09:15 |
| tsufiev | there are a lot of bugs with undefined priority | 09:15 |
| jgrassler | tsufiev: No worries, happy to :-) | 09:15 |
| robcresswell | tsufiev: Blueprints also crawling back up again | 09:16 |
| tsufiev | robcresswell, yeah, have to constantly run just to keep once achieved results :/ | 09:17 |
| *** e0ne has joined #openstack-horizon | 09:17 | |
| robcresswell | tsufiev: fwiw, both neutron and nova also have 1000+ bugs | 09:20 |
| tsufiev | okay, I'm relieved :) | 09:20 |
| *** ^Gal^ has joined #openstack-horizon | 09:20 | |
| *** aix has joined #openstack-horizon | 09:21 | |
| robcresswell | tsufiev: I think our bp list is nearly-manageable now anyway. I think 150 would be quite a good target, but often people will do 3/4 small bps per cycle so difficult to gauge an actual "target" | 09:22 |
| *** vgridnev has joined #openstack-horizon | 09:22 | |
| robcresswell | tsufiev: But bugs , we have 874 that are New/ Confirmed/ Triaged/ In Progress | 09:22 |
| *** sayan has quit IRC | 09:27 | |
| *** mohankumar has joined #openstack-horizon | 09:31 | |
| *** openstackgerrit has quit IRC | 09:31 | |
| *** openstackgerrit has joined #openstack-horizon | 09:31 | |
| *** ccesario_ has quit IRC | 09:33 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:35 | |
| *** exploreshaifali has joined #openstack-horizon | 09:43 | |
| tsufiev | robcresswell, still seems pretty big amount to me (even keeping in mind Neutron/Nova). Looks like a good topic to discuss on today meeting | 09:49 |
| *** JeanBriceCombebi has quit IRC | 09:50 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:50 | |
| robcresswell | tsufiev: The bp amount seems big, or bugs? | 09:53 |
| tsufiev | robcresswell, bugs | 09:54 |
| robcresswell | tsufiev: Oh, I agree, its huge and totally useless | 09:54 |
| robcresswell | No point having a tool that is just a dumping point | 09:54 |
| *** JeanBriceCombebi has quit IRC | 10:05 | |
| *** vgridnev has quit IRC | 10:07 | |
| *** vgridnev has joined #openstack-horizon | 10:07 | |
| *** lhcheng has joined #openstack-horizon | 10:07 | |
| *** zhenguo has quit IRC | 10:10 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:12 | |
| *** lhcheng has quit IRC | 10:12 | |
| *** ygbo has joined #openstack-horizon | 10:13 | |
| *** JeanBriceCombebi has quit IRC | 10:21 | |
| *** cpallares has quit IRC | 10:27 | |
| *** vkmc has quit IRC | 10:29 | |
| r1chardj0n3s | by "today' | 10:32 |
| r1chardj0n3s | s meeting" is that one in about 2.5 hours, or one in about 10 hours? | 10:32 |
| r1chardj0n3s | I've lost track :/ | 10:32 |
| robcresswell | r1chardj0n3s: I'd assume the one in 1.5 hours, -drivers | 10:32 |
| r1chardj0n3s | yep | 10:32 |
| r1chardj0n3s | I shall endeavor to stay away for that one | 10:33 |
| *** kzaitsev_mb has quit IRC | 10:35 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Get urls of datasources safer https://review.openstack.org/237976 | 10:35 |
| *** stevemar_ has joined #openstack-horizon | 10:35 | |
| r1chardj0n3s | er | 10:35 |
| r1chardj0n3s | stay awake | 10:35 |
| *** vkmc has joined #openstack-horizon | 10:35 | |
| r1chardj0n3s | not away | 10:35 |
| *** cpallares has joined #openstack-horizon | 10:36 | |
| *** tnovacik has joined #openstack-horizon | 10:36 | |
| *** stevemar_ has quit IRC | 10:38 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:40 | |
| *** ccesario has joined #openstack-horizon | 10:43 | |
| *** kzaitsev_mb has quit IRC | 10:45 | |
| tsufiev | r1chardj0n3s, your fingers tell of your real intentions ;) | 10:49 |
| *** tnovacik has quit IRC | 10:49 | |
| r1chardj0n3s | damn it!!!!! :) | 10:49 |
| *** rajatvig has joined #openstack-horizon | 10:49 | |
| r1chardj0n3s | I am fading fast though, so I think I'm gonna have to read the meeting transcript again, or I won't wake up for the morning meeting | 10:50 |
| r1chardj0n3s | (I'm currently also packing up my house for moving the day after I get back from Tokyo summit, because that's how I roll) | 10:50 |
| tsufiev | r1chardj0n3s, anyways, I don't think something important is going to be discussed in ~hour. All important stuff awaits you in Tokyo | 10:51 |
| r1chardj0n3s | well, all the arguing about forking anyway :-D | 10:51 |
| tsufiev | like 'to angular or not to angular?' | 10:51 |
| r1chardj0n3s | yup | 10:52 |
| *** rajatvig has quit IRC | 10:54 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:57 | |
| robcresswell | That topic confused me a little | 11:04 |
| robcresswell | I didn't think "to angular" was a discussion we were still having | 11:04 |
| robcresswell | more just "how best to angular" | 11:04 |
| r1chardj0n3s | robcresswell: yep | 11:04 |
| r1chardj0n3s | I read the transcript of the openstack-ironic discussion | 11:04 |
| r1chardj0n3s | so yeah, how best to | 11:05 |
| robcresswell | kfox1111: How are you handling JS testing/linting in your app catalog ui? | 11:06 |
| *** JeanBriceCombebi has joined #openstack-horizon | 11:06 | |
| *** tnovacik has joined #openstack-horizon | 11:19 | |
| *** doug-fish has joined #openstack-horizon | 11:20 | |
| *** ^Gal^ has quit IRC | 11:20 | |
| *** ^Gal^__ has joined #openstack-horizon | 11:20 | |
| *** ^Gal^__ has quit IRC | 11:20 | |
| *** ^Gal^ has joined #openstack-horizon | 11:22 | |
| *** aix has quit IRC | 11:24 | |
| robcresswell | tsufiev: Have to step away, should be back for meeting, give or take 5 mins | 11:24 |
| tsufiev | robcresswell, ok | 11:25 |
| jgrassler | tsufiev: Bug report for the project list issue submitted (https://bugs.launchpad.net/horizon/+bug/1508421 ). Took a little longer since I tried to be comprehensive :-) | 11:33 |
| openstack | Launchpad bug 1508421 in OpenStack Dashboard (Horizon) "Projects dropdown fails due to incomplete Keystone endpoint URL" [Undecided,New] | 11:33 |
| *** JeanBriceCombebi has quit IRC | 11:34 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 11:37 | |
| *** e0ne has quit IRC | 11:37 | |
| *** exploreshaifali has quit IRC | 11:38 | |
| *** sayan has joined #openstack-horizon | 11:39 | |
| *** sayan has quit IRC | 11:41 | |
| *** Guest63084 has joined #openstack-horizon | 11:43 | |
| *** kzaitsev_mb has quit IRC | 11:47 | |
| tsufiev | jgrassler, wow, it looks like a new bug template for Horizon bugs :) | 11:52 |
| *** e0ne has joined #openstack-horizon | 11:54 | |
| *** kzaitsev_mb has joined #openstack-horizon | 11:56 | |
| *** aix has joined #openstack-horizon | 12:01 | |
| *** Ephur has joined #openstack-horizon | 12:01 | |
| *** manas has joined #openstack-horizon | 12:03 | |
| *** Ephur has quit IRC | 12:06 | |
| *** ducttape_ has joined #openstack-horizon | 12:09 | |
| *** Guest63084 has quit IRC | 12:10 | |
| *** tnovacik has quit IRC | 12:12 | |
| *** sayali has quit IRC | 12:12 | |
| *** ^Gal^__ has joined #openstack-horizon | 12:16 | |
| *** ^Gal^ is now known as Guest23580 | 12:16 | |
| *** ^Gal^__ is now known as ^Gal^ | 12:16 | |
| *** openstackgerrit has quit IRC | 12:16 | |
| *** openstackgerrit has joined #openstack-horizon | 12:16 | |
| *** ^Gal^ has quit IRC | 12:17 | |
| *** Guest23580 has quit IRC | 12:17 | |
| *** ^Gal^ has joined #openstack-horizon | 12:18 | |
| *** kzaitsev_mb has quit IRC | 12:20 | |
| *** vgridnev has quit IRC | 12:20 | |
| *** yamamoto has quit IRC | 12:21 | |
| *** itisha has joined #openstack-horizon | 12:22 | |
| *** tnovacik has joined #openstack-horizon | 12:27 | |
| *** vgridnev has joined #openstack-horizon | 12:29 | |
| *** lapalm has joined #openstack-horizon | 12:33 | |
| *** ducttape_ has quit IRC | 12:34 | |
| *** JeanBriceCombebi has quit IRC | 12:46 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:48 | |
| *** sayali has joined #openstack-horizon | 12:54 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Don't hide Karma coverage reports https://review.openstack.org/238043 | 12:55 |
| *** mounica has joined #openstack-horizon | 12:55 | |
| *** stevemar_ has joined #openstack-horizon | 13:03 | |
| *** petertr7_away is now known as petertr7 | 13:04 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Get urls of datasources safer https://review.openstack.org/237976 | 13:05 |
| *** matt-borland has joined #openstack-horizon | 13:06 | |
| *** stevemar_ has quit IRC | 13:07 | |
| tsufiev | robcresswell, I like the name Karma developers chose. It leads to meaningful commit titles, like 'Don't hide Karma' | 13:07 |
| tsufiev | I presume it looks very funny to Buddhists :) | 13:08 |
| *** stevemar_ has joined #openstack-horizon | 13:09 | |
| *** kzaitsev_mb has joined #openstack-horizon | 13:09 | |
| robcresswell | tsufiev: haha, I hadnt thought of that | 13:11 |
| *** stevemar_ has quit IRC | 13:12 | |
| *** yamamoto has joined #openstack-horizon | 13:14 | |
| *** manas has quit IRC | 13:14 | |
| *** ducttape_ has joined #openstack-horizon | 13:16 | |
| *** zhurong has joined #openstack-horizon | 13:17 | |
| *** stevemar_ has joined #openstack-horizon | 13:17 | |
| *** ducttape_ has quit IRC | 13:18 | |
| robcresswell | Could one of the cores take a look at https://review.openstack.org/#/c/212152/ ? Been around a while | 13:20 |
| *** kiran-r has joined #openstack-horizon | 13:21 | |
| *** masco has quit IRC | 13:21 | |
| *** jpomeroy has quit IRC | 13:22 | |
| matt-borland | So robcresswell, I'm both livid and depressed about what I've heard about the feature branch :( | 13:25 |
| matt-borland | ch | 13:26 |
| matt-borland | I'm wondering if you can help me understand why I shouldn't be livid and depressed. :) | 13:26 |
| robcresswell | matt-borland: Go ahead | 13:26 |
| robcresswell | As in, explain the anger/sadness | 13:26 |
| matt-borland | so, what I'd heard is that we're just putting Searchlight, Identity, and Image panels in it | 13:26 |
| matt-borland | and that everything else must wait for merging until that completes | 13:27 |
| matt-borland | which I understood to be around midcycle. | 13:27 |
| matt-borland | That means that the 5 panels that have gone through UX review, etc. | 13:27 |
| robcresswell | That seems to be the current plan. The panels haven't actually been decided, yet, it depends which the developers would like to prioritise | 13:27 |
| matt-borland | will have to sit an freeze until sometime in February | 13:27 |
| robcresswell | As in, who is willing to put resources in | 13:27 |
| matt-borland | well | 13:28 |
| matt-borland | we've put quite a lot of resources into the panel work | 13:28 |
| matt-borland | cross-pollinating best practices, | 13:28 |
| matt-borland | soliticing reviews | 13:28 |
| matt-borland | establishing patterns | 13:28 |
| matt-borland | that don't exist in those areas | 13:28 |
| matt-borland | and now we're told | 13:28 |
| matt-borland | we have to wait 3 months before anyone should look at them for merging | 13:28 |
| matt-borland | I'm just saying, that was not what I wanted out of a feature branch | 13:29 |
| matt-borland | you don't need to answer/respond, I'm just registering *extreme* lack of support | 13:30 |
| *** kiran-r has quit IRC | 13:30 | |
| matt-borland | otherwise things are well :) | 13:30 |
| robcresswell | I was typing, but wondering how to phrase | 13:30 |
| robcresswell | What would you expect from a feature branch? | 13:30 |
| robcresswell | or feature branching in general. | 13:30 |
| matt-borland | well, first I'd prefer that we look at the work that has passed UX reviews, gone through design reviews, etc., to be reviewed for merging. | 13:31 |
| matt-borland | That is my first preference, regardless of FBing. | 13:31 |
| matt-borland | but it seems there is a Silence. | 13:31 |
| *** lblanchard has joined #openstack-horizon | 13:31 | |
| robcresswell | My suggestion for merging btw was around M-2, which is mid- January. | 13:31 |
| *** rdopiera is now known as rdopiera_afk | 13:31 | |
| matt-borland | sure | 13:31 |
| matt-borland | so basically, Feb would be when people might start looking at merging panels that have been already heavily reviewed *and* have passed UX reviews. | 13:32 |
| matt-borland | That is a problem. | 13:32 |
| robcresswell | In terms of which panels, frankly that can be pretty much argued amongst HP, since that appears to be most of the angular contributors | 13:32 |
| matt-borland | We've got lots of good eyes and reviews on many of those panels. | 13:32 |
| matt-borland | I think the point of a FB | 13:33 |
| matt-borland | is to address the gripe that people want to see total functionality. | 13:33 |
| matt-borland | and | 13:33 |
| matt-borland | to address the ability to better cross-pollinate between patches, by allowing them to merge to something so we don't have long chains of patches. | 13:34 |
| robcresswell | I agree on both | 13:34 |
| matt-borland | those are the advantages of the FB :) | 13:34 |
| matt-borland | but if we have a large bulk of work | 13:34 |
| matt-borland | that has many good patterns in it | 13:34 |
| matt-borland | those should be on the feature branch, too | 13:34 |
| robcresswell | But coordinating that amongst 3 panels, over the next 3 months, given the summit and christmas, seems like enough work, IMO. | 13:34 |
| matt-borland | in other words | 13:34 |
| robcresswell | once it starts getting to 5,6 panels, I'm not sure its manageable, and then we end up in the exact same situation. | 13:35 |
| matt-borland | that's not how I see it. | 13:35 |
| matt-borland | first off, I fall back on the philosophy of: | 13:35 |
| *** masco has joined #openstack-horizon | 13:35 | |
| matt-borland | we've done the process that was originally agreed to, | 13:35 |
| matt-borland | so let's merge that work. | 13:35 |
| matt-borland | I worked with you, other cores, and David to figure out the best way to structure patches | 13:35 |
| matt-borland | I did that | 13:35 |
| matt-borland | we designed a new UX review process that we said everything had to go through | 13:36 |
| matt-borland | I did that. | 13:36 |
| robcresswell | (I hasten to add, this is far from *my decision*, and I'm not trying to tell people what to do. It's just a suggestion to make both sides of the argument agree on a path) | 13:36 |
| matt-borland | I know :) | 13:36 |
| matt-borland | I appreciate you talking with me | 13:36 |
| matt-borland | this is not about aiming blame | 13:36 |
| matt-borland | this is about planning | 13:36 |
| robcresswell | Right | 13:36 |
| matt-borland | if we need to deep-freeze those 5 panels because we're waiting for some patterns | 13:37 |
| matt-borland | I object | 13:37 |
| matt-borland | but I'd like to not delude myself either | 13:37 |
| robcresswell | So the panels I've seen that appear to have good progress so far are Flavors, Users, Projects, Images, and possibly Searchlight | 13:37 |
| matt-borland | System Info and Defaults. | 13:37 |
| robcresswell | And also the system info | 13:37 |
| matt-borland | yeah, and this is all Disabled by default. | 13:38 |
| robcresswell | So that puts us right now at 7 | 13:38 |
| matt-borland | the worst we're doing is adding some unused modules into the Angular space | 13:38 |
| matt-borland | so I'd prefer we just merge the "easy" stuff | 13:38 |
| matt-borland | I don't see conflicting patterns here. | 13:38 |
| matt-borland | I wouldn't either mind creating...heh heh...ANOTHER feature branch just for those 4-5 panels | 13:39 |
| doug-fish | FWIW unused modules add to the effort of translating Horizon. | 13:39 |
| matt-borland | doug-fish, they front-load the work. | 13:40 |
| matt-borland | and most of the verbiage is redundant | 13:40 |
| matt-borland | in the areas we're talking about | 13:40 |
| matt-borland | here's the thing | 13:40 |
| doug-fish | good to know - though the way it's captured is going to require a retranslate anyway | 13:40 |
| matt-borland | I've been given every excuse in the book for Cores not to look at reviewing these panels | 13:40 |
| matt-borland | wait for X, wait for Y, not sure Angular is fast enough, memory overhead, patterns not established...a long list | 13:41 |
| matt-borland | some is good to consider, some is not | 13:41 |
| matt-borland | but it's time to p*ss or get off the pot for work that has gone the gauntlet | 13:41 |
| matt-borland | and has been reviewed positively by the community | 13:41 |
| matt-borland | but then faces what can only be called Silence of the Cores. | 13:42 |
| matt-borland | this is my opinion as a dev :) | 13:42 |
| *** Daisy has joined #openstack-horizon | 13:43 | |
| doug-fish | sure fair enough - IIRC you'll be at the summit, right? | 13:43 |
| matt-borland | yep :) | 13:43 |
| doug-fish | well get to hash it out further there, I'm sure | 13:43 |
| matt-borland | I appreciate everyone helping talk through this | 13:43 |
| robcresswell | How would you feel about increasing the size of the FB to incorporate more panels? | 13:43 |
| matt-borland | and all the support we've got | 13:43 |
| doug-fish | my point on translation was really not to expect to merge late like we did for the launch instance rewrite | 13:43 |
| matt-borland | right | 13:44 |
| robcresswell | My fear is: my branch, add 5 panels, go into refactor hell again, and the community refuses the 3000 lines that come out of it at the end. | 13:44 |
| matt-borland | so, this is a great time to merge the stuff that has been positively reviewed | 13:44 |
| matt-borland | of course, I agree robcresswell | 13:44 |
| robcresswell | my? Not sure what I meant by that | 13:44 |
| doug-fish | FWIW I had to put some code into a feature branch related to keystoneclient. I found it to be a big pain, and ultimately that feature branch never merged | 13:44 |
| doug-fish | so I have a bit of a bad taste for that approach | 13:45 |
| matt-borland | I think that each FB should have a specific set of goals | 13:45 |
| matt-borland | doug-fish, exactly | 13:45 |
| matt-borland | I'd prefer not to feature branch at all | 13:45 |
| matt-borland | we have committed to an in-place upgrade | 13:45 |
| matt-borland | (for better or worse) | 13:45 |
| robcresswell | So the compromise there is err on side of caution, let companies decide which panels they want to push for and develop those 3 panels and merge fast, refactor/ rewrite, merge early Jan, spend next 2 months adding other panels that fit patterns. | 13:45 |
| matt-borland | so that means | 13:45 |
| matt-borland | we have to incrementally add things into master | 13:45 |
| matt-borland | and iterate | 13:46 |
| matt-borland | we spent most of Liberty establishing infrastructure | 13:46 |
| matt-borland | that was painful but necessary | 13:46 |
| matt-borland | the amount of refactors we've had to apply since | 13:46 |
| doug-fish | the in-place upgrade is a real concern to me. It means we have to all agree to make the change together, and once we decide all of our consumer have to change | 13:46 |
| matt-borland | has been minimal | 13:46 |
| matt-borland | doug-fish | 13:46 |
| *** petertr7 is now known as petertr7_away | 13:46 | |
| matt-borland | I agree | 13:46 |
| doug-fish | including a total rewrite of any plugins/customizaitons they have developed | 13:46 |
| robcresswell | I disagree that it was *necessary*. Thoe style should've been decided much, much earlier. | 13:46 |
| robcresswell | Half of my agnular reviews have just been renaming files or moving code | 13:47 |
| matt-borland | robcresswell, it was necessary given where we were | 13:47 |
| robcresswell | Given that, yes. | 13:47 |
| matt-borland | yes | 13:47 |
| *** zhurong has quit IRC | 13:47 | |
| matt-borland | we are always living based on circumstance | 13:47 |
| *** jpomeroy has joined #openstack-horizon | 13:47 | |
| *** neelashah1 has joined #openstack-horizon | 13:47 | |
| matt-borland | we cannot operate in a vacuum, always have a context | 13:47 |
| matt-borland | similarly, | 13:47 |
| matt-borland | we seem to want to have an in-place upgrade rather than a fork/Horizon 2.0 | 13:48 |
| robcresswell | doug-fish: Realistically, we'd run both panels for a while, but declare a deprecation I assume. Easiest thing would be to have a "new panel" dict in the settings, so that people can toggle it locally with ease. | 13:48 |
| matt-borland | I don't know if that's good | 13:48 |
| doug-fish | maybe we need to define this term "in-place" | 13:48 |
| matt-borland | sure | 13:48 |
| matt-borland | I just meant, | 13:48 |
| *** erhudy has joined #openstack-horizon | 13:48 | |
| matt-borland | Horizon is composed of a mix of implementations as it transitions | 13:49 |
| doug-fish | robcresswell: why not just make them completely independent panels? | 13:49 |
| matt-borland | They are separate panels | 13:49 |
| matt-borland | separate names, | 13:49 |
| robcresswell | doug-fish: Well, they are separate panels. Even now they're declared as ng-<panel> | 13:49 |
| matt-borland | loaded independently | 13:49 |
| doug-fish | I'm happier already :-) | 13:49 |
| robcresswell | Indeed. | 13:49 |
| matt-borland | so customers can choose them | 13:49 |
| matt-borland | :) | 13:49 |
| robcresswell | Yep | 13:50 |
| matt-borland | so, good point doug-fish, not 'in-place' in complete replacement/swap-out | 13:50 |
| matt-borland | but rather | 13:50 |
| *** ducttape_ has joined #openstack-horizon | 13:50 | |
| matt-borland | having 1 system with 2 technologies being implemented. | 13:50 |
| doug-fish | I had overlooked that fact, and had the (apparently) incorrect assumption that we were completely replacing existing panels | 13:50 |
| matt-borland | nope :) | 13:50 |
| matt-borland | ok, cool cool | 13:50 |
| robcresswell | doug-fish: Replacing in the sense that the navbar would direct you to ng-networks etc | 13:50 |
| robcresswell | doug-fish: But the panel code would exist for both | 13:51 |
| doug-fish | sure, but that something a deployer can choose right? | 13:51 |
| matt-borland | yep | 13:51 |
| robcresswell | As I said, it would be nice to have a settings dict that just toggled new/old, rather than having to manually disabled and enable each one, but it makes little difference I suppose. | 13:51 |
| doug-fish | so if they've invested in a python based customzation to the Images panel they can use that panel | 13:51 |
| doug-fish | presumably for a deprecation period | 13:51 |
| matt-borland | yep | 13:51 |
| *** kzaitsev_mb has quit IRC | 13:51 | |
| matt-borland | exactly exactly | 13:51 |
| robcresswell | doug-fish: Precisely! | 13:51 |
| matt-borland | so that's the path we're on | 13:52 |
| *** lapalm has quit IRC | 13:52 | |
| matt-borland | and that's why all the panels that we've developed are (for merging) disabled by default | 13:52 |
| matt-borland | but even given that | 13:52 |
| *** tnovacik has quit IRC | 13:52 | |
| matt-borland | people are seemingly afraid to look at merging them. | 13:52 |
| doug-fish | FWIW I'm not afraid, but time constrained | 13:52 |
| matt-borland | I understand :) | 13:52 |
| matt-borland | so that's a factor in determining how to approach this rewrite, | 13:53 |
| matt-borland | from david's perspective | 13:53 |
| matt-borland | "cores don't have enough time" | 13:53 |
| matt-borland | but, | 13:53 |
| *** sayali has quit IRC | 13:53 | |
| matt-borland | having said that | 13:53 |
| doug-fish | in fact, I should be doing other work than having this chat now | 13:53 |
| doug-fish | but I think it's important | 13:53 |
| matt-borland | doug-fish: np, thanks for tuning in :) | 13:53 |
| *** sayali has joined #openstack-horizon | 13:53 | |
| matt-borland | I wanted to chat through this openly because I don't want there to be surprises at the summit | 13:54 |
| matt-borland | I also really need to plan where to put effort | 13:54 |
| *** stevemar_ has quit IRC | 13:54 | |
| matt-borland | and if we're freezing existing "completed" panel work | 13:54 |
| matt-borland | I need to know | 13:54 |
| matt-borland | (and simultaneously object) | 13:54 |
| doug-fish | sure - so what's the case against merging these in master w/o the feature branch? | 13:54 |
| *** petertr7_away is now known as petertr7 | 13:54 | |
| matt-borland | and also suggest alternatives | 13:54 |
| matt-borland | doug-fish, that is *exactly* what I want to know, too | 13:54 |
| doug-fish | I haven't only given them passing reviews and had the impression they weren't mature yet, mostly based on the discussion | 13:55 |
| matt-borland | well, here's the thing. | 13:55 |
| robcresswell | doug-fish: The current resistance seems to be: We merged a load of angular code at first, then spent another X months re-reviewing the code | 13:55 |
| doug-fish | but given the approach and matt-borland's assurance of the maturing I think they need a closer look | 13:55 |
| matt-borland | they've gone through UX review, unlike most other features | 13:55 |
| matt-borland | some of them have been sitting awaiting merge review for over a month | 13:55 |
| matt-borland | some parts of them, like the APIs, are mostly cookie-cutter and also have value across patches | 13:56 |
| *** peristeri has quit IRC | 13:56 | |
| matt-borland | *panels | 13:56 |
| robcresswell | matt-borland: It's worth pointing out that isn't unique, Horizon has a notably low review count across the board, comparing the numbers to other projects. | 13:56 |
| doug-fish | robcresswell: it sounds like the resistance is that we don't want to refactor? | 13:56 |
| matt-borland | That's one fear | 13:56 |
| robcresswell | doug-fish: Yes. Personally, I don't like reviewing the same code 3 times with different file paths. | 13:56 |
| matt-borland | but here's my counter argument | 13:56 |
| doug-fish | IMO Horizon is harder to review - the judgement of what is "right" can't necessarily be covered in a unit/integration test | 13:57 |
| robcresswell | And having to double check it doesnt break anything in the process | 13:57 |
| doug-fish | (though that's part of it) | 13:57 |
| robcresswell | There's a minimum time involved in any reviewing regardless, just in pulling down code and running horizon, even for seemingly trivial changes. | 13:57 |
| matt-borland | right | 13:57 |
| doug-fish | Prior to liberty the panels were untranslatable - that was a big deal to me, but not the case any more | 13:57 |
| matt-borland | and so we have to constantly re-review our patches, like the APIs, most of which have settled long ago | 13:58 |
| matt-borland | patches which, by our agreement early on, were structured explicitly so we could approve underlying patches and not have immense patches | 13:58 |
| *** kzaitsev_mb has joined #openstack-horizon | 13:58 | |
| *** mohankumar has quit IRC | 13:58 | |
| matt-borland | now that agreement is all but ignored, | 13:59 |
| *** sayali has quit IRC | 13:59 | |
| matt-borland | and generally I get abstract arguments for why no one should merge patches | 13:59 |
| matt-borland | without even looking at them. | 13:59 |
| matt-borland | I've been following these patches | 13:59 |
| doug-fish | no one should merge patches without looking at them - that's not your point is it? | 13:59 |
| matt-borland | I've been watching for refactor hell...and it hasn't happened! | 14:00 |
| matt-borland | because we're using standard features. | 14:00 |
| matt-borland | that we already established in the last releases. | 14:00 |
| robcresswell | Right, the linting and style guiding has finally settled down | 14:00 |
| matt-borland | no, the problem is that cores *aren't* generally looking at them | 14:00 |
| robcresswell | Although I still see the occasional "this should be called blah.js" patch | 14:00 |
| matt-borland | ok, | 14:01 |
| matt-borland | so, what is your point with that specifically? | 14:01 |
| *** vgridnev has quit IRC | 14:01 | |
| matt-borland | I'm talking about panel patches. | 14:01 |
| doug-fish | robcresswell: the fact it's occasional says that it's pretty mature | 14:01 |
| robcresswell | Right, as I said, its settled down now | 14:01 |
| matt-borland | yeah | 14:01 |
| robcresswell | Which is good. | 14:01 |
| matt-borland | and what I'd heard from cores before the end of Liberty was roughly: | 14:01 |
| *** sayali has joined #openstack-horizon | 14:02 | |
| matt-borland | after we have worked on some patches, we'll be able to just turn around patch reviews | 14:02 |
| robcresswell | The other part which hasn't settled, and I spoke to travis about this and he completely agreed, and this is from his angular-focused core perspective too | 14:02 |
| matt-borland | so I went and researched actual use cases | 14:02 |
| robcresswell | Is that daily churn is a nightmare | 14:02 |
| matt-borland | and followed the process | 14:02 |
| *** vgridnev has joined #openstack-horizon | 14:02 | |
| doug-fish | robcresswell: which daily churn? | 14:02 |
| *** e0ne has quit IRC | 14:03 | |
| matt-borland | you see, we haven't had the churn in the panels (except for suggestions), because there's minimal overlap with other patches | 14:03 |
| robcresswell | So, generally speaking, so that I can approve more patches, I will A) wait until a couple of non-cores have reviewed, and B) wait until the patch has 2/3 days without changing. I don't want to review a patch, only to have to re-review it every day of the week. | 14:03 |
| matt-borland | robcresswell, absolutely | 14:04 |
| *** JeanBriceCombebi has quit IRC | 14:04 | |
| matt-borland | so here's what we've done to shelter all the cores | 14:04 |
| robcresswell | The sys info API patch, for example, has had 9 opatch sets since yesterday | 14:04 |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:05 | |
| matt-borland | OK, so how do you want to talk about this, | 14:05 |
| matt-borland | because basiaclly what I do is this" | 14:05 |
| matt-borland | this: | 14:05 |
| matt-borland | After the UX review, and after our internal review, I ask for others to review the panel patches, right now, only 3 total patches (not panels) at a time. | 14:05 |
| matt-borland | so we are not clobbering the community | 14:05 |
| matt-borland | of course we get feedback on those | 14:06 |
| robcresswell | sure | 14:06 |
| matt-borland | like Sysinfo API, frankly that was stable for a couple of weeks | 14:06 |
| matt-borland | until yesterday, when Richard pointed out a mocking issue he'd missed before | 14:06 |
| matt-borland | it's frankly not the most important thing in the world, but we address it | 14:06 |
| matt-borland | then, at what point do we ask cores for reviews? | 14:07 |
| matt-borland | 3 days? | 14:07 |
| *** tristanC has quit IRC | 14:07 | |
| matt-borland | 2 weeks? | 14:07 |
| matt-borland | it was a mock. | 14:07 |
| matt-borland | the feature itself has been virtually unchanged otherwise | 14:07 |
| matt-borland | and what of the other APIs that have been sitting ready for review? | 14:08 |
| matt-borland | do we decide not to review those because someone else saw that there was movement in another patch? | 14:08 |
| matt-borland | this is the kind of abstract argument I don't like | 14:08 |
| *** jongchoi has joined #openstack-horizon | 14:08 | |
| robcresswell | I can only explain the reasons I personally would avoid reviewing something | 14:09 |
| robcresswell | I can't speak for the other cores | 14:09 |
| matt-borland | I know :) | 14:09 |
| matt-borland | I am voicing my perspective, not condemning :) | 14:09 |
| doug-fish | matt-borland: here's why I haven't spent much time yet on the angular patches: Early in the release we had a lot of churn with lint/format type issues and it seemed enough people reviewing that ... | 14:09 |
| doug-fish | later in the release, I had the impression there was refactoring going on to help sort out key patterns ... | 14:09 |
| doug-fish | that's where I thought we were | 14:10 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: [WIP] Skip UpdatePrijectMembers if user_list failed https://review.openstack.org/237615 | 14:10 |
| matt-borland | I like specifics | 14:10 |
| robcresswell | So the API for flavors: 7 patch sets in the last week. API for quotas 10 in the last week. Note, this is often multiple patch sets without comments or revies, where the author is just spontaneously updating it. | 14:10 |
| doug-fish | I've been lightly reviewing and my key concerns have been addressed (translatability and extensibility) | 14:10 |
| robcresswell | If I go and +2 because I think its good enough based on my knowledge, and then the author updates it 2 hours later, I need to pull the patch again, check their patchset changes etc. | 14:11 |
| matt-borland | robcresswell, several things: | 14:11 |
| matt-borland | 1) I ask people to put descriptions of their changes in, if they don't do that, bad on them. | 14:11 |
| doug-fish | robcresswell: rereviewing patches you already know is a good way to boost your review numbers! | 14:12 |
| matt-borland | 2) there's a fine balance between static reviews because they're not reviewed, and a well-reviewed patch that has gone dormant | 14:12 |
| robcresswell | doug-fish: :) gotta get those numbers. | 14:12 |
| doug-fish | you know you can see the changes between patch sets, right? | 14:12 |
| robcresswell | doug-fish: Ha, yes of course | 14:12 |
| doug-fish | robcresswell: yeah, I should work on that. | 14:12 |
| matt-borland | either way it's nice to have a description | 14:12 |
| matt-borland | the other thing, | 14:13 |
| matt-borland | again, is that when I've asked people to officially ask for merge review, | 14:13 |
| robcresswell | doug-fish: My point was it still takes time, that I could spend looking into other patches | 14:13 |
| *** masco has quit IRC | 14:13 | |
| *** Daisy has quit IRC | 14:13 | |
| *** pumaranikar has joined #openstack-horizon | 14:13 | |
| matt-borland | so, again, how long of 'quiet time' is needed? | 14:13 |
| robcresswell | couple days is normally enough for me. | 14:14 |
| *** Daisy has joined #openstack-horizon | 14:14 | |
| matt-borland | OK | 14:14 |
| matt-borland | I can work with that. | 14:14 |
| robcresswell | Its not that I have a specific "you shall not pass" rule, more that if someone says "please review this cores" and its had 5 patch sets in the last hour I'll likely leave it for the time being. | 14:14 |
| matt-borland | I can absolutely find patches that have otherwise been stable. And frankly, those APIs, if you look at what is changing, they are largely stable and have been. | 14:15 |
| *** sayali has quit IRC | 14:15 | |
| matt-borland | but, like any time you ask for a review, | 14:15 |
| matt-borland | someone will find a nit | 14:15 |
| matt-borland | so you feel compelled to address it | 14:15 |
| matt-borland | robcresswell, of course | 14:16 |
| matt-borland | about the 5 PS in last hour | 14:16 |
| matt-borland | I have never asked a core to review such a patch. | 14:16 |
| doug-fish | I'm glad we've had this pre-summit chat - frankly, I think if any of these patches are mature (and it sounds like they are) creating the feature branch will only slow progress | 14:16 |
| robcresswell | Well, that depends on the scope of the nit really. If you've got 500 lines of code and someone points out you've forgotten a '.' in your commit message, ignore it. | 14:16 |
| doug-fish | and require that we get *all* of the panels ready before *any* can merge | 14:16 |
| *** sayali has joined #openstack-horizon | 14:17 | |
| matt-borland | You gotta remember, in this case, it's complex, because we're getting feedback that "we're new the community and should be good members," | 14:17 |
| matt-borland | so those that are new are more ready to please by making the change | 14:17 |
| doug-fish | ironically, chatting about this is taking away time that I could actually do reviews later, so I'm going to step away | 14:17 |
| robcresswell | doug-fish: I don't really mind how we address it. I like the angular work, but I'm not expert in it, so reviews take time. | 14:17 |
| matt-borland | doug-fish, thanks for your participation here | 14:17 |
| robcresswell | doug-fish: Thanks Doug | 14:17 |
| matt-borland | I really appreciate the opportunity to go thru this | 14:17 |
| doug-fish | sure no worries. Looking forward to talking further next week. | 14:17 |
| matt-borland | see you there! | 14:17 |
| matt-borland | robcresswell, sorry for venting publicly, but hadda do it | 14:18 |
| *** Daisy has quit IRC | 14:18 | |
| matt-borland | I'd rather people know my perspective than I just whisper it | 14:18 |
| *** rajatvig has joined #openstack-horizon | 14:19 | |
| matt-borland | this is a very complex situation, I appreciate everyone's work | 14:19 |
| matt-borland | I don't want it to come off as otherwise :) I just need to express my interests | 14:19 |
| *** Daisy has joined #openstack-horizon | 14:22 | |
| *** rajatvig has quit IRC | 14:24 | |
| robcresswell | matt-borland: No problem | 14:24 |
| robcresswell | Just making coffee, back in a mo | 14:25 |
| *** jongchoi has quit IRC | 14:28 | |
| *** mhorban_ has joined #openstack-horizon | 14:31 | |
| matt-borland | robcresswell, no problem :) | 14:31 |
| *** lastovich has joined #openstack-horizon | 14:32 | |
| *** aortega has quit IRC | 14:32 | |
| matt-borland | we have amazing, intelligent, professional people here in Horizon...we have lots of opportunity...let's capitalize on that! Let none of my concerns belittle that attitude. | 14:33 |
| *** vkmc is now known as vkmc-afk | 14:34 | |
| *** JeanBriceCombebi has quit IRC | 14:35 | |
| robcresswell | david-lyle: ping | 14:37 |
| *** lastovich has quit IRC | 14:38 | |
| *** david_cu has joined #openstack-horizon | 14:39 | |
| ducttape_ | matt-borland - I don't seem to fit in any of your categories :P | 14:39 |
| *** david_cu_ has joined #openstack-horizon | 14:39 | |
| matt-borland | ha! | 14:39 |
| matt-borland | :) | 14:39 |
| matt-borland | it always pays to be unique | 14:40 |
| *** david_cu_ has quit IRC | 14:41 | |
| *** david_cu has quit IRC | 14:41 | |
| *** lastovich has joined #openstack-horizon | 14:41 | |
| robcresswell | ducttape_: What's your stance on this? | 14:42 |
| ducttape_ | on the reviews in general? | 14:42 |
| ducttape_ | like what gets looked at? when do things get merged? | 14:43 |
| robcresswell | ducttape_: On the angular work and where it should live | 14:43 |
| robcresswell | and the various frustrations shared by people :p | 14:43 |
| ducttape_ | I think we have a lot of energy / people working on ng stuff, and it is not making the progress that *everyone* would like | 14:44 |
| ducttape_ | but just merging more code in, is not really always the best fix | 14:44 |
| ducttape_ | I think part of the reason of the slow uptake, is that what we have is not really ready for broad adoption | 14:45 |
| ducttape_ | horizon's success is that you have mostly python library developers who want stuff to show up on a web page | 14:45 |
| ducttape_ | if our angular layer would do more work to make it easier for these people, things would be going smoother I think | 14:46 |
| matt-borland | thanks, good points | 14:46 |
| *** yamamoto has quit IRC | 14:46 | |
| ducttape_ | like auto generate most of the angular content, with options to customize angular at certain extension points | 14:47 |
| ducttape_ | right now, if we have 10 patches with tons of separate js files - that is starting to sign up for a long term support issue | 14:48 |
| ducttape_ | so getting the right pattern at the begining is important, and I'm not sure we have that yet | 14:48 |
| ducttape_ | these are my ideas, I'm sure others might see it differently | 14:48 |
| robcresswell | matt-borland: I had one question. What was the reason for choosing to do ng-include and ng-controller for the index tables, rather than a directive? | 14:49 |
| matt-borland | many of the patches don't use ng-include. The original thought was that that would be a way to make it extensible. | 14:50 |
| ducttape_ | tqtran and I had an approach where you could convert all table views to angular, and it would take about 3 lines of code changes per table. While that approach was not supported, I think we need something like that | 14:50 |
| *** Daisy has quit IRC | 14:50 | |
| matt-borland | if you want to see extensibility, jpomeroy has a good patch for that | 14:50 |
| *** Daisy has joined #openstack-horizon | 14:51 | |
| matt-borland | ducttape_, I kind of agree with that patch, with several ifs. I've heard strong arguments against that for other reasons, but I feel it could be a good bridge. | 14:51 |
| robcresswell | ducttape_: Which patch is that? | 14:51 |
| matt-borland | it however doesn't easily deal with variance *if* we want to deviate the UX much. | 14:51 |
| *** Piet has quit IRC | 14:51 | |
| ducttape_ | https://review.openstack.org/#/c/94706/ | 14:52 |
| ducttape_ | it's as old as dirt | 14:52 |
| *** lapalm has joined #openstack-horizon | 14:52 | |
| *** petertr7 is now known as petertr7_away | 14:53 | |
| ducttape_ | matt-borland - this is where I would say that adding customization hooks should be done over time. trying to think of every possible extension point is not an effective use of time | 14:53 |
| *** Drago has joined #openstack-horizon | 14:53 | |
| matt-borland | exactly! I agree 100% with that sentiment :) | 14:54 |
| robcresswell | matt-borland: I don't suppose you have an example of a non-ng-include panel? Sorry | 14:54 |
| ducttape_ | and also, sometimes you build extension points that nobody cares about | 14:54 |
| *** Drago has quit IRC | 14:54 | |
| *** Drago has joined #openstack-horizon | 14:54 | |
| matt-borland | https://review.openstack.org/#/c/206203/40/openstack_dashboard/dashboards/admin/static/dashboard/admin/flavors/table/flavors-table.html | 14:54 |
| matt-borland | if that's what you mean robcresswell | 14:55 |
| matt-borland | if you use that approach | 14:55 |
| matt-borland | it's quite transparent how it all works | 14:55 |
| matt-borland | and if there is a need for extensibility | 14:55 |
| *** stevemar_ has joined #openstack-horizon | 14:55 | |
| robcresswell | Ah, I meant why was this pattern chosen; <ng-include src="'{{ STATIC_URL }}dashboard/admin/flavors/table/flavors-table.html'"></ng-include> | 14:55 |
| robcresswell | and then ng-controller in the table.html | 14:55 |
| *** stevemar_ has quit IRC | 14:56 | |
| *** Daisy has quit IRC | 14:56 | |
| robcresswell | vs just having a "flavors table" directive that links the two | 14:56 |
| *** e0ne has joined #openstack-horizon | 14:56 | |
| matt-borland | well, let's back up 1 second | 14:56 |
| matt-borland | there is a transition here | 14:56 |
| ducttape_ | matt-borland - see that patch as an example | 14:56 |
| ducttape_ | you could auto generate that | 14:56 |
| matt-borland | yep, I've looked at it, exactly | 14:56 |
| matt-borland | I don't disagree with having that approach on top of other more explicit markup too | 14:57 |
| matt-borland | in fact | 14:57 |
| *** lapalm has quit IRC | 14:57 | |
| matt-borland | I'd prefer that we have the 'quickie table' approach so that implementers of either core or extended features can just whip them together | 14:57 |
| robcresswell | It seems to me that an awful lot of the 'table.html' files is absolutely identical. In fact, bar the column names, you can pretty much s/flavor/user/g and get the same table. | 14:57 |
| matt-borland | and not have to fuss with markup in every case | 14:57 |
| matt-borland | robcresswell, talk with Thai about that approach. | 14:58 |
| *** sayali has quit IRC | 14:58 | |
| matt-borland | I am not invested in that approach | 14:58 |
| matt-borland | frankly | 14:58 |
| robcresswell | I was just wondering if we could end up with a thing like <hz-index-table columns="[]"> | 14:58 |
| ducttape_ | I'd like it so openstack project XYZ comes in with a new library, can do a bit of python, and needs little in the way of doing much else (unless they are motivated to) | 14:58 |
| robcresswell | Sure thing | 14:58 |
| matt-borland | for the short term we're in what I call a 17-page-app | 14:58 |
| matt-borland | that entire routing can change | 14:58 |
| matt-borland | and when it does, | 14:58 |
| matt-borland | the top level of includes goes away | 14:58 |
| *** lapalm has joined #openstack-horizon | 14:58 | |
| *** stevemar_ has joined #openstack-horizon | 14:59 | |
| *** lapalm has joined #openstack-horizon | 14:59 | |
| matt-borland | robcresswell, I've tried working that over with Thai as well; I wrote an hz-table patch a long time ago | 14:59 |
| robcresswell | I know with the magnum UI basic tables, they're all displaying ID/ Name/ Status/ Actions, and they're all carbon copies except for the model names | 14:59 |
| robcresswell | With the python we just declare a list of names and a few other things, like truncate for example, and the tabel does some magic. This feels way more manual to me. | 15:00 |
| robcresswell | table* | 15:00 |
| matt-borland | robcresswell, there are some issues | 15:00 |
| robcresswell | Sure | 15:00 |
| matt-borland | what we see in UX | 15:00 |
| matt-borland | is that we want much more nested elements | 15:00 |
| matt-borland | which you can of course make programmable thru such a configuration | 15:00 |
| matt-borland | but | 15:00 |
| *** sayali has joined #openstack-horizon | 15:00 | |
| matt-borland | in markup, you just do it. | 15:00 |
| matt-borland | add in the tags/elements you want. | 15:01 |
| matt-borland | unlimited | 15:01 |
| matt-borland | want a donut chart? | 15:01 |
| matt-borland | awesome. | 15:01 |
| matt-borland | but if it's more imperative | 15:01 |
| matt-borland | driven by python | 15:01 |
| matt-borland | you have to either make a million little hooks | 15:01 |
| matt-borland | or something similar | 15:01 |
| matt-borland | so, | 15:01 |
| *** alejandrito has joined #openstack-horizon | 15:01 | |
| matt-borland | the hz-table IS good, and I'd support having one. | 15:01 |
| matt-borland | that produces a "good enough" table | 15:02 |
| robcresswell | I'm not saying we should drive it with python, just that we should be more DRY | 15:02 |
| *** alejandrito has quit IRC | 15:02 | |
| matt-borland | sure | 15:02 |
| matt-borland | that is always a concern | 15:02 |
| robcresswell | The first 20 lines of https://review.openstack.org/#/c/206203/40/openstack_dashboard/dashboards/admin/static/dashboard/admin/flavors/table/flavors-table.html | 15:02 |
| *** alejandrito has joined #openstack-horizon | 15:02 | |
| matt-borland | doesn't mean we should hold up EVERY panel patch | 15:02 |
| robcresswell | are the same in every single table so far | 15:02 |
| matt-borland | which again, is my issue :) | 15:02 |
| robcresswell | Sure | 15:02 |
| matt-borland | if you don't like the pattern, argue it | 15:02 |
| matt-borland | with the people that are arguing for it. | 15:02 |
| * robcresswell spreads -1s throughout the land | 15:03 | |
| matt-borland | this is something Thai was very keen on | 15:03 |
| matt-borland | and he explained his reasons | 15:03 |
| robcresswell | Yeah, I brought it up in a hangout ages ago | 15:03 |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:03 | |
| matt-borland | :) | 15:03 |
| robcresswell | It seems really anti-angular to me | 15:03 |
| matt-borland | so, | 15:03 |
| matt-borland | there are some questions. | 15:03 |
| robcresswell | My studies of it have always turned up with "directive all the things" | 15:04 |
| matt-borland | robcresswell, I think that is generally true. | 15:04 |
| matt-borland | I had written my original patches that way | 15:04 |
| matt-borland | I was then told that it's just adding indirection | 15:04 |
| matt-borland | which in a way, is true | 15:05 |
| matt-borland | both from a design perspective | 15:05 |
| matt-borland | and from a programming perspective | 15:05 |
| matt-borland | and it's kind of true. | 15:05 |
| ducttape_ | my concern with good-enough is that no one ever comes back to fix things. this is the same as agile - stuff needs to be done-done | 15:05 |
| matt-borland | having said that | 15:05 |
| *** jprovazn has joined #openstack-horizon | 15:06 | |
| matt-borland | in terms of patterns, nothing is perfect. | 15:06 |
| matt-borland | esp in angular, where the patterns are vague and sometimes ambiguous | 15:06 |
| matt-borland | so at some point you either p*ss or get off the pot. I explicitly worked on a number of panels so we'd get better perspective. | 15:07 |
| matt-borland | they have been available to look at for quite some time | 15:07 |
| matt-borland | these are not new arguments. Somehow we agree to disagree, or we prioritize our disagreements and commit to resolving them. | 15:08 |
| matt-borland | NOT...wait for the code to just work the way we want it to work. | 15:08 |
| *** SimonChung1 has quit IRC | 15:08 | |
| *** JeanBriceCombebi has quit IRC | 15:09 | |
| *** yamamoto has joined #openstack-horizon | 15:09 | |
| *** Daisy has joined #openstack-horizon | 15:09 | |
| robcresswell | Sure | 15:10 |
| robcresswell | I'll ask thai to explain | 15:10 |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:11 | |
| matt-borland | And the point of "never fixing things" | 15:11 |
| matt-borland | I call shenannigans on that, if only because all of Liberty was refactoring work done in Kilo, to make it more right. | 15:12 |
| matt-borland | in fact, that is one approach I like. One release for new content, one release for refactors. | 15:12 |
| matt-borland | allows consumers to better plan their adoption | 15:13 |
| robcresswell | matt-borland: As a generally OpenStack trend people have a habit of writing code then disappearing | 15:13 |
| matt-borland | it's not surprising :) | 15:13 |
| robcresswell | matt-borland: So letting people write crap code on the promise of "we'll fix it later" is a bad move. | 15:13 |
| *** stevema__ has joined #openstack-horizon | 15:13 | |
| matt-borland | but I believe, if there's a process problem and a goal...fix the process. | 15:13 |
| matt-borland | don't abandon the goal | 15:13 |
| matt-borland | don't wallow in misery about the failed process | 15:14 |
| matt-borland | I think we established there's a difference between "crap code" and "code that some people have disagreements about" | 15:14 |
| matt-borland | so let's just be clear, no one is suggesting merging crap code. | 15:15 |
| robcresswell | Sure, I'm speaking pretty generally about openstack here | 15:15 |
| matt-borland | I like specifics :) | 15:15 |
| robcresswell | Not "how I think we should handle tables" | 15:15 |
| matt-borland | but that was the extension of that argument, wasn't it? I just want to explain yet another "reason we shouldn't merge X" | 15:15 |
| tsufiev | robcresswell, doug-fish: gentlemen, could I ask for your opinion in this review: https://review.openstack.org/#/c/115092/ ? | 15:16 |
| tsufiev | (it's not my patch) | 15:16 |
| robcresswell | matt-borland: Which argument? I was just curious why we decided to do ng-include and not directives, thats all | 15:16 |
| *** stevemar_ has quit IRC | 15:16 | |
| tsufiev | it's about the integration tests coverage for admin vs. non-admin roles | 15:17 |
| matt-borland | I dunno! | 15:17 |
| matt-borland | :) | 15:17 |
| robcresswell | lol, okay | 15:17 |
| tsufiev | matt-borland, sorry to interrupt your lovely discussion | 15:17 |
| matt-borland | tsufiev, no problem! :) | 15:17 |
| *** Ephur has joined #openstack-horizon | 15:17 | |
| robcresswell | tsufiev: I need to get on with some actual code for now :) | 15:18 |
| *** emilyw has joined #openstack-horizon | 15:19 | |
| matt-borland | robcresswell, thanks again for being a sounding-board. :) | 15:20 |
| tsufiev | robcresswell, oh, my evil plan was to get your judgement w/o reading the code ) | 15:20 |
| tsufiev | s/evil/cunning/ | 15:20 |
| robcresswell | tsufiev: heh, assume good and just +2? | 15:22 |
| robcresswell | I must have a bad reputation :( | 15:22 |
| tsufiev | robcresswell, nope, it's not about +2. It's just about -1 vs. -2 :) | 15:22 |
| *** kmartin has joined #openstack-horizon | 15:23 | |
| *** ZZelle has joined #openstack-horizon | 15:23 | |
| tsufiev | robcresswell, I feel obliged to tnovacik, because he built most of stuff I'm taking credits for fixing now | 15:24 |
| *** Ala has quit IRC | 15:25 | |
| robcresswell | tsufiev: Ahh, I see | 15:27 |
| *** garthb has joined #openstack-horizon | 15:28 | |
| *** yamamoto_ has joined #openstack-horizon | 15:29 | |
| *** aortega has joined #openstack-horizon | 15:29 | |
| *** yamamoto has quit IRC | 15:32 | |
| *** lhcheng has joined #openstack-horizon | 15:33 | |
| *** bpokorny has joined #openstack-horizon | 15:37 | |
| *** bluex has quit IRC | 15:38 | |
| *** bpokorny has quit IRC | 15:39 | |
| *** bpokorny has joined #openstack-horizon | 15:39 | |
| *** vgridnev has quit IRC | 15:46 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Don't hide Karma coverage reports https://review.openstack.org/238043 | 15:46 |
| *** evgenyf has quit IRC | 15:46 | |
| *** petertr7_away is now known as petertr7 | 15:50 | |
| *** JeanBriceCombebi has quit IRC | 15:52 | |
| *** Daisy has quit IRC | 15:53 | |
| *** neelashah1 has quit IRC | 15:53 | |
| *** Daisy has joined #openstack-horizon | 15:53 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:54 | |
| *** ygbo has quit IRC | 15:56 | |
| *** Daisy has quit IRC | 15:58 | |
| *** vgridnev has joined #openstack-horizon | 15:59 | |
| *** stevema__ has quit IRC | 16:00 | |
| *** vkmc-afk is now known as vkmc | 16:01 | |
| *** vkmc has quit IRC | 16:01 | |
| *** vkmc has joined #openstack-horizon | 16:01 | |
| *** neelashah1 has joined #openstack-horizon | 16:01 | |
| *** JeanBriceCombebi has quit IRC | 16:02 | |
| *** rajatvig has joined #openstack-horizon | 16:02 | |
| *** exploreshaifali has joined #openstack-horizon | 16:05 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API for getting and updating quotas https://review.openstack.org/207126 | 16:05 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel subflows for admin https://review.openstack.org/234986 | 16:05 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel for admin https://review.openstack.org/205296 | 16:05 |
| *** emilyw has quit IRC | 16:05 | |
| pkarikh | Hi folks! Does anyone know, is there any way to apply patches from gerrit into devstack installation? For example, if I want to check gerrit patch for horizon or keystone from the devstack. | 16:06 |
| matt-borland | pkarikh, I've done that before | 16:08 |
| *** john5223 is now known as zz_john5223 | 16:09 | |
| matt-borland | usually just shuffle around where Horizon has been installed to to be a working dir, | 16:09 |
| *** sqchen has joined #openstack-horizon | 16:09 | |
| matt-borland | and copy/replace local_settings.py accordingly | 16:09 |
| pkarikh | matt-borland: hm.. So, there is no some service repo in the devstack, so I can just git pull someones changes? | 16:10 |
| *** Piet has joined #openstack-horizon | 16:11 | |
| matt-borland | no, I swap out the horizon dir with a working directory | 16:11 |
| pkarikh | matt-borland: ok, thanks! | 16:12 |
| david-lyle | pkarikh: yes you can do it all from there | 16:12 |
| david-lyle | not the best way, but expedient at times | 16:13 |
| david-lyle | it's just a clone of the repo | 16:13 |
| *** petertr7 is now known as petertr7_away | 16:13 | |
| *** neelashah1 has quit IRC | 16:13 | |
| *** e0ne has quit IRC | 16:16 | |
| *** e0ne has joined #openstack-horizon | 16:17 | |
| *** rdopiera_afk is now known as rdopiera | 16:19 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular flavors panel https://review.openstack.org/206203 | 16:23 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add button to Create new Flavor https://review.openstack.org/234875 | 16:23 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular flavors panel Edit Subflow https://review.openstack.org/234874 | 16:23 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Multiple and Single delete actions for the flavors panel https://review.openstack.org/234873 | 16:23 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API Services for Flavors Panel https://review.openstack.org/214896 | 16:23 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add a Delete Modal Service for deleting entities https://review.openstack.org/234408 | 16:23 |
| david-lyle | pkarikh: the exact command is git review -d <change-id> just for completeness | 16:24 |
| *** petertr7_away is now known as petertr7 | 16:27 | |
| *** logan2 has quit IRC | 16:27 | |
| *** clu_ has joined #openstack-horizon | 16:28 | |
| *** lastovich has quit IRC | 16:29 | |
| *** SimonChung has joined #openstack-horizon | 16:29 | |
| *** stevemar_ has joined #openstack-horizon | 16:36 | |
| *** exploreshaifali has quit IRC | 16:38 | |
| *** doug-fish has quit IRC | 16:40 | |
| *** doug-fish has joined #openstack-horizon | 16:41 | |
| *** stevemar_ has quit IRC | 16:41 | |
| *** KunalGandhi has joined #openstack-horizon | 16:42 | |
| *** amotoki has quit IRC | 16:42 | |
| *** mpavlase has quit IRC | 16:43 | |
| *** gyee has joined #openstack-horizon | 16:45 | |
| *** doug-fish has quit IRC | 16:45 | |
| *** logan2 has joined #openstack-horizon | 16:47 | |
| *** jobewan has joined #openstack-horizon | 16:48 | |
| *** petertr7 is now known as petertr7_away | 16:52 | |
| *** lapalm has quit IRC | 16:55 | |
| *** lapalm has joined #openstack-horizon | 16:55 | |
| *** doug-fish has joined #openstack-horizon | 16:56 | |
| *** rhagarty has joined #openstack-horizon | 16:57 | |
| *** zigo_ has quit IRC | 16:59 | |
| *** lapalm has quit IRC | 17:00 | |
| *** zigo has joined #openstack-horizon | 17:00 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Don't hide Karma coverage reports https://review.openstack.org/238043 | 17:04 |
| *** vgridnev has quit IRC | 17:11 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for system information https://review.openstack.org/205196 | 17:11 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular system information panel https://review.openstack.org/204731 | 17:11 |
| *** ColemanB has joined #openstack-horizon | 17:15 | |
| *** sqchen has quit IRC | 17:15 | |
| *** yamamoto_ has quit IRC | 17:17 | |
| *** cbii has joined #openstack-horizon | 17:19 | |
| *** ColemanB has quit IRC | 17:19 | |
| *** pauloewerton has joined #openstack-horizon | 17:25 | |
| *** yamamoto has joined #openstack-horizon | 17:25 | |
| *** kfox1111 has quit IRC | 17:25 | |
| *** kfox1111 has joined #openstack-horizon | 17:26 | |
| *** kzaitsev_mb has quit IRC | 17:28 | |
| *** Daisy has joined #openstack-horizon | 17:30 | |
| *** stevemar_ has joined #openstack-horizon | 17:32 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Dropdown now inherits from Bootstrap Theme https://review.openstack.org/232735 | 17:34 |
| *** sqchen has joined #openstack-horizon | 17:34 | |
| *** cbii has quit IRC | 17:35 | |
| *** ducttape_ has quit IRC | 17:35 | |
| *** lapalm has joined #openstack-horizon | 17:40 | |
| *** lapalm has quit IRC | 17:40 | |
| *** exploreshaifali has joined #openstack-horizon | 17:40 | |
| *** lapalm has joined #openstack-horizon | 17:40 | |
| *** hurgleburgler1 has quit IRC | 17:41 | |
| openstackgerrit | Tony Dunbar proposed openstack/horizon: Made instance state values in the CSV summary translatable https://review.openstack.org/238186 | 17:41 |
| *** rhagarty_ has joined #openstack-horizon | 17:43 | |
| *** amotoki has joined #openstack-horizon | 17:43 | |
| *** rhagarty has quit IRC | 17:46 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Avoid multiple calls to Glance happening in api.nova.server_list() https://review.openstack.org/238189 | 17:46 |
| *** amotoki has quit IRC | 17:48 | |
| *** brad[] has quit IRC | 17:48 | |
| *** brad[] has joined #openstack-horizon | 17:48 | |
| *** e0ne has quit IRC | 17:49 | |
| *** vgridnev has joined #openstack-horizon | 17:50 | |
| *** exploreshaifali has quit IRC | 17:53 | |
| *** yamamoto has quit IRC | 17:55 | |
| *** ybathia has joined #openstack-horizon | 17:55 | |
| *** harlowja has quit IRC | 17:57 | |
| *** jpomeroy has quit IRC | 17:57 | |
| *** saksham has joined #openstack-horizon | 17:57 | |
| *** rdopiera has quit IRC | 17:58 | |
| *** stevemar_ has quit IRC | 17:58 | |
| *** jpomeroy has joined #openstack-horizon | 18:02 | |
| *** harlowja has joined #openstack-horizon | 18:02 | |
| *** Daisy has quit IRC | 18:02 | |
| *** lapalm_ has joined #openstack-horizon | 18:04 | |
| *** lsmola_ has quit IRC | 18:07 | |
| *** lapalm__ has joined #openstack-horizon | 18:07 | |
| *** neelashah1 has joined #openstack-horizon | 18:07 | |
| *** lapalm has quit IRC | 18:08 | |
| *** lapalm_ has quit IRC | 18:08 | |
| *** vgridnev has quit IRC | 18:10 | |
| *** tqtran has joined #openstack-horizon | 18:10 | |
| *** ducttape_ has joined #openstack-horizon | 18:11 | |
| *** aix has quit IRC | 18:12 | |
| *** vgridnev has joined #openstack-horizon | 18:12 | |
| *** vgridnev has quit IRC | 18:14 | |
| *** petertr7_away is now known as petertr7 | 18:16 | |
| *** Piet has quit IRC | 18:17 | |
| *** julim_ has joined #openstack-horizon | 18:19 | |
| *** julim has quit IRC | 18:19 | |
| *** jwy has joined #openstack-horizon | 18:21 | |
| *** vgridnev has joined #openstack-horizon | 18:25 | |
| *** mounica has quit IRC | 18:26 | |
| *** lhcheng has quit IRC | 18:28 | |
| *** lhcheng has joined #openstack-horizon | 18:29 | |
| *** lhcheng has quit IRC | 18:30 | |
| *** exploreshaifali has joined #openstack-horizon | 18:31 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Reduce Overview panels default date range to 1 day https://review.openstack.org/238204 | 18:31 |
| *** zul has quit IRC | 18:32 | |
| *** Daisy has joined #openstack-horizon | 18:33 | |
| *** zul has joined #openstack-horizon | 18:33 | |
| openstackgerrit | Lucas Palm proposed openstack/horizon: Truncate instance creation pop-up message https://review.openstack.org/231737 | 18:35 |
| openstackgerrit | Akanksha Srivastava proposed openstack/horizon: Fixes the readability of UUID for Network Instance https://review.openstack.org/228252 | 18:44 |
| *** amotoki has joined #openstack-horizon | 18:44 | |
| *** amotoki has quit IRC | 18:49 | |
| *** jbell8 has joined #openstack-horizon | 18:49 | |
| *** yamamoto has joined #openstack-horizon | 18:55 | |
| *** petertr7 is now known as petertr7_away | 18:56 | |
| *** Daisy has quit IRC | 18:59 | |
| *** yamamoto has quit IRC | 19:00 | |
| *** stevemar_ has joined #openstack-horizon | 19:07 | |
| *** lhcheng has joined #openstack-horizon | 19:07 | |
| *** lhcheng_ has joined #openstack-horizon | 19:08 | |
| *** sqchen has quit IRC | 19:09 | |
| *** SimonChung has quit IRC | 19:10 | |
| *** SimonChung1 has joined #openstack-horizon | 19:10 | |
| *** lhcheng has quit IRC | 19:12 | |
| *** lapalm__ has quit IRC | 19:12 | |
| *** lapalm has joined #openstack-horizon | 19:13 | |
| *** linkedinyou has joined #openstack-horizon | 19:15 | |
| *** stevemar_ has quit IRC | 19:15 | |
| *** rajatvig has quit IRC | 19:15 | |
| *** stevemar_ has joined #openstack-horizon | 19:16 | |
| *** rajatvig has joined #openstack-horizon | 19:16 | |
| *** sqchen has joined #openstack-horizon | 19:16 | |
| *** lapalm has quit IRC | 19:17 | |
| *** stevemar_ has quit IRC | 19:20 | |
| openstackgerrit | Tony Dunbar proposed openstack/horizon: Made instance state values in the CSV summary translatable https://review.openstack.org/238186 | 19:21 |
| *** lapalm has joined #openstack-horizon | 19:22 | |
| *** cbader has quit IRC | 19:23 | |
| lapalm | robcresswell: Are you around? ;P | 19:24 |
| *** zacdev has joined #openstack-horizon | 19:24 | |
| *** vgridnev has quit IRC | 19:25 | |
| *** fifieldt_ has joined #openstack-horizon | 19:26 | |
| *** Daisy has joined #openstack-horizon | 19:27 | |
| *** vgridnev has joined #openstack-horizon | 19:28 | |
| *** fifieldt has quit IRC | 19:29 | |
| *** vgridnev has quit IRC | 19:29 | |
| *** vgridnev has joined #openstack-horizon | 19:30 | |
| robcresswell | lapalm: How can I help? | 19:30 |
| *** mounica has joined #openstack-horizon | 19:31 | |
| openstackgerrit | Akanksha Srivastava proposed openstack/horizon: Fixes Broken Error Message on Subnet Creation https://review.openstack.org/238219 | 19:31 |
| lapalm | robcresswell: Oh hey. Just pestering you about my review that is marked WIP still awaiting your response. ;) | 19:31 |
| robcresswell | ?? I replied ot that in IRC last time you asked | 19:32 |
| lapalm | hmmmmm | 19:32 |
| lapalm | Really? | 19:32 |
| *** jprovazn has quit IRC | 19:32 | |
| lapalm | IDK about that lol | 19:32 |
| lapalm | I remember asking you and I think you said that you would take a look. | 19:33 |
| robcresswell | No I definitely replied in the channel | 19:34 |
| robcresswell | Link? I'll look again | 19:34 |
| lapalm | hah alright | 19:35 |
| tqtran | Hi robcresswell , can i pester you to look at https://review.openstack.org/#/c/235497/ and https://review.openstack.org/#/c/222297/ again? | 19:35 |
| lapalm | https://review.openstack.org/#/c/226579/ | 19:36 |
| lapalm | tqtran: wait your turn ;P | 19:36 |
| tqtran | :D drive-by request haha | 19:36 |
| robcresswell | Goodbye evening :( | 19:40 |
| *** vgridnev has quit IRC | 19:40 | |
| *** hurgleburgler has joined #openstack-horizon | 19:42 | |
| lapalm | robcresswell: Come back tomorrow with a fresh mind and look at them. | 19:43 |
| lapalm | Take the night off | 19:43 |
| *** Piet has joined #openstack-horizon | 19:43 | |
| *** pauloewerton has quit IRC | 19:45 | |
| tqtran | lapalm: you're too nice! sleep is for the weak! | 19:45 |
| *** petertr7_away is now known as petertr7 | 19:45 | |
| robcresswell | nah, will look this evening. | 19:45 |
| tqtran | haha jk :P | 19:45 |
| *** SimonChung1 has quit IRC | 19:46 | |
| *** emilyw has joined #openstack-horizon | 19:46 | |
| robcresswell | holy shit | 19:47 |
| robcresswell | will people please stop grammar sniping | 19:47 |
| robcresswell | 3 -1s on a commit message | 19:47 |
| matt-borland | geez | 19:47 |
| robcresswell | Also why does the inline editor wrap :( | 19:48 |
| robcresswell | doesnt* | 19:48 |
| matt-borland | that is kinda sad! | 19:48 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Don't hide Karma coverage reports https://review.openstack.org/238043 | 19:48 |
| *** rhagarty_ has quit IRC | 19:48 | |
| *** harlowja has quit IRC | 19:50 | |
| *** pumaranikar has quit IRC | 19:50 | |
| *** cbader has joined #openstack-horizon | 19:50 | |
| *** pauloewerton has joined #openstack-horizon | 19:53 | |
| bpokorny | robcresswell: In defense of my -1 on that one, it was about the docs as opposed to the line wrapping. | 19:54 |
| *** vgridnev has joined #openstack-horizon | 19:54 | |
| bpokorny | Sorry if that seemed too strong, though. | 19:54 |
| *** Daisy has quit IRC | 19:54 | |
| robcresswell | bpokorny: No, yours was reasonable, and line comment was reasonable too. | 19:55 |
| robcresswell | bpokorny: It's more when people start giving extra -1s for "agree needs moar grammar" | 19:55 |
| robcresswell | I'm ranting. | 19:55 |
| robcresswell | Long day :) | 19:55 |
| hurgleburgler | robcresswell I agree with you | 19:56 |
| *** vgridnev has quit IRC | 19:56 | |
| matt-borland | robcresswell, sorry if I got things off to a bad start. We're all in this together. | 19:56 |
| robcresswell | matt-borland: Not at all, discussion earlier was good. | 19:56 |
| hurgleburgler | Documentation grammar is important, but nit picking in commit message is well … nit picking. | 19:57 |
| r1chardj0n3s | morning | 19:57 |
| matt-borland | I should align my schedule to yours now r1chardj0n3s | 19:57 |
| hurgleburgler | r1chardj0n3s Morning! | 19:57 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Don't hide Karma coverage reports https://review.openstack.org/238043 | 19:58 |
| r1chardj0n3s | hurgleburgler: if people dont get there grammer right in commit messages it bugs me | 19:58 |
| r1chardj0n3s | ohai matt-borland | 19:58 |
| robcresswell | r1chardj0n3s: lol | 19:58 |
| matt-borland | :) | 19:58 |
| r1chardj0n3s | robcresswell: alot | 19:59 |
| r1chardj0n3s | :) | 19:59 |
| robcresswell | Meeting time | 20:00 |
| robcresswell | #openstack-meeting-3 folks | 20:00 |
| *** vgridnev has joined #openstack-horizon | 20:01 | |
| *** vgridnev has quit IRC | 20:03 | |
| *** vgridnev has joined #openstack-horizon | 20:06 | |
| *** openstackstatus has joined #openstack-horizon | 20:07 | |
| *** ChanServ sets mode: +v openstackstatus | 20:07 | |
| *** pauloewerton has quit IRC | 20:08 | |
| *** pauloewerton has joined #openstack-horizon | 20:09 | |
| *** mpavlase has joined #openstack-horizon | 20:11 | |
| *** dansiwiec has joined #openstack-horizon | 20:19 | |
| *** woodm19791 has joined #openstack-horizon | 20:21 | |
| *** Daisy has joined #openstack-horizon | 20:24 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular flavors panel https://review.openstack.org/206203 | 20:24 |
| *** vgridnev has quit IRC | 20:31 | |
| *** vgridnev has joined #openstack-horizon | 20:32 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:33 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Magic Search Filtering to NG Flavors https://review.openstack.org/233755 | 20:34 |
| *** errolpais has joined #openstack-horizon | 20:35 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add a Delete Modal Service for deleting entities https://review.openstack.org/234408 | 20:37 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API Services for Flavors Panel https://review.openstack.org/214896 | 20:37 |
| *** dansiwiec has quit IRC | 20:38 | |
| *** harlowja has joined #openstack-horizon | 20:39 | |
| *** harlowja_ has joined #openstack-horizon | 20:40 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Webroot Theme is no longer needed https://review.openstack.org/213411 | 20:40 |
| *** SimonChung has joined #openstack-horizon | 20:40 | |
| *** alejandrito has quit IRC | 20:42 | |
| *** harlowja has quit IRC | 20:44 | |
| *** amotoki has joined #openstack-horizon | 20:45 | |
| *** jobewan has quit IRC | 20:45 | |
| *** rajatvig has quit IRC | 20:47 | |
| *** doug-fis_ has joined #openstack-horizon | 20:50 | |
| *** doug-fi__ has joined #openstack-horizon | 20:50 | |
| robcresswell | hurgleburgler: ^^ isn't that still needed in devstack? | 20:51 |
| *** doug-fi__ has quit IRC | 20:51 | |
| robcresswell | looking at ze comments | 20:51 |
| *** doug-fi__ has joined #openstack-horizon | 20:51 | |
| hurgleburgler | Well, devstack is configured to need it | 20:51 |
| hurgleburgler | but it doesn't actually need it anymore | 20:51 |
| hurgleburgler | we just need to update devstack though | 20:51 |
| hurgleburgler | right david-lyle ? | 20:51 |
| *** Daisy has quit IRC | 20:51 | |
| david-lyle | hurgleburgler: yes, hence the -2 :) | 20:52 |
| robcresswell | Sure, I just wondered why the rebasing if its waiting on devstack changes | 20:52 |
| hurgleburgler | I was on the wrong patch page :P | 20:52 |
| hurgleburgler | sorry | 20:52 |
| hurgleburgler | click happy me | 20:52 |
| *** doug-fish has quit IRC | 20:53 | |
| hurgleburgler | tried to rebase another patch, which actually needs a manual rebase now | 20:53 |
| *** david____ has joined #openstack-horizon | 20:54 | |
| *** david____ is now known as david_cu | 20:54 | |
| *** doug-fis_ has quit IRC | 20:54 | |
| *** lapalm has quit IRC | 20:54 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add firewall detail actions and breadcrumb nav https://review.openstack.org/234315 | 20:58 |
| robcresswell | tqtran: Could you take a look at https://review.openstack.org/#/c/212152 ? | 20:59 |
| *** Drago1 has joined #openstack-horizon | 20:59 | |
| *** Drago1 has quit IRC | 20:59 | |
| tqtran | sure thing boss | 21:00 |
| *** Drago1 has joined #openstack-horizon | 21:00 | |
| *** jobewan has joined #openstack-horizon | 21:00 | |
| *** SimonChung1 has joined #openstack-horizon | 21:01 | |
| *** SimonChung has quit IRC | 21:01 | |
| robcresswell | tqtran: Thanks! | 21:01 |
| *** SimonChung has joined #openstack-horizon | 21:02 | |
| *** SimonChung1 has quit IRC | 21:02 | |
| *** SimonChung1 has joined #openstack-horizon | 21:02 | |
| *** SimonChung has quit IRC | 21:02 | |
| *** Drago has quit IRC | 21:03 | |
| matt-borland | later folks! | 21:05 |
| *** matt-borland has quit IRC | 21:05 | |
| *** pauloewerton has quit IRC | 21:06 | |
| *** lblanchard has quit IRC | 21:07 | |
| *** woodm19791 has quit IRC | 21:10 | |
| robcresswell | More of you need this in your lives: http://wiki.znc.in/ZNC | 21:10 |
| *** jongchoi_ has joined #openstack-horizon | 21:10 | |
| *** stevemar_ has joined #openstack-horizon | 21:11 | |
| *** rajatvig has joined #openstack-horizon | 21:17 | |
| *** darrenc is now known as darrenc_afk | 21:17 | |
| *** Daisy has joined #openstack-horizon | 21:21 | |
| *** petertr7 is now known as petertr7_away | 21:23 | |
| *** neelashah1 has quit IRC | 21:25 | |
| *** rhagarty has joined #openstack-horizon | 21:28 | |
| *** SimonChung has joined #openstack-horizon | 21:28 | |
| *** SimonChung1 has quit IRC | 21:28 | |
| *** mpavlase has quit IRC | 21:28 | |
| *** amotoki has quit IRC | 21:31 | |
| *** zz_john5223 has quit IRC | 21:31 | |
| robcresswell | tqtran: Looking at the Create User action | 21:31 |
| tqtran | coolios | 21:31 |
| robcresswell | tqtran: settings.getSettings on the Default Role always returns the default value, not the setting | 21:32 |
| *** doug-fi__ has quit IRC | 21:32 | |
| robcresswell | tqtran: If I log it, it just gives me the string '_member_' in your patch. I can make that anything though, and it always seems to return that instead of the setting value. | 21:32 |
| *** doug-fish has joined #openstack-horizon | 21:33 | |
| *** zz_john5223 has joined #openstack-horizon | 21:33 | |
| robcresswell | tqtran: I'll look some more probably during summit week :) | 21:33 |
| tqtran | hm... really? can you put a breakpoint on the server side and see if its getting hit at all? | 21:34 |
| *** doug-fis_ has joined #openstack-horizon | 21:34 | |
| *** doug-fish has quit IRC | 21:37 | |
| *** rajatvig has quit IRC | 21:37 | |
| *** emily_w has joined #openstack-horizon | 21:37 | |
| *** doug-fish has joined #openstack-horizon | 21:38 | |
| openstackgerrit | Tony Dunbar proposed openstack/horizon: Add STATUS_DISPLAY_CHOICE which matches Nova vm state https://review.openstack.org/238258 | 21:38 |
| *** mounica has quit IRC | 21:38 | |
| *** emilyw has quit IRC | 21:38 | |
| *** doug-fis_ has quit IRC | 21:39 | |
| *** darrenc_afk is now known as darrenc | 21:39 | |
| *** emily-w has joined #openstack-horizon | 21:41 | |
| *** rajatvig has joined #openstack-horizon | 21:41 | |
| *** jobewan has quit IRC | 21:42 | |
| *** doug-fish has quit IRC | 21:42 | |
| *** rajatvig has quit IRC | 21:43 | |
| robcresswell | tqtran: Er, break where? | 21:43 |
| *** emily_w has quit IRC | 21:43 | |
| *** rajatvig has joined #openstack-horizon | 21:43 | |
| robcresswell | tqtran: Actually, scrap that, its nearly 11pm, I'm having a cup of tea and sleep :) | 21:44 |
| robcresswell | tqtran: See you in Tokyo! | 21:44 |
| *** rhagarty_ has joined #openstack-horizon | 21:45 | |
| *** jpomeroy_ has joined #openstack-horizon | 21:45 | |
| tqtran | see you in Jp! | 21:46 |
| *** robcresswell has left #openstack-horizon | 21:46 | |
| *** rhagarty has quit IRC | 21:46 | |
| *** jbell8 has quit IRC | 21:47 | |
| *** robcresswell has joined #openstack-horizon | 21:47 | |
| *** jpomeroy has quit IRC | 21:48 | |
| *** Daisy has quit IRC | 21:49 | |
| *** ducttape_ has quit IRC | 21:49 | |
| *** doug-fish has joined #openstack-horizon | 21:50 | |
| *** doug-fish has quit IRC | 21:54 | |
| *** tqtran has quit IRC | 21:54 | |
| *** tqtran has joined #openstack-horizon | 21:55 | |
| *** jobewan has joined #openstack-horizon | 22:01 | |
| *** jongchoi_ has quit IRC | 22:02 | |
| *** jongchoi_ has joined #openstack-horizon | 22:05 | |
| *** david_cu has quit IRC | 22:06 | |
| *** cody-somerville has quit IRC | 22:06 | |
| *** jamielennox|away is now known as jamielennox | 22:07 | |
| *** zacdev has quit IRC | 22:07 | |
| *** jongchoi_ has quit IRC | 22:10 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Basic tables now inherit from Bootstrap Theme https://review.openstack.org/218608 | 22:11 |
| *** sqchen has quit IRC | 22:11 | |
| *** sqchen has joined #openstack-horizon | 22:12 | |
| *** lhcheng_ has quit IRC | 22:17 | |
| *** Daisy has joined #openstack-horizon | 22:18 | |
| *** vgridnev has quit IRC | 22:19 | |
| *** jbell8 has joined #openstack-horizon | 22:23 | |
| *** jpomeroy_ has quit IRC | 22:23 | |
| *** jbell8 has quit IRC | 22:27 | |
| *** emily_w has joined #openstack-horizon | 22:27 | |
| *** bpokorny_ has joined #openstack-horizon | 22:29 | |
| *** jbell8 has joined #openstack-horizon | 22:30 | |
| *** emilyw has joined #openstack-horizon | 22:30 | |
| *** bpokorny_ has quit IRC | 22:30 | |
| *** bpokorny_ has joined #openstack-horizon | 22:30 | |
| *** emily-w has quit IRC | 22:30 | |
| *** emily_w has quit IRC | 22:32 | |
| *** lhcheng has joined #openstack-horizon | 22:33 | |
| *** bpokorny has quit IRC | 22:33 | |
| *** Daisy has quit IRC | 22:39 | |
| *** jbell8 has quit IRC | 22:40 | |
| *** jbell8 has joined #openstack-horizon | 22:41 | |
| *** jobewan has quit IRC | 22:46 | |
| *** emilyw has quit IRC | 22:52 | |
| *** emilyw has joined #openstack-horizon | 22:52 | |
| *** jbell8 has quit IRC | 22:53 | |
| *** jbell8 has joined #openstack-horizon | 22:54 | |
| *** Drago1 has quit IRC | 23:03 | |
| *** david_cu has joined #openstack-horizon | 23:05 | |
| *** Daisy has joined #openstack-horizon | 23:08 | |
| *** ZZelle has quit IRC | 23:08 | |
| *** emilyw has quit IRC | 23:17 | |
| *** yamamoto has joined #openstack-horizon | 23:18 | |
| *** ducttape_ has joined #openstack-horizon | 23:19 | |
| *** ducttape_ has quit IRC | 23:20 | |
| *** cbii has joined #openstack-horizon | 23:23 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Login now inherits from Bootstrap Theme https://review.openstack.org/219881 | 23:23 |
| *** cbii has left #openstack-horizon | 23:23 | |
| *** cbii has joined #openstack-horizon | 23:24 | |
| *** yamamoto has quit IRC | 23:26 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API for getting and updating quotas https://review.openstack.org/207126 | 23:27 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel subflows for admin https://review.openstack.org/234986 | 23:27 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel for admin https://review.openstack.org/205296 | 23:27 |
| *** kzaitsev_mb has quit IRC | 23:27 | |
| *** amotoki has joined #openstack-horizon | 23:28 | |
| *** erhudy has quit IRC | 23:29 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Basic tables now inherit from Bootstrap Theme https://review.openstack.org/218608 | 23:32 |
| *** amotoki has quit IRC | 23:33 | |
| *** harlowja_ has quit IRC | 23:33 | |
| *** Daisy has quit IRC | 23:35 | |
| *** harlowja has joined #openstack-horizon | 23:37 | |
| *** exploreshaifali has quit IRC | 23:38 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Dropdowns should have a consistent design https://review.openstack.org/232734 | 23:38 |
| hurgleburgler | Any one want a quick review, this one is ready: https://review.openstack.org/#/c/232734 | 23:39 |
| *** cbii has quit IRC | 23:40 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Magic Search is now themable https://review.openstack.org/233305 | 23:40 |
| tqtran | david-lyle: if you're still around, can i bug you to +A this through? https://review.openstack.org/#/c/214815/ | 23:42 |
| tqtran | its something to be desired for many patches | 23:43 |
| *** Daisy has joined #openstack-horizon | 23:43 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Magic Search is now themable https://review.openstack.org/233305 | 23:44 |
| *** harlowja_ has joined #openstack-horizon | 23:45 | |
| *** emilyw has joined #openstack-horizon | 23:46 | |
| *** Daisy has quit IRC | 23:47 | |
| *** Daisy has joined #openstack-horizon | 23:48 | |
| *** harlowja has quit IRC | 23:49 | |
| *** SimonChung1 has joined #openstack-horizon | 23:51 | |
| *** SimonChung has quit IRC | 23:51 | |
| *** SimonChung has joined #openstack-horizon | 23:52 | |
| *** SimonChung1 has quit IRC | 23:52 | |
| *** Daisy has quit IRC | 23:52 | |
| david-lyle | tqtran: I thought I had, oops | 23:54 |
| *** ducttape_ has joined #openstack-horizon | 23:54 | |
| *** SimonChung1 has joined #openstack-horizon | 23:55 | |
| *** SimonChung has quit IRC | 23:55 | |
| *** yamamoto has joined #openstack-horizon | 23:55 | |
| *** aortega has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!