| *** ZZelle_ has quit IRC | 00:09 | |
| *** yamamoto has joined #openstack-horizon | 00:12 | |
| *** yamamoto has quit IRC | 00:17 | |
| *** jbell8 has joined #openstack-horizon | 00:19 | |
| *** geoffarnold is now known as geoffarnoldX | 00:27 | |
| *** yamamoto has joined #openstack-horizon | 00:28 | |
| *** ducttape_ has joined #openstack-horizon | 00:30 | |
| *** jtriley has joined #openstack-horizon | 00:30 | |
| *** yamamoto has quit IRC | 00:32 | |
| *** jtriley has quit IRC | 00:35 | |
| *** lblanchard has joined #openstack-horizon | 00:36 | |
| *** yamamoto has joined #openstack-horizon | 00:43 | |
| *** yamamoto has quit IRC | 00:47 | |
| *** ducttape_ has quit IRC | 00:51 | |
| *** ducttape_ has joined #openstack-horizon | 00:51 | |
| *** ducttape_ has quit IRC | 00:55 | |
| *** jbell8 has quit IRC | 01:02 | |
| *** linkedinyou has joined #openstack-horizon | 01:03 | |
| *** linkedinyou has quit IRC | 01:03 | |
| *** linkedinyou has joined #openstack-horizon | 01:03 | |
| *** linkedinyou has quit IRC | 01:04 | |
| *** linkedinyou has joined #openstack-horizon | 01:05 | |
| *** jpomeroy has quit IRC | 01:08 | |
| *** jpomeroy has joined #openstack-horizon | 01:15 | |
| *** masco has joined #openstack-horizon | 01:17 | |
| *** masco has quit IRC | 01:25 | |
| *** TravT_ has joined #openstack-horizon | 01:29 | |
| *** TravT has quit IRC | 01:31 | |
| *** zhenguo has joined #openstack-horizon | 01:35 | |
| *** fedexo has joined #openstack-horizon | 01:45 | |
| *** lyanchih has joined #openstack-horizon | 01:46 | |
| *** david-ly_ has joined #openstack-horizon | 01:51 | |
| *** david-lyle has quit IRC | 01:54 | |
| *** yamamoto has joined #openstack-horizon | 01:57 | |
| *** jtriley has joined #openstack-horizon | 02:01 | |
| *** yamamoto has quit IRC | 02:02 | |
| openstackgerrit | Allen proposed openstack/horizon: Fix a bug for "Set Gateway" form modal https://review.openstack.org/220770 | 02:03 |
|---|---|---|
| *** TravT_ has quit IRC | 02:03 | |
| *** yamamoto has joined #openstack-horizon | 02:04 | |
| *** TravT has joined #openstack-horizon | 02:04 | |
| *** jtriley has quit IRC | 02:06 | |
| *** yamamoto has quit IRC | 02:10 | |
| *** jbell8 has joined #openstack-horizon | 02:16 | |
| *** tjones has joined #openstack-horizon | 02:25 | |
| *** tjones has quit IRC | 02:47 | |
| *** amotoki has joined #openstack-horizon | 02:48 | |
| *** zhurong has joined #openstack-horizon | 02:56 | |
| *** yamamoto has joined #openstack-horizon | 02:56 | |
| *** tbh has joined #openstack-horizon | 03:00 | |
| tbh | Hi, may I know why we need to set the management url for novaclient like this https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L456 | 03:02 |
| *** zhurong has quit IRC | 03:06 | |
| *** yingjun has joined #openstack-horizon | 03:11 | |
| *** zhurong has joined #openstack-horizon | 03:12 | |
| *** linkedinyou has quit IRC | 03:16 | |
| *** lblanchard has quit IRC | 03:19 | |
| *** yingjun has quit IRC | 03:22 | |
| *** yingjun has joined #openstack-horizon | 03:22 | |
| *** yingjun has quit IRC | 03:27 | |
| *** lhcheng has joined #openstack-horizon | 03:27 | |
| *** linkedinyou has joined #openstack-horizon | 03:37 | |
| *** Samos123 has quit IRC | 03:40 | |
| *** deray has joined #openstack-horizon | 03:44 | |
| *** Samos123 has joined #openstack-horizon | 03:44 | |
| *** yingjun has joined #openstack-horizon | 03:46 | |
| *** julim has quit IRC | 03:47 | |
| *** jbell8 has quit IRC | 03:56 | |
| *** jamielennox is now known as jamielennox|away | 03:56 | |
| *** yingjun has quit IRC | 03:56 | |
| *** yingjun has joined #openstack-horizon | 03:57 | |
| *** lyanchih has quit IRC | 04:04 | |
| *** yingjun has quit IRC | 04:04 | |
| *** tbh has quit IRC | 04:05 | |
| *** tbh has joined #openstack-horizon | 04:13 | |
| *** jtriley has joined #openstack-horizon | 04:13 | |
| *** jtriley has quit IRC | 04:19 | |
| *** btully has joined #openstack-horizon | 04:21 | |
| *** zhurong has quit IRC | 04:25 | |
| openstackgerrit | Amogh proposed openstack/horizon: Integration tests - Instances tests https://review.openstack.org/117091 | 04:28 |
| *** deray has quit IRC | 04:43 | |
| *** deray has joined #openstack-horizon | 04:53 | |
| *** deray has quit IRC | 04:53 | |
| *** lyanchih has joined #openstack-horizon | 04:58 | |
| *** tbh has quit IRC | 05:01 | |
| *** jtriley has joined #openstack-horizon | 05:14 | |
| *** jtriley has quit IRC | 05:19 | |
| *** KingKhan has joined #openstack-horizon | 05:20 | |
| *** mflobo1 has joined #openstack-horizon | 05:22 | |
| *** josecastroleon1 has joined #openstack-horizon | 05:22 | |
| *** mflobo has quit IRC | 05:22 | |
| *** josecastroleon has quit IRC | 05:23 | |
| *** KingKhan has quit IRC | 05:24 | |
| *** zhurong has joined #openstack-horizon | 05:30 | |
| *** lyanchih has quit IRC | 05:31 | |
| *** zhurong has quit IRC | 05:31 | |
| *** aortega has quit IRC | 05:35 | |
| *** KingKhan has joined #openstack-horizon | 05:38 | |
| *** kjelly has quit IRC | 05:39 | |
| *** vgridnev has joined #openstack-horizon | 05:45 | |
| *** yingjun has joined #openstack-horizon | 05:46 | |
| *** masco has joined #openstack-horizon | 05:52 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add docs https://review.openstack.org/221156 | 05:54 |
| *** yingjun has quit IRC | 05:55 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add information for debugging Selenium tests https://review.openstack.org/221156 | 05:55 |
| *** tnovacik has joined #openstack-horizon | 06:00 | |
| *** mrunge has joined #openstack-horizon | 06:01 | |
| *** alexpilotti_ has joined #openstack-horizon | 06:01 | |
| *** lyanchih has joined #openstack-horizon | 06:01 | |
| *** fedexo has quit IRC | 06:03 | |
| *** mflobo1 has left #openstack-horizon | 06:04 | |
| *** alexvictorchan has joined #openstack-horizon | 06:09 | |
| *** alexvictorchan has quit IRC | 06:09 | |
| *** radez has quit IRC | 06:10 | |
| *** radez has joined #openstack-horizon | 06:10 | |
| *** mohankumar has joined #openstack-horizon | 06:10 | |
| *** akrivoka has joined #openstack-horizon | 06:13 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/220404 | 06:13 |
| *** rdopiera has joined #openstack-horizon | 06:27 | |
| *** mflobo has joined #openstack-horizon | 06:27 | |
| *** mflobo has left #openstack-horizon | 06:27 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add information for debugging Selenium tests https://review.openstack.org/221156 | 06:28 |
| *** josecastroleon has joined #openstack-horizon | 06:29 | |
| *** josecastroleon1 has quit IRC | 06:30 | |
| *** btully has quit IRC | 06:42 | |
| *** lsmola has joined #openstack-horizon | 06:47 | |
| *** peristeri has joined #openstack-horizon | 07:00 | |
| *** zz_ttrifonov is now known as ttrifonov | 07:03 | |
| *** fifieldt has joined #openstack-horizon | 07:13 | |
| *** jbell8 has joined #openstack-horizon | 07:15 | |
| *** jtomasek has joined #openstack-horizon | 07:29 | |
| *** sayan has joined #openstack-horizon | 07:30 | |
| *** jtriley has joined #openstack-horizon | 07:32 | |
| *** mpavlase has joined #openstack-horizon | 07:35 | |
| *** jtomasek has quit IRC | 07:37 | |
| *** jtriley has quit IRC | 07:42 | |
| *** btully has joined #openstack-horizon | 07:43 | |
| *** aortega has joined #openstack-horizon | 07:47 | |
| *** btully has quit IRC | 07:48 | |
| *** jtomasek has joined #openstack-horizon | 07:48 | |
| *** lyanchih has quit IRC | 07:48 | |
| *** bluex-pl has joined #openstack-horizon | 07:52 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 07:53 | |
| *** chlong has quit IRC | 07:56 | |
| *** ygbo has joined #openstack-horizon | 08:00 | |
| *** lyanchih has joined #openstack-horizon | 08:02 | |
| *** jcoufal has joined #openstack-horizon | 08:09 | |
| *** vgridnev has quit IRC | 08:12 | |
| *** romainh has joined #openstack-horizon | 08:14 | |
| *** Ala has joined #openstack-horizon | 08:16 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Wording for Security Groups is incorrect https://review.openstack.org/221193 | 08:25 |
| *** exploreshaifali has joined #openstack-horizon | 08:31 | |
| *** deray has joined #openstack-horizon | 08:33 | |
| *** JeanBriceCombebi has quit IRC | 08:36 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:36 | |
| *** yingjun has joined #openstack-horizon | 08:52 | |
| *** aix has quit IRC | 08:53 | |
| *** yingjun has quit IRC | 08:55 | |
| *** JeanBriceCombebi has quit IRC | 08:56 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:56 | |
| *** vgridnev has joined #openstack-horizon | 08:58 | |
| haypo | morning | 09:05 |
| *** tosky has joined #openstack-horizon | 09:06 | |
| haypo | half of my pending python3 patches already have a +2 vote, other got +1 votes, coolness :) https://review.openstack.org/#/q/status:open+project:openstack/horizon+branch:master+topic:bp/porting-python3,n,z | 09:08 |
| *** wuhg has quit IRC | 09:11 | |
| *** kiran-r has joined #openstack-horizon | 09:11 | |
| *** wznoinsk has joined #openstack-horizon | 09:15 | |
| *** Daisy has joined #openstack-horizon | 09:16 | |
| *** e0ne has joined #openstack-horizon | 09:16 | |
| *** yingjun has joined #openstack-horizon | 09:16 | |
| *** aix has joined #openstack-horizon | 09:18 | |
| *** mwhagedorn has joined #openstack-horizon | 09:19 | |
| *** ^Gal^ has joined #openstack-horizon | 09:21 | |
| akrivoka | haypo: thanks for this effort, it is much appreciated | 09:22 |
| *** JeanBriceCombebi has quit IRC | 09:23 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:25 | |
| *** lhcheng has quit IRC | 09:32 | |
| *** yingjun has quit IRC | 09:33 | |
| *** Daisy has quit IRC | 09:37 | |
| *** Daisy has joined #openstack-horizon | 09:37 | |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/221111 | 09:37 |
| *** NightKhaos has quit IRC | 09:39 | |
| *** Daisy_ has joined #openstack-horizon | 09:41 | |
| *** e0ne has quit IRC | 09:41 | |
| *** Daisy has quit IRC | 09:42 | |
| *** NightKhaos has joined #openstack-horizon | 09:42 | |
| *** Daisy_ has quit IRC | 09:46 | |
| *** bluex-pl has quit IRC | 09:48 | |
| *** bluex-pl has joined #openstack-horizon | 09:48 | |
| *** bluex-pl has quit IRC | 09:49 | |
| *** bluex-pl has joined #openstack-horizon | 09:49 | |
| *** yamamoto has quit IRC | 09:53 | |
| robcresswell | akrivoka, haypo: Yeah, this python 3 work is awesome | 09:57 |
| robcresswell | I'm not too sure about merging it in FF though | 09:57 |
| robcresswell | stability risks? | 09:57 |
| haypo | robcresswell: yeah, my patches will kill kittens | 09:57 |
| *** e0ne has joined #openstack-horizon | 09:57 | |
| robcresswell | :p | 09:58 |
| haypo | no omelette without breaking eggs | 09:58 |
| robcresswell | True | 09:58 |
| robcresswell | and were we mid-cycle I wouldn't mind | 09:59 |
| haypo | robcresswell: more seriously, i trust gates to validate my changes | 09:59 |
| robcresswell | integration testing on Horizon is very very light | 09:59 |
| haypo | robcresswell: sorry, i don't know how to ensure that there is no regression. patches are quite small, the risk is low | 09:59 |
| robcresswell | Oh dw, I agree, risk is low, small patches etc | 09:59 |
| haypo | then it's up to you | 09:59 |
| robcresswell | but... need to ask PTL about merging now vs waiting a week or so for M | 10:00 |
| haypo | robcresswell: most PTL made a choice: no more python 3 in nova, cinder and swift for example | 10:01 |
| haypo | (until the next cycle) | 10:01 |
| robcresswell | Indeed, that is the reaction I would expect. | 10:02 |
| robcresswell | david-lyle: Whenever you're about, just wondering about python3 work; amongst others, it hasn't been -2 but wanted to check on merging. | 10:02 |
| *** jtriley has joined #openstack-horizon | 10:06 | |
| mrunge | I don't think, openstack_auth is py3 yet, isn't it? | 10:07 |
| mrunge | and if it is, we should add a check/gate job | 10:07 |
| haypo | mrunge: it's "almost" compatible with python 3 | 10:07 |
| haypo | mrunge: but i found an issue which impacts a lot of tests in horizon | 10:08 |
| haypo | mrunge: my fix was merged, i'm waiting for a release | 10:08 |
| mrunge | haypo, I briefly looked into issues in horizon checks | 10:08 |
| mrunge | I didn't knew you already submitted a fix haypo | 10:08 |
| haypo | mrunge: django_openstack_auth *has* a *voting* gate-django_openstack_auth-python34 gate | 10:09 |
| tsufiev | morning, folks | 10:09 |
| *** KingKhan has quit IRC | 10:09 | |
| robcresswell | tsufiev: Morning! | 10:09 |
| haypo | mrunge: the merged fix, https://review.openstack.org/#/c/217687/ | 10:09 |
| mrunge | haypo, oh, my bad. | 10:09 |
| mrunge | morning tsufiev | 10:09 |
| mrunge | yay! for gating on py3 there, too | 10:10 |
| *** bluex-pl has quit IRC | 10:10 | |
| tsufiev | https://bugs.launchpad.net/horizon/+bug/1493205 another 'They killed Kenny, bastards!' - I mean integration tests :) | 10:10 |
| openstack | Launchpad bug 1493205 in OpenStack Dashboard (Horizon) "Create Keypair failed on latest DevStack" [Undecided,New] - Assigned to Chung Chih, Hung (lyanchih) | 10:10 |
| *** bluex-pl has joined #openstack-horizon | 10:10 | |
| mrunge | another reason for adding horizon integration tests on others gates | 10:12 |
| robcresswell | tsufiev: I know what causes that issue! | 10:12 |
| robcresswell | sambetts pointed it to me yesterday | 10:13 |
| robcresswell | I think | 10:13 |
| *** jtriley has quit IRC | 10:13 | |
| tsufiev | robcresswell, new system of permissions or something like that? | 10:13 |
| robcresswell | tsufiev: It was davids exception patch | 10:13 |
| tsufiev | haha )) | 10:13 |
| robcresswell | he did a silly thing with his if statements and no cores caught it | 10:13 |
| robcresswell | https://github.com/openstack/horizon/commit/a5f5912bc346d34a5c8e1de95c0c360b8993c9c0 | 10:14 |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: fixed row update of vpn table https://review.openstack.org/168833 | 10:14 |
| tsufiev | nobody dared :) | 10:14 |
| tsufiev | we need more brave people | 10:14 |
| robcresswell | elif message and "%(exc)s" in message: | 10:14 |
| robcresswell | - message = encoding.force_text(message) % {"exc": log_entry} | 10:14 |
| robcresswell | + user_message = encoding.force_text(message) % {"exc": log_entry} if message: | 10:14 |
| robcresswell | - message = encoding.force_text(message) | 10:14 |
| robcresswell | + user_message = encoding.force_text(message) | 10:14 |
| robcresswell | Of that failed | 10:14 |
| robcresswell | one sec | 10:14 |
| sambetts | robcresswell: The patch is up to fix it :) https://review.openstack.org/#/c/221000/ | 10:14 |
| sambetts | tsufiev: ^ | 10:14 |
| tsufiev | I'm deploying fresh devstack right now, going to see it for myself | 10:15 |
| tsufiev | sambetts, thanks, will look | 10:15 |
| robcresswell | tsufiev: http://paste.openstack.org/show/450000/ | 10:15 |
| robcresswell | tsufiev: The second if overrides the first, so user_message will always derp | 10:15 |
| robcresswell | wait I think I posted it wrong again | 10:15 |
| robcresswell | gah | 10:15 |
| robcresswell | basically its a small issue and sam fixed it already :p | 10:16 |
| robcresswell | tsufiev: I'm actually getting a totally different bug than that error, but its still broken | 10:21 |
| tsufiev | robcresswell, I looked through horizon-error.log from devstack in integration tests job artifacts, there were a dozen tracebacks | 10:22 |
| robcresswell | ah I see | 10:22 |
| robcresswell | Yeah I *think* its because of the condition handling in davids patch, the exc never gets resolved and just gets passed as a message | 10:23 |
| openstackgerrit | Daniel Bellantuono proposed openstack/horizon: Swap and ephemeral fields should be optional https://review.openstack.org/207963 | 10:23 |
| robcresswell | tsufiev: https://github.com/openstack/horizon/blob/master/horizon/exceptions.py#L344 Because "if message" means that user_message will always be overriden with "message" regardless of the conidition at 342 | 10:24 |
| tsufiev | well, I am not sure it's time to blame David's patch, because the whole exception handling in Horizon is a mess | 10:24 |
| robcresswell | tsufiev: sambetts spotted it so credit to him :) | 10:24 |
| tsufiev | maybe he just made some things more obvious | 10:24 |
| robcresswell | tsufiev: Its not really blaming. He fixed one issue, but just made a small mistake. | 10:24 |
| robcresswell | Realistically someone should have caught it, but small mistakes happen :) | 10:25 |
| tsufiev | robcresswell, the problem with these exceptions is that it's hard to keep the whole picture in head | 10:25 |
| robcresswell | tsufiev: Agreed, the system is a mess | 10:26 |
| tsufiev | or at least one needs to spend no less that several hours to imagine it | 10:26 |
| robcresswell | yup | 10:27 |
| *** KingKhan has joined #openstack-horizon | 10:29 | |
| *** _kiran_ has joined #openstack-horizon | 10:29 | |
| *** romainh has quit IRC | 10:29 | |
| robcresswell | Sams patch works, and properly exposes the key pair error | 10:29 |
| *** julim has joined #openstack-horizon | 10:29 | |
| robcresswell | it seems the actual key pair part is failing for a different reason | 10:29 |
| *** kiran-r has quit IRC | 10:30 | |
| sambetts | tsufiev, robcresswell: I found the exception mess out when I went through it all in a patch I've had up for months to do with making sure that django lazy string objects get resolved before being written to the logs | 10:31 |
| tsufiev | sambetts, something like that https://review.openstack.org/#/c/216712/2 ? | 10:31 |
| sambetts | tsufiev: https://review.openstack.org/#/c/173974/ | 10:32 |
| *** JeanBriceCombebi has quit IRC | 10:33 | |
| tsufiev | omg, it's big | 10:33 |
| *** julim has quit IRC | 10:33 | |
| *** sayan has quit IRC | 10:34 | |
| sambetts | tsufiev: some of it might not be needed now, it needs a rebase, but the main thing is the log filter, which makes sure that the lazy tranlation objects get made into an english string instead of printing a python object to the logs | 10:35 |
| tsufiev | r1chardj0n3s, ping | 10:35 |
| tsufiev | sambetts, added to my review queue | 10:35 |
| *** aix has quit IRC | 10:35 | |
| *** mhickey has joined #openstack-horizon | 10:35 | |
| mrunge | sambetts, it makes sense to rebase your patch | 10:36 |
| *** yamamoto has joined #openstack-horizon | 10:36 | |
| mrunge | I know, this is a pain | 10:36 |
| *** aix has joined #openstack-horizon | 10:36 | |
| sambetts | mrunge: I will work on getting it back to a reviewable state :) | 10:37 |
| mrunge | sambetts, thank you | 10:37 |
| mrunge | about those large patches, I'm twofold | 10:38 |
| mrunge | on one side, it's a pain to get them through, on the other side, we need to stabilize horizon | 10:38 |
| r1chardj0n3s | tsufiev: hi | 10:40 |
| robcresswell | mrunge: Could you review https://review.openstack.org/#/c/221000/? It seems to at least expose the error message properly in https://bugs.launchpad.net/horizon/+bug/1493205 | 10:40 |
| openstack | Launchpad bug 1493205 in OpenStack Dashboard (Horizon) "Create Keypair failed on latest DevStack" [Undecided,New] - Assigned to Chung Chih, Hung (lyanchih) | 10:40 |
| robcresswell | Its a small patch too | 10:40 |
| tsufiev | r1chardj0n3s, I've tried some unicode interpolation combinations here http://paste2.org/fjMOEA7P (related CR https://review.openstack.org/#/c/216712/) and it seems to me that adding u'' to interpolation template doesn't solve the problme | 10:42 |
| r1chardj0n3s | ok, um, so u'' and '' don't mix | 10:42 |
| r1chardj0n3s | that | 10:42 |
| r1chardj0n3s | is rule #1 | 10:43 |
| r1chardj0n3s | if you want to format a u'' into a '' then you *must* encode it, otherwise you risk an exception (usually a UnicodeEncodeException IIRC its name) | 10:43 |
| tsufiev | the more important thing regarding that patch is that we need to decode interpolation arguments in advance | 10:43 |
| tsufiev | in case they are utf-8 encoded | 10:43 |
| r1chardj0n3s | yes | 10:43 |
| r1chardj0n3s | I've only just started becoming aware of some of the unicode issues in Horizon and | 10:44 |
| tsufiev | mrunge, ^^ | 10:44 |
| r1chardj0n3s | wel | 10:44 |
| r1chardj0n3s | I'm pretty goddamn angry at oslo, to be honest | 10:44 |
| r1chardj0n3s | those "safe" unicode functions it provides just promote ingnorance and laziness :( | 10:44 |
| tsufiev | r1chardj0n3s, I think an interpolation wrapper would help | 10:44 |
| mhickey | Anyone go time to look at this patch: https://review.openstack.org/#/c/213193/ ? | 10:44 |
| *** jtomasek has quit IRC | 10:45 | |
| r1chardj0n3s | if you're gonna deal with unicode then you *have* to know what data you're dealing with and do the correct encoding and decoding necessary to *each situation as it arises* | 10:45 |
| *** jtomasek has joined #openstack-horizon | 10:45 | |
| ekarlso | seeing that there's alot of html files with the new angular stuff | 10:48 |
| ekarlso | are you guys gonna do like a bundle of all / most html into a .js file for production to avoid having to fetch n+ html files ? | 10:48 |
| *** ZZelle has quit IRC | 10:49 | |
| *** ZZelle has joined #openstack-horizon | 10:49 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Angular docs - code theory and translation https://review.openstack.org/203862 | 10:50 |
| r1chardj0n3s | ekarlso: I'm not sure that's been discussed yet - how about you write up a proposal in a blueprint? | 10:50 |
| robcresswell | Heh, I'm looking forward to our angular shouting matches at the summit again :D | 10:51 |
| r1chardj0n3s | robcresswell: you too? :) | 10:53 |
| ekarlso | meh :p | 10:53 |
| ekarlso | haha | 10:53 |
| r1chardj0n3s | robcresswell: so I have a fix against d-o-a but I'm not sure who I should hassle to get the patch looked at | 10:53 |
| ekarlso | not even going to the summit :p | 10:54 |
| r1chardj0n3s | I emailed david, but I'm not even sure he's the guy to talk to | 10:54 |
| r1chardj0n3s | s/guy/person | 10:54 |
| robcresswell | r1chardj0n3s: Most of the d_o_a reviewing is handled by lhcheng and david | 10:54 |
| r1chardj0n3s | robcresswell: ok, then I'm on the right track | 10:55 |
| ekarlso | robcresswell: I figured the angular stuff btw | 10:55 |
| robcresswell | ekarlso: Oh nice, what was it? | 10:55 |
| ekarlso | ADD_JS_FILES vs AUTODISCOVER :P | 10:55 |
| ekarlso | so the module was overwritten :D | 10:55 |
| robcresswell | ekarlso: Interesting | 10:56 |
| ekarlso | so, what strategy should I use when we have a resource in Designate called Zones (DNS Domains) and under there you have RecordSets that you manage? | 10:58 |
| ekarlso | is there a way to "nest" stuff ? | 10:58 |
| *** lyanchih has quit IRC | 10:58 | |
| *** yamamoto has quit IRC | 10:58 | |
| robcresswell | ekarlso: In terms of routing? Have a look at networks? | 10:59 |
| ekarlso | robcresswell: is there any angular code for networks ? | 11:00 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Angular docs - code theory and translation https://review.openstack.org/203862 | 11:01 |
| robcresswell | ekarlso: Narp, sorry I'm only half watching the chat :p | 11:02 |
| ekarlso | robcresswell: :| | 11:03 |
| robcresswell | I'm not sure how the angular work intends to nest resources like that | 11:03 |
| ekarlso | robcresswell: well I guess I can just do a "Manage Records" button for now | 11:03 |
| ekarlso | to bring into a new url | 11:03 |
| tsufiev | robcresswell, sambetts: there are at least 2 problems with keypair create: http://paste2.org/P8zxO95K | 11:05 |
| robcresswell | tsufiev: Yes, like I said Sams patch just exposes the error message properly :p | 11:06 |
| tsufiev | this one https://bugs.launchpad.net/horizon/+bug/1493207 triggers the one that David might have introduced | 11:06 |
| openstack | Launchpad bug 1493205 in OpenStack Dashboard (Horizon) "duplicate for #1493207 Create Keypair failed on latest DevStack" [Undecided,New] - Assigned to Chung Chih, Hung (lyanchih) | 11:06 |
| tsufiev | yep | 11:06 |
| robcresswell | Looks like that bug report already points out a versioning issue? | 11:09 |
| openstackgerrit | Merged openstack/horizon: Wording for Security Groups is incorrect https://review.openstack.org/221193 | 11:11 |
| *** _kiran_ is now known as kiran-r | 11:11 | |
| *** kjelly_ has joined #openstack-horizon | 11:13 | |
| mrunge | tsufiev, about those unicode issues, I must admit, I'm a bit astonished, you haven't seen this as customer ticket yet | 11:15 |
| tsufiev | mrunge, we were lucky ) | 11:15 |
| mrunge | tsufiev, at least for my proposal, I had the feedback, the proposed patch fixed their issues | 11:16 |
| mrunge | but I agree, we might have many occasions | 11:16 |
| *** romainh has joined #openstack-horizon | 11:16 | |
| mrunge | I would propose, fix, what you know to be broken, instead of delaying patches, because there might be other occurrences | 11:17 |
| mrunge | on the other side, you're right. we want to have a proper fix | 11:17 |
| *** deray has quit IRC | 11:17 | |
| mrunge | not a dirty hack or a half baked patch | 11:18 |
| tsufiev | mrunge, I think at least for this occurence we should ensure that the string is a unicode object on _both_ sides of the interpolation | 11:18 |
| tsufiev | the current patch fixes the problem because interpolation arguments are already of unicode type, but what would happen if they were not? | 11:19 |
| tsufiev | then we could proceed to other cases in separate patches | 11:19 |
| *** btully has joined #openstack-horizon | 11:19 | |
| mrunge | I would argue, it's django, and django is supposed to shift unicode around | 11:20 |
| tsufiev | hm... | 11:20 |
| mrunge | yeah, hm... | 11:20 |
| mrunge | if you have a better idea, more ideas, feel free to pick up the patch | 11:20 |
| mrunge | I would like to see it fixed in liberty | 11:20 |
| mrunge | and in best case a backport to kilo as well | 11:21 |
| *** btully has quit IRC | 11:24 | |
| *** jbell8 has quit IRC | 11:25 | |
| *** yingjun has joined #openstack-horizon | 11:26 | |
| tsufiev | mrunge, are you fine with me proposing more general solution in the patch dependent on yours? | 11:26 |
| mrunge | tsufiev, sure, just go ahead! | 11:27 |
| tsufiev | okay | 11:27 |
| mrunge | any help is appreciated! | 11:27 |
| *** yingjun has quit IRC | 11:28 | |
| *** yingjun has joined #openstack-horizon | 11:28 | |
| *** doug-fish has joined #openstack-horizon | 11:31 | |
| r1chardj0n3s | tsufiev: BTW the error at the end of http://paste2.org/fjMOEA7P is obvious, once you understand Python 2 strings/unicode and encoding/decoding :) | 11:31 |
| r1chardj0n3s | I'd be happy to explain it | 11:31 |
| r1chardj0n3s | unless you already know why that exception is raised, of course | 11:31 |
| tsufiev | r1chardj0n3s, I guess it's because internally non-unicode strings in Python are encoded as utf-8, but then when using such strings in unicode context, Python tries to decode them with ascii codec. Is that right? | 11:33 |
| *** yingjun has quit IRC | 11:33 | |
| r1chardj0n3s | tsufiev: you're partially there | 11:33 |
| r1chardj0n3s | there's no such thing as an "internal encoding" in Python | 11:34 |
| r1chardj0n3s | the unicode characters are stored in some manner that, as far as we mere mortals are concerned, is a black box. | 11:34 |
| r1chardj0n3s | (it's actually irrelevant how they're stored) | 11:34 |
| r1chardj0n3s | but you're correct in that: you're trying to format something into a unicode string | 11:34 |
| r1chardj0n3s | so the format operator, in formatting %s, *requires* a unicode object as an argument | 11:35 |
| r1chardj0n3s | Python 2, in its ... unfortunate choice ... tries to automatically coerce a regular string into a unicode object for you | 11:35 |
| r1chardj0n3s | but to do so, the regular string must be *decoded* to unicode, and the only sensible default encoding it can use is | 11:35 |
| r1chardj0n3s | ASCII! | 11:35 |
| r1chardj0n3s | so, you get a UnicodeDecodeError: "ASCII has no idea what you're doing" | 11:36 |
| tsufiev | r1chardj0n3s, if there is no 'internal encoding', who does 'utf-8' encoding? | 11:36 |
| r1chardj0n3s | does that make sense? | 11:36 |
| r1chardj0n3s | *you* do | 11:36 |
| *** deray has joined #openstack-horizon | 11:36 | |
| tsufiev | r1chardj0n3s, you mean the text editor? | 11:36 |
| r1chardj0n3s | when you encode or decode | 11:36 |
| r1chardj0n3s | ok, if you enter unicode in a Python source file, you *must* declare the encoding for Python to understand it, yes? | 11:37 |
| tsufiev | I recall the choice of codec for encoding is explicit in Emacs | 11:37 |
| r1chardj0n3s | similarly if you read data from a file, or from a socket, you *must* .decode() it | 11:37 |
| r1chardj0n3s | emacs isn't likely the thing doing the encoding - it'll be your *terminal* | 11:37 |
| r1chardj0n3s | unless you use a GUI emacs | 11:37 |
| tsufiev | r1chardj0n3s, one thing that is clear to me: it's good that py3 abandoned default str() type :) | 11:38 |
| r1chardj0n3s | oh, yes | 11:38 |
| r1chardj0n3s | so Django does decoding for us, though sadly it also has stupid functions like force_text() ugh | 11:39 |
| r1chardj0n3s | so the values in Django's POST etc. will all be decoded using the charset specified by the client | 11:39 |
| r1chardj0n3s | (which is usually the charset we specify *to* the client using our header or meta tag - I'm pretty sure Horizon does specify utf8) | 11:40 |
| r1chardj0n3s | similarly, database layers also do encoding/decoding for you, but we're not using them | 11:40 |
| r1chardj0n3s | I have actually no idea what our OpenStack service APIs do in the face of unicode, but to be honest, given the goddamn oslo library and its ridiculous safe_encode (or whatever it's called) I'd be surprised if *anyone* knew what happens to unicode in the interface between services :/ | 11:41 |
| *** early has quit IRC | 11:41 | |
| r1chardj0n3s | I seem to have gone off on a unicode rant again. Sorry about that. | 11:42 |
| robcresswell | ELI5 why oslo safe_encode is bad? | 11:42 |
| robcresswell | :) | 11:42 |
| r1chardj0n3s | because it encourages laziness - it encourages developers to not know what the data type of the data they're using is. which is all well and fine if you're an American and never have to deal with unicode ... | 11:42 |
| robcresswell | Ah | 11:43 |
| *** sayan has joined #openstack-horizon | 11:44 | |
| *** early has joined #openstack-horizon | 11:49 | |
| tsufiev | r1chardj0n3s, I think we should run Horizon integration tests with non-english locale switched on | 11:50 |
| tsufiev | both in Horizon and the rest of the stack | 11:50 |
| r1chardj0n3s | tsufiev: that sounds like fun ;) | 11:50 |
| r1chardj0n3s | yep | 11:51 |
| tsufiev | r1chardj0n3s, of course, once integration tests are made voting again | 11:51 |
| tsufiev | that will guarantee that everyone will try to fix unicode errors asap :) | 11:51 |
| *** mohankumar has quit IRC | 11:51 | |
| r1chardj0n3s | at the moment, I'm just trying to get the selenium tests consistently green - the hilarious thing is that people keep on merging patches that break the selenium tests :) | 11:51 |
| tsufiev | r1chardj0n3s, same thing with integration tests | 11:52 |
| *** JeanBriceCombebi has joined #openstack-horizon | 11:52 | |
| r1chardj0n3s | :( | 11:52 |
| tsufiev | what makes me even more sad is that not only Horizon folks merge patches that break integration tests | 11:52 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Ensure unicode and non-unicode don't mix in interpolations https://review.openstack.org/221270 | 11:55 |
| tsufiev | r1chardj0n3s, does that ^^ makes sense? | 11:55 |
| r1chardj0n3s | tsufiev: I need to look into that tomorrow (sorry, I'm heading off to bed now) | 11:56 |
| r1chardj0n3s | g'night | 11:56 |
| tsufiev | r1chardj0n3s, good night! | 11:57 |
| robcresswell | night r1chardj0n3s | 11:57 |
| * tsufiev again forgot about TZ stuff | 11:57 | |
| mrunge | r1chardj0n3s, good night | 11:58 |
| *** yamamoto has joined #openstack-horizon | 11:59 | |
| *** e0ne has quit IRC | 12:01 | |
| *** alexpilotti_ has quit IRC | 12:03 | |
| *** cloudtrainme has quit IRC | 12:03 | |
| *** yamamoto has quit IRC | 12:04 | |
| *** e0ne has joined #openstack-horizon | 12:04 | |
| *** lblanchard has joined #openstack-horizon | 12:05 | |
| *** doug-fish has quit IRC | 12:08 | |
| mrunge | uhm, stupid question: do we really need django-babel? | 12:09 |
| mrunge | it's upstream says: Django<1.7 | 12:10 |
| mrunge | https://github.com/graingert/django-babel/ | 12:10 |
| *** doug-fish has joined #openstack-horizon | 12:10 | |
| mrunge | ah, pypi uses a wrong upstream url | 12:11 |
| *** eandersson has joined #openstack-horizon | 12:11 | |
| robcresswell | Anyone know what jquery-ui is actually used for? :p | 12:14 |
| *** tnovacik has quit IRC | 12:18 | |
| rdopiera | robcresswell: drag-and-drop, animations and the like | 12:22 |
| *** chlong has joined #openstack-horizon | 12:22 | |
| robcresswell | rdopiera: Yeah, it seems very minor... trying to rip it out. Personally with jqlite in angular, I doubt we even need jquery at all, but still investigating. | 12:23 |
| *** daemontool_ has quit IRC | 12:23 | |
| *** mohankumar has joined #openstack-horizon | 12:24 | |
| rdopiera | robcresswell: it's possible that some calendar plugin we used to use needed it... | 12:25 |
| rdopiera | or something like that | 12:25 |
| robcresswell | rdopiera: I heard that too, but the datepickers seem to be functioning fine. Just looking around, so far its some draggable modal code, and the sorting for network lists in launch instance etc. | 12:26 |
| *** e0ne has quit IRC | 12:26 | |
| robcresswell | Most of the jquery usage overall seems to be for element/class selectors, which jqlite will do fine, so would be nice to see if we can actually pull out a bunch of dependencies. | 12:27 |
| tsufiev | robcresswell, jqlite selectors are pretty limited comparing to jquery. That might break some of the angular code which relies on the power of jquery selectors (although it shouldn't) | 12:29 |
| *** ducttape_ has joined #openstack-horizon | 12:29 | |
| robcresswell | tsufiev: Indeed, its just an investigation for now. Thing is, a lot of selector code *is* very limited. We don't use much complex jquery anywhere | 12:30 |
| *** jtriley has joined #openstack-horizon | 12:31 | |
| tsufiev | robcresswell, I think if coverage of angular code is good enough, unit tests for the commit which removes jquery support should tell us whether it's fatal. Still Horizon JS code is not only _Angular_ yet... | 12:32 |
| robcresswell | Yeah will be interesting to see :p | 12:33 |
| openstackgerrit | Karthik Suresh proposed openstack/horizon: Fixed typos in comment for renaming dashboard https://review.openstack.org/221281 | 12:37 |
| *** ducttape_ has quit IRC | 12:41 | |
| *** ducttape_ has joined #openstack-horizon | 12:42 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Enable Launch Instance NG for the case when Nova quotas are disabled https://review.openstack.org/215196 | 12:42 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Check element's existence in angular unit tests in a proper way https://review.openstack.org/221283 | 12:42 |
| *** masco has quit IRC | 12:42 | |
| *** daemontool_ has joined #openstack-horizon | 12:42 | |
| *** jtriley has quit IRC | 12:43 | |
| *** KingKhan has quit IRC | 12:44 | |
| *** ducttape_ has quit IRC | 12:46 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: VPNaaS delete actions refactoring https://review.openstack.org/220522 | 12:49 |
| *** crobertsrh has left #openstack-horizon | 12:53 | |
| *** amotoki has quit IRC | 12:54 | |
| *** sayan has quit IRC | 12:54 | |
| *** mordred has joined #openstack-horizon | 12:54 | |
| *** crobertsrh has joined #openstack-horizon | 12:55 | |
| mordred | david-ly_: (or anyone else) heya! if I wanted to make a horizon patch to add the ability to download a clouds.yaml in addition to an openrc.sh ... | 12:55 |
| mordred | I've gotten as far as finding openstack_dashboard/dashboards/project/access_and_security/api_access/urls.py: url(r'^openrc/$', views.download_rc_file, name='openrc'), | 12:55 |
| mordred | but i'm not sure where in | 12:56 |
| mordred | oh | 12:56 |
| mordred | duh | 12:56 |
| mordred | nevermind | 12:56 |
| *** KingKhan has joined #openstack-horizon | 12:56 | |
| mordred | I was going to ask how it got from a web template to there | 12:56 |
| mordred | BUT | 12:56 |
| *** KingKhan has quit IRC | 12:56 | |
| mordred | then I learned how grep works :) | 12:56 |
| mordred | ignore me - I'll be back later with real questions I'm sure | 12:56 |
| mordred | oh - nope. still confused | 12:59 |
| mordred | openstack_dashboard/dashboards/project/access_and_security/templates/access_and_security/api_access/_credentials.html seems to display them - but I can't find where the download link comes from | 13:00 |
| openstackgerrit | Merged openstack/horizon: Ensure exc message is included in user_message https://review.openstack.org/221000 | 13:02 |
| *** mohankumar has quit IRC | 13:02 | |
| *** lyanchih has joined #openstack-horizon | 13:03 | |
| *** yamamoto has joined #openstack-horizon | 13:05 | |
| robcresswell | mordred: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/access_and_security/api_access/tables.py#L70 | 13:06 |
| robcresswell | mordred: That's the table action definition, and then the links themselves are above. | 13:07 |
| *** Piet has quit IRC | 13:07 | |
| *** vgridnev has quit IRC | 13:07 | |
| *** vgridnev has joined #openstack-horizon | 13:07 | |
| *** e0ne has joined #openstack-horizon | 13:08 | |
| robcresswell | Wait I think I've misunderstood your query | 13:08 |
| robcresswell | Unsure, ping me if you need more help navigating django :p | 13:08 |
| *** aortega has quit IRC | 13:09 | |
| *** geoffarnoldX is now known as geoffarnold | 13:11 | |
| *** romainh has quit IRC | 13:15 | |
| *** btully has joined #openstack-horizon | 13:15 | |
| mordred | robcresswell: aha! | 13:16 |
| mordred | robcresswell: thanks! | 13:16 |
| mordred | robcresswell: that's exactly what I was looking for | 13:16 |
| *** vijendar has joined #openstack-horizon | 13:16 | |
| *** neelashah has joined #openstack-horizon | 13:17 | |
| *** kjelly_ has quit IRC | 13:20 | |
| *** geoffarnold has quit IRC | 13:22 | |
| *** daemontool_ has quit IRC | 13:22 | |
| *** yamamoto has quit IRC | 13:22 | |
| robcresswell | mordred: No problem | 13:25 |
| *** exploreshaifali has quit IRC | 13:27 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move cluster configuration to separate tab https://review.openstack.org/197965 | 13:28 |
| *** deray has quit IRC | 13:29 | |
| *** Daisy has joined #openstack-horizon | 13:29 | |
| *** romainh has joined #openstack-horizon | 13:31 | |
| *** mrunge has quit IRC | 13:32 | |
| *** pauloewerton has joined #openstack-horizon | 13:36 | |
| *** lapalm has joined #openstack-horizon | 13:37 | |
| *** kiran-r has quit IRC | 13:40 | |
| *** jtriley has joined #openstack-horizon | 13:40 | |
| *** yamamoto has joined #openstack-horizon | 13:52 | |
| *** ducttape_ has joined #openstack-horizon | 13:53 | |
| *** jprovazn has joined #openstack-horizon | 14:00 | |
| *** jcoufal has quit IRC | 14:00 | |
| *** amotoki has joined #openstack-horizon | 14:00 | |
| *** cloudtrainme has joined #openstack-horizon | 14:07 | |
| *** cloudtrainme has quit IRC | 14:11 | |
| *** JeanBriceCombebi has quit IRC | 14:18 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:18 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: FWaaS delete actions refactoring https://review.openstack.org/221319 | 14:19 |
| *** cloudtrainme has joined #openstack-horizon | 14:21 | |
| haypo | sorry i don't recall who is the release manager for django_openstack_auth. I see Sergey Lukjanov in the latest announce, http://lists.openstack.org/pipermail/openstack-announce/2015-August/000545.html | 14:22 |
| haypo | it's just to get an update for the next release | 14:22 |
| *** tosky has quit IRC | 14:25 | |
| *** Drago has joined #openstack-horizon | 14:27 | |
| *** Daisy has quit IRC | 14:28 | |
| *** Daisy has joined #openstack-horizon | 14:28 | |
| *** tosky has joined #openstack-horizon | 14:31 | |
| *** vishwanathj has joined #openstack-horizon | 14:32 | |
| *** Daisy has quit IRC | 14:33 | |
| *** hurgleburgler has joined #openstack-horizon | 14:33 | |
| *** jcoufal has joined #openstack-horizon | 14:37 | |
| *** rhagarty has quit IRC | 14:38 | |
| *** teju has joined #openstack-horizon | 14:38 | |
| *** rhagarty_ has quit IRC | 14:38 | |
| tsufiev | robcresswell, it seems like network topology patch has fallen victim to the same quota issues that we hit recently in integration tests | 14:39 |
| *** aortega has joined #openstack-horizon | 14:40 | |
| *** Drago has quit IRC | 14:40 | |
| *** Drago has joined #openstack-horizon | 14:40 | |
| *** tjones has joined #openstack-horizon | 14:45 | |
| *** david-ly_ is now known as david-lyle | 14:53 | |
| *** ChanServ sets mode: +o david-lyle | 14:53 | |
| *** mhickey has quit IRC | 14:54 | |
| *** geoffarnold has joined #openstack-horizon | 14:55 | |
| *** hurgleburgler1 has joined #openstack-horizon | 14:58 | |
| *** kodokuu has joined #openstack-horizon | 14:58 | |
| *** crobertsrh has quit IRC | 14:59 | |
| kodokuu | Hi, I have issue with ceilometer and horizon | 14:59 |
| kodokuu | BadRequest at /admin/metering/ | 14:59 |
| kodokuu | my trace ==> http://paste.openstack.org/show/450378/ | 14:59 |
| kodokuu | Anyone can help me ? | 14:59 |
| kodokuu | With api all request works | 15:00 |
| *** fifieldt has quit IRC | 15:00 | |
| kodokuu | and with cli too | 15:00 |
| *** cbader has joined #openstack-horizon | 15:00 | |
| *** hurgleburgler has quit IRC | 15:01 | |
| *** crobertsrh has joined #openstack-horizon | 15:01 | |
| *** geoffarnold is now known as geoffarnoldX | 15:04 | |
| *** geoffarnoldX is now known as geoffarnold | 15:04 | |
| *** tjones has quit IRC | 15:04 | |
| haypo | robcresswell: oh, Akihiro Motoki approved some of my python3 patches. he likes omelette :) | 15:05 |
| *** Daisy has joined #openstack-horizon | 15:06 | |
| david-lyle | robcresswell: what silly thing? | 15:08 |
| *** teju has quit IRC | 15:08 | |
| david-lyle | justify yourself | 15:08 |
| *** TravT is now known as TravT_away | 15:08 | |
| david-lyle | :D | 15:08 |
| david-lyle | re: https://github.com/openstack/horizon/commit/a5f5912bc346d34a5c8e1de95c0c360b8993c9c0 | 15:09 |
| *** mhickey has joined #openstack-horizon | 15:09 | |
| david-lyle | you've unfixed something that wasn't broken | 15:10 |
| david-lyle | if you follow the logic | 15:10 |
| david-lyle | the second if was intentional | 15:10 |
| *** Piet has joined #openstack-horizon | 15:10 | |
| *** crobertsrh has quit IRC | 15:11 | |
| david-lyle | ah, nevermind, I see it | 15:11 |
| david-lyle | the logic was already there, however | 15:11 |
| *** geoffarnold is now known as geoffarnoldX | 15:12 | |
| *** geoffarnoldX is now known as geoffarnold | 15:12 | |
| david-lyle | I did miss the user_message in the first handler :/ thought I had that (shrug | 15:14 |
| david-lyle | ) | 15:14 |
| *** mpavlase has quit IRC | 15:15 | |
| *** crobertsrh has joined #openstack-horizon | 15:16 | |
| amotoki | haypo: what's a problem? | 15:18 |
| *** sayan has joined #openstack-horizon | 15:18 | |
| amotoki | haypo: It seems I miss something important. | 15:19 |
| *** crobertsrh has quit IRC | 15:22 | |
| *** bpokorny has joined #openstack-horizon | 15:22 | |
| *** alexvictorchan has joined #openstack-horizon | 15:24 | |
| haypo | amotoki: no problem. we had a discussion earlier with robcresswell on my python 3 patches. he asked me if it's still ok to merge such changes since we are close to the feature freeze | 15:25 |
| david-lyle | amotoki: there is a question of FF and approving python3 work. I was on the fence so I didn't preemptively -2 all of them, but I think that the logical thing at this point would be to block them until M, as we're unlikely to get full python 3 support in L in Horizon | 15:25 |
| haypo | amotoki: in short, i don't consider that there is a high risk to merge my changes | 15:25 |
| *** cloudtrainme has quit IRC | 15:26 | |
| amotoki | haypo: david-lyle: thanks for the clarification. I thought I checked the blueprint is targeted but I was confused with some other one :-( | 15:27 |
| haypo | david-lyle, amotoki, robcresswell: oh by the way, would you be ok to make the py34 gate voting? tests now pass with python 3.4! | 15:27 |
| *** cloudtrainme has joined #openstack-horizon | 15:28 | |
| haypo | david-lyle: it's up to you, i understand that you want to slow down the number of changes to stabilize the code | 15:28 |
| *** bradjones has joined #openstack-horizon | 15:28 | |
| *** bradjones has quit IRC | 15:28 | |
| *** bradjones has joined #openstack-horizon | 15:28 | |
| amotoki | personally I am fine with making py34 voting, but it can be deferred until Mitaka dev is open. | 15:29 |
| david-lyle | if it's passing now, I don't mind making it voting | 15:30 |
| haypo | david-lyle: great ;) | 15:30 |
| haypo | well, i'm working on a patch, so you can directly comment & vote there | 15:30 |
| david-lyle | haypo: sounds good. | 15:31 |
| *** Daisy has quit IRC | 15:31 | |
| amotoki | at now, we have the whitelist for py34 test, so we can make py34 voting safely. | 15:31 |
| *** Daisy has joined #openstack-horizon | 15:31 | |
| haypo | amotoki: sure, it's safe with a whitelist approach | 15:31 |
| david-lyle | my personal preference on the python 3 work is to hold off on more patches until Mitaka in Horizon. the less moving parts right now, the better | 15:32 |
| *** peristeri has quit IRC | 15:33 | |
| *** vgridnev has quit IRC | 15:33 | |
| haypo | "Make gate-horizon-python34 voting": https://review.openstack.org/#/c/221366/ | 15:33 |
| *** lapalm has quit IRC | 15:33 | |
| david-lyle | I do agree though that they are likely not high risk, but less un-required change the better. | 15:33 |
| haypo | david-lyle: ok, it's fair ;) i'm just concerned by making the gate voting | 15:33 |
| *** lapalm has joined #openstack-horizon | 15:34 | |
| haypo | david-lyle: to ensure that we start on a strong base with the next cycle | 15:34 |
| haypo | see the "py34 gate" column of https://wiki.openstack.org/wiki/Python3#OpenStack_applications -- it's cool, it's green for almost all applications, except swift & horizon (and manila & designate, but there are less important for me) | 15:35 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Enable Launch Instance NG for the case when Nova quotas are disabled https://review.openstack.org/215196 | 15:35 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix pie charts appearance https://review.openstack.org/221368 | 15:35 |
| david-lyle | haypo +1 from me | 15:35 |
| david-lyle | on the voting | 15:35 |
| *** Daisy has quit IRC | 15:36 | |
| haypo | david-lyle: ok. i added other horizon core devs to the reviewer list | 15:37 |
| amotoki | we can avoid re-introduing python3 issues addressed already by making py34 voting. nice :-) | 15:37 |
| *** lapalm has quit IRC | 15:38 | |
| *** lapalm has joined #openstack-horizon | 15:39 | |
| *** lapalm has quit IRC | 15:39 | |
| *** lapalm has joined #openstack-horizon | 15:39 | |
| *** kodokuu has quit IRC | 15:40 | |
| mhickey | @david-lyle: thanks for feedback to https://review.openstack.org/#/c/213193/ | 15:41 |
| mhickey | Probably just need to know if enabling button is needed or suifficient to just edit and enable then. | 15:43 |
| *** devlaps has joined #openstack-horizon | 15:43 | |
| david-lyle | haypo: the test only related patches I approved | 15:43 |
| david-lyle | the ones touching things in production code, postponed | 15:43 |
| haypo | david-lyle: ok, thanks | 15:43 |
| david-lyle | haypo: I really do appreciate all your efforts here | 15:44 |
| haypo | david-lyle: well, it's not a big deal. most patches are simple | 15:44 |
| david-lyle | haypo: just happens to require 2000 of them ;) | 15:45 |
| haypo | (ok, sometimes it takes me a few hours to find the "simple" python3 bug :-p) | 15:45 |
| haypo | david-lyle: haha, not so much | 15:45 |
| david-lyle | mhickey: I guess my initial thought was it's odd to call out disable and not enable | 15:46 |
| david-lyle | whether a batch action or not, hmmm | 15:46 |
| david-lyle | probably would provide better balance to have it | 15:47 |
| mhickey | @david-lyle: ok, agreed about the balance. Is using "More Actions" dropdown good emans for both functions? | 15:48 |
| mhickey | i.e. More Actions->Enable Domains and More Actions->Disable Domains | 15:49 |
| david-lyle | mhickey: I think that would be great | 15:49 |
| david-lyle | without it we'll have space issues | 15:49 |
| mhickey | @david-lyle: ok, thanks :) | 15:49 |
| *** linkedinyou has quit IRC | 15:53 | |
| *** romainh has left #openstack-horizon | 15:55 | |
| *** rajatvig has joined #openstack-horizon | 15:55 | |
| ZZelle | david-lyle, hi | 15:57 |
| ZZelle | david-lyle, do you think i can request a FFE for https://review.openstack.org/220838 ? | 15:57 |
| *** mhickey has quit IRC | 15:58 | |
| robcresswell | david-lyle: re: the patch, it wasn't meant to be a criticism, just that there was a minor issue with the conditions that noone noticed :) | 15:59 |
| robcresswell | Also, with the py3 work, I'm a +1 for block until M just because of risk | 15:59 |
| *** jprovazn has quit IRC | 16:00 | |
| david-lyle | robcresswell: I misread the issue | 16:01 |
| david-lyle | I thought the problem was with the second if message | 16:01 |
| david-lyle | but realized it was a munge of the original logic | 16:01 |
| *** ygbo has quit IRC | 16:01 | |
| david-lyle | plus brain was moving slow | 16:02 |
| *** gyee has joined #openstack-horizon | 16:03 | |
| robcresswell | Cool cool, didn't want it to seem like I was throwing blame around. | 16:03 |
| *** crobertsrh has joined #openstack-horizon | 16:08 | |
| *** zhenguo has quit IRC | 16:08 | |
| *** doug-fis_ has joined #openstack-horizon | 16:09 | |
| *** doug-fish has quit IRC | 16:09 | |
| *** clu_ has joined #openstack-horizon | 16:10 | |
| *** crobertsrh has quit IRC | 16:12 | |
| *** cloudtrainme has quit IRC | 16:13 | |
| *** lapalm has quit IRC | 16:15 | |
| *** lapalm has joined #openstack-horizon | 16:15 | |
| *** crobertsrh has joined #openstack-horizon | 16:16 | |
| *** rdopiera has quit IRC | 16:17 | |
| *** lapalm has quit IRC | 16:19 | |
| *** crobertsrh1 has joined #openstack-horizon | 16:20 | |
| *** crobertsrh has quit IRC | 16:21 | |
| *** kyleolivo has joined #openstack-horizon | 16:24 | |
| *** SimonChung has joined #openstack-horizon | 16:25 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Enable Launch Instance NG for the case when Nova quotas are disabled https://review.openstack.org/215196 | 16:25 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Magic Search in Angular Users table https://review.openstack.org/221391 | 16:25 |
| *** JeanBriceCombebi has quit IRC | 16:25 | |
| *** tjones has joined #openstack-horizon | 16:26 | |
| *** rhagarty has joined #openstack-horizon | 16:26 | |
| *** rhagarty_ has joined #openstack-horizon | 16:26 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Create volume pre-select default vol-type https://review.openstack.org/221393 | 16:28 |
| *** Ala has quit IRC | 16:29 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Magic Search in Angular Users table https://review.openstack.org/202265 | 16:29 |
| *** lyanchih has quit IRC | 16:29 | |
| *** bluex-pl has quit IRC | 16:31 | |
| *** vgridnev has joined #openstack-horizon | 16:37 | |
| *** crobertsrh1 has quit IRC | 16:39 | |
| *** Guest60469 is now known as mgagne | 16:40 | |
| *** mgagne has joined #openstack-horizon | 16:40 | |
| *** doug-fis_ has quit IRC | 16:41 | |
| *** TravT_away is now known as TravT | 16:42 | |
| *** tqtran has joined #openstack-horizon | 16:45 | |
| *** kyleolivo has quit IRC | 16:45 | |
| *** crobertsrh has joined #openstack-horizon | 16:46 | |
| *** amotoki has quit IRC | 16:46 | |
| *** lapalm has joined #openstack-horizon | 16:48 | |
| *** lapalm has quit IRC | 16:48 | |
| *** lapalm has joined #openstack-horizon | 16:48 | |
| *** jbell8 has joined #openstack-horizon | 16:53 | |
| *** lapalm has quit IRC | 16:54 | |
| *** lapalm has joined #openstack-horizon | 16:54 | |
| *** e0ne has quit IRC | 16:56 | |
| *** kyleolivo has joined #openstack-horizon | 16:56 | |
| *** jbell8 has quit IRC | 16:57 | |
| *** pai15 has joined #openstack-horizon | 16:57 | |
| *** aix has quit IRC | 16:58 | |
| *** lapalm has quit IRC | 16:59 | |
| *** SimonChung1 has joined #openstack-horizon | 17:00 | |
| *** SimonChung has quit IRC | 17:00 | |
| *** doug-fish has joined #openstack-horizon | 17:00 | |
| *** SimonChung has joined #openstack-horizon | 17:02 | |
| *** SimonChung1 has quit IRC | 17:02 | |
| *** harlowja has joined #openstack-horizon | 17:03 | |
| *** alanf has joined #openstack-horizon | 17:04 | |
| *** kyleolivo has quit IRC | 17:05 | |
| *** KunalGandhi has joined #openstack-horizon | 17:05 | |
| *** SimonChung1 has joined #openstack-horizon | 17:06 | |
| *** SimonChung has quit IRC | 17:06 | |
| *** kyleolivo has joined #openstack-horizon | 17:06 | |
| *** eandersson has quit IRC | 17:07 | |
| *** jbell8 has joined #openstack-horizon | 17:08 | |
| *** KunalGandhi has quit IRC | 17:10 | |
| *** jpomeroy has quit IRC | 17:10 | |
| *** kyleolivo has quit IRC | 17:10 | |
| *** kyleolivo has joined #openstack-horizon | 17:10 | |
| *** lhcheng has joined #openstack-horizon | 17:13 | |
| *** lhcheng has quit IRC | 17:13 | |
| *** KunalGandhi has joined #openstack-horizon | 17:14 | |
| *** lhcheng has joined #openstack-horizon | 17:14 | |
| * tsufiev thinks we should have something like https://github.com/gloomyson/StarCraft in Horizon :) | 17:14 | |
| *** jtriley_ has joined #openstack-horizon | 17:14 | |
| hurgleburgler1 | tsufiev +1 | 17:15 |
| *** pai15 has quit IRC | 17:15 | |
| *** kyleolivo has quit IRC | 17:16 | |
| *** kyleolivo has joined #openstack-horizon | 17:16 | |
| *** kyleolivo has quit IRC | 17:17 | |
| *** jtriley has quit IRC | 17:17 | |
| *** kyleolivo has joined #openstack-horizon | 17:17 | |
| *** kyleolivo has quit IRC | 17:18 | |
| *** kyleolivo has joined #openstack-horizon | 17:19 | |
| *** TravT_ has joined #openstack-horizon | 17:21 | |
| *** TravT has quit IRC | 17:21 | |
| *** sayan has quit IRC | 17:22 | |
| *** stevemar has joined #openstack-horizon | 17:23 | |
| *** kyleolivo has quit IRC | 17:23 | |
| *** tjones has quit IRC | 17:28 | |
| *** lsmola has quit IRC | 17:29 | |
| *** tjones has joined #openstack-horizon | 17:32 | |
| *** jpomeroy has joined #openstack-horizon | 17:33 | |
| *** jingjing_ren has joined #openstack-horizon | 17:38 | |
| *** sayan has joined #openstack-horizon | 17:38 | |
| *** shivrao has joined #openstack-horizon | 17:39 | |
| *** neelashah has quit IRC | 17:41 | |
| *** exploreshaifali has joined #openstack-horizon | 17:42 | |
| openstackgerrit | Merged openstack/horizon: Port horizon forms tests to Python 3 https://review.openstack.org/219713 | 17:43 |
| *** pai15 has joined #openstack-horizon | 17:45 | |
| *** e0ne has joined #openstack-horizon | 17:47 | |
| *** saksham has joined #openstack-horizon | 17:48 | |
| *** tosky_ has joined #openstack-horizon | 17:54 | |
| *** tosky_ has quit IRC | 17:54 | |
| *** lapalm has joined #openstack-horizon | 17:55 | |
| *** tosky has quit IRC | 17:57 | |
| *** ericpeterson has joined #openstack-horizon | 17:58 | |
| *** ducttape_ has quit IRC | 17:58 | |
| *** doug-fis_ has joined #openstack-horizon | 17:59 | |
| *** doug-fi__ has joined #openstack-horizon | 18:00 | |
| *** cloudtrainme has joined #openstack-horizon | 18:00 | |
| *** vgridnev has quit IRC | 18:00 | |
| *** aix has joined #openstack-horizon | 18:01 | |
| *** jingjing_ren has quit IRC | 18:01 | |
| *** lapalm has quit IRC | 18:01 | |
| *** cloudtrainme has quit IRC | 18:01 | |
| *** doug-fish has quit IRC | 18:01 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for system information https://review.openstack.org/205196 | 18:03 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular system information panel https://review.openstack.org/204731 | 18:03 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 18:03 |
| *** doug-fis_ has quit IRC | 18:03 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add pagination support to the volume page https://review.openstack.org/118450 | 18:04 |
| *** lapalm has joined #openstack-horizon | 18:04 | |
| *** lapalm has quit IRC | 18:04 | |
| *** lapalm has joined #openstack-horizon | 18:05 | |
| *** vgridnev has joined #openstack-horizon | 18:06 | |
| *** vgridnev has quit IRC | 18:06 | |
| *** KunalGandhi has quit IRC | 18:06 | |
| *** aortega has quit IRC | 18:09 | |
| *** SimonChung1 has quit IRC | 18:10 | |
| *** SimonChung has joined #openstack-horizon | 18:10 | |
| *** aortega has joined #openstack-horizon | 18:10 | |
| *** pai15_ has joined #openstack-horizon | 18:10 | |
| *** SimonChung has quit IRC | 18:10 | |
| *** SimonChung1 has joined #openstack-horizon | 18:10 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Webroot Theme is no longer needed https://review.openstack.org/213411 | 18:11 |
| *** pai15 has quit IRC | 18:14 | |
| *** jingjing_ren has joined #openstack-horizon | 18:17 | |
| *** kyleolivo has joined #openstack-horizon | 18:19 | |
| *** sqchen has joined #openstack-horizon | 18:20 | |
| *** kyleolivo has quit IRC | 18:23 | |
| *** e0ne has quit IRC | 18:29 | |
| *** openstackgerrit has quit IRC | 18:31 | |
| *** openstackgerrit has joined #openstack-horizon | 18:32 | |
| lhcheng | david-lyle: there are some issues with the recent release of novaclient related to micro version | 18:33 |
| lhcheng | david-lyle: OSC have to make some fixes to unblock its gate | 18:33 |
| lhcheng | david-lyle: I wonder if horizon might also hit that problem | 18:33 |
| david-lyle | something about client versions? | 18:34 |
| lhcheng | david-lyle: yes | 18:34 |
| *** asahlin has joined #openstack-horizon | 18:34 | |
| *** ybathia has joined #openstack-horizon | 18:34 | |
| lhcheng | related to this type of code: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/keypairs.py#L69-L83 | 18:34 |
| lhcheng | two methods with the same name | 18:34 |
| *** cloudtrainme has joined #openstack-horizon | 18:34 | |
| lhcheng | and we have to pass the api version so the right method will be used | 18:35 |
| david-lyle | awesome | 18:35 |
| david-lyle | which is the right version? | 18:35 |
| lhcheng | I haven't got the chance to rebuild devstack to test (didn't want to wipe my current keystone setup) | 18:35 |
| lhcheng | depends on the micro version that deployed nova support | 18:36 |
| david-lyle | so is the expectation we just walk down versions until we hit one that works? | 18:37 |
| lhcheng | david-lyle: so yeah, I think create keypair might fail now.. https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L559-L560 | 18:38 |
| lhcheng | the version needs to be passed in the Client call | 18:38 |
| lhcheng | if anyone have bandwidth, would appreciate testing the Create Keypair with the latest code. | 18:40 |
| *** cloudtrainme has quit IRC | 18:40 | |
| *** SimonChung has joined #openstack-horizon | 18:40 | |
| *** SimonChung1 has quit IRC | 18:40 | |
| *** cloudtrainme has joined #openstack-horizon | 18:41 | |
| david-lyle | so what | 18:41 |
| david-lyle | 's the nature of the failure? | 18:41 |
| *** SimonChung has quit IRC | 18:41 | |
| *** SimonChung has joined #openstack-horizon | 18:41 | |
| *** vijendar has quit IRC | 18:45 | |
| lhcheng | david-lyle: this method is getting called when creating a keypair: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/keypairs.py#L82-L83 | 18:47 |
| lhcheng | and nova will throw an error that type is not a valid attribute | 18:47 |
| *** rajatvig has quit IRC | 18:48 | |
| *** vgridnev has joined #openstack-horizon | 18:48 | |
| *** rajatvig has joined #openstack-horizon | 18:48 | |
| lhcheng | maybe it will work with devstack since it would be running in latest code, idk | 18:49 |
| *** garthb has joined #openstack-horizon | 18:49 | |
| *** KunalGandhi has joined #openstack-horizon | 18:53 | |
| *** ttrifonov is now known as zz_ttrifonov | 18:55 | |
| *** jingjing_ren has quit IRC | 18:57 | |
| openstackgerrit | Merged openstack/horizon: Port dashboard api access tests to Python 3 https://review.openstack.org/218381 | 18:57 |
| *** jpomeroy has quit IRC | 19:00 | |
| *** doug-fi__ has quit IRC | 19:00 | |
| *** doug-fish has joined #openstack-horizon | 19:01 | |
| *** doug-fish has quit IRC | 19:01 | |
| *** doug-fish has joined #openstack-horizon | 19:02 | |
| *** doug-fish has quit IRC | 19:02 | |
| *** cloudtrainme has quit IRC | 19:02 | |
| *** neelashah has joined #openstack-horizon | 19:02 | |
| *** doug-fish has joined #openstack-horizon | 19:02 | |
| *** cloudtrainme has joined #openstack-horizon | 19:03 | |
| *** cloudtrainme has quit IRC | 19:04 | |
| *** lapalm has quit IRC | 19:05 | |
| *** lapalm has joined #openstack-horizon | 19:05 | |
| *** kyleolivo has joined #openstack-horizon | 19:06 | |
| *** neelashah has quit IRC | 19:06 | |
| *** neelashah has joined #openstack-horizon | 19:08 | |
| *** kyleolivo has quit IRC | 19:08 | |
| *** vgridnev has quit IRC | 19:09 | |
| *** ericpeterson has quit IRC | 19:14 | |
| *** cloudtrainme has joined #openstack-horizon | 19:15 | |
| *** ducttape_ has joined #openstack-horizon | 19:15 | |
| *** vijendar has joined #openstack-horizon | 19:16 | |
| *** aorourke has joined #openstack-horizon | 19:16 | |
| *** vgridnev has joined #openstack-horizon | 19:17 | |
| *** kyleolivo has joined #openstack-horizon | 19:18 | |
| *** djc__ has joined #openstack-horizon | 19:18 | |
| djc__ | Hi. I am running into a problem with the dashboard using keystone version3 (multi-domains -- mysql & AD). When in the dashboard, I get the error message "Error: Unauthorized: Unable to retrieve group list." when trying to select 'Users' and 'Groups' under the Identity tab. Here is my keystone log. https://gist.github.com/anonymous/c7c1c546218f39f86c3a | 19:18 |
| *** SimonChung1 has joined #openstack-horizon | 19:28 | |
| *** SimonChung has quit IRC | 19:28 | |
| *** aix has quit IRC | 19:32 | |
| *** jpomeroy has joined #openstack-horizon | 19:32 | |
| *** asahlin has quit IRC | 19:33 | |
| *** yamamoto has quit IRC | 19:34 | |
| *** tjones has quit IRC | 19:35 | |
| *** mpavlase has joined #openstack-horizon | 19:36 | |
| *** saksham has quit IRC | 19:42 | |
| *** jingjing_ren has joined #openstack-horizon | 19:47 | |
| *** ZZelle_ has joined #openstack-horizon | 19:50 | |
| david-lyle | djc__: the advice given in the keystone room is the correct advice. at least according to the log. If you remedy that and still see the error, come back. | 19:51 |
| djc__ | david-lyle I changed the backend and got rid of the cookie size error but the other error still persists. https://gist.github.com/anonymous/c306d05201c6708aa348 | 19:53 |
| openstackgerrit | Merged openstack/horizon: Add information for debugging Selenium tests https://review.openstack.org/221156 | 19:54 |
| david-lyle | djc_ what policy file are you using? | 19:55 |
| david-lyle | for keystone? | 19:55 |
| *** neelashah has quit IRC | 19:55 | |
| *** mhickey has joined #openstack-horizon | 19:57 | |
| *** crobertsrh has quit IRC | 19:59 | |
| *** crobertsrh has joined #openstack-horizon | 20:01 | |
| *** jtriley_ has quit IRC | 20:01 | |
| *** geoffarnold has quit IRC | 20:04 | |
| *** asahlin has joined #openstack-horizon | 20:04 | |
| openstackgerrit | Merged openstack/horizon: ESLint glob pattern not matching files for lint https://review.openstack.org/219010 | 20:04 |
| *** jbell8 has quit IRC | 20:07 | |
| *** djc__ has quit IRC | 20:10 | |
| *** tnovacik has joined #openstack-horizon | 20:11 | |
| *** jwy has joined #openstack-horizon | 20:12 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for Metadata Definitions https://review.openstack.org/215721 | 20:13 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 20:13 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 20:13 |
| *** kyleolivo has quit IRC | 20:15 | |
| *** kyleolivo has joined #openstack-horizon | 20:18 | |
| *** kyleolivo has quit IRC | 20:18 | |
| *** kyleolivo has joined #openstack-horizon | 20:19 | |
| *** kyleolivo has quit IRC | 20:20 | |
| *** kyleolivo has joined #openstack-horizon | 20:20 | |
| *** kyleolivo has quit IRC | 20:20 | |
| *** kyleolivo has joined #openstack-horizon | 20:21 | |
| *** kyleolivo has quit IRC | 20:21 | |
| openstackgerrit | Victor Stinner proposed openstack/horizon: TestCase: add aliases to assert methods on py3 https://review.openstack.org/220998 | 20:24 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Port horizon base tests to Python 3 https://review.openstack.org/220976 | 20:24 |
| *** jprovazn has joined #openstack-horizon | 20:24 | |
| *** rajatvig has quit IRC | 20:29 | |
| *** rajatvig has joined #openstack-horizon | 20:30 | |
| *** rajatvig has quit IRC | 20:30 | |
| *** rajatvig has joined #openstack-horizon | 20:30 | |
| *** doug-fis_ has joined #openstack-horizon | 20:30 | |
| *** exploreshaifali has quit IRC | 20:31 | |
| *** doug-fi__ has joined #openstack-horizon | 20:33 | |
| *** doug-fish has quit IRC | 20:34 | |
| *** yamamoto has joined #openstack-horizon | 20:34 | |
| *** doug-fis_ has quit IRC | 20:35 | |
| *** doug-fi__ has quit IRC | 20:37 | |
| *** ekarlso has quit IRC | 20:38 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Add Magic Search Filtering to NG Images https://review.openstack.org/217437 | 20:39 |
| *** yamamoto has quit IRC | 20:40 | |
| *** vgridnev has quit IRC | 20:40 | |
| *** jprovazn has quit IRC | 20:40 | |
| *** tjones has joined #openstack-horizon | 20:42 | |
| *** akrivoka has quit IRC | 20:43 | |
| *** sayan has quit IRC | 20:46 | |
| *** rbertram_ has quit IRC | 20:47 | |
| *** asahlin_ has quit IRC | 20:47 | |
| *** rajatvig has quit IRC | 20:48 | |
| *** vgridnev has joined #openstack-horizon | 20:53 | |
| *** rajatvig has joined #openstack-horizon | 20:54 | |
| *** jpomeroy_ has joined #openstack-horizon | 20:54 | |
| *** jpomeroy has quit IRC | 20:57 | |
| *** neelashah has joined #openstack-horizon | 20:58 | |
| *** geoffarnold has joined #openstack-horizon | 20:58 | |
| *** TravT_ is now known as TravT | 20:59 | |
| *** SimonChung1 has quit IRC | 21:00 | |
| *** SimonChung has joined #openstack-horizon | 21:00 | |
| *** aix has joined #openstack-horizon | 21:01 | |
| *** christophs has quit IRC | 21:03 | |
| *** pauloewerton has quit IRC | 21:04 | |
| *** saksham has joined #openstack-horizon | 21:08 | |
| *** crobertsrh is now known as _crobertsrh | 21:11 | |
| *** vgridnev has quit IRC | 21:13 | |
| *** kyleolivo has joined #openstack-horizon | 21:17 | |
| *** haypo has quit IRC | 21:20 | |
| *** rajatvig has quit IRC | 21:21 | |
| *** kyleolivo has quit IRC | 21:22 | |
| *** doug-fish has joined #openstack-horizon | 21:23 | |
| *** jingjing_ren has quit IRC | 21:23 | |
| *** doug-fish has quit IRC | 21:24 | |
| *** doug-fish has joined #openstack-horizon | 21:25 | |
| *** jingjing_ren has joined #openstack-horizon | 21:29 | |
| *** doug-fish has quit IRC | 21:29 | |
| *** vgridnev has joined #openstack-horizon | 21:31 | |
| *** rajatvig has joined #openstack-horizon | 21:32 | |
| *** pai15_ has quit IRC | 21:34 | |
| lhcheng | david-lyle: https://review.openstack.org/#/c/221222/ | 21:34 |
| lhcheng | david-lyle: fix the novaclient microversion | 21:35 |
| *** pai15 has joined #openstack-horizon | 21:35 | |
| lhcheng | *fixes | 21:35 |
| david-lyle | even better :) | 21:35 |
| * lhcheng still haven't got the chance to see if it does break anything | 21:35 | |
| lhcheng | glad someone already fixing it | 21:35 |
| *** cloudtrainme has quit IRC | 21:36 | |
| *** doug-fish has joined #openstack-horizon | 21:37 | |
| *** jingjing_ren has quit IRC | 21:37 | |
| *** devlaps has quit IRC | 21:38 | |
| *** pai15 has quit IRC | 21:39 | |
| *** cloudtrainme has joined #openstack-horizon | 21:43 | |
| *** lapalm has quit IRC | 21:43 | |
| *** vgridnev has quit IRC | 21:44 | |
| *** jbell8 has joined #openstack-horizon | 21:44 | |
| *** mhickey has quit IRC | 21:45 | |
| *** cloudtrainme has quit IRC | 21:46 | |
| *** christophs has joined #openstack-horizon | 21:46 | |
| *** christophs has joined #openstack-horizon | 21:46 | |
| *** darrenc_ is now known as darrenc | 21:47 | |
| *** kyleolivo has joined #openstack-horizon | 21:47 | |
| *** linkedinyou has joined #openstack-horizon | 21:50 | |
| *** jamielennox|away is now known as jamielennox | 21:51 | |
| *** cloudtrainme has joined #openstack-horizon | 21:52 | |
| *** tnovacik has quit IRC | 21:52 | |
| *** kyleolivo has quit IRC | 21:54 | |
| *** cloudtra_ has joined #openstack-horizon | 21:57 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP Adding Create Image Action to angular images panel https://review.openstack.org/217828 | 21:57 |
| *** linkedinyou has quit IRC | 21:59 | |
| *** doug-fish has quit IRC | 22:00 | |
| *** neelashah has quit IRC | 22:01 | |
| *** cloudtrainme has quit IRC | 22:01 | |
| *** jbell8 has quit IRC | 22:01 | |
| *** neelashah has joined #openstack-horizon | 22:01 | |
| *** mhickey has joined #openstack-horizon | 22:01 | |
| *** Ephur has joined #openstack-horizon | 22:01 | |
| *** Daisy has joined #openstack-horizon | 22:02 | |
| *** SimonChung1 has joined #openstack-horizon | 22:05 | |
| *** SimonChung has quit IRC | 22:05 | |
| *** Piet has quit IRC | 22:11 | |
| *** neelashah has quit IRC | 22:20 | |
| r1chardj0n3s | lhcheng: I understand you're involved with django-openstack-auth? could you please have a look at https://review.openstack.org/#/c/220382/? It will fix a couple of outstanding bugs in Horizon | 22:24 |
| openstackgerrit | Richard Jones proposed openstack/django_openstack_auth: Monkey-patch to avoid breaking Django with hash user.id https://review.openstack.org/220382 | 22:27 |
| *** stevemar has quit IRC | 22:29 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add volumes panel that uses angular.js https://review.openstack.org/216778 | 22:30 |
| *** neelashah has joined #openstack-horizon | 22:31 | |
| *** asahlin has quit IRC | 22:31 | |
| *** lblanchard has quit IRC | 22:31 | |
| *** asahlin has joined #openstack-horizon | 22:31 | |
| ducttape_ | does anyone recall active work around the project picker on top nav, how the check mark does not display well in safari? I have a fix, wondering if that is already underway with a bug etc | 22:32 |
| lhcheng | r1chardj0n3s: yeah, just a little bit. I starred it for review, juggling couple of things atm will try to review later in the evening or tom. | 22:35 |
| *** lblanchard has joined #openstack-horizon | 22:35 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Nav checkbox placement fix https://review.openstack.org/221535 | 22:35 |
| *** vijendar has quit IRC | 22:36 | |
| *** Sukhdev_ has joined #openstack-horizon | 22:36 | |
| *** lblanchard has quit IRC | 22:36 | |
| ducttape_ | hurgleburgler1 ^ not sure if this is bad / good css.... but it does fix stuff | 22:37 |
| ducttape_ | within chrome / ff / safari | 22:37 |
| hurgleburgler1 | There was a reason for the unsetting of the float, but lemme pull and test it out :) | 22:37 |
| ducttape_ | http://pasteboard.co/uQfG2Xi.png is what it looks like right now in safari | 22:38 |
| ducttape_ | which is not terrific | 22:38 |
| *** lblanchard has joined #openstack-horizon | 22:38 | |
| *** lblanchard has quit IRC | 22:38 | |
| hurgleburgler1 | that's unpleasant | 22:38 |
| *** lblanchard has joined #openstack-horizon | 22:39 | |
| ducttape_ | there is still some funky stuff when the project name starts to wrap / reaches it's length.... but that happens no matter what | 22:39 |
| ducttape_ | that is, the check box can follow on another line if your project name is just the right length | 22:40 |
| hurgleburgler1 | Its doing that correctly right now or it isn't? | 22:40 |
| hurgleburgler1 | the problem with floating it is that it is no longer vertically centered, I think | 22:40 |
| r1chardj0n3s | lhcheng: thanks | 22:41 |
| hurgleburgler1 | but, lemme pull it and take a look | 22:41 |
| *** mpavlase has quit IRC | 22:41 | |
| ducttape_ | http://pasteboard.co/uQvzEPc.png after my change hurgleburgler1 | 22:42 |
| ducttape_ | hurgleburgler1 - if you name gets longer, wrapping is not super great with either solution, but that can follow on with a later patch. I just want safari so it is not embarrassingly broken | 22:43 |
| *** lblanchard has quit IRC | 22:43 | |
| ducttape_ | "you name " -> "the project name" | 22:43 |
| ducttape_ | and hurgleburgler1, you can ammend my patch all you like if you have a better fix, I take no offense | 22:44 |
| hurgleburgler1 | understood, looking now | 22:44 |
| *** Daisy has quit IRC | 22:45 | |
| *** cloudtra_ has quit IRC | 22:45 | |
| *** Daisy has joined #openstack-horizon | 22:45 | |
| david-lyle | safari, the next IE | 22:45 |
| ducttape_ | the other css nit would be around the role membership screen too, that screen needs help if you have roles with more than like 8-10 characters | 22:47 |
| *** Daisy has quit IRC | 22:49 | |
| *** mhickey has quit IRC | 22:51 | |
| *** ducttape_ has quit IRC | 22:53 | |
| *** asahlin has quit IRC | 22:54 | |
| *** asahlin has joined #openstack-horizon | 22:55 | |
| *** asahlin has quit IRC | 22:59 | |
| *** Piet has joined #openstack-horizon | 23:00 | |
| *** asahlin has joined #openstack-horizon | 23:05 | |
| *** stevemar has joined #openstack-horizon | 23:07 | |
| *** jbell8 has joined #openstack-horizon | 23:10 | |
| *** ZZelle_ has quit IRC | 23:14 | |
| *** Sukhdev_ has quit IRC | 23:17 | |
| *** erlon has quit IRC | 23:18 | |
| *** Sukhdev has joined #openstack-horizon | 23:19 | |
| *** jpomeroy_ has quit IRC | 23:20 | |
| *** chlong has quit IRC | 23:27 | |
| *** chlong has joined #openstack-horizon | 23:28 | |
| *** yamamoto has joined #openstack-horizon | 23:30 | |
| *** yamamoto has quit IRC | 23:31 | |
| *** TravT has quit IRC | 23:36 | |
| *** Sukhdev has quit IRC | 23:38 | |
| *** TravT has joined #openstack-horizon | 23:39 | |
| *** Sukhdev has joined #openstack-horizon | 23:40 | |
| *** asahlin has quit IRC | 23:52 | |
| *** asahlin has joined #openstack-horizon | 23:52 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding row action to delete single image to angular images panel https://review.openstack.org/217949 | 23:54 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Adding multiple row actions for the Image table https://review.openstack.org/217964 | 23:54 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Launch Instance Modal should be exist as a Service https://review.openstack.org/220214 | 23:54 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding action to delete multiple images to angular images panel https://review.openstack.org/217422 | 23:54 |
| *** Drago has quit IRC | 23:54 | |
| *** ybathia has quit IRC | 23:55 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Dashboard Panels should not include custom/styles https://review.openstack.org/218941 | 23:56 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Move humanize and truncate to horizon.quota.js https://review.openstack.org/207549 | 23:56 |
| *** asahlin has quit IRC | 23:57 | |
| *** asahlin has joined #openstack-horizon | 23:58 | |
| *** rajatvig has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
