| *** jcoufal has quit IRC | 00:02 | |
| *** lhcheng has quit IRC | 00:05 | |
| *** ericpeterson has quit IRC | 00:06 | |
| *** alexvictorchan has quit IRC | 00:08 | |
| *** nlahouti has quit IRC | 00:23 | |
| *** nlahouti has joined #openstack-horizon | 00:25 | |
| *** nlahouti has quit IRC | 00:26 | |
| *** Longgeek has joined #openstack-horizon | 00:27 | |
| *** nlahouti has joined #openstack-horizon | 00:30 | |
| *** jcoufal_ has quit IRC | 00:31 | |
| *** alexvictorchan has joined #openstack-horizon | 00:35 | |
| openstackgerrit | Merged openstack/horizon: Fixes error message during volume snapshot creation https://review.openstack.org/156110 | 00:36 |
|---|---|---|
| *** neillc is now known as neillc_afk | 00:39 | |
| *** ramishra_ has joined #openstack-horizon | 00:44 | |
| *** alexvictorchan has quit IRC | 00:44 | |
| *** alexvictorchan has joined #openstack-horizon | 00:58 | |
| *** Longgeek has quit IRC | 01:00 | |
| *** ramishra_ has quit IRC | 01:02 | |
| *** ramishra_ has joined #openstack-horizon | 01:05 | |
| *** ramishra_ has quit IRC | 01:05 | |
| *** ramishra_ has joined #openstack-horizon | 01:06 | |
| *** ramishra_ has quit IRC | 01:06 | |
| *** ramishra_ has joined #openstack-horizon | 01:07 | |
| *** ramishra_ has quit IRC | 01:08 | |
| *** ramishra_ has joined #openstack-horizon | 01:12 | |
| *** jamielennox is now known as jamielennox|away | 01:16 | |
| *** nlahouti has quit IRC | 01:27 | |
| *** Longgeek has joined #openstack-horizon | 01:28 | |
| *** Longgeek has quit IRC | 01:28 | |
| *** nlahouti has joined #openstack-horizon | 01:28 | |
| *** nlahouti has quit IRC | 01:29 | |
| *** Longgeek has joined #openstack-horizon | 01:30 | |
| *** jamielennox|away is now known as jamielennox | 01:31 | |
| *** nlahouti has joined #openstack-horizon | 01:36 | |
| *** amerine has joined #openstack-horizon | 01:37 | |
| *** Piet has joined #openstack-horizon | 01:38 | |
| *** jamielennox is now known as jamielennox|away | 01:41 | |
| *** alexvictorchan has quit IRC | 01:45 | |
| *** iamjarvo has joined #openstack-horizon | 01:51 | |
| *** iamjarvo has quit IRC | 01:51 | |
| *** iamjarvo has joined #openstack-horizon | 01:51 | |
| *** amerine has quit IRC | 02:01 | |
| *** sqchen has left #openstack-horizon | 02:01 | |
| *** nlahouti has quit IRC | 02:07 | |
| *** jamielennox|away is now known as jamielennox | 02:09 | |
| *** alanf-mc has quit IRC | 02:18 | |
| *** lhcheng has joined #openstack-horizon | 02:20 | |
| *** lhcheng has quit IRC | 02:25 | |
| *** ramishra_ has quit IRC | 02:30 | |
| *** ramishra_ has joined #openstack-horizon | 02:31 | |
| *** ramishra_ has quit IRC | 02:43 | |
| *** ramishra_ has joined #openstack-horizon | 02:53 | |
| *** amerine has joined #openstack-horizon | 03:01 | |
| *** tqtran has quit IRC | 03:02 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Serial Console https://review.openstack.org/144659 | 03:13 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Glance Rest API for Angular Front End https://review.openstack.org/151468 | 03:19 |
| *** ccard_ has joined #openstack-horizon | 03:31 | |
| *** alexvictorchan has joined #openstack-horizon | 03:34 | |
| *** ccard has quit IRC | 03:34 | |
| *** lhcheng has joined #openstack-horizon | 03:38 | |
| *** alexvictorchan has quit IRC | 03:41 | |
| *** amotoki_ has joined #openstack-horizon | 03:43 | |
| *** amotoki_ has quit IRC | 03:45 | |
| *** amerine has quit IRC | 03:46 | |
| *** ccard_ has quit IRC | 03:53 | |
| *** ccard_ has joined #openstack-horizon | 03:57 | |
| *** lhcheng has quit IRC | 04:00 | |
| *** Longgeek has quit IRC | 04:04 | |
| *** ramishra_ has quit IRC | 04:08 | |
| *** nlahouti has joined #openstack-horizon | 04:19 | |
| *** neillc_afk is now known as neillc | 04:20 | |
| *** ramishra_ has joined #openstack-horizon | 04:20 | |
| *** nikunj2512 has joined #openstack-horizon | 04:23 | |
| *** nlahouti has quit IRC | 04:23 | |
| *** nlahouti has joined #openstack-horizon | 04:23 | |
| *** ccard_ has quit IRC | 04:31 | |
| *** ccard_ has joined #openstack-horizon | 04:36 | |
| *** ccard__ has joined #openstack-horizon | 04:48 | |
| *** ccard_ has quit IRC | 04:50 | |
| *** tzumainn has quit IRC | 04:53 | |
| *** radez is now known as radez_g0n3 | 05:01 | |
| *** lhcheng has joined #openstack-horizon | 05:11 | |
| *** ccard__ has quit IRC | 05:15 | |
| *** masco has joined #openstack-horizon | 05:15 | |
| *** devlaps has quit IRC | 05:16 | |
| *** ccard__ has joined #openstack-horizon | 05:16 | |
| *** lhcheng has quit IRC | 05:18 | |
| *** sayan has joined #openstack-horizon | 05:18 | |
| *** iamjarvo has quit IRC | 05:21 | |
| *** rushiagr_away is now known as rushiagr | 05:23 | |
| *** ccard__ has quit IRC | 05:24 | |
| *** ccard__ has joined #openstack-horizon | 05:24 | |
| *** jrist is now known as jrist-afk | 05:26 | |
| *** ramishra_ has quit IRC | 05:27 | |
| *** ramishra_ has joined #openstack-horizon | 05:41 | |
| *** pcaruana has quit IRC | 05:47 | |
| *** sayan has quit IRC | 05:54 | |
| *** ramishra_ has quit IRC | 05:57 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 05:58 | |
| *** jcoufal has joined #openstack-horizon | 06:05 | |
| *** ramishra_ has joined #openstack-horizon | 06:06 | |
| *** ybathia has joined #openstack-horizon | 06:08 | |
| *** _gryf has joined #openstack-horizon | 06:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/156478 | 06:11 |
| *** ishant has joined #openstack-horizon | 06:12 | |
| *** ccard_ has joined #openstack-horizon | 06:13 | |
| *** ccard__ has quit IRC | 06:14 | |
| *** ramishra_ has quit IRC | 06:34 | |
| openstackgerrit | Wu Wenxiang proposed openstack/horizon: Make values for IPSec&VPN status be translatable https://review.openstack.org/152889 | 06:44 |
| *** Guest51132 has joined #openstack-horizon | 06:51 | |
| *** sayan_ has joined #openstack-horizon | 06:52 | |
| *** lhcheng has joined #openstack-horizon | 07:06 | |
| *** lhcheng has quit IRC | 07:08 | |
| *** mrunge has joined #openstack-horizon | 07:23 | |
| *** oro has joined #openstack-horizon | 07:28 | |
| *** ZZelle has quit IRC | 07:32 | |
| *** ZZelle has joined #openstack-horizon | 07:32 | |
| *** ramishra_ has joined #openstack-horizon | 07:35 | |
| *** rdopiera has joined #openstack-horizon | 07:36 | |
| *** stevemar has quit IRC | 07:38 | |
| *** Ala has joined #openstack-horizon | 07:40 | |
| *** rdopiera has quit IRC | 07:40 | |
| *** rdopiera has joined #openstack-horizon | 07:40 | |
| *** ramishra_ has quit IRC | 07:40 | |
| *** mpavlase has joined #openstack-horizon | 07:41 | |
| *** jprovazn has joined #openstack-horizon | 07:42 | |
| *** nlahouti1 has joined #openstack-horizon | 07:42 | |
| *** mpavlase has quit IRC | 07:42 | |
| *** nlahouti has quit IRC | 07:44 | |
| *** nlahouti1 has quit IRC | 07:46 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Allow adding to INSTALLED_APPS from local_settings.py https://review.openstack.org/107747 | 07:47 |
| *** dkorn has joined #openstack-horizon | 07:54 | |
| *** Ala has quit IRC | 07:56 | |
| *** rm_work is now known as rm_work|away | 07:57 | |
| openstackgerrit | Wu Wenxiang proposed openstack/horizon: Make values for IPSec&VPN status be translatable https://review.openstack.org/152889 | 07:58 |
| *** Ala has joined #openstack-horizon | 08:01 | |
| *** oro has quit IRC | 08:08 | |
| *** fifieldt has joined #openstack-horizon | 08:09 | |
| *** chlong has quit IRC | 08:11 | |
| *** lhcheng has joined #openstack-horizon | 08:12 | |
| *** jtomasek has joined #openstack-horizon | 08:14 | |
| *** markus_z has joined #openstack-horizon | 08:15 | |
| *** cody-somerville has quit IRC | 08:19 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Wait till spinner disappears https://review.openstack.org/151608 | 08:27 |
| *** ybathia has quit IRC | 08:28 | |
| *** ybathia has joined #openstack-horizon | 08:29 | |
| *** bluex-pl has joined #openstack-horizon | 08:29 | |
| *** bluex-pl has quit IRC | 08:30 | |
| *** bluex-pl has joined #openstack-horizon | 08:30 | |
| *** ramishra_ has joined #openstack-horizon | 08:36 | |
| *** ybathia has quit IRC | 08:38 | |
| *** ramishra_ has quit IRC | 08:41 | |
| *** MaxV has joined #openstack-horizon | 08:43 | |
| *** lhcheng has quit IRC | 08:44 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:49 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:52 | |
| *** mwhagedorn has quit IRC | 08:55 | |
| *** cody-somerville has joined #openstack-horizon | 08:56 | |
| *** fifieldt has quit IRC | 08:56 | |
| *** Ala has quit IRC | 09:10 | |
| *** akrivoka has joined #openstack-horizon | 09:10 | |
| *** Ala has joined #openstack-horizon | 09:12 | |
| *** Ala has quit IRC | 09:12 | |
| *** Ala has joined #openstack-horizon | 09:13 | |
| *** aix has quit IRC | 09:21 | |
| *** ygbo has joined #openstack-horizon | 09:22 | |
| openstackgerrit | Ekaterina Chernova proposed openstack/horizon: Remove test skipping since #1396954 was fixed https://review.openstack.org/156353 | 09:22 |
| *** mpavlase has joined #openstack-horizon | 09:23 | |
| *** dsneddon has quit IRC | 09:30 | |
| *** mwhagedorn has joined #openstack-horizon | 09:38 | |
| *** oro has joined #openstack-horizon | 09:38 | |
| *** regebro has joined #openstack-horizon | 09:42 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Add project-dropdown https://review.openstack.org/151638 | 09:46 |
| *** e0ne has joined #openstack-horizon | 09:48 | |
| *** aix has joined #openstack-horizon | 09:48 | |
| *** tosky has joined #openstack-horizon | 09:54 | |
| *** robcresswell_afk is now known as robcresswell | 09:56 | |
| robcresswell | Morning all | 09:57 |
| *** oro has quit IRC | 10:00 | |
| *** aix has quit IRC | 10:05 | |
| *** aix has joined #openstack-horizon | 10:17 | |
| sambetts | Morning morning | 10:18 |
| openstackgerrit | Sam Betts proposed openstack/horizon: Reduce title duplication in project networking https://review.openstack.org/154595 | 10:19 |
| *** e0ne is now known as e0ne_ | 10:21 | |
| *** e0ne_ has quit IRC | 10:26 | |
| *** e0ne has joined #openstack-horizon | 10:38 | |
| *** krykowski has joined #openstack-horizon | 10:38 | |
| *** ramishra_ has joined #openstack-horizon | 10:38 | |
| openstackgerrit | Merged openstack/tuskar-ui: Use the newest and greatest Hacking https://review.openstack.org/155734 | 10:39 |
| openstackgerrit | Merged openstack/tuskar-ui: Do not display warnings for unused roles https://review.openstack.org/155803 | 10:39 |
| *** oro has joined #openstack-horizon | 10:41 | |
| *** sayan_ has quit IRC | 10:42 | |
| *** ramishra_ has quit IRC | 10:43 | |
| *** Ala has quit IRC | 10:54 | |
| *** sayan_ has joined #openstack-horizon | 10:55 | |
| *** JeanBriceCombebi has quit IRC | 10:56 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:56 | |
| dkorn | david-lyle: a few weeks ago you marked few integration tests patches as abandoned after they weren't updated more than 4 weeks | 10:58 |
| dkorn | david-lyle: the contributors didn't reactivate them till now and I wonder if it's OK if I'll rewrite them in new patches | 10:58 |
| dkorn | david-lyle: I've sent them emails in the past and usually takes more than a week to get an answer if at all | 10:59 |
| *** jcoufal_ has joined #openstack-horizon | 11:00 | |
| *** e0ne has quit IRC | 11:01 | |
| *** oro has quit IRC | 11:01 | |
| *** e0ne has joined #openstack-horizon | 11:02 | |
| *** jcoufal has quit IRC | 11:03 | |
| *** JeanBriceCombebi has quit IRC | 11:12 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 11:13 | |
| *** e0ne has quit IRC | 11:24 | |
| *** e0ne has joined #openstack-horizon | 11:25 | |
| openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Sahara] Fix Node Group Templates copy https://review.openstack.org/156551 | 11:28 |
| *** ramishra_ has joined #openstack-horizon | 11:39 | |
| robcresswell | dkorn: Have you tried reaching them through colleagues/irc also? Normally its okay to take over patches that dont have much activity | 11:42 |
| robcresswell | As long as they are given some notice | 11:42 |
| *** ramishra_ has quit IRC | 11:43 | |
| *** Ala has joined #openstack-horizon | 11:44 | |
| *** e0ne is now known as e0ne_ | 11:44 | |
| dkorn | robcresswell: the ones I'm referring to are not on irc. I sent the emails in the past but if they answer it's after a while and usually say they'll fix the patch in the future but can take several weeks | 11:45 |
| dkorn | robcresswell: like in this case when it took more than 4 weeks before david made those patches abandoned | 11:46 |
| dkorn | robcresswell: since than 3 weeks have passed and still no update | 11:46 |
| dkorn | robcresswell: I don't mean to step into other contributors place, but those patches blocks us from moving on with other patches | 11:47 |
| dkorn | robcresswell: might co-author in the commit message be a solution? | 11:48 |
| sambetts | its an interesting topic | 11:48 |
| robcresswell | dkorn: If you've asked them to look into it, and its now been ~2 months since any work, I would say take it over. You should definitely list the original contributor as a co-author. | 11:48 |
| robcresswell | dkorn: We have to be as diplomatic as possible, but can't stop progress for the sake of being nice :) | 11:49 |
| sambetts | it might be something to bring up in the next IRC meeting because it effects everyuone | 11:49 |
| robcresswell | It was brought up last week with a patch that hadn't been worked on before - consensus at the time was to ask permission and then go ahead :) | 11:50 |
| robcresswell | But yes, would check with one of the cores | 11:50 |
| dkorn | thanks robcresswell, I agree | 11:50 |
| *** e0ne_ has quit IRC | 11:54 | |
| *** yingjun has joined #openstack-horizon | 11:55 | |
| *** e0ne has joined #openstack-horizon | 11:55 | |
| *** krykowski has quit IRC | 11:58 | |
| *** krykowski has joined #openstack-horizon | 11:58 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/156478 | 11:58 |
| mrunge | dkorn, do you have links to reviews handy? I can abandon those patches, too | 12:00 |
| openstackgerrit | Merged openstack/horizon: Revert "Fix shared firewall policy can not be displayed in horizon" https://review.openstack.org/156061 | 12:01 |
| dkorn | mrunge: https://review.openstack.org/#/c/99329/10, https://review.openstack.org/#/c/101169/ | 12:05 |
| mrunge | dkorn, they are abandoned | 12:06 |
| mrunge | dkorn, david-lyle abandoned them on Jan 27th | 12:06 |
| dkorn | mrunge: I know, that's where I started my question to david | 12:07 |
| dkorn | mrunge: since I wasn't sure it's OK to take over them | 12:07 |
| mrunge | dkorn, if nobody came up with a new patch, then I'd assume, nobody is interested | 12:07 |
| mrunge | dkorn, I'd say, go ahead | 12:08 |
| dkorn | mrunge: will do, thanks. anyway, I'll add a co-author :) | 12:08 |
| *** e0ne is now known as e0ne_ | 12:19 | |
| amotoki | We have Login twice problem again after the security fix https://bugs.launchpad.net/horizon/+bug/1394370 ? | 12:22 |
| openstack | Launchpad bug 1394370 in OpenStack Dashboard (Horizon) juno "[OSSA 2014-040] horizon login page is vulnerable to DOS attack (CVE-2014-8124)" [Undecided,Fix committed] - Assigned to Tristan Cacqueray (tristan-cacqueray) | 12:22 |
| amotoki | Does anyone have the idea on how to fix this? | 12:22 |
| mrunge | amotoki yes | 12:23 |
| *** e0ne_ is now known as e0ne | 12:23 | |
| mrunge | there is a fix for django-openstack-auth | 12:23 |
| mrunge | amotoki, cherry-pick this commit: https://github.com/openstack/django_openstack_auth/commit/d5ba1a2dd99cc894ca230cae048746c64a49b7c4 | 12:24 |
| mrunge | amotoki, for reference, the bug is 1403037 | 12:25 |
| mrunge | (in launchpad) | 12:25 |
| amotoki | mrunge: thanks. | 12:26 |
| amotoki | mrunge: I see double logic problem in ubuntu cloud-archive Juno. They seem have only security update for Juno :-( | 12:30 |
| *** jprovazn has quit IRC | 12:30 | |
| mrunge | amotoki, they would need an update for django_openstack_auth as well. | 12:30 |
| mrunge | amotoki, in our case, I cherry-picked the fix to django-openstack-auth-1.1.7 | 12:31 |
| mrunge | but this won't help you here... | 12:32 |
| amotoki | mrunge: it sounds an reasonable approach. | 12:32 |
| amotoki | mrunge: I was just asked on this and am now cheking cloud-archive sources. | 12:32 |
| mrunge | amotoki, if you're a customer there, you should open a bug report, pointing to github | 12:34 |
| *** mwhagedorn has quit IRC | 12:35 | |
| amotoki | mrunge: yes, of course. I am a bit out-of-date on openstack-auth and in addition when I ran devstack I forgot to update django-openstack-auth :-( | 12:36 |
| *** masco has quit IRC | 12:37 | |
| *** oro has joined #openstack-horizon | 12:38 | |
| *** ramishra_ has joined #openstack-horizon | 12:40 | |
| *** lblanchard has joined #openstack-horizon | 12:40 | |
| *** rushiagr is now known as rushiagr_away | 12:41 | |
| *** ramishra_ has quit IRC | 12:44 | |
| *** ishant has quit IRC | 12:45 | |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Stop memoising on request arguments https://review.openstack.org/150392 | 12:56 |
| *** sseago has quit IRC | 13:02 | |
| *** sseago has joined #openstack-horizon | 13:03 | |
| *** JeanBriceCombebi has quit IRC | 13:04 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:06 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 13:08 |
| *** jprovazn has joined #openstack-horizon | 13:14 | |
| *** ericpeterson has joined #openstack-horizon | 13:17 | |
| *** JeanBriceCombebi has quit IRC | 13:17 | |
| *** ericpeterson has quit IRC | 13:20 | |
| *** sseago has quit IRC | 13:22 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:22 | |
| *** sseago has joined #openstack-horizon | 13:24 | |
| *** jtomasek has quit IRC | 13:29 | |
| *** oro_ has joined #openstack-horizon | 13:39 | |
| *** tzumainn has joined #openstack-horizon | 13:40 | |
| *** ramishra_ has joined #openstack-horizon | 13:40 | |
| *** ramishra_ has quit IRC | 13:45 | |
| *** _crobertsrh is now known as crobertsrh | 13:47 | |
| *** jtomasek has joined #openstack-horizon | 13:48 | |
| *** amotoki has quit IRC | 13:49 | |
| *** HenryG has quit IRC | 13:49 | |
| *** iamjarvo has joined #openstack-horizon | 13:49 | |
| *** iamjarvo has quit IRC | 13:50 | |
| *** iamjarvo has joined #openstack-horizon | 13:50 | |
| *** HenryG has joined #openstack-horizon | 13:52 | |
| *** amotoki has joined #openstack-horizon | 13:54 | |
| *** amotoki has quit IRC | 13:54 | |
| *** radez_g0n3 is now known as radez | 13:56 | |
| *** e0ne is now known as e0ne_ | 13:56 | |
| *** iamjarvo has quit IRC | 13:56 | |
| *** e0ne_ is now known as e0ne | 14:00 | |
| *** trown|outttypeww is now known as trown | 14:02 | |
| *** ayoung has joined #openstack-horizon | 14:12 | |
| *** _gryf is now known as gryf|afk | 14:15 | |
| *** gryf|afk has quit IRC | 14:20 | |
| *** gerchardon has joined #openstack-horizon | 14:21 | |
| *** JeanBriceCombebi has quit IRC | 14:23 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:23 | |
| *** peristeri has joined #openstack-horizon | 14:27 | |
| *** Piet has quit IRC | 14:28 | |
| *** mwhagedorn has joined #openstack-horizon | 14:32 | |
| *** mwhagedorn has quit IRC | 14:36 | |
| *** nikunj2512 has quit IRC | 14:37 | |
| *** rushiagr_away is now known as rushiagr | 14:37 | |
| *** ramishra_ has joined #openstack-horizon | 14:39 | |
| *** JeanBriceCombebi has quit IRC | 14:40 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:40 | |
| *** mwhagedorn has joined #openstack-horizon | 14:42 | |
| *** ramishra_ has quit IRC | 14:43 | |
| openstackgerrit | Daniel Korn proposed openstack/horizon: Security groups page and test https://review.openstack.org/156604 | 14:47 |
| *** mwhagedorn has quit IRC | 14:48 | |
| *** jtriley has joined #openstack-horizon | 14:53 | |
| openstackgerrit | Merged openstack/horizon: Add horizon.cookies.getRaw to access raw cookie values https://review.openstack.org/156146 | 14:54 |
| *** dboik has joined #openstack-horizon | 14:55 | |
| *** freerunner has joined #openstack-horizon | 14:55 | |
| *** iamjarvo has joined #openstack-horizon | 14:56 | |
| *** iamjarvo has quit IRC | 14:56 | |
| *** iamjarvo has joined #openstack-horizon | 14:57 | |
| *** rebelagentm has joined #openstack-horizon | 15:03 | |
| *** vijendar has joined #openstack-horizon | 15:04 | |
| *** ericpeterson has joined #openstack-horizon | 15:05 | |
| *** neelashah has joined #openstack-horizon | 15:06 | |
| *** e0ne is now known as e0ne_ | 15:07 | |
| *** amotoki has joined #openstack-horizon | 15:07 | |
| *** e0ne_ is now known as e0ne | 15:08 | |
| *** absubram has joined #openstack-horizon | 15:09 | |
| robcresswell | david-lyle: Holy moly, some serious review pace | 15:13 |
| *** rm_work|away is now known as rm_work | 15:18 | |
| *** stevemar has joined #openstack-horizon | 15:28 | |
| *** nlahouti has joined #openstack-horizon | 15:30 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Common Detail template & html cleanup https://review.openstack.org/151762 | 15:34 |
| *** nlahouti has quit IRC | 15:34 | |
| *** fischerw has joined #openstack-horizon | 15:39 | |
| *** jprovazn has quit IRC | 15:39 | |
| *** jtomasek has quit IRC | 15:51 | |
| *** jtomasek has joined #openstack-horizon | 15:55 | |
| openstackgerrit | Merged openstack/horizon: Reduce title duplication in project networking https://review.openstack.org/154595 | 15:55 |
| openstackgerrit | Merged openstack/horizon: Allow adding to INSTALLED_APPS from local_settings.py https://review.openstack.org/107747 | 15:55 |
| openstackgerrit | Merged openstack/horizon: Remove test skipping since #1396954 was fixed https://review.openstack.org/156353 | 15:55 |
| openstackgerrit | Merged openstack/tuskar-ui: Use the default kernel and ramdisk images in suggested flavor https://review.openstack.org/156216 | 15:58 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Pie and donut chart directive https://review.openstack.org/146934 | 16:00 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Pie/Donut Chart Directive https://review.openstack.org/154160 | 16:01 |
| *** jtomasek has quit IRC | 16:02 | |
| *** neelashah has quit IRC | 16:02 | |
| *** bpokorny has quit IRC | 16:05 | |
| *** dkorn has quit IRC | 16:07 | |
| *** jtriley has quit IRC | 16:08 | |
| *** jtriley has joined #openstack-horizon | 16:09 | |
| *** e0ne has quit IRC | 16:09 | |
| *** neelashah has joined #openstack-horizon | 16:10 | |
| *** sayan_ has quit IRC | 16:10 | |
| openstackgerrit | Merged openstack/horizon: Add missing stubs to project stacks tests https://review.openstack.org/154929 | 16:12 |
| *** amotoki has quit IRC | 16:13 | |
| openstackgerrit | Merged openstack/horizon: Stack resources table improvement https://review.openstack.org/150411 | 16:13 |
| openstackgerrit | Merged openstack/horizon: Reduce page title duplication in settings and test https://review.openstack.org/154602 | 16:13 |
| *** yingjun_ has joined #openstack-horizon | 16:13 | |
| openstackgerrit | Merged openstack/horizon: Reduce page title duplication in Admin Hypervisors https://review.openstack.org/154509 | 16:13 |
| openstackgerrit | Merged openstack/horizon: Reduce page title duplication in databases https://review.openstack.org/154588 | 16:13 |
| openstackgerrit | Merged openstack/horizon: Refactor modal forms for Subnets https://review.openstack.org/156285 | 16:14 |
| openstackgerrit | Merged openstack/horizon: Refactor modal forms for Nexus1000v https://review.openstack.org/156302 | 16:14 |
| openstackgerrit | Merged openstack/horizon: Make the values of Cluster status be translatable https://review.openstack.org/152948 | 16:14 |
| *** bpokorny has joined #openstack-horizon | 16:15 | |
| *** jtomasek has joined #openstack-horizon | 16:16 | |
| *** yingjun has quit IRC | 16:17 | |
| fischerw | david-lyle: If you get a chance, can you take a look at https://review.openstack.org/#/c/145870/? I have made the changes you had suggested. | 16:18 |
| *** Piet has joined #openstack-horizon | 16:18 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Pie and donut chart directive https://review.openstack.org/146934 | 16:18 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Pie/Donut Chart Directive https://review.openstack.org/154160 | 16:18 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Refactor modal forms for Routers https://review.openstack.org/155815 | 16:23 |
| *** my_rudzha_userna has joined #openstack-horizon | 16:24 | |
| *** jtomasek has quit IRC | 16:26 | |
| *** jtomasek has joined #openstack-horizon | 16:28 | |
| *** SimonChung1 has quit IRC | 16:30 | |
| *** jrist-afk is now known as jrist | 16:31 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Raw Output Demo for Glance API https://review.openstack.org/155556 | 16:31 |
| *** ramishra_ has joined #openstack-horizon | 16:31 | |
| *** amerine has joined #openstack-horizon | 16:31 | |
| *** rdopiera has quit IRC | 16:32 | |
| *** alexvictorchan has joined #openstack-horizon | 16:33 | |
| openstackgerrit | Merged openstack/horizon: Reduce page title duplication in A and S views https://review.openstack.org/154579 | 16:35 |
| *** gerchardon has quit IRC | 16:37 | |
| *** nlahouti has joined #openstack-horizon | 16:38 | |
| *** my_rudzha_userna is now known as my_openstack_use | 16:39 | |
| *** regebro has quit IRC | 16:40 | |
| *** bluex-pl has quit IRC | 16:41 | |
| *** Ephur has quit IRC | 16:46 | |
| esp | ping david-lyle | 16:46 |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 16:51 |
| *** rwsu has joined #openstack-horizon | 16:52 | |
| *** markus_z has quit IRC | 16:53 | |
| *** regebro has joined #openstack-horizon | 16:55 | |
| *** lhcheng has joined #openstack-horizon | 16:57 | |
| *** ttrifonov is now known as zz_ttrifonov | 16:58 | |
| esp | for anyone tracking the domain scoped token work we are keeping track of bugs here https://etherpad.openstack.org/p/Horizon_Presidents_Day_Bugs | 16:59 |
| esp | work is in this patch https://review.openstack.org/#/c/148082/ | 16:59 |
| *** cbader has joined #openstack-horizon | 17:00 | |
| *** doug-fish has joined #openstack-horizon | 17:00 | |
| *** krykowski has quit IRC | 17:00 | |
| *** jcoufal_ has quit IRC | 17:06 | |
| *** Piet has quit IRC | 17:07 | |
| *** ramishra_ has quit IRC | 17:10 | |
| *** ygbo has quit IRC | 17:11 | |
| *** Ala has quit IRC | 17:11 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Raw Output Demo for Glance API https://review.openstack.org/155556 | 17:16 |
| david-lyle | back, what did I miss? | 17:19 |
| *** JeanBriceCombebi has quit IRC | 17:19 | |
| *** iamjarvo has quit IRC | 17:20 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Help text clarification for data processing data sources https://review.openstack.org/156669 | 17:20 |
| david-lyle | esp: pong | 17:24 |
| esp | hey dude | 17:28 |
| david-lyle | robcresswell: 2 line changes and sambetts title changes help speed things up | 17:28 |
| *** dboik_ has joined #openstack-horizon | 17:28 | |
| david-lyle | esp: what's up? | 17:28 |
| *** mpavlase has quit IRC | 17:28 | |
| esp | david-lyle: just wanted to give ya an update | 17:29 |
| david-lyle | shoot | 17:29 |
| *** rushiagr is now known as rushiagr_away | 17:29 | |
| *** dboik_ has quit IRC | 17:29 | |
| esp | david-lyle: we are attacking that bug list https://etherpad.openstack.org/p/Horizon_Presidents_Day_Bugs | 17:29 |
| esp | hope to get most of it shaken out by the end of the week | 17:30 |
| *** dboik_ has joined #openstack-horizon | 17:30 | |
| esp | you were correct that we will need to use a project scoped token in some cases | 17:30 |
| esp | so I’m working on that now | 17:30 |
| david-lyle | cool, looked at the etherpad | 17:32 |
| *** dboik has quit IRC | 17:32 | |
| david-lyle | a little hard to follow | 17:32 |
| david-lyle | but I think System is the panel group? | 17:33 |
| esp | david-lyle: sorry | 17:33 |
| esp | it its a bit kludgy | 17:33 |
| david-lyle | no worries, just making sure I comprehend | 17:33 |
| david-lyle | for project dash, project scoped identity token makes sense | 17:34 |
| esp | david-lyle: System is the System Dashboard | 17:34 |
| david-lyle | there is no system dashboard | 17:34 |
| david-lyle | Admin? | 17:34 |
| esp | yeah | 17:34 |
| esp | Admin —> System | 17:34 |
| esp | sorry | 17:35 |
| esp | lol | 17:35 |
| david-lyle | esp, you're going back in time | 17:35 |
| esp | yeah I tend to live in the past ;) | 17:35 |
| david-lyle | hmm | 17:35 |
| david-lyle | is project scoped token right for that? | 17:35 |
| david-lyle | the problem is the keystone api call you're making | 17:36 |
| esp | not sure yet | 17:36 |
| esp | right | 17:36 |
| david-lyle | let me look at the policy file | 17:37 |
| esp | for bugs 8 - 12, I need to allow for passing a project scoped token | 17:37 |
| esp | but for bugs 1-7, I haven’t looked that closely yet | 17:37 |
| *** rushiagr_away is now known as rushiagr | 17:37 | |
| david-lyle | list projects should be right | 17:37 |
| *** e0ne has joined #openstack-horizon | 17:38 | |
| david-lyle | "identity:list_projects": "rule:cloud_admin or rule:admin_and_matching_domain_id", | 17:38 |
| david-lyle | domain id's just need to match | 17:38 |
| esp | yeah, I think we’d just need to make sure the list_project calls outside of the Identity dash are sending a domain id | 17:38 |
| david-lyle | yeah, let me look | 17:39 |
| esp | but this is the sucker that will require a project scoped token "admin_on_project_filter" : "rule:cloud_admin or (rule:admin_required and project_id:%(scope.project.id)s)", | 17:39 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/policy_backend.py#L120 | 17:39 |
| david-lyle | which one is that? | 17:39 |
| esp | that one is for listing roles | 17:40 |
| esp | "admin_on_project_filter" : "rule:cloud_admin or (rule:admin_required and project_id:%(scope.project.id)s)", | 17:40 |
| *** jprovazn has joined #openstack-horizon | 17:42 | |
| david-lyle | well doesn't "identity:list_role_assignments": "rule:admin_on_domain_filter or rule:admin_on_project_filter", handle the domain scoped version | 17:42 |
| david-lyle | that seems to be the only place it's used | 17:42 |
| *** oro_ has quit IRC | 17:42 | |
| david-lyle | I guess there will be condition | 17:42 |
| *** oro has quit IRC | 17:43 | |
| david-lyle | since you my only have a project scoped token | 17:43 |
| esp | yeah, I will have get project token on the fly | 17:44 |
| david-lyle | you have both | 17:44 |
| david-lyle | just have to pick which to use | 17:45 |
| david-lyle | if domain = None use project | 17:45 |
| david-lyle | perhaps I'm over-simplifying | 17:45 |
| esp | but I think it needs to be a specific project token | 17:45 |
| esp | not necessarily the one that we scoped to on initial auth | 17:45 |
| esp | aka, the one in the session | 17:46 |
| *** tqtran has joined #openstack-horizon | 17:46 | |
| *** Drago has quit IRC | 17:46 | |
| *** dboik_ has quit IRC | 17:47 | |
| david-lyle | then what are you trying to list? the role assignments in a project you are admin in that you are not scoped to? that doesn't make any sense | 17:47 |
| *** dboik has joined #openstack-horizon | 17:47 | |
| esp | when I tried yesterday using curl directly against keystone api, I needed to be scoped to the project to list the roles, users | 17:48 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Glance Rest API for Angular Front End https://review.openstack.org/151468 | 17:48 |
| esp | meaning I wasn’t able to list users, roles from another project | 17:48 |
| *** neelashah has quit IRC | 17:49 | |
| david-lyle | so shouldn't you only be doing that task if scoped to that project? | 17:49 |
| david-lyle | I'm failing to see the use case | 17:49 |
| * esp shrugs | 17:49 | |
| david-lyle | either I'm cloud_admin and all is good | 17:49 |
| esp | cloud admin is all good for sure | 17:49 |
| david-lyle | I'm domain_admin and scoped to the domain | 17:50 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Raw Output Demo for Glance API https://review.openstack.org/155556 | 17:50 |
| esp | but if you want domain admin to manage users for projects I think ya gotta get the project scoped token | 17:50 |
| *** MaxV has quit IRC | 17:50 | |
| david-lyle | I don't think so | 17:50 |
| david-lyle | the rule is domain admin or project admin | 17:50 |
| *** crobertsrh has quit IRC | 17:51 | |
| esp | but does project admin mean you can manage all projects? | 17:51 |
| esp | or just the one you have auth’d to? | 17:51 |
| david-lyle | I'm not exactly sure what the purpose is there | 17:51 |
| david-lyle | that is just to list roles | 17:52 |
| *** Drago has joined #openstack-horizon | 17:52 | |
| *** gyee has joined #openstack-horizon | 17:52 | |
| david-lyle | may need to ping gyee | 17:52 |
| david-lyle | speaking of gyee | 17:52 |
| esp | david-lyle: yeah | 17:52 |
| gyee | what who when where? | 17:53 |
| david-lyle | https://github.com/openstack/keystone/blob/master/etc/policy.v3cloudsample.json#L93 | 17:53 |
| esp | gyee: I ran into an inssue during domain scoped token work | 17:53 |
| esp | thx david-lyle | 17:53 |
| david-lyle | relies on https://github.com/openstack/keystone/blob/master/etc/policy.v3cloudsample.json#L92 | 17:53 |
| david-lyle | what the hell is a project admin? | 17:53 |
| esp | lol | 17:53 |
| gyee | huh? | 17:54 |
| david-lyle | is this new age HMT mumbo jumbo? | 17:54 |
| esp | I’ll try to give a little context | 17:54 |
| gyee | you can't get a domain scoped token? | 17:54 |
| esp | forgive me if I mess this up, just got back from vacation | 17:54 |
| esp | so, in the Identity Dashboard - Projects panel | 17:55 |
| david-lyle | esp, unauthorized vacation, I might add | 17:55 |
| david-lyle | :D | 17:55 |
| esp | lol | 17:55 |
| esp | Cloud Admin can manage users/roles across all projects np | 17:55 |
| lhcheng | david-lyle, esp: not sure if you guys want to spend too much time on separating domain and project scoped token | 17:56 |
| *** neelashah has joined #openstack-horizon | 17:56 | |
| lhcheng | this might end up be the same with the *special project work | 17:56 |
| david-lyle | lhcheng: did someone finally come to their senses | 17:56 |
| david-lyle | ? | 17:56 |
| esp | Domain Admin can’t successfully list all the users associated to project using a domain scoped token | 17:56 |
| david-lyle | two years too late? | 17:56 |
| gyee | heh | 17:57 |
| david-lyle | to hell with domains, I'm out | 17:57 |
| *** neelashah1 has joined #openstack-horizon | 17:57 | |
| david-lyle | good luck | 17:57 |
| esp | so my thinking was Domain Admin needs a project scoped token scoped to the specific project it’s trying to manage | 17:57 |
| esp | lol david-lyle | 17:57 |
| gyee | esp, you mean you want to list all the users that have role assignment on a given project? | 17:57 |
| esp | we’ll make it work | 17:57 |
| * david-lyle remembers asking in keystone room, so do I really need to do this domain token thing that makes no sense | 17:57 | |
| esp | don’t worry david-lyle | 17:57 |
| * david-lyle heard response, oh yeah, that's the way to go | 17:58 | |
| esp | gyee: yeah | 17:58 |
| ongk | david-lyle: any news on the virtual sprints? | 17:58 |
| esp | let me pull up the code | 17:58 |
| david-lyle | ongk: good question | 17:58 |
| lhcheng | david-lyle: domain and project role assignment will be merged | 17:59 |
| david-lyle | will the tokens? | 17:59 |
| esp | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/roles.py#L88 | 17:59 |
| ongk | david-lyle: still planning for this week? | 17:59 |
| david-lyle | ongk: definitely, the question is to start today or tomorrow | 18:00 |
| *** alanf-mc has joined #openstack-horizon | 18:00 | |
| david-lyle | last minute planning has left it a bit ambiguous | 18:00 |
| *** neelashah has quit IRC | 18:00 | |
| david-lyle | so victory | 18:00 |
| david-lyle | https://etherpad.openstack.org/p/horizon-kilo-virtual-sprint btw | 18:00 |
| david-lyle | for those playing at home | 18:00 |
| *** matt-borland has joined #openstack-horizon | 18:01 | |
| lhcheng | david-lyle: if you scope to the special project, you'll get a bonus.. you get two tokens :) | 18:01 |
| lhcheng | but the role assigned will be the same | 18:01 |
| david-lyle | lhcheng: what???? | 18:01 |
| david-lyle | in the response I get two tokens | 18:02 |
| david-lyle | ? | 18:02 |
| esp | wonderful | 18:02 |
| david-lyle | really | 18:02 |
| gyee | esp, according to v3cloudsample policy file, if you have a domain-scoped token on the cloud admin domain, you are God | 18:02 |
| gyee | which means you can list all the role assignments | 18:02 |
| gyee | which policy file are you using? | 18:02 |
| lhcheng | esp: This is in the reseller spec I mentioend to you :) | 18:02 |
| esp | I’m using the latest from devstack I *think* | 18:02 |
| *** dsneddon has joined #openstack-horizon | 18:03 | |
| david-lyle | talking about moving targets | 18:03 |
| esp | policy.v3cloudsample.json | 18:03 |
| *** yingjun_ has quit IRC | 18:04 | |
| lhcheng | david-lyle: https://review.openstack.org/#/c/139824 | 18:05 |
| gyee | esp, did you update this line with the correct domain_id? https://github.com/openstack/keystone/blob/master/etc/policy.v3cloudsample.json#L3 | 18:05 |
| esp | gyee: yep, it’s set to “default” | 18:06 |
| *** alexvictorchan has quit IRC | 18:06 | |
| gyee | esp, k, so you have a domain-scoped token, scoped to the default domain, and still getting 401 on list role assignments? | 18:06 |
| *** alexvictorchan has joined #openstack-horizon | 18:06 | |
| esp | only issue I see is that Domain Admin can’t make the list() call with a project id and domain token | 18:07 |
| esp | gyee: it’s only for Domain Admin, 403 I believe | 18:08 |
| esp | but when I use a project scoped token seems to work | 18:08 |
| gyee | that doesn't sound right, lemme check the code | 18:08 |
| esp | I just have to do some extra work to retrieve a project scoped token specific to that project | 18:09 |
| esp | k, thx gyee | 18:09 |
| esp | I’ll update you guys after I test out a few more things | 18:09 |
| *** ZZelle_ has joined #openstack-horizon | 18:09 | |
| *** alanf-mc has quit IRC | 18:10 | |
| *** harlowja_away is now known as harlowja_ | 18:10 | |
| *** alexvictorchan has quit IRC | 18:12 | |
| *** alexvictorchan has joined #openstack-horizon | 18:16 | |
| openstackgerrit | Michael Hagedorn proposed openstack/horizon: WIP REST API to support create instance angular (Neutron) https://review.openstack.org/151313 | 18:18 |
| openstackgerrit | Merged openstack/django_openstack_auth: Allow running individual tests via tox https://review.openstack.org/154341 | 18:21 |
| *** alanf-mc has joined #openstack-horizon | 18:21 | |
| *** nlahouti has quit IRC | 18:24 | |
| *** nlahouti has joined #openstack-horizon | 18:25 | |
| *** bpokorny_ has joined #openstack-horizon | 18:29 | |
| *** tosky has quit IRC | 18:30 | |
| *** bpokorny has quit IRC | 18:32 | |
| *** devlaps has joined #openstack-horizon | 18:40 | |
| *** ramishra_ has joined #openstack-horizon | 18:41 | |
| *** my_openstack_use has quit IRC | 18:43 | |
| *** jasondotstar has joined #openstack-horizon | 18:45 | |
| *** bpokorny has joined #openstack-horizon | 18:45 | |
| *** ybathia has joined #openstack-horizon | 18:45 | |
| *** ramishra_ has quit IRC | 18:46 | |
| *** bpokorny_ has quit IRC | 18:48 | |
| *** devlaps has quit IRC | 18:49 | |
| *** iamjarvo has joined #openstack-horizon | 18:51 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 18:52 |
| *** tqtran has quit IRC | 18:55 | |
| *** oro has joined #openstack-horizon | 18:55 | |
| *** oro_ has joined #openstack-horizon | 18:55 | |
| *** TravT has quit IRC | 18:57 | |
| *** dboik_ has joined #openstack-horizon | 18:58 | |
| *** crobertsrh has joined #openstack-horizon | 18:59 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 19:00 |
| *** dboik_ has quit IRC | 19:01 | |
| jamielennox | david-lyle: around? | 19:01 |
| david-lyle | jamielennox: here | 19:01 |
| *** dboik_ has joined #openstack-horizon | 19:01 | |
| *** dboik has quit IRC | 19:01 | |
| jamielennox | david-lyle: i'm looking for some guidance on how to make these kerberos changes work | 19:01 |
| jamielennox | david-lyle: i got POC working | 19:01 |
| jamielennox | but they require a few things i don't know how horizon would configure | 19:02 |
| jamielennox | firstly requires: https://review.openstack.org/#/c/153174/ | 19:02 |
| *** rushiagr is now known as rushiagr_away | 19:02 | |
| jamielennox | and i'm not sure if that's something horizon team would want to vote on | 19:02 |
| *** akrivoka has quit IRC | 19:03 | |
| david-lyle | jamielennox: looking | 19:03 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 19:12 |
| david-lyle | jamielennox: so if the user is not authenticated we're raising an exception? | 19:13 |
| jamielennox | david-lyle: that will fall through in middleware to a redirect to /auth/login | 19:14 |
| jamielennox | david-lyle: the point is it's a redirect and not a rendering on GET / | 19:15 |
| *** fischerw has quit IRC | 19:16 | |
| robcresswell | night all | 19:16 |
| *** jprovazn has quit IRC | 19:16 | |
| *** fischerw has joined #openstack-horizon | 19:16 | |
| *** robcresswell is now known as robcresswell_afk | 19:17 | |
| jamielennox | to do proper SSO for kerberos or client certs we shouldn't show a login page and force someone to pick kerberos - it should just happen | 19:17 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Pie and donut chart directive https://review.openstack.org/146934 | 19:17 |
| jamielennox | but to do that we need to have apache handling certain routes, and as it is it will return the login on GET / and i can't intercept that | 19:17 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Pie/Donut Chart Directive https://review.openstack.org/154160 | 19:18 |
| david-lyle | jamielennox: there used to be a reason for the behavior as written, but the reason is lost on me now | 19:18 |
| david-lyle | I open to updating the logic | 19:19 |
| jamielennox | david-lyle: ok - wanted to check the reason as i can see that being a stumbling block | 19:19 |
| jamielennox | david-lyle: for DOA: https://review.openstack.org/#/c/153910/ | 19:19 |
| david-lyle | I think only folks that aren't around anymore would know the motivation | 19:20 |
| *** openstackgerrit has quit IRC | 19:20 | |
| *** openstackgerrit has joined #openstack-horizon | 19:20 | |
| david-lyle | I've made that same hack on 174 | 19:21 |
| *** oro_ has quit IRC | 19:21 | |
| *** oro has quit IRC | 19:22 | |
| jamielennox | yea, that's ugly - i can hopefully fix that from a keystone perspective | 19:22 |
| gyee | esp, works for me | 19:23 |
| gyee | curl -H 'X-Auth-Token: could admin token' http://host:port/v3/role_assignments?scope.project.id=<project_id> | 19:24 |
| gyee | esp, ^^^ | 19:24 |
| jamielennox | david-lyle: so i think an approach like this will help with the concerns i've heard about federated login as well | 19:24 |
| jamielennox | david-lyle: they seem to be missing the ability to provide an existing keystone token directly to horizon | 19:25 |
| david-lyle | jamielennox: yes, I think you're right | 19:25 |
| jamielennox | in this model you just make a plugin that checks for that header | 19:25 |
| david-lyle | where is keystoneclient_kerberos defined? | 19:26 |
| jamielennox | https://github.com/openstack/python-keystoneclient-kerberos | 19:26 |
| david-lyle | so an optional auth plugin? | 19:26 |
| jamielennox | david-lyle: yes | 19:26 |
| jamielennox | we're trying to get the non-standard plugins out of tree | 19:26 |
| jamielennox | so -federation exists as well | 19:26 |
| david-lyle | I'd prefer that wasn't hard coded | 19:27 |
| david-lyle | typically we do that with the django settings file | 19:27 |
| david-lyle | local_settings.py | 19:27 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example | 19:27 |
| david-lyle | that's the example for deployment dependent settings | 19:28 |
| jamielennox | david-lyle: sure, if we're happy with the idea of plugins like that then i could easily host the kerberos plugin from the -kerberos repo and enable via settings | 19:28 |
| jamielennox | or are you just looking for put import in __init__ and fail if asked for and not present? | 19:29 |
| david-lyle | looking more into the patch | 19:30 |
| david-lyle | this is going to get messy really quickl | 19:31 |
| david-lyle | y | 19:31 |
| jamielennox | yea, has that potential | 19:32 |
| david-lyle | a generalized auth plugin interface seems difficult, but how many other SSO solutions do I need hard-coded in DOA | 19:32 |
| jamielennox | so that one i think isn't too bad | 19:33 |
| *** alexvictorchan has quit IRC | 19:33 | |
| jamielennox | because the auth plugin interface is defined already in keystoneclient | 19:33 |
| jamielennox | the plugin here is just given the information passed to authenticate() what plugin can i use for that information | 19:33 |
| jamielennox | fallback is an issue though - if one method was to fail would you allow it to continue down the list | 19:33 |
| *** alexvictorchan has joined #openstack-horizon | 19:35 | |
| david-lyle | I see AUTH_PLUGINS as a setting and would prefer the PLUGINS lived in their own file | 19:35 |
| david-lyle | handling the import checks there | 19:35 |
| *** fischerw has quit IRC | 19:35 | |
| jamielennox | david-lyle: sure, this was POC i expect i'll have to make this a bit more django-y, i just have to look into how to do that | 19:35 |
| jamielennox | david-lyle: i guess what i need to figure out is if the approach is good, and is calling authenticate() twice like that an issue | 19:36 |
| david-lyle | that way the deployer can choose the fallback path | 19:36 |
| jamielennox | from what i was reading of the django docs it appears calling authenticate() many times should be allowed | 19:36 |
| *** fischerw has joined #openstack-horizon | 19:37 | |
| *** fischerw has quit IRC | 19:37 | |
| *** fischerw has joined #openstack-horizon | 19:38 | |
| david-lyle | still reading through | 19:38 |
| jamielennox | david-lyle: no rush | 19:39 |
| *** Piet has joined #openstack-horizon | 19:39 | |
| *** oro has joined #openstack-horizon | 19:42 | |
| *** oro_ has joined #openstack-horizon | 19:42 | |
| *** ramishra_ has joined #openstack-horizon | 19:42 | |
| *** fischerw has quit IRC | 19:46 | |
| *** fischerw has joined #openstack-horizon | 19:46 | |
| *** ramishra_ has quit IRC | 19:47 | |
| *** mrunge has quit IRC | 19:54 | |
| *** fischerw has quit IRC | 19:54 | |
| *** fischerw has joined #openstack-horizon | 19:54 | |
| *** TravT has joined #openstack-horizon | 19:58 | |
| *** fischerw has quit IRC | 20:00 | |
| *** fischerw has joined #openstack-horizon | 20:00 | |
| *** fischerw has quit IRC | 20:01 | |
| *** fischerw has joined #openstack-horizon | 20:01 | |
| jamielennox | david-lyle: going missing for about 15 minutes - i'll see any comments though so let me know hat you're thinking | 20:03 |
| rbertram | Is it possible to create new domains on devstack? | 20:05 |
| david-lyle | rbertram: yes | 20:07 |
| rbertram | david-lyle: thx, i'll keep working at it before requesting help, but wanted to be sure | 20:08 |
| david-lyle | rbertram: I was going to give you more, but had to hang up a call | 20:08 |
| rbertram | david-lyle: can't be done in Horizon, right? | 20:08 |
| david-lyle | yes it can | 20:08 |
| david-lyle | just a sec | 20:08 |
| david-lyle | let me grab the link | 20:09 |
| david-lyle | so pushy :D | 20:09 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L43 | 20:09 |
| *** crobertsrh has quit IRC | 20:09 | |
| david-lyle | enabling that and making sure https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L37 is 3 | 20:10 |
| david-lyle | will open the world to you | 20:10 |
| david-lyle | manage your domains away | 20:10 |
| *** crobertsrh has joined #openstack-horizon | 20:10 | |
| david-lyle | been there since H release | 20:11 |
| david-lyle | Havana | 20:11 |
| david-lyle | can't believe I couldn't remember that | 20:11 |
| david-lyle | log in to "default" domain | 20:12 |
| david-lyle | and bob's your uncle | 20:12 |
| *** alanf-mc has quit IRC | 20:12 | |
| rbertram | david-lyle: Thanks! | 20:13 |
| rbertram | david-lyle: Just got the command line working right, but switching to this for sure | 20:13 |
| *** fischerw has quit IRC | 20:15 | |
| *** fischerw has joined #openstack-horizon | 20:15 | |
| esp | gyee: thx, that works for me too | 20:18 |
| esp | will keep you posted ;) | 20:18 |
| *** fischerw has quit IRC | 20:21 | |
| *** fischerw has joined #openstack-horizon | 20:22 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/156750 | 20:24 |
| *** bpokorny_ has joined #openstack-horizon | 20:25 | |
| openstackgerrit | Gabriel Hurley proposed openstack/horizon: Use less permissive chmod in secret key test https://review.openstack.org/156752 | 20:25 |
| *** bpokorny has quit IRC | 20:27 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 20:28 |
| *** dboik_ has quit IRC | 20:28 | |
| *** peristeri has quit IRC | 20:29 | |
| *** peristeri has joined #openstack-horizon | 20:29 | |
| *** dboik has joined #openstack-horizon | 20:30 | |
| *** peristeri has quit IRC | 20:32 | |
| *** peristeri has joined #openstack-horizon | 20:32 | |
| rbertram | david-lyle: Can't seem to add projects or users in my new domain. I tried switching to its "context". what else? | 20:32 |
| *** peristeri has quit IRC | 20:33 | |
| *** peristeri has joined #openstack-horizon | 20:33 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:34 | |
| r1chardj0n3s | morning | 20:34 |
| *** fischerw has quit IRC | 20:37 | |
| *** fischerw_ has joined #openstack-horizon | 20:37 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 20:38 |
| *** dkorn has joined #openstack-horizon | 20:39 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/156760 | 20:42 |
| *** mpavlase has joined #openstack-horizon | 20:43 | |
| *** ramishra_ has joined #openstack-horizon | 20:43 | |
| *** dboik has quit IRC | 20:43 | |
| *** dboik has joined #openstack-horizon | 20:44 | |
| *** dboik has quit IRC | 20:44 | |
| *** dboik has joined #openstack-horizon | 20:45 | |
| *** ramishra_ has quit IRC | 20:48 | |
| *** oro has quit IRC | 20:51 | |
| *** TravT_ has joined #openstack-horizon | 20:51 | |
| *** oro_ has quit IRC | 20:51 | |
| *** ericpeterson has quit IRC | 20:52 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 20:53 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Demo for Re-designed Tables https://review.openstack.org/151101 | 20:54 |
| *** Piet has quit IRC | 20:54 | |
| *** matt-borland has quit IRC | 20:55 | |
| *** TravT has quit IRC | 20:55 | |
| *** jtomasek has quit IRC | 21:00 | |
| *** TravT_ has quit IRC | 21:03 | |
| *** TravT has joined #openstack-horizon | 21:04 | |
| *** fischerw_ has quit IRC | 21:04 | |
| *** fischerw_ has joined #openstack-horizon | 21:04 | |
| *** fischerw_ has quit IRC | 21:09 | |
| *** fischerw_ has joined #openstack-horizon | 21:09 | |
| *** fischerw_ has quit IRC | 21:10 | |
| *** fischerw_ has joined #openstack-horizon | 21:10 | |
| *** dkorn has quit IRC | 21:11 | |
| *** alanf-mc has joined #openstack-horizon | 21:12 | |
| r1chardj0n3s | TravT: sqchen isn't around right now, but could we please stop this use of .factory() over .service()? :) | 21:13 |
| *** fischerw__ has joined #openstack-horizon | 21:18 | |
| *** fischerw_ has quit IRC | 21:18 | |
| *** aix has quit IRC | 21:20 | |
| *** LiveOne_ has joined #openstack-horizon | 21:22 | |
| *** ericpeterson has joined #openstack-horizon | 21:22 | |
| *** dkorn has joined #openstack-horizon | 21:30 | |
| *** MaxV has joined #openstack-horizon | 21:32 | |
| *** fischerw__ has quit IRC | 21:34 | |
| *** fischerw__ has joined #openstack-horizon | 21:34 | |
| *** hhuang has quit IRC | 21:37 | |
| *** hhuang has joined #openstack-horizon | 21:38 | |
| *** e0ne has quit IRC | 21:39 | |
| *** dkorn has quit IRC | 21:41 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Enabling auto focus on first form element https://review.openstack.org/156785 | 21:43 |
| *** rm_work is now known as rm_work|away | 21:44 | |
| *** ramishra_ has joined #openstack-horizon | 21:44 | |
| TravT | hey r1charj0n3s: | 21:46 |
| r1chardj0n3s | hey TravT :) | 21:47 |
| TravT | r1chardj0n3s: | 21:47 |
| TravT | i think tomorrow we're shooting for at least a period of time that everybody is online to talk specifically about these APIs | 21:47 |
| r1chardj0n3s | the sprint time? | 21:48 |
| TravT | yeah | 21:48 |
| r1chardj0n3s | yep | 21:48 |
| *** robcresswell_afk has quit IRC | 21:48 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Enabling auto-focus on first form element https://review.openstack.org/156785 | 21:48 |
| r1chardj0n3s | plan on being here | 21:48 |
| TravT | i'm thinking i'll put up the alternate $resource pattern into the same patch | 21:48 |
| TravT | and then we can have a big cage match | 21:48 |
| TravT | ;) | 21:48 |
| *** ramishra_ has quit IRC | 21:49 | |
| r1chardj0n3s | sure, but I'm still worried we've had zero actual user-facing changes land | 21:49 |
| TravT | altneratively, | 21:49 |
| TravT | i could put up a dependent patch that shows the $resource pattern | 21:49 |
| r1chardj0n3s | I guess I can't tell you what to work on, so go for it | 21:49 |
| TravT | ultimately, we are starting work on the instance steps. | 21:50 |
| r1chardj0n3s | that's good to hear | 21:51 |
| TravT | it just felt like the call last week was hard to follow the difference | 21:51 |
| *** robcresswell_afk has joined #openstack-horizon | 21:51 | |
| TravT | so, was thinking a side by side would make it more tangible. | 21:51 |
| r1chardj0n3s | nono, I fully understand where you're coming from | 21:51 |
| *** robcresswell_afk is now known as robcresswell | 21:51 | |
| TravT | i'd be happy to see current patch land | 21:52 |
| TravT | and then explore other options. | 21:52 |
| r1chardj0n3s | it takes two weeks to get a patch through. altering the underlying API code now will push out all dependent patches by another two weeks | 21:52 |
| TravT | but you are right, we've got to get the user facing work land | 21:52 |
| r1chardj0n3s | twoo weeks *minimum* | 21:52 |
| TravT | well, that is some of what Matt B was saying | 21:52 |
| TravT | it should matter too much since controller is where data is bound | 21:53 |
| TravT | so we could start with current | 21:53 |
| *** rebelagentm has quit IRC | 21:53 | |
| david-lyle | I think some code is going land and refactoring happens in L based on group learnings | 21:53 |
| *** peristeri has quit IRC | 21:54 | |
| r1chardj0n3s | yep, I agree | 21:54 |
| *** fischerw__ has quit IRC | 21:54 | |
| TravT | but at the same time, since actual work hasn't started with these APIs, it only takes a little time to look at the differences. | 21:54 |
| *** neelashah1 has quit IRC | 21:54 | |
| *** fischerw__ has joined #openstack-horizon | 21:54 | |
| TravT | so, let me ask you both for a vote right now | 21:54 |
| r1chardj0n3s | but again, re-working them will cause other work to be delayed by weeks | 21:54 |
| david-lyle | we have 1 month | 21:54 |
| david-lyle | total | 21:54 |
| TravT | if i put up a patch with the $resource pattern (which I have mostly read) would you rather I modify current patch or put up a dependent patch for comparison? | 21:55 |
| TravT | If I do the former, it could land and start getting used | 21:55 |
| *** sqchen has joined #openstack-horizon | 21:55 | |
| *** gyee has quit IRC | 21:55 | |
| r1chardj0n3s | of *those two options* (ignoring the third one) and even though it'll be messier, I would lean towards the first | 21:56 |
| r1chardj0n3s | still arguinig strongly that option 3 (don't change tack *right now*) is the only sensible one | 21:56 |
| TravT | well, nobody is using the API yet. | 21:57 |
| TravT | but that could change as soon as it lands | 21:57 |
| r1chardj0n3s | and changing it is going to help that? | 21:57 |
| TravT | how about david-lyle just ninja's it through now and ends the discussion? ;-) | 21:57 |
| r1chardj0n3s | just so we're clear: I am *not* arguiing that the current API is perfect! | 21:57 |
| r1chardj0n3s | :) | 21:58 |
| r1chardj0n3s | but we need to stabilise the knock-on work can actually get done | 21:58 |
| r1chardj0n3s | otherwise, effectively, 6 months have been wasted | 21:58 |
| r1chardj0n3s | *6 months* | 21:58 |
| r1chardj0n3s | ugh | 21:58 |
| TravT | nobody wants that | 21:58 |
| TravT | talking of current patch. sqchen: are you on? | 21:59 |
| TravT | factory vs service | 21:59 |
| sqchen | yes, I am here | 21:59 |
| TravT | see below: https://review.openstack.org/#/c/151468/21..29/horizon/static/horizon/js/angular/services/hz.api.glance.js | 21:59 |
| r1chardj0n3s | sqchen is on! I'm curious where you get that idea about singletons | 22:00 |
| TravT | r1chardj0n3s doesn't like the factory pattern here. | 22:00 |
| *** dkorn has joined #openstack-horizon | 22:00 | |
| r1chardj0n3s | I think it has extra code (yes, only two lines) that is messy ;) | 22:00 |
| r1chardj0n3s | so I prefer the service() pattern with the implicit new by angular | 22:00 |
| sqchen | As I said before, it is not supper important, class pattern works as well. | 22:01 |
| r1chardj0n3s | sqchen but your argument is that using service() you don't end up with a singleton, which is not correct in my understanding | 22:01 |
| sqchen | with new, it won’t be a singleton. but since it doesn’t have state, it should work fine. | 22:02 |
| *** iamjarvo has quit IRC | 22:02 | |
| r1chardj0n3s | sqchen: but it is a singleton. all services are singletons. angular caches the result of a .service() | 22:02 |
| r1chardj0n3s | unless my understanding is incorrect ;) | 22:02 |
| r1chardj0n3s | but that's how I read the documentation | 22:02 |
| sqchen | using a class and having new to get the serivice, you will get a new instance everytime you call the service. | 22:03 |
| TravT | i read through some of this again on an alternate site... | 22:03 |
| TravT | trying to find that now. | 22:03 |
| sqchen | sorry, r1chardj0n3s :-) | 22:04 |
| r1chardj0n3s | sqchen: but the docs explicitly state that all services are singletons | 22:04 |
| r1chardj0n3s | sqchen: angular does the work to make them so | 22:04 |
| david-lyle | factory just calls service internally anyway | 22:04 |
| *** garthb has joined #openstack-horizon | 22:04 | |
| *** garthb_ has joined #openstack-horizon | 22:04 | |
| *** dkorn has quit IRC | 22:04 | |
| sqchen | I know it is confusing, and that is a mistake of angular using all thse confusing terms, this is what they said. :) .service returns new instance from a contructor function, a new one each time we injecct it. | 22:09 |
| sqchen | .facory pattern return a singleton. they should not call it factory for sure, but, it allreay named as it. | 22:10 |
| *** crobertsrh has quit IRC | 22:10 | |
| r1chardj0n3s | sqchen: do you have a reference for that .service statement pls? | 22:10 |
| sqchen | Again, in our case, it doesn’t matter, because our api doesn’t have state. | 22:10 |
| sqchen | https://docs.angularjs.org/guide/providers | 22:11 |
| r1chardj0n3s | sqchen: where in that page? | 22:11 |
| r1chardj0n3s | because that's the page that states all services are singletons | 22:12 |
| sqchen | myApp.factory('unicornLauncher', ["apiToken", function(apiToken) { | 22:12 |
| sqchen | return new UnicornLauncher(apiToken); | 22:12 |
| sqchen | }]); | 22:12 |
| r1chardj0n3s | ah yes, but that's not how we're using it | 22:13 |
| *** mugsie has quit IRC | 22:13 | |
| r1chardj0n3s | that's registering a .factory() not a .service() | 22:14 |
| *** mugsie has joined #openstack-horizon | 22:14 | |
| sqchen | .factory() do not call new operator for us. | 22:15 |
| r1chardj0n3s | but we're not using .factory() we're using .service() when we use that pattern | 22:15 |
| *** neillc is now known as neillc_afk | 22:16 | |
| r1chardj0n3s | myApp.service('unicornLauncher', ["apiToken", UnicornLauncher]); | 22:16 |
| r1chardj0n3s | no "new" | 22:16 |
| sqchen | .service() do not return singleton | 22:16 |
| sqchen | service call new operator automatically | 22:16 |
| r1chardj0n3s | and it does it once and caches the result - that's what the page says | 22:16 |
| r1chardj0n3s | even if we .factory() and invoked new ourselves, angular would still cache the result so it was a singleton | 22:18 |
| sqchen | Idealy we should not mix service recipe and facory recipe. But again. it doesn’t matter in our case, because the api object doesn’t has state. | 22:18 |
| r1chardj0n3s | I really need to make sure we are clear on this singleton issue - I need to know that my understanding of angular is correct, so I'm asking for where you have seen the angular docs state that .service() doesn't follow the "services are singletons" documentation | 22:19 |
| TravT | https://docs.angularjs.org/guide/services | 22:20 |
| r1chardj0n3s | we use .service() in all the currently-committed api | 22:20 |
| TravT | Singletons – Each component dependent on a service gets a reference to the single instance generated by the service factory. | 22:20 |
| *** fischerw__ has quit IRC | 22:21 | |
| TravT | these guys seriously should be burned for their overuse of the word service and factory | 22:21 |
| *** fischerw__ has joined #openstack-horizon | 22:21 | |
| r1chardj0n3s | yeah, they're way off using factory there :/ | 22:21 |
| sqchen | r1chardj0n3s: you can be right, may be service is also return a singleton. | 22:22 |
| david-lyle | 3 ways of doing the provider is sillyness | 22:22 |
| david-lyle | what were they thinkinig | 22:22 |
| sqchen | haha | 22:23 |
| TravT | This article is actually good reading, but it doesn't really address the singleton issue, I think. | 22:23 |
| TravT | http://tylermcginnis.com/angularjs-factory-vs-service-vs-provider/ | 22:23 |
| TravT | the main difference is where you assign your properties and functions, with no actual difference as far as I can tell. | 22:24 |
| r1chardj0n3s | TravT: yep | 22:25 |
| *** neelashah has joined #openstack-horizon | 22:26 | |
| *** dboik has quit IRC | 22:28 | |
| TravT | lhcheng: are you there? | 22:29 |
| lhcheng | TravT, yeah but I am on a meeting | 22:30 |
| lhcheng | TravT, what's up? | 22:30 |
| rbertram | After creating a new domain in Horizon, is it possible to add a project to it? And then users? Options are still grayed out... | 22:30 |
| TravT | ok, well, it was partially your review on the above that caused me to go ahead with moving service to factory. | 22:31 |
| TravT | https://review.openstack.org/#/c/151468/21..29/horizon/static/horizon/js/angular/services/hz.api.glance.js | 22:31 |
| david-lyle | rbertram: yes | 22:31 |
| *** MaxV has quit IRC | 22:31 | |
| TravT | but now it seems none us actually can prove that moving to that pattern is better. | 22:31 |
| david-lyle | in domains, set domain context on the domain you want to administer | 22:31 |
| TravT | so barring the above happening, I think I'll switch that code back to original service pattern. | 22:31 |
| rbertram | david-lyle: Would you be kind enough to tell me what the secret is? :-) | 22:32 |
| david-lyle | the set context button in the row action | 22:32 |
| sqchen | r1chardj0n3s: you are right, .service() returns singleton. :) | 22:32 |
| rbertram | david-lyle: I tried that, it set the context, but still didn't allow adding projects/users | 22:32 |
| r1chardj0n3s | \o/ I'm not crazy :) | 22:32 |
| TravT | sqchen: so you'd vote I go back to service as well? | 22:32 |
| david-lyle | cleaner yes | 22:33 |
| sqchen | yes TravT | 22:33 |
| david-lyle | rbertram: are you using the default policy file? | 22:33 |
| rbertram | It says "Domain project is set to ..." correctly | 22:33 |
| TravT | ok. i'll do that. | 22:33 |
| r1chardj0n3s | also not using .factory() ever because to do so would be to validate the angularjs developers' life choices | 22:33 |
| r1chardj0n3s | :) | 22:33 |
| rbertram | david-lyle: far as I know | 22:33 |
| david-lyle | ok | 22:33 |
| rbertram | david-lyle: never messed with it | 22:33 |
| TravT | i have to back out my current changes that show the $resource pattern in that patch. will take just a few minutes. | 22:34 |
| david-lyle | so when you set the domain context what happends? | 22:34 |
| lhcheng | TravT, yeah sqchen had a comment on using factory pattern. I didn't see a response on the following patch about that. | 22:34 |
| *** jtriley has quit IRC | 22:34 | |
| david-lyle | lhcheng: read back a bit | 22:34 |
| rbertram | david-lyle: It gives a green success message. The domains table shrinks down to one row. | 22:34 |
| TravT | \me trembles in fear of screwing up git commands and losing work. | 22:34 |
| * TravT also can't use irc commands correctly | 22:34 | |
| david-lyle | rbertram: then go to projects | 22:34 |
| rbertram | david-lyle: But when I switch to Projects view, and try to add a project, it is still stuck on default id/name of domain | 22:35 |
| david-lyle | rbertram: I think you may be running in a cookie overflow problem | 22:35 |
| TravT | lhcheng: thanks I will upload that change it just a sec. | 22:35 |
| r1chardj0n3s | I think the real blocker we've hit is the API for policy | 22:35 |
| david-lyle | r1chardj0n3s: I've been working on that | 22:35 |
| david-lyle | the API is easy | 22:35 |
| sqchen | factory pattern allows you to have true private states. | 22:35 |
| r1chardj0n3s | ok cool | 22:35 |
| rbertram | david-lyle: hmmm. heardthis talked about. suggestions? | 22:35 |
| david-lyle | the hard part is consuming it | 22:36 |
| david-lyle | it a non-belligerent way | 22:36 |
| r1chardj0n3s | for i in thing: pass | 22:36 |
| r1chardj0n3s | nomnomnom | 22:36 |
| r1chardj0n3s | non-belligerent? | 22:36 |
| r1chardj0n3s | I don't think I've seen that word used in an API-consumer context before :) | 22:36 |
| david-lyle | r1chardj0n3s: re-ask every time it's needed | 22:37 |
| r1chardj0n3s | ahhh, ok | 22:37 |
| r1chardj0n3s | but the policy wouldn't change very often for a given user, yeah? | 22:37 |
| rbertram | david-lyle: I can toss all the cookies for the site | 22:37 |
| r1chardj0n3s | so the angular-side service can cache? | 22:37 |
| david-lyle | what I wanted to do was... | 22:38 |
| david-lyle | rbertram: addSESSION_ENGINE = 'django.contrib.sessions.backends.cache' to your local_settings.py | 22:38 |
| david-lyle | what I wanted to do was | 22:38 |
| david-lyle | build a list of all the policy checks in say a controller and instantiate the policyService using that, and return hits from the cached results or go ask for items not in the cache and add it to the cache | 22:39 |
| david-lyle | angular is not well designed for such things | 22:39 |
| david-lyle | additionally there are policy targets that have to be passed | 22:40 |
| r1chardj0n3s | istm that policy checks should be the domain of a service | 22:40 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Glance Rest API for Angular Front End https://review.openstack.org/151468 | 22:40 |
| * ericpeterson can't believe we are still using the cookie session engine | 22:40 | |
| *** neelashah has quit IRC | 22:40 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Raw Output Demo for Glance API https://review.openstack.org/155556 | 22:40 |
| david-lyle | r1chardj0n3s: a generalized service? | 22:40 |
| * rbertram wonders how he'd get by without help from you guys | 22:41 | |
| david-lyle | that was my aim | 22:41 |
| david-lyle | but the caching gets tricky if the targets change | 22:41 |
| rbertram | david-lyle: that fixed it. Thanks! | 22:41 |
| r1chardj0n3s | david-lyle: I'd see maybe two services: one that handles the api conversation, and another on top of that that implements the policy checks and caching of checks. the api service is only used by the check service | 22:41 |
| r1chardj0n3s | targets? | 22:41 |
| * r1chardj0n3s is probably woefully unfamiliar with the policy engine :/ | 22:42 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: WIP REST API for Users filter https://review.openstack.org/156810 | 22:42 |
| david-lyle | so my fallback may just be a basic service for now that makes the checks directly when needed and optimize later | 22:42 |
| ericpeterson | r1chardj0n3s - you should really spend some time with policy engine stuff. it is a super terrific awesome time | 22:42 |
| r1chardj0n3s | ericpeterson hates me, and I don't know why | 22:42 |
| ericpeterson | lol | 22:43 |
| david-lyle | r1chardj0n3s: yes please, if you ask real nice I'll let you own it | 22:43 |
| r1chardj0n3s | ;) | 22:43 |
| *** neelashah has joined #openstack-horizon | 22:43 | |
| * david-lyle rues that he ever heard the word policy | 22:43 | |
| r1chardj0n3s | wow, et tu david-lyle? | 22:43 |
| ericpeterson | so then r1chardj0n3s owns policy engine, glad we could get that nailed down | 22:43 |
| ericpeterson | ;) | 22:43 |
| r1chardj0n3s | look, I'd love to, but I have this dozen cats I really want to bathe first | 22:44 |
| david-lyle | you get all the glory jobs | 22:44 |
| *** ramishra_ has joined #openstack-horizon | 22:45 | |
| david-lyle | so yeah, I may have permission to do x to network A but not network B | 22:45 |
| *** neelashah1 has joined #openstack-horizon | 22:45 | |
| r1chardj0n3s | yep, so the caching mechanism needs work be sophisticated - max how many inputs for a given policy check? | 22:45 |
| TravT | r1chardj0n3s: see above https://review.openstack.org/#/c/151468/ | 22:46 |
| TravT | i have to run to help Piet with something. | 22:46 |
| r1chardj0n3s | TravT: already on it ;) | 22:46 |
| TravT | so i'll be offline for about 1.5 hours. but will be back online later | 22:46 |
| r1chardj0n3s | ok, thanks | 22:46 |
| TravT | thanks! | 22:46 |
| TravT | glad we could do that discussion | 22:47 |
| david-lyle | r1chardj0n3s: array of rules to be or'd, and target | 22:47 |
| r1chardj0n3s | yikes | 22:47 |
| david-lyle | each rule pass is composed of service and rule | 22:47 |
| david-lyle | like compute, compute:list_servers | 22:48 |
| *** neelashah has quit IRC | 22:48 | |
| TravT | david-lyle: i updated info on the virtual sprint. FYI my tomorrow afternoons are free and clear. | 22:48 |
| TravT | also we can use the hp myroom. | 22:48 |
| david-lyle | TravT: (thumbsup) | 22:48 |
| david-lyle | thanks | 22:48 |
| TravT | ttyl | 22:48 |
| david-lyle | r1chardj0n3s: because policy is not globally unique each service can have a rule called compute:i_hate_david | 22:49 |
| *** gyee has joined #openstack-horizon | 22:49 | |
| sqchen | david-lyle: would you like to take a look on https://review.openstack.org/#/c/156359/ | 22:49 |
| *** ramishra_ has quit IRC | 22:49 | |
| * ericpeterson thought all services have a policy called i_hate_david which allows all | 22:50 | |
| david-lyle | and I have no way to map them, unless the call says which service it wants to check against | 22:50 |
| * david-lyle know ericpeterson is right | 22:50 | |
| r1chardj0n3s | :) | 22:50 |
| david-lyle | so for now, we will pass through | 22:51 |
| *** TravT has quit IRC | 22:51 | |
| ericpeterson | the policy engine is a really good idea and cool thing, if only it was really used and more broadly adopted. | 22:51 |
| r1chardj0n3s | right, so the calls have to include service and rule, yep | 22:51 |
| david-lyle | as a bridge | 22:51 |
| david-lyle | and then I'll work on caching | 22:51 |
| david-lyle | caching is what I've been working mostly on but it needs more time | 22:52 |
| r1chardj0n3s | david-lyle: that's sensible - I'll try to help out on the caching once I see the shape of it | 22:52 |
| david-lyle | something to get unblocked is needed now | 22:52 |
| r1chardj0n3s | yep | 22:52 |
| david-lyle | r1chardj0n3s: sure, thanks | 22:52 |
| david-lyle | I'm still hoping for a central policy store | 22:53 |
| david-lyle | so I'm not expecting much | 22:53 |
| lhcheng | TravT: sure, you guys got sqchen onboard on using the service pattern. that's fine with me. | 22:54 |
| *** doug-fish has left #openstack-horizon | 22:54 | |
| sqchen | May I get your attention now? david-lyle, lhcheng | 22:55 |
| david-lyle | sqchen: sure, what's up | 22:55 |
| david-lyle | ? | 22:55 |
| lhcheng | sqchen, I'm still on a meeting, will be slow to respond | 22:55 |
| sqchen | can you take look at https://review.openstack.org/#/c/156359/ | 22:55 |
| sqchen | ok, np :) | 22:56 |
| david-lyle | sqchen: will do | 22:56 |
| sqchen | thanks! | 22:56 |
| *** fischerw__ has quit IRC | 22:56 | |
| *** fischerw__ has joined #openstack-horizon | 22:56 | |
| *** lblanchard has quit IRC | 22:59 | |
| *** iamjarvo has joined #openstack-horizon | 23:02 | |
| *** neelashah1 has quit IRC | 23:04 | |
| *** rhagarty has quit IRC | 23:05 | |
| *** chlong has joined #openstack-horizon | 23:08 | |
| *** Piet has joined #openstack-horizon | 23:10 | |
| *** mpavlase has quit IRC | 23:14 | |
| *** neillc_afk is now known as neillc | 23:22 | |
| *** fischerw__ has quit IRC | 23:29 | |
| *** nlahouti has quit IRC | 23:32 | |
| *** vijendar has quit IRC | 23:35 | |
| *** MaxV has joined #openstack-horizon | 23:41 | |
| *** ramishra_ has joined #openstack-horizon | 23:45 | |
| *** MaxV has quit IRC | 23:46 | |
| *** ramishra_ has quit IRC | 23:50 | |
| openstackgerrit | Gloria Gu proposed openstack/horizon: Added snapshot tab to a volume detail https://review.openstack.org/156848 | 23:52 |
| *** ZZelle_ has quit IRC | 23:53 | |
| *** nlahouti has joined #openstack-horizon | 23:55 | |
| *** nlahouti1 has joined #openstack-horizon | 23:55 | |
| *** nlahouti has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!