tsufiev_ | hello, horizoneers! Could anyone point me to the code in tables inline-editing where csrf-middleware token is generated? | 00:03 |
---|---|---|
tsufiev_ | fast search for 'csrf' didn't help | 00:03 |
lhcheng | tsufiev_: thought horizon.ajax handles it somewhere.. | 00:06 |
*** alexvictorchan has quit IRC | 00:06 | |
lhcheng | tsufiev_: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.tables_inline_edit.js#L217 | 00:08 |
lhcheng | usually the csrf token is included in the form | 00:08 |
tsufiev_ | lhcheng, yep, thank you very much! I think that the token is generated on server-side | 00:08 |
lhcheng | tsufiev_: glad to help | 00:09 |
*** Piet has quit IRC | 00:22 | |
*** Sukhdev has joined #openstack-horizon | 00:26 | |
*** sqchen has joined #openstack-horizon | 00:41 | |
*** sqchen has left #openstack-horizon | 00:49 | |
*** sqchen has joined #openstack-horizon | 00:49 | |
*** mgarza has quit IRC | 00:52 | |
*** ericpeterson has joined #openstack-horizon | 00:53 | |
openstackgerrit | Merged openstack/horizon: Create a reusable angular-based wizard https://review.openstack.org/137417 | 00:54 |
r1chardj0n3s | merged!! \o/ | 00:54 |
*** ericpeterson has quit IRC | 00:57 | |
*** mpavlase has quit IRC | 01:00 | |
*** zul has quit IRC | 01:03 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Angular Modal https://review.openstack.org/140932 | 01:05 |
*** sqchen has left #openstack-horizon | 01:16 | |
*** doug-fish has left #openstack-horizon | 01:16 | |
*** sqchen has joined #openstack-horizon | 01:16 | |
ongk | tqtran: ping | 01:22 |
tqtran | ongk: pong | 01:22 |
ongk | tqtran: for the tables, you want a separate patch for docs or in the same one? | 01:23 |
tqtran | same one please | 01:23 |
*** lhcheng has quit IRC | 01:24 | |
*** alexvictorchan has joined #openstack-horizon | 01:25 | |
*** clu_ has quit IRC | 01:25 | |
ongk | Is there a separate JS documentation somewhere I can check out? | 01:26 |
ongk | tqtran: I’m only seeing the python docs | 01:28 |
tqtran | Matt provided a pretty good example | 01:29 |
tqtran | just take a look at any of the angular directive and follow | 01:29 |
tqtran | https://github.com/angular/angular.js/tree/master/src | 01:29 |
*** Sukhdev has quit IRC | 01:31 | |
*** openstack has joined #openstack-horizon | 01:33 | |
ongk | Oh, you mean in the JS file. Thought you meant something else :) | 01:34 |
*** TravT has quit IRC | 01:39 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 01:40 | |
*** alexvictorchan has quit IRC | 01:42 | |
*** TravT has joined #openstack-horizon | 01:46 | |
*** TravT has quit IRC | 01:53 | |
*** rwsu is now known as rwsu-afk | 01:53 | |
*** Sukhdev has joined #openstack-horizon | 02:00 | |
*** sqchen has left #openstack-horizon | 02:03 | |
*** sayan has joined #openstack-horizon | 02:06 | |
*** ybathia has quit IRC | 02:09 | |
*** bpokorny has quit IRC | 02:11 | |
*** nlahouti has quit IRC | 02:20 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: Pie and donut chart directive https://review.openstack.org/146934 | 02:24 |
*** ericpeterson has joined #openstack-horizon | 02:25 | |
*** ericpeterson has quit IRC | 02:26 | |
*** tqtran has quit IRC | 02:30 | |
*** sayan has quit IRC | 02:47 | |
*** harlowja is now known as harlowja_away | 02:48 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: Re-designed and Angularized tables https://review.openstack.org/147393 | 03:07 |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 03:09 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Re-designed and Angularized tables https://review.openstack.org/147393 | 03:13 |
*** bpokorny has joined #openstack-horizon | 03:32 | |
*** bpokorny has quit IRC | 03:33 | |
*** bpokorny has joined #openstack-horizon | 03:33 | |
*** sayan has joined #openstack-horizon | 03:34 | |
*** Longgeek has joined #openstack-horizon | 03:36 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: Re-designed and Angularized tables https://review.openstack.org/147393 | 03:38 |
*** mattfarina has joined #openstack-horizon | 03:40 | |
*** lhcheng has joined #openstack-horizon | 03:44 | |
*** tzumainn has quit IRC | 03:49 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Re-designed Tables https://review.openstack.org/151101 | 03:58 |
*** Sukhdev has quit IRC | 04:00 | |
*** early has quit IRC | 04:04 | |
*** early has joined #openstack-horizon | 04:25 | |
openstackgerrit | Trung Trinh proposed openstack/horizon: Ignore Exception in process of Edit Attachments https://review.openstack.org/153460 | 04:26 |
*** lhcheng has quit IRC | 04:26 | |
*** sayan has quit IRC | 04:28 | |
*** TravT has joined #openstack-horizon | 04:29 | |
*** TravT has quit IRC | 04:29 | |
*** TravT has joined #openstack-horizon | 04:29 | |
openstackgerrit | Trung Trinh proposed openstack/horizon: Ignore Exception in process of Edit Attachments https://review.openstack.org/153460 | 04:31 |
*** early has quit IRC | 04:43 | |
*** EmilienM|afk has quit IRC | 04:45 | |
*** sayan has joined #openstack-horizon | 04:45 | |
*** EmilienM has joined #openstack-horizon | 04:46 | |
*** nlahouti has joined #openstack-horizon | 04:47 | |
*** neelashah has joined #openstack-horizon | 04:50 | |
*** nlahouti has quit IRC | 04:50 | |
*** nlahouti has joined #openstack-horizon | 04:51 | |
*** mattfarina has quit IRC | 04:51 | |
*** neelashah has quit IRC | 04:51 | |
*** nlahouti has quit IRC | 05:13 | |
*** nlahouti has joined #openstack-horizon | 05:13 | |
*** nikunj2512 has joined #openstack-horizon | 05:14 | |
*** tmazur_ has quit IRC | 05:17 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 05:19 | |
*** harlowja_away has quit IRC | 05:38 | |
*** echevemaster has quit IRC | 05:42 | |
*** jasondotstar has quit IRC | 05:43 | |
*** early has joined #openstack-horizon | 05:47 | |
*** ishant has joined #openstack-horizon | 05:48 | |
*** early has quit IRC | 05:50 | |
*** early has joined #openstack-horizon | 06:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/153476 | 06:10 |
*** masco has joined #openstack-horizon | 06:10 | |
*** early has quit IRC | 06:12 | |
*** early has joined #openstack-horizon | 06:23 | |
*** rushiagr_away is now known as rushiagr | 06:29 | |
*** openstackgerrit has quit IRC | 06:35 | |
*** openstackgerrit has joined #openstack-horizon | 06:35 | |
*** danieru has quit IRC | 06:36 | |
*** tsufiev_ is now known as tsufiev | 06:37 | |
*** danieru has joined #openstack-horizon | 06:37 | |
*** early has quit IRC | 06:43 | |
*** denis_makogon has joined #openstack-horizon | 06:43 | |
*** early has joined #openstack-horizon | 06:49 | |
*** denis_makogon has quit IRC | 06:56 | |
*** josecastroleon has joined #openstack-horizon | 07:01 | |
*** chlong has quit IRC | 07:12 | |
*** chlong has joined #openstack-horizon | 07:13 | |
*** jtomasek has joined #openstack-horizon | 07:34 | |
*** nlahouti has quit IRC | 07:37 | |
*** oro has joined #openstack-horizon | 08:07 | |
*** zz_ttrifonov is now known as ttrifonov | 08:23 | |
quist` | Hello everyone, i have a question regarding modification of Horizon. Would this channel be the appropriate place for such questions? | 08:35 |
*** stevemar has quit IRC | 08:39 | |
nikunj2512 | quist`: Seems so.. Please ask your question | 08:40 |
*** ygbo has joined #openstack-horizon | 08:40 | |
*** markus_z has joined #openstack-horizon | 08:42 | |
quist` | nikunj2512: Ah ok, is it possible to add images to the Dashboards, groups and panels into the Horizon menu? | 08:46 |
nikunj2512 | quist`: yes.. Take a look at this wiki: http://docs.openstack.org/developer/horizon/quickstart.html#dashboard-configuration | 08:48 |
nikunj2512 | quist`: but you have to change some code... | 08:49 |
nikunj2512 | http://docs.openstack.org/admin-guide-cloud/content/dashboard-custom-brand.html | 08:49 |
*** alexpilotti has joined #openstack-horizon | 08:50 | |
nikunj2512 | quist`: This will help you -> https://horizon-openstack-dashboard.readthedocs.org/en/latest/topics/customizing.html | 08:51 |
*** chlong has quit IRC | 08:53 | |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Wait till spinner is disappears https://review.openstack.org/151608 | 08:53 |
*** oro has quit IRC | 08:56 | |
*** teju has joined #openstack-horizon | 08:57 | |
*** jpich has joined #openstack-horizon | 08:59 | |
*** amerine_ has joined #openstack-horizon | 08:59 | |
*** amerine has quit IRC | 09:00 | |
*** mpavlase has joined #openstack-horizon | 09:06 | |
*** JeanBriceCombebi has joined #openstack-horizon | 09:06 | |
*** JeanBriceCombebi has quit IRC | 09:23 | |
*** jtomasek has quit IRC | 09:30 | |
*** alexpilotti has quit IRC | 09:32 | |
*** jtomasek has joined #openstack-horizon | 09:33 | |
*** oro has joined #openstack-horizon | 09:37 | |
*** robcresswell_afk is now known as robcresswell | 09:39 | |
*** JeanBriceCombebi has joined #openstack-horizon | 09:39 | |
robcresswell | Ooooh the Angular wizard went in | 09:41 |
*** e0ne has joined #openstack-horizon | 09:41 | |
*** sayan has quit IRC | 09:43 | |
*** jtomasek has quit IRC | 09:43 | |
*** MaxV has joined #openstack-horizon | 09:45 | |
*** jcoufal has joined #openstack-horizon | 09:46 | |
*** e0ne has quit IRC | 09:49 | |
*** e0ne has joined #openstack-horizon | 09:50 | |
*** early has quit IRC | 09:51 | |
*** SlickNik has quit IRC | 09:52 | |
*** jpich has quit IRC | 09:52 | |
*** raildo has quit IRC | 09:53 | |
*** jcoufal has quit IRC | 09:55 | |
*** sayan has joined #openstack-horizon | 09:56 | |
*** SlickNik has joined #openstack-horizon | 09:57 | |
*** jtomasek has joined #openstack-horizon | 09:57 | |
*** jpich has joined #openstack-horizon | 10:06 | |
*** raildo has joined #openstack-horizon | 10:06 | |
*** chlong has joined #openstack-horizon | 10:09 | |
*** oro has quit IRC | 10:12 | |
*** agvanya has joined #openstack-horizon | 10:14 | |
*** aix has joined #openstack-horizon | 10:16 | |
*** agvanya_ has joined #openstack-horizon | 10:17 | |
*** JeanBriceCombebi has quit IRC | 10:20 | |
*** bluex-pl has joined #openstack-horizon | 10:21 | |
*** bluex-pl has quit IRC | 10:21 | |
*** bluex-pl has joined #openstack-horizon | 10:22 | |
*** sayan has quit IRC | 10:22 | |
*** JeanBriceCombebi has joined #openstack-horizon | 10:22 | |
*** pkarikh has quit IRC | 10:23 | |
*** e0ne is now known as e0ne_ | 10:23 | |
*** sayan has joined #openstack-horizon | 10:24 | |
*** e0ne_ is now known as e0ne | 10:25 | |
*** pkarikh has joined #openstack-horizon | 10:25 | |
*** jcoufal has joined #openstack-horizon | 10:33 | |
*** bpokorny has quit IRC | 10:36 | |
*** bpokorny has joined #openstack-horizon | 10:44 | |
*** JeanBriceCombebi has quit IRC | 10:54 | |
*** bpokorny has quit IRC | 10:55 | |
*** amotoki has joined #openstack-horizon | 10:56 | |
*** JeanBriceCombebi has joined #openstack-horizon | 10:56 | |
*** bpokorny has joined #openstack-horizon | 11:01 | |
*** bpokorny has quit IRC | 11:07 | |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds styling of "Confirm Password" Field in user forms https://review.openstack.org/153520 | 11:11 |
*** ishant has quit IRC | 11:11 | |
*** bpokorny has joined #openstack-horizon | 11:15 | |
*** akrivoka has joined #openstack-horizon | 11:27 | |
*** teju has left #openstack-horizon | 11:31 | |
*** zigo has quit IRC | 11:42 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Addresses Detail page inconsistencies & code style https://review.openstack.org/151762 | 11:46 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Fixes inconsistent Router Details page https://review.openstack.org/151226 | 11:46 |
*** dachary has quit IRC | 11:48 | |
*** dachary has joined #openstack-horizon | 11:48 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Applies ImageFormCtrl to Admin > Images https://review.openstack.org/136744 | 11:49 |
robcresswell | pkarikh: Don't suppose you feel like reviewing a mammoth patch? https://review.openstack.org/#/c/151762/9 :p | 11:51 |
*** e0ne is now known as e0ne_ | 11:54 | |
nikunj2512 | jpich: hi, i have a question about Launch Clusters.. In Launch Cluster form, we can import a keypair from the Launch Cluster form but if user don't have any image, they have to go to images panel to upload the image. Will it be good usecase to allow users to dynamically upload the image from the Launch Cluster form? | 11:54 |
pkarikh | robcresswell: wow.. Are you trying to refactor whole Horizon? :D | 11:54 |
robcresswell | pkarikh: No, its just the details pages :( | 11:54 |
robcresswell | pkarikh: The line count is really high because of file renames... May revert it just so it actually gets reviewed | 11:55 |
robcresswell | pkarikh: It adds a common detail template and changes the styling so they all look consistent. Bit of a nightmare. | 11:55 |
*** JeanBriceCombebi has quit IRC | 11:58 | |
*** bradjones has quit IRC | 11:59 | |
*** e0ne_ is now known as e0ne | 11:59 | |
*** zul has joined #openstack-horizon | 11:59 | |
*** dsneddon has quit IRC | 12:00 | |
pkarikh | robcresswell: rdopiera has replased icons in whole horizon with a few patches. So maybe if you divide it into several patches it will be reviewed a little bit faster.. For example as admin, than jobs, than clusters. It's really hard to find out how to separate them. | 12:00 |
*** dsneddon has joined #openstack-horizon | 12:00 | |
pkarikh | robcresswell: how many time did you spent on it? | 12:00 |
robcresswell | pkarikh: Yeah, I think that may the only way to do it. Will have to leave it to next week when I have some more time. | 12:01 |
*** zul has quit IRC | 12:01 | |
*** zul has joined #openstack-horizon | 12:01 | |
robcresswell | pkarikh: Just been a gradual thing. It isn't complex... just repetitive. | 12:01 |
*** bradjones has joined #openstack-horizon | 12:02 | |
nikunj2512 | ttrifonov: Hi, please can you take a look at this patch -> https://review.openstack.org/#/c/135256/4 as per your convience | 12:03 |
pkarikh | robcresswell: '+629, -1122' sounds like core-reviewers nightmare. :D | 12:03 |
robcresswell | pkarikh: Yeah, the previous one was only about +300 -600. It hasnt picked up the renames, thinks they are new files :( | 12:04 |
*** julim has quit IRC | 12:04 | |
robcresswell | pkarikh: Which is *very* frustrating. | 12:04 |
robcresswell | pkarikh: I'll break it down next week, ha | 12:05 |
*** bluex-pl has quit IRC | 12:06 | |
*** bluex-pl has joined #openstack-horizon | 12:06 | |
*** julim has joined #openstack-horizon | 12:06 | |
*** jroll has quit IRC | 12:06 | |
pkarikh | robcresswell: or you can just wait till most patient reviewers will see your patch. :) However, I'll try to take a look later. | 12:13 |
openstackgerrit | Merged openstack/tuskar-ui: Remove outdated FIXME https://review.openstack.org/153275 | 12:14 |
robcresswell | pkarikh: Thankyou, I appreciate it. As I said, it isn't terribly complex, just *big*. | 12:17 |
robcresswell | pkarikh: And its mainly HTML - easiest test is just to pull it and look through :) | 12:18 |
*** zul has quit IRC | 12:19 | |
*** dachary has quit IRC | 12:19 | |
*** miguelgrinberg has quit IRC | 12:19 | |
*** medberry has quit IRC | 12:19 | |
*** mgagne has quit IRC | 12:19 | |
*** jroll has joined #openstack-horizon | 12:20 | |
*** zul has joined #openstack-horizon | 12:20 | |
*** medberry has joined #openstack-horizon | 12:20 | |
*** dachary has joined #openstack-horizon | 12:20 | |
*** miguelgrinberg has joined #openstack-horizon | 12:20 | |
*** mgagne has joined #openstack-horizon | 12:20 | |
pkarikh | robcresswell: no problem. :) | 12:27 |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Wait till spinner disappears https://review.openstack.org/151608 | 12:49 |
*** sayan has quit IRC | 12:49 | |
pkarikh | Hi all Do we have any bugs/blueprints about page load speed? I'm interested in the list of most 'heavy' pages in Horizon. Do we have any? | 12:52 |
robcresswell | pkarikh: mattfarina has some ongoing work around JS memory management/cleanup, so he may have a good idea of slower pages | 12:56 |
*** early has joined #openstack-horizon | 13:01 | |
*** masco has quit IRC | 13:03 | |
jpich | nikunj2512: Hi! I'm afraid I'm not very familiar with the Launch Cluster page, so I don't have any special thoughts on what could make it better, sorry. If you think there is a justification for this and it would be a good improvement, and that wouldn't be too complex to maintain - go for it! | 13:04 |
nikunj2512 | jpich: Ok.. Thank You | 13:05 |
*** early has quit IRC | 13:08 | |
*** chaii has joined #openstack-horizon | 13:09 | |
*** rushiagr is now known as rushiagr_away | 13:10 | |
*** lblanchard has joined #openstack-horizon | 13:11 | |
*** lblanchard has quit IRC | 13:13 | |
*** tzumainn has joined #openstack-horizon | 13:14 | |
*** JeanBriceCombebi has joined #openstack-horizon | 13:14 | |
*** chaii has quit IRC | 13:16 | |
*** athomas has joined #openstack-horizon | 13:16 | |
openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Auto-discover missing node parameters by default https://review.openstack.org/152219 | 13:19 |
*** alexpilotti has joined #openstack-horizon | 13:20 | |
*** bluex-pl has quit IRC | 13:25 | |
pkarikh | robcresswell: thanks! | 13:27 |
openstackgerrit | Merged openstack/tuskar-ui: Remove Inheritable*TestCase https://review.openstack.org/150454 | 13:31 |
*** lblanchard has joined #openstack-horizon | 13:32 | |
*** gerchardon has quit IRC | 13:35 | |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Improves Launch Cluster model in Data Processing panel https://review.openstack.org/135256 | 13:44 |
ekarlso | why does horizon do The settings.py file points to a v2.0 keystone endpoint, but v3 is specified as the API version to use. Using v3 endpoint for authentication. | 13:45 |
ekarlso | when I tell it to use v2 ? | 13:45 |
nikunj2512 | ekarlso: You by default horizon uses V2 | 13:46 |
ekarlso | nikunj2512: why does it use v3 then ?! | 13:47 |
nikunj2512 | ekarlso: but for you if Horizon is using keystone v3 than you can goto openstack_dashboard/local/local_settings.py and check there if Keystone V3 is enables or not | 13:47 |
ekarlso | it's not ... | 13:48 |
ekarlso | i've told it to use v2 | 13:48 |
*** sayan has joined #openstack-horizon | 13:48 | |
nikunj2512 | ekarlso: Where you told it to use v2? | 13:48 |
*** oro has joined #openstack-horizon | 13:48 | |
*** cbader has quit IRC | 13:49 | |
*** _crobertsrh is now known as crobertsrh | 13:49 | |
nikunj2512 | ekarlso: the setting in local_settings.py file is to use v3 and when horizon doesn't find the value of OPENSTACK_API_VERSIONS, it uses v2 | 13:49 |
*** rushiagr_away is now known as rushiagr | 13:50 | |
*** athomas has quit IRC | 13:52 | |
nikunj2512 | ekarlso: see here -> this is the code which tell keystone which version to use -> https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L61 | 13:52 |
*** bluex-pl has joined #openstack-horizon | 13:58 | |
*** bluex-pl has quit IRC | 13:58 | |
*** bluex-pl has joined #openstack-horizon | 13:59 | |
openstackgerrit | Wu Hong Guang proposed openstack/horizon: Integration test - Create and delete user https://review.openstack.org/143027 | 14:00 |
pkarikh | Does anyone know when lcheng usualy is around here? | 14:03 |
*** jroll has quit IRC | 14:03 | |
*** jroll has joined #openstack-horizon | 14:03 | |
*** quist` has quit IRC | 14:05 | |
robcresswell | pkarikh: US I believe - going back through logs. Have to be up late :p | 14:06 |
*** neelashah has joined #openstack-horizon | 14:08 | |
*** radez_g0n3 is now known as radez | 14:11 | |
openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Refactor, customization and fixes of Metadata Widget https://review.openstack.org/136437 | 14:14 |
openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata display widget https://review.openstack.org/151745 | 14:14 |
*** rm_work|away is now known as rm_work | 14:17 | |
openstackgerrit | Wu Hong Guang proposed openstack/horizon: Integration tests - Run test on Windows with Chrome or IE https://review.openstack.org/147426 | 14:24 |
*** obutenko has joined #openstack-horizon | 14:25 | |
*** davelowe has joined #openstack-horizon | 14:28 | |
openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata widget multivalue selection support https://review.openstack.org/153210 | 14:28 |
*** sseago has joined #openstack-horizon | 14:30 | |
openstackgerrit | Wu Hong Guang proposed openstack/horizon: Integration tests - Run test on Windows with Chrome or IE https://review.openstack.org/147426 | 14:31 |
*** Ctina_ has joined #openstack-horizon | 14:31 | |
*** mpavlase has quit IRC | 14:31 | |
*** mattfarina has joined #openstack-horizon | 14:32 | |
*** sseago has left #openstack-horizon | 14:34 | |
*** ZZelle has quit IRC | 14:35 | |
*** ZZelle has joined #openstack-horizon | 14:35 | |
*** JeanBriceCombebi has quit IRC | 14:37 | |
*** jpomero has joined #openstack-horizon | 14:39 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:40 | |
pkarikh | mattfarina: Hello! Do you have a few minutes? | 14:40 |
mattfarina | pkarikh sure. what's up? | 14:51 |
*** markus_z has quit IRC | 14:55 | |
pkarikh | mattfarina: I'm interested about some list of most heavy/long loading pages in horizon. robcresswell said that you could know something about fast/slow pages. | 14:57 |
mattfarina | i know some things. they happen for a number of reasons. is there something specific you're looking for or to do? | 14:58 |
*** vijendar has joined #openstack-horizon | 15:03 | |
openstackgerrit | Merged openstack/tuskar-ui: Make node registration fields required https://review.openstack.org/153265 | 15:06 |
mattfarina | pkarikh are you looking to improve JS, clean up API calls, or something else? | 15:11 |
*** Drago has joined #openstack-horizon | 15:12 | |
*** Drago has quit IRC | 15:12 | |
pkarikh | mattfarina: oh, sorry, haven't seen you answer. At this moment I just wont to know which pages are most slow | 15:12 |
*** Drago has joined #openstack-horizon | 15:12 | |
*** rushiagr is now known as rushiagr_away | 15:15 | |
*** stevemar has joined #openstack-horizon | 15:17 | |
mattfarina | pkarikh i've not walked through horizon to know for sure. but, on table listings that are long (like /identity/users with hundreds of users) you have lag. See https://bugs.launchpad.net/horizon/+bug/1411892 | 15:20 |
openstack | Launchpad bug 1411892 in OpenStack Dashboard (Horizon) "JS keyup/keydown making user create very difficult" [Undecided,New] - Assigned to Chris Johnson (wchrisjohnson) | 15:20 |
mattfarina | pkarikh this has to do with the keydown event and the :input jquery psuedo selector | 15:20 |
mattfarina | pkarikh on a page like that if you try to create a user you might see a lag of a few seconds from touching a key to a character showing up in a form | 15:21 |
pkarikh | mattfarina: hm.. Ok, thanks. Right now I'm more insterested about just how long page is loaded frim server into the browser, but your info is very interesting too, thanks! | 15:22 |
mattfarina | pkarikh ah. ok. i'll have to get back with you on that. i'm heading out the door on vacation and can't grab that information until I get back | 15:23 |
nikunj2512 | ttrifonov: Hi, i have addressed your comments in this patch ->https://review.openstack.org/#/c/135256/ | 15:24 |
pkarikh | mattfarina: ok, thanks. Have a nice vacations! :) | 15:26 |
openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Auto-discover missing node parameters by default https://review.openstack.org/152219 | 15:29 |
*** Piet has joined #openstack-horizon | 15:31 | |
*** athomas has joined #openstack-horizon | 15:33 | |
*** JeanBriceCombebi has quit IRC | 15:33 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 15:40 |
*** MaxV has quit IRC | 15:44 | |
*** neelashah has quit IRC | 15:46 | |
*** nikunj2512 has quit IRC | 15:47 | |
*** bpokorny has quit IRC | 15:52 | |
*** lnxnut has joined #openstack-horizon | 15:54 | |
openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/153476 | 15:55 |
*** oro has quit IRC | 16:02 | |
*** bluex-pl has quit IRC | 16:06 | |
*** david-lyle_afk is now known as david-lyle | 16:07 | |
*** bpokorny has joined #openstack-horizon | 16:10 | |
openstackgerrit | Paul Karikh proposed openstack/horizon: Remove admin role name 'admin' hardcode https://review.openstack.org/123741 | 16:13 |
*** TravT has quit IRC | 16:18 | |
openstackgerrit | Randy Bertram proposed openstack/horizon: Serial Console https://review.openstack.org/144659 | 16:19 |
*** jcoufal has quit IRC | 16:19 | |
*** openstackgerrit has quit IRC | 16:21 | |
*** openstackgerrit has joined #openstack-horizon | 16:22 | |
*** TravT has joined #openstack-horizon | 16:34 | |
openstackgerrit | Paul Karikh proposed openstack/horizon: Remove admin role name 'admin' hardcode https://review.openstack.org/123741 | 16:35 |
pkarikh | david-lyle: hello! Could you please take a look at this patch (custom admin roles and RBAC) and tell me if I'm going in right or wrong direction. Thnak you! | 16:38 |
pkarikh | david-lyle: hello! Could you please take a look at this patch (custom admin roles and RBAC) and tell me if I'm going in right or wrong direction. Thnak you! Here the patch: https://review.openstack.org/#/c/123741/ | 16:39 |
pkarikh | I'm sorry for spam :( | 16:39 |
*** pkarikh has quit IRC | 16:39 | |
*** pkarikh has joined #openstack-horizon | 16:40 | |
*** nikunj2512_ has joined #openstack-horizon | 16:40 | |
pkarikh | robcresswell: sorry, I haven't enough time to take a look on your patch. I'll try to do it on Monday. | 16:42 |
*** ybathia has joined #openstack-horizon | 16:46 | |
*** pkarikh has quit IRC | 16:48 | |
*** enykeev has quit IRC | 16:50 | |
*** enykeev has joined #openstack-horizon | 16:52 | |
*** nlahouti has joined #openstack-horizon | 16:53 | |
*** josecastroleon has quit IRC | 16:57 | |
*** cbader has joined #openstack-horizon | 16:59 | |
*** jtomasek has quit IRC | 17:00 | |
*** nikunj2512_ has quit IRC | 17:05 | |
*** sayan has quit IRC | 17:05 | |
*** nikunj2512_ has joined #openstack-horizon | 17:05 | |
*** lhcheng has joined #openstack-horizon | 17:06 | |
*** rwsu-afk is now known as rwsu | 17:09 | |
*** Ala has quit IRC | 17:12 | |
*** ttrifonov is now known as zz_ttrifonov | 17:14 | |
nikunj2512_ | akrivoka: Please can you take a look at this patch -> https://review.openstack.org/#/c/124712/, as per your convenience | 17:16 |
*** bpokorny_ has joined #openstack-horizon | 17:20 | |
*** raildo has quit IRC | 17:20 | |
*** rwsu has quit IRC | 17:20 | |
*** bpokorny has quit IRC | 17:23 | |
*** early has joined #openstack-horizon | 17:23 | |
*** e0ne has quit IRC | 17:24 | |
*** fischerw has joined #openstack-horizon | 17:24 | |
*** sqchen has joined #openstack-horizon | 17:24 | |
*** raildo has joined #openstack-horizon | 17:24 | |
*** jpich has quit IRC | 17:28 | |
*** alexvictorchan has joined #openstack-horizon | 17:29 | |
*** sayan has joined #openstack-horizon | 17:30 | |
*** obutenko has quit IRC | 17:34 | |
*** sivy has joined #openstack-horizon | 17:39 | |
sivy | good morning | 17:39 |
*** radez is now known as radez_g0n3 | 17:43 | |
*** ZZelle has quit IRC | 17:44 | |
fischerw | david-lyle: If you get a chance, can you take a look at https://review.openstack.org/#/c/145870/. It is my understanding that this documentation change was something you asked for. Thanks. | 17:45 |
*** sqchen has quit IRC | 17:45 | |
fischerw | david-lyle: I work with gugl, gary-smith, jgravel, and rhagarty. | 17:47 |
*** rwsu has joined #openstack-horizon | 17:49 | |
*** ZZelle has joined #openstack-horizon | 17:50 | |
*** tjones1 has joined #openstack-horizon | 17:51 | |
tjones1 | hi - i am trying to populate a dropdown menu based on the selection in another dropdown. are there examples of how to accomplish this? | 17:52 |
*** ygbo has quit IRC | 17:55 | |
robcresswell | sivy: Evening! :p | 17:56 |
*** neelashah has joined #openstack-horizon | 17:58 | |
*** sqchen has joined #openstack-horizon | 17:59 | |
*** early has quit IRC | 18:00 | |
*** garthb has joined #openstack-horizon | 18:01 | |
*** gyee has joined #openstack-horizon | 18:03 | |
*** garthb has quit IRC | 18:05 | |
*** early has joined #openstack-horizon | 18:06 | |
*** bpokorny has joined #openstack-horizon | 18:07 | |
*** bpokorny_ has quit IRC | 18:10 | |
tjones1 | looks like i need to use DynamicSelectWidget - so i am searching for examples of that | 18:12 |
*** harlowja has joined #openstack-horizon | 18:15 | |
*** early has quit IRC | 18:20 | |
*** e0ne has joined #openstack-horizon | 18:26 | |
*** sayan has quit IRC | 18:30 | |
*** bpokorny_ has joined #openstack-horizon | 18:33 | |
*** bpokorn__ has joined #openstack-horizon | 18:35 | |
*** bpokorny has quit IRC | 18:36 | |
*** bpokorny_ has quit IRC | 18:38 | |
*** early has joined #openstack-horizon | 18:38 | |
openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Join node registration and upload forms https://review.openstack.org/153650 | 18:41 |
*** bpokorny has joined #openstack-horizon | 18:42 | |
*** bpokorn__ has quit IRC | 18:45 | |
*** sayan has joined #openstack-horizon | 18:50 | |
*** early has quit IRC | 18:53 | |
nikunj2512_ | david-lyle: Hi, please take a look at this patch-> https://review.openstack.org/#/c/135256/4 as per your convenience | 18:54 |
*** TravT has quit IRC | 18:56 | |
*** TravT_ has joined #openstack-horizon | 18:57 | |
*** oro has joined #openstack-horizon | 19:01 | |
*** mattfarina has quit IRC | 19:04 | |
*** mattfarina has joined #openstack-horizon | 19:04 | |
*** Ctina_ is now known as Ctina | 19:05 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: add .idea to gitignore https://review.openstack.org/153662 | 19:05 |
*** sayan has quit IRC | 19:05 | |
*** akrivoka has quit IRC | 19:07 | |
*** alexpilotti has quit IRC | 19:12 | |
*** nikunj2512_ has quit IRC | 19:23 | |
*** nikunj2512_ has joined #openstack-horizon | 19:24 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided job execution page for Sahara https://review.openstack.org/147918 | 19:26 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara https://review.openstack.org/147677 | 19:26 |
*** e0ne has quit IRC | 19:28 | |
*** tqtran has joined #openstack-horizon | 19:31 | |
*** oro has quit IRC | 19:38 | |
*** mpavlase has joined #openstack-horizon | 19:45 | |
*** Miouge has joined #openstack-horizon | 19:46 | |
*** bradjones has quit IRC | 19:47 | |
*** early has joined #openstack-horizon | 19:50 | |
*** Ctina has quit IRC | 19:50 | |
*** bradjones has joined #openstack-horizon | 19:50 | |
*** radez_g0n3 is now known as radez | 19:50 | |
*** early has quit IRC | 19:53 | |
*** ctina has joined #openstack-horizon | 19:54 | |
*** early has joined #openstack-horizon | 19:58 | |
*** ctina has left #openstack-horizon | 19:59 | |
*** ctina has joined #openstack-horizon | 20:00 | |
*** early has quit IRC | 20:03 | |
*** ctina has quit IRC | 20:05 | |
*** early has joined #openstack-horizon | 20:07 | |
*** raildo has quit IRC | 20:07 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 20:07 |
openstackgerrit | Kelly Domico proposed openstack/horizon: Re-designed and Angularized tables https://review.openstack.org/147393 | 20:08 |
openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Re-designed Tables https://review.openstack.org/151101 | 20:09 |
*** bpokorny_ has joined #openstack-horizon | 20:09 | |
*** nlahouti has quit IRC | 20:10 | |
*** bpokorn__ has joined #openstack-horizon | 20:11 | |
*** bpokorny has quit IRC | 20:13 | |
ongk | tqtran: ping | 20:13 |
*** bpokorny_ has quit IRC | 20:14 | |
*** early has quit IRC | 20:14 | |
tqtran | ongk: pong | 20:17 |
ongk | tqtran: updated the table docs. Used ngdoc. Do you have a preference? | 20:18 |
ongk | vs jsdoc? | 20:18 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara https://review.openstack.org/147677 | 20:19 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided job execution page for Sahara https://review.openstack.org/147918 | 20:19 |
tqtran | ngdoc is fine | 20:19 |
ongk | there isn’t a mechanism in place to generate the docs yet, is there? | 20:20 |
*** nlahouti has joined #openstack-horizon | 20:20 | |
*** early has joined #openstack-horizon | 20:24 | |
openstackgerrit | Merged openstack/horizon: add angular-bootstrap to jasmine spec runner page https://review.openstack.org/152814 | 20:31 |
fischerw | david-lyle: thanks for the review. will push changes later today. | 20:33 |
david-lyle | fischerw: np, thanks for your efforts | 20:33 |
* TravT_ is sad... just discovered computer is on corporate network and can't pull patches. | 20:35 | |
*** TravT has joined #openstack-horizon | 20:36 | |
david-lyle | wifi | 20:37 |
david-lyle | TravT | 20:37 |
TravT | yep | 20:37 |
david-lyle | or are you somewhere else? | 20:37 |
TravT | no, i'm in the office | 20:37 |
*** stevemar has quit IRC | 20:37 | |
TravT | just switched, so good to go again | 20:37 |
*** stevemar has joined #openstack-horizon | 20:38 | |
*** TravT_ has quit IRC | 20:38 | |
TravT | ongk: are you there? | 20:40 |
ongk | TravT: yup, what’s up? | 20:40 |
TravT | is your demo patch supposed to also include sorting? | 20:40 |
ongk | Not at the moment. Don’t have the dragAndDrop library in Horizon yet | 20:41 |
TravT | ok. | 20:41 |
TravT | so that will be a subsequent patch? | 20:41 |
ongk | Oh wait - I misunderstood maybe. I was thinking re-ordering the rows. | 20:42 |
TravT | no, i'm thinking the sort by clicking table row header | 20:42 |
ongk | I didn’t include sorting in the demo patch but can probably do that | 20:42 |
TravT | yeah, drag and drop is something diff | 20:43 |
david-lyle | I'm definitely pro-sorting | 20:43 |
david-lyle | :D | 20:43 |
TravT | yeah, if you can include the demo of sorting. | 20:44 |
david-lyle | sorting > no sorting | 20:44 |
tqtran | sorting? you dont need that | 20:44 |
TravT | I'd like to see how that works in comparison to the mockups we all went through. | 20:44 |
david-lyle | see what I did there | 20:44 |
david-lyle | tqtran: well, I don't | 20:44 |
david-lyle | but some may | 20:44 |
ongk | sure, will do | 20:44 |
david-lyle | ongk: your nick was not obvious | 20:45 |
tqtran | david-lyle: i believe thats her last name | 20:45 |
david-lyle | saw it many times thinking, who is that? | 20:45 |
david-lyle | eh-eh | 20:45 |
* tqtran laughs secretly.... | 20:45 | |
ongk | haha | 20:45 |
david-lyle | ah | 20:45 |
david-lyle | such shenanigans | 20:46 |
esp | ;) | 20:46 |
TravT | \me was actually just thinking of how Dan's nick is also non-obvious | 20:46 |
* TravT can't type correctly slash | 20:47 | |
esp | well yeh… | 20:47 |
david-lyle | he already knew that | 20:47 |
esp | blame the rax dudes, they all had such cool handles | 20:47 |
esp | I didn’t want to appear inadequate at that too | 20:47 |
TravT | lol | 20:47 |
ongk | sadly, someone started using my other name to buy stuff at Urban Outfitters | 20:49 |
*** early has quit IRC | 20:49 | |
esp | david-lyle: I’m hoping to get a new patchset up soon for domain-scoped-tokens work today | 20:49 |
esp | your DOA patch looks good so far | 20:50 |
david-lyle | inconceivable | 20:50 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Correcting JavaScript files order https://review.openstack.org/153686 | 20:50 |
david-lyle | It worked what I tried it out | 20:50 |
esp | seriously, I was gonna get my bag of +1’s out and everything.. | 20:50 |
david-lyle | in all the cases I claimed, but let me know where I mucked it up | 20:51 |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:51 | |
TravT | where do you get that bag of +1's? | 20:51 |
esp | np, I’m sure I’ve got some things to iron out too | 20:51 |
TravT | Do they sell those in Washington state? | 20:52 |
esp | TravT: I stole them ;) | 20:52 |
TravT | ok... thought maybe they'd be in the new vending machines I heard about | 20:52 |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 20:53 |
ongk | TravT: ha, don’t need to buy ‘em. Just walk down the street and get it for free | 20:54 |
*** bpokorny has joined #openstack-horizon | 20:55 | |
*** htruta has quit IRC | 20:55 | |
TravT | ongk: lol | 20:58 |
*** bpokorn__ has quit IRC | 20:58 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Re-designed Tables https://review.openstack.org/151101 | 21:00 |
* TravT pulls https://review.openstack.org/151101 | 21:01 | |
ongk | TravT: username is sorted by default | 21:01 |
david-lyle | hopefully that's true for all tables | 21:02 |
david-lyle | :D | 21:02 |
TravT | just pulled it. was very disappointed i could sort by action buttons. ;-) | 21:03 |
TravT | could -> couldn't | 21:03 |
TravT | ongk: sort looks just like the mocks. awesome | 21:04 |
ongk | TravT: is that hover sort icon too light? | 21:05 |
TravT | let me see if i can grab piet | 21:05 |
TravT | to get his opinion | 21:05 |
ongk | I can make it bright red. j/k | 21:06 |
Piet | Travis, need you in an interview | 21:06 |
TravT | i vaguely remember discussions of pink and fuschia | 21:06 |
TravT | Piet: ok | 21:07 |
david-lyle | Piet can you really call for help in interviews? | 21:07 |
david-lyle | if you don't know the answer, fess up | 21:07 |
Piet | Funny... | 21:07 |
david-lyle | I bet | 21:07 |
TravT | ROFL | 21:07 |
Piet | Travis, stop laughing and get into the interview! | 21:08 |
david-lyle | at least you'll have an answer for what's your greatest weakness | 21:08 |
*** Miouge has quit IRC | 21:08 | |
david-lyle | err, opportunity for improvement | 21:08 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Data Processing: changing labels of submit buttons https://review.openstack.org/153693 | 21:09 |
Piet | My social skills? | 21:10 |
Piet | You should be nice...this person will be doing UX work for the community fulltime | 21:10 |
david-lyle | ok, 2 opportunities | 21:10 |
david-lyle | :D | 21:10 |
david-lyle | oooh, nice | 21:11 |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 21:11 |
Piet | david; you might be interviewing him at some point | 21:11 |
sqchen | david-lyle: Hi David, please take a look at https://review.openstack.org/153686, a first step to inject javascript file from HORIZON.js_files. | 21:12 |
david-lyle | if you want | 21:12 |
david-lyle | Piet | 21:12 |
*** jpomero has quit IRC | 21:13 | |
openstackgerrit | David Lyle proposed openstack/horizon: Making modify usage report params modal https://review.openstack.org/153694 | 21:13 |
*** gary-smith_ has joined #openstack-horizon | 21:13 | |
david-lyle | Low-hanging review there folks ^^^^ | 21:14 |
david-lyle | changing the world | 21:14 |
david-lyle | one css class at a time | 21:14 |
esp | david-lyle: you should hire some PR ;) | 21:14 |
david-lyle | I certainly need help | 21:15 |
*** alexvictorchan has quit IRC | 21:16 | |
*** alexvictorchan has joined #openstack-horizon | 21:16 | |
david-lyle | sqchen: I look in a little bit, busy changing the world | 21:16 |
david-lyle | Thanks for looking into it | 21:17 |
sqchen | just want to get the direction right. :) | 21:17 |
david-lyle | tqtran, r1chardj0n3s and I were discussing a bit yesterday | 21:18 |
david-lyle | *discussing it | 21:18 |
r1chardj0n3s | running away from it | 21:18 |
r1chardj0n3s | looking at it all side-eye | 21:18 |
david-lyle | r1chardj0n3s: it's saturday, you punishing yourself for something? | 21:19 |
r1chardj0n3s | you lot are always busy on Friday afternoons/evenings so it behooves me to drop in an see what you are all up to so there's no big surprises on Monday :) | 21:19 |
r1chardj0n3s | also Monday is really quiet ;) | 21:19 |
david-lyle | sqchen: I should have looked before punting | 21:21 |
david-lyle | I was expecting something monstrous | 21:21 |
david-lyle | That's a reasonable start | 21:22 |
david-lyle | why we were loading them in earlier is a mystery to me | 21:22 |
david-lyle | sqchen: question, how does a new angular panel in the horizon tree take advantage of this? | 21:24 |
sqchen | I guess people don’t know what we want to add to the js_files. | 21:24 |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 21:24 | |
david-lyle | sqchen: for extensions it's easy | 21:24 |
david-lyle | for in-tree the issue I had was do we really want to hard-code all these | 21:25 |
david-lyle | maybe we just move all panels to be plugins | 21:25 |
david-lyle | that live in tree | 21:25 |
david-lyle | have them specify their custom js files in the enabled/my_panel.py file | 21:26 |
david-lyle | and their modules | 21:26 |
david-lyle | tqtran: thoughts | 21:26 |
david-lyle | sqchen: but the loading order should be fixed either way | 21:27 |
david-lyle | so your patch makes sense | 21:27 |
sqchen | Having the file listed centrally somewhere make sense to me. With that we do not need to redo the same thing for jasmine test | 21:27 |
david-lyle | sqchen: which file? | 21:27 |
david-lyle | to include in the jasmine test runs? | 21:28 |
sqchen | sorrey, having all the js files listed ... | 21:28 |
david-lyle | but jasmine is a good point | 21:28 |
david-lyle | we will want to tie them in there as well | 21:28 |
sqchen | my typing is very slow… | 21:28 |
david-lyle | maybe a test_js_files field in the enabled/my_panel.py file as well | 21:29 |
tqtran | tqtran: one sec, catching up on chat | 21:29 |
sqchen | currently all js sources and spec are defined in another python class. | 21:30 |
TravT | tqtran: do you always talk to yourself? | 21:30 |
david-lyle | won't auto complete my own nick | 21:31 |
sqchen | currently all js sources and spec files for Jasmine are defined in another python class. | 21:31 |
* david-lyle makes be a smart-ass harder | 21:31 | |
*** radez is now known as radez_g0n3 | 21:31 | |
david-lyle | sqchen: don't you think that will need to be pluggable? | 21:31 |
esp | haha | 21:31 |
tqtran | TravT: dont we all? :P | 21:32 |
david-lyle | I think if you analyzed my contributions in IRC, you would deduce my English fluency is that of an eight year old | 21:32 |
david-lyle | not, far off actually | 21:32 |
sqchen | So if we could have source files defined for production AND jasmine togeter somewhere. it will save us some time. | 21:33 |
tqtran | sqchen, david-lyle: so my concern is that we're basically moving the hardcode from one location to another | 21:33 |
david-lyle | an enabled file | 21:33 |
david-lyle | tqtran: it's all hard-coded at some level | 21:33 |
esp | bpokorny: thx for review comments, fixin some of them now | 21:33 |
tqtran | sqchen: but i do agree that this is a small step that would help with jasmine tests | 21:33 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara https://review.openstack.org/147677 | 21:34 |
bpokorny | esp: No problem. Sounds good. | 21:34 |
david-lyle | tqtran: it's localized to the panel directory, or enabled file | 21:34 |
tqtran | david-lyle: it just seems a bit strange to me that we would move our js files to a settings CONFIG object | 21:34 |
david-lyle | tqtran: only for panel specific js | 21:35 |
david-lyle | not general widgets | 21:35 |
david-lyle | the file paths, not the files | 21:35 |
tqtran | david-lyle: if that were the case, it makes little sense to do it for jasmine tests even. since jasmine tests will require all of the widgets be present to test | 21:35 |
david-lyle | I want jasmine to run tests for the panels too, no? | 21:36 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided job execution page for Sahara https://review.openstack.org/147918 | 21:36 |
david-lyle | there are two classes of js code here | 21:36 |
sqchen | david_lyle: I don’t understand the how plug system works yet. | 21:36 |
tqtran | david-lyle: yes, but now the config object will explode | 21:36 |
david-lyle | general purpose and specific | 21:36 |
david-lyle | for general, it makes sense to lump them all together in a link file | 21:37 |
david-lyle | s/link/import/ | 21:37 |
david-lyle | tqtran: with what, 10 path strings? | 21:37 |
david-lyle | the js files still live in the panel's static dir | 21:37 |
*** clu_ has joined #openstack-horizon | 21:37 | |
TravT | david-lyle: are you saying plugin per panel? | 21:37 |
TravT | or could we have plugins even within a panel. | 21:38 |
david-lyle | TravT: you win | 21:38 |
david-lyle | former not latter | 21:38 |
david-lyle | but latter eventually | 21:38 |
TravT | that would be super ideal | 21:38 |
david-lyle | but that mechanism doesn't exist yet | 21:38 |
david-lyle | the sub-plugin plugin | 21:38 |
TravT | one of the biggest problems projects face in horizon is that they essentially can't "decorate" a panel with extra functionality | 21:39 |
david-lyle | they can, but it's requires some stake in the game | 21:39 |
TravT | exactly. | 21:39 |
TravT | well, maybe. | 21:40 |
TravT | can you clarify | 21:40 |
david-lyle | a custom horizon app with template overrides | 21:40 |
david-lyle | the main way to do extensive modifications to horizon | 21:40 |
TravT | ok. | 21:40 |
david-lyle | stake is they have to build and maintain that app | 21:40 |
TravT | yeah. | 21:40 |
david-lyle | but that's what most companies do already | 21:41 |
david-lyle | unless they are delivering vanilla horizon | 21:41 |
*** amotoki has quit IRC | 21:41 | |
tqtran | david-lyle: ok I get what you're saying about template overrides, but im not sure how that is connected to the config object | 21:41 |
david-lyle | sqchen: the system actually works pretty well | 21:41 |
tqtran | david-lyle: you kinda lost me there | 21:42 |
david-lyle | the config object contains an optional field to specify js files in your plugin to add to the _scripts.html file dynamically | 21:43 |
* TravT happy not the only one.... i thought we were talking about angular plugins for a panel. | 21:43 | |
david-lyle | reset | 21:43 |
david-lyle | we're trying to figure out a way to pull in js files from in tree panels without hard-coding them in _scripts.html | 21:44 |
tqtran | david-lyle: but couldnt you do that already if you extend the _script template? | 21:44 |
TravT | but tqtran: isn't that an all or nothing? | 21:45 |
david-lyle | tqtran: if I have a _script file with 500 entries, I'll shoot myself | 21:45 |
tqtran | david-lyle: ok, just to clarify, when we have js files, are we talking about libraries, our js files, or plugin js files? | 21:45 |
tqtran | *when we say | 21:45 |
* robcresswell is starting to regret trying to fix every single Details page | 21:45 | |
tqtran | TravT: no, you can extend the template, its not a complete replacement | 21:45 |
*** nlahouti has quit IRC | 21:45 | |
tqtran | TravT: although you could replace it if you want to | 21:46 |
david-lyle | you want me to extend it for every panel? | 21:46 |
david-lyle | what if I want to use something cross-panel? | 21:46 |
tqtran | david-lyle: no, just once because its part of the base template | 21:46 |
tqtran | david-lyle: lets say you need js 1,2,3 for panels a,b,c. you would extend _scripts to include 1,2,3 and panels a,b,c should work | 21:47 |
david-lyle | where's sqchen's patch for launch instance? | 21:47 |
*** alexpilotti has joined #openstack-horizon | 21:47 | |
tqtran | https://review.openstack.org/#/c/152822/2/horizon/templates/horizon/_scripts.html | 21:48 |
*** nlahouti has joined #openstack-horizon | 21:48 | |
david-lyle | tqtran: yeah, that. that's not going to happen | 21:49 |
david-lyle | that makes no sense | 21:49 |
tqtran | david-lyle: so what are you proposing? that we move these includes into the config object? | 21:49 |
TravT | https://review.openstack.org/#/c/152822/ | 21:49 |
david-lyle | per panel | 21:49 |
TravT | Sean has a question on the bottom there | 21:49 |
david-lyle | we're discussing that now, I believe | 21:50 |
tqtran | david-lyle: per panel.... ok i'm starting to maybe follow | 21:50 |
tqtran | david-lyle: but the issue is that we are moving toward a single-page-app | 21:50 |
TravT | david-lyle: yes i agree with the premise of what you are saying | 21:50 |
*** vijendar has quit IRC | 21:50 | |
tqtran | david-lyle: so loading it per panel would actually be longer load time | 21:50 |
david-lyle | tqtran: some day, but you'll still need a dynamic mechanism to extend it | 21:51 |
TravT | tqtran: | 21:51 |
david-lyle | tqtran: not loading per panel | 21:51 |
david-lyle | specifying per panel | 21:51 |
TravT | the loaded modules would be injected into this dynamically? | 21:51 |
david-lyle | they all end up loaded here: https://review.openstack.org/#/c/153686/1/horizon/templates/horizon/_scripts.html line 69 | 21:51 |
*** oro has joined #openstack-horizon | 21:52 | |
tqtran | david-lyle: could you provide an example of what the config object would look like? | 21:52 |
sqchen | We may need a client-side dynamic mechanism to load JS file as well, in the future. | 21:52 |
david-lyle | real life extension today | 21:53 |
david-lyle | https://github.com/stackforge/monasca-ui/blob/master/monitoring/enabled/_50_admin_add_monitoring_panel.py | 21:53 |
david-lyle | so we already have a mechanism to dynamically (just not hard-coded in one file) angular modules and js files | 21:53 |
david-lyle | just use that to load the panels | 21:53 |
sqchen | I got it, but for launch instance where I should list JS files? | 21:54 |
david-lyle | specify all the ADD_JS_FILES for the panel | 21:54 |
tqtran | david-lyle: ok, that that config object gets loaded into scripts. i still don't see how that is panel-specific? | 21:54 |
david-lyle | that one's at the dashboard level | 21:54 |
tqtran | david-lyle: its globally available in the base page | 21:54 |
sqchen | which panel is for launch instance | 21:54 |
tqtran | oh.... | 21:54 |
david-lyle | sqchen: instances panel | 21:54 |
TravT | instances | 21:54 |
david-lyle | no config file yet | 21:55 |
david-lyle | that's what I'm suggesting | 21:55 |
david-lyle | create one for all panels | 21:55 |
david-lyle | use the mechanism we have | 21:55 |
david-lyle | add a new field for ADD_JASMINE_FILES | 21:55 |
david-lyle | and bob's your uncle | 21:55 |
sqchen | as a base panel> | 21:55 |
david-lyle | sqchen: huh? | 21:56 |
TravT | some wizards can be launched from more than one panel... | 21:56 |
TravT | for example, network panel today let's you launch in instance | 21:56 |
TravT | would they both specify all the scripts? | 21:56 |
sqchen | should the launch instance panel a base panel? | 21:56 |
david-lyle | sqchen: no | 21:56 |
sqchen | ok | 21:57 |
david-lyle | TravT: some things should be common in openstack_dashboard | 21:57 |
david-lyle | which is where we talked about putting those things as well | 21:57 |
sqchen | ADD_JASMINE_FILES for jasmine spec file, right? | 21:57 |
david-lyle | some time in the distant past | 21:57 |
david-lyle | sqchen: yes | 21:57 |
tqtran | david-lyle: so for each panel, we would have a settings.py? | 21:59 |
*** crobertsrh is now known as _crobertsrh | 21:59 | |
sqchen | TravT: only the applied wizard should go to panel. the wizard widget stay the curretly way of loading — in _script.html | 21:59 |
david-lyle | tqtran: basically an enabled file | 21:59 |
sqchen | david-lyle: it there an example there I can follow? | 22:00 |
david-lyle | sqchen: for? | 22:01 |
sqchen | is there an example there I can follow to have a seeting.py for instance panel? | 22:01 |
TravT | ok, i have to go somewhere. brb. but, it also seems to me that for customization it wouldn't have to even be at openstack_dashboard level | 22:01 |
TravT | a panel should just say what module it depends on | 22:02 |
sqchen | Agree with TravT | 22:02 |
*** mattfarina has quit IRC | 22:02 | |
TravT | i don't think every panel should track all its js independently | 22:03 |
david-lyle | TravT: only if it's isolated to that panel | 22:03 |
tqtran | I think the modules can be left out, we can just list it inside the JS | 22:03 |
tqtran | so the ADD_ANGULAR_MODULES field is not neccessary | 22:03 |
sqchen | Yes, I think it is, at the first glance it seems no though | 22:04 |
TravT | be back in 30 mins. :( | 22:04 |
tqtran | sqchen: angular has DI for that, why do we need to inject that using python? | 22:05 |
sqchen | it can make the code break if the modules names defined in panel, but delcaird in horizon.js | 22:05 |
tqtran | for example: for your module requires 'monitoringApp | 22:05 |
david-lyle | because my panel's js should know that it needs to be appended to angular.module.hz.widgets? | 22:05 |
david-lyle | that's not the right path | 22:06 |
*** nikunj2512_ has quit IRC | 22:06 | |
david-lyle | but it requires internals knowledge of horizon | 22:06 |
tqtran | well no, it shouldnt need to append to hz.widgets | 22:06 |
david-lyle | was a for instance | 22:06 |
sqchen | DI is for providers, the module themselves cannot be injected. | 22:06 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Addresses Detail page inconsistencies & code style https://review.openstack.org/151762 | 22:06 |
*** nikunj2512_ has joined #openstack-horizon | 22:07 | |
tqtran | I think a concrete piece of code will really help here. I think we're on the same page but not understanding each other clearly | 22:08 |
robcresswell | TravT: I tidied up that details patch... I think its a good start for a unified template and a more common theme. Data_processing pages are also done, Network Details in the pipeline... | 22:08 |
robcresswell | TravT: Would really appreciate comments if you get some time :) | 22:08 |
tqtran | david-lyle: but yes, the proposed mechanism should work | 22:09 |
*** fischerw has quit IRC | 22:09 | |
tqtran | well its not proposed since its already there....? | 22:09 |
*** bradjones has quit IRC | 22:09 | |
david-lyle | tqtran: I'm proposing to use the existing mechanism | 22:09 |
TravT | i'm back (for 20 mins). | 22:09 |
sqchen | For the statically added framework level components, like wizard widget, the current way of decalred modue dependencies is correct. But for dynamically added modules, there name cannot be statically added. | 22:09 |
*** fischerw has joined #openstack-horizon | 22:10 | |
*** mattfarina has joined #openstack-horizon | 22:10 | |
david-lyle | last part is cross panel js that is not a base widget | 22:10 |
*** mattfarina has quit IRC | 22:10 | |
david-lyle | I think that's just part of openstack_dashboard/static | 22:10 |
david-lyle | the soon to be network wizard e.g. | 22:11 |
TravT | robcresswell: will do. might be this weekend or monday. | 22:11 |
*** zigo has joined #openstack-horizon | 22:11 | |
tqtran | david-lyle: sigh.. so we're gonna have 3 places to add scripts? | 22:11 |
tqtran | david-lyle: i thought 2 was already confusing enough, now we're gonna hve 3...... | 22:11 |
tqtran | actually 4, not counting the settings.py | 22:11 |
robcresswell | TravT: Not expecting reviews over the weekend, haha. Just keep it in mind :) | 22:11 |
david-lyle | how many places do we add python files? | 22:12 |
david-lyle | html files? | 22:12 |
david-lyle | there is a reason they are placed where they are | 22:13 |
david-lyle | logical separation | 22:13 |
*** bradjones has joined #openstack-horizon | 22:13 | |
david-lyle | monolithic lists are bad for everything | 22:13 |
david-lyle | just ask Santa | 22:13 |
TravT | i think we need to sketch out a bigger vision for dynamic content, but in the meantime, why can't it simply by a list of angular modules needed by the panel and then this little snippet in _scripts.html goes into that module and adds the js files? | 22:14 |
david-lyle | TravT: how? | 22:15 |
*** fischerw has quit IRC | 22:15 | |
TravT | 'doh | 22:15 |
*** cbader has quit IRC | 22:15 | |
*** fischerw has joined #openstack-horizon | 22:16 | |
david-lyle | in essence, I'm trying establish that mechanism | 22:16 |
TravT | how what? | 22:17 |
tqtran | david-lyle: is it possible to extend if we have a static folder in each panel? | 22:17 |
tqtran | david-lyle: so instead of a config file, we just pick up the static folder and do template override/extend | 22:18 |
david-lyle | override what? | 22:18 |
tqtran | david-lyle: the _script.html | 22:18 |
tqtran | david-lyle: basically, the ADD_JS_FILES eventually get included in the _script.html | 22:19 |
david-lyle | tqtran: yes | 22:19 |
david-lyle | but overriding _scripts for each page seems like overkill | 22:20 |
david-lyle | I have two goals here | 22:21 |
david-lyle | extensibility | 22:21 |
tqtran | david-lyle: it is, but that is pretty similar to what we're doing with the settings.py | 22:21 |
* TravT studying code | 22:21 | |
tqtran | david-lyle: when we have the ADD_JS_FILES, we are in essence, regenerating the _script.thml | 22:21 |
tqtran | each time for each panel | 22:21 |
david-lyle | no | 22:21 |
david-lyle | not at all | 22:21 |
david-lyle | at startup | 22:22 |
sqchen | WIth angular DI, if we could have all the files that define modules but not only using modules listed before any other JS file, the order doesn’t matter. With this fact, we DO NOT need to have any JS file list. The only thing we need is a pattern to collect JS file automatically. | 22:22 |
david-lyle | we build a list of ADD_JS_FILES | 22:22 |
tqtran | ok so this is done prior to any page loading | 22:22 |
sqchen | yes build it automatically, not manually, | 22:22 |
tqtran | it just appends them all at the global level, then insert all at once | 22:23 |
david-lyle | then when the _scripts.html template gets loaded, it adds all the JS file includes | 22:23 |
sqchen | right | 22:23 |
tqtran | david-lyle: yes, but when it does the insertion, isn't it modifying the _script.html? how is that different than extending and including a new script tag? | 22:24 |
*** tjones1 has left #openstack-horizon | 22:24 | |
tqtran | for example: the _header.html we have in dashboard today extends the one in horizon | 22:24 |
TravT | what all does collectstatic do? | 22:25 |
david-lyle | TravT: mostly collects static files :P | 22:25 |
robcresswell | haha | 22:25 |
tqtran | lol | 22:26 |
* TravT that seems odd | 22:26 | |
TravT | lol | 22:26 |
robcresswell | tqtran: o/ | 22:26 |
*** stevemar has quit IRC | 22:26 | |
david-lyle | it walks all the static dirs and makes those files available, js, images, etc | 22:26 |
david-lyle | in theory it aggregates them | 22:26 |
TravT | that's what I figured (just never actually looked at the code) | 22:27 |
david-lyle | then you come through and compress | 22:27 |
tqtran | right, so if we have these static folders in each panel. it will do the same thing right? | 22:27 |
david-lyle | but compress is it's own step | 22:27 |
david-lyle | tqtran: you have to link them | 22:27 |
*** stevemar has joined #openstack-horizon | 22:27 | |
tqtran | ok, so how hard would it be to link them? | 22:27 |
david-lyle | as easy as a for loop in _scripts.html after you've added those file paths to your enabled files :D | 22:28 |
david-lyle | using ADD_JS_FILES | 22:28 |
tqtran | lol | 22:28 |
david-lyle | the other part which TravT makes a good point of | 22:29 |
david-lyle | is we'll want all of them compressed together | 22:29 |
david-lyle | if you do it in the panel dirs, we won't get that | 22:29 |
david-lyle | you can have a bunch of compressed blobs | 22:29 |
david-lyle | but not one | 22:29 |
*** fischerw has quit IRC | 22:30 | |
david-lyle | that's what you were getting at right TravT? | 22:30 |
*** fischerw has joined #openstack-horizon | 22:30 | |
TravT | I was wondering how this would affect that | 22:30 |
david-lyle | :-) | 22:30 |
tqtran | noob question incoming: if i have panel A and B, and in panel A i need js 1,2,3 and in panel B i need js 3,4,5. when i visit panel A, do i see 1,2,3,4,5? or do i only see 1,2,3? | 22:30 |
TravT | since I manaully run collectstatic and compress about 20 times a day | 22:30 |
david-lyle | right now you see 1-5 | 22:31 |
*** fischerw has quit IRC | 22:31 | |
tqtran | basically, along similar line, is it compress all at once, or per panl? | 22:31 |
* TravT sigh... my time ran out again and I have to run again. be back in 30. | 22:31 | |
*** fischerw has joined #openstack-horizon | 22:31 | |
david-lyle | if they're added via enabled, the same | 22:32 |
david-lyle | if they're added via a per panel compress, you could get 1,2,3 and 3,4,5 separately | 22:32 |
david-lyle | but then 3 should really be a part of common blob A | 22:32 |
david-lyle | and 1,2 should be panel blob and 4,5 should be panel blob | 22:33 |
tqtran | does django save those blob or is it generated each time? | 22:33 |
david-lyle | they're placed in the root static | 22:33 |
david-lyle | that's where you pull 1231ab434325be43.js from | 22:34 |
david-lyle | and 12312bcd7789e.css from | 22:34 |
david-lyle | then those are cached by your local browser and you only load them once | 22:35 |
tqtran | if we decide to do this, i would like to see angular templates get included and compress as well | 22:35 |
tqtran | instead of ajax fetching them when needed | 22:35 |
*** lnxnut has quit IRC | 22:35 | |
david-lyle | tqtran: js or html? | 22:35 |
tqtran | html | 22:35 |
david-lyle | not sure how you do that | 22:36 |
tqtran | via a scrip tag, let me find an example.... | 22:36 |
david-lyle | I don't think collectstatic or compressor is built for HTML | 22:37 |
sqchen | I know what is this. but that will load all templates no matter we need them or not. | 22:37 |
*** oro has quit IRC | 22:38 | |
sqchen | I prefer lazy loading | 22:38 |
tqtran | sqchen: yes, but it'll be faster once page loads is completely. and it would also solve the jasmine issue. Im not too crazy about how we're doing it in jasmine today | 22:38 |
*** lblanchard has quit IRC | 22:39 | |
sqchen | I am wordering the memory use, not the loading time... | 22:39 |
tqtran | the base angular widget templates. doesn't ahve to be panel specific | 22:40 |
tqtran | since we're doing it for the js, might as well include the template | 22:40 |
sqchen | Get the page initialzed faster seems a better UX. | 22:40 |
sqchen | I don’t think we should load all JS files as well | 22:41 |
sqchen | I prefer increamental loading. Some UI will never open for some user. | 22:42 |
david-lyle | sqchen: I tend to agree | 22:42 |
david-lyle | that's not how things are structured now | 22:42 |
david-lyle | but we can junk up the compressed objects | 22:42 |
sqchen | This is especially important for mobile devices. | 22:42 |
david-lyle | I just don't want duplication | 22:43 |
fischerw | david-lyle: For https://review.openstack.org/#/c/145870/11/doc/source/topics/tutorial.rst, for the "circular" comments, did you mean that the comments after the links were unneeded, since following the link gave the details. | 22:43 |
*** neelashah has quit IRC | 22:43 | |
david-lyle | fischerw: I meant for FilterAction you indicate that it's an action that filters. It would be nice to either reword the description to not echo the class name, or not have it | 22:44 |
david-lyle | preferably the former | 22:44 |
david-lyle | it's like saying hairdo is a do for hair | 22:45 |
sqchen | I agree to load all basic templates together as tqtran said though. | 22:45 |
david-lyle | it doesn't really help if I don't already know what a hairdo is | 22:45 |
david-lyle | sqchen: html tempates? | 22:45 |
sqchen | right | 22:46 |
tqtran | sqchen: i think that was a question lol | 22:46 |
sqchen | but only for generic templates | 22:46 |
sqchen | cool. we agrred :) | 22:46 |
david-lyle | what I'd really like is to get a working solution and then optimize | 22:47 |
david-lyle | but it will influence the design a bit | 22:47 |
tqtran | or optimize before we write code, and then never go anywhere | 22:47 |
sqchen | I think we can optimize later, it is not an issue right now. | 22:48 |
david-lyle | here's what I don't want, change panel js, add an angular file, have to edit horizon/templates/_scripts.html in the same patch | 22:48 |
david-lyle | that's too much coupling | 22:49 |
sqchen | or someon can do it transparently. | 22:49 |
david-lyle | that doesn't need to work like that | 22:49 |
*** fischerw has quit IRC | 22:49 | |
sqchen | david-lyle: I agreed on that. This is why I had the fix this morning. | 22:49 |
david-lyle | sqchen: I understand | 22:50 |
tqtran | david-lyle: i agree that its more extensible with the config approach. but the coupling doesnt neccessary go away either. you're just rewriting that stuff into settings.py instead of _scripts | 22:52 |
sqchen | Ok, I think the only thing I need is to figure out where to add those JS file names. if the config/setting file does not exist, how to create one. | 22:52 |
david-lyle | not in settings | 22:52 |
david-lyle | it's a per panel config | 22:53 |
sqchen | I think the benefit is that we don’t need to re-write the same list for Jasmin. | 22:53 |
david-lyle | if we don't want to make each panel pluggable (which I actually do), we just need to add it in the panel.py file | 22:54 |
david-lyle | and alter horizon/base.py | 22:54 |
tqtran | no, i like the panel pluggable thing | 22:54 |
sqchen | Another benefit is, Horizon is nore customizable. | 22:54 |
tqtran | im just playing devil's advocate | 22:55 |
sqchen | more customizable | 22:55 |
david-lyle | I think for the builtin panels, for now we just put the enabled file in openstack_dashboard/enabled | 22:55 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Fixes inline edit icon size/placement https://review.openstack.org/145197 | 22:56 |
sqchen | tqthai: sorry, I just type slow. I am answer david-lyle | 22:56 |
robcresswell | david-lyle: ^^ That patch is for the pencil icon overlay and skewed buttons in inline_edit you bug reported in December, I think | 22:58 |
tqtran | Piet: are you still around? got a few UX questions for you | 22:58 |
Piet | Dang, I was just headed out the door to get a growler of beer | 22:59 |
tqtran | Piet: you can get your beer, i will wait | 22:59 |
Piet | We can chat | 22:59 |
tqtran | Piet: can we google hangout? | 23:00 |
Piet | What's up? | 23:00 |
Piet | sure | 23:00 |
tqtran | secret meeting | 23:00 |
tqtran | invite only | 23:00 |
Piet | Don't invite David Lyle! | 23:00 |
tqtran | whats your gmail? | 23:00 |
Piet | pkruithofjr | 23:01 |
*** robcresswell is now known as robcresswell_afk | 23:02 | |
tqtran | inviting | 23:02 |
Piet | https://plus.google.com/hangouts/_/event/c8j8km27k3retmn7jgplp94g61c | 23:02 |
Piet | just click on that link | 23:02 |
tqtran | ok im on | 23:03 |
tqtran | but i see no one | 23:03 |
david-lyle | most private when just you | 23:08 |
*** fischerw has joined #openstack-horizon | 23:11 | |
tqtran | lol yes indeed | 23:11 |
*** fischerw has quit IRC | 23:17 | |
*** nlahouti has quit IRC | 23:28 | |
*** ZZelle has quit IRC | 23:34 | |
openstackgerrit | Randy Bertram proposed openstack/horizon: WIP Magic Search in Angular User https://review.openstack.org/151386 | 23:38 |
*** Drago has quit IRC | 23:44 | |
*** nlahouti has joined #openstack-horizon | 23:53 | |
*** nlahouti has quit IRC | 23:54 | |
*** stevemar has quit IRC | 23:56 | |
tqtran | anyknow how to to enable SSL? the USE_SSL is not in our local_settings.py.example anymore, is it under a different field now? | 23:56 |
*** nlahouti has joined #openstack-horizon | 23:56 | |
*** sqchen has quit IRC | 23:57 | |
*** sqchen has joined #openstack-horizon | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!