apodacae | david-lyle: Ok I think I figured it out there is some custom sizing code here that was assuming bootstrap 2 | 00:00 |
---|---|---|
*** ArcTanSusan has quit IRC | 00:07 | |
*** ArcTanSusan has joined #openstack-horizon | 00:08 | |
*** nlahouti has joined #openstack-horizon | 00:08 | |
*** ArcTanSusan has quit IRC | 00:10 | |
miguelgrinberg | I would greatly appreciate it if somebody can spend a couple of minutes reviewing these two bug fixes: https://review.openstack.org/#/c/114711/ and https://review.openstack.org/#/c/116128/ | 00:16 |
*** amcrn has quit IRC | 00:19 | |
*** amerine has quit IRC | 00:23 | |
*** amerine has joined #openstack-horizon | 00:31 | |
*** qba73 has quit IRC | 00:31 | |
*** tnovacik has quit IRC | 00:41 | |
*** clu_ has quit IRC | 00:45 | |
*** sbfox has joined #openstack-horizon | 00:56 | |
*** tqtran has quit IRC | 01:05 | |
*** nlahouti has quit IRC | 01:08 | |
*** wuhg has joined #openstack-horizon | 01:10 | |
*** sbfox has quit IRC | 01:13 | |
*** amerine has quit IRC | 01:15 | |
*** lblanchard has quit IRC | 01:15 | |
*** wchrisj has quit IRC | 01:19 | |
*** sbfox has joined #openstack-horizon | 01:21 | |
*** peristeri has quit IRC | 01:21 | |
*** sbfox has quit IRC | 01:22 | |
*** ArcTanSusan has joined #openstack-horizon | 01:38 | |
*** ArcTanSusan has quit IRC | 01:40 | |
*** sbfox has joined #openstack-horizon | 01:52 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 01:56 | |
*** dsneddon has quit IRC | 02:06 | |
*** johnma has quit IRC | 02:13 | |
*** ramishra has joined #openstack-horizon | 02:26 | |
*** sbfox has quit IRC | 02:27 | |
*** ramishra has quit IRC | 02:43 | |
*** ramishra has joined #openstack-horizon | 02:44 | |
*** nlahouti has joined #openstack-horizon | 02:45 | |
*** cherry has joined #openstack-horizon | 02:47 | |
*** cherry has quit IRC | 02:48 | |
*** neelashah has joined #openstack-horizon | 02:56 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 03:18 | |
r1chardj0n3s | it looks like the use of @memoized in openstack_dashboard/api/nova.py is broken in all cases - one of the args is always a request object which means the memoizing will never result in a cache hit | 03:26 |
r1chardj0n3s | certainly in my limited testing the functions are called repeatedly when cached results should be used | 03:27 |
*** Longgeek has joined #openstack-horizon | 03:31 | |
*** prasoon has joined #openstack-horizon | 03:33 | |
*** prasoon has quit IRC | 03:38 | |
*** prasoon_ has joined #openstack-horizon | 03:38 | |
*** sbfox has joined #openstack-horizon | 03:56 | |
*** mitz_ has quit IRC | 03:59 | |
*** mitz has joined #openstack-horizon | 03:59 | |
*** sbfox has quit IRC | 04:09 | |
*** ramishra has quit IRC | 04:19 | |
*** amerine has joined #openstack-horizon | 04:20 | |
*** sbfox has joined #openstack-horizon | 04:21 | |
*** ramishra has joined #openstack-horizon | 04:34 | |
*** amotoki has joined #openstack-horizon | 04:36 | |
*** echevemaster has joined #openstack-horizon | 04:37 | |
*** ArcTanSusan has joined #openstack-horizon | 04:40 | |
*** ramishra has quit IRC | 04:42 | |
*** ramishra has joined #openstack-horizon | 04:45 | |
*** Longgeek_ has joined #openstack-horizon | 04:52 | |
*** ramishra has quit IRC | 04:55 | |
*** Longgeek has quit IRC | 04:56 | |
*** ramishra has joined #openstack-horizon | 05:06 | |
*** neelashah has quit IRC | 05:08 | |
*** vivekd_ has joined #openstack-horizon | 05:16 | |
*** vivekd has quit IRC | 05:18 | |
*** vivekd_ is now known as vivekd | 05:18 | |
*** sbfox has quit IRC | 05:38 | |
*** nlahouti has left #openstack-horizon | 05:46 | |
*** nlahouti has joined #openstack-horizon | 05:46 | |
*** jtomasek has joined #openstack-horizon | 05:47 | |
*** nlahouti has left #openstack-horizon | 05:48 | |
*** nlahouti has joined #openstack-horizon | 05:48 | |
*** nlahouti has joined #openstack-horizon | 05:49 | |
*** dkorn has joined #openstack-horizon | 05:54 | |
*** k4n0 has joined #openstack-horizon | 06:03 | |
*** ArcTanSusan has quit IRC | 06:03 | |
*** jtomasek has quit IRC | 06:06 | |
*** mrunge has joined #openstack-horizon | 06:08 | |
*** vokhrimenko has joined #openstack-horizon | 06:13 | |
*** tnovacik has joined #openstack-horizon | 06:14 | |
*** ramishra has quit IRC | 06:17 | |
*** qba73 has joined #openstack-horizon | 06:20 | |
*** pkoniszewski has joined #openstack-horizon | 06:23 | |
*** vivekd has quit IRC | 06:26 | |
*** e0ne has joined #openstack-horizon | 06:37 | |
*** nlahouti has quit IRC | 06:40 | |
*** e0ne has quit IRC | 06:43 | |
*** qba73 has quit IRC | 06:50 | |
*** vkmc has quit IRC | 06:52 | |
*** jtomasek has joined #openstack-horizon | 06:54 | |
*** jprovazn has joined #openstack-horizon | 06:54 | |
*** denis_makogon has joined #openstack-horizon | 06:54 | |
*** rdopieralski has joined #openstack-horizon | 06:54 | |
*** e0ne has joined #openstack-horizon | 06:57 | |
*** e0ne has quit IRC | 06:58 | |
*** romainh has joined #openstack-horizon | 07:06 | |
*** AA_ has joined #openstack-horizon | 07:13 | |
*** harlowja_ is now known as harlowja_away | 07:14 | |
*** ramishra has joined #openstack-horizon | 07:18 | |
*** ramishra has quit IRC | 07:22 | |
*** ramishra has joined #openstack-horizon | 07:22 | |
*** ramishra has quit IRC | 07:24 | |
*** ramishra has joined #openstack-horizon | 07:24 | |
*** bvandenh has joined #openstack-horizon | 07:26 | |
*** ramishra has quit IRC | 07:34 | |
*** pkoniszewski has quit IRC | 07:34 | |
*** ramishra has joined #openstack-horizon | 07:35 | |
*** pkoniszewski has joined #openstack-horizon | 07:35 | |
*** arezmerita has joined #openstack-horizon | 07:38 | |
AA_ | Hi, I'm new in OpenStack development, I developed a Heat topology display improvement. My implementation has already 2 positive reviews but I need more reviews to merge my code : https://review.openstack.org/#/c/110888/. Here is my blueprint https://blueprints.launchpad.net/horizon/+spec/heat-topology-display-improvement. Thanks | 07:40 |
*** tnovacik has quit IRC | 07:45 | |
*** echevemaster has quit IRC | 07:46 | |
*** jcoufal has joined #openstack-horizon | 07:49 | |
*** ygbo has joined #openstack-horizon | 07:50 | |
*** pkoniszewski has quit IRC | 07:50 | |
*** pkoniszewski has joined #openstack-horizon | 07:51 | |
*** jpich has joined #openstack-horizon | 07:53 | |
rdopieralski | AA_: hi, please be patient, I know it's frustrating waiting for reviews, but we have very limited resources for that | 07:56 |
*** cedrics has joined #openstack-horizon | 07:58 | |
*** AA_ has quit IRC | 07:59 | |
*** AA_ has joined #openstack-horizon | 08:08 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 08:08 | |
*** akrivoka has joined #openstack-horizon | 08:18 | |
*** e0ne has joined #openstack-horizon | 08:19 | |
*** ramishra has quit IRC | 08:42 | |
*** ramishra has joined #openstack-horizon | 08:54 | |
*** regebro has joined #openstack-horizon | 09:03 | |
*** ramishra has quit IRC | 09:08 | |
*** athomas has joined #openstack-horizon | 09:11 | |
*** qba73 has joined #openstack-horizon | 09:14 | |
*** alexpilotti has joined #openstack-horizon | 09:18 | |
*** masco has joined #openstack-horizon | 09:18 | |
*** masco has left #openstack-horizon | 09:19 | |
*** DaveJ__ has joined #openstack-horizon | 09:20 | |
*** tosky has joined #openstack-horizon | 10:01 | |
*** e0ne has quit IRC | 10:05 | |
*** jcoufal has quit IRC | 10:09 | |
*** jab has joined #openstack-horizon | 10:10 | |
*** jab has quit IRC | 10:10 | |
*** jab has joined #openstack-horizon | 10:10 | |
*** jcoufal has joined #openstack-horizon | 10:12 | |
*** denis_makogon has quit IRC | 10:13 | |
*** e0ne has joined #openstack-horizon | 10:13 | |
*** jab is now known as bradjones | 10:20 | |
*** romainh has quit IRC | 10:22 | |
*** HenryG has quit IRC | 10:43 | |
*** cedrics has quit IRC | 10:49 | |
*** aix has joined #openstack-horizon | 10:52 | |
*** bradjones has quit IRC | 11:08 | |
*** dkorn has quit IRC | 11:21 | |
*** prasoon_ has quit IRC | 11:24 | |
*** stpierre has joined #openstack-horizon | 11:34 | |
*** cedrics has joined #openstack-horizon | 11:36 | |
*** AA_ has quit IRC | 11:37 | |
*** vkmc has joined #openstack-horizon | 11:46 | |
*** vkmc has quit IRC | 11:46 | |
*** vkmc has joined #openstack-horizon | 11:46 | |
*** HenryG has joined #openstack-horizon | 11:52 | |
*** prasoon has joined #openstack-horizon | 11:58 | |
*** romainh has joined #openstack-horizon | 11:58 | |
*** tosky has quit IRC | 12:01 | |
*** e0ne has quit IRC | 12:04 | |
*** asahlin has quit IRC | 12:05 | |
*** jab has joined #openstack-horizon | 12:05 | |
*** jab has quit IRC | 12:05 | |
*** jab has joined #openstack-horizon | 12:05 | |
*** jab is now known as bradjones | 12:07 | |
*** lblanchard has joined #openstack-horizon | 12:11 | |
*** masco has joined #openstack-horizon | 12:13 | |
*** dkorn has joined #openstack-horizon | 12:15 | |
*** e0ne has joined #openstack-horizon | 12:18 | |
*** erecio has joined #openstack-horizon | 12:18 | |
*** mflobo has joined #openstack-horizon | 12:25 | |
*** masco has quit IRC | 12:26 | |
mflobo | On keystone project are working on Hierarchical Multitenancy (nested projects) https://blueprints.launchpad.net/keystone/+spec/hierarchical-multitenancy | 12:26 |
mflobo | Is there some plan to offer this functionallity on Horizon? | 12:26 |
jpich | mflobo: I'm not aware of any work or blueprint in that area currently. In general it's better to wait for the work to be finished in the other projects before starting the work in Horizon, so it might be coming later | 12:30 |
*** julim has joined #openstack-horizon | 12:33 | |
*** julim has quit IRC | 12:35 | |
mflobo | jpich, ok, thanks for the answer | 12:35 |
jpich | mflobo: You're welcome. If you want to help with implementing it on the horizon side you're very welcome :-) | 12:36 |
mflobo | jpich, I'm thinking on that | 12:38 |
jpich | mflobo: Great to hear! | 12:38 |
mflobo | jpich, We'll in touch | 12:38 |
jpich | You're welcome to ask for advice in here if you get lost or have any question :) | 12:38 |
jpich | Cool! | 12:38 |
mflobo | perfect | 12:38 |
*** julim has joined #openstack-horizon | 12:39 | |
jomara_ | rdopieralski: hi | 12:49 |
jomara_ | rdopieralski: i have a question about manually creating django forms, instead of just doing {{ form }} like their examples show, or using the horizon _modal_form | 12:50 |
rdopieralski | jomara_: hello, brave adventurer, what is your quest? | 12:50 |
jomara_ | rdopieralski: i have an HTML form element with the correct location i think, but i cant figure out how to render the fields | 12:50 |
jomara_ | rdopieralski: i see this a lot ... | 12:50 |
jomara_ | {{ add_bootstrap_class }} | 12:50 |
jomara_ | {{ field|add_bootstrap_class]} | 12:50 |
rdopieralski | look into form_fields.html | 12:51 |
rdopieralski | you basically just iterate over the form to get the fields | 12:51 |
jomara_ | it just says field|bootstrapform field | 12:51 |
rdopieralski | yeah, {{ field }} will call the field's widget to get the html | 12:51 |
jomara_ | rdopieralski: hm | 12:51 |
jomara_ | rdopieralski: i have an array of django field objects | 12:52 |
rdopieralski | no, wait | 12:52 |
rdopieralski | wrong version | 12:52 |
jomara_ | rdopieralski: if i loop over the array and call {{ field}}, i get the wrong results | 12:52 |
jomara_ | (i've tried that) | 12:52 |
rdopieralski | jomara_: look at this one https://review.openstack.org/#/c/67140/ | 12:52 |
rdopieralski | so what |add_bootstrap_class does, is sumply adding a form-control class to the widget | 12:53 |
rdopieralski | so that it's rendered correctly by bootstrap | 12:53 |
jomara_ | i would normally be fine with that | 12:53 |
rdopieralski | but otherwise, {{ field }} just genreates the html for tha given field | 12:53 |
jomara_ | however i get an error about a CharField object (or whatever is in the array) not having a field property | 12:54 |
rdopieralski | you also get {{ field.label }} and such for the other parts | 12:54 |
rdopieralski | did you forget to initialize your form? | 12:54 |
jomara_ | i dont think so? | 12:55 |
rdopieralski | show me the code | 12:55 |
jomara_ | debugging shows that the objects are definitely 'field' objects | 12:55 |
jomara_ | sec | 12:55 |
rdopieralski | there is 'field' and there is 'bound field' | 12:55 |
jomara_ | uh oh | 12:55 |
jomara_ | rdopieralski: fwiw, the "basic" tab display correctly, but that is trivial | 12:56 |
jomara_ | http://pastebin.com/ySsDWhB9 | 12:56 |
jomara_ | so, 'form.basic_parameters' works to get back an array of dicts | 12:57 |
rdopieralski | jomara_: ok, I see what you did there | 12:57 |
rdopieralski | jomara_: that won't wortk | 12:57 |
jomara_ | haha, ok | 12:57 |
rdopieralski | jomara_: the fields have to be on the Form class to work | 12:57 |
jomara_ | oh, you cant just have an array of fields? | 12:57 |
rdopieralski | jomara_: the Form class has a metaclass that collects them and does some magic | 12:57 |
jomara_ | ahhhh | 12:57 |
rdopieralski | in particular, binds them to values | 12:57 |
rdopieralski | what you can have | 12:57 |
rdopieralski | let me find it | 12:58 |
rdopieralski | we did it in previous cycle in tuskar | 12:58 |
rdopieralski | in tuskar-ui | 12:58 |
*** jasondotstar has joined #openstack-horizon | 13:00 | |
rdopieralski | hmm, I can't find it | 13:02 |
jomara_ | rdopieralski: is the 'correct solution' just to bind them to the form class? | 13:02 |
rdopieralski | jomara_: pretty much, but I had some code that does it | 13:03 |
rdopieralski | jomara_: well, you need to add them to self.fields of the form too | 13:03 |
*** jpomero has quit IRC | 13:04 | |
rdopieralski | jomara_: so that they get processed when the form is submitted | 13:04 |
jomara_ | *too*? both of them? | 13:04 |
rdopieralski | jomara_: so basically in your form's __init__ you would add them to self.fields and to some lists, and later, when rendering them, you would call some function that takes those lists and binds the fields and returns to you | 13:05 |
*** neelashah has joined #openstack-horizon | 13:07 | |
*** asahlin has joined #openstack-horizon | 13:08 | |
rdopieralski | jomara_: I can't find it | 13:09 |
*** k4n0 has quit IRC | 13:10 | |
*** qba73 has quit IRC | 13:10 | |
jomara_ | rdopieralski: =( | 13:10 |
jomara_ | rdopieralski: im incapable of making *new* code, help! | 13:10 |
rdopieralski | jomara_: so the __init__ part is pretty much like here: https://github.com/openstack/tuskar-ui/blob/master/tuskar_ui/infrastructure/overview/forms.py#L38-L54 | 13:11 |
rdopieralski | the field binding part I couldn't find | 13:13 |
*** dkorn has quit IRC | 13:13 | |
*** qba73 has joined #openstack-horizon | 13:13 | |
jomara_ | rdopieralski: is it absolutely required? how does this form get awaywiht it | 13:14 |
jomara_ | since there is no binding | 13:14 |
rdopieralski | normally, the form that you get in a template is a BoundForm | 13:15 |
rdopieralski | that has all of its fileds bound when you iterate over them | 13:15 |
rdopieralski | sorry, not BoundForm | 13:16 |
rdopieralski | normal Form, but anyways it binds the field to data when you access it | 13:16 |
rdopieralski | https://github.com/django/django/blob/master/django/forms/forms.py#L153-L160 | 13:16 |
rdopieralski | so it seems that all you need is to have a list of field names | 13:17 |
*** qba73 has quit IRC | 13:17 | |
rdopieralski | and do: def my_field_group(self): for field_name in self.my_field_group_names: yield self[field_name] | 13:18 |
rdopieralski | you would initialize self.my_field_group_names in __init__ of course, while adding the fields to the form | 13:19 |
rdopieralski | does that make sense? | 13:19 |
*** peristeri has joined #openstack-horizon | 13:19 | |
*** tosky has joined #openstack-horizon | 13:20 | |
*** qba73 has joined #openstack-horizon | 13:21 | |
jomara_ | rdopieralski: sorry on a call, slow .... | 13:21 |
rdopieralski | jomara_: http://paste.openstack.org/show/101719/ | 13:22 |
*** ramishra has joined #openstack-horizon | 13:22 | |
*** qba73 has quit IRC | 13:24 | |
*** radez_g0` is now known as radez | 13:24 | |
*** peristeri has quit IRC | 13:25 | |
*** qba73 has joined #openstack-horizon | 13:25 | |
*** qba73 has quit IRC | 13:28 | |
*** peristeri has joined #openstack-horizon | 13:31 | |
*** qba73 has joined #openstack-horizon | 13:32 | |
*** qba73 has quit IRC | 13:35 | |
*** cedricss has joined #openstack-horizon | 13:36 | |
*** qba73 has joined #openstack-horizon | 13:37 | |
*** cedrics has quit IRC | 13:39 | |
*** ramishra has quit IRC | 13:40 | |
*** tosky_ has joined #openstack-horizon | 13:46 | |
asahlin | I have a newbie question about translation. Where are the key/value pairs of strings (MRI files) that are defined for translation? I found a hard coded "string" in a html template, but dont know where to find the key for that string or if it already exists. | 13:48 |
*** doug-fish has joined #openstack-horizon | 13:48 | |
*** tosky has quit IRC | 13:50 | |
rdopieralski | asahlin: we use gettext for translations | 13:50 |
rdopieralski | asahlin: so just call gettext with the english version of the string, and it will give you the translated version | 13:50 |
*** amotoki has quit IRC | 13:51 | |
*** samrose has joined #openstack-horizon | 13:51 | |
*** amotoki has joined #openstack-horizon | 13:51 | |
asahlin | ok, thanks. No wonder I couldn't find "resource bundle" anywhere ;-) | 13:52 |
rdopieralski | asahlin: the translations are here https://github.com/openstack/horizon/tree/master/openstack_dashboard/locale | 13:53 |
asahlin | so if the string that needs to be translated is not in the django.po file, do I need to add it? or is that automatically done? | 13:57 |
*** dulek has joined #openstack-horizon | 13:57 | |
*** tnovacik has joined #openstack-horizon | 14:00 | |
jpich | asahlin: You can check locally if it's generated by running ./run_tests.sh --makemessages. The strings are automatically transferred to Transifex, I'm not sure if the local /en/ resources are updated in our repo directly too. You shouldn't update the po files directly, if the gettext markers are correct the string will show up in the po files | 14:00 |
*** sambetts has joined #openstack-horizon | 14:10 | |
*** tosky_ has quit IRC | 14:11 | |
*** ramishra has joined #openstack-horizon | 14:11 | |
*** tosky_ has joined #openstack-horizon | 14:11 | |
asahlin | jpich: I ran the command (successfully), where do I check to see if the translation got generated (the local en/resources did not contain the string still)? I brought up the panel and see the string, so is that all the verification I need? | 14:13 |
jpich | asahlin: There's several 'en' po files, for horizon and openstack_dashboard, fwiw. If you still don't see the string in there, you found a i18n bug yep! | 14:15 |
*** ramishra has quit IRC | 14:16 | |
asahlin | jpich: rdopieralski: Thanks for the help | 14:18 |
*** amerine has quit IRC | 14:19 | |
jpich | You're welcome | 14:19 |
*** david-lyle has joined #openstack-horizon | 14:19 | |
*** woodm1979 has joined #openstack-horizon | 14:24 | |
*** Longgeek_ has quit IRC | 14:24 | |
*** ericpeterson has joined #openstack-horizon | 14:25 | |
asahlin | I have a draft of the Horizon JavaScript best practices available for review. I did the draft on the wiki at https://wiki.openstack.org/wiki/Horizon/Javascript | 14:29 |
*** david-lyle has quit IRC | 14:30 | |
asahlin | What is the preferred way to do a review like this? Looking at the wki is good, but not convenient for giving feedback. | 14:30 |
*** david-lyle has joined #openstack-horizon | 14:30 | |
rdopieralski | asahlin: shuldn't it go into the docs? | 14:30 |
rdopieralski | asahlin: http://docs.openstack.org/developer/horizon/contributing.html#javascript | 14:31 |
jpich | asahlin: Thanks! I'd start a conversation about it on the list to get more visibility | 14:31 |
asahlin | yeah I think it needs to go to the docs and wiki, just didn't know where most convenient to review would be. Wiki was easy for me to create the best practices ;-) | 14:32 |
jpich | It'd be good to get some input from the storyboard folks too, see what they're up to and make sure we keep best practices consistent across openstack projects, as much as possible | 14:32 |
rdopieralski | asahlin: a patch to the docs would go through gerrit, so everyone can review and comment on individual lines | 14:33 |
*** amerine has joined #openstack-horizon | 14:33 | |
asahlin | rdopieralski: yeah that makes sense.. I can update the existing section and do the review through gerrit. | 14:34 |
asahlin | jpich: not sure what you mean by " I'd start a conversation about it on the list to get more visibility" | 14:35 |
rdopieralski | asahlin: I think that it's not necessary to talk about issues that jslint catches on the gate anyways? | 14:35 |
jpich | asahlin: If you send an email to the development list ( https://wiki.openstack.org/wiki/MailingLists#Future_Development ), more people who may not be on IRC or paying attention to it right now will hear about it too | 14:36 |
jpich | and may be able to offer feedback | 14:36 |
*** vijendar has joined #openstack-horizon | 14:36 | |
*** tnovacik has quit IRC | 14:36 | |
jpich | rdopieralski: I think it's good to document them anyway. It's kind of what we do with HACKING, isn't it? Writing up rules and then making up automated checks for them | 14:36 |
asahlin | jpich: thanks will send out and email | 14:37 |
*** ericpeterson has quit IRC | 14:37 | |
rdopieralski | jpich: maybe we should just list jslint warnings then? | 14:37 |
jpich | ? | 14:38 |
*** ericpeterson has joined #openstack-horizon | 14:38 | |
rdopieralski | like E666: Line ending with a pentagram. | 14:38 |
rdopieralski | just enumerate the jslint rules that we have enabled | 14:38 |
rdopieralski | no sense duplicating the descriptions in our own words | 14:39 |
jpich | Ah! Yes that would be good too | 14:39 |
rdopieralski | the current docs kinda do that, except they only list the differences from defaults | 14:40 |
asahlin | rdopieralski: thanks for the feedback, while JSHint warns on the errors for the configs we set, it doesn't catch all. I was going with more of an overall best practices for educational purposes. | 14:43 |
*** jprovazn has quit IRC | 14:43 | |
rdopieralski | asahlin: we can configure it to catch more | 14:43 |
asahlin | rdopieralski: but we definitely could / should go with that approach describing what JSHint setting we have set. | 14:43 |
rdopieralski | asahlin: I think guidelines and style guides are useless if they are not enforced | 14:44 |
asahlin | rdopieralski: JSHint is a great tool, but it won't catch everything.. and occasionally can be too strict and catches valid coding practices.. | 14:45 |
asahlin | rdopieralski: This is good feedback, is what I was looking for. I will send out an email to the developer list and see what others are thinking | 14:46 |
*** qba73 has quit IRC | 14:46 | |
*** bradjones has quit IRC | 14:46 | |
rdopieralski | pbelanyi_: by the way, there is also jscs, maybe it would be better for our needs? | 14:50 |
rdopieralski | pbelanyi_: it has the advantage of being extensible, so we can add our own rules like in Hacking | 14:51 |
*** bradjones has joined #openstack-horizon | 14:52 | |
rdopieralski | https://github.com/jscs-dev/node-jscs | 14:52 |
*** bradjones has quit IRC | 14:52 | |
*** bradjones has joined #openstack-horizon | 14:52 | |
rdopieralski | and the license is reasonable | 14:53 |
rdopieralski | MIT | 14:53 |
*** jcoufal has quit IRC | 14:53 | |
*** ericpete_ has joined #openstack-horizon | 14:59 | |
*** ericpeterson has quit IRC | 14:59 | |
*** rdopieralski has quit IRC | 15:00 | |
*** woodm1979 has quit IRC | 15:02 | |
*** romainh has quit IRC | 15:04 | |
*** jcoufal-mobile has joined #openstack-horizon | 15:06 | |
*** jcoufal-mobile has quit IRC | 15:06 | |
*** mrunge has quit IRC | 15:08 | |
*** ramishra has joined #openstack-horizon | 15:12 | |
*** asahlin has quit IRC | 15:13 | |
*** asahlin has joined #openstack-horizon | 15:13 | |
*** ramishra has quit IRC | 15:16 | |
*** oro has joined #openstack-horizon | 15:20 | |
*** oro_ has joined #openstack-horizon | 15:20 | |
*** nlahouti has joined #openstack-horizon | 15:21 | |
*** romainh has joined #openstack-horizon | 15:22 | |
*** romainh has left #openstack-horizon | 15:22 | |
*** AlkaD has joined #openstack-horizon | 15:27 | |
*** HenryG has quit IRC | 15:28 | |
*** sbfox has joined #openstack-horizon | 15:31 | |
*** sbfox has quit IRC | 15:31 | |
*** samrose has quit IRC | 15:39 | |
*** david-ly_ has joined #openstack-horizon | 15:48 | |
*** david-lyle has quit IRC | 15:51 | |
*** ygbo has quit IRC | 15:55 | |
*** woodm1979 has joined #openstack-horizon | 15:59 | |
*** woodm1979 has quit IRC | 16:00 | |
*** woodm1979 has joined #openstack-horizon | 16:00 | |
*** cedricss has quit IRC | 16:01 | |
*** rebelagentm has joined #openstack-horizon | 16:01 | |
*** neelashah has quit IRC | 16:02 | |
*** cody-somerville has joined #openstack-horizon | 16:03 | |
*** cody-somerville has quit IRC | 16:03 | |
*** cody-somerville has joined #openstack-horizon | 16:03 | |
*** AlkaD has quit IRC | 16:03 | |
*** erecio has quit IRC | 16:06 | |
*** linkid has joined #openstack-horizon | 16:06 | |
*** woodm1979 has quit IRC | 16:06 | |
*** woodm1979 has joined #openstack-horizon | 16:08 | |
*** woodm1979 has quit IRC | 16:08 | |
*** AlkaD has joined #openstack-horizon | 16:09 | |
*** woodm1979 has joined #openstack-horizon | 16:10 | |
*** e0ne has quit IRC | 16:12 | |
jpich | amotoki: Do you know if Abishek will be around to update the IPv6 patches? It's not clear to me anymore if your patch is meant to demonstrate an alternative approach or supersede the other patch now | 16:12 |
*** erecio has joined #openstack-horizon | 16:13 | |
amotoki | I am now trying to reach abishek. I think we need to honor usability in the dashbaord. It is the most different point compared to CLI. | 16:14 |
jpich | I agree with your comments on usability | 16:15 |
*** vokhrimenko has quit IRC | 16:17 | |
jpich | amotoki: Do you mind if I upload a new patch myself to fix the typos in https://review.openstack.org/#/c/116277/ ? | 16:17 |
amotoki | I just got an feedback on the menu options from IPv6 sub team lead. The choices reduced and it is a good news :-) | 16:17 |
jpich | I saw that in the neutron channel, that is awesome news instead :) | 16:18 |
jpich | I think it's ok to add more options later if users complain, but this looks like a much more understandable starting point | 16:18 |
*** dsneddon has joined #openstack-horizon | 16:18 | |
*** neelashah has joined #openstack-horizon | 16:18 | |
amotoki | jpich: thanks. could you upload the new version? | 16:19 |
jpich | amotoki: Cool, will do | 16:19 |
*** dguerri_ is now known as dguerri | 16:20 | |
*** woodm1979 has quit IRC | 16:22 | |
*** absubram has joined #openstack-horizon | 16:29 | |
absubram | jpich: thanks for the comments and reviews for the IPv6 BP! | 16:29 |
david-ly_ | amotoki: question on https://review.openstack.org/#/c/113336/7 | 16:30 |
*** david-ly_ is now known as david-lyle | 16:30 | |
jpich | absubram: Sweet! We were talking about your review, will you be able to take the feedback into account? | 16:30 |
david-lyle | do you want me to add the removal for the admin router panel? | 16:30 |
david-lyle | I word-smithed the doc addition a little | 16:31 |
absubram | oh definitely! we're actually also talking about internally here | 16:31 |
jpich | absubram: amotoki got a subset of sane default values from someone on the neutron team as well (in a review on his patch) which should really help with usability | 16:31 |
absubram | Looks like amotoki's implementation is the way to go | 16:31 |
amotoki | david-lyle: thanks for letting me know. Admin router panel also needs to be hidden. | 16:31 |
absubram | jpich: yes I just saw Sean's comments | 16:31 |
jpich | absubram: If it turns out users do want more flexibility we can expand the available options later on - hopefully in a way that doesn't lose the non-experts | 16:32 |
david-lyle | amotoki: you want me to tackle that? | 16:32 |
absubram | jpich: looks like he wants to reduce the available options for IPv6 via Horizon to keep things simple | 16:32 |
amotoki | absubram: i requested Sean to advise us. | 16:32 |
amotoki | david-lyle: will do soon. | 16:32 |
jpich | amotoki: (I updated https://review.openstack.org/#/c/116277/ - you might want to have a quick look to make sure my docs update is still accurate but I think it's ok) | 16:32 |
jpich | absubram: Awesome re: "oh definitely" :-) | 16:33 |
*** ramishra has joined #openstack-horizon | 16:33 | |
amotoki | david-lyle: is there a good way to deprecate settings in Horizon? https://review.openstack.org/#/c/114051/5/doc/source/topics/settings.rst | 16:33 |
absubram | amotoki: yes.. most likely Henry will be reaching out to Sean as well regarding this.. thank you for putting out your version to get a little better clarity and some sense of resolution on what to do from Horizon! | 16:33 |
david-lyle | amotoki: good question, let me dig a little bit | 16:34 |
* jpich didn't know we had no need for enable_lb, etc anymore, that is cool | 16:34 | |
amotoki | If we don't have a way like oslo.config, release note and the doc help us | 16:34 |
jpich | Probably we can handle docs/settings deprecation in a separate patch ;) | 16:35 |
jpich | We refer users to this settings page and it's not versioned so we probably should wait a wihle before just removing it there | 16:35 |
-amotoki- I have 6 parallel context and seems to be overflowed.. | 16:35 | |
david-lyle | jpich: I agree, I just added the comment | 16:35 |
david-lyle | still gave it a +2 | 16:36 |
absubram | amotoki: just a quick question.. for edit subnets, you've disabled the IPv6 options for now though? | 16:36 |
david-lyle | I just figured a note on deprecation in docs/settings | 16:36 |
david-lyle | but we can wait | 16:36 |
jpich | david-lyle: Cool! | 16:36 |
amotoki | absubram: i will check the detail when I work on the new vesion. | 16:37 |
jpich | Hm getting kicked out of the office now, good luck to amotoki with all the patches :-) | 16:37 |
*** jpich has quit IRC | 16:37 | |
absubram | amotoki: np.. let me know if you need any help! | 16:38 |
-amotoki- in most cases horizon developers are the first users of new features :-) | 16:38 | |
*** akrivoka has quit IRC | 16:39 | |
*** sbfox has joined #openstack-horizon | 16:39 | |
*** aix has quit IRC | 16:40 | |
*** dulek has quit IRC | 16:41 | |
*** bvandenh has quit IRC | 16:43 | |
*** oro_ has quit IRC | 16:46 | |
*** oro has quit IRC | 16:46 | |
amotoki | david-lyle: thanks for fixing the issue on admin router panel. | 16:46 |
david-lyle | sure no problem | 16:46 |
amotoki | david-lyle: is it better to rebase this patch on top of neutron ext-list aware patch? | 16:46 |
amotoki | david-lyle: this patch introdueces enable_router but if it is extension-aware the option is no longer needed. | 16:47 |
david-lyle | I didn't realize l-3 support was covered by the ext-list | 16:48 |
david-lyle | yeah, I'll tackle that in a bit | 16:48 |
amotoki | both patches are proposed in parallel, so I try to avoid the conflicts. | 16:49 |
david-lyle | amotoki: I'll do that, gate wait is too long to just get the ext-list merged first | 16:50 |
david-lyle | which was my hope | 16:50 |
david-lyle | going to be a long few days gate wise | 16:50 |
amotoki | david-lyle: sounds reasonable to me too. | 16:50 |
amotoki | yeah, check/gate queue is getting longer and longer. it's crazy :-( | 16:51 |
david-lyle | then there seems to be more to the issue in launch instances | 16:51 |
*** woodm1979 has joined #openstack-horizon | 16:51 | |
david-lyle | is there an easy way to disable l-3 in devstack to tackle that? | 16:52 |
*** tqtran has joined #openstack-horizon | 16:53 | |
afaranha | Hi, I'm having some issues when trying to give permission to another user to access project page in identity panel when the user is not an admin, does anyone knows how to solve this? I updated the keystone policy to grant permission to everybody be able to list_projects, list_user_projects and create_project. | 16:53 |
amotoki | david-lyle: I believe just removing q-l3 works | 16:53 |
david-lyle | amotoki: will try, thanks! | 16:53 |
*** clu_ has joined #openstack-horizon | 16:53 | |
david-lyle | afaranha: the change in policy has to be made in keystone and Horizon | 16:54 |
*** pkoniszewski has quit IRC | 16:54 | |
david-lyle | list_user_projects, should be enabled by default | 16:54 |
*** qba73 has joined #openstack-horizon | 16:55 | |
*** lsmola has quit IRC | 16:56 | |
afaranha | david-lyle: I already did this, both the policies are equals, I modified the policy in openstack_dashboard/conf/keystone_policy, and then restarted the services and apache | 16:56 |
afaranha | In horizon appears the Identity panel, but when I click in projects the horizon logs me out with the message: "You do not have permission to access the resource:/identity/" | 16:57 |
*** sbfox has quit IRC | 16:57 | |
*** sbfox has joined #openstack-horizon | 17:00 | |
*** tosky_ is now known as tosky | 17:01 | |
*** ramishra has quit IRC | 17:02 | |
*** harlowja_away is now known as harlowja_ | 17:03 | |
*** ramishra has joined #openstack-horizon | 17:03 | |
*** harlowja_ is now known as harlowja_away | 17:04 | |
*** ArcTanSusan has joined #openstack-horizon | 17:04 | |
*** harlowja_away is now known as harlowja_ | 17:09 | |
*** e0ne has joined #openstack-horizon | 17:10 | |
*** vijendar has quit IRC | 17:14 | |
*** vijendar has joined #openstack-horizon | 17:14 | |
*** erecio has quit IRC | 17:17 | |
*** dguerri is now known as dguerri`afk | 17:20 | |
*** samrose has joined #openstack-horizon | 17:20 | |
*** erecio has joined #openstack-horizon | 17:20 | |
linkid | amotoki: hi. I asked about checking imports in Python 3, but it seems it's not really easy to do it for methods like string.letters which are removed | 17:25 |
amotoki | linkid: thanks for checking the detail. We see only a few modules use it and I think a risk to use the method in other modules before python3 compat is fully enabled. | 17:27 |
amotoki | linkid: I now agree that we can go as-is. | 17:27 |
*** ramishra has quit IRC | 17:28 | |
*** absubram has quit IRC | 17:29 | |
*** tosky has quit IRC | 17:30 | |
*** zul has quit IRC | 17:37 | |
*** Sukhdev has joined #openstack-horizon | 17:40 | |
*** sbfox has quit IRC | 17:45 | |
*** tosky has joined #openstack-horizon | 17:48 | |
*** zul has joined #openstack-horizon | 17:51 | |
*** amcrn has joined #openstack-horizon | 17:51 | |
*** echevemaster has joined #openstack-horizon | 17:53 | |
*** regebro has quit IRC | 17:56 | |
*** morganfainberg is now known as morganfainberg_Z | 17:57 | |
*** TravT has joined #openstack-horizon | 18:05 | |
*** sbfox has joined #openstack-horizon | 18:06 | |
*** sbfox1 has joined #openstack-horizon | 18:07 | |
*** bradjones has quit IRC | 18:09 | |
*** sbfox has quit IRC | 18:11 | |
*** qba73 has quit IRC | 18:17 | |
*** bao_ has quit IRC | 18:20 | |
*** sbfox has joined #openstack-horizon | 18:21 | |
*** sbfox1 has quit IRC | 18:21 | |
*** bao_ has joined #openstack-horizon | 18:22 | |
*** lcheng_ has joined #openstack-horizon | 18:26 | |
linkid | amotoki: well, it may be possible to add to the hacking module a function to check for imported modules like that… I'm to do so | 18:32 |
*** wuhg has quit IRC | 18:32 | |
*** samrose_ has joined #openstack-horizon | 18:35 | |
linkid | ok, I may have it | 18:36 |
linkid | but it's not very clean… | 18:36 |
*** samrose has quit IRC | 18:38 | |
*** ArcTanSusan has quit IRC | 18:38 | |
linkid | is the channel for the hacking module the #openstack-qa one ? | 18:39 |
*** romainh has joined #openstack-horizon | 18:40 | |
linkid | hmm… don't think so… | 18:40 |
*** pkoniszewski has joined #openstack-horizon | 18:41 | |
*** e0ne has quit IRC | 18:46 | |
*** sigmavirus24 has joined #openstack-horizon | 18:49 | |
*** sbfox has quit IRC | 18:49 | |
*** e0ne has joined #openstack-horizon | 18:50 | |
*** ArcTanSusan has joined #openstack-horizon | 18:51 | |
*** pkoniszewski has quit IRC | 18:53 | |
*** ArcTanSusan has quit IRC | 18:55 | |
*** sbfox has joined #openstack-horizon | 18:57 | |
*** ArcTanSusan has joined #openstack-horizon | 18:59 | |
*** amotoki_ has joined #openstack-horizon | 19:02 | |
*** amotoki has quit IRC | 19:03 | |
*** AlkaD has quit IRC | 19:03 | |
*** peristeri has quit IRC | 19:04 | |
*** lcheng_ has quit IRC | 19:06 | |
*** sbfox has quit IRC | 19:08 | |
*** sbfox1 has joined #openstack-horizon | 19:08 | |
*** amerine has quit IRC | 19:09 | |
*** chuck_ has joined #openstack-horizon | 19:14 | |
*** zul has quit IRC | 19:16 | |
*** romainh has left #openstack-horizon | 19:17 | |
*** chuck_ has quit IRC | 19:20 | |
*** zul has joined #openstack-horizon | 19:20 | |
*** sambetts has quit IRC | 19:22 | |
*** peristeri has joined #openstack-horizon | 19:24 | |
*** asahlin has quit IRC | 19:26 | |
*** e0ne has quit IRC | 19:27 | |
*** amerine has joined #openstack-horizon | 19:27 | |
*** e0ne has joined #openstack-horizon | 19:29 | |
*** e0ne has quit IRC | 19:30 | |
*** prasoon has quit IRC | 19:38 | |
*** prasoon has joined #openstack-horizon | 19:39 | |
*** Sukhdev has quit IRC | 19:40 | |
*** prasoon has quit IRC | 19:44 | |
*** samrose_ has quit IRC | 19:53 | |
*** e0ne has joined #openstack-horizon | 19:53 | |
*** qba73 has joined #openstack-horizon | 20:01 | |
*** e0ne has quit IRC | 20:03 | |
*** e0ne has joined #openstack-horizon | 20:07 | |
*** sbfox1 has quit IRC | 20:08 | |
*** gugl2 has quit IRC | 20:12 | |
*** gugl has joined #openstack-horizon | 20:13 | |
*** sbfox has joined #openstack-horizon | 20:13 | |
*** lcheng_ has joined #openstack-horizon | 20:14 | |
*** absubram has joined #openstack-horizon | 20:17 | |
*** Dafna has quit IRC | 20:23 | |
*** denis_makogon has joined #openstack-horizon | 20:26 | |
*** qba73 has quit IRC | 20:27 | |
*** qba73 has joined #openstack-horizon | 20:27 | |
*** e0ne has quit IRC | 20:30 | |
*** lcheng_ has quit IRC | 20:31 | |
*** echevemaster has quit IRC | 20:32 | |
*** stpierre has quit IRC | 20:32 | |
*** amotoki_ has quit IRC | 20:32 | |
*** e0ne has joined #openstack-horizon | 20:33 | |
*** fifieldt_ has quit IRC | 20:42 | |
*** e0ne has quit IRC | 20:42 | |
*** sbfox has quit IRC | 20:43 | |
*** sbfox has joined #openstack-horizon | 20:43 | |
*** e0ne has joined #openstack-horizon | 20:46 | |
*** e0ne has quit IRC | 20:49 | |
*** e0ne has joined #openstack-horizon | 20:53 | |
*** radez is now known as radez_g0n3 | 20:54 | |
*** peristeri has quit IRC | 20:55 | |
*** fifieldt_ has joined #openstack-horizon | 20:59 | |
*** peristeri has joined #openstack-horizon | 21:01 | |
*** amerine_ has joined #openstack-horizon | 21:02 | |
*** amerine has quit IRC | 21:02 | |
*** neelashah has quit IRC | 21:04 | |
*** gokrokve has joined #openstack-horizon | 21:05 | |
gokrokve | Hi. On latest master I am getting the error 'horizon/lib/angular/angular-cookies.js' could not be found in the COMPRESS_ROOT | 21:06 |
gokrokve | I've checked lib forder and it has only jquery scripts but no angular | 21:06 |
gokrokve | Is it normal situation. Does anybody know how to workaround this issue? | 21:07 |
*** ArcTanSusan has quit IRC | 21:08 | |
*** peristeri has quit IRC | 21:10 | |
*** ArcTanSusan has joined #openstack-horizon | 21:12 | |
*** Sukhdev has joined #openstack-horizon | 21:15 | |
*** qba73 has quit IRC | 21:19 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 21:20 | |
*** e0ne has quit IRC | 21:27 | |
*** e0ne has joined #openstack-horizon | 21:27 | |
*** rebelagentm has quit IRC | 21:31 | |
*** alexpilotti has quit IRC | 21:47 | |
*** sbfox has quit IRC | 21:48 | |
*** sbfox has joined #openstack-horizon | 21:48 | |
*** e0ne has quit IRC | 21:56 | |
*** erecio has quit IRC | 21:57 | |
*** ArcTanSusan has quit IRC | 21:57 | |
*** e0ne has joined #openstack-horizon | 22:00 | |
*** denis_makogon has quit IRC | 22:05 | |
*** bao_ has quit IRC | 22:05 | |
*** vijendar has quit IRC | 22:05 | |
*** linkid has left #openstack-horizon | 22:07 | |
*** amcrn has quit IRC | 22:08 | |
*** e0ne has quit IRC | 22:09 | |
*** lcheng_ has joined #openstack-horizon | 22:09 | |
*** gary-smith_ has joined #openstack-horizon | 22:09 | |
*** tsufiev has quit IRC | 22:14 | |
*** lcheng_ has quit IRC | 22:14 | |
*** amcrn has joined #openstack-horizon | 22:14 | |
*** tsufiev has joined #openstack-horizon | 22:17 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:17 | |
*** amcrn has quit IRC | 22:17 | |
*** amotoki has joined #openstack-horizon | 22:33 | |
*** ArcTanSusan has joined #openstack-horizon | 22:34 | |
*** morganfainberg_Z is now known as morganfainberg | 22:34 | |
tqtran | gokrokve: did the new nenv fix your issue? | 22:37 |
*** ArcTanSusan has quit IRC | 22:37 | |
*** amotoki has quit IRC | 22:38 | |
*** apodacae has quit IRC | 22:40 | |
*** ArcTanSusan has joined #openstack-horizon | 22:41 | |
*** sbfox has quit IRC | 22:44 | |
*** sbfox1 has joined #openstack-horizon | 22:44 | |
gokrokve | tqtran: Actually no | 22:44 |
gokrokve | I had to install horizon from tarball | 22:44 |
*** sbfox1 has quit IRC | 22:44 | |
*** sbfox has joined #openstack-horizon | 22:44 | |
gokrokve | I used 2014.2 | 22:44 |
tqtran | tarball? | 22:45 |
tqtran | does that mean from scratch? | 22:45 |
gokrokve | no via pip install http://tarballs.openstack.org/horizon/horizon-2014.2.b2.tar.gz | 22:45 |
gokrokve | I am doing plugin development for Horizon | 22:46 |
*** doug-fish has left #openstack-horizon | 22:48 | |
gokrokve | Surprisingly I was not be able to install Horizon from master branch and from stable/icehouse branch | 22:48 |
gokrokve | Every time I used Horizon from source I got different issues | 22:49 |
*** vkmc has quit IRC | 22:59 | |
*** Sukhdev has quit IRC | 23:15 | |
*** david-lyle has quit IRC | 23:17 | |
*** woodm1979 has quit IRC | 23:19 | |
*** ericpete_ has quit IRC | 23:19 | |
*** TravT has quit IRC | 23:21 | |
*** ArcTanSusan has quit IRC | 23:22 | |
*** sbfox has quit IRC | 23:25 | |
*** amcrn has joined #openstack-horizon | 23:40 | |
*** ArcTanSusan has joined #openstack-horizon | 23:43 | |
*** lcheng has quit IRC | 23:48 | |
*** gokrokve has quit IRC | 23:51 | |
*** tosky has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!