*** uck has quit IRC | 00:01 | |
*** trozet has quit IRC | 00:54 | |
*** trozet has joined #openstack-heat-translator | 01:07 | |
*** bobh has joined #openstack-heat-translator | 01:07 | |
*** spzala has quit IRC | 01:21 | |
*** spzala has joined #openstack-heat-translator | 02:22 | |
*** spzala has quit IRC | 02:27 | |
*** spzala has joined #openstack-heat-translator | 02:53 | |
*** spzala has quit IRC | 02:59 | |
*** spzala has joined #openstack-heat-translator | 03:01 | |
*** spzala has quit IRC | 03:05 | |
*** trozet has quit IRC | 03:32 | |
*** sridhar_ram has quit IRC | 03:47 | |
*** sridhar_ram has joined #openstack-heat-translator | 03:50 | |
*** bobh has quit IRC | 03:51 | |
*** skraynev has quit IRC | 03:56 | |
*** spzala has joined #openstack-heat-translator | 04:02 | |
*** spzala has quit IRC | 04:06 | |
*** vishwanathj has quit IRC | 04:20 | |
*** vishwanathj has joined #openstack-heat-translator | 04:21 | |
*** spzala has joined #openstack-heat-translator | 05:01 | |
*** spzala has quit IRC | 05:05 | |
*** spzala has joined #openstack-heat-translator | 06:02 | |
*** spzala has quit IRC | 06:06 | |
openstackgerrit | Santhosh64 proposed openstack/heat-translator: Implemented Scaling policies in heat translator https://review.openstack.org/302636 | 06:08 |
---|---|---|
openstackgerrit | Santhosh64 proposed openstack/heat-translator: Implemented Scaling policies in heat translator https://review.openstack.org/302636 | 06:13 |
*** vishwanathj has quit IRC | 06:15 | |
*** vishwanathj has joined #openstack-heat-translator | 06:15 | |
*** spzala has joined #openstack-heat-translator | 07:02 | |
*** spzala has quit IRC | 07:07 | |
openstackgerrit | Steve Martinelli proposed openstack/heat-translator: fix the tosca-parser job https://review.openstack.org/353653 | 07:12 |
*** spzala has joined #openstack-heat-translator | 08:03 | |
*** spzala has quit IRC | 08:08 | |
*** spzala has joined #openstack-heat-translator | 11:05 | |
*** spzala has quit IRC | 11:10 | |
*** spzala has joined #openstack-heat-translator | 12:06 | |
*** spzala has quit IRC | 12:11 | |
*** bobh has joined #openstack-heat-translator | 12:57 | |
*** spzala has joined #openstack-heat-translator | 13:07 | |
*** spzala has quit IRC | 13:12 | |
*** bobh has quit IRC | 13:15 | |
*** spzala has joined #openstack-heat-translator | 13:18 | |
openstackgerrit | Merged openstack/heat-translator: fix the tosca-parser job https://review.openstack.org/353653 | 13:40 |
*** bobh has joined #openstack-heat-translator | 13:54 | |
*** trozet has joined #openstack-heat-translator | 14:13 | |
openstackgerrit | Merged openstack/heat-translator: Implemented Scaling policies in heat translator https://review.openstack.org/302636 | 14:20 |
*** uck has joined #openstack-heat-translator | 14:27 | |
*** uck has quit IRC | 15:21 | |
*** zaneb has quit IRC | 15:30 | |
*** shangxdy_ has joined #openstack-heat-translator | 15:56 | |
spzala | Hi all topol: bobh: shangxdy_: tbh: | 16:00 |
shangxdy_ | HI,spzala and all:) | 16:00 |
spzala | :) | 16:01 |
shangxdy_ | I'am looking at the comments. | 16:01 |
spzala | shangxdy_: cool and meanwhile we can wait for a minute or two if anyone else joining | 16:02 |
shangxdy_ | ok. | 16:02 |
spzala | aite, we can start our short meeting | 16:04 |
spzala | announcement: tosca-parser 0.6.0 is released | 16:04 |
bobh | o/ sorry late | 16:05 |
spzala | and seems like it's backward compatible this time and no issues with heat-translator or tacker | 16:05 |
spzala | bobh: o/ | 16:05 |
spzala | bobh: np, glad that you made it :) | 16:05 |
shangxdy_ | great, i have updated the release locally. | 16:06 |
spzala | I just announced that tosca-parser 0.6.0 seems backward compatible and didn't create any translator or tacker issues, | 16:06 |
bobh | spzala: cool | 16:06 |
spzala | first time we didn't have to change requirements in translator | 16:06 |
spzala | :) | 16:06 |
spzala | bobh: thanks again for your manual verification of new release with tacker | 16:07 |
bobh | spzala: np | 16:07 |
spzala | shangxdy: :-) Cool | 16:07 |
spzala | the second things - gate-heat-translator-tox-py27-tosca-parser-master-ubuntu-xenial | 16:07 |
spzala | is been failing lately after the gate names were changed with xenial suffix | 16:07 |
spzala | since it's non-voting things were fine, but we wanted to make sure to fix it soon as possible and seems like the issue was with char length | 16:08 |
spzala | of the gate name .. possible fix was added by stevemar and it's merged .. hopefully this fixes the issue | 16:09 |
spzala | that's pretty much from my side | 16:09 |
spzala | we can move to substitution_mappings discussion https://review.openstack.org/#/c/345492/ | 16:10 |
spzala | shangxdy: we can have quick discussion here, since we don't have full test coverage to it and since the complete implementation is not yet done, the main thing here is to get agreed with our approach | 16:11 |
shangxdy_ | The gate name is Indeed too long:) | 16:11 |
spzala | shangxdy: :) yup, it was long and got too long after the new suffix :-) | 16:11 |
shangxdy_ | Ok | 16:11 |
shangxdy_ | Let's back to the substitution_mappings. | 16:12 |
spzala | shangxdy: the patch looks great, and provides initial implementation nicely but as I said we just need to make sure our approach | 16:12 |
spzala | to me the latest patch approach looks good, if not perfect, but we can discuss and change as needed | 16:13 |
shangxdy_ | I agree | 16:13 |
spzala | shangxdy: and once we have initial patch merged (this patch), your new patches with test coverage will make it more clear | 16:14 |
spzala | shangxdy: so let's not spend too much time on this one, if we like approach and you think it can be changed easily going forward as needed or as you add more patches then we should be fine | 16:15 |
spzala | shangxdy: but it's your call :-) | 16:15 |
shangxdy_ | Can you consider the translation to HOT? If you have i agree the latest patch | 16:15 |
spzala | shangxdy: you are the one doing hard work on it | 16:15 |
spzala | shangxdy_: sorry I didn't get your question | 16:16 |
spzala | if you are asking if this patch will help with translation or not? | 16:16 |
spzala | I think it should allow translation nicely, again it's hard unless we start playing with translation but I agree that we need to keep translation in mind | 16:17 |
shangxdy_ | How to translate to hot if the mapped node template associated with sub mapping class | 16:17 |
shangxdy_ | I means the brief approach for translation. | 16:18 |
spzala | when we translate node template, it will give associated sub_mapping and then we replace and translate that particular node template with call to sub_mapping | 16:18 |
spzala | e.g. sub_mapping.capabilities() or .requirements() or .interfaces() | 16:19 |
spzala | when I thought about it, node template with associated sub_mapping object makes it easy on translation side | 16:20 |
shangxdy_ | But in my initial opinion, there is not much information for translation in sub mapping class . | 16:20 |
spzala | shangxdy: yes, I agree we definitely need to consider brief approach | 16:21 |
spzala | that's true, but we just need the data and replace the node template with sub_mapping data or node template | 16:21 |
spzala | and than continue translation as usual | 16:21 |
spzala | in-memory | 16:22 |
spzala | it's similar to say NodeTemplate or other classes doesn't have much information for translation but it gives a mean to iterate over data | 16:23 |
spzala | like properties, req, cap, etc and we use that during translation | 16:23 |
shangxdy_ | In my patch, sub mapping class is only used to validate and associated. and it doesn't replace any data. | 16:24 |
spzala | true, we are not replacing any data no where in fact but | 16:25 |
spzala | sub mapping class should provide the data like, submapping.type or submapping.properties etc | 16:25 |
spzala | the class shouldn't only do validation but provide all those data about itself | 16:26 |
shangxdy_ | I known your idea. but i think it's will be more complicated for translation. | 16:26 |
spzala | thanks, I couldn't think about complication (again, you know it better than me as you are having a bigger picture with owing blueprints on both side) | 16:27 |
spzala | I guess during the translation, we have to do similar things as I was saying | 16:28 |
spzala | we can handle it similar ways like translation of node templates, groups, policy etc. .. the major difference is first we need to get sub_mapping object which will provide node template | 16:29 |
shangxdy_ | Sure, submapping.node_type submapping.capabilites and submapping.requirements will be provided in sub mapping class. But how to use it is different between us:) | 16:29 |
spzala | and then we use the data of that node template instead of the one in service template | 16:30 |
spzala | of course after validation | 16:30 |
shangxdy_ | Yes, that's the point between us. | 16:31 |
spzala | :) well again I will respect your decision but if the diff between approach is not major then we can go ahead with the patch | 16:31 |
spzala | and modify as we need unless the current code doesn't set the base .. | 16:32 |
shangxdy_ | Agree!:) | 16:32 |
spzala | :-) thanks, certain things we can only find out when we do actual translation but let's focus on the correct parsing and if you think we are doing it then during translation we may need to add some more code on translator side or even changes in parser | 16:34 |
shangxdy_ | We shall run to the same direction, and turn around if it doesn't work. | 16:34 |
spzala | we always need to remember that purpose of tosca-parser project (when I spun the code from translator) was to allow user to use parser outside translation need | 16:35 |
spzala | shagnxdy_: absolutely, that's why I said if the base code are good then we go forward | 16:35 |
spzala | so definitely need to keep translation in mind and if we can assure here that we can correctly parse the template provided with sub_mappings then translation should be possible | 16:36 |
shangxdy_ | It sounds great:) | 16:36 |
spzala | every patch that goes in parser impacts translation code one way or other | 16:37 |
spzala | :-) thanks | 16:37 |
shangxdy_ | :) | 16:37 |
spzala | so I would say, please go over the patch one more time and if you think it looks good (if not great) | 16:38 |
spzala | we can merge it and then have your other patches come in with tests etc | 16:38 |
spzala | and as we do that, hopefully we will get a better picture within parser itself | 16:38 |
spzala | i.e. before creating next pypi which will be used in translation | 16:38 |
spzala | and fix anything before next pypi | 16:39 |
shangxdy_ | Ok, a question, every patch needs a bp or bug in launchpad? | 16:39 |
spzala | not really, it's totally find to create patch without a bug or bp unless the patch is touching something that needs to be described for a better review of code changes | 16:40 |
shangxdy_ | I think we can complete the sub mapping function in parser and translator before next release. | 16:40 |
spzala | if it's straightforward change, no bug or bp needed | 16:40 |
shangxdy_ | Understood | 16:41 |
spzala | shangxdy_: i am sure and that sounds great.. once we have initial implementation working then we iterate over it with complex use cases as we go further in following release cycles | 16:41 |
spzala | shangxdy: please feel free to ping or email me with any question .. sub_mapping is very important and thanks for working on it :-) | 16:45 |
spzala | shangxdy: anything else from you? or even on sub mapping right now ? | 16:45 |
shangxdy_ | Next week I want to spend some time on OPNFV, but i'll alsowork for the patch | 16:47 |
spzala | well, and as we just talked the gate issue is fixed .. stevemar: thanks a bunch! | 16:47 |
shangxdy_ | Great. | 16:47 |
spzala | shangxdy: sure, if we can get this patch merged once you think it's alright we can merge this one .. but please make any changes as needed or we can discuss before this merge | 16:48 |
spzala | shangxdy_: :-) yup | 16:48 |
shangxdy_ | Another question, we can discuss it next time: what's the different between abstract node template and substituted node template? and how to implement the tow node template? | 16:50 |
spzala | sure, to me they are same | 16:51 |
spzala | abstract node is implemented by sub node | 16:51 |
spzala | I think that's the abstraction | 16:52 |
shangxdy_ | The tow node templates are different in spec. but the implementations are similar or same | 16:52 |
shangxdy_ | I think sub node is subset of abstract node. | 16:54 |
spzala | I see, not sure where exactly in spec you are mentioned but abstract is what is not implemented and sub mapping makes that abstraction possible | 16:54 |
spzala | :-) I guess or other way | 16:55 |
shangxdy_ | The chapter 2.10 in spec. | 16:56 |
spzala | but to me that's the relationship between two of them | 16:56 |
spzala | yup the chapter on sub mapping | 16:57 |
spzala | you agree with me on the relationship part right? | 16:58 |
spzala | would like to know if it's more than that | 16:58 |
*** bobh has quit IRC | 16:58 | |
shangxdy_ | Agree, in fact, in my patch, i consider the tow node templates the same in function _is_sub_mapped_node. | 16:58 |
spzala | shangxdy: yup, got to tell that you have understood the concept of sub_mapping well .. it's not easy to grasp honestly | 16:59 |
spzala | once you understand it looks easy (well that's with everything) | 17:00 |
spzala | shangxdy: we are over time on meeting ;) let's end? | 17:02 |
spzala | shangxdy: we can continue discussion though until you feel sleepy :-) and I feel hungry :) | 17:03 |
shangxdy_ | I think template composition in HOT is the best example of sub_mappings | 17:03 |
shangxdy_ | O, it's over time:) | 17:04 |
shangxdy_ | I'am sleepy once you said that:) | 17:05 |
spzala | shangxdy: lol | 17:05 |
spzala | shangxdy: wait, what did u mean? | 17:05 |
shangxdy_ | Have a good launch:) | 17:05 |
spzala | shangxdy: OK, I see you mean in Heat itself? | 17:05 |
shangxdy_ | Yes, nested template solution in heat. | 17:06 |
spzala | shangxdy_: yup, I am with you on that | 17:06 |
spzala | shangxdy_: alright then, good night and I am heading to lunch | 17:07 |
shangxdy_ | :) | 17:07 |
shangxdy_ | good lunch. | 17:07 |
spzala | shangxdy_: :) thanks | 17:08 |
shangxdy_ | By, spzala and all | 17:09 |
spzala | shangxdy:_ bye | 17:10 |
*** shangxdy_ has quit IRC | 17:10 | |
*** bobh has joined #openstack-heat-translator | 17:59 | |
*** bobh has quit IRC | 18:03 | |
*** bobh has joined #openstack-heat-translator | 18:35 | |
*** bobh has quit IRC | 21:20 | |
*** zaneb has joined #openstack-heat-translator | 21:30 | |
*** zaneb has quit IRC | 21:30 | |
*** zaneb has joined #openstack-heat-translator | 21:31 | |
*** bobh has joined #openstack-heat-translator | 21:33 | |
*** bobh has quit IRC | 21:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!