*** bobh has joined #openstack-heat-translator | 00:32 | |
openstackgerrit | Merged openstack/heat-translator: Update code to use tosca-parser 0.4.0 https://review.openstack.org/276473 | 00:45 |
---|---|---|
*** sridhar_ram has quit IRC | 01:15 | |
*** spzala_ has quit IRC | 01:56 | |
*** spzala has joined #openstack-heat-translator | 01:56 | |
*** spzala has quit IRC | 02:01 | |
*** spzala has joined #openstack-heat-translator | 02:03 | |
bobh | spzala: hello | 02:03 |
openstackgerrit | Bob Haddleton proposed openstack/heat-translator: Fixed an import test in the OSC tests, and re-enabled https://review.openstack.org/276537 | 02:20 |
*** sridhar_ram has joined #openstack-heat-translator | 02:43 | |
*** sridhar_ram has quit IRC | 02:48 | |
*** spzala has quit IRC | 03:24 | |
*** spzala has joined #openstack-heat-translator | 03:25 | |
*** spzala has quit IRC | 03:29 | |
*** bobh has quit IRC | 03:47 | |
*** spzala has joined #openstack-heat-translator | 04:25 | |
*** spzala has quit IRC | 04:30 | |
*** spzala has joined #openstack-heat-translator | 05:27 | |
*** spzala has quit IRC | 05:32 | |
*** spzala has joined #openstack-heat-translator | 06:29 | |
*** spzala has quit IRC | 06:34 | |
*** spzala has joined #openstack-heat-translator | 07:30 | |
*** vahidh has quit IRC | 07:32 | |
*** vahidh has joined #openstack-heat-translator | 07:33 | |
*** vahidh has quit IRC | 07:33 | |
*** vahidh has joined #openstack-heat-translator | 07:33 | |
*** spzala has quit IRC | 07:35 | |
*** vahidh has quit IRC | 07:36 | |
*** spzala has joined #openstack-heat-translator | 08:31 | |
*** spzala has quit IRC | 08:36 | |
*** openstackgerrit has quit IRC | 09:17 | |
*** openstackgerrit has joined #openstack-heat-translator | 09:18 | |
*** spzala has joined #openstack-heat-translator | 09:32 | |
*** spzala has quit IRC | 09:37 | |
*** spzala has joined #openstack-heat-translator | 10:33 | |
*** spzala has quit IRC | 10:37 | |
*** vahidh has joined #openstack-heat-translator | 11:06 | |
*** vahidh has quit IRC | 11:10 | |
openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Map get_property to an actual property https://review.openstack.org/270318 | 11:19 |
openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Interpret get_artifact in inputs handling https://review.openstack.org/276686 | 11:19 |
*** spzala has joined #openstack-heat-translator | 11:33 | |
*** spzala has quit IRC | 11:38 | |
*** spzala has joined #openstack-heat-translator | 12:34 | |
*** spzala has quit IRC | 12:39 | |
*** bobh has joined #openstack-heat-translator | 12:54 | |
*** bobh has quit IRC | 12:56 | |
*** spzala has joined #openstack-heat-translator | 13:35 | |
*** spzala has quit IRC | 13:40 | |
*** zaneb has quit IRC | 13:44 | |
*** spzala has joined #openstack-heat-translator | 13:58 | |
*** zaneb has joined #openstack-heat-translator | 13:59 | |
*** spzala has quit IRC | 14:11 | |
*** zaneb has quit IRC | 14:11 | |
*** spzala has joined #openstack-heat-translator | 14:11 | |
*** zaneb has joined #openstack-heat-translator | 14:14 | |
*** spzala has quit IRC | 14:15 | |
*** vahidh has joined #openstack-heat-translator | 14:42 | |
*** vahidh has quit IRC | 14:47 | |
*** spzala has joined #openstack-heat-translator | 14:53 | |
openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Merge interfaces between the node template, its type and its type hierarchy. Disable some tests which import URL from GitHub, this commit needs to reach the repo for those tests to be valid again. A following patch will re-enable them. https://review.openstack.org/269537 | 15:29 |
openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Merge interfaces between the node template, its type and its type hierarchy. Disable some tests which import URL from GitHub, this commit needs to reach the repo for those tests to be valid again. A following patch will re-enable them. https://review.openstack.org/269537 | 15:31 |
openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Enable tests disabled in previous patch https://review.openstack.org/276787 | 15:34 |
openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Merge interfaces between the node template, its type and its type hierarchy. Disable some tests which import URL from GitHub, this commit needs to reach the repo for those tests to be valid again. A following patch will re-enable them. https://review.openstack.org/269537 | 15:37 |
openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Enable tests disabled in previous patch https://review.openstack.org/276787 | 15:37 |
*** bobh has joined #openstack-heat-translator | 15:38 | |
*** bobh has quit IRC | 15:38 | |
*** bobh has joined #openstack-heat-translator | 15:38 | |
*** vahidh has joined #openstack-heat-translator | 16:02 | |
*** tbh has joined #openstack-heat-translator | 16:12 | |
*** vishwanathj has joined #openstack-heat-translator | 16:14 | |
tbh | spzala, ping | 16:22 |
spzala | tbh: Hi | 16:27 |
spzala | tbh: did you get my email? :) | 16:28 |
spzala | tbh: I need to run for a team meeting | 16:29 |
spzala | tbh: I see your email on bug | 16:29 |
spzala | tbh: thanks for taking ownership of it .. please shoot me email for any questions. I will be back in about an hour. | 16:30 |
*** spzala has quit IRC | 16:30 | |
*** spzala has joined #openstack-heat-translator | 16:31 | |
*** spzala_ has joined #openstack-heat-translator | 16:32 | |
*** spzala has quit IRC | 16:35 | |
tbh | spzala_, sure | 16:36 |
*** spzala_ has quit IRC | 16:36 | |
openstackgerrit | bharaththiruveedula proposed openstack/heat-translator: Fix OSC tests issues https://review.openstack.org/276825 | 16:54 |
*** vishwanathj has quit IRC | 17:02 | |
*** vishwanathj has joined #openstack-heat-translator | 17:03 | |
*** vishwanathj has quit IRC | 17:18 | |
*** vahidh has quit IRC | 17:22 | |
*** vahidh has joined #openstack-heat-translator | 17:42 | |
*** spzala has joined #openstack-heat-translator | 18:11 | |
tbh | spzala, pushed the patch for that bug, waiting for jenkins result | 18:12 |
spzala | tbh: awesome | 18:14 |
tbh | spzala, :) | 18:14 |
spzala | tbh: :-) thanks. I just looked at the patch, it might not fix it but let's see | 18:15 |
tbh | spzala, I tested in my local setup | 18:15 |
bobh | spzala: I tried that same patch last night - worked in my test environment but not in the gate - very strange | 18:15 |
spzala | tbh: I had that fix in my local environment before I disabled osc tests | 18:15 |
tbh | spzala, I see | 18:16 |
bobh | spzala: wondering if there is a requirements issue, where something local is at a higher release than what is in the gate | 18:16 |
spzala | bobh: tbh: hmmm, I could see the same errors as I see on Jenkins | 18:16 |
bobh | spzala: tbh: that patch is definitely needed, but something else going on too | 18:16 |
spzala | bobh: but we don't have anything higher than 0.4.0 that's what gate should be using too | 18:16 |
bobh | spzala: I'm wondering if a different library is involved | 18:17 |
spzala | bobh: tbh: well, I agree it's needed | 18:17 |
spzala | bobh: it shouldn't | 18:17 |
tbh | bobh, spzala any logs? | 18:17 |
spzala | bobh: nope, I couldn't get anything .. locally all I can see it's something with mocking stdout | 18:18 |
bobh | tbh: just the failing tests - OSC is doing something different or pulling in something | 18:18 |
bobh | spzala: tbh: interesting that the heat template version shows up as a datetime(2013, 05, 13) or whatever instead of the string | 18:19 |
bobh | in the failues | 18:19 |
bobh | failures | 18:19 |
spzala | bobh: tbh: no, I don't think so, I could see the translation side on OSC is as expected | 18:19 |
tbh | bobh, yes I got the same error in local setup, as difference of both dicts | 18:19 |
spzala | bobh: yes, and I think that's where something with the way command line output is handled.. my guess | 18:20 |
tbh | bobh, with this patch, I got rid of this | 18:20 |
tbh | bobh, spzala need to check in gate | 18:20 |
spzala | tbh: that's strange. I tried the fix you have but locally it's giving same errors as gate | 18:21 |
tbh | spzala, I checked in this way | 18:22 |
tbh | spzala, before this line https://github.com/openstack/heat-translator/blob/master/translator/osc/v1/tests/notest_translate.py#L74 | 18:22 |
tbh | spzala, I added the self.assertEqual("", mock_stdout_yaml) | 18:22 |
tbh | spzala, it gave the hot with out "heat template version" | 18:23 |
spzala | tbh: similar what I see is, self.cmd.take_action works fine | 18:23 |
tbh | spzala, so I added that line | 18:23 |
tbh | so it worked fine | 18:23 |
spzala | tbh: but starting line #73 it's giving error | 18:23 |
tbh | and other case is to change expected_msg, copied from bobh commit | 18:24 |
tbh | spzala, oh | 18:24 |
spzala | tbh: I see, | 18:24 |
spzala | tbh: I didn't see the change you made on #73 | 18:24 |
tbh | spzala, I meant for debugging | 18:25 |
spzala | tbh: I thought it was the csar change only you checked in | 18:25 |
tbh | spzala, https://review.openstack.org/#/c/276825/1/translator/osc/v1/tests/test_translate.py | 18:25 |
tbh | spzala, you can see the change in 73 line also | 18:25 |
spzala | tbh: yup, I just noticed | 18:26 |
bobh | have to see what Jenkins says | 18:26 |
bobh | pretty slow - 2+ hours? | 18:26 |
spzala | tbh: that is the fix then | 18:27 |
tbh | bobh, yes | 18:27 |
spzala | tbh: I just tried locally with one test and it worked | 18:27 |
spzala | tbh: bobh: I feel it's Jenkins gonna be happy | 18:27 |
tbh | spzala, I hope so | 18:27 |
tbh | spzala, any reason why jenkins is slow? | 18:28 |
spzala | tbh: nope, no idea | 18:28 |
spzala | tbh: besides it's Friday :-) | 18:28 |
tbh | spzala, :D | 18:28 |
*** sridhar_ram has joined #openstack-heat-translator | 18:29 | |
spzala | tbh: my local tox is happy now ..hopefully so should be Jenkins with you #73 change | 18:30 |
tbh | spzala, jenkins is happy | 18:30 |
spzala | tbh: yay | 18:31 |
spzala | tbh: awesome | 18:31 |
tbh | spzala, :) | 18:31 |
spzala | bobh: it's working :-) | 18:31 |
bobh | spzala: great! on the the next bug :-) | 18:31 |
bobh | on to the next bug | 18:32 |
spzala | bobh: :-) :-) Yup cool | 18:32 |
spzala | tbh: thanks again .. going to merge it | 18:32 |
spzala | tbh: hopefully you will sleep well now :-) good night unless you aren't ready for sleep yet | 18:33 |
tbh | spzala, hehe, not yet though | 18:33 |
spzala | tbh: OK :) | 18:34 |
*** tbh has quit IRC | 18:41 | |
openstackgerrit | Merged openstack/heat-translator: Fix OSC tests issues https://review.openstack.org/276825 | 18:43 |
*** spzala has quit IRC | 18:52 | |
*** spzala has joined #openstack-heat-translator | 19:20 | |
*** spzala has quit IRC | 19:24 | |
*** spzala has joined #openstack-heat-translator | 19:25 | |
*** sridhar_ram1 has joined #openstack-heat-translator | 19:36 | |
openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Merge interfaces between the node template, its type and its type hierarchy. Disable some tests which import URL from GitHub, this commit needs to reach the repo for those tests to be valid again. A following patch will re-enable them. https://review.openstack.org/269537 | 19:36 |
*** sridhar_ram has quit IRC | 19:38 | |
*** sridhar_ram1 is now known as sridhar_ram | 20:03 | |
*** sridhar_ram1 has joined #openstack-heat-translator | 20:27 | |
*** sridhar_ram has quit IRC | 20:30 | |
*** spzala has quit IRC | 21:20 | |
*** sridhar_ram has joined #openstack-heat-translator | 22:03 | |
*** sridhar_ram1 has quit IRC | 22:04 | |
*** vishwanathj has joined #openstack-heat-translator | 22:46 | |
*** sridhar_ram has quit IRC | 22:58 | |
*** vishwanathj has quit IRC | 23:00 | |
*** sridhar_ram has joined #openstack-heat-translator | 23:01 | |
*** bobh has quit IRC | 23:35 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!