| opendevreview | shisen.zhang proposed openstack/glance master: Delete image in stage when using the image conversion plugin https://review.opendev.org/c/openstack/glance/+/925436 | 03:17 |
|---|---|---|
| opendevreview | Merged openstack/glance master: Make separate schema for new location API https://review.opendev.org/c/openstack/glance/+/925333 | 04:19 |
| opendevreview | shisen.zhang proposed openstack/glance master: Delete image in stage when using the image conversion plugin https://review.opendev.org/c/openstack/glance/+/925436 | 05:58 |
| opendevreview | Eric Harney proposed openstack/glance master: Auto-detect qemu-img qed support for unit tests https://review.opendev.org/c/openstack/glance/+/925466 | 11:16 |
| opendevreview | Merged openstack/glance stable/2023.1: Do not set_acls if store is not associated to glance node https://review.opendev.org/c/openstack/glance/+/925055 | 11:32 |
| pdeore | abhishekk, rosmaita, dansmith, croelandt, mrjoshi glance weekly meeting in 10 minutes at #openstack-meeting | 13:50 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Revert image state to queued if conversion fails https://review.opendev.org/c/openstack/glance/+/923624 | 14:43 |
| abhishekk | Need to write new test class for image conversion with multiple stores as old one is for single store where everything is mocked | 14:50 |
| dansmith | ack, | 14:51 |
| dansmith | it's running the code inside the if, so I'm less concerned about missing that coverage | 14:51 |
| dansmith | I think the remove case should be covered though :) | 14:51 |
| abhishekk | I will create a dependency patch with new test | 14:52 |
| dansmith | ack | 14:52 |
| dansmith | this patch tests correctly in my system with good/bad images, so thanks! | 14:52 |
| abhishekk | cool, thank you for verification!! | 14:52 |
| croelandt | abhishekk: https://review.opendev.org/c/openstack/glance/+/923624 I'm confused, did you give up on dansmith's comments? | 14:53 |
| abhishekk | yeah, I will push a followup patch with new test | 14:54 |
| abhishekk | just read few lines above, we were discussing the same thing | 14:54 |
| croelandt | oh ok sorry :) | 14:55 |
| dansmith | abhishekk: https://review.opendev.org/c/openstack/tempest/+/925490 | 14:55 |
| dansmith | abhishekk: that confirms that qcow-with-datafile is rejected by glance, and the other vmdk things we added before | 14:56 |
| dansmith | and when glance moves to the oslo thing, we can remove the "with footer" limitation for that bug that was filed recently | 14:56 |
| abhishekk | croelandt: no problem :D | 14:59 |
| abhishekk | dansmith: ++ | 14:59 |
| opendevreview | Merged openstack/glance master: Auto-detect qemu-img qed support for unit tests https://review.opendev.org/c/openstack/glance/+/925466 | 15:03 |
| dansmith | abhishekk: so we can approve the revert-to-queued patch and you will, on your honor, follow up with another quick test patch is that right? | 15:16 |
| abhishekk | yes | 15:16 |
| abhishekk | I will do it tomorrow on priority | 15:16 |
| dansmith | croelandt: I just +2d | 15:17 |
| * abhishekk it's late today so tomorrow | 15:19 | |
| dansmith | ack | 15:19 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Revert image state to queued if conversion fails https://review.opendev.org/c/openstack/glance/+/923624 | 16:36 |
| abhishek_ | dansmith, croelandt ^^ | 16:36 |
| * dansmith wonders if it is tomorrow already | 16:37 | |
| abhishek_ | :) | 16:38 |
| * abhishek_ reminded that tomorrow I have some urgent tasks to take care | 16:39 | |
| dansmith | didn't have to be tomorrow, just had to not be forgotten, but thanks :) | 16:40 |
| abhishek_ | it could have been forgot :D | 16:42 |
| opendevreview | Merged openstack/glance master: Deprecate the "metadata_encryption_key" option https://review.opendev.org/c/openstack/glance/+/923197 | 17:42 |
| abhishek_ | 2024-08-01 17:44:37.606727 | controller | Details: (ImagesFormatTest:test_accept_reject_formats_import) Image 60856d21-2dbb-4054-b45d-6a797a907aa8 failed to reach queued state (current state active) within the required time (300 s). | 17:49 |
| abhishek_ | dansmith ^^ In logs I can see image becomes active so technically not possible to be set back to queued | 17:57 |
| abhishek_ | https://zuul.opendev.org/t/openstack/build/a2e36d3be2af4262879b5e71037ac775 | 17:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!