Thursday, 2023-08-10

pdeoreabhishekk, rosmaita, dansmith, croelandt, mrjoshi glance weekly meeting in 10 minutes at #openstack-meeting13:49
abhishekkthanks13:52
dansmithabhishekk: read these comments: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/imagebackend.py#L1182-L119114:24
abhishekkack14:25
dansmithI think that means as long as the fsid is the same, they don't have to be in the same pool14:25
dansmithI don't have a local ceph devstack up at the moment, but I can try to poke around with it later14:25
abhishekkcool, that will not be difficult to test it locally then14:26
abhishekkscenario will be, create image, boot an instance from it and then snapshot it using nova image-create (for time being in add_location I can change it to use new API call like cinder POC)14:27
dansmithyeah14:27
dansmithabhishekk: https://review.opendev.org/c/openstack/nova/+/89103614:28
abhishekkthanks for the clarification14:28
abhishekkperfect14:28
abhishekkdansmith, Instance is going in error state and log says,15:19
abhishekkImage 41c7c20d-6424-43ba-9f16-a3eaca1bd42d copied to rbd store robust15:20
abhishekkImage locations are: []15:20
abhishekkInstance failed to spawn: nova.exception.ImageUnacceptable: Image 41c7c20d-6424-43ba-9f16-a3eaca1bd42d is unacceptable: No image locations are accessible15:20
dansmithabhishekk: locally? with current code or with the new glance stuff?15:21
abhishekklocally, with new glance code, but it does not matter because new code is not invoked on instance creation, 15:22
abhishekkbecause I haven't changed anything in nova yet15:22
abhishekkImage 41c7c20d-6424-43ba-9f16-a3eaca1bd42d is not on my ceph and [workarounds]/never_download_image_if_on_rbd=True; refusing to fetch and upload.: nova.exception.ImageUnacceptable: Image 41c7c20d-6424-43ba-9f16-a3eaca1bd42d is unacceptable: No image locations are accessible15:22
dansmithdo you have all the show locations things turned on?15:22
abhishekkoops15:23
dansmiththis definitely works locally for me15:23
abhishekkyou got me15:23
abhishekkdansmith, I am getting not found exception here while creating the snapshot16:07
abhishekkhttps://github.com/openstack/glance_store/blob/master/glance_store/_drivers/rbd.py#L42216:07
abhishekklooks like it fails to read image rbd.ImageNotFound: [errno 2] RBD image not found (error opening image b'948d7037-d710-4d11-8919-8d07b4abf299' at snapshot b'snap')16:08
abhishekkfrom 'images' pool16:08
dansmithabhishekk: is that when it adds the location in glance and glance can't find it?16:09
abhishekkyeah16:09
abhishekkThe call comes to new location api, and when glance tries to find it, it fails16:10
abhishekkI will revert the changes and see it is working with old loaction add workflow 16:11
dansmithit comes to the new one?16:11
abhishekkyes16:11
dansmithhttps://zuul.opendev.org/t/openstack/build/4884721dbf764b33995d71c990f65dfe/log/controller/logs/screen-n-cpu.txt#1609616:11
dansmithit clearly works in the existing stuff16:11
abhishekkack16:12
abhishekkstill, I will verify if something is wrong in my local environment or not16:13
dansmithwhy is this hitting the new API if glanceclient isn't doing the new..or..old logic?16:13
abhishekkI am directly calling the new api from nova16:14
dansmithoh okay16:15
abhishekkworking with old16:15
dansmiththis is why we should test the new code with the client services before we merge :D16:15
abhishekkI think I got the problem here16:15
abhishekkif we remove this line here, https://review.opendev.org/c/openstack/glance/+/886749/14/glance/async_/flows/location_import.py#213 it will work16:16
dansmithum, really?16:20
abhishekki think so,not sure16:21
abhishekknope16:24
abhishekkwith old API it fetches size https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/rbd.py#L422 correctly16:35
abhishekkbut for new API it raises not found error at same line :D16:35
* abhishekk signing out for the day17:56

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!