| jokke_ | croelandt: around? | 12:07 |
|---|---|---|
| croelandt | jokke_: yeah | 12:25 |
| croelandt | quickly though, I got a meeting soon :) | 12:25 |
| croelandt | jokke_: ok following your comment, look at Launchpad :) | 12:27 |
| croelandt | and I answered on gerrit as well | 12:29 |
| jokke_ | croelandt: So there is a point of not running sdist install (which the skipsdist=True) does. The real question/issue is why in eart are we importing parts of the code when we're supposed to just build docs and if the autodoc is really necessary, then the right thing to do is to include the correct requirements.txt | 12:32 |
| croelandt | jokke_: so I'm not sure why we had skipsdist=True in the first place | 12:33 |
| croelandt | we could also include requirements.txt in addition to doc/requirements.txt | 12:33 |
| croelandt | rosmaita fixed the same issue in Cinder | 12:34 |
| croelandt | so I was thinking this could be discussed in the upstream meeting | 12:34 |
| croelandt | jokke_: also we have 2 different bugs blocking the client CI, so we need to merge A to be able to merge B, but we need to merge B to be able to merge A | 12:38 |
| croelandt | and I'm not sure how we usually solve this | 12:38 |
| jokke_ | croelandt: it avoids us to build sdist via setup.py which is totally unnecessary step on running tests. Thus we use the -r on deps to point out what dependencies are required for each test venv | 12:39 |
| croelandt | jokke_: can you run "tox -redocs" with tox 3.x? | 12:40 |
| croelandt | on my machine I get a "develop" installation | 12:40 |
| croelandt | https://paste.opendev.org/show/bNF17iclvCeFpSR9N7ZB/ | 12:41 |
| croelandt | ^ 3.8 | 12:41 |
| croelandt | https://paste.opendev.org/show/bdZ1djftwklIvh74vAWh/ | 12:41 |
| croelandt | ^ 4.0 | 12:41 |
| jokke_ | yes, the [testenv] usedevelop=True inheritance get devel install on all the test venvs, that's exactly the combination allowing us to avoid building source distribution packages for each run | 12:43 |
| croelandt | yeah somehow that stuff is broken in tox 4 | 12:44 |
| jokke_ | or it's finally working correctly | 12:46 |
| croelandt | well | 12:47 |
| croelandt | look at the pastes above | 12:47 |
| croelandt | tell me which behaviour seems right | 12:47 |
| jokke_ | Looks like the 4.0 works right, it installs just the requirements passed to it and runs he tests, 3.8 seems to be installing loads of extra stuff and yet still skipping the tests ;) | 12:50 |
| croelandt | I'm fine with just adding -r | 12:51 |
| croelandt | tox is voodoo stuff anyway :) | 12:51 |
| jokke_ | haha ;) | 12:51 |
| croelandt | now on to the bigger problem: how do we solve circulare dependencies? | 12:52 |
| jokke_ | which is? | 12:52 |
| croelandt | Two blockers for the glanceclient CI | 12:52 |
| croelandt | Cannot merge any of them without also merging the other one | 12:52 |
| croelandt | second patch being https://review.opendev.org/c/openstack/python-glanceclient/+/867932 | 12:52 |
| jokke_ | how did we get the gate to that state? Like how the fuck interpreter _AND_ tox versions were bumped without running the tests and seeing what it happens to break this time | 12:54 |
| croelandt | I donno | 12:55 |
| croelandt | feels like there should have been a huge call "hey, testing py310" | 12:55 |
| croelandt | mayeb there was | 12:55 |
| croelandt | but anyway, here we are | 12:55 |
| jokke_ | well those two are pretty easy to smash into one patch | 12:59 |
| croelandt | So you'd +2 two changes squashed into one another? :) | 13:01 |
| croelandt | Damn that's dirty | 13:01 |
| jokke_ | Nothing overapping, both needed and test only, heck I ninja it in too | 13:02 |
| croelandt | hahah | 13:02 |
| jokke_ | but first I go for some soup, brb :D | 13:03 |
| opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: Fix functional tests and docs generation https://review.opendev.org/c/openstack/python-glanceclient/+/869868 | 13:10 |
| croelandt | jokke_: https://review.opendev.org/c/openstack/python-glanceclient/+/869868/ | 13:11 |
| croelandt | I squashed everything in this patch | 13:11 |
| jokke_ | croelandt: thnx, waiting for zuul | 13:43 |
| abhishekk | rosmaita, jokke_, dansmith, croelandt, mrjoshi__, weekly meeting in 10 mins at #openstack-meeting | 13:49 |
| rosmaita | abhishekk: ty | 13:56 |
| abhishekk | np! | 13:56 |
| opendevreview | Merged openstack/python-glanceclient master: Fix functional tests and docs generation https://review.opendev.org/c/openstack/python-glanceclient/+/869868 | 17:21 |
| opendevreview | Merged openstack/python-glanceclient master: Boolean options: use strict checking https://review.opendev.org/c/openstack/python-glanceclient/+/858785 | 22:39 |
| opendevreview | Merged openstack/python-glanceclient master: Remove unicode-related Python2-only code https://review.opendev.org/c/openstack/python-glanceclient/+/857462 | 22:39 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!