Monday, 2022-11-07

gesGood day! We seem to be hitting this issue: https://bugs.launchpad.net/glance/+bug/1983279 where the format_inspector doesn't want to "streamOptimized" VMDK. What would you all think about processing the streamOptimized VMDKs in the same way we handle the monolithicSparse variant? I ran a quick test with some images and it seems to agree with the size calculated by qemu-img.13:40
gesdoesn't want to handle*13:41
rosmaitages: i'm not sure why we support monolithicSparse format only ... your suggestion makes sense, maybe put it on the agenda for the next glance meeting?13:55
rosmaitages: https://etherpad.opendev.org/p/glance-team-meeting-agenda13:58
rosmaitages:  make sure you mention that streamOptimized is a monolithic format (at least i think it is ... docs say "These disks are currently used only in the monolithic form")14:02
rosmaitaalso, make sure the docs i'm talking about are current:  https://www.vmware.com/app/vmdk/?src=vmdk14:03
gesrosmaita: I read the same doc, and I think the same. I don't understand why we care about getting the variant from the descriptor for getting the virtual size. The virtual size seems to be one of the first things we can read from the VMDK file.15:44
rosmaitages: i think the key issue is that the file needs to be monolithic so that each file is stand-alone15:45
gesrosmaita: I think we could add a check there, since we  have acces to the "descriptor", we could ensure the VMDK consists of only one extend. I am not very familiar with of VMDK works in OpenStack, but I imagine it's not really possible to use a non-monolithic VMDK for example in Nova.15:50
rosmaitages: that sounds about right, but the issue for Glance is that we don't want a user to upload an unusable image15:51
gesrosmaita: yeah, that would be strange. I added the item to the agenda for Thursday meeting, I think I could also quickly come-up with a patche that accepts streamOptimized and ensure we are working on a monolithic image.15:55
rosmaitages: that sounds good15:55
*** sfinucan is now known as stephenfin16:10
opendevreviewBrian Rosmaita proposed openstack/glance stable/yoga: [stable-only] Remove glance-code-constants-check  https://review.opendev.org/c/openstack/glance/+/86362218:06
opendevreviewDan Smith proposed openstack/glance master: DNM: Test cinder target devstack change  https://review.opendev.org/c/openstack/glance/+/86392619:20
opendevreviewBrian Rosmaita proposed openstack/glance stable/xena: [stable-only] Remove glance-code-constants-check  https://review.opendev.org/c/openstack/glance/+/86394321:55
opendevreviewBrian Rosmaita proposed openstack/glance stable/wallaby: [stable-only] Remove glance-code-constants-check  https://review.opendev.org/c/openstack/glance/+/86394422:06
opendevreviewBrian Rosmaita proposed openstack/glance stable/victoria: [stable-only] Remove glance-code-constants-check  https://review.opendev.org/c/openstack/glance/+/86394522:09
opendevreviewBrian Rosmaita proposed openstack/glance stable/ussuri: [stable-only] Remove glance-code-constants-check  https://review.opendev.org/c/openstack/glance/+/86394622:12
opendevreviewMerged openstack/glance stable/yoga: [stable-only] Remove glance-code-constants-check  https://review.opendev.org/c/openstack/glance/+/86362222:13
opendevreviewBrian Rosmaita proposed openstack/glance stable/train: [stable-only] Remove glance-code-constants-check  https://review.opendev.org/c/openstack/glance/+/86394722:15
opendevreviewCyril Roelandt proposed openstack/python-glanceclient master: Unhardcode the value of DEFAULT_PAGE_SIZE from the tests  https://review.opendev.org/c/openstack/python-glanceclient/+/82448023:06

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!