| opendevreview | OpenStack Proposal Bot proposed openstack/glance_store master: Imported Translations from Zanata https://review.opendev.org/c/openstack/glance_store/+/853898 | 03:07 |
|---|---|---|
| *** tkajinam|off is now known as tkajinam | 05:48 | |
| opendevreview | Merged openstack/glance_store master: Tests: Mock sleep in cinder test_attachment_create_retries https://review.opendev.org/c/openstack/glance_store/+/854000 | 07:20 |
| opendevreview | Arnaud Morin proposed openstack/glance-specs master: Add option region_name to s3 store https://review.opendev.org/c/openstack/glance-specs/+/854112 | 07:20 |
| opendevreview | Merged openstack/glance-specs master: Add Antelope directory for specs https://review.opendev.org/c/openstack/glance-specs/+/853477 | 07:38 |
| abhishekk | dansmith, if you have time can you take over remaining work of glance-download, unfortunately I have some urgent internal work to attend this week | 12:47 |
| abhishekk | otherwise we can postponed it to next cycle (in worst case) | 12:48 |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test glance-download with tempest https://review.opendev.org/c/openstack/glance/+/852609 | 13:46 |
| mrjoshi__ | rosmaita, dansmith , jokke_ Hi, could you please take a look at https://review.opendev.org/c/openstack/glance/+/842045 | 13:55 |
| rosmaita | mrjoshi__: ack | 13:56 |
| dansmith | mrjoshi__: we should probably let rosmaita or jokke_ +W that because they had comments earlier | 13:56 |
| dansmith | unless the can't get to it | 13:56 |
| rosmaita | mrjoshi__: left a question on the patch ... dansmith, could use your opinion, maybe i am being unreasonable | 14:04 |
| dansmith | well, I think I'm missing context or something | 14:06 |
| dansmith | I don't see the problem with saying "the api exposes bytes, even though the deployer can only configure in MiB chunks" | 14:07 |
| rosmaita | ok, in that case, then i don't think we should identify the values with the actual config name | 14:08 |
| dansmith | like, df shows you total bytes on your disk, but you can only add to that in chunks of 512 or 4096 bytes :) | 14:08 |
| mrjoshi__ | I need to change the parameter names back to as they were previously named? | 14:13 |
| rosmaita | see what abhishekk thinks, but i'd prefer doing what we have for rbd instead of using the config option names (so yeah, drop the 'swift_store' prefix | 14:15 |
| rosmaita | but use 'large_object_size' and 'large_object_chunk_size' | 14:16 |
| dansmith | rosmaita: meaning use the computed values but call them something other than the exact config option name to avoid people thinking they should be the same? | 14:17 |
| rosmaita | exactamundo | 14:17 |
| dansmith | that makes sense to me | 14:17 |
| dansmith | mrjoshi__: I also noted something in your api response example | 14:17 |
| mrjoshi__ | dansmith, ack, will correct that | 14:20 |
| mrjoshi__ | and for the parameter names of the swift_store I need to use large_object_size and large_object_chunk_size ,right? | 14:21 |
| rosmaita | that works for me | 14:22 |
| mrjoshi__ | ack | 14:22 |
| rosmaita | and apologies, because i requested you change them in the first place | 14:22 |
| rosmaita | also, might as well just use 'container' to keep everything consistent | 14:22 |
| opendevreview | Mridula Joshi proposed openstack/glance master: Extending stores-detail API https://review.opendev.org/c/openstack/glance/+/842045 | 14:43 |
| mrjoshi__ | dansmith, rosmaita: made all corrections please have a look, and if there's any suggestion please let me know :) | 14:47 |
| dansmith | mrjoshi__: will wait for rosmaita | 14:48 |
| rosmaita | mrjoshi__: dansmith: LGTM | 15:03 |
| dansmith | rosmaita: mrjoshi__: sent | 15:04 |
| mrjoshi__ | dansmith, rosmaita thanks! | 15:04 |
| opendevreview | Dan Smith proposed openstack/glance master: Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 15:27 |
| opendevreview | Dan Smith proposed openstack/glance master: Add documentation for glance-download plugin https://review.opendev.org/c/openstack/glance/+/853928 | 15:27 |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test glance-download with tempest https://review.opendev.org/c/openstack/glance/+/852609 | 15:27 |
| abhishekk | thank you! | 15:29 |
| dansmith | abhishekk: I don't have a lot of time to spend on this either, but I think it's probably close, so will give it a shot | 15:29 |
| abhishekk | dansmith, yeah, lets hope this will get merged, will try to find out some time if required as well | 15:30 |
| opendevreview | Merged openstack/glance master: Add support to get glance endpoint https://review.opendev.org/c/openstack/glance/+/853927 | 20:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!