| *** tosky is now known as Guest71 | 10:46 | |
| *** tosky_ is now known as tosky | 10:46 | |
| *** bhagyashris is now known as bhagyashris|afk | 11:44 | |
| *** tosky is now known as Guest77 | 12:01 | |
| *** tosky__ is now known as tosky | 12:01 | |
| *** tosky is now known as Guest78 | 12:30 | |
| *** tosky_ is now known as tosky | 12:30 | |
| *** bhagyashris|afk is now known as bhagyashris | 12:50 | |
| *** tosky is now known as Guest85 | 13:13 | |
| *** tosky__ is now known as tosky | 13:13 | |
| opendevreview | Cyril Roelandt proposed openstack/glance_store master: Add chunk download support for rbd backend https://review.opendev.org/c/openstack/glance_store/+/763114 | 13:52 |
|---|---|---|
| opendevreview | Rajat Dhasmana proposed openstack/glance stable/yoga: Fix tests for logging connection info https://review.opendev.org/c/openstack/glance/+/852504 | 14:21 |
| opendevreview | Rajat Dhasmana proposed openstack/glance stable/yoga: Mock getaddrinfo in cinder store tests https://review.opendev.org/c/openstack/glance/+/852505 | 14:21 |
| dansmith | alistarl1: around by chance? | 14:56 |
| *** sfinucan is now known as stephenfin | 15:16 | |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test glance-download https://review.opendev.org/c/openstack/glance/+/852609 | 16:47 |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test glance-download with tempest https://review.opendev.org/c/openstack/glance/+/852609 | 16:50 |
| dansmith | abhishekk: ^ | 16:50 |
| abhishekk | dansmith, ack, just going through your comments on the patch | 16:51 |
| abhishekk | thank you for tempest woek | 16:51 |
| dansmith | tbh, I'm not sure if we avoid a traceback on other errors, | 16:51 |
| dansmith | but since this is easy for a user to cause a failure, it opens the ability for them to spam the logs with a lot of error-level messages... | 16:52 |
| dansmith | but certainly we need to properly roll back in those cases, if nothing else | 16:52 |
| abhishekk | agree on roll back | 16:53 |
| dansmith | abhishekk: btw, there is a TODO from jokke_ in the get_import_plugin() method to handle missing plugins, | 17:23 |
| dansmith | and that is what I was hitting until I fixed the setup.cfg | 17:24 |
| abhishekk | looking | 17:24 |
| dansmith | the error is very confusing for someone not skilled in the art, so we should put something at the end there like: | 17:24 |
| dansmith | raise Exception('Plugin $name not found') | 17:24 |
| abhishekk | ++ | 17:25 |
| abhishekk | line 214 should be in try except block | 17:25 |
| abhishekk | will put a patch tomorrow | 17:26 |
| dansmith | it's actually that we fall through the for loop, | 17:33 |
| dansmith | so it needs to be "if we didn't find and return a plugin, raise something specific" | 17:34 |
| dansmith | else we return None, which fails to add to the flow with an obscure message | 17:34 |
| abhishekk | Ack | 17:35 |
| croelandt | abhishekk: dansmith: I guess we'll do 2pm UTC on Thursday instead of the upstream meeting | 18:14 |
| croelandt | I'll send an invite | 18:14 |
| abhishekk | croelandt, ack | 18:14 |
| dansmith | ack, thursdays are busy for me and there are some other things flying around that could have me pulled away at the last minute, but I'll surely *plan* to be there | 18:14 |
| croelandt | yeah I forgot Friday was recharge day :/ | 18:15 |
| dansmith | oh, heh right | 18:17 |
| opendevreview | Cyril Roelandt proposed openstack/glance_store master: [Swift] Bulk delete chunks from container https://review.opendev.org/c/openstack/glance_store/+/793978 | 18:17 |
| dansmith | I'll be gone anyway | 18:17 |
| dansmith | forgot that was so close | 18:17 |
| dansmith | I guess rosmaita is planning to be here | 18:18 |
| dansmith | already charged up I guess | 18:18 |
| rosmaita | i was planning for friday, thursday is not so good for me | 18:18 |
| dansmith | rosmaita: not recharging on friday? | 18:19 |
| rosmaita | well, i am *now* | 18:19 |
| dansmith | heh | 18:19 |
| rosmaita | i forgot all about it, too | 18:19 |
| croelandt | hehe | 18:21 |
| croelandt | Thanks abhishekk for reminding everyone | 18:21 |
| abhishekk | o/ | 18:21 |
| *** lifeless_ is now known as lifeless | 18:24 | |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test glance-download with tempest https://review.opendev.org/c/openstack/glance/+/852609 | 18:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!