| *** abhishekk is now known as akekane|home | 04:52 | |
| *** akekane|home is now known as abhishekk | 04:52 | |
| opendevreview | Pranali Deore proposed openstack/glance master: Remove dead code of auth and policy layers https://review.opendev.org/c/openstack/glance/+/845114 | 07:01 |
|---|---|---|
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 07:51 |
| opendevreview | Benedikt Löffler proposed openstack/python-glanceclient master: Check if stdin has isatty attribute https://review.opendev.org/c/openstack/python-glanceclient/+/813802 | 08:57 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: [WIP] Immediate caching of an image https://review.opendev.org/c/openstack/glance/+/842070 | 09:06 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: [WIP] Immediate caching of an image https://review.opendev.org/c/openstack/glance/+/842070 | 09:09 |
| opendevreview | chenwei proposed openstack/glance master: Update api-ref: versions response for master branch https://review.opendev.org/c/openstack/glance/+/845578 | 10:36 |
| opendevreview | Pranali Deore proposed openstack/glance master: Remove dead code of auth and policy layers https://review.opendev.org/c/openstack/glance/+/845114 | 11:10 |
| dansmith | abhishekk: did your comment mean you tested the cache patch locally and it works? | 14:04 |
| abhishekk | dansmith, yes, I have tried 3-4 scenarios and it is working, I just had to make some changes which you can find in diff | 14:05 |
| abhishekk | some == 3/4 changes | 14:05 |
| dansmith | yeah, I saw, sorry about that | 14:06 |
| dansmith | I didn't even run pep8 on it, was just trying to give some ideas | 14:06 |
| dansmith | looking at the functional test now | 14:07 |
| abhishekk | no problem, i saw your comment as well and that's why decided to test it :D | 14:08 |
| abhishekk | need to write better comments in functional test | 14:09 |
| dansmith | are you working on unit tests as well? | 14:14 |
| abhishekk | I can work | 14:14 |
| abhishekk | right now just fixed functional tests, later (mostly tomorrow) will fix unit tests and then add new tests | 14:15 |
| abhishekk | then will move to tempest patch | 14:15 |
| dansmith | okay, I can take a look at the unit tests | 14:19 |
| abhishekk | ack, thank you | 14:20 |
| * abhishekk will be away for 1 hour | 14:30 | |
| dansmith | abhishekk: I'm not sure why we need this: | 17:31 |
| dansmith | # NOTE(abhishekk): Importing the prefetcher just in time to avoid import loop during initialization | 17:31 |
| abhishekk | if you move it to top then we get error at service startup | 17:32 |
| abhishekk | like, wsgi has not attribute JSONRequestDeserializer | 17:33 |
| dansmith | I don't... | 17:43 |
| dansmith | when running tests or starting with devstack? | 17:43 |
| dansmith | all unit and functional run for me with it at the top | 17:47 |
| dansmith | anyway not important, just wasn't sure | 17:48 |
| opendevreview | Dan Smith proposed openstack/glance master: [WIP] Immediate caching of an image https://review.opendev.org/c/openstack/glance/+/842070 | 17:48 |
| dansmith | abhishekk: I'll let you take the WIP off that when you're ready | 17:49 |
| abhishekk | dansmith, ack, I will try to reproduce it again | 17:50 |
| abhishekk | it was while starting with devstack | 17:51 |
| abhishekk | and with uwsgi enabled | 17:51 |
| dansmith | abhishekk: okay, might be good to just validate that it's still there.. no big deal if it is | 18:06 |
| *** maysams is now known as maysams-afk | 18:06 | |
| abhishekk | ack | 18:07 |
| abhishekk | dansmith, have you tried restarting g-api service after caching image locally? | 18:17 |
| dansmith | abhishekk: I haven't actually run this in devstack yet :D | 18:17 |
| dansmith | so...no? :P | 18:17 |
| abhishekk | ohh, I just tried and looks like it hangs their waiting for graceful exit | 18:18 |
| abhishekk | this error I was getting on startup on PS 3, https://paste.opendev.org/show/bSuBS6VfhpbMM3cFLaKH/ | 18:20 |
| dansmith | abhishekk: okay do you see the info logs for "Signaling cache worker to exit" ? | 18:21 |
| abhishekk | just applied the latest PS | 18:22 |
| abhishekk | will check | 18:22 |
| abhishekk | nope | 18:22 |
| dansmith | oh, | 18:23 |
| dansmith | running uwsgi? | 18:23 |
| dansmith | I made a change in the latest PS for the non-standalone case | 18:23 |
| abhishekk | yeah | 18:24 |
| dansmith | we didn't signal it before, so because it's not a daemon thread, we'll hang until it exists | 18:25 |
| simboja_ | Hello, guys. I am hitting this and hopefully someone can help me out: https://paste.opendev.org/show/bTLo8hU4mBiTWDI7iB6W/ | 18:26 |
| abhishekk | ack | 18:26 |
| abhishekk | simboja_, looks like some sqlite dependency related issue | 18:27 |
| dansmith | simboja_: give us some context.. that's related to a new thing in devstack, and if it's failing like that it probably means you updated one thing and not another | 18:27 |
| simboja_ | Nothing I know of, I deployed fresh devstack | 18:28 |
| dansmith | devstack installs that plugin and configures the services to use it, and it looks like it's not actually installed | 18:28 |
| simboja_ | Excatly whihc I don't know why | 18:28 |
| dansmith | simboja_: pastebin your local.conf | 18:28 |
| simboja_ | a sec | 18:28 |
| simboja_ | https://paste.opendev.org/show/bQV2mFmDaUX6LHepkX1W/ | 18:29 |
| dansmith | simboja_: can you share your devstack.log? | 18:30 |
| dansmith | simboja_: we might also move to -qa since this is not glance related | 18:30 |
| simboja_ | one moment | 18:30 |
| simboja_ | https://paste.opendev.org/show/bMZtlydHoutvC3gCANDW/ | 18:31 |
| dansmith | simboja_: I need to see the whole thing not just where it failed | 18:31 |
| dansmith | because it installs that plugin almost first thing | 18:31 |
| abhishekk | looks like this is not called, https://review.opendev.org/c/openstack/glance/+/842070/6/glance/common/wsgi_app.py#98 | 18:31 |
| simboja_ | let me get the entire log | 18:33 |
| dansmith | abhishekk: hmm, can you add some debug there to figure out why? | 18:33 |
| abhishekk | yeah, doing it | 18:33 |
| abhishekk | atexit function drain_workers is not getting called on exit/restart | 18:43 |
| dansmith | abhishekk: oh, well, that's a bigger problem then | 18:44 |
| abhishekk | yeah | 18:44 |
| dansmith | I wonder if atexit under uwsgi doesn't work like we expect | 18:44 |
| abhishekk | https://github.com/unbit/uwsgi/issues/2063 | 18:44 |
| simboja_ | dansmith: I can not pastebin, how do I send you the log file as its above limit on pastebin? | 18:48 |
| abhishekk | after changing atexit.register(drain_workers) to uwsgi.atexit = drain_workers it is exiting gracefully | 18:48 |
| dansmith | simboja_: post it somewhere, dropbox link or something? | 18:49 |
| simboja_ | cool | 18:49 |
| dansmith | abhishekk: is that in python or the uwsgi conf somewhere? | 18:49 |
| dansmith | oh I see | 18:50 |
| abhishekk | https://paste.opendev.org/show/bQm6G2G32ou0OFrvXgWu/ | 18:51 |
| abhishekk | in python code | 18:51 |
| simboja_ | dansmith: https://docs.google.com/document/d/1pEn_XxF-HFbXoecnX7MB_QacCn7q00ITghnFK3GRVk0/edit?usp=sharing | 18:56 |
| abhishekk | tomorrow I will configure wsgi and test as well, once verified will add documentation change/reno and lift WIP from it | 18:56 |
| dansmith | abhishekk: cool | 18:57 |
| dansmith | simboja_: blank doc? can you just share the file via google drive? | 18:57 |
| simboja_ | One moment, dont know why Google doc is failing to sync | 18:58 |
| simboja_ | Try now dansmith: https://drive.google.com/file/d/1BKyJKvHBBiB5ofp90ElDiPm_rfdGPRsp/view?usp=sharing | 19:01 |
| dansmith | simboja_: which distro is this? | 19:03 |
| dansmith | just FYI MYSQL_GATHER_PERFORMANCE=False will work around this, but I want to know why it's failing for you | 19:05 |
| dansmith | if you can try this: | 19:05 |
| dansmith | python3 | 19:05 |
| dansmith | import dbcounter | 19:05 |
| dansmith | print(dbcounter.__file__) | 19:05 |
| dansmith | I'd be interested | 19:05 |
| abhishekk | dansmith, looks like graceful exit also not work with uwsgi | 19:06 |
| abhishekk | it terminates the thread immediately | 19:06 |
| abhishekk | !!! uWSGI process 231696 got Segmentation Fault !!! | 19:07 |
| opendevmeet | abhishekk: Error: "!!" is not a valid command. | 19:07 |
| abhishekk | Jun 13 19:02:12 akekane-rally devstack@g-api.service[231696]: *** backtrace of 231696 *** | 19:07 |
| dansmith | abhishekk: okay, well that thread (on github) also indicates there are some wrinkles :/ | 19:07 |
| abhishekk | hmm | 19:07 |
| dansmith | oh well, that seems like a bug.. it shouldn't segv | 19:07 |
| abhishekk | is there another method than terminate? | 19:08 |
| dansmith | other than atexit you mean | 19:09 |
| dansmith | ? | 19:10 |
| abhishekk | yeah | 19:10 |
| dansmith | it'll have to be something uwsgi-specific I imagine | 19:10 |
| dansmith | really the problem is running everything long-running in the same thread as the api.. that's just not done for a reason, and is why all the other services use RPC to workers... | 19:11 |
| abhishekk | yep, but this is glance :D | 19:12 |
| dansmith | hah | 19:12 |
| * abhishekk signing out for the day | 19:26 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!