| *** EugenMayer7 is now known as EugenMayer | 02:30 | |
| opendevreview | Merged openstack/glance master: [api-ref] update cache manage API info https://review.opendev.org/c/openstack/glance/+/840215 | 05:25 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Provision for immediate caching of an image https://review.opendev.org/c/openstack/glance-specs/+/838642 | 05:35 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: [APIImpact] Correct API response code for PUT /v2/cache/{image_id} https://review.opendev.org/c/openstack/glance/+/840409 | 05:51 |
| abhishekk | rosmaita, ^^ | 05:52 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 06:52 |
| opendevreview | Merged openstack/glance-specs master: Spec Lite: Add ability to purge all rows by glance-manage https://review.opendev.org/c/openstack/glance-specs/+/819622 | 07:30 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Provision for immediate caching of an image https://review.opendev.org/c/openstack/glance-specs/+/838642 | 07:34 |
| abhishekk | IDENTIFY | 07:37 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 07:48 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 08:04 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 08:56 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: [WIP] Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 08:57 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: [WIP] Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 09:27 |
| whoami-rajat | jokke_, dansmith hey, one query, where is this _do_add() method called from? https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L662 | 11:35 |
| opendevreview | mitya-eremeev-2 proposed openstack/glance master: glance-manage can purge all deleted rows https://review.opendev.org/c/openstack/glance/+/813691 | 12:21 |
| rosmaita | whoami-rajat: https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L611-L613 | 12:23 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 14:07 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: [WIP] Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 14:10 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 14:11 |
| opendevreview | mitya-eremeev-2 proposed openstack/glance master: glance-manage can purge all deleted rows https://review.opendev.org/c/openstack/glance/+/813691 | 14:56 |
| opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: utils.strip_version: properly handle all URLs https://review.opendev.org/c/openstack/python-glanceclient/+/831612 | 15:49 |
| whoami-rajat__ | rosmaita, thanks! | 16:37 |
| whoami-rajat__ | croelandt, hey, don't want to bother you again and again but can we have a decisive vote on this patch https://review.opendev.org/c/openstack/glance_store/+/833767 | 16:41 |
| croelandt | whoami-rajat__: you never bother me | 17:06 |
| croelandt | so I disagree with the implementation | 17:06 |
| croelandt | and the general idea of mocking library calls all the time | 17:06 |
| croelandt | and I think we should work with a more "black box" approach | 17:07 |
| croelandt | but it would also be silly to keep my -1 when everyone else agrees with the patch, so I'll merge it | 17:07 |
| croelandt | whoami-rajat__: done! | 17:08 |
| croelandt | let me check your other glance_store patches :) | 17:09 |
| whoami-rajat__ | croelandt, thanks, that could be a good discussion point but I'm skeptic about testing third party library functionalities and that would be extra efforts for testing on our side than the lib itself, but that's just my opinion | 17:23 |
| whoami-rajat__ | also it's about the precedent we follow to mock out third party libs, if that changes, I don't mind implementing tests in that way | 17:24 |
| *** whoami-rajat__ is now known as whoami-rajat | 17:25 | |
| croelandt | yeah the issue I see here | 17:27 |
| croelandt | is that if one day we change the implementation | 17:27 |
| croelandt | the tests are going to fail | 17:27 |
| croelandt | hence my "black box" approach | 17:28 |
| croelandt | but it's not a hill I'm willing to die on | 17:28 |
| croelandt | we have far bigger issues on OpenStack | 17:28 |
| whoami-rajat__ | agreed | 17:36 |
| croelandt | whoami-rajat__: https://bugs.launchpad.net/glance-store/+bug/1970698 what a bug :D | 17:40 |
| whoami-rajat__ | couldn't be more creative for an issue that's fixed with changing a closing bracket :D | 17:52 |
| whoami-rajat__ | ápr 07 08:44:34 devstack0 devstack@g-api.service[850369]: ERROR glance TypeError: f() takes 1 positional argument but 2 were given | 17:52 |
| whoami-rajat__ | this is the main issue | 17:52 |
| whoami-rajat__ | thanks for all the reviews croelandt ! much appreciated | 17:53 |
| croelandt | whoami-rajat__: there is a Glance review party tomorrow | 17:59 |
| croelandt | I'll add the couple of patches left that you wrote | 17:59 |
| croelandt | not sure if you want to join, there should not be many Cinder-related patches | 18:00 |
| opendevreview | Merged openstack/glance_store master: Add coverage for helper methods https://review.opendev.org/c/openstack/glance_store/+/833767 | 18:58 |
| opendevreview | Merged openstack/glance_store master: Add exception coverage for get, get_size, delete https://review.opendev.org/c/openstack/glance_store/+/833982 | 19:11 |
| opendevreview | Merged openstack/glance_store master: Add coverage for add method https://review.opendev.org/c/openstack/glance_store/+/834115 | 19:11 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 22:13 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!