| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add coverage for add method https://review.opendev.org/c/openstack/glance_store/+/834115 | 08:44 |
|---|---|---|
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add coverage for StoreLocation https://review.opendev.org/c/openstack/glance_store/+/833539 | 10:39 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add coverage for get_cinderclient and _check_context https://review.opendev.org/c/openstack/glance_store/+/833751 | 10:39 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add coverage for helper methods https://review.opendev.org/c/openstack/glance_store/+/833767 | 10:39 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add exception coverage for get, get_size, delete https://review.opendev.org/c/openstack/glance_store/+/833982 | 10:39 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add coverage for add method https://review.opendev.org/c/openstack/glance_store/+/834115 | 10:39 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Remove redundant try except around volume create https://review.opendev.org/c/openstack/glance_store/+/834155 | 11:21 |
| *** pdeore_ is now known as pdeore | 13:43 | |
| pdeore | abhishekk, rosmaita, jokke_, dansmith, croelandt, mrjoshi_ glance weekly meeting in 10 minutes at #openstack-meeting | 13:51 |
| dansmith | and I'll be there due to DST \o/ | 13:51 |
| pdeore | great!! :D | 13:54 |
| *** tosky_ is now known as tosky | 14:27 | |
| dansmith | abhishekk: why have you not +2 this yet? still looking? | 14:52 |
| dansmith | https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802792/17..19/glance_tempest_plugin/tests/rbac/v2/metadefs/test_resource_types.py | 14:52 |
| abhishekk | dansmith, looking | 14:53 |
| dansmith | the changes to the lock and namespace naming look okay, but some fo the boolean logic in test_create_resource_type makes me worried that more changed since I reviewed last | 14:53 |
| abhishekk | line 157 you mean? | 14:55 |
| dansmith | and 179, etc | 14:55 |
| abhishekk | I ran those tests multiple times (25/30 times) in local environment couple of days back and didn't encounter any failure, but forget to mention that on patch | 14:56 |
| dansmith | I'm just not sure why they changed | 14:56 |
| dansmith | pdeore: ? | 14:56 |
| dansmith | abhishekk: but otherwise are you +2 on that? | 14:57 |
| abhishekk | I think we raise not found if we try to view namespace for other project | 14:57 |
| dansmith | ...right | 14:58 |
| dansmith | wonder if it is related to L49 change? | 14:58 |
| abhishekk | right, | 14:59 |
| abhishekk | I found this gerrit version really confusing as it shows all the comments in recent patch :/ | 15:00 |
| abhishekk | will confirm this with pdeore, logically line no 49 sounds like the reason for changing the boolean check | 15:04 |
| dansmith | ack sorry in tc meeting | 15:18 |
| dansmith | but yeah, I assume that's it | 15:18 |
| dansmith | and yes, I hate the new gerrit's persistent comment thing :/ | 15:18 |
| dansmith | you have to mark them as resolved to make them go away | 15:18 |
| abhishekk | yeah | 15:20 |
| dansmith | abhishekk: can we officially adopt something similar in glance? https://docs.openstack.org/cinder/latest/contributor/gerrit.html#ci-job-rechecks | 15:28 |
| dansmith | we're talking about it in -tc right now and you know my opinion on the topic :) | 15:28 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!