| opendevreview | Takashi Kajinami proposed openstack/glance master: Deploy healthcheck middleware as app instead of filter https://review.opendev.org/c/openstack/glance/+/802148 | 01:08 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/glance master: Refactor pipeline definition https://review.opendev.org/c/openstack/glance/+/802180 | 01:08 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: [WIP] Modify glance db constant check logic https://review.opendev.org/c/openstack/glance/+/827587 | 05:13 |
| opendevreview | Merged openstack/glance master: Remove six.moves.range usage https://review.opendev.org/c/openstack/glance/+/822735 | 08:22 |
| opendevreview | Merged openstack/glance master: Remove six.moves.http_client usage https://review.opendev.org/c/openstack/glance/+/822736 | 09:12 |
| abhishekk | jokke_, rosmaita, dansmith, croelandt glance weekly meeting at #openstack-meeting in 10 minutes | 13:49 |
| rosmaita | abhishekk: ty | 13:49 |
| abhishekk | np o/ | 13:49 |
| * abhishekk going afk for 1 hour | 14:37 | |
| ade_lee | dansmith, amo/join #openstack-horizon | 16:07 |
| ade_lee | oops | 16:07 |
| ade_lee | dansmith, abhishekk hey - will update fips patch once we have agreement on modifying existing job vs. adding new jobs | 16:09 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Cinder store: Wait for device resize https://review.opendev.org/c/openstack/glance_store/+/826290 | 16:09 |
| ade_lee | dansmith, abhishekk and if we agree to modify existing jobs, do we want to rename to add -fips to emphasize their fipsiness? | 16:11 |
| dansmith | abhishekk: sure | 16:11 |
| dansmith | (sure rename I mean) | 16:11 |
| abhishekk | ade_lee, ack, if we doesn't get conclusion till then, please join our weekly meeting next Thursday at 1400 UTC | 16:11 |
| whoami-rajat__ | abhishekk, rosmaita (and other cores): hey, can you take a look at this patch? https://review.opendev.org/c/openstack/glance_store/+/826290 | 16:12 |
| ade_lee | abhishekk, well, I'm hoping we can reach agreement now :) | 16:12 |
| abhishekk | whoami-rajat__, ack | 16:12 |
| whoami-rajat__ | thanks | 16:12 |
| *** whoami-rajat__ is now known as whoami-rajat | 16:12 | |
| abhishekk | ade_lee, so you will change py-36 job name to py36-fips right? | 16:13 |
| dansmith | abhishekk: I think we can resolve now, I think we just want confirmation of what your comment meant | 16:16 |
| ade_lee | abhishekk, so if I understand what is being proposed -- I would modify the tempest-integrated-storage-import and glance-multistore-cinder-import jobs to be fips enabled and change their names to foo-fips | 16:16 |
| dansmith | that's my preference | 16:16 |
| ade_lee | also, presumably tha same thing with the openstack-tox-functional-py36 job, convert it to be fips enabled, and modify name | 16:17 |
| abhishekk | yeah, right | 16:17 |
| dansmith | yep | 16:17 |
| abhishekk | but I am talking about functional job here, we will have one as openstack-tox-functional-py36-fips and other as openstack-tox-functional-py37, openstack-tox-functional-py38 or openstack-tox-functional-py39 | 16:17 |
| abhishekk | will that be confusing to others? | 16:18 |
| dansmith | I think it's fine to just have one functional fips job, and the py36 is the obvious one because centos | 16:18 |
| dansmith | so just slap -fips on the end of that job, IMHO | 16:18 |
| abhishekk | ok, sounds good | 16:18 |
| dansmith | I have to step away for a sec | 16:19 |
| abhishekk | ack | 16:19 |
| ade_lee | cool thanks -- I'll make the required changes | 16:19 |
| abhishekk | yep, thank you | 16:21 |
| opendevreview | Ade Lee proposed openstack/glance master: Add fips check jobs https://review.opendev.org/c/openstack/glance/+/790536 | 16:22 |
| dansmith | abhishekk: did you see my patch on top of your test patch to configure the worker timer? | 16:25 |
| abhishekk | dansmith, yes, I commented on the patch as well | 16:25 |
| dansmith | abhishekk: I meant this: https://review.opendev.org/c/openstack/glance/+/827538 | 16:25 |
| dansmith | if you are cool with that I need to squash it into the one below | 16:25 |
| abhishekk | yeah, I saw it buut I guess I commented on different patch :/ | 16:26 |
| dansmith | I still want to talk to gmann about the tempest test waiting for the periodic, but with a short periodic that's better | 16:26 |
| dansmith | oh okay, so I should squash? | 16:26 |
| abhishekk | yes | 16:26 |
| abhishekk | looks better to me | 16:26 |
| dansmith | okay, I think we should s/DNM/WIP as well, assuming we'll get it in somehow | 16:27 |
| abhishekk | dansmith, also I guess we bump minor version for each new API or group of APIs addition | 16:27 |
| abhishekk | ++ | 16:28 |
| dansmith | abhishekk: okay this example seemed to stand alone: https://review.opendev.org/c/openstack/glance/+/775860 | 16:28 |
| dansmith | I don't really understand how the versioning in glance works anyway | 16:29 |
| abhishekk | yeah, because at that time it was skipped and we have added only one api,which as image task-show api | 16:29 |
| dansmith | the current stuff has logic to control what the current version is based on enabled_backends, but I guess that's just because the most recent one was only if multistore, so I can just make 2.13 for quotas the current version regardless? | 16:30 |
| dansmith | or do you want that to differ based on quota config? | 16:30 |
| abhishekk | 2.13 if yours gets merged first | 16:30 |
| abhishekk | or 2.14 if mine cache API stuff gets merged firts | 16:30 |
| dansmith | hmm | 16:33 |
| abhishekk | I have added comment in the morning,but forgot to submit that :D | 16:36 |
| ade_lee | dansmith, abhishekk just to confirm -- glance-multistore-cinder-import has tempest-integrated-storage-import as its parent, so I actually won't need to change it other than to make the parent the fips version, and add "fips" to the job name | 16:37 |
| dansmith | cool | 16:37 |
| ade_lee | dansmith, abhishekk the same is true for tempest-integrated-storage-import-standalone | 16:37 |
| abhishekk | so you will just change the names of those ? | 16:38 |
| ade_lee | yes, I just wanted to confirm that you guys are ok with all the tempest-integrated-storage-import and their descendent jobs only running in fips mode on centos | 16:39 |
| abhishekk | ack | 16:40 |
| ade_lee | ok cool | 16:40 |
| dansmith | oh, hang on, | 16:40 |
| ade_lee | :) | 16:40 |
| dansmith | let me look.. I was thinking that would just be the related ones | 16:40 |
| dansmith | ade_lee: you could just do glance-multistore-cinder-import and have all the same coverage without changing all the others right? | 16:41 |
| abhishekk | I think you still added new job defs? | 16:41 |
| dansmith | since that one inherits from the storage-import parent | 16:41 |
| ade_lee | dansmith, I think so -- thats for you to tell me :) | 16:42 |
| dansmith | ade_lee: yeah, abhishekk mentioned those two, the parent and a leaf, | 16:42 |
| dansmith | but I don't think there's any real need to do the parent | 16:42 |
| dansmith | the multistore-cinder one does pretty much all of the same stuff, and is a leaf, so I'd say just do that one only | 16:43 |
| dansmith | sorry i wasn't really paying attention to the hierarchy | 16:43 |
| abhishekk | the parent will use file store and multistore will have multiple stores | 16:43 |
| abhishekk | means file + cinder two stores | 16:43 |
| dansmith | abhishekk: right, so the cinder job covers everything yeah? | 16:44 |
| abhishekk | yeah | 16:44 |
| abhishekk | except distributed image import i guess | 16:44 |
| dansmith | ade_lee: so I think just the multistore cinder job for tempest, and the py36 functional job | 16:44 |
| dansmith | abhishekk: not much fips-related in that | 16:45 |
| ade_lee | abhishekk, ^^ agree? | 16:45 |
| dansmith | it excludes the meta/conversion cases, but not really much related in there either I think | 16:45 |
| abhishekk | in that case sounds | 16:46 |
| abhishekk | good | 16:46 |
| ade_lee | ok will do | 16:46 |
| dansmith | ade_lee: sorry for all the derping :) | 16:46 |
| abhishekk | yeah, sorry | 16:47 |
| ade_lee | dansmith, abhishekk glad we're getting it all right :) | 16:47 |
| abhishekk | but again if I am correct, you are suggesting to rename the job and not add the new one right? | 16:47 |
| abhishekk | dansmith, ^ | 16:47 |
| dansmith | abhishekk: right | 16:47 |
| dansmith | *convert* those two to fips, add -fips to name to make it clear | 16:48 |
| ade_lee | ack | 16:48 |
| abhishekk | yeah, so last patch updated by ade_lee has new definitions | 16:48 |
| ade_lee | abhishekk, yeah - sorry - that was just a rebase | 16:48 |
| abhishekk | aahh, no worries | 16:49 |
| abhishekk | cool, now we are on same page | 16:49 |
| opendevreview | Dan Smith proposed openstack/glance master: [APIImpact] Quota usage API https://review.opendev.org/c/openstack/glance/+/794860 | 16:49 |
| * abhishekk signing out for the day and will be on leave tomorrow | 18:16 | |
| opendevreview | Ade Lee proposed openstack/glance master: Add fips check jobs https://review.opendev.org/c/openstack/glance/+/790536 | 18:23 |
| ade_lee | abhishekk, dansmith ^^ I think this covers it | 18:24 |
| ade_lee | lmk if I got something wrong | 18:25 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!