| opendevreview | Merged openstack/glance stable/wallaby: Fix failing copy_image flow init https://review.opendev.org/c/openstack/glance/+/826975 | 05:59 |
|---|---|---|
| opendevreview | Mridula Joshi proposed openstack/glance master: Fix overwriting of existing tags while creating new tags https://review.opendev.org/c/openstack/glance/+/804966 | 14:23 |
| abhishekk | rosmaita, jokke_, croelandt, dansmith https://review.opendev.org/c/openstack/glance/+/790536 | 14:31 |
| abhishekk | either of you when get time,kindly review this patch | 14:32 |
| rosmaita | abhishekk: ack | 14:34 |
| dansmith | abhishekk: I left comments, but that's a lot of new job duplication.. I would think fipsifying some fo those variants would be fine, or not having -fips versions of them since they're nearly the same as the main job, but with meta injection or something else turned on | 14:38 |
| abhishekk | dansmith, ack, looking | 14:38 |
| abhishekk | dansmith, yes good point, | 14:41 |
| opendevreview | Dan Smith proposed openstack/glance master: Fix set_property_atomic() boolean type casting https://review.opendev.org/c/openstack/glance/+/820247 | 15:13 |
| dansmith | abhishekk: this ^ fixes a postgres break I introduced a while back because I didn't realize that table didn't support the soft-delete convention | 15:14 |
| dansmith | I dunno what the best way to test it is, other than the opportunistic testing (if glance does that?) | 15:15 |
| abhishekk | dansmith, ack, I think we do that, need to check it | 15:15 |
| dansmith | well, regular testing will ensure it didn't regress anything, and the reporter confirmed it fixed postgres.. | 15:16 |
| abhishekk | yeah, seen his comment | 15:17 |
| abhishekk | we just tests migration scripts with opportunistic, I guess regular testing is enough here | 15:19 |
| abhishekk | jokke_, croelandt, rosmaita Kindly look for "[Glance] Upstream core meet" in you inbox | 15:24 |
| rosmaita | abhishekk: ack | 15:24 |
| opendevreview | Dan Smith proposed openstack/glance master: [APIImpact] Quota usage API https://review.opendev.org/c/openstack/glance/+/794860 | 15:58 |
| dansmith | abhishekk: hopefully this ^ is nearly ready.. you mentioned unused variables, so point them out if you see them | 15:59 |
| abhishekk | dansmith, cool, will have a look in some time | 16:00 |
| dansmith | abhishekk: oops, forgot to add my comments to the test, will fix | 16:06 |
| dansmith | oh no, I did, heh, nevermind | 16:06 |
| abhishekk | :D | 16:06 |
| abhishekk | dansmith, added comments, looks good will perform some manual testing tomorrow my time before final vote | 16:20 |
| dansmith | abhishekk: ack thanks | 16:20 |
| abhishekk | np | 16:24 |
| * abhishekk going for dinner | 16:24 | |
| opendevreview | Dan Smith proposed openstack/glance master: [APIImpact] Quota usage API https://review.opendev.org/c/openstack/glance/+/794860 | 16:40 |
| * abhishekk signing out for the day | 17:53 | |
| *** tkajinam is now known as Guest1307 | 18:43 | |
| opendevreview | Dan Smith proposed openstack/python-glanceclient master: Add support for usage API https://review.opendev.org/c/openstack/python-glanceclient/+/827174 | 20:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!