| *** bhagyashris_ is now known as bhagyashris | 11:43 | |
| dansmith | "and will remove the support of same in Victoria cycle" | 14:47 |
|---|---|---|
| dansmith | :P | 14:47 |
| abhishekk | :D | 14:54 |
| abhishekk | you are watching everything :P | 14:54 |
| dansmith | sorry, is that creepy? :P | 14:55 |
| dansmith | just got the email notification when you rechecked that | 14:55 |
| abhishekk | not at all | 14:55 |
| abhishekk | I should have modified the commit message :D | 14:55 |
| dansmith | might be good | 14:56 |
| abhishekk | yep | 14:56 |
| dansmith | might as well let it run now though | 14:56 |
| dansmith | in case we need to fix something, and can do the commit message change at the same time | 14:56 |
| abhishekk | modified, | 14:57 |
| abhishekk | I think I need to look at dependent patches, there are some comments from you on swift patch | 14:58 |
| zigo | Hi. | 15:02 |
| zigo | I just noticed that Glance wouldn't build with 4.4.0, but does with 4.6.0. | 15:02 |
| zigo | Please bump the (test-)requirements.txt | 15:03 |
| dansmith | zigo: 4.4.0 of what? | 15:03 |
| zigo | with oslo.log, that is, sorry. | 15:03 |
| zigo | Test discovery fail otherwise. | 15:03 |
| zigo | (of course, I'm talking about Glance RC for Xena) | 15:04 |
| zigo | dansmith: Here's the begining of the build log: https://paste.opendev.org/show/809412/ | 15:05 |
| dansmith | not sure why that would be oslo.log related | 15:06 |
| dansmith | abhishekk: ^ | 15:06 |
| abhishekk | looking | 15:06 |
| zigo | Well, look at the matching code, when I read it, I found it kind of obvious... | 15:07 |
| abhishekk | zigo, which job you are running ? | 15:07 |
| zigo | https://github.com/openstack/glance/blob/master/glance/policies/metadef.py#L39 <--- This references a versionutils from oslo_log | 15:08 |
| dansmith | oh, versionutils comes from oslo.log, I see | 15:08 |
| zigo | abhishekk: I'm the OpenStack Debian package maintainer since 2011, so I'm not running any job, I just run the unit tests when I build packages. | 15:08 |
| zigo | abhishekk: This involves pulling all dependencies from packages only, and then just run stestr ... | 15:08 |
| abhishekk | zigo, ack | 15:09 |
| zigo | FYI, other than that, no worries with Glance unit tests (I've just uploaded glance_23.0.0~rc1-1_source.changes to Debian Experimental...). | 15:10 |
| zigo | Have a good week-end folks ... I'm off now. | 15:10 |
| abhishekk | requirements.txt already states oslo.log>=4.3.0 so do we need to blacklist 4.4.0 ? | 15:11 |
| dansmith | we probably need it to be >=4.6.0 | 15:12 |
| abhishekk | Ok | 15:12 |
| abhishekk | I thought there are bots to bump the specific requirement versions | 15:13 |
| dansmith | there are, I dunno what their trigger is though | 15:13 |
| abhishekk | ack | 15:13 |
| dansmith | and I guess if we didn't use that XENA reference, it probably wouldn't matter, so it would be hard for the bot to know that | 15:13 |
| abhishekk | might be, | 15:14 |
| abhishekk | but still its little bit confusing | 15:15 |
| abhishekk | what is the upper constraints for olso.log ? | 15:15 |
| abhishekk | if it is 4.6.0 then glance should install that and not 4.4.0 | 15:16 |
| dansmith | abhishekk: I think we are, but I'm guessing that in debian they're installing whatever the oldest thing we say we can work with is | 15:33 |
| abhishekk | dansmith, ack | 15:35 |
| abhishekk | so we need to bump the requirements.txt and backport it to stable/wallaby now ? | 15:36 |
| dansmith | no, this is only a xena thing right? so just rc2? | 15:40 |
| abhishekk | we already cut the stable branch with RC1 | 15:40 |
| dansmith | for xena, right, so we need to backport to stable/xena | 15:41 |
| abhishekk | and tag the rc2 as well | 15:41 |
| abhishekk | https://review.opendev.org/c/openstack/neutron/+/803160 | 15:42 |
| abhishekk | I have found similar fix in neutron, so do we need to bump it to 4.5.0 or to 4.6.0 | 15:42 |
| dansmith | whatever version added versionutils.XENA should be fine | 15:43 |
| dansmith | if neutron grabbed 4.5 for that then that should be fine | 15:43 |
| abhishekk | ack | 15:43 |
| abhishekk | will report a bug and submit a patch | 15:44 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Bump oslo.log to version 4.5.0 https://review.opendev.org/c/openstack/glance/+/809777 | 15:53 |
| * abhishekk going for lunch break | 15:57 | |
| * abhishekk *dinner | 15:57 | |
| abhishekk | jokke_, croelandt ^^ | 16:27 |
| jokke_ | I don't think the requirements bumps comes from the bots anymore. It used to be that when ever global-requirements were updated the project requirements got patch to bump theirs but IIUC the requirement management is up to the projects now as long as they are aligned with global | 16:28 |
| abhishekk | jokke_, ack, I was wondering about the same, thank you | 16:29 |
| jokke_ | abhishekk: when was the RC1 released? | 16:35 |
| abhishekk | yesterday | 16:35 |
| jokke_ | cheers. I created rc2 milestone and targeted that bug to it | 16:40 |
| abhishekk | ++ | 16:41 |
| jokke_ | I also created the yoga series | 16:41 |
| jokke_ | So once we merge that to master, we need to backport it to stable/xena too | 16:41 |
| abhishekk | ye | 16:41 |
| abhishekk | thanks for creating yoga milestones as well | 16:42 |
| jokke_ | There's lots of housekeeping that needs to happen. we've nothing targeted so LP is pretty much mess | 16:44 |
| abhishekk | hmm | 16:47 |
| * abhishekk signing out for the day | 17:12 | |
| opendevreview | Merged openstack/glance master: Bump oslo.log to version 4.5.0 https://review.opendev.org/c/openstack/glance/+/809777 | 17:39 |
| dansmith | zigo: ^ | 17:43 |
| jokke_ | dansmith: that's only master | 17:44 |
| jokke_ | does not help him yet | 17:44 |
| dansmith | jokke_: I understand, just keeping him in the loop | 17:45 |
| dansmith | jokke_: you targeted the bug, were you going to do the backport or should I? | 17:45 |
| jokke_ | if you do the backport I can give it +2 | 17:46 |
| jokke_ | if I do it I can't ;) | 17:46 |
| opendevreview | Dan Smith proposed openstack/glance stable/xena: Bump oslo.log to version 4.5.0 https://review.opendev.org/c/openstack/glance/+/809886 | 17:47 |
| dansmith | jokke_: ^ | 17:47 |
| jokke_ | ++ | 17:47 |
| jokke_ | thanks | 17:47 |
| * dansmith nods | 17:49 | |
| jokke_ | rosmaita: if you have a moment, I think you should be able to approve that still ^^ | 17:50 |
| rosmaita | looking | 18:07 |
| rosmaita | jokke_: glad you pointed me to that, i will have to update cinder, too | 18:09 |
| rosmaita | dansmith: good job catching that | 18:09 |
| dansmith | rosmaita: I didn't catch it really, but I'll take whatever praise from you, however misguided :P | 18:19 |
| opendevreview | Merged openstack/glance stable/xena: Bump oslo.log to version 4.5.0 https://review.opendev.org/c/openstack/glance/+/809886 | 18:27 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!