| *** udesale is now known as udesale|holiday | 06:58 | |
| dansmith | lbragstad: question for you here: https://review.opendev.org/c/openstack/glance/+/806775/5/glance/tests/functional/v2/metadef_utils.py | 13:58 |
|---|---|---|
| dansmith | otherwise a big fan of the cleanups of course | 13:58 |
| dansmith | I'm happy to squash those for you if you agree | 13:58 |
| lbragstad | dansmith yep - i agree with that | 13:59 |
| dansmith | okay you want me to do the squashing? | 14:00 |
| lbragstad | dansmith my initial thought was to separate the assertions from the thing creating the namespace | 14:01 |
| lbragstad | but after i did that, i realized the method only contained a single line for the POST | 14:01 |
| lbragstad | which probably doesn't make much sense | 14:01 |
| dansmith | I guess I'm not sure why they should be separate at all | 14:02 |
| lbragstad | yeah - i don't think they need to be | 14:02 |
| lbragstad | i thought it was something to try initially, but in doing so i don't think it useful or necessary | 14:03 |
| dansmith | ack, just looking through the others real quick | 14:03 |
| lbragstad | the main thing i wanted to do was to remove the duplicated method from every file | 14:03 |
| dansmith | for sure | 14:04 |
| lbragstad | and separating create_namespace into a method for creation and a method for assertions was probably a step too far | 14:04 |
| dansmith | well, and in the last patch, you define _headers on the test base and not the thing with the POST helper | 14:04 |
| dansmith | which seems contradictory :) | 14:04 |
| lbragstad | yeah - exactly | 14:05 |
| dansmith | okay, let me pull these down and squash that bit together and then I'll ninja them all | 14:05 |
| lbragstad | dansmith thank you, i've been meaning to get back to those, but i've been in a fist-fight was tripleo all week | 14:06 |
| lbragstad | i appreciate the help | 14:06 |
| dansmith | hah | 14:06 |
| dansmith | I don't envy that position | 14:06 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove duplicate namespace utilities in functional tests https://review.opendev.org/c/openstack/glance/+/806775 | 14:11 |
| opendevreview | Dan Smith proposed openstack/glance master: Move global constants to test module setUp https://review.opendev.org/c/openstack/glance/+/806779 | 14:11 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove duplicate _url() methods from functional test classes https://review.opendev.org/c/openstack/glance/+/806797 | 14:11 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove duplicate _header() implementations in metadef tests https://review.opendev.org/c/openstack/glance/+/806801 | 14:11 |
| dansmith | ninja'd thusly | 14:13 |
| opendevreview | OpenStack Release Bot proposed openstack/glance_store stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/glance_store/+/808257 | 14:32 |
| opendevreview | OpenStack Release Bot proposed openstack/glance_store stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/glance_store/+/808259 | 14:32 |
| opendevreview | OpenStack Release Bot proposed openstack/glance_store master: Update master for stable/xena https://review.opendev.org/c/openstack/glance_store/+/808261 | 14:32 |
| opendevreview | OpenStack Release Bot proposed openstack/glance_store master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/glance_store/+/808265 | 14:32 |
| opendevreview | OpenStack Release Bot proposed openstack/python-glanceclient stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/python-glanceclient/+/808306 | 14:33 |
| opendevreview | OpenStack Release Bot proposed openstack/python-glanceclient stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/python-glanceclient/+/808307 | 14:33 |
| opendevreview | OpenStack Release Bot proposed openstack/python-glanceclient master: Update master for stable/xena https://review.opendev.org/c/openstack/python-glanceclient/+/808309 | 14:33 |
| opendevreview | OpenStack Release Bot proposed openstack/python-glanceclient master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/python-glanceclient/+/808311 | 14:33 |
| opendevreview | Erno Kuvaja proposed openstack/glance master: Fixed image_format typo in doc https://review.opendev.org/c/openstack/glance/+/806414 | 14:49 |
| opendevreview | Merged openstack/glance master: Make signature verification go back to 'queued' https://review.opendev.org/c/openstack/glance/+/807932 | 16:26 |
| opendevreview | Merged openstack/glance master: Remove duplicate namespace utilities in functional tests https://review.opendev.org/c/openstack/glance/+/806775 | 16:26 |
| opendevreview | Merged openstack/glance master: Move global constants to test module setUp https://review.opendev.org/c/openstack/glance/+/806779 | 16:26 |
| opendevreview | Merged openstack/glance master: Remove duplicate _url() methods from functional test classes https://review.opendev.org/c/openstack/glance/+/806797 | 16:26 |
| opendevreview | Merged openstack/glance master: Remove duplicate _header() implementations in metadef tests https://review.opendev.org/c/openstack/glance/+/806801 | 16:26 |
| opendevreview | Merged openstack/glance stable/ussuri: Revert "Remove all usage of keystoneclient" https://review.opendev.org/c/openstack/glance/+/800103 | 18:11 |
| opendevreview | Merged openstack/glance master: Fixed image_format typo in doc https://review.opendev.org/c/openstack/glance/+/806414 | 18:12 |
| gmann | dansmith: I am seeing a failure where 'member' role is not able to update the image member https://storyboard.openstack.org/#!/story/2009210 | 18:56 |
| gmann | dansmith: is it something to do with https://review.opendev.org/c/openstack/glance/+/796066 ? | 18:57 |
| dansmith | gmann: not directly, but potentially that whole refactor.. is this on a new proposed patch or existing tempest? | 18:58 |
| gmann | dansmith: it is in patrole tests. | 19:02 |
| dansmith | gmann: with rbac turned on? | 19:02 |
| gmann | existing patrole tests which were passing before | 19:02 |
| gmann | dansmith: no, with legacy rbac | 19:02 |
| dansmith | gmann: can you point me at the test? | 19:03 |
| dansmith | the refactored policy is definitely tighter/more-correct than it was before, so possible the test is wrong | 19:03 |
| gmann | https://github.com/openstack/patrole/blob/master/patrole_tempest_plugin/tests/api/image/test_images_member_rbac.py#L93 | 19:04 |
| gmann | it is simple test to update member on image with configured role in different job- admin, member, reader | 19:04 |
| dansmith | yeah, but still | 19:05 |
| dansmith | it's failing in the "override role" thing right? what does that change? | 19:05 |
| gmann | yeah in override role. that (in member role job) basically check 1. policy directly with member role in oslo.policy 2. run tests with member role. former is passing policy but later fail in tests with 403 | 19:06 |
| dansmith | gmann: what I'm asking is what is the difference between L103 and L108? admin first, then member? | 19:07 |
| dansmith | there was a bug before (I think) that allowed the owner of the image to update the member status, which isn't supposed to be allowed or something, only the recipient of the share is allowed to do that | 19:08 |
| gmann | dansmith: L103 is always admin role | 19:08 |
| dansmith | right, okay | 19:08 |
| dansmith | gmann: so the test should be: | 19:08 |
| dansmith | 1. create image with tenant1, shared | 19:09 |
| dansmith | 2. as tenant1 (owner), add tenant2 to members list | 19:09 |
| dansmith | 3. As tenant2, change status between pending and accepted | 19:09 |
| dansmith | tenant1 cannot do that (but admin always can I think) | 19:09 |
| gmann | ok, I think that what we tests in tempest https://github.com/openstack/tempest/blob/master/tempest/api/image/v2/test_images_member_negative.py#L36 | 19:09 |
| dansmith | so I think that test is wrong, and the code before was letting it do it but shouldn't have | 19:09 |
| gmann | and that is changed recently right ? | 19:10 |
| gmann | i mean fixed | 19:10 |
| gmann | in glance | 19:10 |
| gmann | ok | 19:10 |
| dansmith | yes | 19:10 |
| dansmith | let me see if I can find any discussion to link you to | 19:10 |
| dansmith | gmann: https://review.opendev.org/c/openstack/glance/+/802996/8/glance/tests/functional/v2/test_member_api_policy.py#135 | 19:12 |
| dansmith | that's not super clear because I think it took some irc discussion for me to realize what was going on, but that's kinda where we noted that it needed to be different in our own tests | 19:13 |
| dansmith | gmann: yes, that tempest test is exactly right.. the owner can't change accept status, only the person the image is shared *with* | 19:13 |
| gmann | dansmith: ok, but tempest test was passing with forbidden even before glance recent change ? | 19:15 |
| dansmith | gmann: yeah, not sure why patrole would be tickling something different, but maybe because it was using admin? | 19:15 |
| gmann | humm yeah may be, it change the role to admin before override thing. | 19:16 |
| gmann | thanks for clarity. it explain the things now. let me fix the patrole test | 19:19 |
| dansmith | cool :) | 19:19 |
| opendevreview | Merged openstack/python-glanceclient stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/python-glanceclient/+/808306 | 19:41 |
| opendevreview | Merged openstack/python-glanceclient stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/python-glanceclient/+/808307 | 19:41 |
| opendevreview | Merged openstack/python-glanceclient master: Update master for stable/xena https://review.opendev.org/c/openstack/python-glanceclient/+/808309 | 19:41 |
| opendevreview | Merged openstack/glance_store stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/glance_store/+/808257 | 19:42 |
| opendevreview | Merged openstack/glance_store stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/glance_store/+/808259 | 19:42 |
| opendevreview | Merged openstack/glance_store master: Update master for stable/xena https://review.opendev.org/c/openstack/glance_store/+/808261 | 19:48 |
| opendevreview | Merged openstack/glance_store master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/glance_store/+/808265 | 20:54 |
| opendevreview | Merged openstack/glance stable/wallaby: Fix image/tasks API for in-progress tasks https://review.opendev.org/c/openstack/glance/+/785420 | 21:20 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!