| opendevreview | Abhishek Kekane proposed openstack/glance master: Check deactivate, reactivate policy in the API https://review.opendev.org/c/openstack/glance/+/798266 | 06:20 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for delete image for store in API https://review.opendev.org/c/openstack/glance/+/804585 | 06:20 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move Tasks policy checks in the API https://review.opendev.org/c/openstack/glance/+/802245 | 06:20 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image import operation in API https://review.opendev.org/c/openstack/glance/+/804590 | 06:20 |
| *** akekane_ is now known as abhishekk | 06:46 | |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Tags in API https://review.opendev.org/c/openstack/glance/+/804588 | 07:15 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image tasks information in API https://review.opendev.org/c/openstack/glance/+/805590 | 07:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Avoid reinitialization of image repo https://review.opendev.org/c/openstack/glance/+/805593 | 08:01 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 08:07 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 08:53 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 08:53 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 08:53 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 08:53 |
| abhishekk | dansmith, croelandt 12 patches up and remaining for policy refactor, and one more I will be working on cache manage policy to conclude this work | 13:25 |
| abhishekk | #link https://tinyurl.com/glance-xena-3 | 13:26 |
| abhishekk | remaining means, ready but not merged yet | 13:26 |
| abhishekk | #link https://review.opendev.org/c/openstack/glance/+/805593 | 13:27 |
| abhishekk | this one is trivial and can be ninja approved | 13:27 |
| dansmith | abhishekk: it looks trivial, but are we even testing that code path? | 13:44 |
| abhishekk | Not in unit test, will look at functional test else add new one | 13:44 |
| dansmith | okay I could look at a test after I do some of these reviews if you want | 13:46 |
| dansmith | abhishekk: is this to fix something? or you just noticed it? | 13:46 |
| abhishekk | I just scanned get_repo call to look out what has left | 13:47 |
| dansmith | okay | 13:47 |
| abhishekk | and I found 3 places, this is one of them | 13:47 |
| abhishekk | image_data.py, upload call #189 line | 13:47 |
| abhishekk | images.py get_task_info line #570 | 13:47 |
| abhishekk | prefetcher.py line #46 | 13:47 |
| dansmith | ack | 13:48 |
| abhishekk | for this I have submitted another patch | 13:48 |
| abhishekk | for prefetcher I will fix it while working on cache_manage policy change | 13:48 |
| dansmith | ack | 13:48 |
| abhishekk | nothing in functional as well | 13:57 |
| opendevreview | Mridula Joshi proposed openstack/glance master: Fix overwriting of existing tags while creating new tags https://review.opendev.org/c/openstack/glance/+/804966 | 14:04 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for delete image for store in API https://review.opendev.org/c/openstack/glance/+/804585 | 15:34 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move Tasks policy checks in the API https://review.opendev.org/c/openstack/glance/+/802245 | 15:56 |
| * abhishekk going for dinner break | 15:57 | |
| opendevreview | Ade Lee proposed openstack/glance master: DNM: Add fips check jobs https://review.opendev.org/c/openstack/glance/+/790536 | 16:12 |
| abhishekk | heavy traffic in gate, one patch will take 6 to 7 hours | 17:51 |
| abhishekk | If you guys give +2s, I will set workflow +A during my time when traffic will be much less | 17:52 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Avoid reinitialization of image repo https://review.opendev.org/c/openstack/glance/+/805593 | 18:13 |
| *** timburke__ is now known as timburke | 18:14 | |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Avoid reinitialization of image repo https://review.opendev.org/c/openstack/glance/+/805593 | 18:15 |
| abhishekk | dansmith, tried to add unit test ^^^ | 18:17 |
| * abhishekk signing out for the day | 18:45 | |
| abhishekk | croelandt, replied to your comment | 18:53 |
| opendevreview | Merged openstack/glance master: Check deactivate, reactivate policy in the API https://review.opendev.org/c/openstack/glance/+/798266 | 21:20 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org has been restarted for a patch version upgrade, resulting in a brief outage | 21:42 | |
| opendevreview | Merged openstack/glance master: Check policies for delete image for store in API https://review.opendev.org/c/openstack/glance/+/804585 | 23:33 |
| *** yoctozepto4 is now known as yoctozepto | 23:37 | |
| opendevreview | Merged openstack/glance master: Move Tasks policy checks in the API https://review.opendev.org/c/openstack/glance/+/802245 | 23:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!