| opendevreview | Cyril Roelandt proposed openstack/glance master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/glance/+/802649 | 03:07 |
|---|---|---|
| opendevreview | Cyril Roelandt proposed openstack/glance master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/glance/+/802649 | 03:45 |
| opendevreview | Merged openstack/glance master: Add api_patch() to SynchronousAPIBase https://review.opendev.org/c/openstack/glance/+/801119 | 05:16 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: PoC Move member policy checks to API layer https://review.opendev.org/c/openstack/glance/+/802526 | 07:10 |
| *** mabrams is now known as Guest2562 | 11:51 | |
| *** mabrams1 is now known as mabrams | 11:51 | |
| *** mabrams is now known as Guest2563 | 11:53 | |
| *** mabrams1 is now known as mabrams | 11:53 | |
| *** whoami-rajat is now known as Guest2569 | 12:41 | |
| *** whoami-rajat__ is now known as whoami-rajat | 12:41 | |
| abhishekk | member policies are nightmare :/ | 13:55 |
| dansmith | yeah | 13:58 |
| abhishekk | we need to redefine default RABC policies for members | 14:01 |
| dansmith | what do you mean? | 14:03 |
| abhishekk | example | 14:03 |
| abhishekk | current get member policy is admin or project reader | 14:03 |
| abhishekk | and auth layer injecting lots of read only checks | 14:04 |
| dansmith | get member or get image? | 14:04 |
| abhishekk | get_member | 14:05 |
| dansmith | ah okay, you mean the member api I guess | 14:05 |
| dansmith | makes sense yeah | 14:05 |
| abhishekk | yep | 14:05 |
| abhishekk | and auth layer for the same is adding 3-4 different checks :/ | 14:06 |
| dansmith | :/ | 14:07 |
| dansmith | abhishekk: so maybe I should add tests at least to the member target patch today and then you can pull that out into your member stack? | 14:10 |
| abhishekk | sounds good | 14:10 |
| abhishekk | Till then I will work on drafting new policies in our spreadsheet where we can discuss and finalize them | 14:10 |
| abhishekk | * new RBAC policies | 14:11 |
| dansmith | ack | 14:11 |
| opendevreview | Dan Smith proposed openstack/glance master: Add a member field to Image when appropriate https://review.opendev.org/c/openstack/glance/+/796066 | 15:13 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check delete_image policy in the API https://review.opendev.org/c/openstack/glance/+/798073 | 15:13 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check deactivate, reactivate policy in the API https://review.opendev.org/c/openstack/glance/+/798266 | 15:13 |
| dansmith | abhishekk: pulling that out of the stack gives me conflicts, so your decision if you want to rebase it or just build on top and wait for it to merge | 15:14 |
| abhishekk | I will rebase ion top of it | 15:14 |
| dansmith | abhishekk: maybe we can get croelandt to hit the few at the bottom of this stack? :) https://review.opendev.org/c/openstack/glance/+/799699 | 15:15 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Glance cinder nfs: Block creating qcow2 volumes https://review.opendev.org/c/openstack/glance_store/+/796577 | 15:15 |
| abhishekk | yep, croelandt when you have time, kindly have a look | 15:16 |
| whoami-rajat | dansmith, ^ updated as per comments | 15:19 |
| dansmith | whoami-rajat: nearly finished slapping my +2 on it already :) | 15:19 |
| whoami-rajat | dansmith, \o/, thanks for the quick responses :) | 15:20 |
| dansmith | abhishekk: should be an easy re-approve for you ^, just more test assertions and one other thing | 15:21 |
| abhishekk | dansmith, looking | 15:21 |
| whoami-rajat | and to answer your comment, I've executed those tests locally, the assertions pass | 15:21 |
| dansmith | I figured :P | 15:22 |
| whoami-rajat | :D ok, i will keep an eye on gate and notify | 15:24 |
| abhishekk | done | 15:24 |
| whoami-rajat | thanks abhishekk dansmith \o/ | 15:24 |
| abhishekk | ++ | 15:25 |
| abhishekk | f strings :D | 15:27 |
| dansmith | f--k strings | 15:28 |
| abhishekk | haha | 15:32 |
| * abhishekk dinner break | 15:55 | |
| opendevreview | Stephen Finucane proposed openstack/glance master: tests: Remove use of 'oslo_db.sqlalchemy.test_base' https://review.opendev.org/c/openstack/glance/+/802762 | 17:06 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Refactor gateway auth layer for member APIs https://review.opendev.org/c/openstack/glance/+/802525 | 17:47 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: PoC Move member policy checks to API layer https://review.opendev.org/c/openstack/glance/+/802526 | 17:47 |
| abhishekk | This will fix failing functional-py38-rbac job | 17:48 |
| abhishekk | still need to rebase it on top of dan's member patch | 17:48 |
| abhishekk | added current RBAC vs New RBAC rules after policy refactoring to spreadsheet | 18:18 |
| abhishekk | https://docs.google.com/spreadsheets/d/1SWBq0CsHw8jofHxmOG8QeZEX6veDE4eU0QHItOu8uQs/edit?pli=1#gid=0 | 18:18 |
| * abhishekk signing out for the day | 18:42 | |
| abhishekk | dansmith, I will work on rebasing tomorrow, finished describing policy changes in spreadsheet for member APIs | 18:47 |
| dansmith | abhishekk: cool, have a good evening! | 18:47 |
| abhishekk | thanks, good day | 18:47 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef namespaces https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 19:16 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef resource types https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802792 | 19:16 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef objects https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802793 | 19:16 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef properties https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802794 | 19:16 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef tags https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802795 | 19:16 |
| Guest2352 | looks like the new networkx causes glance failures | 19:23 |
| Guest2352 | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_190/802427/4/check/cross-glance-py38/190cc58/testr_results.html | 19:23 |
| Guest2352 | https://review.opendev.org/802427 | 19:23 |
| *** timburke_ is now known as timburke | 20:55 | |
| opendevreview | Merged openstack/glance_store master: Glance cinder nfs: Block creating qcow2 volumes https://review.opendev.org/c/openstack/glance_store/+/796577 | 21:24 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!