| opendevreview | Merged openstack/glance master: db: Move 'schema' module up a level https://review.opendev.org/c/openstack/glance/+/760408 | 03:24 |
|---|---|---|
| opendevreview | Merged openstack/glance master: Ignore stale image property removal https://review.opendev.org/c/openstack/glance/+/783668 | 03:42 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 07:11 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-type and object https://review.opendev.org/c/openstack/glance/+/799671 | 07:11 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef property and tags APIs https://review.opendev.org/c/openstack/glance/+/799912 | 07:11 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 07:47 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-type and object https://review.opendev.org/c/openstack/glance/+/799671 | 07:49 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef property and tags APIs https://review.opendev.org/c/openstack/glance/+/799912 | 07:49 |
| opendevreview | Merged openstack/glance master: db: Replace sqlalchemy-migrate call with alembic equivalent https://review.opendev.org/c/openstack/glance/+/760531 | 07:57 |
| *** bhagyashris_ is now known as bhagyashris | 08:05 | |
| opendevreview | Merged openstack/glance master: db: Stop checking for DB under sqlalchemy-migrate control https://review.opendev.org/c/openstack/glance/+/760409 | 08:08 |
| opendevreview | Merged openstack/glance master: db: Remove old sqlalchemy-migrate migrations https://review.opendev.org/c/openstack/glance/+/760410 | 08:18 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 08:43 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 08:47 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-type and object https://review.opendev.org/c/openstack/glance/+/799671 | 08:56 |
| stephenfin | abhishekk++ croelandt++ Thanks for the reviews! | 09:07 |
| abhishekk | stephenfin, np, thank you for the patience :D | 09:07 |
| *** bhagyashris_ is now known as bhagyashris | 09:35 | |
| opendevreview | Abhishek Kekane proposed openstack/glance master: DB layer suppress Forbidden to NotFound error https://review.opendev.org/c/openstack/glance/+/801373 | 09:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add base policy check module https://review.opendev.org/c/openstack/glance/+/801129 | 09:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Refactor gateway auth layer for metadef APIs https://review.opendev.org/c/openstack/glance/+/799632 | 09:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef namepsace policy checks in the API https://review.opendev.org/c/openstack/glance/+/799633 | 09:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef object policy checks in the API https://review.opendev.org/c/openstack/glance/+/799634 | 09:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef resource type association policy checks in the API https://review.opendev.org/c/openstack/glance/+/799637 | 09:46 |
| *** mabrams is now known as mabrams|afk | 11:42 | |
| *** mabrams|afk is now known as mabrams | 11:43 | |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 13:06 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-type and object https://review.opendev.org/c/openstack/glance/+/799671 | 13:06 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef property and tags APIs https://review.opendev.org/c/openstack/glance/+/799912 | 13:07 |
| abhishekk | jokke_, croelandt, dansmith, smcginnis glance weekly meeting in 4 minutes at #openstack-meeting | 13:56 |
| dansmith | croelandt: if you could hit the bottom two patches here, it'd help: https://review.opendev.org/c/openstack/glance/+/801373/3 | 14:10 |
| dansmith | so I can rebase on abhishekk's work | 14:10 |
| abhishekk | jokke_, smcginnis, croelandt we wrapped up today's meeting early as nothing much there to discuss, if you have any questions then we can discuss here | 14:12 |
| abhishekk | dansmith, just FYI I have managed to finish work for namespace, objects and resource types, now working on properties and next tags. Hopefully tomorrow or on Monday I will start on tasks APIs | 14:29 |
| dansmith | cool, I guess I'll keep working up the stack of image patches | 14:30 |
| abhishekk | sounds good | 14:30 |
| dansmith | abhishekk: can you throw your +2 on the 403->404 one and maybe I can get croelandt to hit that one too to drop a patch out of my stack? | 14:31 |
| dansmith | https://review.opendev.org/c/openstack/glance/+/799699/6 | 14:31 |
| dansmith | he had a question, which you answered, but never circled back | 14:31 |
| abhishekk | looking | 14:32 |
| abhishekk | Done | 14:33 |
| dansmith | thanks | 14:33 |
| abhishekk | just to update everyone, rosmaita is on vacation this week | 15:25 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add base policy check module https://review.opendev.org/c/openstack/glance/+/801129 | 15:38 |
| * abhishekk going for dinner | 15:38 | |
| opendevreview | Merged openstack/glance master: DB layer suppress Forbidden to NotFound error https://review.opendev.org/c/openstack/glance/+/801373 | 16:15 |
| opendevreview | Merged openstack/glance master: trivial: Remove references to sqlalchemy-migrate https://review.opendev.org/c/openstack/glance/+/760411 | 16:16 |
| opendevreview | Merged openstack/glance master: db: Remove "support" for configurable migration backends https://review.opendev.org/c/openstack/glance/+/760421 | 16:16 |
| abhishekk | dansmith, replied to your comment on PolicyBase patch | 16:51 |
| dansmith | abhishekk: yeah replying | 16:51 |
| abhishekk | ack | 16:52 |
| dansmith | there's one other crufty thing in there I noticed while looking closer | 16:55 |
| abhishekk | looking | 16:55 |
| dansmith | It seems to me that having Forbidden->HTTPForbidden in 20 places is less good than doing it in the single place we hit it now, so I was expecting to DRY that up, but if you want to just keep it the way it is, then I shan't argue | 16:56 |
| abhishekk | ack | 16:57 |
| abhishekk | will revert it | 16:57 |
| abhishekk | do you know any shortcuts for rebasing :P | 16:57 |
| dansmith | shortcut for doing what exactly? | 16:57 |
| abhishekk | nah, just kidding | 16:58 |
| abhishekk | I need to rebase this change to all other commits | 16:58 |
| dansmith | you're using "git rebase -i" right? | 16:59 |
| abhishekk | yes | 16:59 |
| abhishekk | dansmith, one question though | 17:11 |
| abhishekk | what about the forbidden we raising from db layer ? | 17:11 |
| dansmith | many of those can go away right? | 17:12 |
| dansmith | we'll still have some I'm sure, but I would think most of the current ones would be generated in the api layer going forward, especially when the secure rbac stuff is implemented, | 17:13 |
| dansmith | as it should allow multiple things that the DB layer wouldn't right/ | 17:13 |
| abhishekk | hmm | 17:13 |
| dansmith | no? | 17:14 |
| abhishekk | yes | 17:14 |
| dansmith | I don't mean to make a huge deal out of this, so if you're prefer to just remove the translation from the new policy thing and deal with it later, we can just do that | 17:15 |
| abhishekk | but at the moment If I caught and translate it from policy module and remove those from controllers then how to handle exception raised from db layer ? | 17:15 |
| dansmith | that's why I didn't remove it from the controllers yet :) | 17:16 |
| abhishekk | hmm, ack I need to fix my tests differently then | 17:16 |
| abhishekk | will check and let you know shortly | 17:17 |
| dansmith | rgr | 17:18 |
| abhishekk | dansmith, any suggestion for this failure, https://paste.opendev.org/show/807660/ ? | 17:47 |
| dansmith | um | 17:49 |
| dansmith | that second exception is you raising the HTTPForbidden right? | 17:49 |
| abhishekk | yes | 17:51 |
| abhishekk | second means from controller, right ? | 17:51 |
| dansmith | yeah, raising the HTTP error there should not trigger the InternalError case | 17:52 |
| dansmith | I'm a bit lost where these things have been changed.. which patch should I look at to see this test? | 17:52 |
| dansmith | I thought it was the "namespace policy" one but I don't see that test being modified there | 17:53 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/799633/9 | 17:53 |
| dansmith | ohhh | 17:53 |
| dansmith | that API case catches *any* other exception and translates it to internalerror! | 17:54 |
| dansmith | even if you raise a webob.Exception class | 17:54 |
| dansmith | https://review.opendev.org/c/openstack/glance/+/799633/9/glance/api/v2/metadef_namespaces.py L225 | 17:54 |
| dansmith | cripes | 17:55 |
| abhishekk | :P | 17:55 |
| dansmith | well, in that case, adding HTTPForbidden to the Forbidden handler for now would get you past it | 17:55 |
| dansmith | or | 17:55 |
| dansmith | just remove that "except exception" as I think the wsgi layer will do that itself, right? | 17:56 |
| abhishekk | yes, later sounds good | 17:56 |
| dansmith | yeah, we shouldn't need to be doing that everywhere.. that's silly | 17:56 |
| abhishekk | :D | 17:56 |
| abhishekk | thank you | 17:56 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add base policy check module https://review.opendev.org/c/openstack/glance/+/801129 | 18:13 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Refactor gateway auth layer for metadef APIs https://review.opendev.org/c/openstack/glance/+/799632 | 18:13 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef namepsace policy checks in the API https://review.opendev.org/c/openstack/glance/+/799633 | 18:13 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef namepsace policy checks in the API https://review.opendev.org/c/openstack/glance/+/799633 | 18:20 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef object policy checks in the API https://review.opendev.org/c/openstack/glance/+/799634 | 18:28 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef resource type association policy checks in the API https://review.opendev.org/c/openstack/glance/+/799637 | 18:40 |
| * abhishekk signing out for the day | 19:22 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!