| *** bhagyashris_ is now known as bhagyashris|ruck | 08:24 | |
| abhishekk | As there are no objections about, https://review.opendev.org/c/openstack/glance-specs/+/800688 (Removing sqlalchemy migrate support) I am approving the spec | 13:36 |
|---|---|---|
| opendevreview | Dan Smith proposed openstack/glance master: Make our functional tests compatible with RBAC https://review.opendev.org/c/openstack/glance/+/800822 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: Make property protection tests use member role https://review.opendev.org/c/openstack/glance/+/789914 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: Move lazy store update to locations layer https://review.opendev.org/c/openstack/glance/+/797722 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove dead 403->404 code https://review.opendev.org/c/openstack/glance/+/799699 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: Refactor gateway get_repo auth layer https://review.opendev.org/c/openstack/glance/+/789913 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Make image update check policy at API layer https://review.opendev.org/c/openstack/glance/+/789915 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Add a member field to Image when appropriate https://review.opendev.org/c/openstack/glance/+/796066 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check get_image(s) in the API https://review.opendev.org/c/openstack/glance/+/796067 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check delete_image policy in the API https://review.opendev.org/c/openstack/glance/+/798073 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check deactivate, reactivate policy in the API https://review.opendev.org/c/openstack/glance/+/798266 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC Refactor gateway auth layer for metadef APIs https://review.opendev.org/c/openstack/glance/+/799632 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef namepsace policy checks in the API https://review.opendev.org/c/openstack/glance/+/799633 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef object policy checks in the API https://review.opendev.org/c/openstack/glance/+/799634 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef property policy checks in the API https://review.opendev.org/c/openstack/glance/+/799635 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef tag policy checks in the API https://review.opendev.org/c/openstack/glance/+/799636 | 13:57 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef resource type association policy checks in the API https://review.opendev.org/c/openstack/glance/+/799637 | 13:57 |
| dansmith | croelandt: can you hit this? https://review.opendev.org/c/openstack/glance/+/800822/2 | 13:57 |
| abhishekk | dansmith, if you can have a look at metadef related changes, then I can move to tasks API if there is no modification required in metadef | 13:58 |
| dansmith | croelandt: the bottom four patches in that stack are prep work and should be ready to go, so we can reduce the size of that stack | 13:58 |
| dansmith | abhishekk: okay | 13:58 |
| abhishekk | thanks | 13:58 |
| dansmith | abhishekk: policy burn down sheet looks awesome btw | 13:59 |
| abhishekk | thank you | 13:59 |
| croelandt | let me look | 13:59 |
| dansmith | abhishekk: if you think we're good to go now that the spec has merged I can try to work on fleshing out tests in the update patch and we can actually start merging some things | 13:59 |
| abhishekk | ++ | 14:00 |
| abhishekk | this is a go now, no turning back :D | 14:00 |
| dansmith | heh okay | 14:01 |
| opendevreview | Merged openstack/glance-specs master: Add remove-sqlalchemy-migrate https://review.opendev.org/c/openstack/glance-specs/+/800688 | 14:01 |
| croelandt | why is there a "FIXME(danms)" in a patch written by abhishekk | 14:14 |
| dansmith | croelandt: because he copied it from one of my patches I guess | 14:14 |
| abhishekk | yeah | 14:14 |
| dansmith | abhishekk: some questions on the first metadef patch for you | 14:16 |
| abhishekk | dansmith, ack, looking | 14:17 |
| abhishekk | will reply shortly | 14:18 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add functional tests for metadef resource types https://review.opendev.org/c/openstack/glance/+/801074 | 14:52 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add functional tests for metadef resource types https://review.opendev.org/c/openstack/glance/+/801074 | 15:08 |
| abhishekk | dansmith, around? | 15:16 |
| dansmith | ...yep :) | 15:16 |
| abhishekk | So the current policy changes for metadef are just migration of existing policy checks to API | 15:17 |
| abhishekk | I think you are reviewing with prospect of RBAC as well | 15:18 |
| abhishekk | earlier the enforcement was not passing any resource to for visibility check | 15:18 |
| dansmith | yeah, you're right | 15:19 |
| dansmith | I'm not just reviewing this for rbac, but rather for "how it should have been from the beginning" but agree | 15:19 |
| abhishekk | Right, so I can make changes as per your suggestion to make it right | 15:19 |
| abhishekk | I was confused, how I missed these things :D then I remember | 15:20 |
| dansmith | yeah, well, it's worth thinking about how it should be, even if we don't do that now (or ever) | 15:21 |
| abhishekk | Yeah, I think I need to add lots of comments to explain why I am doing this to avoid confusion of other reviewers | 15:22 |
| abhishekk | Will make changes accordingly to metadefs and then move to tasks API | 15:22 |
| dansmith | yup, sounds good | 15:22 |
| abhishekk | cool | 15:22 |
| abhishekk | Removing 404 exposed another issue :D | 15:24 |
| dansmith | yeah, just looking at that | 15:24 |
| dansmith | oh, I wonder if this is in db simple | 15:25 |
| dansmith | yeah | 15:25 |
| dansmith | simple db api doesn't pass the image id | 15:26 |
| abhishekk | hmm | 15:26 |
| * abhishekk dinner break | 15:28 | |
| opendevreview | Dan Smith proposed openstack/glance master: Remove dead 403->404 code https://review.opendev.org/c/openstack/glance/+/799699 | 15:30 |
| opendevreview | Dan Smith proposed openstack/glance master: Refactor gateway get_repo auth layer https://review.opendev.org/c/openstack/glance/+/789913 | 15:30 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Make image update check policy at API layer https://review.opendev.org/c/openstack/glance/+/789915 | 15:30 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Add a member field to Image when appropriate https://review.opendev.org/c/openstack/glance/+/796066 | 15:30 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check get_image(s) in the API https://review.opendev.org/c/openstack/glance/+/796067 | 15:31 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check delete_image policy in the API https://review.opendev.org/c/openstack/glance/+/798073 | 15:31 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check deactivate, reactivate policy in the API https://review.opendev.org/c/openstack/glance/+/798266 | 15:31 |
| opendevreview | Dan Smith proposed openstack/glance master: POC Refactor gateway auth layer for metadef APIs https://review.opendev.org/c/openstack/glance/+/799632 | 15:31 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef namepsace policy checks in the API https://review.opendev.org/c/openstack/glance/+/799633 | 15:31 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef object policy checks in the API https://review.opendev.org/c/openstack/glance/+/799634 | 15:31 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef property policy checks in the API https://review.opendev.org/c/openstack/glance/+/799635 | 15:31 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef tag policy checks in the API https://review.opendev.org/c/openstack/glance/+/799636 | 15:31 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef resource type association policy checks in the API https://review.opendev.org/c/openstack/glance/+/799637 | 15:31 |
| opendevreview | Merged openstack/glance master: Make our functional tests compatible with RBAC https://review.opendev.org/c/openstack/glance/+/800822 | 16:18 |
| opendevreview | Merged openstack/glance master: Make property protection tests use member role https://review.opendev.org/c/openstack/glance/+/789914 | 16:18 |
| abhishekk | dansmith, I guess I should remove dependencies of metadef patches on yours to make them short, I don't think it needed lazy loading, 404 > 403 etc (Other than just your glance/api/v2/policy.py file) | 16:57 |
| dansmith | you need the authorization layer change patch though right? | 16:58 |
| abhishekk | no, it just adds one flag to decide whether to include it or not | 16:59 |
| dansmith | you don't need this? https://review.opendev.org/c/openstack/glance/+/789913/13 | 17:00 |
| dansmith | ohh, | 17:00 |
| dansmith | your repo is different, not ImageRepo | 17:00 |
| abhishekk | yes | 17:00 |
| dansmith | right, right, makes sense then | 17:00 |
| abhishekk | Just we need to figure out how to avoid conflicts in glance/api/v2/policy.py | 17:01 |
| dansmith | I'm working on new tests for modify_image, which I think will be a good base for further things, | 17:01 |
| abhishekk | cool | 17:01 |
| dansmith | but it will be a little bit before I have something up | 17:01 |
| abhishekk | ack, I guess by Monday EOD I will have metadefs in good shape | 17:02 |
| dansmith | cool | 17:02 |
| abhishekk | ok, over and out!! | 17:02 |
| dansmith | okay I'll delete your metadef patches from my stack when I push up (i.e. orphan them) | 17:03 |
| dansmith | cool, enjoy the weekend | 17:03 |
| abhishekk | sounds good, same to you o/~ | 17:03 |
| dansmith | o/ | 17:03 |
| abhishekk | just before signing out if you have a look this patch then it will avoid conflicts with mine | 17:04 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/801074 | 17:04 |
| dansmith | okay in the queue but haven't looked yet | 17:06 |
| abhishekk | ack | 17:07 |
| opendevreview | Dan Smith proposed openstack/glance master: Make image update check policy at API layer https://review.opendev.org/c/openstack/glance/+/789915 | 17:50 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Add a member field to Image when appropriate https://review.opendev.org/c/openstack/glance/+/796066 | 17:50 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check get_image(s) in the API https://review.opendev.org/c/openstack/glance/+/796067 | 17:50 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check delete_image policy in the API https://review.opendev.org/c/openstack/glance/+/798073 | 17:50 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check deactivate, reactivate policy in the API https://review.opendev.org/c/openstack/glance/+/798266 | 17:50 |
| opendevreview | Dan Smith proposed openstack/glance master: Add api_patch() to SynchronousAPIBase https://review.opendev.org/c/openstack/glance/+/801119 | 17:50 |
| opendevreview | Dan Smith proposed openstack/glance master: Add api_patch() to SynchronousAPIBase https://review.opendev.org/c/openstack/glance/+/801119 | 18:29 |
| opendevreview | Dan Smith proposed openstack/glance master: Make image update check policy at API layer https://review.opendev.org/c/openstack/glance/+/789915 | 18:29 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Add a member field to Image when appropriate https://review.opendev.org/c/openstack/glance/+/796066 | 18:30 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check get_image(s) in the API https://review.opendev.org/c/openstack/glance/+/796067 | 18:30 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check delete_image policy in the API https://review.opendev.org/c/openstack/glance/+/798073 | 18:30 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check deactivate, reactivate policy in the API https://review.opendev.org/c/openstack/glance/+/798266 | 18:30 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: POC: Move metadef namepsace policy checks in the API https://review.opendev.org/c/openstack/glance/+/799633 | 19:48 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add base poloicy check module https://review.opendev.org/c/openstack/glance/+/801129 | 19:48 |
| abhishekk | spelling mistake in title :/ | 19:49 |
| abhishekk | dansmith, ^^ something like this, still need to work for objects, resrource, properties and tags APIs | 19:51 |
| * abhishekk signing out for the day | 19:54 | |
| dansmith | okay will look later.. still have to get to that func test patch | 19:56 |
| opendevreview | Merged openstack/glance master: Add functional tests for metadef resource types https://review.opendev.org/c/openstack/glance/+/801074 | 22:37 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!