| opendevreview | hanchunlei proposed openstack/python-glanceclient master: fix unit test https://review.opendev.org/c/openstack/python-glanceclient/+/800742 | 02:35 |
|---|---|---|
| *** mabrams1 is now known as mabrams | 04:25 | |
| *** abhishekk is now known as akekane|home | 04:44 | |
| *** akekane|home is now known as abhishekk | 04:44 | |
| opendevreview | Merged openstack/glance-specs master: Fix symlinks for Xena templates https://review.opendev.org/c/openstack/glance-specs/+/800687 | 04:57 |
| *** bhagyashris_ is now known as bhagyashris|ruck | 06:25 | |
| opendevreview | Merged openstack/glance-specs master: Policy layer refactoring https://review.opendev.org/c/openstack/glance-specs/+/796753 | 13:47 |
| abhishekk | dansmith, around? | 13:48 |
| dansmith | yeah | 13:48 |
| abhishekk | I think we need to sync again to plan the work ^^^ | 13:48 |
| dansmith | ah, glad to see that | 13:49 |
| dansmith | I've been busy with other things and was waiting to make sure we were actually going to do this thing before investing more effort | 13:50 |
| abhishekk | Yes, this is required for RBAC so there is no going back | 13:51 |
| dansmith | I mean, I agree, but .. :) | 13:52 |
| abhishekk | Just we need to ensure to have more coverage :D | 13:52 |
| abhishekk | So let me know, then we can plan and divide the workload accordingly | 13:54 |
| dansmith | like, you want to have another voice call about it? | 13:54 |
| abhishekk | possibly yes, | 13:55 |
| dansmith | can we merge the bottom four patches in the series? | 13:56 |
| dansmith | or maybe the three other than the gateway patch, if that's up for discussion | 13:57 |
| abhishekk | Ack, will have a look again to those patches | 13:57 |
| dansmith | that will help reduce the size a bit | 13:58 |
| dansmith | I guess the other thing I need to do is figure out why the rbac tests are failing to make sure we're not committing to anything that won't work there.. I think they *were* working before I kinda de-rbac'd it based on previous discussion | 13:59 |
| abhishekk | yep, is it possible for you to move gateway related patch up in the chain, may be after 403 > 404 error ? | 13:59 |
| dansmith | hang on | 14:00 |
| dansmith | I can move it to under the update patch but no further | 14:01 |
| dansmith | yeah, after the 403->404 patch right | 14:01 |
| abhishekk | sounds good | 14:02 |
| opendevreview | Dan Smith proposed openstack/glance master: Make property protection tests use member role https://review.opendev.org/c/openstack/glance/+/789914 | 14:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Move lazy store update to locations layer https://review.opendev.org/c/openstack/glance/+/797722 | 14:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove dead 403->404 code https://review.opendev.org/c/openstack/glance/+/799699 | 14:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Refactor gateway get_repo auth layer https://review.opendev.org/c/openstack/glance/+/789913 | 14:03 |
| abhishekk | superdan :D | 14:04 |
| dansmith | okay, so, IIRC you were asking about when we disable the auth layer, like by config or something | 14:05 |
| dansmith | I have to load the context back in my head, but I think what I was hoping is that we won't make that optional, | 14:06 |
| dansmith | but rather make sure the policy (normal and rbac) equivalent so that any code that is converted does not run with the auth layer under it, ever | 14:06 |
| abhishekk | ack, so that flag will be remove in the last once all checks are migrated towards API layer | 14:07 |
| dansmith | right, that was my thinking | 14:09 |
| abhishekk | ack | 14:10 |
| dansmith | so I'll try to look at the rbac fails on the update patch today to see if I can make it work both ways | 14:13 |
| abhishekk | cool | 14:13 |
| dansmith | looks like delete, et al are also failing the rbac test, so maybe you can do the same in parallel on one of those? | 14:13 |
| abhishekk | delete, deactivate ? | 14:14 |
| dansmith | yeah | 14:15 |
| abhishekk | I will have a look as well | 14:16 |
| abhishekk | dansmith, you are talking about this job glance-tox-functional-py38-rbac-defaults, right ? | 14:23 |
| dansmith | abhishekk: right, that asserts the desired behavior when rbac rules are applied, and I assume they're failing because with the new stuff we're not honoring things exactly like those expect | 14:28 |
| abhishekk | ack | 14:28 |
| abhishekk | dansmith, do you think our changes has nothing to do with RBAC failures as it is failed on https://review.opendev.org/c/openstack/glance/+/789914 this patch as well ? | 14:37 |
| dansmith | oh, hmm | 14:41 |
| dansmith | yeah I dunno, that probably is related.. I totally hadn't noticed that | 14:42 |
| dansmith | although... | 14:42 |
| abhishekk | I think this is something related to test changes I have made to read it from code than file | 14:42 |
| dansmith | many more tests are failing there than just PP so.. | 14:42 |
| dansmith | ahhhh, yeah, maybe so | 14:42 |
| abhishekk | will try to figure it out | 14:43 |
| dansmith | that actually might be most of the fails in the update patch.. so.. yeah :) | 14:48 |
| abhishekk | yes | 14:49 |
| abhishekk | so for example, this test is failing, test_owning_tenant_id_can_retrieve_image_information | 14:58 |
| abhishekk | which is passing own set of rules in test and not using defaults from the code | 14:58 |
| * abhishekk going for dinner | 15:30 | |
| abhishekk | dansmith, probably, found the failure | 17:48 |
| dansmith | supershekk! | 17:51 |
| abhishekk | took reference from your patches only :P | 17:58 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/796067/10/glance/tests/functional/serial/test_scrubber.py | 17:58 |
| abhishekk | we need to pass reader role wherever required | 17:59 |
| abhishekk | so if you look closely below this level lots of tests are failing but after this patch there are comparatively less failures | 17:59 |
| dansmith | ack, cool | 18:00 |
| abhishekk | I will push wip patch, but you need to remove reader related changes from this patch | 18:01 |
| abhishekk | or else on top of all, I can push a patch to fix reamining failures | 18:01 |
| dansmith | you just mean rebase my patches on your fix, right? | 18:02 |
| abhishekk | nah | 18:02 |
| abhishekk | If i push a separate patch to make our functional tests compatible with RBAC then your above patch will go in merge conflict if you rebase it with my patch | 18:03 |
| dansmith | well, I meant "rebase and fix conflicts" :) | 18:04 |
| abhishekk | aaah :D | 18:04 |
| dansmith | but I think we should fix the current situation first, so I would base your fix on master | 18:04 |
| abhishekk | ack, let me push some revision so that you will get idea | 18:05 |
| dansmith | okay | 18:05 |
| *** timburke_ is now known as timburke | 18:12 | |
| abhishekk | may be it will take some more time for me to put up a patch, will do it tomorrow morning my time as its almost midnight now | 18:27 |
| dansmith | ack | 18:38 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Make our functional tests compatible with RBAC https://review.opendev.org/c/openstack/glance/+/800822 | 19:07 |
| abhishekk | dansmith, ^^ | 19:08 |
| dansmith | I thought you were going to sleep? | 19:08 |
| abhishekk | will sleep peacefully now :D | 19:09 |
| dansmith | hah okay | 19:09 |
| dansmith | g'nite | 19:09 |
| abhishekk | thank you, good day | 19:10 |
| abhishekk | we can abandon this patch and push another patch on top of all the chain to fix 3 failing tests to avoid conflicts | 19:16 |
| abhishekk | passing in the gate/zuul now | 19:21 |
| dansmith | ah right, but I already clean up images at the end of each test because I have to for quota | 19:31 |
| dansmith | or do I need to also clean up via addCleanup in case of fail? | 19:32 |
| opendevreview | Dan Smith proposed openstack/glance master: Make property protection tests use member role https://review.opendev.org/c/openstack/glance/+/789914 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: Move lazy store update to locations layer https://review.opendev.org/c/openstack/glance/+/797722 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove dead 403->404 code https://review.opendev.org/c/openstack/glance/+/799699 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: Refactor gateway get_repo auth layer https://review.opendev.org/c/openstack/glance/+/789913 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Make image update check policy at API layer https://review.opendev.org/c/openstack/glance/+/789915 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Add a member field to Image when appropriate https://review.opendev.org/c/openstack/glance/+/796066 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check get_image(s) in the API https://review.opendev.org/c/openstack/glance/+/796067 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check delete_image policy in the API https://review.opendev.org/c/openstack/glance/+/798073 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Check deactivate, reactivate policy in the API https://review.opendev.org/c/openstack/glance/+/798266 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC Refactor gateway auth layer for metadef APIs https://review.opendev.org/c/openstack/glance/+/799632 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef namepsace policy checks in the API https://review.opendev.org/c/openstack/glance/+/799633 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef object policy checks in the API https://review.opendev.org/c/openstack/glance/+/799634 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef property policy checks in the API https://review.opendev.org/c/openstack/glance/+/799635 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef tag policy checks in the API https://review.opendev.org/c/openstack/glance/+/799636 | 19:33 |
| opendevreview | Dan Smith proposed openstack/glance master: POC: Move metadef resource type association policy checks in the API https://review.opendev.org/c/openstack/glance/+/799637 | 19:33 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!