*** ianw has joined #openstack-glance | 00:11 | |
*** tosky has quit IRC | 01:02 | |
*** zzzeek has quit IRC | 02:09 | |
*** zzzeek has joined #openstack-glance | 02:11 | |
*** zzzeek has quit IRC | 02:36 | |
*** zzzeek has joined #openstack-glance | 02:39 | |
*** rcernin has quit IRC | 02:50 | |
*** rcernin has joined #openstack-glance | 02:55 | |
*** udesale has joined #openstack-glance | 02:58 | |
*** rcernin has quit IRC | 03:12 | |
*** ricolin has quit IRC | 03:26 | |
*** rcernin has joined #openstack-glance | 03:31 | |
*** rcernin has quit IRC | 03:34 | |
*** rcernin has joined #openstack-glance | 03:34 | |
*** ratailor has joined #openstack-glance | 04:59 | |
*** whoami-rajat_ has joined #openstack-glance | 05:13 | |
*** m75abrams has joined #openstack-glance | 05:15 | |
*** k_mouza has joined #openstack-glance | 05:16 | |
*** k_mouza has quit IRC | 05:21 | |
*** lpetrut has joined #openstack-glance | 07:03 | |
*** k_mouza has joined #openstack-glance | 07:12 | |
*** ralonsoh has joined #openstack-glance | 07:13 | |
*** k_mouza has quit IRC | 07:16 | |
*** rcernin has quit IRC | 07:17 | |
*** priteau has joined #openstack-glance | 08:17 | |
*** tosky has joined #openstack-glance | 08:53 | |
*** k_mouza has joined #openstack-glance | 09:12 | |
*** k_mouza has quit IRC | 09:16 | |
*** rcernin has joined #openstack-glance | 09:36 | |
*** rcernin has quit IRC | 09:40 | |
*** k_mouza has joined #openstack-glance | 09:56 | |
*** xarlos has joined #openstack-glance | 10:20 | |
*** openstackgerrit has quit IRC | 10:43 | |
*** udesale_ has joined #openstack-glance | 10:57 | |
*** udesale has quit IRC | 11:00 | |
*** k_mouza has quit IRC | 11:02 | |
*** k_mouza_ has joined #openstack-glance | 11:02 | |
*** rosmaita has joined #openstack-glance | 12:21 | |
*** k_mouza_ has quit IRC | 12:50 | |
*** k_mouza has joined #openstack-glance | 12:50 | |
*** ricolin has joined #openstack-glance | 12:51 | |
*** Luzi has joined #openstack-glance | 12:55 | |
*** ricolin has quit IRC | 13:15 | |
dansmith | abhishekk: so are we good with this? https://review.opendev.org/c/openstack/glance/+/780104 | 13:28 |
---|---|---|
dansmith | presumably needs a reno? | 13:28 |
dansmith | I need to look at what tests we might have in the tree that I can extend | 13:28 |
abhishekk | dansmith, as discussed and responses we have received it is clear that initially metadef APIs has been designed to be used by Admin only and whoever using it so far restricting them for admin only | 13:36 |
abhishekk | So IMO we are good with this approach, reno will be good to have and also does this patch needs SecurityImpact tag ? | 13:37 |
dansmith | ack, probably | 13:37 |
dansmith | even with the test policy set to admin those tests still pass, which is weird | 13:38 |
abhishekk | ohh, need to have better look then | 13:39 |
dansmith | it might be that they don't actually test much in the way of creation things, but... there are delete tests.. | 13:39 |
abhishekk | ok | 13:39 |
abhishekk | Between we managed to release Glance M3 today | 13:40 |
dansmith | I saw it got approved, that's sweet :) | 13:40 |
abhishekk | so thank you all for your hardwork and efforts | 13:40 |
abhishekk | \o/ | 13:40 |
dansmith | and you :) | 13:42 |
abhishekk | :) | 13:43 |
*** ricolin has joined #openstack-glance | 13:45 | |
*** smcginnis has joined #openstack-glance | 13:50 | |
*** openstackgerrit has joined #openstack-glance | 14:00 | |
openstackgerrit | Merged openstack/python-glanceclient stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/python-glanceclient/+/779956 | 14:00 |
openstackgerrit | Merged openstack/python-glanceclient master: Update master for stable/wallaby https://review.opendev.org/c/openstack/python-glanceclient/+/779958 | 14:01 |
*** ratailor has quit IRC | 14:02 | |
*** Luzi has quit IRC | 14:04 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance-specs master: Add xena directory for specs https://review.opendev.org/c/openstack/glance-specs/+/778608 | 14:32 |
openstackgerrit | Dan Smith proposed openstack/glance master: Make some metadef operations admin-only https://review.opendev.org/c/openstack/glance/+/780104 | 14:46 |
dansmith | ah, I just saw lbragstad's comment, will look at the docs | 14:47 |
openstackgerrit | Dan Smith proposed openstack/glance master: Make some metadef operations admin-only https://review.opendev.org/c/openstack/glance/+/780104 | 14:59 |
abhishekk | Looks good to me, will wait for test results | 15:10 |
* dansmith nods | 15:14 | |
openstackgerrit | Merged openstack/python-glanceclient master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/python-glanceclient/+/779959 | 15:16 |
*** lpetrut has quit IRC | 15:16 | |
openstackgerrit | Merged openstack/python-glanceclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/python-glanceclient/+/779957 | 15:16 |
openstackgerrit | Merged openstack/glance-specs master: Add xena directory for specs https://review.opendev.org/c/openstack/glance-specs/+/778608 | 15:21 |
dansmith | abhishekk: I forget what this means: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1e2/780104/6/check/glance-code-constants-check/1e20b8b/testr_results.html | 15:27 |
abhishekk | looking | 15:28 |
abhishekk | something related to this, https://review.opendev.org/c/openstack/glance/+/771907/2/glance/db/migration.py | 15:29 |
abhishekk | Not sure why it is failing at this moment | 15:30 |
abhishekk | messed up with release patch :/ | 15:34 |
dansmith | okay I figured it had to be related to that, something with the "current release" but.. didn't know | 15:35 |
abhishekk | added you as a reviewer | 15:36 |
dansmith | yikes | 15:37 |
dansmith | I wonder if that released wallaby as victoria? | 15:37 |
dansmith | I definitely just looked at the hash and didn't notice the version obviously.. makes me not a good reviewer :/ | 15:38 |
abhishekk | I guess no one has verified from glance side for the hash | 15:39 |
abhishekk | https://review.opendev.org/c/openstack/releases/+/780477 :( | 15:39 |
dansmith | the hash looks okay right? | 15:40 |
dansmith | just not the version number | 15:40 |
abhishekk | hash is correct | 15:40 |
dansmith | yeah, I looked at the hash from email, but it was approved before I got to it | 15:40 |
abhishekk | hmm | 15:41 |
dansmith | but I bet I wouldn't have noticed anyway | 15:41 |
dansmith | I mean.. I didn't notice | 15:41 |
abhishekk | every cycle in last minute something goes wrong by me :( | 15:42 |
dansmith | I'm sure this is not a huge deal :) | 15:42 |
dansmith | and, this is what the reviewers are supposed to catch | 15:42 |
abhishekk | I have added checklist but every time I do the new mistake | 15:42 |
dansmith | shall we go to -release to ask what to do? | 15:42 |
abhishekk | right | 15:43 |
dansmith | herve is rebooting, wait a sec | 15:43 |
abhishekk | ack | 15:44 |
abhishekk | smcginnis, around? | 15:44 |
*** m75abrams has quit IRC | 15:55 | |
*** ajitha has joined #openstack-glance | 16:11 | |
*** hoonetorg has quit IRC | 16:20 | |
*** jdillaman has joined #openstack-glance | 16:20 | |
*** whoami-rajat_ is now known as whoami-rajat | 16:52 | |
*** udesale_ has quit IRC | 17:08 | |
*** dasp_ has joined #openstack-glance | 17:10 | |
*** dasp has quit IRC | 17:14 | |
*** k_mouza has quit IRC | 17:21 | |
*** k_mouza has joined #openstack-glance | 17:21 | |
*** felixhuettner[m] has quit IRC | 18:03 | |
*** k_mouza has quit IRC | 18:04 | |
*** felixhuettner[m] has joined #openstack-glance | 18:05 | |
*** felixhuettner[m] has quit IRC | 18:09 | |
openstackgerrit | Dan Smith proposed openstack/glance master: Fix a typo in contributor docs https://review.opendev.org/c/openstack/glance/+/780652 | 18:27 |
dansmith | smcginnis: can you ninja that ^ so we can have a new hash for the release fix? If not I'll just do it | 18:28 |
*** felixhuettner[m] has joined #openstack-glance | 18:38 | |
*** smcginnis has quit IRC | 18:53 | |
rosmaita | dansmith: got it (that was my typo) | 18:55 |
dansmith | rosmaita: thanks | 18:55 |
dansmith | rosmaita: we might need a new hash to release for m3 because of a little version number snafu, | 18:55 |
dansmith | so that was identified as a good wont-run-tests candidate :) | 18:56 |
dansmith | so... thanks for the typo and the approval :P | 18:56 |
rosmaita | clever | 18:56 |
*** freefood_ has joined #openstack-glance | 19:10 | |
*** freefood has quit IRC | 19:11 | |
*** whoami-rajat has quit IRC | 19:12 | |
*** freefood_ has quit IRC | 19:31 | |
*** takamatsu has quit IRC | 19:32 | |
*** freefood_ has joined #openstack-glance | 19:32 | |
*** takamatsu has joined #openstack-glance | 19:33 | |
*** smcginnis has joined #openstack-glance | 19:39 | |
*** jv_ has quit IRC | 20:56 | |
*** lbragstad has quit IRC | 20:56 | |
*** lyr has quit IRC | 20:58 | |
*** freerunner has quit IRC | 20:58 | |
*** jv_ has joined #openstack-glance | 20:58 | |
*** lbragstad has joined #openstack-glance | 20:58 | |
*** lyr has joined #openstack-glance | 20:58 | |
*** freerunner has joined #openstack-glance | 20:58 | |
*** freerunner has quit IRC | 21:00 | |
*** freerunner has joined #openstack-glance | 21:04 | |
*** lbragstad has quit IRC | 21:24 | |
*** lbragstad has joined #openstack-glance | 21:28 | |
openstackgerrit | Merged openstack/glance master: Fix a typo in contributor docs https://review.opendev.org/c/openstack/glance/+/780652 | 21:37 |
*** rcernin has joined #openstack-glance | 21:57 | |
*** smcginnis has quit IRC | 22:28 | |
*** xarlos has quit IRC | 23:33 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!