*** zzzeek has quit IRC | 00:17 | |
*** zzzeek has joined #openstack-glance | 00:18 | |
*** tosky has quit IRC | 00:42 | |
*** ricolin has quit IRC | 00:46 | |
*** ricolin has joined #openstack-glance | 00:50 | |
*** benj_ has joined #openstack-glance | 00:54 | |
*** benj_ has quit IRC | 01:01 | |
*** benj_ has joined #openstack-glance | 01:02 | |
*** rcernin has quit IRC | 01:12 | |
*** rcernin_ has joined #openstack-glance | 01:12 | |
*** benj_ has quit IRC | 01:17 | |
*** benj_ has joined #openstack-glance | 01:17 | |
*** benj_ has quit IRC | 02:06 | |
*** benj_ has joined #openstack-glance | 02:07 | |
*** k_mouza has joined #openstack-glance | 02:15 | |
*** k_mouza has quit IRC | 02:19 | |
*** zzzeek has quit IRC | 02:44 | |
*** zzzeek has joined #openstack-glance | 02:47 | |
*** zzzeek has quit IRC | 03:10 | |
*** zzzeek has joined #openstack-glance | 03:12 | |
*** rcernin_ has quit IRC | 03:14 | |
*** rcernin_ has joined #openstack-glance | 03:21 | |
*** zzzeek has quit IRC | 04:02 | |
*** zzzeek has joined #openstack-glance | 04:04 | |
*** udesale has joined #openstack-glance | 04:34 | |
*** k_mouza has joined #openstack-glance | 04:50 | |
*** k_mouza has quit IRC | 04:55 | |
*** ratailor has joined #openstack-glance | 05:05 | |
*** ajitha has joined #openstack-glance | 05:26 | |
*** zzzeek has quit IRC | 05:26 | |
*** zzzeek has joined #openstack-glance | 05:29 | |
*** k_mouza has joined #openstack-glance | 05:42 | |
*** k_mouza has quit IRC | 05:47 | |
*** zzzeek has quit IRC | 06:03 | |
*** zzzeek has joined #openstack-glance | 06:05 | |
*** m75abrams has joined #openstack-glance | 06:36 | |
*** ratailor_ has joined #openstack-glance | 06:41 | |
*** ratailor__ has joined #openstack-glance | 06:44 | |
*** ratailor has quit IRC | 06:44 | |
*** ratailor_ has quit IRC | 06:48 | |
*** ratailor_ has joined #openstack-glance | 06:52 | |
*** ratailor__ has quit IRC | 06:57 | |
*** rcernin_ has quit IRC | 07:14 | |
*** ralonsoh has joined #openstack-glance | 07:23 | |
*** lpetrut has joined #openstack-glance | 07:24 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Implement project personas for image actions https://review.opendev.org/c/openstack/glance/+/764754 | 07:27 |
---|---|---|
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Deprecate the external task API policies https://review.opendev.org/c/openstack/glance/+/763208 | 07:27 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Add API version 2.13 https://review.opendev.org/c/openstack/glance/+/779163 | 07:27 |
*** fnordahl has quit IRC | 07:39 | |
*** fnordahl has joined #openstack-glance | 07:39 | |
*** k_mouza has joined #openstack-glance | 07:43 | |
abhishekk | Just FYI, I have applied for PTL candidacy for Xena | 07:45 |
*** k_mouza has quit IRC | 07:48 | |
openstackgerrit | Felix Huettner proposed openstack/glance master: Fix users being able to delete disabled images https://review.opendev.org/c/openstack/glance/+/778951 | 07:54 |
*** whoami-rajat_ has joined #openstack-glance | 08:26 | |
*** tosky has joined #openstack-glance | 08:34 | |
*** udesale has quit IRC | 08:57 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Refresh Glance example configs for Wallaby milestone 3 https://review.opendev.org/c/openstack/glance/+/779181 | 09:02 |
*** Luzi has joined #openstack-glance | 09:31 | |
*** udesale has joined #openstack-glance | 09:31 | |
*** k_mouza has joined #openstack-glance | 09:37 | |
*** k_mouza has quit IRC | 09:42 | |
*** k_mouza has joined #openstack-glance | 09:58 | |
*** mugsie__ is now known as mugsie | 10:11 | |
*** rosmaita has quit IRC | 12:39 | |
*** lpetrut has quit IRC | 12:44 | |
*** rosmaita has joined #openstack-glance | 12:53 | |
*** lpetrut has joined #openstack-glance | 13:09 | |
openstackgerrit | Lance Bragstad proposed openstack/glance master: trivial: Fix minor grammatical issues in cache middleware https://review.opendev.org/c/openstack/glance/+/779260 | 13:48 |
openstackgerrit | Lance Bragstad proposed openstack/glance master: trivial: remove unnecessary grouping in base policies https://review.opendev.org/c/openstack/glance/+/779266 | 13:59 |
*** ratailor_ has quit IRC | 14:02 | |
*** mnaser has quit IRC | 14:03 | |
*** mnaser has joined #openstack-glance | 14:03 | |
*** mnaser has quit IRC | 14:03 | |
*** mnaser has joined #openstack-glance | 14:03 | |
openstackgerrit | Lance Bragstad proposed openstack/glance master: Add a release note for secure RBAC project personas https://review.opendev.org/c/openstack/glance/+/779070 | 14:25 |
*** jv_ has quit IRC | 14:30 | |
*** jv_ has joined #openstack-glance | 14:42 | |
*** Luzi has quit IRC | 14:49 | |
abhishekk | Waiting time is gate :/ | 15:05 |
dansmith | housekeeping patch's remaining time is >24h :/ | 15:09 |
dansmith | seems like that can't be right, but also not a good sign | 15:09 |
abhishekk | yeah | 15:11 |
abhishekk | One day one patch | 15:11 |
dansmith | lbragstad: I think that abhishekk and I can probably handle whatever tweaks to your stack at this point, deciding on voting and deprecation and such | 15:11 |
* lbragstad nods | 15:12 | |
lbragstad | that would be awesome | 15:12 |
dansmith | lbragstad: assuming you need to be focusing on cinder or other things, we can poke you specifically if we need something but otherwise I think we're probably okay, agree abhishekk ? | 15:12 |
abhishekk | ++ | 15:12 |
lbragstad | yeah - i have to start testing everything in cinder, or at least filling out the tests | 15:12 |
dansmith | lbragstad: let me know so I can put on my nuclear blast goggles first | 15:13 |
abhishekk | we need a plan to get these patches in | 15:13 |
lbragstad | you should probably head to the bunker now to get ahead of the rush | 15:13 |
abhishekk | I think we still have next week to tag M3 | 15:13 |
dansmith | lbragstad: heh | 15:14 |
dansmith | abhishekk: right, we need to get them in I was just saying I think we can shepherd/tweak them ourselves so lbragstad can focus on other things | 15:15 |
dansmith | abhishekk: sounds like you want to drop the deprecation wording from the tasks patch, so I can do that | 15:15 |
abhishekk | yes | 15:15 |
dansmith | I'm also a little worried that I've seen copy_image_lifecycle fail a couple of times now, on a task assertion | 15:16 |
dansmith | like the housekeeping module just failed that | 15:16 |
abhishekk | I think we should also drop api version bump as we are dealing with only project scope | 15:16 |
dansmith | cool, I'll drop that out of the stack | 15:16 |
abhishekk | I will abandon it | 15:17 |
abhishekk | I think task lock is not releasing in time | 15:18 |
*** zzzeek has quit IRC | 15:19 | |
dansmith | for the copy_image test? | 15:19 |
abhishekk | yeah, think so | 15:20 |
dansmith | okay, I haven't looked yet, I just saw it's complaining about the number of tasks, so I figure it's a timing thing as you say | 15:20 |
*** zzzeek has joined #openstack-glance | 15:21 | |
dansmith | abhishekk: I'm just now reading the task policy descriptions in this deprecation patch.. let me add some comments for you to validate before I update the patch | 15:21 |
abhishekk | ack | 15:22 |
dansmith | abhishekk: https://review.opendev.org/c/openstack/glance/+/763208 | 15:26 |
abhishekk | looking | 15:27 |
*** lpetrut has quit IRC | 15:32 | |
*** udesale has quit IRC | 15:33 | |
abhishekk | dansmith, replied, little bit confusion about task_api_access policy | 15:40 |
dansmith | abhishekk: which confusion? you seem unconfused, and confirmed my assumptions :) | 15:41 |
dansmith | abhishekk: so I think I'm good, but, what do you want to do about modify_task | 15:41 |
abhishekk | I need to find out where actually it gets enforced | 15:42 |
lbragstad | the policy tasks? | 15:45 |
lbragstad | i'm pretty sure the only thing that cares about those is glance.api.policy | 15:45 |
dansmith | lbragstad: modify_task specifically, but I don't see it enforced anywhere, just defined in the policy/tasks module | 15:46 |
lbragstad | https://github.com/openstack/glance/blob/master/glance/api/policy.py#L367-L369 ? | 15:48 |
lbragstad | maybe i'm in left field | 15:48 |
dansmith | oh | 15:48 |
dansmith | I guess I missed that in my grep somehow | 15:48 |
dansmith | oh and I just re-read your note in the patch that it's not used anywhere in the tasks _API_ | 15:49 |
dansmith | but is likely touched when we internally save a task | 15:49 |
abhishekk | right, its not used anywhere than in test | 15:49 |
lbragstad | yeah - at least based on what i understand, which may not be a whole lot ;) | 15:50 |
*** m75abrams has quit IRC | 15:50 | |
lbragstad | the task_api_access policy protects the external task API | 15:50 |
dansmith | abhishekk: do we not go through TaskRepoProxy when we save() the task to update the message? | 15:51 |
dansmith | straight to TaskRepo? | 15:51 |
abhishekk | _task_update is calling .save | 15:51 |
abhishekk | I need to confirm, this onion always confuses me | 15:52 |
dansmith | abhishekk: regardless, do we want to keep the deprecation for that policy? | 15:52 |
dansmith | if there's nothing in the API that would use it, there's no point in having it I think, even after we clean things up for the add/get, etc | 15:53 |
abhishekk | I don't think we need that policy anymore | 15:53 |
abhishekk | right | 15:53 |
dansmith | okay will leave the deprecation stuff for it then | 15:53 |
abhishekk | yep | 15:53 |
abhishekk | so modify_task policy is not linked to any of the external API or it does not have associated task API (like PUT) it is safe to deprecate and remove it | 15:59 |
dansmith | yep | 15:59 |
*** gmann is now known as gmann_afk | 16:01 | |
openstackgerrit | Dan Smith proposed openstack/glance master: Update the task policies https://review.opendev.org/c/openstack/glance/+/763208 | 16:01 |
dansmith | abhishekk: how's that? ^ | 16:02 |
abhishekk | looking | 16:02 |
abhishekk | Perfect | 16:04 |
abhishekk | Commit message itself explains what we are doing | 16:04 |
dansmith | cool | 16:05 |
*** ajitha has quit IRC | 16:15 | |
*** ajitha has joined #openstack-glance | 16:41 | |
abhishekk | dansmith, so we can avoid rechecking trivial patches at the moment | 16:47 |
dansmith | abhishekk: the qa block won't affect most of our patches, if that's what you mean.. | 16:48 |
abhishekk | I am saying lance submitted couple of patches to correct grammatical errors, we can avoid rechecking those now | 16:49 |
dansmith | oh sure | 16:49 |
* abhishekk going for dinner | 16:50 | |
openstackgerrit | Dan Smith proposed openstack/glance master: Update the task policies https://review.opendev.org/c/openstack/glance/+/763208 | 17:32 |
abhishekk | after 8 hours of wait, houskeeping failed again :/ | 17:42 |
* abhishekk signing out for the day | 18:36 | |
dansmith | o/ | 18:47 |
*** k_mouza has quit IRC | 19:08 | |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure https://review.opendev.org/c/openstack/glance/+/779348 | 19:10 |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure https://review.opendev.org/c/openstack/glance/+/779348 | 19:12 |
*** stand has quit IRC | 19:15 | |
*** stand has joined #openstack-glance | 19:22 | |
*** gmann_afk is now known as gmann | 19:32 | |
*** whoami-rajat_ is now known as whoami-rajat | 19:44 | |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure https://review.opendev.org/c/openstack/glance/+/779348 | 20:15 |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure https://review.opendev.org/c/openstack/glance/+/779348 | 20:28 |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure https://review.opendev.org/c/openstack/glance/+/779348 | 20:42 |
*** gyee has joined #openstack-glance | 20:56 | |
*** k_mouza has joined #openstack-glance | 21:08 | |
*** k_mouza has quit IRC | 21:13 | |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure https://review.opendev.org/c/openstack/glance/+/779348 | 21:13 |
openstackgerrit | Dan Smith proposed openstack/glance master: Fix erroneous exit from copy wait loop https://review.opendev.org/c/openstack/glance/+/779369 | 21:31 |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure https://review.opendev.org/c/openstack/glance/+/779348 | 21:32 |
*** rcernin has joined #openstack-glance | 21:54 | |
*** whoami-rajat has quit IRC | 22:06 | |
*** ajitha has quit IRC | 22:35 | |
*** zzzeek has quit IRC | 23:08 | |
*** zzzeek has joined #openstack-glance | 23:12 | |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure https://review.opendev.org/c/openstack/glance/+/779348 | 23:26 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!