Monday, 2021-03-08

*** zzzeek has quit IRC00:17
*** zzzeek has joined #openstack-glance00:18
*** tosky has quit IRC00:42
*** ricolin has quit IRC00:46
*** ricolin has joined #openstack-glance00:50
*** benj_ has joined #openstack-glance00:54
*** benj_ has quit IRC01:01
*** benj_ has joined #openstack-glance01:02
*** rcernin has quit IRC01:12
*** rcernin_ has joined #openstack-glance01:12
*** benj_ has quit IRC01:17
*** benj_ has joined #openstack-glance01:17
*** benj_ has quit IRC02:06
*** benj_ has joined #openstack-glance02:07
*** k_mouza has joined #openstack-glance02:15
*** k_mouza has quit IRC02:19
*** zzzeek has quit IRC02:44
*** zzzeek has joined #openstack-glance02:47
*** zzzeek has quit IRC03:10
*** zzzeek has joined #openstack-glance03:12
*** rcernin_ has quit IRC03:14
*** rcernin_ has joined #openstack-glance03:21
*** zzzeek has quit IRC04:02
*** zzzeek has joined #openstack-glance04:04
*** udesale has joined #openstack-glance04:34
*** k_mouza has joined #openstack-glance04:50
*** k_mouza has quit IRC04:55
*** ratailor has joined #openstack-glance05:05
*** ajitha has joined #openstack-glance05:26
*** zzzeek has quit IRC05:26
*** zzzeek has joined #openstack-glance05:29
*** k_mouza has joined #openstack-glance05:42
*** k_mouza has quit IRC05:47
*** zzzeek has quit IRC06:03
*** zzzeek has joined #openstack-glance06:05
*** m75abrams has joined #openstack-glance06:36
*** ratailor_ has joined #openstack-glance06:41
*** ratailor__ has joined #openstack-glance06:44
*** ratailor has quit IRC06:44
*** ratailor_ has quit IRC06:48
*** ratailor_ has joined #openstack-glance06:52
*** ratailor__ has quit IRC06:57
*** rcernin_ has quit IRC07:14
*** ralonsoh has joined #openstack-glance07:23
*** lpetrut has joined #openstack-glance07:24
openstackgerritAbhishek Kekane proposed openstack/glance master: Implement project personas for image actions  https://review.opendev.org/c/openstack/glance/+/76475407:27
openstackgerritAbhishek Kekane proposed openstack/glance master: Deprecate the external task API policies  https://review.opendev.org/c/openstack/glance/+/76320807:27
openstackgerritAbhishek Kekane proposed openstack/glance master: Add API version 2.13  https://review.opendev.org/c/openstack/glance/+/77916307:27
*** fnordahl has quit IRC07:39
*** fnordahl has joined #openstack-glance07:39
*** k_mouza has joined #openstack-glance07:43
abhishekkJust FYI, I have applied for PTL candidacy for Xena07:45
*** k_mouza has quit IRC07:48
openstackgerritFelix Huettner proposed openstack/glance master: Fix users being able to delete disabled images  https://review.opendev.org/c/openstack/glance/+/77895107:54
*** whoami-rajat_ has joined #openstack-glance08:26
*** tosky has joined #openstack-glance08:34
*** udesale has quit IRC08:57
openstackgerritAbhishek Kekane proposed openstack/glance master: Refresh Glance example configs for Wallaby milestone 3  https://review.opendev.org/c/openstack/glance/+/77918109:02
*** Luzi has joined #openstack-glance09:31
*** udesale has joined #openstack-glance09:31
*** k_mouza has joined #openstack-glance09:37
*** k_mouza has quit IRC09:42
*** k_mouza has joined #openstack-glance09:58
*** mugsie__ is now known as mugsie10:11
*** rosmaita has quit IRC12:39
*** lpetrut has quit IRC12:44
*** rosmaita has joined #openstack-glance12:53
*** lpetrut has joined #openstack-glance13:09
openstackgerritLance Bragstad proposed openstack/glance master: trivial: Fix minor grammatical issues in cache middleware  https://review.opendev.org/c/openstack/glance/+/77926013:48
openstackgerritLance Bragstad proposed openstack/glance master: trivial: remove unnecessary grouping in base policies  https://review.opendev.org/c/openstack/glance/+/77926613:59
*** ratailor_ has quit IRC14:02
*** mnaser has quit IRC14:03
*** mnaser has joined #openstack-glance14:03
*** mnaser has quit IRC14:03
*** mnaser has joined #openstack-glance14:03
openstackgerritLance Bragstad proposed openstack/glance master: Add a release note for secure RBAC project personas  https://review.opendev.org/c/openstack/glance/+/77907014:25
*** jv_ has quit IRC14:30
*** jv_ has joined #openstack-glance14:42
*** Luzi has quit IRC14:49
abhishekkWaiting time is gate :/15:05
dansmithhousekeeping patch's remaining time is >24h :/15:09
dansmithseems like that can't be right, but also not a good sign15:09
abhishekkyeah15:11
abhishekkOne day one patch15:11
dansmithlbragstad: I think that abhishekk and I can probably handle whatever tweaks to your stack at this point, deciding on voting and deprecation and such15:11
* lbragstad nods15:12
lbragstadthat would be awesome15:12
dansmithlbragstad: assuming you need to be focusing on cinder or other things, we can poke you specifically if we need something but otherwise I think we're probably okay, agree abhishekk ?15:12
abhishekk++15:12
lbragstadyeah - i have to start testing everything in cinder, or at least filling out the tests15:12
dansmithlbragstad: let me know so I can put on my nuclear blast goggles first15:13
abhishekkwe need a plan to get these patches in15:13
lbragstadyou should probably head to the bunker now to get ahead of the rush15:13
abhishekkI think we still have next week to tag M315:13
dansmithlbragstad: heh15:14
dansmithabhishekk: right, we need to get them in I was just saying I think we can shepherd/tweak them ourselves so lbragstad can focus on other things15:15
dansmithabhishekk: sounds like you want to drop the deprecation wording from the tasks patch, so I can do that15:15
abhishekkyes15:15
dansmithI'm also a little worried that I've seen copy_image_lifecycle fail a couple of times now, on a task assertion15:16
dansmithlike the housekeeping module just failed that15:16
abhishekkI think we should also drop api version bump as we are dealing with only project scope15:16
dansmithcool, I'll drop that out of the stack15:16
abhishekkI will abandon it15:17
abhishekkI think task lock is not releasing in time15:18
*** zzzeek has quit IRC15:19
dansmithfor the copy_image test?15:19
abhishekkyeah, think so15:20
dansmithokay, I haven't looked yet, I just saw it's complaining about the number of tasks, so I figure it's a timing thing as you say15:20
*** zzzeek has joined #openstack-glance15:21
dansmithabhishekk: I'm just now reading the task policy descriptions in this deprecation patch.. let me add some comments for you to validate before I update the patch15:21
abhishekkack15:22
dansmithabhishekk: https://review.opendev.org/c/openstack/glance/+/76320815:26
abhishekklooking15:27
*** lpetrut has quit IRC15:32
*** udesale has quit IRC15:33
abhishekkdansmith, replied, little bit confusion about task_api_access policy15:40
dansmithabhishekk: which confusion? you seem unconfused, and confirmed my assumptions :)15:41
dansmithabhishekk: so I think I'm good, but, what do you want to do about modify_task15:41
abhishekkI need to find out where actually it gets enforced15:42
lbragstadthe policy tasks?15:45
lbragstadi'm pretty sure the only thing that cares about those is glance.api.policy15:45
dansmithlbragstad: modify_task specifically, but I don't see it enforced anywhere, just defined in the policy/tasks module15:46
lbragstadhttps://github.com/openstack/glance/blob/master/glance/api/policy.py#L367-L369 ?15:48
lbragstadmaybe i'm in left field15:48
dansmithoh15:48
dansmithI guess I missed that in my grep somehow15:48
dansmithoh and I just re-read your note in the patch that it's not used anywhere in the tasks _API_15:49
dansmithbut is likely touched when we internally save a task15:49
abhishekkright, its not used anywhere than in test15:49
lbragstadyeah - at least based on what i understand, which may not be a whole lot ;)15:50
*** m75abrams has quit IRC15:50
lbragstadthe task_api_access policy protects the external task API15:50
dansmithabhishekk: do we not go through TaskRepoProxy when we save() the task to update the message?15:51
dansmithstraight to TaskRepo?15:51
abhishekk_task_update is calling .save15:51
abhishekkI need to confirm, this onion always confuses me15:52
dansmithabhishekk: regardless, do we want to keep the deprecation for that policy?15:52
dansmithif there's nothing in the API that would use it, there's no point in having it I think, even after we clean things up for the add/get, etc15:53
abhishekkI don't think we need that policy anymore15:53
abhishekkright15:53
dansmithokay will leave the deprecation stuff for it then15:53
abhishekkyep15:53
abhishekkso modify_task policy is not linked to any of the external API or it does not have associated task API (like PUT) it is safe to deprecate and remove it15:59
dansmithyep15:59
*** gmann is now known as gmann_afk16:01
openstackgerritDan Smith proposed openstack/glance master: Update the task policies  https://review.opendev.org/c/openstack/glance/+/76320816:01
dansmithabhishekk: how's that? ^16:02
abhishekklooking16:02
abhishekkPerfect16:04
abhishekkCommit message itself explains what we are doing16:04
dansmithcool16:05
*** ajitha has quit IRC16:15
*** ajitha has joined #openstack-glance16:41
abhishekkdansmith, so we can avoid rechecking trivial patches at the moment16:47
dansmithabhishekk: the qa block won't affect most of our patches, if that's what you mean..16:48
abhishekkI am saying lance submitted couple of patches to correct grammatical errors, we can avoid rechecking those now16:49
dansmithoh sure16:49
* abhishekk going for dinner16:50
openstackgerritDan Smith proposed openstack/glance master: Update the task policies  https://review.opendev.org/c/openstack/glance/+/76320817:32
abhishekkafter 8 hours of wait, houskeeping failed again :/17:42
* abhishekk signing out for the day18:36
dansmitho/18:47
*** k_mouza has quit IRC19:08
openstackgerritDan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure  https://review.opendev.org/c/openstack/glance/+/77934819:10
openstackgerritDan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure  https://review.opendev.org/c/openstack/glance/+/77934819:12
*** stand has quit IRC19:15
*** stand has joined #openstack-glance19:22
*** gmann_afk is now known as gmann19:32
*** whoami-rajat_ is now known as whoami-rajat19:44
openstackgerritDan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure  https://review.opendev.org/c/openstack/glance/+/77934820:15
openstackgerritDan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure  https://review.opendev.org/c/openstack/glance/+/77934820:28
openstackgerritDan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure  https://review.opendev.org/c/openstack/glance/+/77934820:42
*** gyee has joined #openstack-glance20:56
*** k_mouza has joined #openstack-glance21:08
*** k_mouza has quit IRC21:13
openstackgerritDan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure  https://review.opendev.org/c/openstack/glance/+/77934821:13
openstackgerritDan Smith proposed openstack/glance master: Fix erroneous exit from copy wait loop  https://review.opendev.org/c/openstack/glance/+/77936921:31
openstackgerritDan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure  https://review.opendev.org/c/openstack/glance/+/77934821:32
*** rcernin has joined #openstack-glance21:54
*** whoami-rajat has quit IRC22:06
*** ajitha has quit IRC22:35
*** zzzeek has quit IRC23:08
*** zzzeek has joined #openstack-glance23:12
openstackgerritDan Smith proposed openstack/glance master: DNM: Grab more details from copy-image failure  https://review.opendev.org/c/openstack/glance/+/77934823:26

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!