Tuesday, 2021-02-23

« Monday, 2021-02-22 Index Wednesday, 2021-02-24 »
openstackgerritDan Smith proposed openstack/glance master: Test restarting glance for staging cleanup  https://review.opendev.org/c/openstack/glance/+/77701401:45
*** benj_ has quit IRC01:53
*** benj_ has joined #openstack-glance01:54
*** ricolin has quit IRC03:15
*** ricolin has joined #openstack-glance03:30
*** udesale has joined #openstack-glance04:08
openstackgerritLance Bragstad proposed openstack/glance master: Implement project personas for image actions  https://review.opendev.org/c/openstack/glance/+/76475404:37
lbragstadabhishekk ^ that only contains the policy updates - i haven't completed the glance_tempest_plugin tests, yet04:37
lbragstadthat will pass tests, but it won't pass the glance_tempest_plugin tests because we'll need some changes from https://review.opendev.org/c/openstack/glance/+/77574104:38
*** ratailor has joined #openstack-glance04:46
*** rcernin has quit IRC05:15
*** rcernin has joined #openstack-glance05:22
*** udesale_ has joined #openstack-glance06:08
*** udesale has quit IRC06:11
*** gyee has quit IRC06:12
*** m75abrams has joined #openstack-glance06:20
*** zzzeek has quit IRC06:45
*** zzzeek has joined #openstack-glance06:46
*** rcernin has quit IRC07:15
*** ralonsoh has joined #openstack-glance07:21
*** udesale__ has joined #openstack-glance07:26
*** udesale_ has quit IRC07:30
*** smcginnis has quit IRC07:30
*** smcginnis has joined #openstack-glance07:30
*** hoonetorg has quit IRC07:38
*** zzzeek has quit IRC07:39
*** zzzeek has joined #openstack-glance07:40
*** rcernin has joined #openstack-glance07:49
*** udesale__ has quit IRC08:00
*** rcernin has quit IRC08:06
*** rcernin has joined #openstack-glance08:09
*** rcernin has quit IRC08:23
*** udesale has joined #openstack-glance09:06
*** udesale has quit IRC09:17
*** k_mouza has joined #openstack-glance09:27
*** nikparasyr has joined #openstack-glance09:29
*** lpetrut has joined #openstack-glance09:35
*** udesale has joined #openstack-glance09:53
*** udesale has quit IRC10:05
abhishekklbragstad, ack10:07
*** ajitha has joined #openstack-glance10:35
*** k_mouza has quit IRC10:49
*** k_mouza has joined #openstack-glance10:59
*** Luzi has joined #openstack-glance11:13
*** smcginnis has quit IRC11:19
*** smcginnis has joined #openstack-glance11:26
*** nikparasyr has left #openstack-glance11:48
*** jv_ has quit IRC11:52
*** smcginnis has quit IRC12:01
*** ratailor has quit IRC12:04
*** jv_ has joined #openstack-glance12:05
*** smcginnis has joined #openstack-glance12:07
*** jv_ has quit IRC12:24
openstackgerritErno Kuvaja proposed openstack/glance master: WIP: Staging refactor  https://review.opendev.org/c/openstack/glance/+/77701812:26
openstackgerritErno Kuvaja proposed openstack/glance master: WIP: Staging refactor  https://review.opendev.org/c/openstack/glance/+/77701812:30
*** rosmaita has quit IRC12:59
*** rosmaita has joined #openstack-glance13:00
aarentsHi glance, We hit this small bug: https://bugs.launchpad.net/glance-store/+bug/1885651 and propose a fix: https://review.opendev.org/c/openstack/glance_store/+/776611 if someone can have a look13:45
openstackLaunchpad bug 1885651 in glance_store "swift_store_endpoint doesn't override keystone catalog" [Undecided,In progress] - Assigned to Alexandre arents (aarents)13:45
*** udesale has joined #openstack-glance14:07
abhishekkaarents,  commented on the patch14:23
openstackgerritPavlo Shchelokovskyy proposed openstack/glance_store master: Do not loose url queries on redirects  https://review.opendev.org/c/openstack/glance_store/+/77713814:43
openstackgerritLance Bragstad proposed openstack/glance master: Bump requirements to prepare for secure RBAC  https://review.opendev.org/c/openstack/glance/+/76423614:48
openstackgerritLance Bragstad proposed openstack/glance master: Explicitly unset tempest_roles in devstack plugin  https://review.opendev.org/c/openstack/glance/+/77430814:50
openstackgerritLance Bragstad proposed openstack/glance master: Explicitly unset tempest_roles in devstack plugin  https://review.opendev.org/c/openstack/glance/+/77430814:51
openstackgerritPavlo Shchelokovskyy proposed openstack/glance_store master: Do not lose url queries on redirects  https://review.opendev.org/c/openstack/glance_store/+/77713814:51
openstackgerritLance Bragstad proposed openstack/glance master: Add basic/common personas to base policies  https://review.opendev.org/c/openstack/glance/+/76424114:54
*** jv_ has joined #openstack-glance14:58
*** udesale has quit IRC14:59
openstackgerritDan Smith proposed openstack/glance master: Add housekeeping module and staging cleaner  https://review.opendev.org/c/openstack/glance/+/77701214:59
openstackgerritDan Smith proposed openstack/glance master: Test restarting glance for staging cleanup  https://review.opendev.org/c/openstack/glance/+/77701414:59
aarentsabhishekk: thank you14:59
*** udesale has joined #openstack-glance15:00
openstackgerritDan Smith proposed openstack/glance master: Test restarting glance for staging cleanup  https://review.opendev.org/c/openstack/glance/+/77701415:14
*** Luzi has quit IRC15:15
*** tosky has joined #openstack-glance15:58
toskyhi! Can I please get a quick and painless +2 on this stable/train backport which moves a legacy job to native zuulv3? https://review.opendev.org/c/openstack/glance_store/+/74923515:58
* abhishekk away for dinner16:21
*** jdillaman has quit IRC16:28
*** lpetrut has quit IRC16:32
openstackgerritDan Smith proposed openstack/glance master: Add housekeeping module and staging cleaner  https://review.opendev.org/c/openstack/glance/+/77701216:33
openstackgerritDan Smith proposed openstack/glance master: Test restarting glance for staging cleanup  https://review.opendev.org/c/openstack/glance/+/77701416:33
*** m75abrams has quit IRC16:39
abhishekkdansmith, o/16:41
dansmithabhishekk: heya16:41
abhishekkI have one question related to housekeeping16:41
abhishekkmy staging directory has some data16:42
abhishekkbut image related to that is marked as deleted16:42
abhishekkso it will raise not found here;16:42
abhishekkhttps://review.opendev.org/c/openstack/glance/+/777012/5/glance/housekeeping.py#5416:42
abhishekkand then that data still remains there16:43
abhishekkI think we should get the list with show deleted = True if possible and clean that data as well16:44
dansmithabhishekk: if image_get() returns NotFound, we'll return False from that is_valid_image() and then go on to delete16:44
dansmithright?16:44
abhishekki confused it with not self.is_image_id16:45
abhishekkstrange that till some data is remaining in my staging directory16:46
abhishekki will debug it and find out the reason16:46
dansmithis it a valid uuid?16:47
abhishekkyep16:47
abhishekk28b04fbd-d80f-44e3-a1bb-1e127dbad63d16:47
abhishekkthis for example16:47
dansmithis that uuid in the database?16:47
abhishekkthat I need to check :D16:47
dansmithmaybe we're actually *not* getting not found there because we're using admin_context?16:47
abhishekkyes it is16:48
dansmithget_admin_context() has read_deleted=False by default, so I expect not, but you could check to see if you're actually hitting the NotFound there16:48
abhishekkwill check it16:48
dansmithI can add a deleted image to the test to check this16:48
abhishekklet me debug it quick16:49
abhishekkthough you might be faster than me16:49
dansmithwho me? :)16:51
abhishekk:D16:51
dansmithabhishekk: yep, looks like even with read_deleted=False, it's returning the image anyway16:52
abhishekkis_valid_image is returning true16:52
dansmither, show_deleted I mean16:52
abhishekkand adding it to ignore16:52
dansmithah,16:52
dansmithcan_see_deleted() is always true if admin16:53
dansmiththat's...odd16:53
abhishekkI guess it is16:53
openstackgerritDan Smith proposed openstack/glance master: Add housekeeping module and staging cleaner  https://review.opendev.org/c/openstack/glance/+/77701216:54
openstackgerritDan Smith proposed openstack/glance master: Test restarting glance for staging cleanup  https://review.opendev.org/c/openstack/glance/+/77701416:54
dansmithabhishekk: ^16:54
abhishekkdansmith, ack16:54
dansmithlbragstad: are you going to rev your series for things like abhishekk's blueprint link? if so, I'll hold off on going through those again16:56
dansmithalso looks like maybe there's some rebasing needing to be done16:56
abhishekkdansmith, now out of 5 2 were deleted, 1 was invalid image id and 2 are still there with one is uploading state and 1 is in queued state16:58
abhishekkso that sounds like working16:58
abhishekki just need to figure out about queued state because for uploading I can issue import call16:59
dansmithabhishekk: ack, cool16:59
dansmithI put a note there about checking state, but I think that if the image is not deleted, then the user's delete call will clean the staging area, so probably not needed17:00
abhishekk+117:00
abhishekkWorking in all aspects now17:01
dansmithsweet, I'm really glad we came around to agreement on this approach17:01
abhishekksame here17:02
openstackgerritPavlo Shchelokovskyy proposed openstack/glance_store master: Do not loose url queries on redirects  https://review.opendev.org/c/openstack/glance_store/+/77713817:02
*** udesale has quit IRC17:03
* abhishekk going offline for the day17:22
lbragstaddansmith yep - done17:31
lbragstadthe first 6 changes in that series (excluding yours) should be good to review17:31
openstackgerritLance Bragstad proposed openstack/glance master: Bump requirements to prepare for secure RBAC  https://review.opendev.org/c/openstack/glance/+/76423617:31
openstackgerritLance Bragstad proposed openstack/glance master: Explicitly unset tempest_roles in devstack plugin  https://review.opendev.org/c/openstack/glance/+/77430817:31
openstackgerritLance Bragstad proposed openstack/glance master: Add basic/common personas to base policies  https://review.opendev.org/c/openstack/glance/+/76424117:31
dansmithlbragstad: also just now saw your reply to my f-string hate.. didn't mean you had to change that, but amused that you did :P17:32
openstackgerritLance Bragstad proposed openstack/glance master: Properly handle InvalidScope exceptions  https://review.opendev.org/c/openstack/glance/+/77430917:32
openstackgerritLance Bragstad proposed openstack/glance master: Pass oslo.context RequestContext objects directly to policy enforcement  https://review.opendev.org/c/openstack/glance/+/76742517:32
openstackgerritLance Bragstad proposed openstack/glance master: Log an experimental warning at startup for secure RBAC  https://review.opendev.org/c/openstack/glance/+/77658817:32
lbragstaddansmith well - i actually pulled up a few articles trying to figure out why you hated them, so it was a learning experience17:32
dansmithhah17:33
lbragstadbut - i'm willing to be enlightened, because the people writing about them don't share your opinion ;)17:33
dansmithwell, some people certainly like them17:33
dansmithI think they make for crazy long strings and/or encourage you to use shorter less-clear variable names so that your strings won't be so long17:34
dansmithwhich makes things hard to eye-format17:34
lbragstadmmm - i can understand that17:34
dansmithnot to mention it seems dangerous to me, where if you typo something that doesn't format you might belch out some internal code you didn't mean to17:35
lbragstadisn't that also try if you do 'something external: %s' % self._private instead of 'something external: %s' % self.public_var ? or are you not a fan that approach either?17:36
lbragstadalso true*17:36
dansmithno, that's not what I meant17:37
dansmithIIRC, you can do crazy things like this in an f-string:17:37
dansmithf"Database error: server2_data[error.code].lie_about_forbidden" <- totally made up to look scary17:38
dansmither,17:38
lbragstadwith {}, right?17:38
dansmithf"Database error: {server2_data[error.code].lie_about_forbidden}" <- totally made up to look scary17:38
lbragstadahh - sure17:39
dansmithbut if you do something like forget/typo the last } you might expose that *code* in the string because it's not formatted17:39
dansmithwhereas the worst you might do elsewhere is leave a % instead of %s somewhere, or maybe %(err)s or something17:39
lbragstadgot - yeah, that makes sense17:40
*** k_mouza has quit IRC17:49
*** k_mouza has joined #openstack-glance17:49
dansmithlbragstad: I was previously +2 on that tempest plugin patch and abhi was already.. am I missing why that wasn't just +Wd at that point?18:15
lbragstaddansmith which one?18:16
lbragstadhttps://review.opendev.org/c/openstack/glance-tempest-plugin/+/773568/19 ?18:16
dansmithoh maybe because at the time there was the config thing underneath it and we were unsure about that?18:16
dansmithno, https://review.opendev.org/c/openstack/glance/+/77430818:16
lbragstadyeah - i rebased that because we pulled https://review.opendev.org/c/openstack/glance/+/776588/3 to the top of the stack instead of the bottom18:17
dansmithyeah, okay so that must be why I didn't +W at the time18:18
dansmithlbragstad: question here https://review.opendev.org/c/openstack/glance/+/77430918:23
openstackgerritErno Kuvaja proposed openstack/glance master: WIP: Staging refactor  https://review.opendev.org/c/openstack/glance/+/77701818:30
openstackgerritErno Kuvaja proposed openstack/glance master: Distributed image import  https://review.opendev.org/c/openstack/glance/+/77718318:30
*** lpetrut has joined #openstack-glance18:34
*** lpetrut has quit IRC18:40
*** k_mouza_ has joined #openstack-glance19:14
*** k_mouza_ has quit IRC19:17
*** k_mouza has quit IRC19:18
openstackgerritMerged openstack/glance master: Stop raising 403 when image is not found  https://review.opendev.org/c/openstack/glance/+/77543519:38
*** gmann is now known as gmann_lunch19:47
*** gmann_lunch is now known as gmann20:07
*** gyee has joined #openstack-glance20:14
*** zzzeek has quit IRC20:29
*** zzzeek has joined #openstack-glance20:31
*** rcernin has joined #openstack-glance20:44
*** sangeet has joined #openstack-glance20:56
sangeetI am trying to upload a large image (50GB) and I keep getting failure after some time. Seems one timeout is failing. Any idea how I can increase the timeout in glancelcient via cli command20:58
sangeethttps://github.com/openstack/python-glanceclient/blob/e8f427e1088b6de488bfa6af811d62415b073c34/glanceclient/common/http.py#L16721:01
*** rajinir has quit IRC21:01
sangeetI want to increase to more than 60021:01
*** rcernin has quit IRC21:01
*** rajinir has joined #openstack-glance21:02
*** knikolla has quit IRC21:11
*** knikolla has joined #openstack-glance21:11
*** k_mouza has joined #openstack-glance21:18
*** k_mouza has quit IRC21:23
*** ajitha has quit IRC21:24
sangeetAny help ^^21:25
*** rcernin has joined #openstack-glance21:46
*** sangeet has quit IRC21:57
*** rcernin has quit IRC21:57
*** rcernin has joined #openstack-glance21:57
lbragstaddansmith https://review.opendev.org/c/openstack/glance/+/774308/7 isn't needed anymore - but i'm ok with not disturbing the chain (again) and i can revert it - if that's cool22:06
dansmithlbragstad: oh like you literally want to abandon that?22:21
dansmithlbragstad: if so, just do it, rebase the stuff above and I'll re-+2 it22:21
openstackgerritLance Bragstad proposed openstack/glance master: Add basic/common personas to base policies  https://review.opendev.org/c/openstack/glance/+/76424122:25
openstackgerritLance Bragstad proposed openstack/glance master: Properly handle InvalidScope exceptions  https://review.opendev.org/c/openstack/glance/+/77430922:25
openstackgerritLance Bragstad proposed openstack/glance master: Pass oslo.context RequestContext objects directly to policy enforcement  https://review.opendev.org/c/openstack/glance/+/76742522:25
openstackgerritLance Bragstad proposed openstack/glance master: Log an experimental warning at startup for secure RBAC  https://review.opendev.org/c/openstack/glance/+/77658822:25
lbragstaddansmith done - thanks for reapplying the +2s22:26
dansmithlbragstad: okay I think I got em all22:28
lbragstadawesome - glad to see this stuff moving :)22:30
*** ralonsoh has quit IRC22:31
openstackgerritMerged openstack/glance master: Bump requirements to prepare for secure RBAC  https://review.opendev.org/c/openstack/glance/+/76423622:43
*** kgz has quit IRC22:46
*** dansmith has quit IRC22:46
*** kgz has joined #openstack-glance22:48
*** dansmith has joined #openstack-glance22:48
*** tkajinam has joined #openstack-glance22:51
*** k_mouza has joined #openstack-glance23:19
*** k_mouza has quit IRC23:23
openstackgerritDan Smith proposed openstack/glance master: Add housekeeping module and staging cleaner  https://review.opendev.org/c/openstack/glance/+/77701223:30
openstackgerritDan Smith proposed openstack/glance master: Test restarting glance for staging cleanup  https://review.opendev.org/c/openstack/glance/+/77701423:30
openstackgerritDan Smith proposed openstack/glance master: Test restarting glance for staging cleanup  https://review.opendev.org/c/openstack/glance/+/77701423:35
*** tkajinam has quit IRC23:40
*** tkajinam has joined #openstack-glance23:40
« Monday, 2021-02-22 Index Wednesday, 2021-02-24 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!