Thursday, 2021-02-18

« Wednesday, 2021-02-17 Index Friday, 2021-02-19 »
*** eandersson has joined #openstack-glance01:35
*** eandersson has quit IRC01:42
*** eandersson has joined #openstack-glance01:42
*** zzzeek has quit IRC02:47
*** zzzeek has joined #openstack-glance02:50
*** priteau has quit IRC02:59
*** nicolasbock has quit IRC02:59
*** ianw has quit IRC02:59
*** nicolasbock has joined #openstack-glance03:00
*** ianw has joined #openstack-glance03:00
*** k_mouza has joined #openstack-glance03:02
*** k_mouza has quit IRC03:07
*** rcernin has quit IRC03:36
*** rcernin has joined #openstack-glance04:16
*** udesale has joined #openstack-glance04:19
*** ratailor has joined #openstack-glance04:35
*** whoami-rajat__ has joined #openstack-glance04:38
*** gyee has quit IRC05:15
*** m75abrams has joined #openstack-glance05:30
*** k_mouza has joined #openstack-glance06:16
*** k_mouza has quit IRC06:20
openstackgerritAbhishek Kekane proposed openstack/glance master: Add logic to properly enforce secure RBAC when handling images  https://review.opendev.org/c/openstack/glance/+/76521006:35
openstackgerritWander Way proposed openstack/python-glanceclient master: Uncap PrettyTable  https://review.opendev.org/c/openstack/python-glanceclient/+/77632506:48
*** eandersson has quit IRC06:53
*** eandersson has joined #openstack-glance06:53
*** eandersson has quit IRC06:56
*** eandersson has joined #openstack-glance06:56
*** lpetrut has joined #openstack-glance07:06
openstackgerritAbhishek Kekane proposed openstack/glance master: Update logic to support secure RBAC for image membership  https://review.opendev.org/c/openstack/glance/+/77574107:12
*** ralonsoh has joined #openstack-glance07:21
*** udesale_ has joined #openstack-glance07:35
*** udesale has quit IRC07:35
openstackgerritRajat Dhasmana proposed openstack/glance master: Fix: cinder store test  https://review.opendev.org/c/openstack/glance/+/77636907:46
*** rcernin has quit IRC07:58
*** rcernin has joined #openstack-glance08:02
*** rcernin has quit IRC08:07
openstackgerritAbhishek Kekane proposed openstack/python-glanceclient master: Get tasks assoiciated with image  https://review.opendev.org/c/openstack/python-glanceclient/+/77640308:17
openstackgerritRajat Dhasmana proposed openstack/glance master: Skip test test_migrate_image_after_upgrade  https://review.opendev.org/c/openstack/glance/+/77640608:46
*** rcernin has joined #openstack-glance08:49
*** rcernin has quit IRC08:53
*** k_mouza has joined #openstack-glance09:28
*** priteau has joined #openstack-glance11:34
*** m75abrams has quit IRC12:51
*** m75abrams has joined #openstack-glance13:12
*** ratailor has quit IRC13:16
abhishekkjokke, rosmaita, smcginnis, dansmith glance weekly meeting in 5 minutes #openstack-meeting13:54
dansmithwhoami-rajat__: I'm confused about your glance_store skip fix14:13
dansmithwhoami-rajat__: did we release glance_store after the volume type validation merged? or are you proposing we skip the test until we do the release, then un-skip and fix the mock count in our tree?14:14
whoami-rajat__dansmith: we didn't release it, it's failing in the tips periodic job and will fail on glance gate once glance_store is released14:16
dansmithwhoami-rajat__: gotcha, okay14:17
whoami-rajat__I've a fix inplace which we can only merge when glance_store gets released so until then skip it14:17
dansmithwhoami-rajat__: I think that mocking something that is not in our tree and asserting the behavior of that is probably not a good plan, for this reason14:17
dansmithcan we just loosen the mock a little?14:17
whoami-rajat__Initially i didn't have any mock asserts and I added it on review request, i don't have any issues removing it14:18
whoami-rajat__let me know which ones to remove14:18
dansmithwhoami-rajat__: not saying we should remove them, just.. loosen14:18
dansmithwhoami-rajat__: I will look after my meetings today and see if I can propose something more flexbile14:19
whoami-rajat__hmm, ack, so just assert_called check? not assert the number of calls14:19
whoami-rajat__ok14:20
dansmithyeah, that'd work since all you're doing is asserting that it was called three times, not how it was called14:20
dansmithso yeah, just do that maybe?14:20
dansmiththen we don't have to skip..release..fix..unskip14:20
whoami-rajat__ok, will update the patch14:21
dansmithwhoami-rajat__: thanks, I think that'll be a lot smoother14:24
*** rajivmucheli has joined #openstack-glance14:28
openstackgerritRajat Dhasmana proposed openstack/glance master: Fix: cinder store test  https://review.opendev.org/c/openstack/glance/+/77636914:32
whoami-rajat__dansmith: ^^14:33
dansmithalready clicked :)14:33
whoami-rajat__:)14:34
dansmithwhoami-rajat__: quick suggestion, but definitely good14:36
whoami-rajat__sure14:37
openstackgerritRajat Dhasmana proposed openstack/glance master: Fix: cinder store test  https://review.opendev.org/c/openstack/glance/+/77636914:42
dansmithhaha14:42
dansmithyou were supposed to put your nick in the () :)14:42
openstackgerritDan Smith proposed openstack/glance master: Fix: cinder store test  https://review.opendev.org/c/openstack/glance/+/77636914:44
dansmithwhoami-rajat__: ^14:45
abhishekkjokke, dansmith, rosmaita https://review.opendev.org/c/openstack/glance/+/77596814:45
whoami-rajat__ah, i thought it was a TODO and we don't put names there anymore so ... :D14:45
abhishekkwhat is your suggestion about it, kindly let me know14:45
whoami-rajat__dansmith: thanks!14:45
*** whoami-rajat__ is now known as whoami-rajat14:48
whoami-rajatdansmith: thanks for reminding to fix my nick14:49
dansmithwhoami-rajat: ah, sorry, well, feel free to fix14:49
dansmithI still put my nick in my NOTE()s but.. either remove the parens or put your nick :)14:49
whoami-rajati don't mind but this change will probably fail pep8 so will update it14:51
dansmithdid I break it?14:51
dansmithI just edited in the browser, but I thought I was good14:52
openstackgerritRajat Dhasmana proposed openstack/glance master: Fix: cinder store test  https://review.opendev.org/c/openstack/glance/+/77636914:54
whoami-rajatyep it was 86 chars, my nick is too long...14:54
dansmithah, I thought it was giving me a ruler14:55
dansmithsorry14:55
dansmithI guess I should not edit code in a browser during a meeting at 6am :)14:55
whoami-rajatno worries, it always ends up bad for me after editing code in browser14:56
whoami-rajat6am!!14:56
rajivmucheliHi, i enabled swift_store_expire_soon_interval = 1800 for images taking long to complete upload, but it doesnt seem to work as planned, i see a trust a issue (based on docu, this is True by default) but i see the below in the logs :14:57
rajivmuchelihttp://paste.openstack.org/show/802787/14:57
rajivmucheliany suggestions how to fix it ?14:58
dansmithwhoami-rajat: yeah, gotta get up at 5:30am on wednesdays for meetings :/14:58
*** m75abrams has quit IRC15:00
*** m75abrams has joined #openstack-glance15:01
whoami-rajatdansmith: that doesn't sound fun, we used to have meetings at late night IST times in cinder(like cinder meeting at 9:30-10:30 PM and 12:30 AM in china/japan), then we conducted a poll for a suitable time for everyone and now it's very comfortable time for me (7:30 PM IST)15:02
dansmithwhoami-rajat: I get up at 6am normally, so 5:30 isn't too much worse, but yeah, I wish everything could be >= 6am15:04
dansmithI expire early, so a late night meeting would be the worst for me :)15:04
whoami-rajatah, it's the opposite for me, then that works15:07
dansmith:)15:09
abhishekkjokke, still around?15:14
jokkeyeah15:17
abhishekkjokke, could you please reconsider your vote about distributed image import?15:18
abhishekkyou can still vote -1 for your disagreement15:18
abhishekkSo that everyone will be aware that you tried to prevent us if something goes wrong15:19
jokkeabhishekk: I expressed my veto on the meeting that you conveniently disgarded, I'm not changing my vote on the review15:19
jokkeYou can vote +2 there to record your disagreement, but gerrit won't be merging them15:20
abhishekkjokke, as a team we should work together is what I think15:22
jokkeyes we should15:23
abhishekkI know your concerns and we agreed to address them15:23
abhishekkits not like we are ignoring them straight away15:23
*** m75abrams has quit IRC15:25
*** udesale__ has joined #openstack-glance15:35
*** udesale_ has quit IRC15:39
*** k_mouza has quit IRC15:44
*** k_mouza has joined #openstack-glance15:44
*** lpetrut has quit IRC16:00
*** rajivmucheli has quit IRC16:02
*** udesale__ has quit IRC16:06
*** rosmaita has quit IRC16:33
* abhishekk signing out for the day16:38
dansmithabhishekk: wait16:47
dansmithabhishekk: can you +W this? https://review.opendev.org/c/openstack/glance/+/77636916:47
abhishekkdansmith, looking16:47
dansmithdon't want to leave whoami-rajat hanging since he answers all my nits :)16:47
dansmithoh sorry, I was ten minutes late with my "wait", didn't mean to call you back16:48
abhishekkdansmith, no problem16:55
abhishekkat least one less patch in bunch of reviews :D16:56
dansmithabhishekk: thanks, now we don't have to skip..release..fix...unskip16:56
dansmithindeed16:56
abhishekkdansmith, yes, better solution16:56
dansmithabhishekk: you may go now :P16:56
abhishekk:D16:57
abhishekkgood day o/~16:57
dansmitho/16:58
whoami-rajatthanks dansmith and abhishekk  !!16:58
whoami-rajatand Dan those nits are great improvements so can't resist myself updating16:58
dansmithwhoami-rajat: well, glad we can move things forward regardless :)17:01
openstackgerritDan Smith proposed openstack/glance_store master: Run glance functional job on glance_store  https://review.opendev.org/c/openstack/glance_store/+/77650217:15
dansmithwhoami-rajat: hopefully this ^ will give us a glance functional run on patches proposed against glance_store17:16
whoami-rajatmakes sense to do this, thanks Dan17:21
dansmithI expect this run to fail until your patch merges17:25
dansmithyup. just did17:26
dansmithperfect test :)17:26
whoami-rajatnever been happier seeing tests fail17:45
whoami-rajatworks as expected17:45
dansmithhah17:49
dansmithwhen tests are supposed to fail, it's good :)17:49
whoami-rajat:) +117:51
*** k_mouza has quit IRC18:04
*** ralonsoh has quit IRC18:15
*** xarlos has joined #openstack-glance18:46
*** rajinir has quit IRC19:15
openstackgerritDan Smith proposed openstack/glance_store master: Run glance functional job on glance_store  https://review.opendev.org/c/openstack/glance_store/+/77650219:23
*** rajinir has joined #openstack-glance19:55
*** gyee has joined #openstack-glance20:18
*** k_mouza has joined #openstack-glance20:29
*** k_mouza has quit IRC20:34
*** rajinir has quit IRC21:05
*** mgagne has quit IRC21:08
*** whoami-rajat has quit IRC21:21
*** rajinir has joined #openstack-glance21:22
*** rcernin has joined #openstack-glance23:03
*** rcernin has quit IRC23:11
*** rcernin has joined #openstack-glance23:12
« Wednesday, 2021-02-17 Index Friday, 2021-02-19 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!