*** zzzeek has quit IRC | 01:39 | |
*** zzzeek has joined #openstack-glance | 01:41 | |
*** baojg has joined #openstack-glance | 01:56 | |
*** sorrison has joined #openstack-glance | 02:36 | |
*** rcernin has quit IRC | 02:52 | |
*** rcernin has joined #openstack-glance | 02:54 | |
*** zzzeek has quit IRC | 04:34 | |
*** zzzeek has joined #openstack-glance | 04:37 | |
*** ratailor has joined #openstack-glance | 04:59 | |
*** zzzeek has quit IRC | 05:33 | |
*** zzzeek has joined #openstack-glance | 05:36 | |
*** zzzeek has quit IRC | 05:57 | |
*** zzzeek has joined #openstack-glance | 05:59 | |
*** udesale has joined #openstack-glance | 06:00 | |
*** whoami-rajat__ has joined #openstack-glance | 06:13 | |
*** m75abrams has joined #openstack-glance | 06:29 | |
*** k_mouza has joined #openstack-glance | 06:40 | |
*** k_mouza has quit IRC | 06:45 | |
*** ralonsoh has joined #openstack-glance | 07:38 | |
*** rcernin has quit IRC | 08:12 | |
*** baojg has quit IRC | 08:20 | |
*** rcernin has joined #openstack-glance | 08:43 | |
*** rcernin has quit IRC | 08:49 | |
*** rcernin has joined #openstack-glance | 08:58 | |
*** rcernin has quit IRC | 09:47 | |
*** k_mouza has joined #openstack-glance | 09:59 | |
*** udesale_ has joined #openstack-glance | 10:29 | |
*** udesale has quit IRC | 10:32 | |
*** ratailor has quit IRC | 10:41 | |
*** ratailor has joined #openstack-glance | 10:41 | |
*** m75abrams has quit IRC | 10:57 | |
*** m75abrams has joined #openstack-glance | 10:58 | |
*** k_mouza has quit IRC | 11:00 | |
*** k_mouza has joined #openstack-glance | 11:06 | |
whoami-rajat__ | dansmith: hey, restarting c-vol didn't work, left comments here https://review.opendev.org/c/openstack/glance/+/774255 | 11:40 |
---|---|---|
*** m75abrams has quit IRC | 11:52 | |
*** Luzi has joined #openstack-glance | 11:55 | |
*** m75abrams has joined #openstack-glance | 12:07 | |
*** CeeMac has quit IRC | 13:27 | |
*** whoami-rajat__ has quit IRC | 13:27 | |
*** jungleboyj has quit IRC | 13:27 | |
*** gmann has quit IRC | 13:27 | |
*** knikolla has quit IRC | 13:27 | |
*** coreycb has quit IRC | 13:27 | |
*** nicolasbock has quit IRC | 13:27 | |
*** mnaser has quit IRC | 13:27 | |
*** PrinzElvis has quit IRC | 13:27 | |
*** CeeMac has joined #openstack-glance | 13:28 | |
*** coreycb has joined #openstack-glance | 13:28 | |
*** mnaser has joined #openstack-glance | 13:29 | |
*** jungleboyj has joined #openstack-glance | 13:29 | |
*** nicolasbock has joined #openstack-glance | 13:30 | |
*** whoami-rajat__ has joined #openstack-glance | 13:31 | |
*** gmann has joined #openstack-glance | 13:31 | |
*** knikolla has joined #openstack-glance | 13:32 | |
*** rcernin has joined #openstack-glance | 13:38 | |
*** PrinzElvis has joined #openstack-glance | 13:51 | |
*** Luzi has quit IRC | 13:52 | |
*** rcernin has quit IRC | 13:53 | |
*** ratailor has quit IRC | 13:57 | |
dansmith | whoami-rajat__: ack | 15:10 |
dansmith | whoami-rajat__: we should try to get some help from rosmaita on that at some point | 15:10 |
whoami-rajat__ | dansmith: yeah, i will discuss with the cinder team | 15:13 |
*** k_mouza has quit IRC | 15:25 | |
*** k_mouza has joined #openstack-glance | 15:26 | |
*** k_mouza_ has joined #openstack-glance | 16:01 | |
*** k_mouza has quit IRC | 16:05 | |
*** k_mouza_ has quit IRC | 16:08 | |
*** k_mouza has joined #openstack-glance | 16:08 | |
openstackgerrit | Dan Smith proposed openstack/glance master: Make web-download revert all stores on fail https://review.opendev.org/c/openstack/glance/+/774314 | 16:46 |
openstackgerrit | Dan Smith proposed openstack/glance master: DNM: Test web-download tempest negative test https://review.opendev.org/c/openstack/glance/+/774315 | 16:46 |
*** k_mouza has quit IRC | 16:52 | |
*** k_mouza has joined #openstack-glance | 16:53 | |
*** udesale_ has quit IRC | 17:15 | |
lbragstad | jokke ping | 17:27 |
*** ralonsoh has quit IRC | 17:38 | |
*** k_mouza_ has joined #openstack-glance | 17:42 | |
*** k_mouza_ has quit IRC | 17:42 | |
*** k_mouza has quit IRC | 17:44 | |
*** gyee has joined #openstack-glance | 17:50 | |
*** gyee has quit IRC | 17:52 | |
*** gyee has joined #openstack-glance | 17:52 | |
jokke | lbragstad: pong | 18:35 |
lbragstad | jokke i think i found a workaround - but i was wondering if there was a consistent pattern in how glance approach resource dependency management across glance APIs | 18:41 |
lbragstad | (e.g., if i need to pull the image members for a particular image in the policy enforcement code of ImageRepoProxy) | 18:42 |
jokke | lbragstad: The domain layers are bit nasty about that | 18:48 |
lbragstad | from what i can tell, it looks like most of it's pushed into the database | 18:48 |
lbragstad | (for example, tack this project id on to the image query for members) | 18:48 |
jokke | We've been quite happily going around the domain model directly to the source in recent cycles 'though. I think everyone would be pretty happy witout all those layers if we just had resources to refactor them out ;) | 18:48 |
jokke | Yeah so original design was that all the db data interations would go through those layers of proxy classes | 18:50 |
lbragstad | yeah - i'm not suggesting we need to rebuild everything, i'm just curious if there is a canonical way glance handles object dependencies at higher layers - since that's where i want to build targets for policy enforcement | 18:50 |
jokke | You're mainly pulling data, right? Like you're not loking to write anything during those checks? | 18:52 |
lbragstad | right - i'm using the data to build target information that we can use only for policy enforcement | 18:53 |
lbragstad | from what i can tell, the target data is isolated to glance.api.policy module | 18:56 |
lbragstad | and it's build on every request | 18:56 |
jokke | Yeah, just read through your mail too. I assume this is the same thing you described in there with bit more detail | 19:03 |
lbragstad | yeah | 19:05 |
*** k_mouza has joined #openstack-glance | 19:44 | |
*** hoonetorg has quit IRC | 19:45 | |
*** rcernin has joined #openstack-glance | 19:47 | |
*** k_mouza has quit IRC | 19:48 | |
*** rcernin has quit IRC | 19:51 | |
*** whoami-rajat__ has quit IRC | 19:53 | |
*** xarlos has joined #openstack-glance | 20:46 | |
lbragstad | jokke users should be able to view shared images that are accepted, right? | 20:47 |
jokke | lbragstad: IIRC as soon as the image is shared user has access to it, it just doesn't show up on their default listings before they accept it | 20:51 |
jokke | That's there to avoid anyone spamming unwanted images | 20:52 |
lbragstad | ok - that makes sense | 20:52 |
lbragstad | i'm trying to hunt down how this works https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/v2/test_images_resource.py#L250-L265 | 20:52 |
jokke | now I need to go afk for about an hour, hour and half ... I'll try to answer anything else once I get back | 20:52 |
lbragstad | ok - no worries | 20:52 |
jokke | It's getting late enough that the store closes in an hour, I need some dinner ;) | 20:53 |
*** k_mouza has joined #openstack-glance | 20:59 | |
*** k_mouza has quit IRC | 21:04 | |
*** rcernin has joined #openstack-glance | 22:24 | |
*** rcernin has quit IRC | 22:30 | |
*** rcernin has joined #openstack-glance | 22:30 | |
openstackgerrit | Lance Bragstad proposed openstack/glance master: WIP: add logic to properly enforce secure RBAC when handling images https://review.opendev.org/c/openstack/glance/+/765210 | 22:57 |
openstackgerrit | Lance Bragstad proposed openstack/glance-tempest-plugin master: Implement API protection testing for images https://review.opendev.org/c/openstack/glance-tempest-plugin/+/773568 | 22:58 |
lbragstad | jokke ok - i think i finally tripped over the database code that was adding query filters based on the context | 22:58 |
lbragstad | ^ | 22:58 |
lbragstad | the tempest plugin patch has a lot of changes that test the series abhishekk started working on | 22:59 |
lbragstad | but - locally they pass all glance tests in tree and they pass the glance-tempest-plugin tests | 22:59 |
lbragstad | not saying it's ready to merge, there are still a lot gaps in the testing | 22:59 |
lbragstad | but - we should be able to look at the approach and see if we want to adjust it | 23:00 |
lbragstad | i'm trying to be minimal with my changes, so keeping some of the policy stuff in the database to avoid churn... | 23:00 |
lbragstad | but - ideally, it would be nice to have more of an API for constructing sql queries and filters that we can invoke from the policy layer (or wherever) | 23:01 |
*** CeeMac has quit IRC | 23:03 | |
*** CeeMac has joined #openstack-glance | 23:04 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!