| *** zzzeek has quit IRC | 00:44 | |
| *** zzzeek has joined #openstack-glance | 00:46 | |
| *** baojg has joined #openstack-glance | 01:58 | |
| *** benj_ has quit IRC | 02:18 | |
| *** lyr has quit IRC | 02:18 | |
| *** benj_ has joined #openstack-glance | 02:19 | |
| *** lyr has joined #openstack-glance | 02:22 | |
| *** rcernin has quit IRC | 02:41 | |
| *** rcernin has joined #openstack-glance | 02:58 | |
| *** rcernin has quit IRC | 03:03 | |
| *** rcernin has joined #openstack-glance | 03:03 | |
| *** zzzeek has quit IRC | 03:22 | |
| *** zzzeek has joined #openstack-glance | 03:23 | |
| *** ratailor has joined #openstack-glance | 04:39 | |
| *** udesale has joined #openstack-glance | 04:42 | |
| *** zzzeek has quit IRC | 05:10 | |
| *** zzzeek has joined #openstack-glance | 05:14 | |
| *** udesale_ has joined #openstack-glance | 06:48 | |
| *** udesale has quit IRC | 06:50 | |
| *** lpetrut has joined #openstack-glance | 07:14 | |
| *** CeeMac has joined #openstack-glance | 07:22 | |
| *** ralonsoh has joined #openstack-glance | 07:28 | |
| *** lpetrut_ has joined #openstack-glance | 07:45 | |
| *** lpetrut_ has quit IRC | 07:45 | |
| *** lpetrut_ has joined #openstack-glance | 07:46 | |
| *** lpetrut has quit IRC | 07:48 | |
| *** rcernin has quit IRC | 07:53 | |
| *** rcernin has joined #openstack-glance | 07:57 | |
| *** nikparasyr has joined #openstack-glance | 08:21 | |
| *** baojg has quit IRC | 08:56 | |
| *** baojg has joined #openstack-glance | 08:56 | |
| *** rcernin has quit IRC | 09:13 | |
| *** rcernin has joined #openstack-glance | 09:24 | |
| *** baojg has quit IRC | 11:24 | |
| *** baojg has joined #openstack-glance | 11:25 | |
| *** baojg has quit IRC | 11:42 | |
| *** lpetrut__ has joined #openstack-glance | 12:22 | |
| *** lpetrut_ has quit IRC | 12:25 | |
| *** rcernin has quit IRC | 12:36 | |
| *** eandersson has quit IRC | 12:44 | |
| *** eandersson has joined #openstack-glance | 12:44 | |
| *** Luzi has joined #openstack-glance | 12:46 | |
| *** bhagyashris has quit IRC | 12:47 | |
| *** bhagyashris has joined #openstack-glance | 12:47 | |
| *** rcernin has joined #openstack-glance | 12:55 | |
| *** CeeMac has quit IRC | 12:56 | |
| *** udesale_ has quit IRC | 12:56 | |
| *** johanssone has quit IRC | 12:56 | |
| *** CeeMac has joined #openstack-glance | 12:59 | |
| *** udesale_ has joined #openstack-glance | 12:59 | |
| *** johanssone has joined #openstack-glance | 12:59 | |
| *** rcernin has quit IRC | 13:00 | |
| *** rcernin has joined #openstack-glance | 13:13 | |
| *** rcernin has quit IRC | 13:27 | |
| *** ratailor has quit IRC | 13:35 | |
| *** ratailor has joined #openstack-glance | 13:38 | |
| *** ratailor has quit IRC | 13:44 | |
| *** lbragstad has joined #openstack-glance | 14:03 | |
| *** lbragstad has quit IRC | 14:16 | |
| *** lbragstad has joined #openstack-glance | 14:19 | |
| *** lbragstad has quit IRC | 14:20 | |
| *** lbragstad has joined #openstack-glance | 14:20 | |
| *** whoami-rajat__ has joined #openstack-glance | 14:25 | |
| *** Luzi has quit IRC | 14:48 | |
| *** udesale__ has joined #openstack-glance | 14:49 | |
| *** m75abrams has joined #openstack-glance | 14:50 | |
| *** udesale_ has quit IRC | 14:52 | |
| dansmith | rosmaita: so funny story | 14:59 |
|---|---|---|
| rosmaita | i hope this is funny "ha-ha" | 15:00 |
| dansmith | rosmaita: I think that when nova goes to create an image from a server, it copies all the image properties from the original image in the POST to create the new one | 15:00 |
| dansmith | which fails once os_glance_ is reserved because it tries to copy stale os_glance_importing_to_stores type stuff from the original cirros image we uploaded during devstack init | 15:01 |
| rosmaita | yeah, use non_inheritable_image_properties in nova | 15:01 |
| rosmaita | or the absolutely NON_INHERITABLE_IMAGE_PROPERTIES | 15:01 |
| rosmaita | would probably be better | 15:01 |
| dansmith | but that's a static list of properties.. nova would really need to filter out anything from that namespace, even things it doesn't know about | 15:02 |
| dansmith | it's also a little bit of an API/contract break too, | 15:03 |
| dansmith | because if you rolled your glance before your nova, you'd be toast | 15:03 |
| rosmaita | yeah, i have been thinking about this for cinder because we need something similar -- whether we should exclude some from ever being copied in the first place, or just store but not copy | 15:03 |
| dansmith | I'm kinda leaning towards making PUT of those a 40x, but on POST just filtering those from the body and logging them | 15:04 |
| rosmaita | but we hadn't gotten to the point of reserved namespaces yet | 15:04 |
| dansmith | I can still make nova behave better, but maybe not make them a 4xx error on POST for "a long time" | 15:04 |
| dansmith | thoughts on that? or do you think it's confusing to make them be silently discarded on POST but an error on PUT? | 15:05 |
| dansmith | (er, PATCH) | 15:05 |
| rosmaita | well about the API contract ... i think there's some flexibility, because an operator could configure property protections in such a way that a POST trying to create a "restricted" property will fail | 15:06 |
| rosmaita | so that can happen already | 15:06 |
| dansmith | okay, that's fair | 15:06 |
| dansmith | but in nova we try not to make any changes that require someone to read the renos before an upgrade breaks.. so a warning followed by removal | 15:07 |
| dansmith | but we can put it in nova-status | 15:07 |
| dansmith | we just know that basically everyone will hit this because nobody has any reason to be filtering out these | 15:07 |
| dansmith | although few people are using import, so.. I guess not everybody | 15:07 |
| rosmaita | i think we say in the docs somewhere not to use os_* as a prefix for custom properties | 15:08 |
| rosmaita | guess we "suggest" it maybe | 15:08 |
| dansmith | yeah I'm less concerned about someone that is using os_glance_private_thing | 15:08 |
| *** lpetrut__ has quit IRC | 15:27 | |
| dansmith | rosmaita: https://review.opendev.org/c/openstack/nova/+/771234 | 15:31 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Make os_glance namespace reserved https://review.opendev.org/c/openstack/glance/+/771070 | 15:33 |
| jokke | dansmith: rosmaita: by quick search looks like we've onl stated the reservation of os_glance_ namespace in like train release notes where it's stated that those store names should be left for internal use | 16:08 |
| rosmaita | dansmith: i like the tempest tests in https://review.opendev.org/c/openstack/tempest/+/771071 , but since tempest is branchless, is there a problem with adding it without some kind of flag? | 16:08 |
| rosmaita | jokke: thanks for tracking that donw | 16:09 |
| rosmaita | *down | 16:09 |
| dansmith | rosmaita: yeah, probably :) | 16:09 |
| jokke | I'm 100% in favor for clamping that namespace down where ever we can, just a note about them and we probably should throw a doc patch up for it as well | 16:10 |
| dansmith | rosmaita: need a conf flag probably, I just wrote those on friday to get something down | 16:10 |
| jokke | dansmith: btw, not ignoring the import proxying patch, just hectic last week getting up to speed after PTO. I have it ope on a tab. Liked the cleanliness of it | 16:11 |
| jokke | based on my forst pass looking through it | 16:11 |
| dansmith | jokke: cool, was just about to re-poke you :) | 16:12 |
| jokke | ;) | 16:12 |
| jokke | Is there anything we really really want to get merged before milestone 2 tag? | 16:13 |
| dansmith | I think we kinda need to get the spec for the distributed import all but ready for abhishekk's return don't we? | 16:13 |
| jokke | If not, I'm gonna throw the release patch up tomorrow, we can wait until Wed if we need to sort something for it | 16:13 |
| jokke | dansmith: yes, the specs are my today's focus | 16:13 |
| jokke | to have ready for Abhishek for Thu | 16:14 |
| dansmith | do we need a spec for the os_glance lockdown or is that mechanical enough to cover with reno/doc? | 16:14 |
| jokke | IMHO we don't need spec for it. It's been the agreement since we introduced it, just we haven't been great communicating it | 16:15 |
| dansmith | sweet | 16:15 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Update docs and renos for os_glance reservation https://review.opendev.org/c/openstack/glance/+/771249 | 16:32 |
| *** udesale__ has quit IRC | 16:36 | |
| *** eandersson8 has joined #openstack-glance | 16:43 | |
| *** m75abrams has quit IRC | 16:44 | |
| *** nikparasyr has quit IRC | 16:44 | |
| *** nikparasyr has joined #openstack-glance | 16:45 | |
| *** m75abrams has joined #openstack-glance | 16:45 | |
| *** eandersson has quit IRC | 16:45 | |
| *** zzzeek has quit IRC | 16:45 | |
| *** eandersson8 is now known as eandersson | 16:45 | |
| *** nikparasyr has left #openstack-glance | 16:45 | |
| *** zzzeek has joined #openstack-glance | 16:46 | |
| *** m75abrams has quit IRC | 16:46 | |
| *** takamatsu has quit IRC | 17:02 | |
| *** ralonsoh has quit IRC | 17:58 | |
| *** dasp has quit IRC | 18:13 | |
| *** dasp has joined #openstack-glance | 18:25 | |
| *** whoami-rajat__ has quit IRC | 18:55 | |
| dansmith | rosmaita: skips when not enabled by devstack now: {0} tempest.api.image.v2.test_images_negative.ImagesNegativeTest.test_create_image_reserved_property ... SKIPPED: os_glance_reserved is not enabled | 19:37 |
| rosmaita | dansmith: very nice | 19:38 |
| dansmith | rosmaita: not trying to brag on my check-a-flag skills, just.. sayin ;P | 19:39 |
| * dansmith updates resume with "can write code with conditional execution based on static flags" | 19:41 | |
| rosmaita | dansmith: see if you buy my argument on https://review.opendev.org/c/openstack/tempest/+/771071/ that this is not new api behavior | 19:50 |
| dansmith | rosmaita: yeah, I was not so sure earlier, but we've carved out specific keys for specific features already, and also the operator can have done that, so yeah.. I think the api user can't be too surprised about it | 19:52 |
| rosmaita | cool | 19:52 |
| rosmaita | left some comments for you on https://review.opendev.org/c/openstack/glance/+/771249 | 19:52 |
| dansmith | rosmaita: cool thanks | 19:55 |
| rosmaita | the worst thing about WFH is that it is *always* my turn to make coffee | 19:58 |
| dansmith | I'll take choice of coffee over having someone else burn it for me :) | 19:58 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Update docs and renos for os_glance reservation https://review.opendev.org/c/openstack/glance/+/771249 | 20:07 |
| *** rcernin has joined #openstack-glance | 22:39 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!