| *** jawad_axd has joined #openstack-glance | 00:34 | |
| *** jawad_axd has quit IRC | 00:38 | |
| *** jawad_axd has joined #openstack-glance | 01:15 | |
| *** jawad_axd has quit IRC | 01:19 | |
| *** gyee has quit IRC | 01:22 | |
| *** Liang__ has joined #openstack-glance | 01:32 | |
| *** jawad_axd has joined #openstack-glance | 01:36 | |
| *** jawad_axd has quit IRC | 01:41 | |
| *** jawad_axd has joined #openstack-glance | 01:57 | |
| *** jawad_axd has quit IRC | 02:01 | |
| *** rosmaita has quit IRC | 02:16 | |
| *** rosmaita has joined #openstack-glance | 02:16 | |
| openstackgerrit | Zihao Wang proposed openstack/python-glanceclient master: requirements: Drop os-testr https://review.opendev.org/753201 | 02:19 |
|---|---|---|
| *** zzzeek has quit IRC | 02:51 | |
| *** zzzeek has joined #openstack-glance | 02:54 | |
| *** udesale has joined #openstack-glance | 03:15 | |
| *** udesale has quit IRC | 03:15 | |
| *** ratailor has joined #openstack-glance | 03:41 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-glance | 04:33 | |
| *** m75abrams has joined #openstack-glance | 04:54 | |
| *** rcernin has quit IRC | 05:14 | |
| *** udesale has joined #openstack-glance | 05:30 | |
| *** rcernin has joined #openstack-glance | 05:34 | |
| *** udesale_ has joined #openstack-glance | 05:46 | |
| *** udesale has quit IRC | 05:47 | |
| *** Liang__ has quit IRC | 05:48 | |
| *** Liang__ has joined #openstack-glance | 05:49 | |
| *** zzzeek has quit IRC | 05:54 | |
| *** zzzeek has joined #openstack-glance | 05:54 | |
| *** zzzeek has quit IRC | 06:26 | |
| *** ralonsoh has joined #openstack-glance | 06:28 | |
| *** zzzeek has joined #openstack-glance | 06:28 | |
| *** Liang__ has quit IRC | 07:03 | |
| *** baojg has joined #openstack-glance | 07:07 | |
| *** Liang__ has joined #openstack-glance | 07:07 | |
| *** belmoreira has joined #openstack-glance | 07:10 | |
| *** nightmare_unreal has joined #openstack-glance | 07:10 | |
| *** rcernin has quit IRC | 07:13 | |
| *** jawad_axd has joined #openstack-glance | 07:22 | |
| *** udesale_ has quit IRC | 07:36 | |
| *** rcernin has joined #openstack-glance | 07:39 | |
| *** udesale_ has joined #openstack-glance | 07:41 | |
| *** udesale_ has quit IRC | 07:41 | |
| nightmare_unreal | Hi, how to debug glance/ glance-api ? I am using devstack where can I find logs for it | 08:11 |
| *** priteau has joined #openstack-glance | 08:23 | |
| *** priteau has quit IRC | 08:35 | |
| *** priteau has joined #openstack-glance | 08:50 | |
| *** rcernin has quit IRC | 08:59 | |
| *** rcernin has joined #openstack-glance | 09:00 | |
| *** ratailor has quit IRC | 09:01 | |
| *** rcernin has quit IRC | 09:19 | |
| *** k_mouza has joined #openstack-glance | 09:32 | |
| abhishekk | you can use rpdb | 09:38 |
| *** Liang__ has quit IRC | 10:00 | |
| *** baojg has quit IRC | 10:33 | |
| *** baojg has joined #openstack-glance | 10:34 | |
| *** k_mouza has quit IRC | 10:35 | |
| *** rcernin has joined #openstack-glance | 10:37 | |
| *** rcernin has quit IRC | 10:37 | |
| *** rcernin has joined #openstack-glance | 10:37 | |
| *** k_mouza has joined #openstack-glance | 10:44 | |
| *** k_mouza has quit IRC | 10:48 | |
| *** k_mouza has joined #openstack-glance | 10:48 | |
| *** ratailor has joined #openstack-glance | 10:54 | |
| *** Luzi has joined #openstack-glance | 10:55 | |
| *** baojg has quit IRC | 11:03 | |
| *** baojg has joined #openstack-glance | 11:04 | |
| *** priteau has quit IRC | 11:08 | |
| *** rcernin has quit IRC | 11:11 | |
| *** ratailor has quit IRC | 11:50 | |
| *** rcernin has joined #openstack-glance | 12:55 | |
| *** rcernin has quit IRC | 13:10 | |
| *** k_mouza has quit IRC | 13:12 | |
| *** k_mouza has joined #openstack-glance | 13:14 | |
| nightmare_unreal | for authentication what does glance use ? token , username pass , conf file ? | 13:45 |
| *** priteau has joined #openstack-glance | 13:46 | |
| dansmith | nightmare_unreal: for authentication to what? | 13:49 |
| dansmith | nightmare_unreal: users authenticate to glance with a token from keystone | 13:50 |
| nightmare_unreal | I mean if glance requires resource/info from other services | 13:50 |
| nightmare_unreal | I am still trying to make the identity client. | 13:50 |
| nightmare_unreal | the link that you shared yesterday was helpful but it's too specific to nova ( i think ) . the context part and nova utils. : https://github.com/openstack/nova/blob/master/nova/api/openstack/identity.py#L34 | 13:51 |
| dansmith | generally when one service needs to talk to another on behalf of a user, it uses the token the user presented to do so, to make sure it doesn't escalate the privileges of the user with the other service | 13:51 |
| dansmith | nightmare_unreal: context is basically oslo_context, and glance uses the same pattern | 13:52 |
| abhishekk | jokke, dansmith around? | 13:53 |
| dansmith | abhishekk: yes? :) | 13:54 |
| abhishekk | :D | 13:54 |
| abhishekk | need couple of minutes | 13:54 |
| abhishekk | we have rc1 this week, I don't think that web_download patch (both size and cleanup) is going to make it | 13:55 |
| nightmare_unreal | oh okay dansmith . what should be the right way to do it? using tokens ? | 13:55 |
| abhishekk | what do you think | 13:55 |
| dansmith | abhishekk: well, one of us could just fix it up quick, or just wait and backport it right? the latter seems like it would be fine too, as it's not a huge change AFAICT | 13:56 |
| dansmith | nightmare_unreal: definitely | 13:56 |
| nightmare_unreal | okay | 13:57 |
| abhishekk | dansmith, I just don't want to duplicate the efforts, but not sure yebinama is around from yesterday so its good that we can fix the changes and get it done | 13:57 |
| abhishekk | Let me work on the fixes, I will also push reno patch on top of it | 13:59 |
| dansmith | abhishekk: okay, seems like the best thing to do if you want to land it first, yeah | 13:59 |
| abhishekk | IF we get couple of +2 tomorrow by this time then we are good | 14:00 |
| dansmith | abhishekk: I'll be on call :) | 14:01 |
| dansmith | er, in case that doesn't translate.. I'll be here ready to review :) | 14:01 |
| abhishekk | ack, thank you | 14:01 |
| abhishekk | :D | 14:02 |
| *** lpetrut has joined #openstack-glance | 14:02 | |
| nightmare_unreal | dansmith: do you have any example for glance, where existing user token is used to communicate with another service | 14:17 |
| dansmith | nightmare_unreal: looks like the cinder stuff uses the user token by default, and I would expect swift as well | 14:18 |
| nightmare_unreal | okay :) | 14:18 |
| dansmith | however, in the api code, you'll see the context just the same as in nova, which should be all you need | 14:18 |
| dansmith | glance is really strange in that it really buries the context stuff in layers of onion almost immediately, which makes it quite difficult to get at that stuff from the bowels, | 14:18 |
| dansmith | but in the API you should have it relatively close by | 14:19 |
| nightmare_unreal | well there is glance.api.middleware.context I tried with that. I was getting error that "glance.api.middleware.context has no attribute get_headers()" | 14:20 |
| dansmith | that's a module, you can't just pass a python module and expect it to magically figure out what it needs from there :) | 14:21 |
| dansmith | the context comes in via the request | 14:21 |
| dansmith | nightmare_unreal: for example: https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L75 | 14:22 |
| dansmith | req.context is what you want.. that's a context object filled out with all the details from the request, including the token they provided, etc | 14:22 |
| nightmare_unreal | aah, true. Thanks I will take a look | 14:23 |
| *** Luzi has quit IRC | 14:25 | |
| *** k_mouza has quit IRC | 14:36 | |
| *** k_mouza has joined #openstack-glance | 14:43 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Image import "web-download" check downloaded size https://review.opendev.org/752067 | 14:52 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Fix cleaning of web-download image import https://review.opendev.org/607680 | 14:52 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Victoria RC-1 release notes https://review.opendev.org/753371 | 14:52 |
| abhishekk | dansmith, ^^^ | 14:53 |
| abhishekk | jokke, rosmaita, smcginnis kindly review when you get some time, thank you | 14:53 |
| rosmaita | abhishekk: ack | 14:54 |
| dansmith | abhishekk: IMHO, you should just +W that bottom patch as you were +2 before and you just fixed a nit | 14:54 |
| abhishekk | dansmith, right, need reviews for cleaning and reno :D | 14:55 |
| dansmith | rgr | 14:55 |
| *** abhishekk is now known as abhishekk-afk | 14:55 | |
| *** jawad_axd has quit IRC | 14:56 | |
| dansmith | abhishekk-afk: small thing in the cleanup patch | 14:58 |
| *** rcernin has joined #openstack-glance | 15:03 | |
| *** rcernin has quit IRC | 15:10 | |
| *** belmoreira has quit IRC | 15:21 | |
| abhishekk-afk | dansmith, regarding that, to mock store.add I need to call execute method and then I need to trigger failure so that revert will be called for which again I need to mock execute method as well | 15:27 |
| abhishekk-afk | otherwise if I call execute method and didn't trigger failure its not logical to call revert method directly from test | 15:28 |
| *** m75abrams has quit IRC | 15:33 | |
| *** abhishekk-afk is now known as abhishekk | 15:35 | |
| dansmith | abhishekk: I'm not following | 15:45 |
| abhishekk | dansmith, just replied on the patch | 15:46 |
| abhishekk | what I was saying is calling both execute and revert method from same test doesn't looks good to me | 15:47 |
| dansmith | abhishekk: okay, the reply doesn't clear it up for me | 15:47 |
| dansmith | why? | 15:47 |
| dansmith | you want to make sure that execute sets up the internal data that revert will need | 15:47 |
| dansmith | if you set up exactly what you need from the test and then call revert, you're testing that the *test* does the right thing, but not the actual code | 15:48 |
| abhishekk | yeah, but revert should be called only when execute fails | 15:48 |
| dansmith | you could do a functional test to make sure it happens, but it'd be simpler to just do it here | 15:48 |
| dansmith | abhishekk: right, you're going to make execute fail, | 15:48 |
| dansmith | because you're going to mock out store.add | 15:48 |
| *** lpetrut has quit IRC | 15:49 | |
| abhishekk | how will execute fail without mocking it? | 15:49 |
| dansmith | i.e. make the mocked store_add return an invalid size | 15:49 |
| abhishekk | hmm | 15:50 |
| dansmith | don't mock execute, mock store_add | 15:50 |
| dansmith | hang on, brb | 15:50 |
| abhishekk | ok | 15:50 |
| dansmith | sorry, local distraction here | 15:51 |
| dansmith | if you still don't understand, I can pull it down and write the change I'm suggesting | 15:51 |
| abhishekk | dansmith, let me try once and then you can do it if I didn't managed :D | 15:52 |
| dansmith | abhishekk: if you don't manage, then look at this, else ignore :) https://pastebin.com/uhmatKn8 | 16:03 |
| abhishekk | dansmith, ack, thank you | 16:05 |
| *** irclogbot_3 has quit IRC | 16:08 | |
| *** bhagyashri|rover has quit IRC | 16:08 | |
| *** irclogbot_0 has joined #openstack-glance | 16:09 | |
| *** dosaboy has quit IRC | 16:09 | |
| *** bhagyashris has joined #openstack-glance | 16:10 | |
| abhishekk | dansmith, only problem is test case implies revert without failure and we are imposing failure | 16:12 |
| dansmith | you were already calling revert, so there was some failure.. is your point that the test case name implies that there wasn't a failure in *this* atom's execute? | 16:12 |
| *** dosaboy has joined #openstack-glance | 16:13 | |
| abhishekk | I think that is what I am assuming | 16:13 |
| dansmith | "without_failure" and "revert gets called" are incompatible anyway, so I'd just change the name to something appropriate :) | 16:13 |
| dansmith | we're not actually testing any different outcome here, just being more comprehensive :) | 16:14 |
| abhishekk | ack :D | 16:16 |
| *** k_mouza has quit IRC | 16:25 | |
| *** k_mouza has joined #openstack-glance | 16:34 | |
| *** k_mouza has quit IRC | 16:38 | |
| *** k_mouza has joined #openstack-glance | 16:42 | |
| *** k_mouza has quit IRC | 16:46 | |
| *** k_mouza has joined #openstack-glance | 16:51 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Fix cleaning of web-download image import https://review.opendev.org/607680 | 16:51 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Victoria RC-1 release notes https://review.opendev.org/753371 | 16:51 |
| openstackgerrit | Erno Kuvaja proposed openstack/glance master: Do not use OSC in infra playbook https://review.opendev.org/750212 | 17:09 |
| *** k_mouza has quit IRC | 17:11 | |
| *** k_mouza has joined #openstack-glance | 17:18 | |
| *** k_mouza has quit IRC | 17:23 | |
| *** k_mouza has joined #openstack-glance | 17:37 | |
| *** k_mouza has quit IRC | 17:41 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Fix cleaning of web-download image import https://review.opendev.org/607680 | 17:41 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Victoria RC-1 release notes https://review.opendev.org/753371 | 17:41 |
| *** ralonsoh has quit IRC | 17:46 | |
| *** k_mouza has joined #openstack-glance | 17:46 | |
| *** k_mouza has quit IRC | 17:51 | |
| openstackgerrit | Grégoire Unbekandt proposed openstack/glance master: Fix cleaning of web-download image import https://review.opendev.org/607680 | 17:59 |
| *** belmoreira has joined #openstack-glance | 18:13 | |
| openstackgerrit | Grégoire Unbekandt proposed openstack/glance master: Fix cleaning of web-download image import https://review.opendev.org/607680 | 18:31 |
| *** gyee has joined #openstack-glance | 18:34 | |
| *** zzzeek has quit IRC | 19:08 | |
| *** zzzeek has joined #openstack-glance | 19:09 | |
| *** priteau has quit IRC | 19:23 | |
| *** belmoreira has quit IRC | 20:40 | |
| *** k_mouza has joined #openstack-glance | 21:09 | |
| *** k_mouza has quit IRC | 21:14 | |
| *** gmann has quit IRC | 22:04 | |
| *** gregwork has quit IRC | 22:04 | |
| *** nicolasbock has quit IRC | 22:04 | |
| *** gmann has joined #openstack-glance | 22:05 | |
| *** nicolasbock has joined #openstack-glance | 22:05 | |
| *** gregwork has joined #openstack-glance | 22:09 | |
| *** rcernin has joined #openstack-glance | 22:55 | |
| *** tkajinam has joined #openstack-glance | 22:57 | |
| openstackgerrit | Merged openstack/glance master: Image import "web-download" check downloaded size https://review.opendev.org/752067 | 23:17 |
| *** zzzeek has quit IRC | 23:30 | |
| *** zzzeek has joined #openstack-glance | 23:31 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!