Tuesday, 2020-09-08

*** zzzeek has quit IRC00:06
*** zzzeek has joined #openstack-glance00:08
*** zzzeek has quit IRC00:24
*** zzzeek has joined #openstack-glance00:29
*** zzzeek has quit IRC00:34
*** zzzeek has joined #openstack-glance00:35
*** Liang__ has joined #openstack-glance01:25
*** hoonetorg has quit IRC01:47
*** hoonetorg has joined #openstack-glance01:48
*** zzzeek has quit IRC02:47
*** zzzeek has joined #openstack-glance02:51
*** rcernin has quit IRC02:59
*** rcernin has joined #openstack-glance03:13
*** udesale has joined #openstack-glance03:15
*** zzzeek has quit IRC03:19
*** udesale_ has joined #openstack-glance03:19
*** zzzeek has joined #openstack-glance03:21
*** udesale has quit IRC03:22
*** zzzeek has quit IRC04:03
*** zzzeek has joined #openstack-glance04:05
*** whoami-rajat__ has joined #openstack-glance04:15
*** ratailor has joined #openstack-glance04:18
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-glance04:33
*** m75abrams has joined #openstack-glance04:53
*** zzzeek has quit IRC06:02
*** zzzeek has joined #openstack-glance06:03
*** zzzeek has quit IRC06:22
*** zzzeek has joined #openstack-glance06:24
*** ralonsoh has joined #openstack-glance06:35
*** rcernin has quit IRC08:00
*** zzzeek has quit IRC08:16
*** zzzeek has joined #openstack-glance08:17
*** nikparasyr has joined #openstack-glance08:24
*** k_mouza has joined #openstack-glance08:26
*** priteau has joined #openstack-glance08:35
*** zzzeek has quit IRC08:47
*** zzzeek has joined #openstack-glance08:50
*** priteau has quit IRC09:12
*** priteau has joined #openstack-glance09:14
*** priteau has quit IRC09:17
*** priteau has joined #openstack-glance09:17
openstackgerritlikui proposed openstack/glance master: Add boto3 requirements.txt  https://review.opendev.org/75030009:29
*** Liang__ has quit IRC10:02
*** k_mouza has quit IRC10:16
*** belmoreira has joined #openstack-glance10:28
*** zzzeek has quit IRC10:48
*** zzzeek has joined #openstack-glance10:50
*** k_mouza has joined #openstack-glance11:08
*** k_mouza has quit IRC11:14
*** k_mouza has joined #openstack-glance11:18
*** udesale__ has joined #openstack-glance11:20
*** udesale_ has quit IRC11:22
openstackgerritlikui proposed openstack/glance master: Add boto3 requirements.txt  https://review.opendev.org/75030011:25
*** rosmaita has joined #openstack-glance11:58
*** njohnston has joined #openstack-glance12:15
mnasermorning folks: can we have a look at https://review.opendev.org/#/c/748877/ ?12:23
mnaserit's still logging errors everywhere for us and it would be useful :)12:23
openstackgerritMerged openstack/glance master: Remove babel.cfg etc  https://review.opendev.org/74965712:31
openstackgerritlikui proposed openstack/glance master: Remove six.PY3 and six.PY2  https://review.opendev.org/75034212:32
openstackgerritlikui proposed openstack/glance master: Remove six.PY3 and six.PY2  https://review.opendev.org/75034212:40
*** ratailor has quit IRC12:52
*** Luzi has joined #openstack-glance12:55
openstackgerritlikui proposed openstack/glance master: Remove six.PY3 and six.PY2  https://review.opendev.org/75034212:58
*** k_mouza has joined #openstack-glance13:09
*** Luzi has quit IRC13:47
*** priteau has quit IRC14:23
*** k_mouza has quit IRC14:27
whoami-rajat__hi smcginnis , I've sent out a mail regarding FFE as the feature requires another release of glance_store, do we require FFE from requirements team as well?14:27
whoami-rajat__abhishekk: rosmaita  ^^14:27
abhishekkwhoami-rajat__, AFAIK, we don't unless we have cut a stable branch for glance_store with the last release, but word from smcginnis will help us more in this case14:29
abhishekkjokke, ^^14:29
abhishekkdansmith, ^^14:30
rosmaitaabhishekk: looks like you slipped one past the goalie there ... i think you were supposed to cut a stable branch for the victoria glance_store release14:31
rosmaitaor, i have my deadlines confused14:31
abhishekkrosmaita, I asked smcginnis about the same and he said its not necessary that we should do it in the same patch14:31
rosmaitainteresting14:32
abhishekkin last weeks meeting14:33
rosmaitai need to pay more attention at these meetings14:33
smcginnisNot the same patch, but the branch should be created. The deadline for non-client libraries was last Thursday, so we are now past the freeze.14:34
smcginnisSo really it should include a FFE ack from requirements.14:35
abhishekksmcginnis, that means we need to put a patch to create new branch as well14:35
smcginnisYep. But I can run a script to generate patches for any libs that are missing them.14:36
abhishekkis it possible for you to do it?14:36
abhishekkack14:36
smcginnisBut if you need to do a FFE, we can either hold off on that, or we can create the branch now, then backport the change.14:36
smcginnisWhat is it that needs to be released yet?14:37
abhishekkhttps://review.opendev.org/75013114:37
abhishekk^^14:37
abhishekkthis issue we found during writing functional tests in glance14:37
smcginnisAh, yep, that looks like it's probably important enough.14:37
abhishekkstrange that it is not failing in actual development environment but only during tests14:38
smcginnisIs it maybe our test code?14:38
smcginnisCertainly would be easier if it was just a matter of fixing the test.14:38
smcginnisThat looks like it's turning a warning into an error.14:39
abhishekkyesterday jokke and me put couple of hours looking into it, but didn't get the clue14:39
abhishekkyes14:39
abhishekkjokke, has pointed out that, for some reason this https://github.com/openstack/glance/blob/master/tox.ini#L16 get overwritten14:39
smcginnisStill odd that it would treat a deprecation warning as an error.14:41
abhishekkyes14:43
*** tkajinam has quit IRC14:43
abhishekkSo, I guess we should send FFE to requirements team, get this patch, release the store and then create the branch?14:46
smcginnisabhishekk: Yeah, that's probably best.14:48
smcginnisWe may need to do something like https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/fixtures.py#L133-L13614:48
abhishekklooking14:48
smcginnisBut if we can just get rid of the warning in the first place, that's probably cleaner.14:48
*** priteau has joined #openstack-glance14:49
abhishekksmcginnis, let me try first clearing the warning is possible without .new release of store14:50
abhishekkif it is then we will fix it in master and later backport14:50
smcginnis++14:50
abhishekkunit14:51
*** k_mouza has joined #openstack-glance14:51
abhishekksmcginnis, I changed above from error to ignore and tests are passing now14:54
smcginnisGreat!14:55
abhishekkSo, is it good idea to ignore it, get the glance patch in, release glance and then enable it on master?14:56
abhishekkI think lets go in right direction, apply for FFE, release glance_store then release glance14:57
abhishekksmcginnis, whoami-rajat__ ^^15:01
smcginnisabhishekk: Either way. It would be good to stop using the deprecated bits.15:02
abhishekksmcginnis, ack, please approve the FFE :D15:02
abhishekkwhoami-rajat__, will send mail soon15:02
smcginnisabhishekk: I've proposed a glance_store stable/victoria, but feel free to -1 that, and/or update that to be a new release with the branch being created from the new point.15:02
*** k_mouza has quit IRC15:03
abhishekksmcginnis, ack15:03
*** nikparasyr has left #openstack-glance15:09
*** k_mouza has joined #openstack-glance15:10
*** k_mouza has quit IRC15:29
* abhishekk dinner break15:30
*** jmlowe has quit IRC15:30
jokkesmcginnis: abhishekk: yeah, I don't know why the tests suddenly treat warnings.warn as errors. I was able to get around that by overwriting the func to pass but no matter what I did on the test definitions it blows. Likely stestr has something hardcoded15:32
*** jmlowe has joined #openstack-glance15:32
smcginnisHmm, seems really odd.15:33
jokkesmcginnis: cheers for the branch patch. I think it would be cleaner not to need release minor for that and backport ;)15:33
jokkesmcginnis: yeah ... coundn't get to the bottom of it but fortunately the actual fix is easy and should have done ages ago15:34
abhishekkjokke, https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/fixtures.py#L133-L13615:35
smcginnisYeah, good to get out the deprecated stuff at least.15:35
*** k_mouza has joined #openstack-glance15:41
*** udesale__ has quit IRC16:02
*** belmoreira has quit IRC16:04
*** k_mouza has quit IRC16:06
*** m75abrams has quit IRC16:08
*** k_mouza has joined #openstack-glance16:08
*** ralonsoh has quit IRC16:12
*** ralonsoh has joined #openstack-glance16:12
*** k_mouza has quit IRC16:18
whoami-rajat__smcginnis: I've sent out mail for the requirements FFE16:22
*** k_mouza has joined #openstack-glance16:24
whoami-rajat__smcginnis: http://lists.openstack.org/pipermail/openstack-discuss/2020-September/017087.html16:27
*** k_mouza has quit IRC16:30
*** rosmaita has left #openstack-glance16:33
*** ralonsoh has quit IRC16:39
*** ralonsoh has joined #openstack-glance16:40
*** lpetrut has joined #openstack-glance16:46
*** ralonsoh has quit IRC17:23
*** gyee has joined #openstack-glance17:33
*** rosmaita has joined #openstack-glance17:33
*** lpetrut has quit IRC17:51
*** priteau has quit IRC19:20
*** whoami-rajat__ has quit IRC20:14
*** zzzeek has quit IRC20:16
*** zzzeek has joined #openstack-glance20:17
openstackgerritMerged openstack/glance master: Support cinder multiple stores  https://review.opendev.org/74803920:22
rosmaita\o/20:29
*** tkajinam has joined #openstack-glance22:57
*** tkajinam has quit IRC22:57
*** tkajinam has joined #openstack-glance22:58
*** rcernin has joined #openstack-glance23:02
*** zzzeek has quit IRC23:33
*** zzzeek has joined #openstack-glance23:35

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!