Tuesday, 2020-08-25

« Monday, 2020-08-24 Index Wednesday, 2020-08-26 »
*** tkajinam_ is now known as tkajinam01:04
*** rcernin has quit IRC01:14
*** rcernin has joined #openstack-glance01:15
*** baojg has joined #openstack-glance01:36
*** gyee has quit IRC01:48
*** udesale has joined #openstack-glance03:32
*** ratailor has joined #openstack-glance03:39
*** rcernin has quit IRC04:32
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-glance04:35
*** udesale has quit IRC04:44
*** m75abrams has joined #openstack-glance04:51
*** udesale has joined #openstack-glance04:55
*** rcernin has joined #openstack-glance05:03
*** ratailor has quit IRC05:09
*** rcernin has quit IRC05:41
*** ralonsoh has joined #openstack-glance06:28
*** ratailor has joined #openstack-glance06:31
*** rcernin has joined #openstack-glance06:56
*** rcernin has quit IRC07:03
*** rcernin has joined #openstack-glance07:04
*** rcernin has quit IRC07:14
*** baojg has quit IRC07:58
*** baojg has joined #openstack-glance07:59
*** udesale has quit IRC08:07
*** udesale has joined #openstack-glance08:07
*** nikparasyr has joined #openstack-glance08:11
*** k_mouza has joined #openstack-glance08:57
*** dosaboy has quit IRC08:59
*** dosaboy has joined #openstack-glance08:59
*** rcernin has joined #openstack-glance09:19
*** rcernin has quit IRC09:24
*** belmoreira has joined #openstack-glance09:25
*** k_mouza has quit IRC09:36
*** k_mouza has joined #openstack-glance09:45
*** NobodyCam has quit IRC10:14
*** NobodyCam has joined #openstack-glance10:16
*** k_mouza has quit IRC10:26
*** ratailor_ has joined #openstack-glance10:26
*** k_mouza has joined #openstack-glance10:28
*** ratailor has quit IRC10:28
*** knikolla has quit IRC10:49
*** rcernin has joined #openstack-glance10:57
*** knikolla has joined #openstack-glance11:01
*** udesale has quit IRC11:05
*** udesale has joined #openstack-glance11:12
*** udesale has quit IRC11:29
*** trident has quit IRC11:31
*** udesale has joined #openstack-glance11:31
*** hoonetorg has quit IRC12:08
*** hoonetorg has joined #openstack-glance12:21
*** hoonetorg has quit IRC12:41
*** hoonetorg has joined #openstack-glance12:54
*** Luzi has joined #openstack-glance12:55
*** lpetrut has joined #openstack-glance12:57
*** trident has joined #openstack-glance13:02
*** ratailor_ has quit IRC13:18
dansmithrosmaita: this test fix is all that is holding up the race fix, if you have a chance to look soonish: https://review.opendev.org/#/c/747470/13:54
dansmithshould be pretty easy, just a retry on import in a functional test if we raced with revert13:54
rosmaitadansmith: looking13:54
rosmaitadansmith: LGTM13:56
dansmiththanks!13:56
*** gyee has joined #openstack-glance14:03
*** rcernin has quit IRC14:45
openstackgerritMerged openstack/glance_store master: Support Cinder multiple stores  https://review.opendev.org/74655615:06
* abhishekk dinner break15:21
*** belmoreira has quit IRC15:29
*** lpetrut has quit IRC15:32
jokkedansmith: anything you need from me before I start my pto?15:35
openstackgerritMerged openstack/glance master: Make test_copy_image_revert_lifecycle handle 409 on import retry  https://review.opendev.org/74747015:39
openstackgerritMerged openstack/glance master: Implement time-limited import locking  https://review.opendev.org/74359715:39
openstackgerritMerged openstack/glance_store stable/train: Add config for cinder mounting needs  https://review.opendev.org/72664815:40
openstackgerritMerged openstack/glance_store stable/train: Add lock per share for cinder nfs mount/umount  https://review.opendev.org/72665015:40
*** baojg has quit IRC15:41
*** baojg has joined #openstack-glance15:42
dansmithjokke: erm, not that I know of.. enjoy!16:09
*** udesale has quit IRC16:09
*** m75abrams has quit IRC16:17
*** k_mouza has quit IRC16:26
abhishekkdansmith, some failure on https://review.opendev.org/#/c/745566/916:30
dansmithabhishekk: unrelated to the patch, but that is a case of losing track of a child process16:31
dansmiththat wait_for_fork check was already in there, but would hang forever before my change to increase aggression16:32
dansmithso this would have been a TIMED_OUT before16:32
abhishekkack16:32
openstackgerritRajat Dhasmana proposed openstack/glance_store master: Correct default type name reference  https://review.opendev.org/74798416:33
abhishekkdansmith, looks like we will hit this failure frequently16:42
dansmithit's the first time I've seen it, are you seeing it elsewhere?16:43
abhishekkhttps://review.opendev.org/#/c/746746/16:44
dansmithwow, seems like something has changed recently16:46
dansmithI don't even see that in logstash, which lags behind reality quite a bit16:48
dansmithmy patch to make wait_for_fork not hang was merged Aug 12, which is almost two weeks ago16:49
abhishekkright16:49
dansmithhave you seen any of these older than today?16:50
openstackgerritRajat Dhasmana proposed openstack/glance_store master: Correct default type name reference  https://review.opendev.org/74798416:50
abhishekkdansmith, nope, I guess I saw it yesterday16:52
dansmithhrm16:53
dansmiththat's troubling16:53
dansmithnot really seeing anything on master that looks like it could be related16:53
dansmithit's odd that the one job there got hit several times16:54
abhishekkI saw it first on https://review.opendev.org/#/c/745566/916:54
abhishekkwhich I stated earlier16:54
abhishekkalso not able to reproduce it locally, I ran it 10-12 times now in local environment16:55
dansmithokay, hmm16:55
dansmithI wonder if something else in the job is killing workers, like because OOM or something16:55
abhishekkneed to check16:56
*** Luzi has quit IRC16:57
*** nikparasyr has left #openstack-glance17:13
dansmithabhishekk: so... I think these are tests where they start a worker and expect it to exit immediately(ish) is that right?17:26
dansmithat least the one I'm looking at maybe17:26
dansmithactually, it must be because it's in a "expect_exit==True" conditional17:27
*** ralonsoh has quit IRC17:27
dansmithso that should probably pass force=False, as maybe it's killing that process too quickly if the system is loaded17:28
abhishekkkind of expecting to exit immediately17:30
dansmithyeah,17:30
dansmithso in those cases if the CI worker is loaded and slow, it may not complete before the kill timer expires17:31
openstackgerritDan Smith proposed openstack/glance master: Disable wait_for_fork() kill aggression if expect_exit=True  https://review.opendev.org/74799117:32
dansmithwhich explains why we can't repro locally17:32
dansmithdoes that ^ make sense?17:32
abhishekkyes17:32
abhishekkdansmith, are you planning to work on backports of race condition patches?17:36
abhishekkit will be very large series of patches17:37
dansmithI dunno, do you think it's worth backporting all of that?17:37
abhishekki think so17:38
dansmithokay I guess I can start working on that and see how bad it is :)17:38
abhishekkack17:39
dansmithso,17:39
dansmithI'm sure we don't want to bring the patches for the policy stuff17:40
dansmithso maybe I can grab the wrapper stuff and then just fix up the patches between that and the actual lock part17:40
abhishekkPolicy stuff don't need to be backported17:40
dansmith*shouldn't* be.. since it's a feature17:41
abhishekkyes, shouldn't :)17:41
dansmithabhishekk: this is also probably legit to backport, which is at the start of it: https://review.opendev.org/#/c/737548/17:42
abhishekklooking17:42
abhishekkyes17:43
abhishekkits already backported17:43
abhishekkhttps://review.opendev.org/#/q/I385f222c5e3b46978b40bdefdc28fcb20d9c67d317:43
dansmithoh I looked but missed it I guess17:47
dansmithugh,17:48
dansmiththe backport of jokke's active image patch re-wrote without the action wrapper17:49
dansmithso that'll have to change17:49
abhishekklet me look17:49
abhishekkthis one https://review.opendev.org/#/c/745100/ ?17:51
dansmith74401017:52
dansmithoh yeah, that's the backport17:52
dansmithyep17:52
abhishekkright17:53
*** k_mouza has joined #openstack-glance17:53
*** baojg has quit IRC17:59
*** k_mouza has quit IRC18:02
* abhishekk signing out for the day18:29
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Add a test to replicate the owner-required behavior of copy-image  https://review.opendev.org/74799918:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Refactor common auth token code in images test  https://review.opendev.org/74800018:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Add a functional test for non-owned image copying  https://review.opendev.org/74800118:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Make import task capable of running as admin on behalf of user  https://review.opendev.org/74800218:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Make test_copy_image_revert_lifecycle handle 409 on import retry  https://review.opendev.org/74800318:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Add testing for _CompleteTask in api_image_import  https://review.opendev.org/74800418:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Add tests for _ImportToStore.execute()  https://review.opendev.org/74800518:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Flesh out FakeImage for extra_properties  https://review.opendev.org/74800618:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Add image_set_property_atomic() helper  https://review.opendev.org/74800718:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Add image_delete_property_atomic() helper  https://review.opendev.org/74800818:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Heartbeat the actual work of the task  https://review.opendev.org/74800918:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Update task message during import  https://review.opendev.org/74801018:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Functional reproducer for bug 1891352  https://review.opendev.org/74801118:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Fix import failure status reporting when all_stores_must_succeed=True  https://review.opendev.org/74801218:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Add context.elevated() helper for getting admin privileges  https://review.opendev.org/74801318:57
openstackbug 1891352 in Glance ussuri "Failed import of one store will remain in progress forever if all_stores_must_succeed=True" [Undecided,New] https://launchpad.net/bugs/1891352 - Assigned to Dan Smith (danms)18:57
openstackgerritDan Smith proposed openstack/glance stable/ussuri: Implement time-limited import locking  https://review.opendev.org/74801418:57
dansmithkaboom18:57
*** k_mouza has joined #openstack-glance20:13
*** k_mouza has quit IRC20:18
*** whoami-rajat__ has joined #openstack-glance20:33
whoami-rajat__jokke: hi, around?20:33
*** jmlowe has quit IRC20:51
*** jmlowe has joined #openstack-glance20:54
*** rcernin has joined #openstack-glance22:00
*** rcernin has quit IRC22:01
*** rcernin has joined #openstack-glance22:02
openstackgerritRajat Dhasmana proposed openstack/glance master: Support cinder multiple stores  https://review.opendev.org/74803922:10
openstackgerritRajat Dhasmana proposed openstack/glance master: Support cinder multiple stores  https://review.opendev.org/74803922:30
« Monday, 2020-08-24 Index Wednesday, 2020-08-26 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!