| *** gyee has quit IRC | 01:49 | |
| *** ratailor has joined #openstack-glance | 04:30 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-glance | 04:33 | |
| *** m75abrams has joined #openstack-glance | 05:21 | |
| *** belmoreira has joined #openstack-glance | 05:55 | |
| *** belmoreira has quit IRC | 05:55 | |
| *** belmoreira has joined #openstack-glance | 05:56 | |
| *** nikparasyr has joined #openstack-glance | 06:01 | |
| *** happyhemant has joined #openstack-glance | 06:28 | |
| *** rcernin has quit IRC | 07:02 | |
| *** rcernin has joined #openstack-glance | 07:03 | |
| *** lpetrut has joined #openstack-glance | 07:23 | |
| openstackgerrit | Merged openstack/glance master: zuul: use the new barbican simple-crypto job https://review.opendev.org/746582 | 07:24 |
|---|---|---|
| *** rosmaita has quit IRC | 07:49 | |
| *** rcernin has quit IRC | 08:34 | |
| *** priteau has joined #openstack-glance | 08:35 | |
| *** k_mouza has joined #openstack-glance | 08:55 | |
| * abhishekk will be back at 7 pm | 09:24 | |
| openstackgerrit | Luigi Toscano proposed openstack/glance_store master: DNM test a devstack-tox-functional change https://review.opendev.org/746669 | 09:30 |
| *** Luzi has joined #openstack-glance | 09:53 | |
| *** tkajinam has quit IRC | 09:58 | |
| *** rosmaita has joined #openstack-glance | 12:04 | |
| *** rosmaita has quit IRC | 12:04 | |
| *** rosmaita has joined #openstack-glance | 12:13 | |
| *** zzzeek has quit IRC | 12:19 | |
| *** zzzeek has joined #openstack-glance | 12:23 | |
| openstackgerrit | Erno Kuvaja proposed openstack/glance_store master: Ramp up rbd resize to avoid excessive calls https://review.opendev.org/746579 | 12:58 |
| *** priteau has quit IRC | 13:06 | |
| *** Luzi has quit IRC | 13:34 | |
| *** tkajinam has joined #openstack-glance | 13:50 | |
| *** k_mouza has quit IRC | 13:51 | |
| *** k_mouza has joined #openstack-glance | 13:53 | |
| *** jv_ has quit IRC | 13:54 | |
| *** rosmaita has quit IRC | 14:18 | |
| *** davee_ has joined #openstack-glance | 14:20 | |
| *** rosmaita has joined #openstack-glance | 14:22 | |
| *** davee_ has quit IRC | 14:22 | |
| openstackgerrit | Erno Kuvaja proposed openstack/glance-specs master: Optimize Ceph store network usage https://review.opendev.org/740980 | 14:39 |
| *** ratailor has quit IRC | 14:45 | |
| *** rosmaita has quit IRC | 14:47 | |
| *** lpetrut has quit IRC | 14:48 | |
| *** rosmaita has joined #openstack-glance | 14:51 | |
| abhishekk | just for FYI, tomorrow I will be on leave, need to take care of some personal work | 14:53 |
| *** nikparasyr has left #openstack-glance | 14:56 | |
| *** belmoreira has quit IRC | 14:57 | |
| *** priteau has joined #openstack-glance | 15:04 | |
| openstackgerrit | Dan Smith proposed openstack/glance master: Implement time-limited import locking https://review.opendev.org/743597 | 15:04 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Add functional test for task status updating https://review.opendev.org/745392 | 15:04 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Move SynchronousAPIBase to a generalized location https://review.opendev.org/745566 | 15:04 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Handle atomic image properties separately https://review.opendev.org/746518 | 15:04 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Functional test enhancement for lock busting https://review.opendev.org/746531 | 15:04 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Cleanup import status information after busting a lock https://review.opendev.org/746554 | 15:04 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Add FakeData generator test utility https://review.opendev.org/746746 | 15:04 |
| * abhishekk dinner break, will be back in 30 mins | 15:14 | |
| *** gyee has joined #openstack-glance | 15:16 | |
| *** lpetrut has joined #openstack-glance | 15:23 | |
| jokke | dansmith: you around? | 15:38 |
| dansmith | yup | 15:38 |
| dansmith | I have your patch in a tab, if that's what you're about to ask :) | 15:38 |
| jokke | So the rdb change in glance_store was that what you wanted? | 15:38 |
| jokke | Yeah ... it became really messy and hard to follow after doing the suggestions what you wanted. But if that's what's needed to get it in so be it | 15:39 |
| dansmith | jokke: honestly if you believe that why would you make the changes? | 15:40 |
| dansmith | I've just skimmed it and replied to abhishekk's comment, but I think characterizing the difference as "really messy and hard to follow" may be a little unfair | 15:41 |
| dansmith | but if you really feel that way, you should definitely revert back to what you had | 15:41 |
| jokke | Wanted to see if that was what you were after and to see that I got it working. Rather done once than leave it half way waiting you getting online and trying to explain how it turned out | 15:42 |
| jokke | ;) | 15:42 |
| jokke | gerrit is pretty easy tool to share different revisions | 15:42 |
| jokke | saved few lines of code, but now we are doing quite a bit of redundant assignments and it took me good while to explain abhishekk how it actually works and that it's functionally same as rev 2 just refactored into shape I understood from your comments | 15:44 |
| dansmith | lol, come on dude :) | 15:45 |
| jokke | so wanted to check with you if that was indeed what you were looking for or if I should keep the test changes and roll back the actual code (part from initializing the cariables) | 15:45 |
| dansmith | I totally don't understand how an if..elif block is less complicated to read than a single min() call, but if you guys think that it is you should totally revert back to what you had | 15:50 |
| abhishekk | yes, I was confused with the way self.resize_amount was calculated and found it bit easy to understand with earlier if/elif conditions until dan's comment about how we can avoid calculating that twice and use the min function more effectively | 15:56 |
| jokke | the if .. elif was just self explanary and did not reassign the value every execution after the cap had been reached. Similar with the if in L555 versus moving it inside the helper function needed extra parameters thrown in there just to make it noop vs. not calling it at all | 15:56 |
| abhishekk | also I was not sure the condition moved to helper was effective one, as earlier we were triggering resize based on that condition only | 15:57 |
| jokke | honestly I don't mind ... the outcome is the same either way. | 15:58 |
| *** m75abrams has quit IRC | 16:01 | |
| openstackgerrit | Erno Kuvaja proposed openstack/glance_store master: Ramp up rbd resize to avoid excessive calls https://review.opendev.org/746579 | 16:02 |
| openstackgerrit | Erno Kuvaja proposed openstack/glance_store master: Ramp up rbd resize to avoid excessive calls https://review.opendev.org/746579 | 16:05 |
| jokke | dansmith: also while I was figuring out the tests I found out that the FakeData iterator won't change the situation as mock will store the data in memory anyways (the call_args_list contains the arguments for the write, so moving it from the iterator to args list or creating it and storing to args list should have same footprint) | 16:09 |
| dansmith | jokke: AFAIK, the mock will store copies, which means not using a generator will store the original plus the copies, so you're getting on to a quarter gig by that point | 16:12 |
| jokke | kk | 16:17 |
| abhishekk | jokke, smcginnis https://review.opendev.org/#/c/745933/3 kindly look if you have time, this will unblock frequent py36-functional job failure | 16:19 |
| dansmith | gah, pep8 | 16:31 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Add FakeData generator test utility https://review.opendev.org/746746 | 16:34 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Add functional test for task status updating https://review.opendev.org/745392 | 16:34 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Move SynchronousAPIBase to a generalized location https://review.opendev.org/745566 | 16:34 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Handle atomic image properties separately https://review.opendev.org/746518 | 16:34 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Functional test enhancement for lock busting https://review.opendev.org/746531 | 16:34 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Cleanup import status information after busting a lock https://review.opendev.org/746554 | 16:34 |
| jokke | might not had to put the -2 on that patch, not sure but not blocking the change, just trying to stop the gate merging it :P | 16:49 |
| abhishekk | jokke, regarding that comment, I insisted dansmith to keep only failed store in the failed list as it might confuse the end_user that what went wrong as all the stores failed to import the data | 16:54 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Fix import failure status reporting when all_stores_must_succeed=True https://review.opendev.org/745933 | 16:56 |
| dansmith | new revision kicks it out of the gate immediately, otherwise you cause a full gate queue reset with just a -2 and penalize everybody that is waiting | 16:57 |
| openstackgerrit | Dan Smith proposed openstack/glance master: Poll for final state on test_copy_image_revert_lifecycle() https://review.opendev.org/745937 | 16:57 |
| jokke | dansmith: good point ... dropped the -2 ... sorry for the confusion there. I think we might have different idea of tracking progress and failue with abhishekk :( | 17:03 |
| *** k_mouza has quit IRC | 17:04 | |
| abhishekk | AFAIK -2 will not hold from the patch getting merged | 17:04 |
| dansmith | it will | 17:06 |
| dansmith | but only at the last minute, so it'll reset the whole gate at the last possible point, which means the most pain for all the people behind you in the queue | 17:06 |
| jokke | Left my note on the PS3 just send it back to gate if I understood the whole point wrong | 17:06 |
| abhishekk | ahh | 17:06 |
| *** lpetrut has quit IRC | 17:29 | |
| openstackgerrit | Merged openstack/glance master: Functional reproducer for bug 1891352 https://review.opendev.org/745932 | 17:58 |
| openstack | bug 1891352 in Glance "Failed import of one store will remain in progress forever if all_stores_must_succeed=True" [Undecided,In progress] https://launchpad.net/bugs/1891352 | 17:58 |
| * abhishekk signing out for the day | 18:21 | |
| *** k_mouza has joined #openstack-glance | 19:14 | |
| *** k_mouza has quit IRC | 19:17 | |
| *** priteau has quit IRC | 19:44 | |
| *** happyhemant has quit IRC | 20:11 | |
| *** keper7 has joined #openstack-glance | 20:48 | |
| *** rcernin has joined #openstack-glance | 21:18 | |
| *** rcernin has quit IRC | 21:35 | |
| *** rcernin has joined #openstack-glance | 21:52 | |
| *** rcernin has quit IRC | 21:57 | |
| *** rcernin has joined #openstack-glance | 22:08 | |
| *** rcernin has quit IRC | 22:09 | |
| openstackgerrit | Merged openstack/glance master: Fix import failure status reporting when all_stores_must_succeed=True https://review.opendev.org/745933 | 22:18 |
| openstackgerrit | Merged openstack/glance master: Poll for final state on test_copy_image_revert_lifecycle() https://review.opendev.org/745937 | 22:18 |
| *** rcernin has joined #openstack-glance | 22:33 | |
| *** knikolla has quit IRC | 22:43 | |
| *** knikolla has joined #openstack-glance | 22:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!