| *** brinzhang has joined #openstack-glance | 00:13 | |
| *** Liang__ has joined #openstack-glance | 01:11 | |
| *** ratailor has joined #openstack-glance | 03:56 | |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-glance | 04:36 | |
| *** belmoreira has joined #openstack-glance | 04:42 | |
| *** belmoreira has quit IRC | 04:46 | |
| *** udesale has joined #openstack-glance | 05:15 | |
| *** lpetrut has joined #openstack-glance | 06:41 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance_store stable/train: Fix: API returns 503 if one of the store is mis-configured https://review.opendev.org/726735 | 06:46 |
|---|---|---|
| *** belmoreira has joined #openstack-glance | 07:46 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/glance-specs master: Refactor and Imporve glance cinder store https://review.opendev.org/717756 | 08:01 |
| *** kukacz_ has joined #openstack-glance | 08:11 | |
| *** kukacz has quit IRC | 08:15 | |
| *** Ramereth has quit IRC | 08:15 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/glance_store master: Refactor Glance Cinder Store https://review.opendev.org/718361 | 08:48 |
| *** Liang__ has quit IRC | 09:30 | |
| *** priteau has joined #openstack-glance | 09:44 | |
| *** happyhemant has joined #openstack-glance | 10:15 | |
| *** priteau has quit IRC | 12:16 | |
| *** tkajinam has quit IRC | 12:31 | |
| *** rosmaita has joined #openstack-glance | 12:32 | |
| *** udesale_ has joined #openstack-glance | 13:06 | |
| *** udesale has quit IRC | 13:09 | |
| *** zzzeek has quit IRC | 13:25 | |
| *** zzzeek has joined #openstack-glance | 13:26 | |
| *** zzzeek has quit IRC | 13:26 | |
| *** zzzeek has joined #openstack-glance | 13:27 | |
| *** ratailor has quit IRC | 13:49 | |
| *** brinzhang_ has joined #openstack-glance | 13:58 | |
| *** brinzhang has quit IRC | 14:02 | |
| *** brinzhang has joined #openstack-glance | 14:02 | |
| *** brinzhang_ has quit IRC | 14:03 | |
| *** awalende has joined #openstack-glance | 14:06 | |
| abhishekk | rosmaita, hi, around? | 14:08 |
| rosmaita | abhishekk: hello | 14:08 |
| abhishekk | rosmaita, good morning | 14:09 |
| rosmaita | thanks, hope you had a good weekend | 14:09 |
| abhishekk | if you have some time could you please look at this backport, https://review.opendev.org/#/c/726735/ | 14:09 |
| abhishekk | rosmaita, yes, thank you | 14:09 |
| abhishekk | the backport is already merged in stable/ussuri and now open for train | 14:09 |
| *** brinzhang_ has joined #openstack-glance | 14:11 | |
| rosmaita | abhishekk: sure, i can do that now | 14:11 |
| abhishekk | rosmaita, thank you :D | 14:11 |
| rosmaita | abhishekk: comment about the commit message | 14:14 |
| *** brinzhang has quit IRC | 14:14 | |
| abhishekk | looking | 14:14 |
| abhishekk | ah, I cherry picked it from master I guess | 14:15 |
| abhishekk | should I abandon it and cherry pick from ussuri? | 14:16 |
| abhishekk | rosmaita, ? | 14:17 |
| * rosmaita is thinking | 14:17 | |
| smcginnis | abhishekk: I think if you redo it, it should get the same change ID. So do a new one, but you can update the existing review withouth abandoning it. | 14:17 |
| rosmaita | whatever smcginnis suggests is fine by me | 14:18 |
| abhishekk | ok, will update it | 14:18 |
| smcginnis | It would be good for tracing purposes to make sure that metadata is in the commit message. | 14:18 |
| abhishekk | smcginnis, thank you | 14:18 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance_store stable/train: Fix: API returns 503 if one of the store is mis-configured https://review.opendev.org/726735 | 14:19 |
| abhishekk | smcginnis, so both cherry pick commits should be there, right? | 14:22 |
| smcginnis | abhishekk: Yeah, ideally you just keep it all as you cherry pick back through branches. | 14:23 |
| abhishekk | smcginnis, updating immediately | 14:23 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance_store stable/train: Fix: API returns 503 if one of the store is mis-configured https://review.opendev.org/726735 | 14:24 |
| smcginnis | Thanks! | 14:24 |
| rosmaita | abhishekk: just out of curiosity, did you re-cherry pick or just change the commit message? | 14:25 |
| abhishekk | rosmaita, changed the commit message | 14:25 |
| *** lpetrut has quit IRC | 14:26 | |
| rosmaita | ok, i think that's fine because master and ussuri are practically the same at this point | 14:26 |
| abhishekk | rosmaita, I will ping you for approval once zuul gives nod | 14:26 |
| rosmaita | abhishekk: i will watch the patch and vote once it passes tests | 14:26 |
| abhishekk | thank you :D | 14:27 |
| rosmaita | yeah, i think it is getting late where you are | 14:27 |
| rosmaita | abhishekk: i am going to be a PITA again ... i think you have the order backwards for the cherry picks in the commit message | 14:29 |
| rosmaita | not sure it matters | 14:29 |
| rosmaita | i think the key thing is for both hashes to be there for searching the git log | 14:29 |
| abhishekk | rosmaita, should I try re-cherry pick for safer side? | 14:30 |
| rosmaita | i don't think it matters, there were no changes from master to ussuri, right? | 14:30 |
| abhishekk | nope | 14:30 |
| abhishekk | its clean backport from browser | 14:30 |
| rosmaita | yeah, you can just adjust the order in the commit message, but let's ask smcginnis first | 14:31 |
| rosmaita | i think the only reason to do it is most people expect that the most recent cherry-pick is listed last | 14:32 |
| abhishekk | Let me re-cherry pick again | 14:32 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance_store stable/train: Fix: API returns 503 if one of the store is mis-configured https://review.opendev.org/726735 | 14:33 |
| rosmaita | abhishekk: i didn't used to pay that much attention to this stuff, but we do a *lot* of backports in cinder, and it's really helpful in reviewing to have everything there | 14:33 |
| abhishekk | rosmaita, ack | 14:34 |
| rosmaita | abhishekk: looks great, i will keep an eye on it | 14:34 |
| rosmaita | luckily it's glance_store, so usually pretty fast through the gate | 14:34 |
| abhishekk | rosmaita, thank you, it should be around 3 hrs for both the gates | 14:34 |
| *** brinzhang_ has quit IRC | 14:40 | |
| smcginnis | rosmaita: Yeah, not sure it really matters. Important part is having that captured, but I do think it makes more sense in my brain to have them in order. | 14:43 |
| jokke_ | by quick look we literally have never included multipe cherry-picked from fields in backports | 14:49 |
| rosmaita | i am not surprised, like i said, i never really noticed until i started working on cinder | 14:50 |
| jokke_ | yeah, gerrit provides you comprehensive list of branches anyways | 14:53 |
| -openstackstatus- NOTICE: Our CI mirrors in OVH BHS1 and GRA1 regions were offline between 12:55 and 14:35 UTC, any failures there due to unreachable mirrors can safely be rechecked | 15:08 | |
| *** belmoreira has quit IRC | 15:21 | |
| *** belmoreira has joined #openstack-glance | 15:32 | |
| *** belmoreira has quit IRC | 15:34 | |
| *** gyee has joined #openstack-glance | 16:04 | |
| *** udesale_ has quit IRC | 16:34 | |
| abhishekk | rosmaita, around? | 16:36 |
| *** evrardjp has quit IRC | 16:36 | |
| *** evrardjp has joined #openstack-glance | 16:36 | |
| *** brinzhang has joined #openstack-glance | 16:37 | |
| abhishekk | smcginnis, could you please restore your +2 on backport patch https://review.opendev.org/726735 | 16:39 |
| abhishekk | thank you | 16:39 |
| abhishekk | jokke_, ^^^ if around | 16:39 |
| rosmaita | abhishekk: looking | 16:54 |
| rosmaita | abhishekk: got it | 16:55 |
| abhishekk | thank you | 16:56 |
| openstackgerrit | Cyril Roelandt proposed openstack/glance_store stable/ussuri: Add lock per share for cinder nfs mount/umount https://review.opendev.org/726914 | 17:44 |
| *** happyhemant has quit IRC | 18:05 | |
| openstackgerrit | Cyril Roelandt proposed openstack/glance_store stable/train: Add lock per share for cinder nfs mount/umount https://review.opendev.org/726650 | 18:15 |
| openstackgerrit | Merged openstack/glance_store stable/train: Fix: API returns 503 if one of the store is mis-configured https://review.opendev.org/726735 | 18:43 |
| *** brinzhang_ has joined #openstack-glance | 19:32 | |
| *** brinzhang has quit IRC | 19:35 | |
| abhishekk | signing out for the day | 19:37 |
| *** jmlowe has quit IRC | 19:42 | |
| *** jmlowe has joined #openstack-glance | 19:45 | |
| openstackgerrit | Cyril Roelandt proposed openstack/glance_store stable/ussuri: Add lock per share for cinder nfs mount/umount https://review.opendev.org/726914 | 20:42 |
| *** awalende has quit IRC | 21:05 | |
| *** awalende has joined #openstack-glance | 21:06 | |
| *** awalende has quit IRC | 21:10 | |
| *** brinzhang has joined #openstack-glance | 21:51 | |
| *** brinzhang_ has quit IRC | 21:54 | |
| *** tkajinam has joined #openstack-glance | 22:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!