Tuesday, 2020-04-07

*** brinzhang has quit IRC00:50
*** brinzhang has joined #openstack-glance00:51
*** gyee has quit IRC00:58
*** brinzhang_ has joined #openstack-glance00:59
*** brinzhang has quit IRC01:03
*** happyhemant has quit IRC01:08
*** Liang__ has joined #openstack-glance01:17
openstackgerritkayluu proposed openstack/glance master: Add recommendations on image schema customization docs  https://review.opendev.org/71788901:21
openstackgerritMerged openstack/glance master: Remove all references to sheepdog  https://review.opendev.org/70555804:05
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Fail gracefully when MD5 is unavailable  https://review.opendev.org/71794604:16
*** brinzhang has joined #openstack-glance04:36
*** evrardjp has quit IRC04:36
*** evrardjp has joined #openstack-glance04:37
*** brinzhang_ has quit IRC04:39
*** ratailor has joined #openstack-glance05:00
openstackgerritkayluu proposed openstack/glance master: Add warning and note on image schema customization docs  https://review.opendev.org/71788905:18
openstackgerritkayluu proposed openstack/glance master: Add warning and note on image schema customization docs  https://review.opendev.org/71788905:26
openstackgerritkayluu proposed openstack/glance master: Add warning and note on image schema customization docs  https://review.opendev.org/71788905:27
openstackgerritkayluu proposed openstack/glance master: Add warning and note on image schema customization docs  https://review.opendev.org/71788905:30
freefoodjokke_ when you do `tox -e docs`, do you get error of missing dependencies in requirements.txt (specifically `boto3` and `hacking`)?05:32
freefoodand looks like I'm having 2 pairs of remotes right now05:32
freefood$ git remote -v05:33
freefoodgerrit ssh://khashf@review.opendev.org:29418/openstack/glance.git (fetch)05:33
freefoodgerrit ssh://khashf@review.opendev.org:29418/openstack/glance.git (push)05:33
freefoodorigin ssh://khashf@review.opendev.org:29418/openstack/glance (fetch)05:33
freefoodorigin ssh://khashf@review.opendev.org:29418/openstack/glance (push)05:33
freefoodshould I delete the `origin` remote?05:33
*** brinzhang_ has joined #openstack-glance05:33
freefoodhmm when I look at what I was having on another machine, my `origin` has the `.git` suffix, but in my current machine, the `origin` remote doesn't05:35
*** brinzhang has quit IRC05:36
freefoodanother question: when my patch is approved but out-of-date with master, does rebase-ing then `git review` again (so my branch is up-to-date with master) invalidate the existing approvals on my patch?05:40
freefood(including Zuul's approval)05:40
*** udesale has joined #openstack-glance05:41
freefooddiablo_rojo: if jokke_ hasn't seen this, could you help me answer these questions?05:43
freefoodright now when I do a clean `tox --recreate -e docs` I get the following error (link below) which I described above05:47
freefoodhttps://pastebin.com/vQP3RFQr05:47
freefoodthen I added `boto3` and `hacking` to doc/requirements.txt the error is gone, and next error is05:49
freefoodglance/doc/source/contributor/api/glance.hacking.rst:document isn't included in any toctree05:49
*** abhishekk has joined #openstack-glance06:09
*** udesale has quit IRC06:09
freefoodI've narrowed down the cause, this commit is possible the cause: https://opendev.org/openstack/glance/commit/6d2c55bc769107207bd2a39059701b76ab27f2b006:11
freefoodhacking>=3.0,<3.1.0 should have been also added to doc/requirements.txt06:11
*** udesale has joined #openstack-glance06:13
freefoodadditionally, local `sphinx-build` may have also generated glance/doc/source/contributor/api/glance.hacking.rst06:16
*** ratailor has quit IRC06:40
*** ratailor has joined #openstack-glance06:47
*** gtema has joined #openstack-glance06:55
abhishekkfreefood, what is the context06:58
*** brinzhang has joined #openstack-glance07:56
*** brinzhang_ has quit IRC07:59
*** brinzhang_ has joined #openstack-glance08:05
*** gtema has left #openstack-glance08:08
*** brinzhang has quit IRC08:09
*** tkajinam has quit IRC08:17
*** priteau has joined #openstack-glance09:01
openstackgerritErno Kuvaja proposed openstack/glance master: Do not decompress 'compressed' containers  https://review.opendev.org/71800509:32
*** brinzhang has joined #openstack-glance09:36
*** brinzhang_ has quit IRC09:39
openstackgerritErno Kuvaja proposed openstack/glance master: Do not decompress 'compressed' containers  https://review.opendev.org/71800509:46
openstackgerritMerged openstack/python-glanceclient master: Add release note for glanceclient 3.0.0  https://review.opendev.org/71766710:05
*** Liang__ has quit IRC10:09
openstackgerritRajat Dhasmana proposed openstack/glance-specs master: Refactor and Imporve glance cinder store  https://review.opendev.org/71775610:12
abhishekksmcginnis, around?10:15
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Rename releasenotes to reflect correct version  https://review.opendev.org/71805010:27
openstackgerritMerged openstack/python-glanceclient master: Rename releasenotes to reflect correct version  https://review.opendev.org/71805010:46
smcginnisabhishekk: Now I am.11:09
abhishekksmcginnis, pushed release patch for glanceclient11:10
smcginnisabhishekk: Thanks, I saw that. Once the zuul jobs pass and I can take a look at that, we should be able to get that through right away.11:10
abhishekksmcginnis, thank you :D11:11
smcginnisThanks for getting it done ahead of the deadline. I wish more folks could do that. :)11:11
openstackgerritAbhishek Kekane proposed openstack/glance master: Ussuri final release notes  https://review.opendev.org/71767911:12
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Fail gracefully when MD5 is unavailable  https://review.opendev.org/71794611:34
*** rosmaita has quit IRC11:40
*** rosmaita has joined #openstack-glance11:42
*** gtema has joined #openstack-glance12:04
*** tkajinam has joined #openstack-glance12:08
openstackgerritJames Page proposed openstack/python-glanceclient master: Update test certificates to use strong signing  https://review.opendev.org/71809312:50
*** udesale_ has joined #openstack-glance13:03
*** udesale has quit IRC13:05
*** Luzi has joined #openstack-glance13:09
*** ratailor has quit IRC13:11
openstackgerritOpenStack Release Bot proposed openstack/python-glanceclient stable/ussuri: Update .gitreview for stable/ussuri  https://review.opendev.org/71810313:19
openstackgerritOpenStack Release Bot proposed openstack/python-glanceclient stable/ussuri: Update TOX/UPPER_CONSTRAINTS_FILE for stable/ussuri  https://review.opendev.org/71810413:19
openstackgerritOpenStack Release Bot proposed openstack/python-glanceclient master: Update master for stable/ussuri  https://review.opendev.org/71810513:19
*** gtema has quit IRC13:45
*** tkajinam has quit IRC14:03
*** tkajinam has joined #openstack-glance14:03
*** Luzi has quit IRC14:07
*** gtema has joined #openstack-glance14:12
*** gtema has quit IRC14:25
openstackgerritBrian Rosmaita proposed openstack/glance-specs master: Deprecate 'checksum' computation  https://review.opendev.org/70876114:25
*** priteau has quit IRC14:37
*** tkajinam has quit IRC14:42
*** rcernin has quit IRC15:13
openstackgerritBrian Rosmaita proposed openstack/glance master: Deprecate the 'checksum' image property  https://review.opendev.org/71814715:19
*** gyee has joined #openstack-glance15:31
*** udesale_ has quit IRC16:08
*** lpetrut has joined #openstack-glance16:27
*** brinzhang has quit IRC16:30
*** brinzhang has joined #openstack-glance16:31
*** evrardjp has quit IRC16:36
*** evrardjp has joined #openstack-glance16:37
*** lpetrut has quit IRC16:56
*** brinzhang_ has joined #openstack-glance17:51
*** brinzhang has quit IRC17:53
abhishekkrosmaita, around?17:59
rosmaitaabhishekk: hello17:59
abhishekkgood morning17:59
abhishekksaw your md5 patch for glanceclient17:59
abhishekkglanceclient version released 3.1.0 just few hours ago :(18:00
rosmaitayeah, i saw that18:01
abhishekkShould we tag another version?18:01
rosmaitaup to you ... might be worth having in ussuri18:01
rosmaitaspec still isn't approved, though18:01
abhishekksorry, it completely slipped out of my mind18:02
rosmaitanot a big deal18:02
abhishekkspecs looks good to me, we still have next week if it get approves then we can release new version18:02
freefoodabhishekk: I'm trying to build docs locally with `tox -e docs`18:23
abhishekkfreefood, and it is failing with some error related to hacking module not exist18:24
freefoodyes18:24
freefoodand I'm surprised because it's the master branch18:24
abhishekkI am just wondering why it is not failing in check/gate jobs18:24
freefoodexactly, I've been wondering that too18:24
freefoodcan you replicate this on your machine?18:25
abhishekkyes, its failing on my machine as well18:25
freefoodokay phew18:25
freefoodAs I said above, I suspect this particular commit cause this error18:25
freefoodhttps://opendev.org/openstack/glance/commit/6d2c55bc769107207bd2a39059701b76ab27f2b018:25
abhishekkI will spend some time tomorrow to understand the reason18:25
freefoodthis commit is made by Zuul. This looks like a routine job18:26
abhishekklikely18:26
freefoodIf I add `hacking` to doc/requirements.txt, the error resolves, then there's another one: "glance/doc/source/contributor/api/glance.hacking.rst is not added to source tree"18:27
freefoodThis tilted me to be more sure on the probable cause of 6d2c55bc769107207bd2a39059701b76ab27f2b018:27
abhishekkohh18:28
freefoodfor now, do you recommend me to let Zuul build do the building job and skip the local build for now?18:28
abhishekkfreefood, for time being yes18:28
freefoodThanks for your attention! :) :)18:28
abhishekkfreefood, no problem :D18:29
openstackgerritMerged openstack/python-glanceclient master: Update master for stable/ussuri  https://review.opendev.org/71810518:38
openstackgerritMerged openstack/python-glanceclient stable/ussuri: Update .gitreview for stable/ussuri  https://review.opendev.org/71810318:39
openstackgerritMerged openstack/python-glanceclient stable/ussuri: Update TOX/UPPER_CONSTRAINTS_FILE for stable/ussuri  https://review.opendev.org/71810418:40
freefoodthat feeling when you carefully crafted a looong bug report, then accidentally clicked on a link, then the drafting bug is destroyed :( :(18:51
freefoodI'll never draft directly on launchpad again :(18:51
abhishekk:D19:05
abhishekkI always use notepad first19:05
freefoodgmann told me to submit the same bug summary again and BOOM! My lost edit is resurrected!19:12
freefoodundocumented feature it is19:12
openstackgerritMerged openstack/glance master: Add Policy enforcement for several Metadata Definition delete APIs  https://review.opendev.org/58453019:29
abhishekkcool19:43
openstackgerritAbhishek Kekane proposed openstack/glance master: Add description of how to use S3 driver  https://review.opendev.org/71089419:46
abhishekkrebased patchset with master ^^19:47
freefoodabhishekk: When the patchset author rebase the patchset, does it invalidate the existing approvals/reviews of that patch?19:58
freefoodFor example, says you already approved my patch and I have all I need to merge the patch to master, however, someone else patch has been merged before me, so I have to rebase. Then, do I lose your approval after my rebase?19:59
freefood(meaning you have to review my new patchset of the patch and approve again?)20:00
freefoodor it depends on which lines the rebase touches?20:01
*** rcernin has joined #openstack-glance22:11
*** tkajinam has joined #openstack-glance22:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!