*** brinzhang has joined #openstack-glance | 00:24 | |
*** brinzhang has quit IRC | 00:32 | |
*** brinzhang has joined #openstack-glance | 01:00 | |
*** brinzhang has quit IRC | 01:05 | |
*** zhengMa has joined #openstack-glance | 01:42 | |
*** baojg has joined #openstack-glance | 02:03 | |
*** brinzhang has joined #openstack-glance | 02:08 | |
*** brinzhang_ has joined #openstack-glance | 02:09 | |
*** brinzhang_ has quit IRC | 02:10 | |
*** brinzhang_ has joined #openstack-glance | 02:10 | |
*** brinzhang_ has quit IRC | 02:11 | |
*** brinzhang_ has joined #openstack-glance | 02:12 | |
*** brinzhang has quit IRC | 02:13 | |
*** goldyfruit has joined #openstack-glance | 02:16 | |
*** goldyfruit has quit IRC | 02:24 | |
*** rcernin has quit IRC | 02:45 | |
*** rcernin has joined #openstack-glance | 02:47 | |
*** bhagyashris has joined #openstack-glance | 02:49 | |
*** m75abrams has joined #openstack-glance | 03:09 | |
*** udesale has joined #openstack-glance | 03:59 | |
*** brinzhang has joined #openstack-glance | 04:04 | |
*** brinzhang_ has quit IRC | 04:07 | |
*** abhishekk has joined #openstack-glance | 04:40 | |
*** AJaeger_ has joined #openstack-glance | 04:47 | |
AJaeger_ | glance cores, could you review https://review.opendev.org/672098 - a simple change for moved documentation, please? | 04:47 |
---|---|---|
*** davee_ has quit IRC | 05:03 | |
*** davee_ has joined #openstack-glance | 05:03 | |
*** Luzi has joined #openstack-glance | 05:06 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Change location metadata key 'backend' to 'store' https://review.opendev.org/658962 | 05:19 |
*** ratailor has joined #openstack-glance | 05:47 | |
*** ratailor_ has joined #openstack-glance | 05:50 | |
*** ratailor has quit IRC | 05:52 | |
AJaeger_ | thanks, abhishekk ! | 05:58 |
*** AJaeger_ has left #openstack-glance | 05:58 | |
*** AJaeger_ has quit IRC | 05:58 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: PoC: Add periodic job to prefecth images into cache https://review.opendev.org/672877 | 06:06 |
*** brinzhang_ has joined #openstack-glance | 06:16 | |
*** brinzhang has quit IRC | 06:19 | |
*** brinzhang_ has quit IRC | 06:28 | |
*** brinzhang has joined #openstack-glance | 07:05 | |
*** tesseract has joined #openstack-glance | 07:08 | |
*** rcernin has quit IRC | 07:11 | |
*** bhagyashris has quit IRC | 07:19 | |
*** pcaruana has joined #openstack-glance | 07:31 | |
*** lpetrut has joined #openstack-glance | 07:51 | |
*** zhengMa has quit IRC | 07:53 | |
openstackgerrit | Merged openstack/glance master: Update api-ref location https://review.opendev.org/672098 | 07:53 |
*** bhagyashris has joined #openstack-glance | 07:56 | |
*** zhengMa has joined #openstack-glance | 07:58 | |
*** abhishekk has quit IRC | 08:27 | |
*** tkajinam has quit IRC | 08:30 | |
*** abhishekk has joined #openstack-glance | 08:30 | |
*** zhengMa has quit IRC | 08:54 | |
*** lpetrut has quit IRC | 08:58 | |
*** tesseract has quit IRC | 08:58 | |
*** trident has quit IRC | 09:16 | |
*** trident has joined #openstack-glance | 09:17 | |
*** tesseract has joined #openstack-glance | 09:20 | |
*** altlogbot_2 has quit IRC | 09:24 | |
*** altlogbot_2 has joined #openstack-glance | 09:25 | |
*** m75abrams has quit IRC | 09:49 | |
*** bhagyashris has quit IRC | 10:02 | |
*** brinzhang_ has joined #openstack-glance | 10:27 | |
*** brinzhang has quit IRC | 10:30 | |
*** jawad_axd has joined #openstack-glance | 10:38 | |
*** lpetrut has joined #openstack-glance | 11:07 | |
*** abhishekk has quit IRC | 11:19 | |
*** udesale has quit IRC | 11:26 | |
*** abhishekk has joined #openstack-glance | 11:54 | |
abhishekk | rosmaita: good morning ./ | 11:54 |
abhishekk | Regarding your comment on location patch, do you want me to refactor the code? (Is that the only concern or you have anything else in mind) | 11:56 |
rosmaita | abhishekk: what do you think about the "autocorrect" behavior? | 12:04 |
*** mvkr has quit IRC | 12:22 | |
*** Conqueror has joined #openstack-glance | 12:31 | |
*** ratailor_ has quit IRC | 12:38 | |
abhishekk | For autocorrect behaviour, i can add one condition, if storeid preset in header then don't skip all stuff and if not present then identify it from the url | 12:39 |
abhishekk | rosmaita: ^^ | 12:39 |
rosmaita | abhishekk: identifying it from the url could still allow the possibility of no store_id (for example, a http:// URL but http store not configured)? | 12:42 |
abhishekk | In that case it will riase unknown scheme error IMO | 12:43 |
rosmaita | abhishekk: what patch has the most recent version of store_utils.get_store_id_from_uri() ... i thought I looked at one that would return None | 12:45 |
abhishekk | What I was saying, if user provide store while adding or relplacing locations in metadata then ignore the lazy update, just verify that store is valid or not and if not provided then identify the same, if None is returned from the store_utils.get_store_id_from_uri, then raise appropriate error i.e. 404? | 12:47 |
rosmaita | ok, that sounds correct (though maybe a 400) | 12:49 |
rosmaita | abhishekk: what do you think of not doing the lazy update at all on this patch? | 12:50 |
abhishekk | Ok, so just let it be as it is and then on list or show call store will get update in the metadata? | 12:51 |
rosmaita | check with jokke_ ... i guess my primary point is that if we do the lazy update in multiple places, we want it to be obvious, so maybe like calling a utility function named lazy_update_location_store_ids() | 12:53 |
abhishekk | I have came up with this approach after discussing with jokke_ | 12:54 |
rosmaita | ok, then I'd suggest moving it to a utility function | 12:54 |
abhishekk | Ok, i will do it once reached home or tomorrow morning my time | 12:55 |
rosmaita | abhishekk: yes, no rush | 12:57 |
abhishekk | Yep, thank you for review | 12:57 |
*** jawad_axd has quit IRC | 13:08 | |
*** jmlowe has joined #openstack-glance | 13:13 | |
*** mvkr has joined #openstack-glance | 13:20 | |
*** jdillaman has joined #openstack-glance | 13:23 | |
*** mvkr has quit IRC | 13:34 | |
*** mvkr has joined #openstack-glance | 13:47 | |
*** jmlowe has quit IRC | 14:08 | |
*** lpetrut has quit IRC | 14:39 | |
*** happyhemant has joined #openstack-glance | 14:42 | |
*** belmoreira has joined #openstack-glance | 14:51 | |
*** Luzi has quit IRC | 15:06 | |
*** udesale has joined #openstack-glance | 15:22 | |
*** gyee has joined #openstack-glance | 15:39 | |
*** udesale has quit IRC | 15:41 | |
*** udesale has joined #openstack-glance | 15:41 | |
*** mvkr has quit IRC | 16:01 | |
*** vishwanathj has quit IRC | 16:02 | |
*** belmoreira has quit IRC | 16:05 | |
*** goldyfruit has joined #openstack-glance | 16:13 | |
*** vishwanathj has joined #openstack-glance | 16:19 | |
*** tesseract has quit IRC | 16:28 | |
*** udesale has quit IRC | 16:57 | |
*** goldyfruit has quit IRC | 17:02 | |
*** happyhemant has quit IRC | 17:12 | |
*** vishwanathj has quit IRC | 17:21 | |
*** vishwanathj has joined #openstack-glance | 17:39 | |
*** trident has quit IRC | 17:47 | |
*** trident has joined #openstack-glance | 17:51 | |
*** goldyfruit has joined #openstack-glance | 17:59 | |
*** abhishekk has quit IRC | 18:44 | |
*** nsherry4 has joined #openstack-glance | 19:11 | |
nsherry4 | We're using glance's multibackend, and we're running into an error trying to share an image | 19:12 |
nsherry4 | Is this the right place to ask about that? | 19:12 |
*** nsherry4 has left #openstack-glance | 19:19 | |
*** goldyfruit has quit IRC | 19:37 | |
*** jmlowe has joined #openstack-glance | 19:57 | |
*** vishwanathj has quit IRC | 19:58 | |
*** vishwanathj has joined #openstack-glance | 20:06 | |
rosmaita | nsherry4: yes, this is the place, sorry I didn't notice your question until after you left | 20:08 |
*** belmoreira has joined #openstack-glance | 20:09 | |
*** jmlowe has quit IRC | 20:14 | |
*** goldyfruit has joined #openstack-glance | 20:16 | |
*** trident has quit IRC | 20:49 | |
*** trident has joined #openstack-glance | 20:52 | |
*** goldyfruit has quit IRC | 21:07 | |
*** belmoreira has quit IRC | 21:17 | |
*** baojg has quit IRC | 21:53 | |
*** mvkr has joined #openstack-glance | 22:06 | |
*** davee_ has quit IRC | 22:25 | |
*** davee_ has joined #openstack-glance | 22:26 | |
*** tkajinam has joined #openstack-glance | 22:54 | |
*** rcernin has joined #openstack-glance | 23:02 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!