*** gyee has quit IRC | 00:15 | |
*** Liang__ has joined #openstack-glance | 00:50 | |
*** brinzhang has joined #openstack-glance | 00:53 | |
*** awalende has joined #openstack-glance | 01:36 | |
*** awalende has quit IRC | 01:41 | |
*** markvoelker has joined #openstack-glance | 02:00 | |
*** markvoelker has quit IRC | 02:35 | |
*** irclogbot_2 has joined #openstack-glance | 03:01 | |
*** Liang__ has quit IRC | 03:05 | |
*** Liang__ has joined #openstack-glance | 03:12 | |
*** rcernin has quit IRC | 03:15 | |
*** nicolasbock has quit IRC | 03:25 | |
*** rcernin has joined #openstack-glance | 03:27 | |
*** markvoelker has joined #openstack-glance | 03:32 | |
*** Sravan has joined #openstack-glance | 03:49 | |
*** rcernin has quit IRC | 03:57 | |
*** rcernin has joined #openstack-glance | 04:01 | |
*** sdinescu has quit IRC | 04:02 | |
*** imacdonn_ has quit IRC | 04:04 | |
*** markvoelker has quit IRC | 04:04 | |
*** imacdonn_ has joined #openstack-glance | 04:04 | |
*** udesale has joined #openstack-glance | 04:13 | |
*** abhishekk has joined #openstack-glance | 04:23 | |
*** _d34dh0r53_ has joined #openstack-glance | 04:24 | |
*** Sravan has quit IRC | 04:33 | |
*** Sravan has joined #openstack-glance | 04:34 | |
*** Sravan has quit IRC | 04:42 | |
*** Sravan has joined #openstack-glance | 04:48 | |
*** tkajinam has quit IRC | 05:00 | |
*** markvoelker has joined #openstack-glance | 05:02 | |
*** tkajinam has joined #openstack-glance | 05:07 | |
*** Sravan has quit IRC | 05:11 | |
*** Sravan has joined #openstack-glance | 05:13 | |
*** Sravan has quit IRC | 05:23 | |
*** Luzi has joined #openstack-glance | 05:24 | |
*** markvoelker has quit IRC | 05:34 | |
*** lpetrut has joined #openstack-glance | 06:02 | |
*** markvoelker has joined #openstack-glance | 06:31 | |
*** bhagyashris has joined #openstack-glance | 06:35 | |
*** pcaruana has joined #openstack-glance | 06:41 | |
*** markvoelker has quit IRC | 07:05 | |
*** mnaser has quit IRC | 07:06 | |
*** mnaser has joined #openstack-glance | 07:06 | |
*** awalende has joined #openstack-glance | 07:15 | |
*** amoralej|off is now known as amoralej | 07:21 | |
*** S4r3n has joined #openstack-glance | 07:49 | |
*** markvoelker has joined #openstack-glance | 08:02 | |
*** awalende has quit IRC | 08:05 | |
*** awalende has joined #openstack-glance | 08:05 | |
*** awalende has quit IRC | 08:06 | |
*** awalende has joined #openstack-glance | 08:06 | |
*** amoralej is now known as amoralej|mtg | 08:13 | |
*** awalende has quit IRC | 08:27 | |
*** awalende has joined #openstack-glance | 08:28 | |
*** abhishekk has quit IRC | 08:28 | |
*** markvoelker has quit IRC | 08:34 | |
*** abhishekk has joined #openstack-glance | 08:38 | |
*** Liang__ has quit IRC | 09:07 | |
*** rcernin has quit IRC | 09:30 | |
*** markvoelker has joined #openstack-glance | 09:31 | |
*** sdinescu has joined #openstack-glance | 09:32 | |
*** bhagyashris has quit IRC | 09:53 | |
*** markvoelker has quit IRC | 10:04 | |
*** Sravan has joined #openstack-glance | 10:07 | |
*** Sravan has quit IRC | 10:11 | |
*** pcaruana has quit IRC | 10:31 | |
*** abhishekk has quit IRC | 10:34 | |
*** nicolasbock has joined #openstack-glance | 10:43 | |
*** amoralej|mtg is now known as amoralej | 10:49 | |
amoralej | may i get reviews on https://review.openstack.org/#/c/651337/? | 11:00 |
---|---|---|
*** markvoelker has joined #openstack-glance | 11:02 | |
*** udesale has quit IRC | 11:05 | |
*** mvkr has joined #openstack-glance | 11:23 | |
*** Liang__ has joined #openstack-glance | 11:25 | |
*** markvoelker has quit IRC | 11:35 | |
*** pcaruana has joined #openstack-glance | 11:36 | |
*** Luzi has quit IRC | 11:39 | |
*** brinzhang has quit IRC | 11:56 | |
*** dhellmann has left #openstack-glance | 12:10 | |
*** markvoelker has joined #openstack-glance | 12:11 | |
jokke_ | amoralej: almost done with my comments there | 12:44 |
jokke_ | amoralej: thanks for taking that. Let us know if you need help with those tests or if I missed something obvious on my comment | 12:46 |
*** timburke has quit IRC | 12:46 | |
rosmaita | i was just looking at that too | 12:46 |
*** timburke has joined #openstack-glance | 12:48 | |
*** awalende has quit IRC | 12:52 | |
*** awalende has joined #openstack-glance | 12:52 | |
*** awalende has quit IRC | 12:57 | |
*** awalende has joined #openstack-glance | 12:57 | |
*** awalende has quit IRC | 13:02 | |
openstackgerrit | Merged openstack/glance master: Separate out configuration tests https://review.openstack.org/645799 | 13:02 |
*** altlogbot_1 has joined #openstack-glance | 13:04 | |
rosmaita | jokke_: i didn't realize that the swiftclient didn't checksum the chunks itself, looks like that's only an option in the swiftclient shell | 13:07 |
rosmaita | i wonder whether we should be doing that | 13:07 |
jokke_ | rosmaita: I'm not exactly convinced that the benefit of it would overweight the additional calculation overhead. Like what are the odds that we after years suddenly start getting those errors that are not caught by the transport layer (and wy I'm saying suddenly is that we would have stumbled upon corrupt images by now if it happened) | 13:13 |
amoralej | jokke_, thanks for your review | 13:18 |
amoralej | jokke_, about the tests issue | 13:19 |
rosmaita | jokke_: agree | 13:20 |
*** awalende has joined #openstack-glance | 13:23 | |
*** tkajinam_ has joined #openstack-glance | 13:25 | |
*** tkajinam has quit IRC | 13:27 | |
*** awalende has quit IRC | 13:28 | |
*** altlogbot_1 has quit IRC | 13:32 | |
*** altlogbot_2 has joined #openstack-glance | 13:33 | |
*** d34dh0r53 has quit IRC | 13:35 | |
*** altlogbot_2 has quit IRC | 13:38 | |
*** altlogbot_3 has joined #openstack-glance | 13:39 | |
openstackgerrit | Alfredo Moralejo proposed openstack/glance_store master: Do not include ETag when puting manifest in chunked uploads https://review.openstack.org/651337 | 13:41 |
amoralej | jokke_, rosmaita ^ i'm not sure if i'm understanding the tests part correctly | 13:41 |
*** altlogbot_3 has quit IRC | 14:00 | |
*** lpetrut has quit IRC | 14:11 | |
rosmaita | amoralej: i left a comment on your patch | 14:12 |
rosmaita | amoralej: also, thanks for taking care of this | 14:14 |
amoralej | glad to help | 14:14 |
rosmaita | see if my comment makes sense, i think that's what erno's getting at | 14:14 |
amoralej | rosmaita, my doubt if it fixture_headers[fixture_key] are the headers of the call itself or the return | 14:15 |
amoralej | the response, i meant | 14:15 |
rosmaita | amoralej: i think the fixture_headers are supposed to be the fake response headers, or am i misunderstanding your question? | 14:23 |
amoralej | rosmaita, but real response headers do not include x-object-manifest | 14:25 |
amoralej | and in the fake it's including it | 14:25 |
*** altlogbot_0 has joined #openstack-glance | 14:26 | |
rosmaita | amoralej: ok, now i understand your point | 14:28 |
amoralej | rosmaita, this is taken from tcpdump http://paste.openstack.org/show/749242/ | 14:29 |
*** altlogbot_0 has quit IRC | 14:29 | |
*** altlogbot_3 has joined #openstack-glance | 14:30 | |
rosmaita | amoralej: i have a meeting now, will check back later | 14:31 |
amoralej | ok, thanks | 14:31 |
rosmaita | i believe the etag for a DLO is supposed to be the md5 hash of a string constructed of the md5 hashes of each of the DLO parts? is that why the etag is b0e6.... instead of d41d8... ? | 14:33 |
*** altlogbot_3 has quit IRC | 14:33 | |
rosmaita | i mean the etag for the DLO manifest | 14:33 |
amoralej | rosmaita, yes that 's the response etag | 14:47 |
*** altlogbot_2 has joined #openstack-glance | 14:48 | |
*** altlogbot_2 has quit IRC | 14:51 | |
*** altlogbot_1 has joined #openstack-glance | 14:52 | |
*** altlogbot_1 has quit IRC | 14:55 | |
*** altlogbot_3 has joined #openstack-glance | 14:59 | |
*** _alastor_ has quit IRC | 15:00 | |
*** S4r3n has quit IRC | 15:15 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance-specs master: Specify image size to avoid glance backend resize https://review.openstack.org/608400 | 15:18 |
*** _alastor_ has joined #openstack-glance | 15:37 | |
*** Sravan has joined #openstack-glance | 15:37 | |
*** Sravan has quit IRC | 15:43 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance-specs master: Specify image size to avoid glance backend resize https://review.openstack.org/608400 | 15:50 |
*** jmlowe has quit IRC | 16:11 | |
*** gyee has joined #openstack-glance | 16:15 | |
*** amoralej is now known as amoralej|off | 16:17 | |
*** Sravan has joined #openstack-glance | 16:39 | |
*** Sravan has quit IRC | 16:41 | |
*** Sravan has joined #openstack-glance | 16:47 | |
*** awalende has joined #openstack-glance | 16:53 | |
*** awalende has quit IRC | 16:57 | |
rosmaita | amoralej|off: sorry i missed you, just left a comment on your patch -- have a good weekend, talk to you next week | 17:08 |
*** Sravan has quit IRC | 17:28 | |
*** Sravan has joined #openstack-glance | 17:33 | |
*** imacdonn_ is now known as imacdonn | 18:08 | |
*** irclogbot_2 has quit IRC | 18:08 | |
*** irclogbot_2 has joined #openstack-glance | 18:10 | |
*** rchurch has joined #openstack-glance | 18:59 | |
*** rchurch_ has quit IRC | 19:01 | |
*** Sravan has quit IRC | 20:18 | |
*** pcaruana has quit IRC | 20:26 | |
*** Sravan has joined #openstack-glance | 20:46 | |
*** Sravan has quit IRC | 21:16 | |
openstackgerrit | Cyril Roelandt proposed openstack/glance_store master: Python3: Fix return type on CooperativeReader.read https://review.openstack.org/651941 | 21:18 |
*** Sravan has joined #openstack-glance | 21:20 | |
*** Sravan has quit IRC | 21:24 | |
*** Sravan has joined #openstack-glance | 21:24 | |
*** Sravan has quit IRC | 21:36 | |
*** Sravan has joined #openstack-glance | 21:39 | |
*** rosmaita has left #openstack-glance | 21:46 | |
*** itlinux has joined #openstack-glance | 22:06 | |
*** Sravan has quit IRC | 23:08 | |
*** Sravan has joined #openstack-glance | 23:10 | |
*** markvoelker has quit IRC | 23:14 | |
*** Sravan has quit IRC | 23:14 | |
*** nicolasbock has quit IRC | 23:30 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!