Friday, 2019-04-12

*** gyee has quit IRC00:15
*** Liang__ has joined #openstack-glance00:50
*** brinzhang has joined #openstack-glance00:53
*** awalende has joined #openstack-glance01:36
*** awalende has quit IRC01:41
*** markvoelker has joined #openstack-glance02:00
*** markvoelker has quit IRC02:35
*** irclogbot_2 has joined #openstack-glance03:01
*** Liang__ has quit IRC03:05
*** Liang__ has joined #openstack-glance03:12
*** rcernin has quit IRC03:15
*** nicolasbock has quit IRC03:25
*** rcernin has joined #openstack-glance03:27
*** markvoelker has joined #openstack-glance03:32
*** Sravan has joined #openstack-glance03:49
*** rcernin has quit IRC03:57
*** rcernin has joined #openstack-glance04:01
*** sdinescu has quit IRC04:02
*** imacdonn_ has quit IRC04:04
*** markvoelker has quit IRC04:04
*** imacdonn_ has joined #openstack-glance04:04
*** udesale has joined #openstack-glance04:13
*** abhishekk has joined #openstack-glance04:23
*** _d34dh0r53_ has joined #openstack-glance04:24
*** Sravan has quit IRC04:33
*** Sravan has joined #openstack-glance04:34
*** Sravan has quit IRC04:42
*** Sravan has joined #openstack-glance04:48
*** tkajinam has quit IRC05:00
*** markvoelker has joined #openstack-glance05:02
*** tkajinam has joined #openstack-glance05:07
*** Sravan has quit IRC05:11
*** Sravan has joined #openstack-glance05:13
*** Sravan has quit IRC05:23
*** Luzi has joined #openstack-glance05:24
*** markvoelker has quit IRC05:34
*** lpetrut has joined #openstack-glance06:02
*** markvoelker has joined #openstack-glance06:31
*** bhagyashris has joined #openstack-glance06:35
*** pcaruana has joined #openstack-glance06:41
*** markvoelker has quit IRC07:05
*** mnaser has quit IRC07:06
*** mnaser has joined #openstack-glance07:06
*** awalende has joined #openstack-glance07:15
*** amoralej|off is now known as amoralej07:21
*** S4r3n has joined #openstack-glance07:49
*** markvoelker has joined #openstack-glance08:02
*** awalende has quit IRC08:05
*** awalende has joined #openstack-glance08:05
*** awalende has quit IRC08:06
*** awalende has joined #openstack-glance08:06
*** amoralej is now known as amoralej|mtg08:13
*** awalende has quit IRC08:27
*** awalende has joined #openstack-glance08:28
*** abhishekk has quit IRC08:28
*** markvoelker has quit IRC08:34
*** abhishekk has joined #openstack-glance08:38
*** Liang__ has quit IRC09:07
*** rcernin has quit IRC09:30
*** markvoelker has joined #openstack-glance09:31
*** sdinescu has joined #openstack-glance09:32
*** bhagyashris has quit IRC09:53
*** markvoelker has quit IRC10:04
*** Sravan has joined #openstack-glance10:07
*** Sravan has quit IRC10:11
*** pcaruana has quit IRC10:31
*** abhishekk has quit IRC10:34
*** nicolasbock has joined #openstack-glance10:43
*** amoralej|mtg is now known as amoralej10:49
amoralejmay i get reviews on https://review.openstack.org/#/c/651337/?11:00
*** markvoelker has joined #openstack-glance11:02
*** udesale has quit IRC11:05
*** mvkr has joined #openstack-glance11:23
*** Liang__ has joined #openstack-glance11:25
*** markvoelker has quit IRC11:35
*** pcaruana has joined #openstack-glance11:36
*** Luzi has quit IRC11:39
*** brinzhang has quit IRC11:56
*** dhellmann has left #openstack-glance12:10
*** markvoelker has joined #openstack-glance12:11
jokke_amoralej: almost done with my comments there12:44
jokke_amoralej: thanks for taking that. Let us know if you need help with those tests or if I missed something obvious on my comment12:46
*** timburke has quit IRC12:46
rosmaitai was just looking at that too12:46
*** timburke has joined #openstack-glance12:48
*** awalende has quit IRC12:52
*** awalende has joined #openstack-glance12:52
*** awalende has quit IRC12:57
*** awalende has joined #openstack-glance12:57
*** awalende has quit IRC13:02
openstackgerritMerged openstack/glance master: Separate out configuration tests  https://review.openstack.org/64579913:02
*** altlogbot_1 has joined #openstack-glance13:04
rosmaitajokke_: i didn't realize that the swiftclient didn't checksum the chunks itself, looks like that's only an option in the swiftclient shell13:07
rosmaitai wonder whether we should be doing that13:07
jokke_rosmaita: I'm not exactly convinced that the benefit of it would overweight the additional calculation overhead. Like what are the odds that we after years suddenly start getting those errors that are not caught by the transport layer (and wy I'm saying suddenly is that we would have stumbled upon corrupt images by now if it happened)13:13
amoralejjokke_, thanks for your review13:18
amoralejjokke_, about the tests issue13:19
rosmaitajokke_: agree13:20
*** awalende has joined #openstack-glance13:23
*** tkajinam_ has joined #openstack-glance13:25
*** tkajinam has quit IRC13:27
*** awalende has quit IRC13:28
*** altlogbot_1 has quit IRC13:32
*** altlogbot_2 has joined #openstack-glance13:33
*** d34dh0r53 has quit IRC13:35
*** altlogbot_2 has quit IRC13:38
*** altlogbot_3 has joined #openstack-glance13:39
openstackgerritAlfredo Moralejo proposed openstack/glance_store master: Do not include ETag when puting manifest in chunked uploads  https://review.openstack.org/65133713:41
amoralejjokke_, rosmaita ^ i'm not sure if i'm understanding the tests part correctly13:41
*** altlogbot_3 has quit IRC14:00
*** lpetrut has quit IRC14:11
rosmaitaamoralej: i left a comment on your patch14:12
rosmaitaamoralej: also, thanks for taking care of this14:14
amoralejglad to help14:14
rosmaitasee if my comment makes sense, i think that's what erno's getting at14:14
amoralejrosmaita, my doubt if it fixture_headers[fixture_key] are the headers of the call itself or the return14:15
amoralejthe response, i meant14:15
rosmaitaamoralej: i think the fixture_headers are supposed to be the fake response headers, or am i misunderstanding your question?14:23
amoralejrosmaita, but real response headers do not include x-object-manifest14:25
amoralejand in the fake it's including it14:25
*** altlogbot_0 has joined #openstack-glance14:26
rosmaitaamoralej: ok, now i understand your point14:28
amoralejrosmaita, this is taken from tcpdump http://paste.openstack.org/show/749242/14:29
*** altlogbot_0 has quit IRC14:29
*** altlogbot_3 has joined #openstack-glance14:30
rosmaitaamoralej: i have a meeting now, will check back later14:31
amoralejok, thanks14:31
rosmaitai believe the etag for a DLO is supposed to be the md5 hash of a string constructed of the md5 hashes of each of the DLO parts? is that why the etag is b0e6.... instead of d41d8... ?14:33
*** altlogbot_3 has quit IRC14:33
rosmaitai mean the etag for the DLO manifest14:33
amoralejrosmaita, yes that 's the response etag14:47
*** altlogbot_2 has joined #openstack-glance14:48
*** altlogbot_2 has quit IRC14:51
*** altlogbot_1 has joined #openstack-glance14:52
*** altlogbot_1 has quit IRC14:55
*** altlogbot_3 has joined #openstack-glance14:59
*** _alastor_ has quit IRC15:00
*** S4r3n has quit IRC15:15
openstackgerritBrian Rosmaita proposed openstack/glance-specs master: Specify image size to avoid glance backend resize  https://review.openstack.org/60840015:18
*** _alastor_ has joined #openstack-glance15:37
*** Sravan has joined #openstack-glance15:37
*** Sravan has quit IRC15:43
openstackgerritBrian Rosmaita proposed openstack/glance-specs master: Specify image size to avoid glance backend resize  https://review.openstack.org/60840015:50
*** jmlowe has quit IRC16:11
*** gyee has joined #openstack-glance16:15
*** amoralej is now known as amoralej|off16:17
*** Sravan has joined #openstack-glance16:39
*** Sravan has quit IRC16:41
*** Sravan has joined #openstack-glance16:47
*** awalende has joined #openstack-glance16:53
*** awalende has quit IRC16:57
rosmaitaamoralej|off: sorry i missed you, just left a comment on your patch -- have a good weekend, talk to you next week17:08
*** Sravan has quit IRC17:28
*** Sravan has joined #openstack-glance17:33
*** imacdonn_ is now known as imacdonn18:08
*** irclogbot_2 has quit IRC18:08
*** irclogbot_2 has joined #openstack-glance18:10
*** rchurch has joined #openstack-glance18:59
*** rchurch_ has quit IRC19:01
*** Sravan has quit IRC20:18
*** pcaruana has quit IRC20:26
*** Sravan has joined #openstack-glance20:46
*** Sravan has quit IRC21:16
openstackgerritCyril Roelandt proposed openstack/glance_store master: Python3: Fix return type on CooperativeReader.read  https://review.openstack.org/65194121:18
*** Sravan has joined #openstack-glance21:20
*** Sravan has quit IRC21:24
*** Sravan has joined #openstack-glance21:24
*** Sravan has quit IRC21:36
*** Sravan has joined #openstack-glance21:39
*** rosmaita has left #openstack-glance21:46
*** itlinux has joined #openstack-glance22:06
*** Sravan has quit IRC23:08
*** Sravan has joined #openstack-glance23:10
*** markvoelker has quit IRC23:14
*** Sravan has quit IRC23:14
*** nicolasbock has quit IRC23:30

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!